[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21177|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21838
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21838&action=edit
[PASSED QA][3.12.x] Bug 10648 - In records merge greatest field can not be
added

When merging 2 records (/cgi-bin/koha/cataloguing/merge.pl),
the destination record is build using the fields and subfields
checked in source records.
When a field is checked, the javascript code searches in
destination record a field with a greater tag number to insert
new field before.
When the new field tag number is greater than all existing field
tag numbers, the field is not added.

This patch corrects this by adding at end if no greater field tag
number exists. Also adds a sort of fields by tag number because
all merge code is based on this.

Test plan :
- Add to a framework a repeatable field with the greates non
  existing tag number. For example 998.
- Edit to records with this framework and add them a value in this
  tag.
- Put those records is a list
- Go to this list and check the two records
- Click on "Merge selected"
- Click on next
- Go to second source record
- Click on the greatest tag number. for example 998.
=> The field is added at the end of destination record

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All tests and QA script pass. Fixed some tabs.
Could reproduce the behaviour by defining a 999$z subfield.
After the patch it works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.