[Koha-bugs] [Bug 11016] New: Move SQL query from acqui/spent.pl to C4/Acquisitions.pm ?

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Oct 8 10:50:44 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11016

            Bug ID: 11016
           Summary: Move SQL query from acqui/spent.pl to
                    C4/Acquisitions.pm ?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

I'm surprised to see a big SQL query in acqui/spent.pl.
Is not that kind of stuff supposed to be rather in C4/Aquisitions.pm ?

my $query = <<EOQ;
SELECT
    aqorders.basketno, aqorders.ordernumber,
    quantity-quantityreceived AS tleft,
    ecost, budgetdate, entrydate,
    aqbasket.booksellerid,
    itype,
    title,
    aqorders.invoiceid,
    aqinvoices.invoicenumber,
    quantityreceived,
    unitprice,
    datereceived,
    aqorders.biblionumber
FROM (aqorders, aqbasket)
LEFT JOIN biblio ON
    biblio.biblionumber=aqorders.biblionumber
LEFT JOIN items ON
    biblio.biblionumber = items.biblionumber
LEFT JOIN aqorders_items ON
     items.itemnumber = aqorders_items.itemnumber
LEFT JOIN aqinvoices ON
    aqorders.invoiceid = aqinvoices.invoiceid
WHERE
    aqorders.ordernumber=aqorders_items.ordernumber AND
    aqorders.basketno=aqbasket.basketno AND
    budget_id=? AND
    (datecancellationprinted IS NULL OR
        datecancellationprinted='0000-00-00')
    GROUP BY aqorders.ordernumber
EOQ



M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list