[Koha-bugs] [Bug 11013] Tests broken by new crypto stuff

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Oct 8 13:02:15 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21867|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21873
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21873&action=edit
[SIGNED-OFF] Bug 11013 - move hashing functions into their own module

As the hashing functions were centralised into C4::Auth, this required
more modules (C4::Members in particular) to use it. However, C4::Auth
uses the database, and so anything that used C4::Members failed to load
in the 00-load.t test. This patch moves the hashing into its own small
module so this isn't an issue.

Test plan:
* Ensure that password related functions work:
** Creating a user account
** Logging in
** Changing a password (OPAC and staff client)
** LDAP logins still work like they should
* Ensure that tests pass without a database server present

Note: there are testing notes for LDAP on bug 9611 that'll bypass the
need to set up an LDAP server.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All Works. No koha-qa errors

Test
1) patch applied
2) new user created
3) change pass from opac/staff
4) change pass using LDAP (sort of, same as on Bug 9611)

NOTE: Robin, you just sent an email about copyright headers,
KohaPassword.pm's reads "...either version 2 of the License,...",
coding guidelines suggests other wording and version 3 of GPL.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list