[Koha-bugs] [Bug 11032] New: Validate passed records in Biblio.pm

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Oct 10 12:32:15 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11032

            Bug ID: 11032
           Summary: Validate passed records in Biblio.pm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: gmcharlt at gmail.com
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

We've all seen Biblio.pm giving the error 'can't call method fields on an
undefined value' for various reasons. They usually cause confusion or panic as
a low level error gets thrown at the user with no apparent relation to their
current operation. The problem is that many of Biblio's routines are rather
optimistically written so that it thinks you've passed a MARC::Record object
you have and it assumes that nothing could every go wrong in this best of all
possible worlds.

Routines should at least check they have a defined record before trying to
process it, and should log a stack trace so that the cause can be determined in
the case of the error.

Merely passing a low level error to the end user is non-productive.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list