[Koha-bugs] [Bug 11045] Wrong query in C4/Biblios.pm : join between biblioitems.itemtypes and itemtypes table

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Jared Camins-Esakov from comment #1)
> (In reply to mathieu saby from comment #0)
> > C4::Biblios::GetBiblioData and GetBiblioItemData are doing : 
> > SELECT [...] itemtypes.notforloan  [...]
> > [...]
> > LEFT JOIN itemtypes ON biblioitems.itemtype = itemtypes.itemtype
> > 
> > This is wrong becaause itemtypes table could be linked with items.itype (as
> > in my library) and not with biblioitems.itemtype.
> 
> Actually, I think this is correct, since this is for biblio-level item
> types, rather than item-level, which are treated elsewhere. You toggle
> between the two with the item-level_itypes syspref.

In my library, I have 'LIVRE' (book), 'REVUE' etc. in biblioitems.itemtypes.
I have "DPN", "DPL" (normal/long check out length) etc in items.itype
We have "DPN","DPL" etc itemtypes table 
We use item level type for issuing rules.

So when these subs are making a JOIN between biblioitems.itemtype and
itemtypes.itemtype, it means trying to join "LIVRE,REVUE" and "DPN,DPL" etc.
So it will never get anything.

What I was wondering is : is Koha's code calling this sub supposing that some
value should always be retreived from the join, and using these values for some
purpose ?
If it is not the case, that's not an issue. But I was not sure...

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.