[Koha-bugs] [Bug 11051] Performance of opac-search

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

--- Comment #4 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21990
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21990&action=edit
Bug 11051 - remove caching of GetMarcStructure

Profiling suggests that this is actually ~1s slower with caching
enabled, probably due to serialisation overheads.

Compare uncached:
http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-XSLT-pm-1282-line.html#78

to cached:
http://debian.koha-community.org/~robin/opac-search-cached/nytprof/usr-share-koha-lib-C4-XSLT-pm-1320-line.html#78

Test plan (please do this, more data points are good):
* set up an instance with memcache available but not used
* run the profiler on it
* enable the use of memcache
* run the profiler on it, note that the caching is being used and the
  code runs slower.
* apply the patch
* run the profiler again with memcache, note that the caching is not being used
and
  things are back to being speedy.

A quick primer to using the profiler:
* apt-get install libdevel-nytprof-perl
* sudo -u library-koha env MEMCACHED_SERVERS=localhost:11211
MEMCACHED_NAMESPACE=library-koha-opac
KOHA_CONF=/etc/koha/sites/library/koha-conf.xml PERL5LIB=/usr/share/koha/lib
SERVER_PORT=80 perl -d:NYTProf /usr/share/koha/opac/cgi-bin/opac/opac-search.pl
'q=a'
* this will create nytprof.out in the current dir (use /tmp)
* run nytprofhtml to produce HTML output.
* remove/include the MEMCACHED variables to turn caching on/off
  globally.

-- 
You are receiving this mail because:
You are watching all bug changes.