[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 16 13:43:20 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #30 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Comment 27 is misleading you cant use a string as a hash_ref in any release of
perl.

A variable called $results suggests theres a bit of confusion here. Meaningless
variable names should be avoided, and we should be more explicit as to what we
are testing.

Another reason for failing QA is that a lexical dirhandle is replaced by the
global DIR. That's surely a backward move

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list