[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #26 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22016
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22016&action=edit
Bug 7376 - Transfer limits should be checked at check-in

Extended UseBranchTransferLimits-check to the check-in case.
Made it possible to override the check-in with circulation-permission if
BranchTransfer is denied.
Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t

*Also added override-functionality to Circulation::AddReturn() to override
BranchTransferLimits. (+unit tests)
*Renamed CanBookBeReturned to CanItemBeReturned since that function was
referenced from AddReturn only.
--This is because function name misguidingly references to a
book/Biblio/Title-level, even if the functionality is strictly
--Item dependent.
*Removed duplicating code by making CheckBranchTransferAllowed() call
IsBranchTransferAllowed().
*Made a unit test library out of CheckBranchTransferAllowed.t's environment
initialization parts,
  so these need not be duplicated whenever UseBranchTransferLimits-related
functionality is tested.
*Documented SIP-testing hardships to C4/SIP/README

-- 
You are receiving this mail because:
You are watching all bug changes.