[Koha-bugs] [Bug 11077] Uninitialized value $pki_field warning

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Actually, I was thinking about this annoying problem too, and that's not how I
was thinking of solving it.

Around line 774 the $pki_field is defined and set as part of an if statement,
but because it can be short-circuited, the variable is sometimes not defined.

I would suggest that the solution is to put:
my $pki_field = C4::Context->preference('AllowPKIAuth') || q{};
before the if statement.
AND
change the if statement to be
... || $pki_field ne 'None' ...

This way $pki_field is defined, and string comparisons shouldn't generate
silent errors.

I'm switching this to in discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.