[Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Oct 21 02:05:12 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22131|0                           |1
        is obsolete|                            |
  Attachment #22132|0                           |1
        is obsolete|                            |

--- Comment #14 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22140
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22140&action=edit
[PASSED-QA] Bug 10016: force zero browser-side caching of SCO pages

This patch makes the web-based self-check module pages
specify that no browser (or proxy caching) occur at all.
This prevents a security issue where letting the SCO session time out,
then hitting the back button allowed one to view the previous
patron's session.

This patch adds an optional fifth parameter to output_with_http_headers(),
and output_html_with_http_headers(), a hashref for miscellaneous
options.  One key is defined at the moment: force_no_caching, which if
if present and set to a true value, sets HTTP headers to specify no
browser caching of the page at all.

To test:

[1] Start a web-based self-check session and optionally perform
    some transactions.
[2] Allow the session to time out (it may be helpful to set
    SelfCheckTimeout to a low value such as 10 seconds).
[3] Hit the back button.  You should not see the previous patron's
    self-check session.
[4] Verify that prove -v t/Output.t passes.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list