[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #43 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment: nice patch, but one question: why did you put 
+            ( $subfield_value ) = $subfield_value =~ m/(\d[\d\,\. ]*\d{0,2})/;
+            # remove comma,dot or space when used as separators from hundreds
+            $subfield_value =~s/[\,\. ](\d{3})/$1/g;
+            # convert comma to dot to ensure correct display of decimals if
existing
+            $subfield_value =~s/,/./;

outside from MungeMarcPrice, it should be here as well, because it's related to
discovering & retrieving the price from the MARC field
So I think it should go here

Otherwise :
 * great regexp description !
 * patch does not apply anymore due to updatedatabase changes

Failing QA, answer my question 1, provide an updated patch if my point is
relevant and switch back to signed off

-- 
You are receiving this mail because:
You are watching all bug changes.