[Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments:
 * 4 spaces instead of tabs, please
 * I think the sub CheckBranchTransferAllowed should be named
CanBookBeTransferred, that would be more consistent with ...BeIssued and
...BeRenewed (and also C4/Reserves.pm::CanBookBeReserved
 * there's an unconditional warn:
             warn "NotAllowed: $messages->{'NotAllowed'} to  " . $branches->{
$messages->{'NotAllowed'} }->{'branchname'};
=> please add a condition:
   warn ... if $ENV{DEBUG}

 * +1 for .t, looks great ! Note that it's MARC21 specific, I think you
could/should skip some tests if systempreference("marcflavour") eq "UNIMARC"

-- 
You are receiving this mail because:
You are watching all bug changes.