[Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 23 17:07:48 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
I noticed that a function call to the refund was commented out in C4::Accounts,
having not even read the patch. I did a:
   git blame -L440,450 C4/Accounts.pm
to discover that the commit in question was likely done in 2008. So, the second
and third blocks displayed in the patches "Diff" have about 5 years old. I
don't see a problem with them.

I went brute force and did a:
   grep fixcredit `find .`
And the only code found was C4::Accounts. This included: the commented line,
two POD lines, and the function definition line. I see no reason not to remove
fixcredit.

When I did the same for refund, it was messier, so I hoped that the git grep
provided was cleaner. It basically was the same thing, except piped to less. 

C4::Accounts has 3 lines related to the deprecated function refund. I ignored
the blib and po results. There were unrelated results in the stats.screen.pl,
sysprefs.sql, updatedatabase.pl, and various template files. As far as I can
see, there is nothing using the refund function in C4::Accounts.

There is only one reference to reconcileaccount, which is the line that is
exporting it. That makes no sense, so I see no reason to prevent removal.

In short, this patch is good.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list