[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #32 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to Olli-Antti Kivilahti from comment #30)
> "mmm... this patch has been set to "failed QA" by Aix-Marseille university,
> and a new patch has been attached. Shouldn't the status be reset to "need
> signoff" ? Otherwise, explanation welcomed !" -PP
> 
> It should. I noticed this as well but I decided to leave it as is, since
> someone had already signed this bug off. I knew it wasn't exactly a nice
> thing and was kinda hoping to skip the sign-off part.
> Obviously my behaviour was not very nice. Apologies for the misconduct.
I didn't spot any misconduct, but as long as a patch is "failed QA" no one
takes care of it, except the patch author. So if you submit a new patch, then
you need to change the status.

When a failed QA is caused by a small/minor QA problem, like an indent one,
then, it's OK to switch back to "signed off" if the patch has already been
signed off. Otherwise, back to "need signoff". But not let "failed QA" status
as it is.

-- 
You are receiving this mail because:
You are watching all bug changes.