[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robin at catalyst.net.nz

--- Comment #9 from Robin Sheat <robin at catalyst.net.nz> ---
Oh good, I've been meaning to do this for a while.

A few comments:
* it creates /var/lock/koha_rebuild_zebra_databasename/lock, why not
/var/lock/koha/rebuild_zebra_databasename? That way if we add more locking
stuff, it will all be under the 'koha' directory.
* it doesn't look like it handles lockdir not being set in the config very
nicely, it should probably default to /var/lock if the config setting isn't
available, otherwise it seems it would try to create a directory under '/'.
* it doesn't set up the lockdir config for package installations, this would be
a very simple matter of adding <lockdir>/var/lock</lockdir> in
debian/templates/koha-conf-site.xml.in. It's OK to hard-code the value in there
because it'll always be the same.

-- 
You are receiving this mail because:
You are watching all bug changes.