[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #12 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Doug Kingston from comment #10)
> The existing koha scripts that create koha instances call
>   install -d -o $kohauser -g $kohauser /var/lock/koha/$kohasite
> When invoked this way, only the last directory in this path is owned
> by the user and the intervening directories are owned by root. 
> rebuild_zebra.pl
> is run as $kohauser so it cannot create another directory under
> /var/lock/koha.

Yeah, I just checked and found that. In that case, it might be best to use that
pattern? If it's only applicable to a package installation, it is something we
could put in just for that case without too much difficulty.

> My changes make sure this is set for proper installs (see the change to
> rewrite-config.pl, but I am happy to put in a fallback if QA team wants it.
> This level of protection is not present for other config variables.
> Lots of other things will go pear-shaped if their definition is missing.

Your changes only apply to _new_ installs. Anyone with a pre-existing
installation who doesn't update their koha-conf.xml will have problems. This
will be most people.

> Thanks for the pointer, I did not know about that template.  This is just
> what code reviews are for.

No problem :)

-- 
You are receiving this mail because:
You are watching all bug changes.