[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Oct 31 15:13:37 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22639|0                           |1
        is obsolete|                            |

--- Comment #52 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22647
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22647&action=edit
Bug 8037: FIX bad sql query and variable renaming

The first patch does a left join on aqorders_items which returns too
much order lines.

This patch follows the Galen's suggestion: it removes the join and calls
the GetItemnumbersFromOrder routine for retrieving itemnumbers.

Bonus: the "parcelitems" variable is badly named and obfuscates the code.
I changed it for "orders".

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list