Without patch, your html tags are missing in your html file
With the patch, they are present and can be used with a css to generate
a formatted pdf file.
If you add some invalid substitution term, with the patch, they are
still in the final letter, but the warn in the log helps you to correct your
notice template.
Signed-off-by: Srdjan
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:04:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 06:04:50 +0000
Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices
shouldn't be removed even if they don't match
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |srdjan at catalyst.net.nz
--- Comment #3 from Srdjan Jankovic ---
I've removed those lines, this script should use GetPreparedLetter anyway.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:15:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 07:15:59 +0000
Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021
--- Comment #7 from Katrin Fischer ---
Some of the information proposed by Mathieu is or might be a bit critical - so
it would be nice to have a system preference to determine which fields are
going to be saved into the statistics table. Maybe we could add the patron
category as a first step.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:21:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 07:21:49 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #3 from David Cook ---
Created attachment 20757
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20757&action=edit
Bug 10662 - Build OAI-PMH Harvesting Client
N.B. This feature is still a work in progress. This commit represents
my work to date on the OAI-PMH harvester, but it's not complete. While
the core classes are operational, I still need to improve the cronjob,
the DC to MARC21 XSLT, and the internal workings of the classes (mostly
in terms of error handling, edge cases, and reporting).
This patch adds several new files to Koha:
Overview:
1) C4/OAI/Harvester.pm: This contains 2 classes. The Harvester class
sets up the 6 OAI-PMH verbs (2 of which harvest records) and imports
records into Koha. The Harvester::Record class is a helper class for
processing records, transforming metadata, etc. At the moment, this is
hardwired for MARC21 but it's easy enough to expand it out to other
flavours (provided there are XSLTs there for the metadata transforms).
2) koha-tmpl/intranet-tmpl/prog/en/xslt/DC2MARC21slim.xsl: This is a
XSLT which transforms oai_dc into MARC21. This is a lightweight XSLT
based on one I found from the Library of Congress. I improved the
Leader and I will endeavour to improve the 008 and map more fields in
a more orderly way than this. However, it's a good start.
3) koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MARC21enhanced.xsl:
This simply strips 999 fields from incoming records, adds the OAI-PMH
unique identifier, and adds a 999 field if that unique identifier has
already been imported in the past (the 999 is added so that automatic
matching and replacement can take place on import).
4) misc/cronjobs/oai_harvester.pl: At the moment, this script takes
database config for a OAI-PMH repository to create a Harvester object,
then tries each OAI-PMH verb and imports the resulting records into
Koha.
5) t/db_dependent/OAI_harvester.t: This is a unit test which uses
Koha as the OAI-PMH repository and client in a circular loop. It
should test the high level methods and go from retrieving database
config to importing records. It uses the "rollback" method so you
won't have a bunch of records imported into your database (although
your autoincrement will probably go up anyway).
Test Plan (For MARC21 users):
0) Apply the patch and run updatedatabase.pl (it will add two new
tables to your database: oai_harvest and oai_harvest_repositories).
I've documented them in kohastructure.sql.
1) For starters, run the OAI_harvester.t test. It should cycle
through all the tests without any problems. If you there are problems,
let me know on Bugzilla, in IRC, or via email.
2a) Next, if you feel safe importing records into your database, use the
config from the unit test as an example and create an entry in your
oai_harvest_repositories table. Be careful with the "import_mode".
"Automatic" will automatically stage and import any records
harvested via OAI-PMH. "Manual" will stage them but not import them.
2b) Once you're somewhat sure of your config, run oai_harvester.pl. The
default is not to use automatic token resumption (so you should only
have 50 records in your import batch most likely). You can change this
in the cronjob itself.
If you fully import this batch, try running "oai_harvester.pl" again.
You shouldn't get any results (as you've already imported that batch
of records). To try out the "replace/update" feature: update one of
the original records you imported (out of that first 50), re-index,
and re-run "oai_harvester.pl". You should now get 1 record in your
batch which should automatically match the original. In "automatic"
mode, it would automatically replace the record (although this can
still be reverted in the Manage Staged MARC Records). In "manual"
mode, you'll notice in the management interface that there has
been a match for that record with the original.
3) To more fully explore: Examine C4/OAI/Harvester.pm. I wrote the POD
at the end of August, so it's a bit out of date but it should be
mostly accurate. I've tried to include as many comments as possible
along the way as well.
It's not a very sophisticated module. However, there are a lot of
different scenarios that I'm trying to account for. I might've missed
some use/edge cases, implemented bad code, or error handling. A place to
start might be any FIXME or TODO messages.
--
As I said at the top, this is still a work in progress, but I'd be
happy to get any feedback or advice on how to proceed with this
feature.
I'll continue working on it and post updates.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:22:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 07:22:33 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20757|0 |1
is obsolete| |
--- Comment #4 from David Cook ---
Created attachment 20758
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20758&action=edit
Bug 10662 - Build OAI-PMH Harvesting Client
N.B. This feature is still a work in progress. This commit represents
my work to date on the OAI-PMH harvester, but it's not complete. While
the core classes are operational, I still need to improve the cronjob,
the DC to MARC21 XSLT, and the internal workings of the classes (mostly
in terms of error handling, edge cases, and reporting).
This patch adds several new files to Koha:
Overview:
1) C4/OAI/Harvester.pm: This contains 2 classes. The Harvester class
sets up the 6 OAI-PMH verbs (2 of which harvest records) and imports
records into Koha. The Harvester::Record class is a helper class for
processing records, transforming metadata, etc. At the moment, this is
hardwired for MARC21 but it's easy enough to expand it out to other
flavours (provided there are XSLTs there for the metadata transforms).
2) koha-tmpl/intranet-tmpl/prog/en/xslt/DC2MARC21slim.xsl: This is a
XSLT which transforms oai_dc into MARC21. This is a lightweight XSLT
based on one I found from the Library of Congress. I improved the
Leader and I will endeavour to improve the 008 and map more fields in
a more orderly way than this. However, it's a good start.
3) koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MARC21enhanced.xsl:
This simply strips 999 fields from incoming records, adds the OAI-PMH
unique identifier, and adds a 999 field if that unique identifier has
already been imported in the past (the 999 is added so that automatic
matching and replacement can take place on import).
4) misc/cronjobs/oai_harvester.pl: At the moment, this script takes
database config for a OAI-PMH repository to create a Harvester object,
then tries each OAI-PMH verb and imports the resulting records into
Koha.
5) t/db_dependent/OAI_harvester.t: This is a unit test which uses
Koha as the OAI-PMH repository and client in a circular loop. It
should test the high level methods and go from retrieving database
config to importing records. It uses the "rollback" method so you
won't have a bunch of records imported into your database (although
your autoincrement will probably go up anyway).
Test Plan (For MARC21 users):
0) Apply the patch and run updatedatabase.pl (it will add two new
tables to your database: oai_harvest and oai_harvest_repositories).
I've documented them in kohastructure.sql.
1) For starters, run the OAI_harvester.t test. It should cycle
through all the tests without any problems. If you there are problems,
let me know on Bugzilla, in IRC, or via email.
2a) Next, if you feel safe importing records into your database, use the
config from the unit test as an example and create an entry in your
oai_harvest_repositories table. Be careful with the "import_mode".
"Automatic" will automatically stage and import any records
harvested via OAI-PMH. "Manual" will stage them but not import them.
2b) Once you're somewhat sure of your config, run oai_harvester.pl. The
default is not to use automatic token resumption (so you should only
have 50 records in your import batch most likely). You can change this
in the cronjob itself.
If you fully import this batch, try running "oai_harvester.pl" again.
You shouldn't get any results (as you've already imported that batch
of records). To try out the "replace/update" feature: update one of
the original records you imported (out of that first 50), re-index,
and re-run "oai_harvester.pl". You should now get 1 record in your
batch which should automatically match the original. In "automatic"
mode, it would automatically replace the record (although this can
still be reverted in the Manage Staged MARC Records). In "manual"
mode, you'll notice in the management interface that there has
been a match for that record with the original.
3) To more fully explore: Examine C4/OAI/Harvester.pm. I wrote the POD
at the end of August, so it's a bit out of date but it should be
mostly accurate. I've tried to include as many comments as possible
along the way as well.
It's not a very sophisticated module. However, there are a lot of
different scenarios that I'm trying to account for. I might've missed
some use/edge cases, implemented bad code, or error handling. A place to
start might be any FIXME or TODO messages.
--
As I said at the top, this is still a work in progress, but I'd be
happy to get any feedback or advice on how to proceed with this
feature.
I'll continue working on it and post updates.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:24:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 07:24:08 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |In Discussion
Patch complexity|--- |Medium patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:24:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 07:24:19 +0000
Subject: [Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's
list of holds
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18742|0 |1
is obsolete| |
--- Comment #8 from Jonathan Druart ---
Created attachment 20759
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20759&action=edit
[3.10.x] Bug 10221 - hold expiration doesn't show on patron's list of holds
When viewing the list of a patron's holds on the circulation page or the
patron detail page the table of holds doesn't display the holds
expiration date, if present. This patch adds display of the hold
expiration date.
To test, place a hold for a patron and set an expiration date for it.
View the patron's existing holds on both circulation.pl and
moremember.pl. The expiration date you chose should appear in the table
of information about existing holds.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:40:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 07:40:12 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #5 from David Cook ---
Thoughts on things to include:
1) Add a preference/config for using identifier + datestamp OR identifier +
datestamp + metadataPrefix as the indicator of the highest order of uniqueness.
2) Add an email feature that tells library staff to check a report which
enumerates the status of records imported via OAI-PMH. These can be create (new
records), replace (updated records), deleted (for incoming records with a
status of deleted), or ambiguous (essentially a new record but linked to
multiple existing bib records. These are almost certainly duplicates but
require manual merging since it's tough to know which is the real authoritative
record).
I was thinking perhaps of sending an email containing a link to a Template
Toolkit page (so that translation would be possible), which would contain the
import/history log.
3) Improving error handling
4) Make the import options more configurable? Although I think the hardcoded
options for always replacing a bib match, adding for no match, and ignoring
items are probably pretty good. There might be other use cases where people
want something different though, so configuration might be a good idea
(although ignoring items is fairly essential, as you could duplicate items if
you're importing updated records with items). Perhaps the MARC21 XSLT should
also strip 952 fields.
5) When using the cronjob, if the "from" date for a repository is "null", check
for existing records in Koha, and use the latest "datestamp"? This way we're
able to do selective harvesting automatically without having to update our
configuration. (I'll probably add this one soon.)
6) Matching rules: a) Check what MARC field that system uses for its
biblionumber. Check if there is a matching rule for that field in Koha. If not,
create one? Having this matching rule is essential for matching updated
records.
7) Improving the DC => MARC conversion (might look at this soon too...it will
always be a "best guess" but it has room for a lot of easy improvement)
8) Make an OAI-PMH harvesting web UI. This would allow people to plug in the
baseURL for a remote OAI-PMH repository and use the 6 verbs on it.
I imagine it being a good way of people getting used to what a OAI-PMH repo
has, so that they can set up the automatic cronjob configuration. It could also
be a good idea to allow the "ImportRecordsIntoKoha" method for selective
harvesting.
That said, if it's too easy to use, it might also be abused by someone who
doesn't know what they're doing. If there were a GUI, it would need a
permission and/or system preference most likely.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:13:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 08:13:35 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
budget summaries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461
--- Comment #5 from Koha Team Lyon 3 ---
Hello Mathieu,
I glance your test in http://pro.test2.biblibre.com/, for the budget spent in
the summary home page, it's normal you see 9 because it take the actual price
for the invoice. So with the preference "invoiced price includes tax", it means
"the atcual price on the invoice printed by the vendor includes tax", the price
spent is really 9.
So for me, the patch is working as it's excepted.
Can you check it ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 12:53:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 10:53:25 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
budget summaries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461
--- Comment #6 from mathieu saby ---
Well, well, I fear I am still lost...
In reception Koha tells me the unit cost is "9.49" (so, I suppose price
including tax). But I don't find again this 9.49 in Acq home page.
For me, "Budget spent" must not take the raw price of the invoice, if this raw
price does not include tax. In this case, budget spent must add tax to this raw
price.
Or maybe there is a bug in reception page?
What is the meaning of the "unit cost" when we receive item : does it mean
1/ "cost actually written by the vendor on his invoice (with or without tax,
depending of invoiceincgst value) ?
or
2/ "price actually paid by the library (so always WITH tax), based on the cost
written by the vendor on the invoice" ?
Maybe Nicole could help me on this point?
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 13:52:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 11:52:53 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
Viktor Sarge changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |viktor.sarge at regionhalland.
| |se
--- Comment #6 from Viktor Sarge ---
I'm excited to see this functionality being developed as we will work with just
the scenario you initially mentioned with a union catalogue providing quality
records that we import automatically as our book vendor add them to our account
in the union catalogue.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:16:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 12:16:22 +0000
Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation
rules is saved incorrectly (rounded)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #11 from Jonathan Druart ---
(In reply to Chris Hall from comment #10)
> Pushed to 3.8.x, will be in 3.8.17
Chris, This patch produces an error (see
http://lists.koha-community.org/pipermail/koha-devel/2013-September/039649.html)
updating the database. Since bug 7420 is not pushed in 3.8.x, I think this fix
should not be pushed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:16:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 12:16:34 +0000
Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation
rules is saved incorrectly (rounded)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |7420
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:16:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 12:16:34 +0000
Subject: [Koha-bugs] [Bug 7420] Add max fines to circulation matrix
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |10490
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:35:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 12:35:48 +0000
Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate
fields
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #60 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #59)
> I think this change might be in conflict with the big serials pattern patch
> that has reached 'Passed QA' already (bug 7688).
I already talk about this possible problem with Julian (author of the feature
7688). On a functional point of view the 2 features are not in conflict but,
inevitably, the patches will not apply cleanly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:02:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 13:02:40 +0000
Subject: [Koha-bugs] [Bug 4823] Raw Socket interface failing to accept
connections
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4823
Colin Campbell changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |WONTFIX
--- Comment #1 from Colin Campbell ---
Closing as resolved. This may have been caused by a configuration issue. If
spare servers is set to zero the server will not ensure that a server is
available to answer incoming connections. When a unit attempts to reconnect all
existing servers may be sitting on old connections they still think are valid
(waiting for the next request that never comes), as no spare has started up the
connection is refused
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:17:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 14:17:48 +0000
Subject: [Koha-bugs] [Bug 10812] New: new check-ou warning:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812
Bug ID: 10812
Summary: new check-ou warning:
Change sponsored?: ---
Product: Koha
Version: 3.12
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: black23 at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Created attachment 20760
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20760&action=edit
warning example
Our patrons very often want to check if selected books they already read. Can
we add custom warning for item which patrad already had some time ago? Message
can looks like example attached file or similar.
Very useful can be setting for:
- some types of items don't generate this warning (ofter loaned items for
example some CD-ROMs, maps or special documents)
- some patrons don't want to be inform about it (checkbox in their detail?)
Thank You
Mike
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:18:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 14:18:06 +0000
Subject: [Koha-bugs] [Bug 10812] new check-ou warning:
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812
Mike changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |black23 at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:19:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 14:19:14 +0000
Subject: [Koha-bugs] [Bug 10812] new check-ou warning:
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812
Mike changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P2
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:31:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 14:31:27 +0000
Subject: [Koha-bugs] [Bug 8605] cs-CZ: Filesystem sent error: No such file
or directory
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8605
Mike changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 17:17:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 15:17:59 +0000
Subject: [Koha-bugs] [Bug 1633] Add ability to take book cover images from
local img db
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633
Manos PETRIDIS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |egpetridis at yahoo.com
--- Comment #88 from Manos PETRIDIS ---
The bug you're looking for, the one where local cover images fail to show, is
#9737.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 20:20:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 18:20:00 +0000
Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 20:20:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 18:20:06 +0000
Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813
--- Comment #6 from Tom?s Cohen Arazi ---
Created attachment 20761
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20761&action=edit
Bug 7813: Ability to delete local cover images
This patch adds the ability to delete local cover images from the detail page.
It adds a 'x' button to trigger the deletion. It occurs using a new SVC script
called cover_images that accepts the following parameters:
- action
- biblionumber (used for checking imagenumber validity)
- imagenumber (repeatable)
It then deletes all valid images passed and returns a JSON object containing
the imagenumbers and the deletion status (1/0). The operation is triggered
using jQuery.ajax, and with the response the corresponding images get deleted.
Note: currently one image is deleted at a time, but the code is there to be
used.
To test:
- Open the detail page fr a biblionumber containing one or more cover images,
go to its images tab.
- Apply the patch, reload the page, go to the images tab.
- Thumbnails should look better than before ;-)
- An 'X' button should show below each cover.
- Clicking the 'X' button should trigger an alert message asking for
confirmation.
a) Cancel: nothing happens, reload the page and check nothing got deleted.
b) Accept: the deleted image should be gone, reload the page to check it
doesn't exist anymore and is not a browser/DOM manipulation trick.
- Signoff
Note: check having more cover images than those that fit the width and see it
wraps fine.
Any comments are welcome, this is WIP.
Thanks
To+
P.S. I chose not to implement every possible action on the svc script, but
another bug could be filled for more improvements.
Sponsored-by: Universidad Nacional de Cordoba
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 22:47:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 20:47:06 +0000
Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command
line
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #20 from Katrin Fischer ---
Setting to failed to get Kyle's attention to comment#18
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 00:02:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 22:02:37 +0000
Subject: [Koha-bugs] [Bug 10813] New: changing sort on tag results shows
more results
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10813
Bug ID: 10813
Summary: changing sort on tag results shows more results
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: nengard at gmail.com
QA Contact: testopia at bugs.koha-community.org
I have a report that when you click a tag in the tag cloud and then change the
sort option on the top right it shows no results found in koha 3.10.10 when I
test this in master I get results, but too many - I get results for a keyword
search instead of the tag search. Either way there is a problem with being able
to change the sort on a tag search results page.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 00:59:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2013 22:59:00 +0000
Subject: [Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093
Pablo L?pez Liotti changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paliotti at mdp.edu.ar
--- Comment #2 from Pablo L?pez Liotti ---
This issue was reported today to me by my library staff.
If the procedure of change field 008 values is repeated sometimes, finally it?s
possible save the record with correct values.
There is any patch o tip to prevent this?
We are using 3.12.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 03:22:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 01:22:12 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
PK, not cardnumber
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |srdjan at catalyst.net.nz
--- Comment #4 from Srdjan Jankovic ---
DDL statements ( ALTER TABLE ) cannot be rolled back, and should not be part of
transaction. In that respect the update transaction makes no sense, and should
be removed. If some kind of failure rollback needs to be implemented, it has to
be done in some other way.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 03:27:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 01:27:29 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
IndexedDB
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 03:27:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 01:27:32 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
IndexedDB
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240
--- Comment #31 from Jared Camins-Esakov ---
Created attachment 20762
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20762&action=edit
Bug 10240 follow-up: fix display
Fix the following two issues:
1) After paying a fine when offline the fine amount becomes NaN.
2) For previous checkouts for a pratron the title and barcode
fields have the wrong infomation in them (i.e. they have been swapped)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 03:43:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 01:43:29 +0000
Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |srdjan at catalyst.net.nz
--- Comment #7 from Srdjan Jankovic ---
A philosophical question - changes like this, consisting of only removing
unused/unwanted code, can those be self-signed, and go to QA directly?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 05:10:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 03:10:50 +0000
Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 05:10:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 03:10:53 +0000
Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20761|0 |1
is obsolete| |
--- Comment #7 from David Cook ---
Created attachment 20763
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20763&action=edit
Bug 7813: Ability to delete local cover images
This patch adds the ability to delete local cover images from the detail page.
It adds a 'x' button to trigger the deletion. It occurs using a new SVC script
called cover_images that accepts the following parameters:
- action
- biblionumber (used for checking imagenumber validity)
- imagenumber (repeatable)
It then deletes all valid images passed and returns a JSON object containing
the imagenumbers and the deletion status (1/0). The operation is triggered
using jQuery.ajax, and with the response the corresponding images get deleted.
Note: currently one image is deleted at a time, but the code is there to be
used.
To test:
- Open the detail page fr a biblionumber containing one or more cover images,
go to its images tab.
- Apply the patch, reload the page, go to the images tab.
- Thumbnails should look better than before ;-)
- An 'X' button should show below each cover.
- Clicking the 'X' button should trigger an alert message asking for
confirmation.
a) Cancel: nothing happens, reload the page and check nothing got deleted.
b) Accept: the deleted image should be gone, reload the page to check it
doesn't exist anymore and is not a browser/DOM manipulation trick.
- Signoff
Note: check having more cover images than those that fit the width and see it
wraps fine.
Any comments are welcome, this is WIP.
Thanks
To+
P.S. I chose not to implement every possible action on the svc script, but
another bug could be filled for more improvements.
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: David Cook
Works as described. This is a nice addition!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 05:58:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 03:58:50 +0000
Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #8 from David Cook ---
Alas, when I try in 3.8.0 (after manually merging the patch with the code), I
get this error:
Uncaught Syntax error, unrecognized expression:
[{"imagenumber":"13","deleted":1}] jquery.js:19
F.filter jquery.js:19
F jquery.js:19
F jquery.js:19
o.fn.o.find jquery.js:12
jQuery.fn.find jquery.hotkeys.min.js:1
o.fn.o.init jquery.js:12
l.jQuery.l.$ jquery.js:12
$.ajax.success detail.pl?biblionumber=179:102
I jquery.js:19
N jquery.js:19
Maybe I made a mistake doing the merge? Or maybe an older version of jQuery has
a harder time processing JSON but that seems strange...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 09:33:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 07:33:30 +0000
Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #2 from Jonathan Druart ---
Created attachment 20764
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20764&action=edit
Bug 10807: FIX if zebra is down, total is undef
The search_history.total column cannot be undef. This patch adds a
default value for the total value.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 13:53:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 11:53:19 +0000
Subject: [Koha-bugs] [Bug 2136] Cataloging Search on Staff Side Not
Consistent
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2136
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #1 from Nicole C. Engard ---
*** This bug has been marked as a duplicate of bug 10047 ***
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 13:53:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 11:53:19 +0000
Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless?
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047
--- Comment #9 from Nicole C. Engard ---
*** Bug 2136 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:10:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 12:10:43 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
PK, not cardnumber
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20724|0 |1
is obsolete| |
--- Comment #5 from Kyle M Hall ---
Created attachment 20765
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20765&action=edit
Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable patronimages
4) Verify patron images are still displaying correctly
5) Test deleting a patron image
6) Test adding a patron image from moremember.pl
7) Test adding a patron image from tools/picture-upload.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:11:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 12:11:04 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
IndexedDB
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nengard at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:11:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 12:11:16 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
PK, not cardnumber
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636
--- Comment #6 from Kyle M Hall ---
Thanks for the info! Does this new patch have a more sensible database update?
Kyle
(In reply to Srdjan Jankovic from comment #4)
> DDL statements ( ALTER TABLE ) cannot be rolled back, and should not be part
> of transaction. In that respect the update transaction makes no sense, and
> should be removed. If some kind of failure rollback needs to be implemented,
> it has to be done in some other way.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:59:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 12:59:24 +0000
Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a
fine
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nengard at gmail.com
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=10708
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:59:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 12:59:24 +0000
Subject: [Koha-bugs] [Bug 10708] make fine receipt customizable
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=10027
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:03:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 14:03:59 +0000
Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant
branches behaviour)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:04:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 14:04:03 +0000
Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant
branches behaviour)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20750|0 |1
is obsolete| |
--- Comment #16 from Kyle M Hall ---
Created attachment 20766
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20766&action=edit
Bug 5904: ysearch.pl members improvements (Independent branches behaviour)
Test plan:
- Add a staff user foo in a library A
- Add a staff user bar in a library B
- log in as foo and try to search 'bar'
- Switch on (Prevent) the new pref IndependentBranches
- the search returns no result
- log in as a superlibrarian
- Check that you are allow to search all patrons.
Signed-off-by: Srdjan
Signed-off-by: Kyle M Hall
Passes koha-qa.pl, works as advertised.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:58:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 14:58:57 +0000
Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql
reports
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19217|0 |1
is obsolete| |
--- Comment #7 from Kyle M Hall ---
Created attachment 20767
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20767&action=edit
Bug 10502 - Add independent branches option for sql reports
This patch adds the ability to hide reports created by other libraries
based on the new IndependentBranchesReports system preference. This is
accomplished by adding a branchcode field to the sql reports, which is
set on report creation.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable IndependentBranchesReports
4) Log in with a non-superlibrarian staff account
5) View existing sql reports, you should see no difference. Existing
reports are 'grandfathered' in, assuming that existing reports may be
used by multiple libraries or library groups.
6) Ensure you have selected a library to act as via the "set library" link.
7) Create a new sql report.
8) Verify it was created and you can view and edit it.
9) Change the logged in library to a difference branch.
10) Observe that the report is no longer visible in the reports list.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:58:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 14:58:55 +0000
Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql
reports
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 18:25:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 16:25:00 +0000
Subject: [Koha-bugs] [Bug 10814] New: add a link to an authorized value
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10814
Bug ID: 10814
Summary: add a link to an authorized value
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: new feature
Priority: P5 - low
Component: System Administration
Assignee: koha-bugs at lists.koha-community.org
Reporter: nengard at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
It would be great if we could add a link to an authorized value (location
specifically) that would then show in the OPAC as a clickable label. The idea
would be to have a shelving location with a link to an image of a library map
showing where that location is.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 18:29:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 16:29:49 +0000
Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813
--- Comment #9 from Tom?s Cohen Arazi ---
(In reply to David Cook from comment #8)
> Alas, when I try in 3.8.0 (after manually merging the patch with the code),
> I get this error:
>
> Uncaught Syntax error, unrecognized expression:
> [{"imagenumber":"13","deleted":1}] jquery.js:19
>
> Maybe I made a mistake doing the merge? Or maybe an older version of jQuery
> has a harder time processing JSON but that seems strange...
I'm not sure about that one, but it might be due to:
- wrong jquery version (incorrectly processing the application/json
content-type)
- wrong JSON Perl library (not outputting the right format)
I'd like to note that I used bootstrap on this patch, and there are some visual
gli-glitches when merging into 3.8.x.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 18:30:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 16:30:57 +0000
Subject: [Koha-bugs] [Bug 10815] New: can click unapproved tags in 'my tags'
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10815
Bug ID: 10815
Summary: can click unapproved tags in 'my tags'
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Tools
Assignee: gmcharlt at gmail.com
Reporter: nengard at gmail.com
QA Contact: testopia at bugs.koha-community.org
In the OPAC I can see my tags even if they are not approved - this is OK. If I
click one of those tags though I get no results. So the tags shouldn't be
clickable if not approved or the tag click should work even if the word isn't
approved. Either way works for me, but it seems like an oversight/bug.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:00:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 18:00:24 +0000
Subject: [Koha-bugs] [Bug 10068] Move from the utf8:: pragma methods to
Encode::
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10068
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|tomascohen at gmail.com |gmcharlt at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:01:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 18:01:41 +0000
Subject: [Koha-bugs] [Bug 10438] Packages pocket/name-versioning broken
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10438
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |WONTFIX
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:20:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 18:20:30 +0000
Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and
manipulating collections of patrons
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565
--- Comment #30 from Kyle M Hall ---
Created attachment 20768
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20768&action=edit
Bug 10565 - Add a "Patron List" feature for storing and manipulating
collections of patrons - Followup 4 - Don't assume borrowernumber 1 exists in
unit test
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:20:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 18:20:27 +0000
Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and
manipulating collections of patrons
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:21:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 18:21:02 +0000
Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and
manipulating collections of patrons
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565
--- Comment #31 from Kyle M Hall ---
Liz, I think the problem with the unit test is that I'm assuming there is a
borrower with a borrowernumber of 1 that is the inital Koha Admin account
created during installation. Is this an improper assumption? I'm guessing it
is. I've attached another followup to remedy the situation.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 00:58:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 22:58:44 +0000
Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594
--- Comment #12 from Dan Scott ---
(In reply to mathieu saby from comment #11)
> Could you tell me if a followup for UNIMARC is needed ?
Yes, at this point only support for MARC21 has been created and merged. I'm not
at all familiar with UNIMARC, thus equivalent XSLT changes for UNIMARC would be
great. I would be happy to help vet the HTML+RDFa output from any such changes!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 01:43:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 23:43:36 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
PK, not cardnumber
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636
--- Comment #7 from Srdjan Jankovic ---
No, this is as good as it can be. The only thing that I'm not sure of is
whether you should reinstate AutoCommit and RaiseError straight after eval. I
hate to admit that whenever I had a db update it was always simple and I
started with copying one before, so I'm not familiar with AutoCommit and
RaiseError policy in updatedatabase.pl.
In a way, because it is a single change within transaction, you can even get
away with not changing AutoCommit at all (RaiseError is still in order).
If you are happy I'll proceed with sign-off, and we'll let QA team cast the
final verdict.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 01:57:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2013 23:57:12 +0000
Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql
reports
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502
--- Comment #8 from Srdjan Jankovic ---
Undefined subroutine &C4::Branch::GetIndependentGroupModificationRights called
at /home/srdjan/koha/dev/C4/Reports/Guided.pm line 676.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 05:44:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 03:44:09 +0000
Subject: [Koha-bugs] [Bug 10816] New: Relational operators in Search
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10816
Bug ID: 10816
Summary: Relational operators in Search
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Documentation
Assignee: nengard at gmail.com
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
In each of the version 3 manuals, it says that a person can compose a query
like so: "yr,st-numeric=>2000".
However, when I try this, I get no results. I have to use
"yr,st-numeric,ge=2000" to get the actual results.
I presumed that the "buildQuery" sub translated => into ge, but maybe that's
not happening (anymore or at all)?
http://manual.koha-community.org/3.12/en/searchguide.html
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 09:12:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 07:12:08 +0000
Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594
--- Comment #13 from mathieu saby ---
I will open a specific bug for unimarc and try to take a look.
Mathieu
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:04:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 09:04:03 +0000
Subject: [Koha-bugs] [Bug 10654] Add feature: export basket in CSV,
list of custom formats for various vendors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10654
Silvia Simonetti changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |s.simonetti at cineca.it
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:18:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 09:18:16 +0000
Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19751|0 |1
is obsolete| |
--- Comment #45 from Chris Cormack ---
Created attachment 20769
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20769&action=edit
Bug 7295: More granular permissions for baskets
Add branch info to baskets
Add a list of borrowers that are allowed to manage a basket (one list
for each basket).
Add a new subpermission: acquisition => order_manage_all
If user is superlibrarian, or if he has permission acquisition = 1
(GranularPermissions = OFF), or subpermission acquisition =>
order_manage_all (GranularPermissions = ON). He's authorised to manage
all baskets.
Depending on syspref AcqViewBaskets:
'all': user can manage all baskets
'branch': user can manage baskets of his branch (the basket branch is
taken into account, not the branch of the basket's creator).
If basket branch is not defined, all user can manage this
basket.
'user': user can manage baskets he created, and baskets he's in their
user list
There are unit tests in t/Acquisition/CanUserManageBasket.t, which
require Test::MockModule
You can edit basket's branch and users list in basket modification page
(acqui/basket.pl)
Signed-off-by: Sonia Bouis
Signed-off-by: Kyle M Hall
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:18:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 09:18:30 +0000
Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19752|0 |1
is obsolete| |
--- Comment #46 from Chris Cormack ---
Created attachment 20770
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20770&action=edit
Bug 7295: Follow-up: Several fixes
- List of libraries in basket.pl is now sorted by branch name, not code
- When IndependantBranches is ON, user has only the possibility to set
basket branch to its own branch, or to no branch at all.
- When basket do not belong to any branch, selected branch by default is
connection branch (was 'no branch')
- added id attributes to both added li elements
- change description of 'order_manage_all' permission to make it
clearer.
- remove Test::MockModule dependency
Signed-off-by: Sonia Bouis
Signed-off-by: Kyle M Hall
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:18:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 09:18:42 +0000
Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:18:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 09:18:47 +0000
Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19754|0 |1
is obsolete| |
--- Comment #47 from Chris Cormack ---
Created attachment 20771
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20771&action=edit
Bug 7295 [follow-up] More granular permissions for baskets
Replace simple-quoted string by double-quoted string
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:20:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 09:20:59 +0000
Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items
table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:21:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 09:21:04 +0000
Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items
table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19883|0 |1
is obsolete| |
--- Comment #4 from Chris Cormack ---
Created attachment 20772
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20772&action=edit
Bug 10634 - Use datatables for course details items table
We should make the course items table in the course details a datatable
to enable searching or sorting.
Test Plan:
1) Apply this patch
2) View the details page for a course with items
3) Verify the table displays and is now a datatable
Signed-off-by: Owen Leonard
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 12:15:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 10:15:16 +0000
Subject: [Koha-bugs] [Bug 10817] New: SIPserver does not return holds info
when requested
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817
Bug ID: 10817
Summary: SIPserver does not return holds info when requested
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs at lists.koha-community.org
Reporter: colin.campbell at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
CC: colin.campbell at ptfs-europe.com
If hold items info is requested using a patron information request it is not
returned. Sip devices need this to show to the user what books they have on
hold and what holds they have awaiting collection.
While the software goes through the motion of supplying this data, it has not
retrieved it to populate the fields.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 12:51:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 10:51:41 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
UTF8 handling in templates
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:13:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 11:13:39 +0000
Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql
reports
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502
--- Comment #9 from Kyle M Hall ---
Did you apply the patch for 10276 first? That subroutine is contain in that
bug's patch.
Kyle
(In reply to Srdjan Jankovic from comment #8)
> Undefined subroutine &C4::Branch::GetIndependentGroupModificationRights
> called at /home/srdjan/koha/dev/C4/Reports/Guided.pm line 676.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:14:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 11:14:21 +0000
Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support
groups of libraries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18850|0 |1
is obsolete| |
--- Comment #7 from Kyle M Hall ---
Created attachment 20773
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20773&action=edit
Bug 10276 - Extend IndependentBranches to support groups of libraries
This patch adds the ability to have independent library groups. To
enable this feature, enable the IndependentBranches system preference.
If no libraries are in any independent library groups,
IndependentBranches will behave as it always have. If a library is
part of an independent library group with one or more libraries, that
library will be able to access and modify patrons and items from any
library in that group.
Let's say we have 3 groups:
Group1:
LibA
LibB
LibC
Group1:
LibD
LibE
LibF
Group3:
LibG
LibH
LibA
Note how LibA is in two groups ( Group1 and Group2 ). With this
configuration, if IndependentBranches is enabled, libraries will be able
to access and edit patrons and items in the following configuration:
LibA => LibB, LibC, LibG, LibH
LibB => LibA, LibC
LibC => LibA, LibB
LibD => LibE, LibF
LibF => LibD, LibE
LibG => LibH, LibA
LibH => LibG, LibA
Furthermore, let us assume there is a library LibI, which does not
belong to any group. That library will only be able to view and edit
patrons and items from it's own library.
Imagine a library consortium consisting of multiple library systems.
This feature would allow a consortium to group libraries by system such
that those systems could work independently from one another on a single
installation.
Test Plan:
1) Apply patches for bugs 10080 and 10206
2) Apply this patch
3) Run updatedatabase.pl
4) Enable IndependentBranches
5) Test independent branches, no changes should be noted
6) Navigate to admin/branches.pl
7) Create a new Independent library group
8) Add your library and some other libraries to that group
9) Re-test IndependentBranches, everything should work as previously,
but instead of being limited to just your library, you should have
access to everything within your library group.
Example: Try to edit an item. If the item is owned by a library in
your group, you should be able to edit it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:14:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 11:14:31 +0000
Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from
search results for Independent Branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18715|0 |1
is obsolete| |
--- Comment #5 from Kyle M Hall ---
Created attachment 20774
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20774&action=edit
Bug 10278 - Add ability to hide items and records from search results for
Independent Branches
For the staff intranet, enabling IndependentBranchesRecordsAndItems
will automatically add a branch limit filter to the search results
thus hiding all records without one or more items owned by the logged
in library. In add addition, all items whose homebranch is not that
libraries will be filtered and hidden from the search results and
record details.
This system preference will not affect the OPAC, unless the environment
variable BRANCHCODE is defined in the koha-httpd.conf file. If it is
defined, the same filters are applied to the OPAC, but based on the
branchcode value of the environment variable BRANCHCODE, rather than the
logged in branch.
Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Perform a search that will give results for both records which
have items owned by the logged in library, and records which have
no items owned by the logged in library.
4) Enable the new system preference IndependentBranchesRecordesAndItems
5) Perform the same search again, any records without items owned
by the currently logged in library should not appear.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:14:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 11:14:49 +0000
Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit
a bibliographic record
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18849|0 |1
is obsolete| |
--- Comment #7 from Kyle M Hall ---
Created attachment 20775
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20775&action=edit
Bug 10263 - Add ability to limit which branch can edit a bibliographic record (
IndependentBranchesMarcEditing )
Right now, it's possible to limit who can edit items by using
IndependantBranches. However, Koha has no method of limiting who can
edit bibliographic records, as they have no defined owner.
This patch adds a new system preference IndependentBranchesMarcEditing. If this
new
syspref is enabled, a librarian can only edit or delete a bib record if
his or her logged in branch code matches the branchcode in
biblio.branchcode. This feature does not affect the ability to edit or
delete items, as that functionality is determined by
IndependantBranches.
This patch adds the 'branches_optional' field to the authorised values
pulldown for MARC fields and subfields in the MARC frameworks editor.
'branches_optional' behaves exactly like 'branches' except it includes
an "empty" choice so the branch does not have to be set.
Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Map a nonrepeatable field/subfield to biblio.branchcode ( e.g. 951$o )
Pro-tip: Use the authorised value 'branches_optional' to get a pulldown of
libraries instead of entering the branchcode manually.
4) Edit a record, and add a branchcode.
5) Log in as a non-superlibrarian with cataloging priveleges
6) Change the logged in branch to a branch other than the one you
entered in the record.
7) You should note the 'edit' pulldown for the record is missing the
"Edit record" and "Delete record" options.
8) Switch the logged in branch to match the branchcode of the record.
9) You should now see the edit and delete options for that record.
10) Attempt to edit a record with no branchcode defined, you should be
able to.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:15:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 11:15:25 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
UTF8 handling in templates
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
Mike changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |black23 at gmail.com
--- Comment #119 from Mike ---
I found same problem in 3.12.x in Czech translation. Problem on:
/cgi-bin/koha/members/members-home.pl
/cgi-bin/koha/admin/preferences.pl?tab=circulation
/cgi-bin/koha/admin/preferences.pl?tab=opac
/cgi-bin/koha/admin/preferences.pl?tab=patrons
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:17:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 11:17:10 +0000
Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian()
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19229|0 |1
is obsolete| |
--- Comment #14 from Kyle M Hall ---
Created attachment 20776
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20776&action=edit
Bug 10277 - Add C4::Context->IsSuperLibrarian()
The method of checking the logged in user for superlibrarian privileges
is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least.
The codebase is littered with these lines, with no explanation given. It
would be much better if we had one subroutine that returned a boolean
value to tell us if the logged in user is a superlibrarian or not.
Test Plan:
1) Apply this patch
2) Verify superlibrarian behavior remains unchanged
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:21:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 11:21:23 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
PK, not cardnumber
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636
--- Comment #8 from Kyle M Hall ---
That sounds good to me!
> If you are happy I'll proceed with sign-off, and we'll let QA team cast the
> final verdict.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:39:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 11:39:12 +0000
Subject: [Koha-bugs] [Bug 10818] New: System preference OAI-PMH:ConfFile
isn't translatable
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818
Bug ID: 10818
Summary: System preference OAI-PMH:ConfFile isn't translatable
Change sponsored?: ---
Product: Koha
Version: 3.12
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: I18N/L10N
Assignee: koha-bugs at lists.koha-community.org
Reporter: josef.moravec at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: frederic at tamil.fr
This text, from System preference OAI-PMH:ConfFile, isn't translatable, and is
still in english in the staff interface:
"If empty, Koha OAI Server operates in normal mode, otherwise it operates in
extended mode. In extended mode, it's possible to parameter other formats than
marcxml or Dublin Core. OAI-PMH:ConfFile specify a YAML configuration file
which list available metadata formats and XSL file used to create them from
marcxml records."
The reason is, obviously, that this text isn't in the *-pref.po files on
translate.koha-community.org
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:39:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 11:39:29 +0000
Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't
translatable
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |trivial
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 14:42:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 12:42:51 +0000
Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 14:46:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 12:46:40 +0000
Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate
fields
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956
--- Comment #61 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #60)
> (In reply to Katrin Fischer from comment #59)
> > I think this change might be in conflict with the big serials pattern patch
> > that has reached 'Passed QA' already (bug 7688).
>
> I already talk about this possible problem with Julian (author of the
> feature 7688). On a functional point of view the 2 features are not in
> conflict but, inevitably, the patches will not apply cleanly.
I suppose the big question is: which of the two will be easier to rebase over
top the other.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:10:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 13:10:14 +0000
Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when
requested
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817
Colin Campbell changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
|ity.org |com
--- Comment #1 from Colin Campbell ---
Created attachment 20777
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20777&action=edit
Proposed Patch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:14:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 13:14:27 +0000
Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting
ReservesControlBranch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:14:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 13:14:29 +0000
Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting
ReservesControlBranch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19435|0 |1
is obsolete| |
--- Comment #18 from Kyle M Hall ---
Created attachment 20778
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20778&action=edit
Bug 10272 - CheckReserves returns not respecting ReservesControlBranch
CheckReserves is using the CircControl system preference to determine what
patrons an item can fill a hold for. It should be using ReservesControlBranch
instead.
Test Plan:
1) Set ReservesControlBranch to "item's home library".
2) Create an item at Library A, place holds for it for patrons at
Library B, Library C, and Library A in that order,
for pickup at the patrons home library.
3) Make sure the holds policy for Library A is set to
Hold Policy = "From home library" and
Return Policy = "Item returns home".
Make sure the holds policies for the other libraries are set to
Hold Policy = "From any library".
4) Check the item in at Library C, the hold for the patron at Library B
should pop up, even though it's in violation of the circulation rules.
Don't click the confirm button!
5) Apply this patch, and reload the page,
now the hold listed should be for the last hold,
the hold for the patron at Library A, which is correct.
This patch adds the subroutine C4::Reserves::GetReservesControlBranch as
an equivilent to C4::Circulation::_GetCircControlBranch.
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:50:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 13:50:33 +0000
Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the
'status' option switch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:51:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 13:51:38 +0000
Subject: [Koha-bugs] [Bug 10733] Memcached on package installs
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Change sponsored?|--- |Sponsored
Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 16:20:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 14:20:53 +0000
Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items
table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |gmcharlt at gmail.com
--- Comment #5 from Galen Charlton ---
Pushed to master. Thanks, Kyle!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 16:24:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 14:24:43 +0000
Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge
search_history entries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #16 from Galen Charlton ---
Pushed to master. Thanks, Mirko!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 16:27:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 14:27:00 +0000
Subject: [Koha-bugs] [Bug 10755] Add "Keyword as Phrase" to staff client
advanced search indexes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |gmcharlt at gmail.com
--- Comment #4 from Galen Charlton ---
Pushed to master. Thanks, David!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 16:29:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 14:29:39 +0000
Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720
--- Comment #57 from Jonathan Druart ---
Kyle, first patch does not apply cleanly (conflicts in opac-detail.tt).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 16:50:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 14:50:21 +0000
Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421
--- Comment #9 from Galen Charlton ---
A relevant discussion on koha-devel -
http://lists.koha-community.org/pipermail/koha-devel/2013-September/039662.html
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:11:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 15:11:29 +0000
Subject: [Koha-bugs] [Bug 10503] incorrect initialization parameters passed
to Memoize::Memcached
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #8 from Jonathan Druart ---
Looks good to me, the patch works as expected on Debian Wheezy.
> This patch also corrects SQLHelper so that it no longer tries to
> use the deprecated (and removed) memcached_servers setting in koha-conf.xml;
Why do you say that?
it is still in used by Koha/Template/Plugin/Cache.pm and appears in
debian/templates/koha-conf-site.xml.in.
Should we remove these occurrences too?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:31:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 15:31:07 +0000
Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't
translatable
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:33:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 15:33:15 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
--- Comment #108 from M. Tompsett ---
Created attachment 20779
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20779&action=edit
Reconstructed attempt for the upload plugin feature.
This patch should obsolete all the other stuff, but since I am not the original
author, but I really want this patch in, I have done my best to reconstruct it.
I decided not to obsolete, in the case I that missed something.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:36:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 15:36:15 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #109 from M. Tompsett ---
As far as I can tell:
- configure the koha-conf.xml with the appropriate values
- make sure the directories exist and have the correct permissions
/home/mtompset/koha-dev/var/lib/plugins
1
/home/mtompset/kohaclone/koha-tmpl/uploads
- link 856$u to the upload.pl plugin.
- test.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:39:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 15:39:36 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
--- Comment #110 from Jared Camins-Esakov ---
(In reply to M. Tompsett from comment #109)
> As far as I can tell:
> - configure the koha-conf.xml with the appropriate values
> - make sure the directories exist and have the correct permissions
> /home/mtompset/koha-dev/var/lib/plugins
> 1
Please provide an updated test plan that reflects your new dependency on Koha's
plugin system.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:04:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 16:04:58 +0000
Subject: [Koha-bugs] [Bug 10819] New: Allow for auto filling of holds when
items are checked in via SCO
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10819
Bug ID: 10819
Summary: Allow for auto filling of holds when items are checked
in via SCO
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Self checkout
Assignee: koha-bugs at lists.koha-community.org
Reporter: cnighswonger at foundations.edu
QA Contact: testopia at bugs.koha-community.org
When an item with a hold on it is checked in via the SCO module (web), no
further processing is done which results in the hold being overlooked unless
the circulation desk workflow includes a regular run of the hold reports.
The least fix for this would be to add a system pref allowing for the option of
auto-filling the highest priority hold on an item checked in via the SCO
module. Perhaps other options allowing for various alternate workflows might be
added here as well.
I'm listing this as an enhancement because depending on one's workflow, this
may not be a bug.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:11:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 16:11:19 +0000
Subject: [Koha-bugs] [Bug 8891] "Long overdue (lost)" items in search
results show garbled information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8891
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |kyle at bywatersolutions.com
Resolution|--- |WORKSFORME
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:13:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 16:13:23 +0000
Subject: [Koha-bugs] [Bug 10820] New: Lost items on search results don't
jive with record details
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820
Bug ID: 10820
Summary: Lost items on search results don't jive with record
details
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
In the OPAC, if an items is both lost and checked out, it will show as lost on
the search results, and checkout out in the record details. The lost status
should take precedence over the checked out status, as the checked out status
may lead a patron to believe the book may return soon.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:13:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 16:13:29 +0000
Subject: [Koha-bugs] [Bug 10820] Lost items on search results don't jive
with record details
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:16:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 16:16:49 +0000
Subject: [Koha-bugs] [Bug 10820] Lost items on search results don't jive
with record details
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:16:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 16:16:51 +0000
Subject: [Koha-bugs] [Bug 10820] Lost items on search results don't jive
with record details
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820
--- Comment #1 from Kyle M Hall ---
Created attachment 20780
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20780&action=edit
Bug 10820 - Lost items on search results don't jive with record details
In the OPAC, if an items is both lost and checked out, it will show as
lost on the search results, and checkout out in the record details. The
lost status should take precedence over the checked out status, as the
checked out status may lead a patron to believe the book may return
soon.
Test Plan:
1) Check an item out to a patron
2) Set it to lost ( requires itemlost to be revealed in the framework
for the items editor ).
3) Rebuild your zebra indexes
4) Run a search where that item is in the results list
5) Note the item is marked as lost
6) View the record details
7) Note the item is listed as "checked out"
8) Apply this patch
9) Repeat steps 4-6, note the item is now listed as lost
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:44:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 16:44:28 +0000
Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant
branches behaviour)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #17 from Galen Charlton ---
Pushed to master. Thanks, Jonathan!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:00:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 17:00:50 +0000
Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO
is not defined
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |gmcharlt at gmail.com
--- Comment #6 from Galen Charlton ---
Pushed to master. Thanks, Jonathan!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:15:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 17:15:35 +0000
Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected
in filters
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #14 from Galen Charlton ---
Pushed to master. Thanks, Fridolyn!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:20:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 17:20:08 +0000
Subject: [Koha-bugs] [Bug 10821] New: label pdf adding in strange breaking
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821
Bug ID: 10821
Summary: label pdf adding in strange breaking
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Label printing
Assignee: cnighswonger at foundations.edu
Reporter: nengard at gmail.com
QA Contact: testopia at bugs.koha-community.org
Created attachment 20781
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20781&action=edit
call number
Let's start here - the CSV, XML and Quick label creator do not have this
problem - it's purely the PDF.
So see the attached images. The call number is 'Script H82 E45' the label is
set to print itemcallnumber only and yet with it prints it makes the label look
like this (also attached):
SCR
.I
P
T
H82
E45
It's adding spaces and a dot that don't belong there. I have changed the font
size and it still does it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:20:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 17:20:35 +0000
Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821
--- Comment #1 from Nicole C. Engard ---
Created attachment 20782
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20782&action=edit
pdf call number
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:41:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 17:41:46 +0000
Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821
--- Comment #2 from Chris Nighswonger ---
Please post an example of the expected split call number.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 20:14:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 18:14:09 +0000
Subject: [Koha-bugs] [Bug 10822] New: Matcher should use SimpleSearch for
auths
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10822
Bug ID: 10822
Summary: Matcher should use SimpleSearch for auths
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jcamins at cpbibliography.com
Reporter: jcamins at cpbibliography.com
QA Contact: testopia at bugs.koha-community.org
Although C4::Matcher now supports both bibliographic and authority records, it
has been using SearchAuthorities for authorities. Ideally it should use
SimpleSearch when possible as part of our ongoing efforts to centralize,
normalize, and de-insanify the search code, and in order to provide the user
with additional indexes under QueryParser.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 20:16:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 18:16:34 +0000
Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout
screen for display in IE
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |gmcharlt at gmail.com
--- Comment #9 from Galen Charlton ---
Pushed to master -- thanks, David!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 20:30:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 18:30:41 +0000
Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821
--- Comment #3 from Nicole C. Engard ---
What do you mean - how should it split? It should split at the spaces and/or
dots so
Script
H82
E45
But instead the PDF is adding in a dot and breaks in the middle of the word
(and it's not font size cause I made it super small and it still does it.
In the CSV, quick spine label and the XML it's not splitting the word 'Script'
like the PDF is.
Nicole
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:01:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:01:24 +0000
Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18714|0 |1
is obsolete| |
--- Comment #35 from Jared Camins-Esakov ---
Created attachment 20783
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20783&action=edit
Bug 7419: General-purpose record deduplicator
This patch adds a script for deduplicating records. It is most useful
for authority records but by design could be easily extended for use
with bibliographic records, if someone had a good use case.
See the follow-up for an updated test plan.
Complete POD documentation:
SYNOPSIS
dedup_records.pl --match=1 -a
dedup_records.pl --match="LC-card-number/010a" --select="date" \
--limit="authid > 367123592" -a
dedup_records.pl --match="Match/100abcdefghijklmnopqrstuvwxyz" \
--select="source=DLC" --select="date" \
--limit="authtypecode='PERSO_NAME'" -a
DESCRIPTION
This script will identify duplicate records, and either suggest
that you merge them (in the case of bibliographic records) or
automatically merge them for you (in the case of authority records).
OPTIONS
--help Prints this help
-v|--verbose
Print verbose log information (warning: very verbose!).
-t|--test
Do not actually make any changes to the database, just
report what changes would be made.
-r|--report
Print a report of what happened during the run.
-l|--limit=S
Only process those records that match the user-specified
WHERE clause (the WHERE is implied and should not be
included on the command line).
-a|--authorities
Check for duplicate authorities rather that duplicate
bibliographic records.
-s|--select=s
Repeatable. Specify how to identify which record to
prefer. See the section on SELECTORS below.
-m|--match=s
Specifies the matching rule to use. This can be the
numeric ID of a matching rule that you have already
configured (preferred), or you can specify a matching
rule on the command-line in the following format:
/[##/[##...]]
Examples:
at/152b##he-main/2..a##he/2..bxyzt##ident/009@
authtype/152b##he-main,ext/2..a##he,ext/2..bxyz
sn,ne,st-numeric/001##authtype/152b##he-main,ext/2..a##he,ext/2..bxyz
-c|--check=s
Only relevant when you are using a matching rule
specified on the command line. Specifies sanity checks to
use to ensure that the records are really duplicate. The
format is [,[,...]]
Examples:
200abxyz will check subfields a,b,x,y,z of 200 fields
009@,152b will check 009 data and 152$b subfields
SELECTORS
This script supports a number of selectors for choosing which
record is "better."
score Prefer the record which is the best match based on the
specified matching rule. This will probably only be
useful in cases where the matching rule will not match
the source record, since the source record will
automatically be given a score of 2 * the matching rule
threshold if it wasn't picked up by the matcher.
date Prefer the record which is newer based on the 005 field.
source=ABC
MARC21 only. Prefer records which come from ABC based on
the 003 field.
usage Authorities only. Prefer the record used in the most
bibliographic records.
ppn UNIMARC only. Prefer records which have a PPN in the 009
field.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:01:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:01:37 +0000
Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419
--- Comment #36 from Jared Camins-Esakov ---
Created attachment 20784
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20784&action=edit
Bug 7419: Add more missing authority indexes
Koha's CCL configuration did not allow for most of the indexes that
were configured for authorities. This patch adds missing authority
indexes to QP.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:01:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:01:49 +0000
Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419
--- Comment #37 from Jared Camins-Esakov ---
Created attachment 20785
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20785&action=edit
Bug 7419: quiet warnings in deduplicator
Quiet some warnings from the deduplicator script.
Revised test plan:
1) Apply patches.
2) Import the sample records (sampleauths.mrc) file into Koha and
make sure that they get indexed (by waiting until rebuild_zebra.pl
runs automatically or by running rebuild_zebra.pl -a -z [-x] manually)
3) Deduplicate based on LCCN (replace {FIRSTAUTH} with the authid of the
first imported record; on my system that number is 367123668):
> misc/migration_tools/dedup_records.pl -t -v -a \
-l "authid >= {FIRSTAUTH}" -r -m "lc-card/010a" -s date
4) Check that you have 10 records that were chosen (you may have more,
if you added more authorities after importing the sample data, but you
should have at least the ten).
5) Deduplicate based on geographic heading, preferring Library of Congress
authorities to local authorities:
> misc/migration_tools/dedup_records.pl -t -v -a \
-l "authid >= {FIRSTAUTH}" -r -m "geographic/151a" -s "source=DLC" -s date
6) Check that you have 2 duplicate records replaced from amongst the new
records.
7) Sign off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:03:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:03:41 +0000
Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|koha.sekjal at gmail.com |testopia at bugs.koha-communit
| |y.org
--- Comment #38 from Jared Camins-Esakov ---
Note that the new test plan does require you to be using QueryParser (and an
updated etc/searchengine/queryparser.yaml).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:21:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:21:05 +0000
Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821
--- Comment #4 from Chris Nighswonger ---
(In reply to Nicole C. Engard from comment #3)
> What do you mean - how should it split? It should split at the spaces and/or
> dots so
>
> Script
> H82
> E45
That's what I was looking for. Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:34:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:34:26 +0000
Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:34:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:34:28 +0000
Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19564|0 |1
is obsolete| |
--- Comment #8 from Jared Camins-Esakov ---
Created attachment 20786
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20786&action=edit
Bug 10539: Remove unused unit tests in lib/KohaTest
This patch removes all files in lib/KohaTest and the associated script
t/db_dependent/database_dependent.pl.
The second patch deals with a few consequences.
Note that bug 10540 has been opened to save some interesting code from these
unit tests and inject them in the currently used t/db_dependent suite.
Test plan:
See second patch.
Signed-off-by: Jared Camins-Esakov
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:34:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:34:38 +0000
Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19565|0 |1
is obsolete| |
--- Comment #9 from Jared Camins-Esakov ---
Created attachment 20787
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20787&action=edit
Bug 10539: Followup for removing KohaTest unit tests
Makefile.PL: Section for creating file t/test-config.txt removed.
Removes t/Makefile and t/rewrite-config-test too.
Modifies XISBN.t to remove two commented lines.
Test plan:
Grep for KohaTest, database_dependent, config-test, t/Makefile.
Run perl Makefile.PL and include running the test suite.
This may fail on t/00-valid-xml.t and t/QueryParser.t, but that is not the
result of this patch. Same for t/00-load.t with potential error on
Koha::Plugins::Base.
I had this result:
Test Summary Report:
t/00-valid-xml.t (Wstat: 1792 Tests: 381 Failed: 7)
Failed tests: 10, 30-31, 169, 181, 201-202
Non-zero exit status: 7
t/QueryParser.t (Wstat: 512 Tests: 0 Failed: 0)
Non-zero exit status: 2
Parse errors: No plan found in TAP output
Files=92, Tests=12385, 45 wallclock secs ( 1.74 usr 0.15 sys + 26.61 cusr
1.92 csys = 30.42 CPU)
Result: FAIL
Failed 2/92 test programs. 7/12385 subtests failed.
Signed-off-by: Jared Camins-Esakov
All tests pass, and I find no mention of the removed test code.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:42:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:42:13 +0000
Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
--- Comment #29 from Jared Camins-Esakov ---
There is a small conflict in C4::Letter that I am not sure how to resolve. Does
the from e-mail address have to be the patron's e-mail address for GPG to work?
It seems to me we'd prefer it to be the library's e-mail address, if one is
set, but I presume there's a reason for the change in the patch, so I wanted to
ask for feedback on it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:46:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:46:29 +0000
Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897
--- Comment #30 from Jared Camins-Esakov ---
Additionally, it looks like there are no unit tests. Is it possible to unit
test C4::GnuPG?
Finally, and this is a definite blocker, it looks like C4::GnuPG is initialized
with file-level my variables:
+my $gpg = new Crypt::GPG;
+$gpg->gpgbin('/usr/bin/gpg');
+$gpg->encryptsafe(0); # we have to allow untrusted keys
This will not work well with persistent environments like Plack. The my could
be changed to our, but even better would be changing the way initialization is
handled such that a file-level variable is unnecessary.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:50:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:50:25 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:50:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:50:28 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20712|0 |1
is obsolete| |
--- Comment #104 from Jared Camins-Esakov ---
Created attachment 20788
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20788&action=edit
Bug 7143: history.txt and about page updates
- two new developers
- releases
Signed-off-by: Galen Charlton
Signed-off-by: Jared Camins-Esakov
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:52:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:52:47 +0000
Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897
--- Comment #31 from Mirko Tietgen ---
(In reply to Jared Camins-Esakov from comment #29)
> There is a small conflict in C4::Letter that I am not sure how to resolve.
> Does the from e-mail address have to be the patron's e-mail address for GPG
> to work? It seems to me we'd prefer it to be the library's e-mail address,
> if one is set, but I presume there's a reason for the change in the patch,
> so I wanted to ask for feedback on it.
I found the problem with the wrong address while I was working on this and
fixed it in Bug 10621 instead of here. I had initially fixed it in this bug and
then un-did it to have the seperate entry. I will change the patch when I have
a little more time, the old behaviour should not be reimplemented by this
patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:53:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 19:53:33 +0000
Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 01:32:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Sep 2013 23:32:35 +0000
Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821
--- Comment #5 from Chris Nighswonger ---
What call number system does this system use?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 03:26:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 01:26:57 +0000
Subject: [Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bgkriegel at gmail.com
--- Comment #3 from Bernardo Gonzalez Kriegel ---
Created attachment 20789
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20789&action=edit
Material type as determined by Leader/06 and Leader/07
008 do not forgets, because it don't know.
As stated in http://www.loc.gov/marc/formatintegration.html,
"Field 008 does not carry any explicit flag identifying the definition of
positions 18-34. Instead, the identification of the type of field 008 is
dependent on the content of Leader/06 (Type of record) and,in the case of
textual material (i.e., when Leader/06 contains value a), the content of
Leader/07 (Bibliographic level)."
So to fix this we need a way to pass Leader/06 and /07 to the plugin so it
learns and shows proper material type, and that if the leader is correctly
filled.
Attached is a PDF with all possible combinations on leader/06 /07 and what kind
of material type must be set.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 06:09:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 04:09:07 +0000
Subject: [Koha-bugs] [Bug 10823] New: add class info to enumchron data in
detail.tt, for better styling
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823
Bug ID: 10823
Summary: add class info to enumchron data in detail.tt, for
better styling
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: mtj at kohaaloha.com
QA Contact: testopia at bugs.koha-community.org
this is a trivial patch with no functional change
this patch adds class info to the item.serialseq and item.publisheddate values,
to allow better styling
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 06:25:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 04:25:18 +0000
Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in
detail.tt, for better styling
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 06:25:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 04:25:21 +0000
Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in
detail.tt, for better styling
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823
--- Comment #1 from Mason James ---
Created attachment 20790
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20790&action=edit
Bug 10823 - add class info to enumchron data in detail.tt, for better styling
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 06:55:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 04:55:12 +0000
Subject: [Koha-bugs] [Bug 10824] New: OAI-PMH repository/server not handling
time in "from" argument
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824
Bug ID: 10824
Summary: OAI-PMH repository/server not handling time in "from"
argument
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Web services
Assignee: koha-bugs at lists.koha-community.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
Currently, if you try to use time in a "from" argument with the Koha OAI-PMH
repository/server, you'll get unexpected results.
Case 1:
There are 3 records with the following timestamps:
2013-09-02 10:29:40
2013-09-05 13:44:33
2013-09-05 13:44:34
However, if you sent a request using "2013-09-02 8:29:40" or
"2013-09-02T8:29:40Z" (the latter being the 'proper' way), you'll only retrieve
the last 2 records of the 3 record set.
This is because we're using this code to check the "from" and "until"
arguments:
"WHERE DATE(timestamp) >= ? AND DATE(timestamp) <= ?"
We need to strip DATE() from around the timestamps.
If we just compare the normal timestamp, MySQL can handle properly compare the
timestamp against the following strings:
"2013-09-02"
"2013-09-02 8:29:40"
"2013-09-02T8:29:40Z" (NB This one produces a warning (not an error) so it's
less than ideal)
I'm proposing that we remove DATE() and include a regex to strip UTC
designators T and Z.
This way, we'll always be passing in "2013-09-02" or "2013-09-02 8:29:40" which
work perfectly.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:13:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:13:44 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
PK, not cardnumber
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636
--- Comment #9 from Srdjan Jankovic ---
1. I had problems with either borrowers changing card numbers, or being removed
(have no idea what is possible, but the situation is real, I'm using a clients
prod dump). In order to establish new PK there must be no nulls, so patronimage
should be purged first, something on the lines of DELETE FROM patronimage wHERE
NOT EXISTS(borrower).
2. The patch adds UNIQUE and then PK. I understand why UNIQUE, but that is
maybe an overkill. So it should either be removed (as in not included in the
statement), or dropped afterwards.
3. There should be an FK statement to replace dropped FK
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:27:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:27:21 +0000
Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian()
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #15 from Srdjan Jankovic ---
I could be wrong with those, so please double check: C4/Circulation.pm - if
should become unless ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:31:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:31:21 +0000
Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql
reports
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502
--- Comment #10 from Srdjan Jankovic ---
Sorry, didn't
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:32:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:32:09 +0000
Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support
groups of libraries
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |srdjan at catalyst.net.nz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:35:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:35:24 +0000
Subject: [Koha-bugs] [Bug 10825] New: detail.tt displays duplicated
enumchron values for serial items
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825
Bug ID: 10825
Summary: detail.tt displays duplicated enumchron values for
serial items
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: mtj at kohaaloha.com
QA Contact: testopia at bugs.koha-community.org
when a serial is received, its serialseq info is automatically copied into it's
item.enumchron field
when that newly created item is displayed in the staff details page both its
enumchron and serialseq values are displayed together.
the bug is - both values are identical creating a duplication of info
(pic attached)
the solution is to only display one of the two fields
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:37:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:37:44 +0000
Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time
in "from" argument
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:37:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:37:47 +0000
Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time
in "from" argument
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824
--- Comment #1 from David Cook ---
Created attachment 20791
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20791&action=edit
Bug 10824 - OAI-PMH repository/server not handling time in "from" argument
This patch remotes the DATE() function from around timestamp, and adds a
sub that strips the UTC designators "T" and "Z" from incoming "from" and
"until" arguments in OAI-PMH requests so that they're more compliant with
MySQL (and probably other databases as well).
TEST PLAN:
0) Note down a selection of timestamps from your biblio table
1) Enable your OAI-PMH server through the global system preferences
Web services tab.
2) Craft and submit a similar request to the following in your browser:
KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc&
from=2013-09-02T13:44:33Z&until=2013-09-05T13:44:33Z
Change the exact dates to accord with your timestamps, but keep the
YYYY-MM-DDTHH:MM:SSZ format.
3) Note the unexpected behaviour. A "from" argument with the timestamp
2013-09-02T13:44:33Z will show records from 2013-09-03 but not records
from 2013-09-02 even though the timestamp in the database will say
"2013-09-02 13:44:33".
4) APPLY THE PATCH
5) Resubmit the links you tried above
6) Note that the applicable records now appear!
--
Developer Note: We could've not stripped the UTC designators and used
DATE() around the parameters in the SQL queries, but that would have
lost the whole purpose of using times in the "from" arguments, since
they would've been generalized to just the dates.
I think this is probably the best solution. Admittedly, creating
"form_arg" and "until_arg" hashrefs in the ResumptionToken object
might not be ideal, but I preferred that to copying the
_strip_UTC_designator subroutine into two other objects. Perhaps this
sub could go somewhere else and be imported into those other two objects
but this seemed to be the most sensible decision. I'm open to other
opinions though.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:38:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:38:36 +0000
Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time
in "from" argument
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:39:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:39:31 +0000
Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron
values for serial items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825
--- Comment #1 from Mason James ---
Created attachment 20792
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20792&action=edit
pic
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:51:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:51:38 +0000
Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron
values for serial items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:51:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:51:40 +0000
Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron
values for serial items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825
--- Comment #2 from Mason James ---
Created attachment 20793
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20793&action=edit
Bug 10825 - detail.tt displays duplicated enumchron values for serial items
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:54:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 05:54:23 +0000
Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron
values for serial items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825
--- Comment #3 from Mason James ---
Created attachment 20794
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20794&action=edit
pic, after applied patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:34:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 07:34:36 +0000
Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |jonathan.druart at biblibre.co
| |m
QA Contact| |jonathan.druart at biblibre.co
| |m
--- Comment #10 from Jonathan Druart ---
QA comment:
This patch is consistent with the current work in progress on unit tests.
The KohaTest is obsolete, unused, buggy, etc.
The interesting code can be retrieve from the git log.
Marked as Passed QA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:36:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 07:36:11 +0000
Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20786|0 |1
is obsolete| |
--- Comment #11 from Jonathan Druart ---
Created attachment 20795
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20795&action=edit
Bug 10539: Remove unused unit tests in lib/KohaTest
This patch removes all files in lib/KohaTest and the associated script
t/db_dependent/database_dependent.pl.
The second patch deals with a few consequences.
Note that bug 10540 has been opened to save some interesting code from these
unit tests and inject them in the currently used t/db_dependent suite.
Test plan:
See second patch.
Signed-off-by: Jared Camins-Esakov
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:36:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 07:36:17 +0000
Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20787|0 |1
is obsolete| |
--- Comment #12 from Jonathan Druart ---
Created attachment 20796
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20796&action=edit
Bug 10539: Followup for removing KohaTest unit tests
Makefile.PL: Section for creating file t/test-config.txt removed.
Removes t/Makefile and t/rewrite-config-test too.
Modifies XISBN.t to remove two commented lines.
Test plan:
Grep for KohaTest, database_dependent, config-test, t/Makefile.
Run perl Makefile.PL and include running the test suite.
This may fail on t/00-valid-xml.t and t/QueryParser.t, but that is not the
result of this patch. Same for t/00-load.t with potential error on
Koha::Plugins::Base.
I had this result:
Test Summary Report:
t/00-valid-xml.t (Wstat: 1792 Tests: 381 Failed: 7)
Failed tests: 10, 30-31, 169, 181, 201-202
Non-zero exit status: 7
t/QueryParser.t (Wstat: 512 Tests: 0 Failed: 0)
Non-zero exit status: 2
Parse errors: No plan found in TAP output
Files=92, Tests=12385, 45 wallclock secs ( 1.74 usr 0.15 sys + 26.61 cusr
1.92 csys = 30.42 CPU)
Result: FAIL
Failed 2/92 test programs. 7/12385 subtests failed.
Signed-off-by: Jared Camins-Esakov
All tests pass, and I find no mention of the removed test code.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:48:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 07:48:36 +0000
Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search
results page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co
|y.org |m
--- Comment #7 from Jonathan Druart ---
QA comment:
Thanks for this second patch: all works as expected and there is not duplicated
code.
Note that the Closed column is not sortable, I will provide a followup.
Marked as Passed QA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:49:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Sep 2013 07:49:05 +0000
Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search
results page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20687|0 |1
is obsolete| |
--- Comment #8 from Jonathan Druart