From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 01:11:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2013 23:11:44 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Assignee|gmcharlt at gmail.com |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- Working on a "source-based" install set of instructions now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 13:36:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2013 11:36:41 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 --- Comment #4 from mathieu saby --- Previous test based on the assumption that "invoiced price includes tax" means "the price on the invoice printed by the vendor includes tax" (I have never been sure of the meaning of this ;-) ) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:47:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2013 21:47:51 +0000 Subject: [Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 --- Comment #3 from Robin Sheat --- I'm not sure. I think I just based it on the pattern used by other things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:52:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2013 21:52:26 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #5 from mathieu saby --- I copy the content of the bug Bug 10778 and close it, as it is a duplicate Mathieu Curently, statistic table contains some information about the item and the borrower (http://schema.koha-community.org/tables/statistics.html): For the item : - itemnumber - itemtype - ccode For the borrower - borrowernumber - associatedborrower - and maybe "usercode" (not documented in schemaspy, so I don't know what it means). I think we should store more information for the borrower : if the borrower record is deleted, we will not be able to get the useful informations (categorycode...) with a JOIN. I am not sure of Koha's behavior if the item or biblio is deleted : if the itemnumber and biblionumber is deleted from statistic table, we could also store more information (as homebranch, location, biblio.serial, biblioitems.itemtype) For the borrowers, I think we need : - categorycode - branchcode - sex - sort1 - sort2 and optionally the ability to record 3 or 4 custom fields with a syspref (for example, to store the extended attributes). Do you agree with that ? M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:52:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2013 21:52:45 +0000 Subject: [Koha-bugs] [Bug 10778] Store more information in statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10778 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from mathieu saby --- *** This bug has been marked as a duplicate of bug 7021 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:52:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2013 21:52:45 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #6 from mathieu saby --- *** Bug 10778 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:53:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2013 21:53:14 +0000 Subject: [Koha-bugs] [Bug 10735] koha-dump not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735 --- Comment #4 from Robin Sheat --- (In reply to Bert Burgemeister from comment #3) > The fallback is already sort of implemented. It just doesn't work > because xmlstarlet returns non-zero which kills koha-dump immediately > due to its "set -e" setting. It'd be better to fix that case with some error handling (or even just '|| true' to hide it if appropriate) than turn off the error aborting script-wide, as that may cause it to try to plow on rather than die if something else goes wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:56:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2013 21:56:12 +0000 Subject: [Koha-bugs] [Bug 10438] Packages pocket/name-versioning broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10438 --- Comment #1 from Robin Sheat --- I'm really not much of a fan of this idea, mostly (though not exclusively) because it prevents having an upgrade path into newer versions, and people could unknowingly end up on an unsupported version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 00:14:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2013 22:14:16 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #3 from mathieu saby --- I think we need to change the behavior of these subs in C4/Acquisitions.pm: GetOrders GetOrder GetOrdersByBiblionumber GetCancelledOrders GetPendingOrders SearchOrder GetLateOrders GetInvoices GetInvoiceDetails maybe also : GetHistory There is no join of acqorders and biblio in other subs. Katrin, I am not sure of the best way of doing it : do you think I can just edit the SQL for requesting deleted_biblio and deleted_biblioitem table? Or maybe it will have bad consequencies on performances? Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 02:17:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 00:17:59 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 02:18:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 00:18:03 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20742|0 |1 is obsolete| | --- Comment #15 from Srdjan Jankovic --- Created attachment 20750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20750&action=edit Bug 5904: ysearch.pl members improvements (Independent branches behaviour) Test plan: - Add a staff user foo in a library A - Add a staff user bar in a library B - log in as foo and try to search 'bar' - Switch on (Prevent) the new pref IndependentBranches - the search returns no result - log in as a superlibrarian - Check that you are allow to search all patrons. Signed-off-by: Srdjan -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 02:55:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 00:55:49 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Srdjan Jankovic --- fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 03:07:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 01:07:54 +0000 Subject: [Koha-bugs] [Bug 10727] Replace carriage return with
when writing hold notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- In such cases, it is slightly better to say (within the loop): local $_ = $message->{'content'}; S/// ... That saves two var copies. I will make that change when signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 04:44:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 02:44:17 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 --- Comment #4 from M. Tompsett --- Created attachment 20751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20751&action=edit rough draft not even close to done Still under revision. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 05:21:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 03:21:03 +0000 Subject: [Koha-bugs] [Bug 10811] New: Add a 999$c record matching rule to the MARC21 defaults Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 Bug ID: 10811 Summary: Add a 999$c record matching rule to the MARC21 defaults Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, the only default matching rules for MARC21 are ISBN and ISSN. However, I'm sure that many people would profit from having a 999$c "Koha biblionumber" record matching rule as well. 1) If you export your bib records to do some global/batch changes with another program (like MarcEdit), you can use this rule to replace the existing bib records with your modified records. 2) With my upcoming OAI-PMH harvesting feature, if you add a OAI-PMH repository with this rule in the configuration, you'll be able to automagically match updated records with the original records that you imported via OAI-PMH (the magic is that I check the incoming unique identifier against records in Koha, and if there is already a bib record in Koha matching that identifier, I write the biblionumber for that record back into the incoming record so that they match. It sounds convoluted but it works well). 3) People might have other ideas about this as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 05:47:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 03:47:28 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 05:47:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 03:47:31 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 --- Comment #1 from David Cook --- Created attachment 20752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20752&action=edit Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults This patch adds a default record matching rule for biblionumber using the 999$c and the Local-Number index. This is part of the optional marc21 SQL, as well as in the updatabase.pl script. TEST PLAN 0) Apply the patch 1) Run updatedatabase.pl 2) Export some MARC bibliographic records from Koha 3) Import those same MARC bibliographic records using the "KohaBiblio" record matching rule. 4) The incoming records should match perfectly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 05:48:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 03:48:19 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 05:57:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 03:57:06 +0000 Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19514|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 20753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20753&action=edit [SIGNED OFF] Bug 10564 - use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl When using UNIMARC XSLT for OPAC detail page, if record has a 856$u its content is displayed as a link. The syspref OPACURLOpenInNewWindow adds the option of opening in a new window (attribute target="_blank"). 856$u is also used in UNIMARC results XSLT but the use of OPACURLOpenInNewWindow syspref is missing. It exists for MARC21. This patch adds the use of OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl. Test plan : - In a UNIMARC catalog, enable XSLT for OPAC results page - Create a record with a link in 856$u and set second indicator to 0 - Set OPACURLOpenInNewWindow syspref on - At OPAC, perform a search that contains the record => You should see the link : "Click here to access online" - click on it => You shoud get to a new window (or tab depending on your browser configuration) - Set OPACURLOpenInNewWindow syspref off - re-perform the search - click on the link => You shoud stay in same window Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, no koha-qa errors Tested following plan after applying patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 05:57:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 03:57:24 +0000 Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 06:26:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 04:26:00 +0000 Subject: [Koha-bugs] [Bug 10324] Editorial series do not display correctly in normal view (UNIMARC / no XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10324 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18373|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 20754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20754&action=edit [SIGNED-OFF] Bug 10324 - Editorial series do not display correctly in normal view (UNIMARC / no XSLT) The patch corrects the issue -- the content of the field 225 shall be displayes under Series now. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 06:26:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 04:26:19 +0000 Subject: [Koha-bugs] [Bug 10324] Editorial series do not display correctly in normal view (UNIMARC / no XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10324 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:46:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 05:46:09 +0000 Subject: [Koha-bugs] [Bug 10727] Replace carriage return with
when writing hold notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:46:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 05:46:12 +0000 Subject: [Koha-bugs] [Bug 10727] Replace carriage return with
when writing hold notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20330|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 20755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20755&action=edit Bug 10727 : Replace carriage return with
when printing hold notices This patch replaces carriage return with
in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - checkin an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl Without the patch, the script generates a html file without
tags. If you run printoverdues.sh , the text in the resulting pdf file is all on one line With the patch, the script generates a html file with
tags and pdf file created by printoverdues.sh is well formatted. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:47:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 05:47:29 +0000 Subject: [Koha-bugs] [Bug 10727] Replace carriage return with
when writing hold notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 --- Comment #4 from Srdjan Jankovic --- Please disregard my comment, wasn't too intelligent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:02:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 06:02:46 +0000 Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:02:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 06:02:49 +0000 Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20320|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 20756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20756&action=edit Bug 10720 : substitution term in overdue notices shouldn't be removed if they don't match. It prevents use of html in notices to use with css Test plan : - define an overdue notice containing some valid substitution terms + some valid html tags ( or
Without patch, your html tags are missing in your html file With the patch, they are present and can be used with a css to generate a formatted pdf file. If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:04:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 06:04:50 +0000 Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- I've removed those lines, this script should use GetPreparedLetter anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:15:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 07:15:59 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #7 from Katrin Fischer --- Some of the information proposed by Mathieu is or might be a bit critical - so it would be nice to have a system preference to determine which fields are going to be saved into the statistics table. Maybe we could add the patron category as a first step. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:21:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 07:21:49 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #3 from David Cook --- Created attachment 20757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20757&action=edit Bug 10662 - Build OAI-PMH Harvesting Client N.B. This feature is still a work in progress. This commit represents my work to date on the OAI-PMH harvester, but it's not complete. While the core classes are operational, I still need to improve the cronjob, the DC to MARC21 XSLT, and the internal workings of the classes (mostly in terms of error handling, edge cases, and reporting). This patch adds several new files to Koha: Overview: 1) C4/OAI/Harvester.pm: This contains 2 classes. The Harvester class sets up the 6 OAI-PMH verbs (2 of which harvest records) and imports records into Koha. The Harvester::Record class is a helper class for processing records, transforming metadata, etc. At the moment, this is hardwired for MARC21 but it's easy enough to expand it out to other flavours (provided there are XSLTs there for the metadata transforms). 2) koha-tmpl/intranet-tmpl/prog/en/xslt/DC2MARC21slim.xsl: This is a XSLT which transforms oai_dc into MARC21. This is a lightweight XSLT based on one I found from the Library of Congress. I improved the Leader and I will endeavour to improve the 008 and map more fields in a more orderly way than this. However, it's a good start. 3) koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MARC21enhanced.xsl: This simply strips 999 fields from incoming records, adds the OAI-PMH unique identifier, and adds a 999 field if that unique identifier has already been imported in the past (the 999 is added so that automatic matching and replacement can take place on import). 4) misc/cronjobs/oai_harvester.pl: At the moment, this script takes database config for a OAI-PMH repository to create a Harvester object, then tries each OAI-PMH verb and imports the resulting records into Koha. 5) t/db_dependent/OAI_harvester.t: This is a unit test which uses Koha as the OAI-PMH repository and client in a circular loop. It should test the high level methods and go from retrieving database config to importing records. It uses the "rollback" method so you won't have a bunch of records imported into your database (although your autoincrement will probably go up anyway). Test Plan (For MARC21 users): 0) Apply the patch and run updatedatabase.pl (it will add two new tables to your database: oai_harvest and oai_harvest_repositories). I've documented them in kohastructure.sql. 1) For starters, run the OAI_harvester.t test. It should cycle through all the tests without any problems. If you there are problems, let me know on Bugzilla, in IRC, or via email. 2a) Next, if you feel safe importing records into your database, use the config from the unit test as an example and create an entry in your oai_harvest_repositories table. Be careful with the "import_mode". "Automatic" will automatically stage and import any records harvested via OAI-PMH. "Manual" will stage them but not import them. 2b) Once you're somewhat sure of your config, run oai_harvester.pl. The default is not to use automatic token resumption (so you should only have 50 records in your import batch most likely). You can change this in the cronjob itself. If you fully import this batch, try running "oai_harvester.pl" again. You shouldn't get any results (as you've already imported that batch of records). To try out the "replace/update" feature: update one of the original records you imported (out of that first 50), re-index, and re-run "oai_harvester.pl". You should now get 1 record in your batch which should automatically match the original. In "automatic" mode, it would automatically replace the record (although this can still be reverted in the Manage Staged MARC Records). In "manual" mode, you'll notice in the management interface that there has been a match for that record with the original. 3) To more fully explore: Examine C4/OAI/Harvester.pm. I wrote the POD at the end of August, so it's a bit out of date but it should be mostly accurate. I've tried to include as many comments as possible along the way as well. It's not a very sophisticated module. However, there are a lot of different scenarios that I'm trying to account for. I might've missed some use/edge cases, implemented bad code, or error handling. A place to start might be any FIXME or TODO messages. -- As I said at the top, this is still a work in progress, but I'd be happy to get any feedback or advice on how to proceed with this feature. I'll continue working on it and post updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:22:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 07:22:33 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20757|0 |1 is obsolete| | --- Comment #4 from David Cook --- Created attachment 20758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20758&action=edit Bug 10662 - Build OAI-PMH Harvesting Client N.B. This feature is still a work in progress. This commit represents my work to date on the OAI-PMH harvester, but it's not complete. While the core classes are operational, I still need to improve the cronjob, the DC to MARC21 XSLT, and the internal workings of the classes (mostly in terms of error handling, edge cases, and reporting). This patch adds several new files to Koha: Overview: 1) C4/OAI/Harvester.pm: This contains 2 classes. The Harvester class sets up the 6 OAI-PMH verbs (2 of which harvest records) and imports records into Koha. The Harvester::Record class is a helper class for processing records, transforming metadata, etc. At the moment, this is hardwired for MARC21 but it's easy enough to expand it out to other flavours (provided there are XSLTs there for the metadata transforms). 2) koha-tmpl/intranet-tmpl/prog/en/xslt/DC2MARC21slim.xsl: This is a XSLT which transforms oai_dc into MARC21. This is a lightweight XSLT based on one I found from the Library of Congress. I improved the Leader and I will endeavour to improve the 008 and map more fields in a more orderly way than this. However, it's a good start. 3) koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MARC21enhanced.xsl: This simply strips 999 fields from incoming records, adds the OAI-PMH unique identifier, and adds a 999 field if that unique identifier has already been imported in the past (the 999 is added so that automatic matching and replacement can take place on import). 4) misc/cronjobs/oai_harvester.pl: At the moment, this script takes database config for a OAI-PMH repository to create a Harvester object, then tries each OAI-PMH verb and imports the resulting records into Koha. 5) t/db_dependent/OAI_harvester.t: This is a unit test which uses Koha as the OAI-PMH repository and client in a circular loop. It should test the high level methods and go from retrieving database config to importing records. It uses the "rollback" method so you won't have a bunch of records imported into your database (although your autoincrement will probably go up anyway). Test Plan (For MARC21 users): 0) Apply the patch and run updatedatabase.pl (it will add two new tables to your database: oai_harvest and oai_harvest_repositories). I've documented them in kohastructure.sql. 1) For starters, run the OAI_harvester.t test. It should cycle through all the tests without any problems. If you there are problems, let me know on Bugzilla, in IRC, or via email. 2a) Next, if you feel safe importing records into your database, use the config from the unit test as an example and create an entry in your oai_harvest_repositories table. Be careful with the "import_mode". "Automatic" will automatically stage and import any records harvested via OAI-PMH. "Manual" will stage them but not import them. 2b) Once you're somewhat sure of your config, run oai_harvester.pl. The default is not to use automatic token resumption (so you should only have 50 records in your import batch most likely). You can change this in the cronjob itself. If you fully import this batch, try running "oai_harvester.pl" again. You shouldn't get any results (as you've already imported that batch of records). To try out the "replace/update" feature: update one of the original records you imported (out of that first 50), re-index, and re-run "oai_harvester.pl". You should now get 1 record in your batch which should automatically match the original. In "automatic" mode, it would automatically replace the record (although this can still be reverted in the Manage Staged MARC Records). In "manual" mode, you'll notice in the management interface that there has been a match for that record with the original. 3) To more fully explore: Examine C4/OAI/Harvester.pm. I wrote the POD at the end of August, so it's a bit out of date but it should be mostly accurate. I've tried to include as many comments as possible along the way as well. It's not a very sophisticated module. However, there are a lot of different scenarios that I'm trying to account for. I might've missed some use/edge cases, implemented bad code, or error handling. A place to start might be any FIXME or TODO messages. -- As I said at the top, this is still a work in progress, but I'd be happy to get any feedback or advice on how to proceed with this feature. I'll continue working on it and post updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:24:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 07:24:08 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:24:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 07:24:19 +0000 Subject: [Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18742|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 20759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20759&action=edit [3.10.x] Bug 10221 - hold expiration doesn't show on patron's list of holds When viewing the list of a patron's holds on the circulation page or the patron detail page the table of holds doesn't display the holds expiration date, if present. This patch adds display of the hold expiration date. To test, place a hold for a patron and set an expiration date for it. View the patron's existing holds on both circulation.pl and moremember.pl. The expiration date you chose should appear in the table of information about existing holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:40:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 07:40:12 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #5 from David Cook --- Thoughts on things to include: 1) Add a preference/config for using identifier + datestamp OR identifier + datestamp + metadataPrefix as the indicator of the highest order of uniqueness. 2) Add an email feature that tells library staff to check a report which enumerates the status of records imported via OAI-PMH. These can be create (new records), replace (updated records), deleted (for incoming records with a status of deleted), or ambiguous (essentially a new record but linked to multiple existing bib records. These are almost certainly duplicates but require manual merging since it's tough to know which is the real authoritative record). I was thinking perhaps of sending an email containing a link to a Template Toolkit page (so that translation would be possible), which would contain the import/history log. 3) Improving error handling 4) Make the import options more configurable? Although I think the hardcoded options for always replacing a bib match, adding for no match, and ignoring items are probably pretty good. There might be other use cases where people want something different though, so configuration might be a good idea (although ignoring items is fairly essential, as you could duplicate items if you're importing updated records with items). Perhaps the MARC21 XSLT should also strip 952 fields. 5) When using the cronjob, if the "from" date for a repository is "null", check for existing records in Koha, and use the latest "datestamp"? This way we're able to do selective harvesting automatically without having to update our configuration. (I'll probably add this one soon.) 6) Matching rules: a) Check what MARC field that system uses for its biblionumber. Check if there is a matching rule for that field in Koha. If not, create one? Having this matching rule is essential for matching updated records. 7) Improving the DC => MARC conversion (might look at this soon too...it will always be a "best guess" but it has room for a lot of easy improvement) 8) Make an OAI-PMH harvesting web UI. This would allow people to plug in the baseURL for a remote OAI-PMH repository and use the 6 verbs on it. I imagine it being a good way of people getting used to what a OAI-PMH repo has, so that they can set up the automatic cronjob configuration. It could also be a good idea to allow the "ImportRecordsIntoKoha" method for selective harvesting. That said, if it's too easy to use, it might also be abused by someone who doesn't know what they're doing. If there were a GUI, it would need a permission and/or system preference most likely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:13:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 08:13:35 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 --- Comment #5 from Koha Team Lyon 3 --- Hello Mathieu, I glance your test in http://pro.test2.biblibre.com/, for the budget spent in the summary home page, it's normal you see 9 because it take the actual price for the invoice. So with the preference "invoiced price includes tax", it means "the atcual price on the invoice printed by the vendor includes tax", the price spent is really 9. So for me, the patch is working as it's excepted. Can you check it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 12:53:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 10:53:25 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 --- Comment #6 from mathieu saby --- Well, well, I fear I am still lost... In reception Koha tells me the unit cost is "9.49" (so, I suppose price including tax). But I don't find again this 9.49 in Acq home page. For me, "Budget spent" must not take the raw price of the invoice, if this raw price does not include tax. In this case, budget spent must add tax to this raw price. Or maybe there is a bug in reception page? What is the meaning of the "unit cost" when we receive item : does it mean 1/ "cost actually written by the vendor on his invoice (with or without tax, depending of invoiceincgst value) ? or 2/ "price actually paid by the library (so always WITH tax), based on the cost written by the vendor on the invoice" ? Maybe Nicole could help me on this point? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 13:52:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 11:52:53 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se --- Comment #6 from Viktor Sarge --- I'm excited to see this functionality being developed as we will work with just the scenario you initially mentioned with a union catalogue providing quality records that we import automatically as our book vendor add them to our account in the union catalogue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:16:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 12:16:22 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- (In reply to Chris Hall from comment #10) > Pushed to 3.8.x, will be in 3.8.17 Chris, This patch produces an error (see http://lists.koha-community.org/pipermail/koha-devel/2013-September/039649.html) updating the database. Since bug 7420 is not pushed in 3.8.x, I think this fix should not be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:16:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 12:16:34 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7420 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:16:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 12:16:34 +0000 Subject: [Koha-bugs] [Bug 7420] Add max fines to circulation matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10490 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:35:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 12:35:48 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #60 from Jonathan Druart --- (In reply to Katrin Fischer from comment #59) > I think this change might be in conflict with the big serials pattern patch > that has reached 'Passed QA' already (bug 7688). I already talk about this possible problem with Julian (author of the feature 7688). On a functional point of view the 2 features are not in conflict but, inevitably, the patches will not apply cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:02:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 13:02:40 +0000 Subject: [Koha-bugs] [Bug 4823] Raw Socket interface failing to accept connections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4823 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Colin Campbell --- Closing as resolved. This may have been caused by a configuration issue. If spare servers is set to zero the server will not ensure that a server is available to answer incoming connections. When a unit attempts to reconnect all existing servers may be sitting on old connections they still think are valid (waiting for the next request that never comes), as no spare has started up the connection is refused -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:17:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 14:17:48 +0000 Subject: [Koha-bugs] [Bug 10812] New: new check-ou warning: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812 Bug ID: 10812 Summary: new check-ou warning: Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 20760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20760&action=edit warning example Our patrons very often want to check if selected books they already read. Can we add custom warning for item which patrad already had some time ago? Message can looks like example attached file or similar. Very useful can be setting for: - some types of items don't generate this warning (ofter loaned items for example some CD-ROMs, maps or special documents) - some patrons don't want to be inform about it (checkbox in their detail?) Thank You Mike -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:18:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 14:18:06 +0000 Subject: [Koha-bugs] [Bug 10812] new check-ou warning: In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:19:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 14:19:14 +0000 Subject: [Koha-bugs] [Bug 10812] new check-ou warning: In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:31:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 14:31:27 +0000 Subject: [Koha-bugs] [Bug 8605] cs-CZ: Filesystem sent error: No such file or directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8605 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 17:17:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 15:17:59 +0000 Subject: [Koha-bugs] [Bug 1633] Add ability to take book cover images from local img db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #88 from Manos PETRIDIS --- The bug you're looking for, the one where local cover images fail to show, is #9737. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 20:20:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 18:20:00 +0000 Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 20:20:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 18:20:06 +0000 Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 20761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20761&action=edit Bug 7813: Ability to delete local cover images This patch adds the ability to delete local cover images from the detail page. It adds a 'x' button to trigger the deletion. It occurs using a new SVC script called cover_images that accepts the following parameters: - action - biblionumber (used for checking imagenumber validity) - imagenumber (repeatable) It then deletes all valid images passed and returns a JSON object containing the imagenumbers and the deletion status (1/0). The operation is triggered using jQuery.ajax, and with the response the corresponding images get deleted. Note: currently one image is deleted at a time, but the code is there to be used. To test: - Open the detail page fr a biblionumber containing one or more cover images, go to its images tab. - Apply the patch, reload the page, go to the images tab. - Thumbnails should look better than before ;-) - An 'X' button should show below each cover. - Clicking the 'X' button should trigger an alert message asking for confirmation. a) Cancel: nothing happens, reload the page and check nothing got deleted. b) Accept: the deleted image should be gone, reload the page to check it doesn't exist anymore and is not a browser/DOM manipulation trick. - Signoff Note: check having more cover images than those that fit the width and see it wraps fine. Any comments are welcome, this is WIP. Thanks To+ P.S. I chose not to implement every possible action on the svc script, but another bug could be filled for more improvements. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 22:47:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 20:47:06 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- Setting to failed to get Kyle's attention to comment#18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 00:02:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 22:02:37 +0000 Subject: [Koha-bugs] [Bug 10813] New: changing sort on tag results shows more results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10813 Bug ID: 10813 Summary: changing sort on tag results shows more results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org I have a report that when you click a tag in the tag cloud and then change the sort option on the top right it shows no results found in koha 3.10.10 when I test this in master I get results, but too many - I get results for a keyword search instead of the tag search. Either way there is a problem with being able to change the sort on a tag search results page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 00:59:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2013 22:59:00 +0000 Subject: [Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Pablo L?pez Liotti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paliotti at mdp.edu.ar --- Comment #2 from Pablo L?pez Liotti --- This issue was reported today to me by my library staff. If the procedure of change field 008 values is repeated sometimes, finally it?s possible save the record with correct values. There is any patch o tip to prevent this? We are using 3.12.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 03:22:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 01:22:12 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #4 from Srdjan Jankovic --- DDL statements ( ALTER TABLE ) cannot be rolled back, and should not be part of transaction. In that respect the update transaction makes no sense, and should be removed. If some kind of failure rollback needs to be implemented, it has to be done in some other way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 03:27:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 01:27:29 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 03:27:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 01:27:32 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #31 from Jared Camins-Esakov --- Created attachment 20762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20762&action=edit Bug 10240 follow-up: fix display Fix the following two issues: 1) After paying a fine when offline the fine amount becomes NaN. 2) For previous checkouts for a pratron the title and barcode fields have the wrong infomation in them (i.e. they have been swapped) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 03:43:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 01:43:29 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #7 from Srdjan Jankovic --- A philosophical question - changes like this, consisting of only removing unused/unwanted code, can those be self-signed, and go to QA directly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 05:10:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 03:10:50 +0000 Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 05:10:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 03:10:53 +0000 Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20761|0 |1 is obsolete| | --- Comment #7 from David Cook --- Created attachment 20763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20763&action=edit Bug 7813: Ability to delete local cover images This patch adds the ability to delete local cover images from the detail page. It adds a 'x' button to trigger the deletion. It occurs using a new SVC script called cover_images that accepts the following parameters: - action - biblionumber (used for checking imagenumber validity) - imagenumber (repeatable) It then deletes all valid images passed and returns a JSON object containing the imagenumbers and the deletion status (1/0). The operation is triggered using jQuery.ajax, and with the response the corresponding images get deleted. Note: currently one image is deleted at a time, but the code is there to be used. To test: - Open the detail page fr a biblionumber containing one or more cover images, go to its images tab. - Apply the patch, reload the page, go to the images tab. - Thumbnails should look better than before ;-) - An 'X' button should show below each cover. - Clicking the 'X' button should trigger an alert message asking for confirmation. a) Cancel: nothing happens, reload the page and check nothing got deleted. b) Accept: the deleted image should be gone, reload the page to check it doesn't exist anymore and is not a browser/DOM manipulation trick. - Signoff Note: check having more cover images than those that fit the width and see it wraps fine. Any comments are welcome, this is WIP. Thanks To+ P.S. I chose not to implement every possible action on the svc script, but another bug could be filled for more improvements. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook Works as described. This is a nice addition! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 05:58:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 03:58:50 +0000 Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #8 from David Cook --- Alas, when I try in 3.8.0 (after manually merging the patch with the code), I get this error: Uncaught Syntax error, unrecognized expression: [{"imagenumber":"13","deleted":1}] jquery.js:19 F.filter jquery.js:19 F jquery.js:19 F jquery.js:19 o.fn.o.find jquery.js:12 jQuery.fn.find jquery.hotkeys.min.js:1 o.fn.o.init jquery.js:12 l.jQuery.l.$ jquery.js:12 $.ajax.success detail.pl?biblionumber=179:102 I jquery.js:19 N jquery.js:19 Maybe I made a mistake doing the merge? Or maybe an older version of jQuery has a harder time processing JSON but that seems strange... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 09:33:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 07:33:30 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #2 from Jonathan Druart --- Created attachment 20764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20764&action=edit Bug 10807: FIX if zebra is down, total is undef The search_history.total column cannot be undef. This patch adds a default value for the total value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 13:53:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 11:53:19 +0000 Subject: [Koha-bugs] [Bug 2136] Cataloging Search on Staff Side Not Consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2136 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Nicole C. Engard --- *** This bug has been marked as a duplicate of bug 10047 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 13:53:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 11:53:19 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 --- Comment #9 from Nicole C. Engard --- *** Bug 2136 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:10:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 12:10:43 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20724|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 20765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20765&action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:11:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 12:11:04 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:11:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 12:11:16 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #6 from Kyle M Hall --- Thanks for the info! Does this new patch have a more sensible database update? Kyle (In reply to Srdjan Jankovic from comment #4) > DDL statements ( ALTER TABLE ) cannot be rolled back, and should not be part > of transaction. In that respect the update transaction makes no sense, and > should be removed. If some kind of failure rollback needs to be implemented, > it has to be done in some other way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:59:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 12:59:24 +0000 Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10708 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:59:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 12:59:24 +0000 Subject: [Koha-bugs] [Bug 10708] make fine receipt customizable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10027 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:03:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 14:03:59 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:04:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 14:04:03 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20750|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 20766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20766&action=edit Bug 5904: ysearch.pl members improvements (Independent branches behaviour) Test plan: - Add a staff user foo in a library A - Add a staff user bar in a library B - log in as foo and try to search 'bar' - Switch on (Prevent) the new pref IndependentBranches - the search returns no result - log in as a superlibrarian - Check that you are allow to search all patrons. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:58:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 14:58:57 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19217|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 20767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20767&action=edit Bug 10502 - Add independent branches option for sql reports This patch adds the ability to hide reports created by other libraries based on the new IndependentBranchesReports system preference. This is accomplished by adding a branchcode field to the sql reports, which is set on report creation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranchesReports 4) Log in with a non-superlibrarian staff account 5) View existing sql reports, you should see no difference. Existing reports are 'grandfathered' in, assuming that existing reports may be used by multiple libraries or library groups. 6) Ensure you have selected a library to act as via the "set library" link. 7) Create a new sql report. 8) Verify it was created and you can view and edit it. 9) Change the logged in library to a difference branch. 10) Observe that the report is no longer visible in the reports list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:58:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 14:58:55 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 18:25:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 16:25:00 +0000 Subject: [Koha-bugs] [Bug 10814] New: add a link to an authorized value Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10814 Bug ID: 10814 Summary: add a link to an authorized value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be great if we could add a link to an authorized value (location specifically) that would then show in the OPAC as a clickable label. The idea would be to have a shelving location with a link to an image of a library map showing where that location is. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 18:29:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 16:29:49 +0000 Subject: [Koha-bugs] [Bug 7813] Add ability to delete local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813 --- Comment #9 from Tom?s Cohen Arazi --- (In reply to David Cook from comment #8) > Alas, when I try in 3.8.0 (after manually merging the patch with the code), > I get this error: > > Uncaught Syntax error, unrecognized expression: > [{"imagenumber":"13","deleted":1}] jquery.js:19 > > Maybe I made a mistake doing the merge? Or maybe an older version of jQuery > has a harder time processing JSON but that seems strange... I'm not sure about that one, but it might be due to: - wrong jquery version (incorrectly processing the application/json content-type) - wrong JSON Perl library (not outputting the right format) I'd like to note that I used bootstrap on this patch, and there are some visual gli-glitches when merging into 3.8.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 18:30:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 16:30:57 +0000 Subject: [Koha-bugs] [Bug 10815] New: can click unapproved tags in 'my tags' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10815 Bug ID: 10815 Summary: can click unapproved tags in 'my tags' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org In the OPAC I can see my tags even if they are not approved - this is OK. If I click one of those tags though I get no results. So the tags shouldn't be clickable if not approved or the tag click should work even if the word isn't approved. Either way works for me, but it seems like an oversight/bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:00:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 18:00:24 +0000 Subject: [Koha-bugs] [Bug 10068] Move from the utf8:: pragma methods to Encode:: In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:01:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 18:01:41 +0000 Subject: [Koha-bugs] [Bug 10438] Packages pocket/name-versioning broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10438 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:20:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 18:20:30 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #30 from Kyle M Hall --- Created attachment 20768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20768&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup 4 - Don't assume borrowernumber 1 exists in unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:20:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 18:20:27 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:21:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 18:21:02 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #31 from Kyle M Hall --- Liz, I think the problem with the unit test is that I'm assuming there is a borrower with a borrowernumber of 1 that is the inital Koha Admin account created during installation. Is this an improper assumption? I'm guessing it is. I've attached another followup to remedy the situation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 00:58:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 22:58:44 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 --- Comment #12 from Dan Scott --- (In reply to mathieu saby from comment #11) > Could you tell me if a followup for UNIMARC is needed ? Yes, at this point only support for MARC21 has been created and merged. I'm not at all familiar with UNIMARC, thus equivalent XSLT changes for UNIMARC would be great. I would be happy to help vet the HTML+RDFa output from any such changes! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 01:43:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 23:43:36 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #7 from Srdjan Jankovic --- No, this is as good as it can be. The only thing that I'm not sure of is whether you should reinstate AutoCommit and RaiseError straight after eval. I hate to admit that whenever I had a db update it was always simple and I started with copying one before, so I'm not familiar with AutoCommit and RaiseError policy in updatedatabase.pl. In a way, because it is a single change within transaction, you can even get away with not changing AutoCommit at all (RaiseError is still in order). If you are happy I'll proceed with sign-off, and we'll let QA team cast the final verdict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 01:57:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2013 23:57:12 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 --- Comment #8 from Srdjan Jankovic --- Undefined subroutine &C4::Branch::GetIndependentGroupModificationRights called at /home/srdjan/koha/dev/C4/Reports/Guided.pm line 676. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 05:44:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 03:44:09 +0000 Subject: [Koha-bugs] [Bug 10816] New: Relational operators in Search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10816 Bug ID: 10816 Summary: Relational operators in Search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org In each of the version 3 manuals, it says that a person can compose a query like so: "yr,st-numeric=>2000". However, when I try this, I get no results. I have to use "yr,st-numeric,ge=2000" to get the actual results. I presumed that the "buildQuery" sub translated => into ge, but maybe that's not happening (anymore or at all)? http://manual.koha-community.org/3.12/en/searchguide.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 09:12:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 07:12:08 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 --- Comment #13 from mathieu saby --- I will open a specific bug for unimarc and try to take a look. Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:04:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 09:04:03 +0000 Subject: [Koha-bugs] [Bug 10654] Add feature: export basket in CSV, list of custom formats for various vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10654 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.simonetti at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:18:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 09:18:16 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19751|0 |1 is obsolete| | --- Comment #45 from Chris Cormack --- Created attachment 20769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20769&action=edit Bug 7295: More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all If user is superlibrarian, or if he has permission acquisition = 1 (GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON). He's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl) Signed-off-by: Sonia Bouis Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:18:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 09:18:30 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19752|0 |1 is obsolete| | --- Comment #46 from Chris Cormack --- Created attachment 20770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20770&action=edit Bug 7295: Follow-up: Several fixes - List of libraries in basket.pl is now sorted by branch name, not code - When IndependantBranches is ON, user has only the possibility to set basket branch to its own branch, or to no branch at all. - When basket do not belong to any branch, selected branch by default is connection branch (was 'no branch') - added id attributes to both added li elements - change description of 'order_manage_all' permission to make it clearer. - remove Test::MockModule dependency Signed-off-by: Sonia Bouis Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:18:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 09:18:42 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:18:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 09:18:47 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19754|0 |1 is obsolete| | --- Comment #47 from Chris Cormack --- Created attachment 20771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20771&action=edit Bug 7295 [follow-up] More granular permissions for baskets Replace simple-quoted string by double-quoted string Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:20:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 09:20:59 +0000 Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 11:21:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 09:21:04 +0000 Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19883|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 20772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20772&action=edit Bug 10634 - Use datatables for course details items table We should make the course items table in the course details a datatable to enable searching or sorting. Test Plan: 1) Apply this patch 2) View the details page for a course with items 3) Verify the table displays and is now a datatable Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 12:15:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 10:15:16 +0000 Subject: [Koha-bugs] [Bug 10817] New: SIPserver does not return holds info when requested Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Bug ID: 10817 Summary: SIPserver does not return holds info when requested Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com If hold items info is requested using a patron information request it is not returned. Sip devices need this to show to the user what books they have on hold and what holds they have awaiting collection. While the software goes through the motion of supplying this data, it has not retrieved it to populate the fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 12:51:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 10:51:41 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:13:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 11:13:39 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 --- Comment #9 from Kyle M Hall --- Did you apply the patch for 10276 first? That subroutine is contain in that bug's patch. Kyle (In reply to Srdjan Jankovic from comment #8) > Undefined subroutine &C4::Branch::GetIndependentGroupModificationRights > called at /home/srdjan/koha/dev/C4/Reports/Guided.pm line 676. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:14:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 11:14:21 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18850|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 20773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20773&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:14:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 11:14:31 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18715|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 20774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20774&action=edit Bug 10278 - Add ability to hide items and records from search results for Independent Branches For the staff intranet, enabling IndependentBranchesRecordsAndItems will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library. In add addition, all items whose homebranch is not that libraries will be filtered and hidden from the search results and record details. This system preference will not affect the OPAC, unless the environment variable BRANCHCODE is defined in the koha-httpd.conf file. If it is defined, the same filters are applied to the OPAC, but based on the branchcode value of the environment variable BRANCHCODE, rather than the logged in branch. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesRecordesAndItems 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:14:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 11:14:49 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18849|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 20775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20775&action=edit Bug 10263 - Add ability to limit which branch can edit a bibliographic record ( IndependentBranchesMarcEditing ) Right now, it's possible to limit who can edit items by using IndependantBranches. However, Koha has no method of limiting who can edit bibliographic records, as they have no defined owner. This patch adds a new system preference IndependentBranchesMarcEditing. If this new syspref is enabled, a librarian can only edit or delete a bib record if his or her logged in branch code matches the branchcode in biblio.branchcode. This feature does not affect the ability to edit or delete items, as that functionality is determined by IndependantBranches. This patch adds the 'branches_optional' field to the authorised values pulldown for MARC fields and subfields in the MARC frameworks editor. 'branches_optional' behaves exactly like 'branches' except it includes an "empty" choice so the branch does not have to be set. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Map a nonrepeatable field/subfield to biblio.branchcode ( e.g. 951$o ) Pro-tip: Use the authorised value 'branches_optional' to get a pulldown of libraries instead of entering the branchcode manually. 4) Edit a record, and add a branchcode. 5) Log in as a non-superlibrarian with cataloging priveleges 6) Change the logged in branch to a branch other than the one you entered in the record. 7) You should note the 'edit' pulldown for the record is missing the "Edit record" and "Delete record" options. 8) Switch the logged in branch to match the branchcode of the record. 9) You should now see the edit and delete options for that record. 10) Attempt to edit a record with no branchcode defined, you should be able to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:15:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 11:15:25 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #119 from Mike --- I found same problem in 3.12.x in Czech translation. Problem on: /cgi-bin/koha/members/members-home.pl /cgi-bin/koha/admin/preferences.pl?tab=circulation /cgi-bin/koha/admin/preferences.pl?tab=opac /cgi-bin/koha/admin/preferences.pl?tab=patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:17:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 11:17:10 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19229|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 20776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20776&action=edit Bug 10277 - Add C4::Context->IsSuperLibrarian() The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. Test Plan: 1) Apply this patch 2) Verify superlibrarian behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:21:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 11:21:23 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #8 from Kyle M Hall --- That sounds good to me! > If you are happy I'll proceed with sign-off, and we'll let QA team cast the > final verdict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:39:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 11:39:12 +0000 Subject: [Koha-bugs] [Bug 10818] New: System preference OAI-PMH:ConfFile isn't translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Bug ID: 10818 Summary: System preference OAI-PMH:ConfFile isn't translatable Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr This text, from System preference OAI-PMH:ConfFile, isn't translatable, and is still in english in the staff interface: "If empty, Koha OAI Server operates in normal mode, otherwise it operates in extended mode. In extended mode, it's possible to parameter other formats than marcxml or Dublin Core. OAI-PMH:ConfFile specify a YAML configuration file which list available metadata formats and XSL file used to create them from marcxml records." The reason is, obviously, that this text isn't in the *-pref.po files on translate.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 13:39:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 11:39:29 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 14:42:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 12:42:51 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 14:46:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 12:46:40 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #61 from Kyle M Hall --- (In reply to Jonathan Druart from comment #60) > (In reply to Katrin Fischer from comment #59) > > I think this change might be in conflict with the big serials pattern patch > > that has reached 'Passed QA' already (bug 7688). > > I already talk about this possible problem with Julian (author of the > feature 7688). On a functional point of view the 2 features are not in > conflict but, inevitably, the patches will not apply cleanly. I suppose the big question is: which of the two will be easier to rebase over top the other. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:10:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 13:10:14 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 20777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20777&action=edit Proposed Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:14:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 13:14:27 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:14:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 13:14:29 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19435|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 20778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20778&action=edit Bug 10272 - CheckReserves returns not respecting ReservesControlBranch CheckReserves is using the CircControl system preference to determine what patrons an item can fill a hold for. It should be using ReservesControlBranch instead. Test Plan: 1) Set ReservesControlBranch to "item's home library". 2) Create an item at Library A, place holds for it for patrons at Library B, Library C, and Library A in that order, for pickup at the patrons home library. 3) Make sure the holds policy for Library A is set to Hold Policy = "From home library" and Return Policy = "Item returns home". Make sure the holds policies for the other libraries are set to Hold Policy = "From any library". 4) Check the item in at Library C, the hold for the patron at Library B should pop up, even though it's in violation of the circulation rules. Don't click the confirm button! 5) Apply this patch, and reload the page, now the hold listed should be for the last hold, the hold for the patron at Library A, which is correct. This patch adds the subroutine C4::Reserves::GetReservesControlBranch as an equivilent to C4::Circulation::_GetCircControlBranch. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:50:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 13:50:33 +0000 Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the 'status' option switch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:51:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 13:51:38 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 16:20:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 14:20:53 +0000 Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 16:24:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 14:24:43 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Galen Charlton --- Pushed to master. Thanks, Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 16:27:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 14:27:00 +0000 Subject: [Koha-bugs] [Bug 10755] Add "Keyword as Phrase" to staff client advanced search indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 16:29:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 14:29:39 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 --- Comment #57 from Jonathan Druart --- Kyle, first patch does not apply cleanly (conflicts in opac-detail.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 16:50:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 14:50:21 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 --- Comment #9 from Galen Charlton --- A relevant discussion on koha-devel - http://lists.koha-community.org/pipermail/koha-devel/2013-September/039662.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:11:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 15:11:29 +0000 Subject: [Koha-bugs] [Bug 10503] incorrect initialization parameters passed to Memoize::Memcached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- Looks good to me, the patch works as expected on Debian Wheezy. > This patch also corrects SQLHelper so that it no longer tries to > use the deprecated (and removed) memcached_servers setting in koha-conf.xml; Why do you say that? it is still in used by Koha/Template/Plugin/Cache.pm and appears in debian/templates/koha-conf-site.xml.in. Should we remove these occurrences too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:31:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 15:31:07 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:33:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 15:33:15 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #108 from M. Tompsett --- Created attachment 20779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20779&action=edit Reconstructed attempt for the upload plugin feature. This patch should obsolete all the other stuff, but since I am not the original author, but I really want this patch in, I have done my best to reconstruct it. I decided not to obsolete, in the case I that missed something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:36:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 15:36:15 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #109 from M. Tompsett --- As far as I can tell: - configure the koha-conf.xml with the appropriate values - make sure the directories exist and have the correct permissions /home/mtompset/koha-dev/var/lib/plugins 1 /home/mtompset/kohaclone/koha-tmpl/uploads - link 856$u to the upload.pl plugin. - test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:39:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 15:39:36 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #110 from Jared Camins-Esakov --- (In reply to M. Tompsett from comment #109) > As far as I can tell: > - configure the koha-conf.xml with the appropriate values > - make sure the directories exist and have the correct permissions > /home/mtompset/koha-dev/var/lib/plugins > 1 Please provide an updated test plan that reflects your new dependency on Koha's plugin system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:04:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 16:04:58 +0000 Subject: [Koha-bugs] [Bug 10819] New: Allow for auto filling of holds when items are checked in via SCO Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10819 Bug ID: 10819 Summary: Allow for auto filling of holds when items are checked in via SCO Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: cnighswonger at foundations.edu QA Contact: testopia at bugs.koha-community.org When an item with a hold on it is checked in via the SCO module (web), no further processing is done which results in the hold being overlooked unless the circulation desk workflow includes a regular run of the hold reports. The least fix for this would be to add a system pref allowing for the option of auto-filling the highest priority hold on an item checked in via the SCO module. Perhaps other options allowing for various alternate workflows might be added here as well. I'm listing this as an enhancement because depending on one's workflow, this may not be a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:11:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 16:11:19 +0000 Subject: [Koha-bugs] [Bug 8891] "Long overdue (lost)" items in search results show garbled information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8891 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:13:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 16:13:23 +0000 Subject: [Koha-bugs] [Bug 10820] New: Lost items on search results don't jive with record details Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820 Bug ID: 10820 Summary: Lost items on search results don't jive with record details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In the OPAC, if an items is both lost and checked out, it will show as lost on the search results, and checkout out in the record details. The lost status should take precedence over the checked out status, as the checked out status may lead a patron to believe the book may return soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:13:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 16:13:29 +0000 Subject: [Koha-bugs] [Bug 10820] Lost items on search results don't jive with record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:16:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 16:16:49 +0000 Subject: [Koha-bugs] [Bug 10820] Lost items on search results don't jive with record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:16:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 16:16:51 +0000 Subject: [Koha-bugs] [Bug 10820] Lost items on search results don't jive with record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820 --- Comment #1 from Kyle M Hall --- Created attachment 20780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20780&action=edit Bug 10820 - Lost items on search results don't jive with record details In the OPAC, if an items is both lost and checked out, it will show as lost on the search results, and checkout out in the record details. The lost status should take precedence over the checked out status, as the checked out status may lead a patron to believe the book may return soon. Test Plan: 1) Check an item out to a patron 2) Set it to lost ( requires itemlost to be revealed in the framework for the items editor ). 3) Rebuild your zebra indexes 4) Run a search where that item is in the results list 5) Note the item is marked as lost 6) View the record details 7) Note the item is listed as "checked out" 8) Apply this patch 9) Repeat steps 4-6, note the item is now listed as lost -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:44:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 16:44:28 +0000 Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:00:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 17:00:50 +0000 Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:15:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 17:15:35 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:20:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 17:20:08 +0000 Subject: [Koha-bugs] [Bug 10821] New: label pdf adding in strange breaking Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Bug ID: 10821 Summary: label pdf adding in strange breaking Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 20781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20781&action=edit call number Let's start here - the CSV, XML and Quick label creator do not have this problem - it's purely the PDF. So see the attached images. The call number is 'Script H82 E45' the label is set to print itemcallnumber only and yet with it prints it makes the label look like this (also attached): SCR .I P T H82 E45 It's adding spaces and a dot that don't belong there. I have changed the font size and it still does it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:20:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 17:20:35 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #1 from Nicole C. Engard --- Created attachment 20782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20782&action=edit pdf call number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:41:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 17:41:46 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #2 from Chris Nighswonger --- Please post an example of the expected split call number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 20:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 18:14:09 +0000 Subject: [Koha-bugs] [Bug 10822] New: Matcher should use SimpleSearch for auths Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10822 Bug ID: 10822 Summary: Matcher should use SimpleSearch for auths Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com QA Contact: testopia at bugs.koha-community.org Although C4::Matcher now supports both bibliographic and authority records, it has been using SearchAuthorities for authorities. Ideally it should use SimpleSearch when possible as part of our ongoing efforts to centralize, normalize, and de-insanify the search code, and in order to provide the user with additional indexes under QueryParser. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 20:16:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 18:16:34 +0000 Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master -- thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 20:30:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 18:30:41 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #3 from Nicole C. Engard --- What do you mean - how should it split? It should split at the spaces and/or dots so Script H82 E45 But instead the PDF is adding in a dot and breaks in the middle of the word (and it's not font size cause I made it super small and it still does it. In the CSV, quick spine label and the XML it's not splitting the word 'Script' like the PDF is. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:01:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:01:24 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18714|0 |1 is obsolete| | --- Comment #35 from Jared Camins-Esakov --- Created attachment 20783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20783&action=edit Bug 7419: General-purpose record deduplicator This patch adds a script for deduplicating records. It is most useful for authority records but by design could be easily extended for use with bibliographic records, if someone had a good use case. See the follow-up for an updated test plan. Complete POD documentation: SYNOPSIS dedup_records.pl --match=1 -a dedup_records.pl --match="LC-card-number/010a" --select="date" \ --limit="authid > 367123592" -a dedup_records.pl --match="Match/100abcdefghijklmnopqrstuvwxyz" \ --select="source=DLC" --select="date" \ --limit="authtypecode='PERSO_NAME'" -a DESCRIPTION This script will identify duplicate records, and either suggest that you merge them (in the case of bibliographic records) or automatically merge them for you (in the case of authority records). OPTIONS --help Prints this help -v|--verbose Print verbose log information (warning: very verbose!). -t|--test Do not actually make any changes to the database, just report what changes would be made. -r|--report Print a report of what happened during the run. -l|--limit=S Only process those records that match the user-specified WHERE clause (the WHERE is implied and should not be included on the command line). -a|--authorities Check for duplicate authorities rather that duplicate bibliographic records. -s|--select=s Repeatable. Specify how to identify which record to prefer. See the section on SELECTORS below. -m|--match=s Specifies the matching rule to use. This can be the numeric ID of a matching rule that you have already configured (preferred), or you can specify a matching rule on the command-line in the following format: /[##/[##...]] Examples: at/152b##he-main/2..a##he/2..bxyzt##ident/009@ authtype/152b##he-main,ext/2..a##he,ext/2..bxyz sn,ne,st-numeric/001##authtype/152b##he-main,ext/2..a##he,ext/2..bxyz -c|--check=s Only relevant when you are using a matching rule specified on the command line. Specifies sanity checks to use to ensure that the records are really duplicate. The format is [,[,...]] Examples: 200abxyz will check subfields a,b,x,y,z of 200 fields 009@,152b will check 009 data and 152$b subfields SELECTORS This script supports a number of selectors for choosing which record is "better." score Prefer the record which is the best match based on the specified matching rule. This will probably only be useful in cases where the matching rule will not match the source record, since the source record will automatically be given a score of 2 * the matching rule threshold if it wasn't picked up by the matcher. date Prefer the record which is newer based on the 005 field. source=ABC MARC21 only. Prefer records which come from ABC based on the 003 field. usage Authorities only. Prefer the record used in the most bibliographic records. ppn UNIMARC only. Prefer records which have a PPN in the 009 field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:01:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:01:37 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 --- Comment #36 from Jared Camins-Esakov --- Created attachment 20784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20784&action=edit Bug 7419: Add more missing authority indexes Koha's CCL configuration did not allow for most of the indexes that were configured for authorities. This patch adds missing authority indexes to QP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:01:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:01:49 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 --- Comment #37 from Jared Camins-Esakov --- Created attachment 20785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20785&action=edit Bug 7419: quiet warnings in deduplicator Quiet some warnings from the deduplicator script. Revised test plan: 1) Apply patches. 2) Import the sample records (sampleauths.mrc) file into Koha and make sure that they get indexed (by waiting until rebuild_zebra.pl runs automatically or by running rebuild_zebra.pl -a -z [-x] manually) 3) Deduplicate based on LCCN (replace {FIRSTAUTH} with the authid of the first imported record; on my system that number is 367123668): > misc/migration_tools/dedup_records.pl -t -v -a \ -l "authid >= {FIRSTAUTH}" -r -m "lc-card/010a" -s date 4) Check that you have 10 records that were chosen (you may have more, if you added more authorities after importing the sample data, but you should have at least the ten). 5) Deduplicate based on geographic heading, preferring Library of Congress authorities to local authorities: > misc/migration_tools/dedup_records.pl -t -v -a \ -l "authid >= {FIRSTAUTH}" -r -m "geographic/151a" -s "source=DLC" -s date 6) Check that you have 2 duplicate records replaced from amongst the new records. 7) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:03:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:03:41 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |testopia at bugs.koha-communit | |y.org --- Comment #38 from Jared Camins-Esakov --- Note that the new test plan does require you to be using QueryParser (and an updated etc/searchengine/queryparser.yaml). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:21:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:21:05 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #4 from Chris Nighswonger --- (In reply to Nicole C. Engard from comment #3) > What do you mean - how should it split? It should split at the spaces and/or > dots so > > Script > H82 > E45 That's what I was looking for. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:34:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:34:26 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:34:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:34:28 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19564|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov --- Created attachment 20786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20786&action=edit Bug 10539: Remove unused unit tests in lib/KohaTest This patch removes all files in lib/KohaTest and the associated script t/db_dependent/database_dependent.pl. The second patch deals with a few consequences. Note that bug 10540 has been opened to save some interesting code from these unit tests and inject them in the currently used t/db_dependent suite. Test plan: See second patch. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:34:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:34:38 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19565|0 |1 is obsolete| | --- Comment #9 from Jared Camins-Esakov --- Created attachment 20787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20787&action=edit Bug 10539: Followup for removing KohaTest unit tests Makefile.PL: Section for creating file t/test-config.txt removed. Removes t/Makefile and t/rewrite-config-test too. Modifies XISBN.t to remove two commented lines. Test plan: Grep for KohaTest, database_dependent, config-test, t/Makefile. Run perl Makefile.PL and include running the test suite. This may fail on t/00-valid-xml.t and t/QueryParser.t, but that is not the result of this patch. Same for t/00-load.t with potential error on Koha::Plugins::Base. I had this result: Test Summary Report: t/00-valid-xml.t (Wstat: 1792 Tests: 381 Failed: 7) Failed tests: 10, 30-31, 169, 181, 201-202 Non-zero exit status: 7 t/QueryParser.t (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: No plan found in TAP output Files=92, Tests=12385, 45 wallclock secs ( 1.74 usr 0.15 sys + 26.61 cusr 1.92 csys = 30.42 CPU) Result: FAIL Failed 2/92 test programs. 7/12385 subtests failed. Signed-off-by: Jared Camins-Esakov All tests pass, and I find no mention of the removed test code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:42:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:42:13 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #29 from Jared Camins-Esakov --- There is a small conflict in C4::Letter that I am not sure how to resolve. Does the from e-mail address have to be the patron's e-mail address for GPG to work? It seems to me we'd prefer it to be the library's e-mail address, if one is set, but I presume there's a reason for the change in the patch, so I wanted to ask for feedback on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:46:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:46:29 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #30 from Jared Camins-Esakov --- Additionally, it looks like there are no unit tests. Is it possible to unit test C4::GnuPG? Finally, and this is a definite blocker, it looks like C4::GnuPG is initialized with file-level my variables: +my $gpg = new Crypt::GPG; +$gpg->gpgbin('/usr/bin/gpg'); +$gpg->encryptsafe(0); # we have to allow untrusted keys This will not work well with persistent environments like Plack. The my could be changed to our, but even better would be changing the way initialization is handled such that a file-level variable is unnecessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:50:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:50:25 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:50:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:50:28 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20712|0 |1 is obsolete| | --- Comment #104 from Jared Camins-Esakov --- Created attachment 20788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20788&action=edit Bug 7143: history.txt and about page updates - two new developers - releases Signed-off-by: Galen Charlton Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:52:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:52:47 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #31 from Mirko Tietgen --- (In reply to Jared Camins-Esakov from comment #29) > There is a small conflict in C4::Letter that I am not sure how to resolve. > Does the from e-mail address have to be the patron's e-mail address for GPG > to work? It seems to me we'd prefer it to be the library's e-mail address, > if one is set, but I presume there's a reason for the change in the patch, > so I wanted to ask for feedback on it. I found the problem with the wrong address while I was working on this and fixed it in Bug 10621 instead of here. I had initially fixed it in this bug and then un-did it to have the seperate entry. I will change the patch when I have a little more time, the old behaviour should not be reimplemented by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:53:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 19:53:33 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 01:32:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2013 23:32:35 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #5 from Chris Nighswonger --- What call number system does this system use? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 03:26:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 01:26:57 +0000 Subject: [Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 20789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20789&action=edit Material type as determined by Leader/06 and Leader/07 008 do not forgets, because it don't know. As stated in http://www.loc.gov/marc/formatintegration.html, "Field 008 does not carry any explicit flag identifying the definition of positions 18-34. Instead, the identification of the type of field 008 is dependent on the content of Leader/06 (Type of record) and,in the case of textual material (i.e., when Leader/06 contains value a), the content of Leader/07 (Bibliographic level)." So to fix this we need a way to pass Leader/06 and /07 to the plugin so it learns and shows proper material type, and that if the leader is correctly filled. Attached is a PDF with all possible combinations on leader/06 /07 and what kind of material type must be set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 06:09:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 04:09:07 +0000 Subject: [Koha-bugs] [Bug 10823] New: add class info to enumchron data in detail.tt, for better styling Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Bug ID: 10823 Summary: add class info to enumchron data in detail.tt, for better styling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org this is a trivial patch with no functional change this patch adds class info to the item.serialseq and item.publisheddate values, to allow better styling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 06:25:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 04:25:18 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 06:25:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 04:25:21 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 --- Comment #1 from Mason James --- Created attachment 20790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20790&action=edit Bug 10823 - add class info to enumchron data in detail.tt, for better styling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 06:55:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 04:55:12 +0000 Subject: [Koha-bugs] [Bug 10824] New: OAI-PMH repository/server not handling time in "from" argument Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 Bug ID: 10824 Summary: OAI-PMH repository/server not handling time in "from" argument Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, if you try to use time in a "from" argument with the Koha OAI-PMH repository/server, you'll get unexpected results. Case 1: There are 3 records with the following timestamps: 2013-09-02 10:29:40 2013-09-05 13:44:33 2013-09-05 13:44:34 However, if you sent a request using "2013-09-02 8:29:40" or "2013-09-02T8:29:40Z" (the latter being the 'proper' way), you'll only retrieve the last 2 records of the 3 record set. This is because we're using this code to check the "from" and "until" arguments: "WHERE DATE(timestamp) >= ? AND DATE(timestamp) <= ?" We need to strip DATE() from around the timestamps. If we just compare the normal timestamp, MySQL can handle properly compare the timestamp against the following strings: "2013-09-02" "2013-09-02 8:29:40" "2013-09-02T8:29:40Z" (NB This one produces a warning (not an error) so it's less than ideal) I'm proposing that we remove DATE() and include a regex to strip UTC designators T and Z. This way, we'll always be passing in "2013-09-02" or "2013-09-02 8:29:40" which work perfectly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:13:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:13:44 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #9 from Srdjan Jankovic --- 1. I had problems with either borrowers changing card numbers, or being removed (have no idea what is possible, but the situation is real, I'm using a clients prod dump). In order to establish new PK there must be no nulls, so patronimage should be purged first, something on the lines of DELETE FROM patronimage wHERE NOT EXISTS(borrower). 2. The patch adds UNIQUE and then PK. I understand why UNIQUE, but that is maybe an overkill. So it should either be removed (as in not included in the statement), or dropped afterwards. 3. There should be an FK statement to replace dropped FK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:27:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:27:21 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #15 from Srdjan Jankovic --- I could be wrong with those, so please double check: C4/Circulation.pm - if should become unless ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:31:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:31:21 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 --- Comment #10 from Srdjan Jankovic --- Sorry, didn't -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:32:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:32:09 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:35:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:35:24 +0000 Subject: [Koha-bugs] [Bug 10825] New: detail.tt displays duplicated enumchron values for serial items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Bug ID: 10825 Summary: detail.tt displays duplicated enumchron values for serial items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org when a serial is received, its serialseq info is automatically copied into it's item.enumchron field when that newly created item is displayed in the staff details page both its enumchron and serialseq values are displayed together. the bug is - both values are identical creating a duplication of info (pic attached) the solution is to only display one of the two fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:37:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:37:44 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:37:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:37:47 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 --- Comment #1 from David Cook --- Created attachment 20791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20791&action=edit Bug 10824 - OAI-PMH repository/server not handling time in "from" argument This patch remotes the DATE() function from around timestamp, and adds a sub that strips the UTC designators "T" and "Z" from incoming "from" and "until" arguments in OAI-PMH requests so that they're more compliant with MySQL (and probably other databases as well). TEST PLAN: 0) Note down a selection of timestamps from your biblio table 1) Enable your OAI-PMH server through the global system preferences Web services tab. 2) Craft and submit a similar request to the following in your browser: KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc& from=2013-09-02T13:44:33Z&until=2013-09-05T13:44:33Z Change the exact dates to accord with your timestamps, but keep the YYYY-MM-DDTHH:MM:SSZ format. 3) Note the unexpected behaviour. A "from" argument with the timestamp 2013-09-02T13:44:33Z will show records from 2013-09-03 but not records from 2013-09-02 even though the timestamp in the database will say "2013-09-02 13:44:33". 4) APPLY THE PATCH 5) Resubmit the links you tried above 6) Note that the applicable records now appear! -- Developer Note: We could've not stripped the UTC designators and used DATE() around the parameters in the SQL queries, but that would have lost the whole purpose of using times in the "from" arguments, since they would've been generalized to just the dates. I think this is probably the best solution. Admittedly, creating "form_arg" and "until_arg" hashrefs in the ResumptionToken object might not be ideal, but I preferred that to copying the _strip_UTC_designator subroutine into two other objects. Perhaps this sub could go somewhere else and be imported into those other two objects but this seemed to be the most sensible decision. I'm open to other opinions though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:38:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:38:36 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:39:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:39:31 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #1 from Mason James --- Created attachment 20792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20792&action=edit pic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:51:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:51:38 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:51:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:51:40 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #2 from Mason James --- Created attachment 20793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20793&action=edit Bug 10825 - detail.tt displays duplicated enumchron values for serial items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:54:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 05:54:23 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #3 from Mason James --- Created attachment 20794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20794&action=edit pic, after applied patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:34:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 07:34:36 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #10 from Jonathan Druart --- QA comment: This patch is consistent with the current work in progress on unit tests. The KohaTest is obsolete, unused, buggy, etc. The interesting code can be retrieve from the git log. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:36:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 07:36:11 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20786|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 20795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20795&action=edit Bug 10539: Remove unused unit tests in lib/KohaTest This patch removes all files in lib/KohaTest and the associated script t/db_dependent/database_dependent.pl. The second patch deals with a few consequences. Note that bug 10540 has been opened to save some interesting code from these unit tests and inject them in the currently used t/db_dependent suite. Test plan: See second patch. Signed-off-by: Jared Camins-Esakov Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:36:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 07:36:17 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20787|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 20796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20796&action=edit Bug 10539: Followup for removing KohaTest unit tests Makefile.PL: Section for creating file t/test-config.txt removed. Removes t/Makefile and t/rewrite-config-test too. Modifies XISBN.t to remove two commented lines. Test plan: Grep for KohaTest, database_dependent, config-test, t/Makefile. Run perl Makefile.PL and include running the test suite. This may fail on t/00-valid-xml.t and t/QueryParser.t, but that is not the result of this patch. Same for t/00-load.t with potential error on Koha::Plugins::Base. I had this result: Test Summary Report: t/00-valid-xml.t (Wstat: 1792 Tests: 381 Failed: 7) Failed tests: 10, 30-31, 169, 181, 201-202 Non-zero exit status: 7 t/QueryParser.t (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: No plan found in TAP output Files=92, Tests=12385, 45 wallclock secs ( 1.74 usr 0.15 sys + 26.61 cusr 1.92 csys = 30.42 CPU) Result: FAIL Failed 2/92 test programs. 7/12385 subtests failed. Signed-off-by: Jared Camins-Esakov All tests pass, and I find no mention of the removed test code. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:48:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 07:48:36 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #7 from Jonathan Druart --- QA comment: Thanks for this second patch: all works as expected and there is not duplicated code. Note that the Closed column is not sortable, I will provide a followup. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:49:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 07:49:05 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20687|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 20797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20797&action=edit Bug 10737 [Revised] Add "Add to basket" link on vendor search results page This patch adds an "add to basket" link to the vendor search results page for each open basket associated with each vendor. Clicking it triggers a modal window with the "add to basket" choices for that vendor and basket. Other changes in this patch: - The add-to-basket include has been modified in order to make it more useful in this context. - booksellers.pl has been modified to check for an existing budget so that the add-to-basket include can properly display a warning if there are none. - "New basket" and "Receive shipment" buttons associated with each vendor search result have been converted to Bootstrap-styled buttons. - Basket closed date has been moved into its own column so that the table can be sorted by that value. - Table columns containing dates now use the "title-string" sort option, eliminating the need for a special date sorting algorithm. - Converted some &'s to &'s To test, apply the patch and search for a vendor. For each vendor in your search results baskets which are open should include an "add to basket" link. Clicking it should open a modal dialog with the same "add to basket" options offered on the basket page. The correct vendor ID and basket number should be associated with each link. The newly-styled "new basket" and "receive shipment" buttons should work correctly. Table sorting should work correctly, including the new "closed" column. Since the add-to-basket include file was modified, the "add to basket" button on the basket view page should also be tested (acqui/basket.pl). Signed-off-by: Campbell Reid-Tait Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:49:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 07:49:10 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 --- Comment #9 from Jonathan Druart --- Created attachment 20798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20798&action=edit Bug 10737: The new column 'Closed' should be sortable. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 10:08:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 08:08:32 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Jonathan Druart --- (In reply to Martin Renvoize from comment #17) > Could you give any errors you see if it's really not working? Hi Martin, It does not work neither for me on the staff interface. Try to use the Koha plugin at the top of the results.tt file ([% USE Koha %]). Moreover, I think it would be great to have the list of stopwords case insensitive, in order to avoid to list all variants (The, the, THE). Marked as Failed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:02:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 09:02:28 +0000 Subject: [Koha-bugs] [Bug 10826] New: Add schema.org microdata for NORMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10826 Bug ID: 10826 Summary: Add schema.org microdata for NORMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org Bug 6594 add schema.org microdata for MARC21. This bug will do the same for NORMARC. Since NORMARC is *mostly* a subset of MARC21 it should not be too hard, I hope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:03:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 09:03:07 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10826 --- Comment #14 from Magnus Enger --- I have added "Bug 10826 - Add schema.org microdata for NORMARC" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:03:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 09:03:07 +0000 Subject: [Koha-bugs] [Bug 10826] Add schema.org microdata for NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10826 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6594 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 13:04:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 11:04:52 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #6 from Nicole C. Engard --- LCC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 13:31:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 11:31:55 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #10 from Colin Campbell --- In the past I've come across sites whose databases included a fair propotion of records with deleted status in the header, often imported from some external source. I'm wondering why you would flag recs in the koha db as deleted rather than delete them straight out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:13:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 12:13:07 +0000 Subject: [Koha-bugs] [Bug 10827] New: List of holds does not update correctly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 Bug ID: 10827 Summary: List of holds does not update correctly Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When an item has many patron's holds and it is checked-in, the first priority patron hold in the list of holds is set as "waiting". Then when this hold expires o is cancelled the hole list of holds doesn't update: the next patron in the list of holds "keeps on hold" but not "waiting" and no email is inserted in the message queue table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:27:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 13:27:52 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20777|0 |1 is obsolete| | --- Comment #2 from Colin Campbell --- Created attachment 20799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20799&action=edit Revised patch Revised the patch to deal with a compile time error thrown by older (no longer supported) versions of perl. (unfortunately debian ships one of these) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:35:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 13:35:08 +0000 Subject: [Koha-bugs] [Bug 10454] Duplicate card numbers may be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19265|0 |1 is obsolete| | --- Comment #19 from Paola Rossi --- Created attachment 20800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20800&action=edit sign off of the bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:35:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 13:35:30 +0000 Subject: [Koha-bugs] [Bug 10454] Duplicate card numbers may be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:36:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 13:36:12 +0000 Subject: [Koha-bugs] [Bug 10454] Duplicate card numbers may be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC|paola.rossi at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:45:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 13:45:34 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20765|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 20801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20801&action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:23:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:23:48 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #19 from Martin Renvoize --- Hi Jonathan (In reply to Jonathan Druart from comment #18) > It does not work neither for me on the staff interface. Try to use the Koha > plugin at the top of the results.tt file ([% USE Koha %]). Thanks for the heads up regarding calling the Koha plugin in results.tt, I've now added this and tested. Seems to be working as expected to me. > Moreover, I think it would be great to have the list of stopwords case > insensitive, in order to avoid to list all variants (The, the, THE). I've now taken this into account too, making it case insensitive was a great idea! Patch to follow. . . -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:25:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:25:04 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20715|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 20802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20802&action=edit Bug 6149 - Stopwords for Result Highlighting Rebased again, and taken Jonathans comments into account. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:25:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:25:29 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:25:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:25:32 +0000 Subject: [Koha-bugs] [Bug 10828] New: Label creator returns empty pdf, xml or csv file Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828 Bug ID: 10828 Summary: Label creator returns empty pdf, xml or csv file Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: pedro.m.ferreira at mail.cm-portel.pt QA Contact: testopia at bugs.koha-community.org In "LABEL CREATOR" i choose "NEW BATCH" then "ADD ITEM(S)". In "Search for items to add to Batch ", i can sucessfully search for an item and then i can select it to add to the batch. I click the "EXPORT BATCH", and then i select the template and the layout. It is from this point that i detect some problems. When i choose the "Download as PDF" I always get an empty PDF FILE. No labels are created In the error log from apache i have the following messages [Thu Sep 05 15:23:43 2013] [error] [client 213.228.143.2] [Thu Sep 5 15:23:43 2013] label-create-pdf.pl: "my" variable $template masks earlier declaration in same scope at /var/www/koha3.12/intranet/cgi-bin/labels/label-create-pdf.pl line 63., referer: http://catalogobib.cm-portel.pt:82/cgi-bin/koha/labels/label-print.pl [Thu Sep 05 15:23:43 2013] [error] [client 213.228.143.2] [Thu Sep 5 15:23:43 2013] label-create-pdf.pl: regexp failed to match string: at /var/www/koha3.12/lib/C4/Labels/Label.pm line 138., referer: http://catalogobib.cm-portel.pt:82/cgi-bin/koha/labels/label-print.pl [Thu Sep 05 15:23:43 2013] [error] [client 213.228.143.2] [Thu Sep 5 15:23:43 2013] label-create-pdf.pl: Use of uninitialized value $parts[-1] in pattern match (m//) at /var/www/koha3.12/lib/C4/Labels/Label.pm line 160., referer: http://catalogobib.cm-portel.pt:82/cgi-bin/koha/labels/label-print.pl [Thu Sep 05 15:23:43 2013] [error] [client 213.228.143.2] [Thu Sep 5 15:23:43 2013] label-create-pdf.pl: Use of uninitialized value $parts[-1] in pattern match (m//) at /var/www/koha3.12/lib/C4/Labels/Label.pm line 160., referer: http://catalogobib.cm-portel.pt:82/cgi-bin/koha/labels/label-print.pl [Thu Sep 05 15:23:43 2013] [error] [client 213.228.143.2] [Thu Sep 5 15:23:43 2013] label-create-pdf.pl: regexp failed to match string: at /var/www/koha3.12/lib/C4/Labels/Label.pm line 165., referer: http://catalogobib.cm-portel.pt:82/cgi-bin/koha/labels/label-print.pl I Have KOHA 3.12 and i migrate the Database from version 3.0.6.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:26:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:26:03 +0000 Subject: [Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828 Pedro Ferreira changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:27:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:27:03 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #21 from Martin Renvoize --- Also noted that these highlighting systems are out of sync between opac and staff client, including the lack of staff client code for Bug 10686. Once I've got this bit out of the way, I'm tempted to submit that as a speerate bug and patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:46:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:46:31 +0000 Subject: [Koha-bugs] [Bug 10829] New: Browse across pages breaks for authority searches Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Bug ID: 10829 Summary: Browse across pages breaks for authority searches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org OK.. this one was hard to replicate, even harder to trace/debug, but relatively simple to fix! Test plan 1. Do an authority search in the OPAC (A search for 'an:49' perhaps.. that should bring up results for authority number 49, hopefully there are multiple pages of results, if not try again and find one that gives you multiple pages of results) 2. Click the final result on any page of results (there must be more results to follow for this to work) 3. Try clicking the 'Next' button in the 'Browse results' pane on the right of the page. 4. It should take you to the next result in the search list (i.e the first result from the next page of results) Double check it is correct, we found that it was often not. 5. Apply patch and run same process, this time you should get the correct paging. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:47:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:47:02 +0000 Subject: [Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828 --- Comment #1 from Chris Nighswonger --- We'll need a little more information to determine if this is a bug or a problem with data corruption during your upgrade. Please attach the following: 1. A pdf file created from your installation which is "blank." 2. Some marc records with the items used on the "blank" form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:53:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:53:28 +0000 Subject: [Koha-bugs] [Bug 10829] Browse across pages breaks for authority searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Created attachment 20803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20803&action=edit Bug 10829 - Browse across pages breaks for authority searches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:56:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:56:51 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 --- Comment #3 from Colin Campbell --- Created attachment 20804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20804&action=edit Test script This script can be used to test the patch. Set up a user with some holds. Set up the configuration in the script and the script should setup a tcp socket connection to the designated server and will output the requests and responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:58:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 14:58:59 +0000 Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Pierre Angot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #76 from Pierre Angot --- If someone can repair it, we can test it next week. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:00:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 15:00:36 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- (In reply to Srdjan Jankovic from comment #7) > A philosophical question - changes like this, consisting of only removing > unused/unwanted code, can those be self-signed, and go to QA directly? A philosophical answer -- no, for two reasons. If a patch removes an unused something, having at least two pairs of eyes can help verify that (a) the something was in fact unused and (b) the something was /completely/ removed. Second, it gives folks time to jump in case they question the removal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:21:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 15:21:32 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Marcel! I note that the RUN_DATABASE_TESTS bits still left in Makefile.PL currently stand unused, but since they provide a hook for work that Jonathan is doing, I think they should stay in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:34:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 15:34:55 +0000 Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:36:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 15:36:41 +0000 Subject: [Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 --- Comment #9 from Galen Charlton --- One of the dependent bugs has been pushed to master, leaving bug 10771, which needs signoff. I encourage anybody interested in seeing this patch get pushed to review the patches for 10771. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:48:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 15:48:37 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:49:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 15:49:04 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20714|0 |1 is obsolete| | --- Comment #14 from Galen Charlton --- Comment on attachment 20714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20714 [PASSED QA] Bug 10649 - Upgrade DataTables and move scripts out of theme directory Setting back to assigned as this is an omnibus bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:49:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 15:49:11 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:56:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 15:56:48 +0000 Subject: [Koha-bugs] [Bug 10830] New: Add schema.org microdata for UNIMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10830 Bug ID: 10830 Summary: Add schema.org microdata for UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org Bug 6594 add schema.org microdata for MARC21. This bug will do the same for UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:57:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 15:57:09 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 --- Comment #15 from mathieu saby --- And I added Bug 10830 for Unimarc. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 18:29:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 16:29:57 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 18:29:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 16:29:59 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 --- Comment #1 from Galen Charlton --- Created attachment 20805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20805&action=edit Bug 10792: fix sorting of funds table on acquisitions home page This patch introduces a DataTables sorting plugin, title-numeric, for sorting cells based on a decimal number embedded in a span title attribute. This allows currency amounts to be formatted properly for display without having to writing a sorting plugin that's super-smart about removing the formatting, particularly for locales that use a comma as the decimal mark. The sorter plugin can be used like this: - In the DataTables config: "aoColumns": [ { "sType": "title-numeric" }, ] - In the table data [% formatted currency %] To test: [1] Go to the acquisitions home page. Note that changing the sort order on the amount, ordered, spent, or avail columns results in incorrect sorting that is either ASCII-betical or which ignores any component of large numbers that occur after the thousands separator. [2] Apply the patch. [3] Verify that the sorting now works correctly and that no JavaScript errors appear in the JS debug console of your choice. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 18:38:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 16:38:31 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #19 from Kyle M Hall --- Created attachment 20806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20806&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 18:38:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 16:38:29 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 18:46:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 16:46:24 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 18:46:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 16:46:26 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 --- Comment #16 from Kyle M Hall --- Created attachment 20807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20807&action=edit Bug 5544 - All Notices from Branch Email Address - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 18:56:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 16:56:31 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 --- Comment #15 from Galen Charlton --- Owen, I just looked at the bugs that you marked this one as blocking. I'll leave it to you to indicate whether you want this one set back to 'pushed to master' (in which case, please open bugs for the remaining modules that need the new DataTables). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 19:05:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 17:05:51 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14814|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 20808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20808&action=edit Bug 7595 - Add branchcode to accountlines Adds a branchcode column to the accountlines table. For payments, this inserts the branchcode of the library where the payment was recorded. For manual invoices, it insert the branchcode of the library where the manual invoice was created. Signed-off-by: Nicole C. Engard I tested with creating manual invoices, and paying partial fines, entire fine lines, and writing off fines. All actions record the branch where the action took place properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 19:06:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 17:06:06 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14815|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 20809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20809&action=edit Bug 7595 - Add branchcode to accountlines - Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 19:06:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 17:06:04 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 19:06:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 17:06:17 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 19:54:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 17:54:12 +0000 Subject: [Koha-bugs] [Bug 10829] Browse across pages breaks for authority searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr at software.coop --- Comment #2 from Martin Renvoize --- *** Bug 7898 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 19:54:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 17:54:12 +0000 Subject: [Koha-bugs] [Bug 7898] Browse Results is easily confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |DUPLICATE --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 10829 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 20:48:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 18:48:32 +0000 Subject: [Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828 --- Comment #2 from Pedro Ferreira --- Created attachment 20810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20810&action=edit blank pdf file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 20:54:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 18:54:45 +0000 Subject: [Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828 Pedro Ferreira changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20810|0 |1 is obsolete| | --- Comment #3 from Pedro Ferreira --- Created attachment 20811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20811&action=edit blank pdf file Batch file created from this record http://catalogobib.cm-portel.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=2293 catalogobib.cm-portel.pt is our Municipality public library link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 21:09:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 19:09:36 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Owen Leonard --- (In reply to Owen Leonard from comment #8) > There is a problem with the OPAC non-XSLT detail page. This is fixed: on a non-XSLT detail page, with OPACPopupAuthorsSearch enabled, search term selection is now performed from a modal dialog rather than a pop-up menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 21:28:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 19:28:56 +0000 Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 --- Comment #6 from Kyle M Hall --- Created attachment 20812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20812&action=edit Bug 10027 - Fine details not showing when printing a fine - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 21:28:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 19:28:54 +0000 Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 23:37:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 21:37:25 +0000 Subject: [Koha-bugs] [Bug 10831] New: QueryParser requires that defaultSortField and defaultSortOrder be set to non-NULL values Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10831 Bug ID: 10831 Summary: QueryParser requires that defaultSortField and defaultSortOrder be set to non-NULL values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org If QueryParser is enabled, the system preferences defaultSortField/defaultSortOrder (and their OPAC kin OPACdefaultSortField/OPACdefaultSortOrder) should not be set to NULL values. Otherwise, for searches where the sort order is not explicitly specified (e.g., searches made from the staff and OPAC global search box), the search can fail. This is due to several slightly questionable coding constructs collaborating in the confusion of both the user and the developer: [1] If a default sort order is not set, catalogue/search.pl and opac/opac-search.pl can end up setting the @sort_by array to (undef). This is because of the construct @sort_by = $cgi->param('sort_by'); If the sort_by CGI parameter is not passed, the result is not an empty array, it's an array containing one element whose value is undef. [2] The following code in C4::Search::parseQuery in turn uses @sort_by to add QP modifiers: if ( scalar(@sort_by) > 0 ) { my $modifier_re = '#(' . join( '|', @{ $QParser->modifiers } ) . ')'; $query =~ s/$modifier_re//g; foreach my $modifier (@sort_by) { $query .= " #$modifier"; } } If the query is "history", the modified version becomes "history #" ... which in turn results in a query that will not make sense to Zebra. One solution is to push through a DB update that extends the fix for bug 8012 to set the system preferences to sensible default values (probably relevance descending) if they're currently NULL. Note, by the way, that this means that the bug manifests itself only in databases old enough to have been created before the patch for bug 8012 was pushed. Another part of the solution, however, ought to be make the code in question a little more robust. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 00:36:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2013 22:36:14 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 02:33:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 00:33:03 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 --- Comment #11 from David Cook --- (In reply to Colin Campbell from comment #10) > In the past I've come across sites whose databases included a fair propotion > of records with deleted status in the header, often imported from some > external source. I'm wondering why you would flag recs in the koha db as > deleted rather than delete them straight out I decided to do a quick web search on this topic and here is the first thing I stumbled across: "Whether you perform the conversion or we do, consider whether you wish to retain MARC records carrying the delete flag ("d" in Leader/05). You may need to retain these for reporting purposes if your database is part of a union catalog." http://www.itsmarc.com/UpgradingFromITS.asp I imagine that this might be the use case that Katrin was mentioning. -- Perhaps it would be an institutional policy for library techs to mark a record as deleted but only "authorized" librarians are allowed to delete the record? Sort of following along the lines of the ideas mentioned here: http://www.lib.berkeley.edu/asktico/procedures/deletion-bibliographic-record -- In the MARC Authority record context, there are actually several different "deleted" flags such as "s" and "x" which have different reasons attached to them. http://www.loc.gov/marc/authority/adleader.html d - Deleted Used when neither code s nor code x is applicable, or when an organization chooses not to use code s or x. Some level of manual intervention may be needed to effect the change in bibliographic records because the deleted heading may or may not be carried as a 4XX See From Tracing field in other authority records and a 682 field explaining the delete may be present in the record marked for deletion. s - Deleted; heading split into two or more headings Record has been deleted from a file because the heading has been split into two or more headings, requiring a new authority record for each. The heading from the deleted record is included in each of the new authority records as a tracing in a 4XX See From Tracing field. This specialized delete value supports use of automated systems to carry out any necessary reviews, since when a heading is split, a computer cannot automatically replace the old heading in bibliographic records. x - Deleted; heading replaced by another heading Record has been deleted from a file and that a new authority record in which the heading from the deleted record appears as a 4XX See From Tracing field has been added to the file. (In a system where authority control is linked to the bibliographic file, a computer can effect the one-to-one replacement indicated by code x without manual intervention.) Apparently there is also a code "o" for obsolete but not deleted. http://www.itsmarc.com/crs/mergedProjects/helpauth/helpauth/idh_leader_05_auth.htm A person can also use the 682 to provide a reason apparently. http://www.loc.gov/marc/authority/ad682.html Admittedly, the Authority context might not be relevant to this discussion because it talks about automatic/manual updating of Bibliographic records. But if you're deleting Bibliographic records...you wouldn't need to worry about a trickle down effect (except in the case where its linked to another using 7xx linking fields, but that's a whole 'nother can of worms). -- In the end...I wonder if it's best to: 1) Not display "deleted" records in the OPAC 2) Have a label saying "deleted" in the staff client 3) Perhaps have a cronjob to clean out "d" records, but only at the behest of a library administrator. It seems that having this cronjob active by default might cause issues if only at a policy level (which is an extremely important level in libraries) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 02:40:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 00:40:12 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 --- Comment #12 from David Cook --- Mohammad Nashbat's comment on the listserv is also interesting: "I?m trying to upload a deletion batch from ebrary to our Koha LMS, this batch changes the records status in the leader tag to ?d? delete, which used to delete the bib records using our old library system ?Dynix? after indexing. But now in Koha it do change the status but without deleting the bib records even after indexing, am I missing something?" I think at a bare minimum records with a "d" need to be suppressed in the OPAC. However, actual deletions...I'm not sure what I think of this "batch deletion" idea. I haven't done a lot yet with MARC dumps from vendors like EBSCO, but I could see how re-uploading records with a "d" in the leader to do a batch delete might be an idea. While it's only tangentially related to this discussion, I wonder what sorts of best practices people have for maintaining MARC records in Koha that come from electronic service providers (for services like electronic journals and e-books). We have a homecooked solution here that my boss takes care of but I wonder what the optimal way of doing it would be. I'm sure people in a union catalogue situation/those who use OCLC or other interconnected cataloguing tools must also encounter situations where the original record has changed and now they either need to update or delete their existing records. (I know this is a problem I've also encountered in developing the OAI-PMH harvester. It seems like it could be a pervasive issue.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 03:15:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 01:15:09 +0000 Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 --- Comment #13 from David Cook --- (In reply to David Cook from comment #12) > Mohammad Nashbat's comment on the listserv is also interesting: > > "I?m trying to upload a deletion batch from ebrary to our Koha LMS, this > batch changes the records status in the leader tag to ?d? delete, which used > to delete the bib records using our old library system ?Dynix? after > indexing. But now in Koha it do change the status but without deleting the > bib records even after indexing, am I missing something?" > > I think at a bare minimum records with a "d" need to be suppressed in the > OPAC. > > However, actual deletions...I'm not sure what I think of this "batch > deletion" idea. I haven't done a lot yet with MARC dumps from vendors like > EBSCO, but I could see how re-uploading records with a "d" in the leader to > do a batch delete might be an idea. > > While it's only tangentially related to this discussion, I wonder what sorts > of best practices people have for maintaining MARC records in Koha that come > from electronic service providers (for services like electronic journals and > e-books). > > We have a homecooked solution here that my boss takes care of but I wonder > what the optimal way of doing it would be. > > I'm sure people in a union catalogue situation/those who use OCLC or other > interconnected cataloguing tools must also encounter situations where the > original record has changed and now they either need to update or delete > their existing records. > > (I know this is a problem I've also encountered in developing the OAI-PMH > harvester. It seems like it could be a pervasive issue.) Jared Camins-Esakov has mentioned that using the import/revert features in Koha, a person could revert a batch of MARC records from an electronic subscription, then just import the latest full reload file. That seems to me to be a very reasonable solution. The only problem would be if someone added items to those records, but as he pointed out...with a large enough load (say 50k records), the likelihood of items being added is probably fairly low. That said, I think some of our libraries have items automatically added to some of their electronic holdings. However, perhaps that's a practice that should just be eliminated, since the process Jared describes seems quite robust. In the case where you unsubscribe from a subscription, you'd just revert your records and that's that. So long as you have a full MARC record dump, you're covered for additions/updates/deletes. -- In the union catalog/online cataloging tool scenario, additions/updates shouldn't be much of a problem (provided that there haven't been local changes), but I imagine that deletes are still an issue...and that perhaps you would still want a record marked "d" in your catalogue (although not in your OPAC). Ok. That's it from me. Sorry for spamming all of you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:18:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 05:18:35 +0000 Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #2 from David Cook --- Just changing this away from an enhancement to "minor" as it's really more of a bug fix than an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:19:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 05:19:49 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 09:22:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 07:22:06 +0000 Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 --- Comment #7 from Jonathan Druart --- Galen, should I switch this report to 'Passed QA'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 10:52:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 08:52:45 +0000 Subject: [Koha-bugs] [Bug 10771] three disused scripts in misc/cronjobs/stats should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 10:52:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 08:52:48 +0000 Subject: [Koha-bugs] [Bug 10771] three disused scripts in misc/cronjobs/stats should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20510|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20813&action=edit Bug 10771: remove disused statistical reports cronjobs This patch removes three cronjobs that are believed to be unused for the following reasons: [1] The commit message that introduces them indicates that they were written for a particular library. A staff member from that library has confirmed that they are not in use. [2] The scripts have received essentially no patches since they were introduced except for being caught up in a broader code-improvement patch. [3] They refer to a column that no longer exists in biblioitems. [4] They no longer adhere to guidelines for command-line utilities, and there's been no sign that anybody has felt the urge to correct that. [5] They are not referenced by another code or the manual, and the mailing list archives do not include any substantive discussion of their use. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:05:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:05:42 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:05:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:05:45 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13276|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 20814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20814&action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:05:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:05:51 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #4 from Jonathan Druart --- Created attachment 20815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20815&action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:05:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:05:56 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #5 from Jonathan Druart --- Created attachment 20816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20816&action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:09:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:09:34 +0000 Subject: [Koha-bugs] [Bug 10832] New: Multi transport types for overdue notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Bug ID: 10832 Summary: Multi transport types for overdue notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 9016 adds a UI for choosing transport types for overdues. The cronjob script misc/cronjobs/overdue_notices.pl should deal with this configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:09:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:09:43 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10832 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:09:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:09:43 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9016 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:10:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:10:07 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10832 | --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > 4/ Now check the features :) The patch allows you to sent letters to the > queue with an email or sms format. > So try to create letters with 1 or both of these transport types and > check the corresponding checkbox on the overdues management page. > Play with the script misc/cronjobs/overdue_notices.pl in order to see > yours notices in the message_queue table. Will be done on bug 10832. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:10:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:10:07 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9016 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:12:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:12:23 +0000 Subject: [Koha-bugs] [Bug 10833] New: Multi transport types for advanced notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Bug ID: 10833 Summary: Multi transport types for advanced notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 9016 adds a UI for creating a message for each transport types for a letter. The cronjob script misc/cronjobs/advance_notices.pl should deal with this configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:12:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:12:35 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:12:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:12:48 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9016 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:12:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:12:48 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10832 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:12:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:12:57 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:13:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:13:11 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9016 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:13:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:13:11 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10833 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:37:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:37:37 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:37:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:37:40 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #1 from Jonathan Druart --- Created attachment 20817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20817&action=edit Bug 10832: Multi transport types for overdue notices Test plan: - define some complex overdue rules (tools/overduerules.pl). For example: First overdue from 2 to 5 days by sms and email with letter code L1 Second overdue from 5 to 15 days by email with letter code L2 Third overdue from 15 days by print with letter code L3 - defined a message for each transport type selected (tools/letters.pl). - select 3 patrons (P1, P2, P3) and 3 barcodes (B1, B2, B3). * checkout B1 to P1 with a due date = NOW - 3 days * checkout B2 to P2 with a due date = NOW - 10 days * checkout B3 to P3 with a due date = NOW - 20 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/overdue_notices.pl - retry the previous sql query, you should have X + 4 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code L1 1 message for P2, 1 for email and the letter code L2 1 message for P3, 1 for print and the letter code L3 - Specific case: If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required, a print notice is generated. A print notice is generated only 1 time per borrower and per level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:39:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:39:07 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20817|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 20818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20818&action=edit Bug 10832: Multi transport types for overdue notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:46:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:46:05 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20818|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 20819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20819&action=edit Bug 10832: Multi transport types for overdue notices Test plan: - define some complex overdue rules (tools/overduerules.pl). For example: First overdue from 2 to 5 days by sms and email with letter code L1 Second overdue from 5 to 15 days by email with letter code L2 Third overdue from 15 days by print with letter code L3 - defined a message for each transport type selected (tools/letters.pl). - select 3 patrons (P1, P2, P3) and 3 barcodes (B1, B2, B3). * checkout B1 to P1 with a due date = NOW + 3 days * checkout B2 to P2 with a due date = NOW + 10 days * checkout B3 to P3 with a due date = NOW + 20 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/overdue_notices.pl - retry the previous sql query, you should have X + 4 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code L1 1 message for P2, 1 for email and the letter code L2 1 message for P3, 1 for print and the letter code L3 - Specific case: If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required, a print notice is generated. A print notice is generated only 1 time per borrower and per level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:46:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:46:48 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:46:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 09:46:51 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 --- Comment #1 from Jonathan Druart --- Created attachment 20820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20820&action=edit Bug 10833: Multi transport types for advanced notices Test plan: - Choose 2 patrons P1 and P2 - Edit "Patron messaging preferences" and check SMS + email with 2 days in advance for P1 check email with 5 days in advance for P2 - defined a message for the letter code PREDUE for sms and email (tools/letters.pl). - select 2 barcodes (B1, B2). * checkout B1 to P1 with a due date = NOW - 2 days * checkout B2 to P2 with a due date = NOW - 5 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/advance_notices.pl -c - retry the previous sql query, you should have X + 3 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code PREDUE 1 message for P2, email and the letter code PREDUE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 12:26:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 10:26:04 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #40 from Martin Renvoize --- Created attachment 20821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20821&action=edit Bug 7973: Fixed bug in Auth_with_ldap - Counter patch I came across this issue at one of our sites today and patched it before finding the bugzilla entry. The patch already here seems to overcomplicate the issue somewhat unless I'm completely missing something. Attached is my counter patch proposal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 12:45:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 10:45:28 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #41 from Martin Renvoize --- So, my patch test plan differs slightly as I don't add additional requirements to the config. 1. Set auth_by_bind to 1 in the conf.xml as we still want to auth by bind. 2. Also set a user and pass in the conf.xml as we want to use an ldapuser to authenticate the initial search 3. Test that authentication works So, my patch does not require the addition of 'bind_with_service' to the xml config, instead it uses the existing user and pass params. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 13:18:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 11:18:21 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 13:33:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 11:33:57 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 13:33:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 11:33:59 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20111|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20822&action=edit Bug 10652 - Ajaxfileupload.js failing in IE9 for local image upload This patch adds a try/catch to the Javascript for adding the iframe element. The try will work for IE8 and older versions, while newer versions and other browsers will be covered by the check. Test Plan: 1) Try uploading a local cover image in IE9 2) Notice that your page is reloaded with no result (except the pop-up of a Javascript error, if you have error reporting on in your browser). 3) Apply the patch 4) Trying uploading a local cover image again 5) Notice that it uploads correctly 6) Repeat steps 4 and 5 for IE8, IE7, and/or other modern browsers. Signed-off-by: Owen Leonard Tested in IE10 in IE10 "browser mode" and IE9 mode as well as in Firefox. Uploads work correctly with book cover images and in MARC uploads. Signed-off-by: Kyle M Hall Also verified as working in Chrome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 14:21:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 12:21:18 +0000 Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 14:21:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 12:21:21 +0000 Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19968|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 20823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20823&action=edit Bug 10574 - mute the "upgrading from 3.2" message New installs get the message about running a script if upgrading from 3.2. They shouldn't. This silences this message in all cases except when you actually are upgrading from 3.2. Test plan: There are three scenarios to test: 1) A fresh install should not cause the prompt. 2) An upgrade with or without the debconf entry set should not cause the prompt. 3) An upgrade from a 3.2 release to this should cause the prompt. To remove the debconf entry that says the prompt has been seen: echo 'unregister koha-common/3.2-3.4-upgrade-notice' | sudo debconf-communicate koha-common This should be run before every test to make debconf forget that it's shown the prompt. To get its current state: sudo debconf-show koha-common To test against the 3.2 version, an empty package that claims to be Koha 3.2.2 is attached to the bug. Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 14:37:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 12:37:21 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 14:37:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 12:37:24 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19737|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 20824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20824&action=edit Bug 10584 - Hide OPAC biblio details if all items are hidden If there are items for a given biblio number, and they are all hidden, then biblio needs to be hidden. If the biblio needs to be hidden, this is done by setting the biblionumber to 0, which triggers the same output as if the biblionumber does not exist. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 14:55:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 12:55:36 +0000 Subject: [Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- (In reply to Jonathan Druart from comment #3) > Quite odd, I cannot reproduce the issue. > Without the patch: > Opac > lists > my list. > The default sort is "title". I am on the list results view and I click on > the "Edit list" link. I change the "Sort this list by" value to "author", > save. > The results list is sorted by author. > > What I miss? I too cannot reproduce this bug. Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 14:58:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 12:58:41 +0000 Subject: [Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Kyle M Hall --- Marking as Failed QA until we have a resolution for this. Owen, can you retest and let us know if you think this patch is still necessary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 15:25:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 13:25:11 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- Tested, I see no change in behavior. http://screencast.com/t/NFW8d7lvImlg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 16:55:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 14:55:22 +0000 Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 17:24:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 15:24:04 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20512|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 20825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20825&action=edit Bug 10656: add regression test This patch adds regression tests to verify the sort order when fetching authorised values in either staff or OPAC mode. This patch also wraps the Koha.t tests in a transaction, and better handles skipping tests if Test::Deep is not installed. To test: [1] Verify that prove -v t/db_dependent/Koha.t passes Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Tests pass with all patches applied. http://bugs.koha-community.org/show_bug.cgi?id=10565 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 17:24:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 15:24:16 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20513|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 20826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20826&action=edit Bug 10656: improve sorting of shelving location and collections on OPAC advanced search form Collection codes and shelving locations are displayed in the OPAC and staff client via GetAuthorisedValues which currently sorts results by "lib, lib_opac." Consequently if lib (the description for the staff client) doesn't match lib_opac (the description for the OPAC) sorting will appear to be nonsensical in the OPAC. GetAuthorisedValues can be passed an $opac parameter, so this should be used to switch how reuslts are sorted. This patch implements such a switch. To test, modify your collection code or shelving location authorized values so that lib and lib_opac do not match. Set your AdvancedSearchTypes system preference to display the modified authorized values and view the advanced search page in the OPAC and staff client. Sorting should be correct in each case according to the correct value (lib in the staff client, lib_opac in the OPAC). Signed-off-by: Nicole C. Engard Tested in staff and opac and it works perfectly! Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 17:24:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 15:24:31 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 17:24:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 15:24:33 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20514|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 20827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20827&action=edit Bug 10656: (follow-up) handle OPAC sorting of authvals where lib_opac is NULL The OPAC description for an authorized value is not required to be populated. In particular, if it is NULL, the staff description is displayed instead. This match makes sure that the sort order (in OPAC mode) uses either the staff description or the OPAC description as needed for each value. To test: [1] Make sure that AdvancedSearchTypes includes "ccode" [1] Arrange your CCODE values so the sort order for staff labels is different from the sort order for OPAC descriptions. Also, ensure that one of the OPAC descriptions is NULL. For example, authorised_value | lib | lib_opac -------------------------------------- ZZZ | A_STAFF | Z_PUBLIC DDD | D_STAFF | NULL AAA | Z_STAFF | A_PUBLIC [2] Prior to the patch, any CCODE values where the OPAC description is NULL will sort first in the OPAC advanced search page, even if the displayed label shouldn't come first. [3] Apply the patch. [4] Verify that the collection list on the OPAC advanced search page is now correct. [5] Verify that the sort order on the staff advanced search page has not changed. Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Works nicely, tested in staff and OPAC. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 17:27:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 15:27:35 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- The AJAX file upload plugin was not written by me. It was originally written by ?yvind Saltvik, although the current canonical fork appears to be http://www.phpletter.com/Our-Projects/AjaxFileUpload/. The change log for the most recent version of this plugin claims to have fixed the IE9 issue. For third-party code, I prefer that we stick with the stock version without modification unless upstream cannot or does not fix bugs that affect Koha. To that end, does somebody have a moment to test the most recent version of the stock plugin? There's another issue: I can find no statements whatsoever about the license of ajaxfileupload.js. Mea culpa -- and that's actually an issue I care about more nowadays than my concern about not bundling modified third-party libraries. It looks like the top upload plugin in the jQuery repository is jQuery File Upload by Sebastian Tschan. It's license is MIT. Setting to in discussion to see if anybody has tuits to test an uploader plugin with a clear (and of course, compatible) license, but if those tuits don't arise soon, I'm not opposed to pushing David's patch as is, though I expect that it will be superseded. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 17:31:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 15:31:39 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 --- Comment #5 from Galen Charlton --- (In reply to Galen Charlton from comment #4) > my concern about not bundling modified third-party > libraries. Or I should say, not modifying bundled third-party libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 17:55:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 15:55:28 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Blocks| |10445 Depends on|10445 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 17:55:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 15:55:28 +0000 Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10446 | Depends on| |10446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 17:59:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 15:59:07 +0000 Subject: [Koha-bugs] [Bug 10795] Improvements for GetOpenIssue in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 17:59:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 15:59:10 +0000 Subject: [Koha-bugs] [Bug 10795] Improvements for GetOpenIssue in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20748|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20828&action=edit Bug 10795 - Improvements for GetOpenIssue in C4::Circulation This patch adds some improvements for the routine GetOpenIssue. Now, it verifies if the parameter is given (if not it returns undef) and it returns $sth->fetchrow_hashref() instead of a $issue. To test: prove t/db_dependent/Circulation_issue.t t/db_dependent/Circulation_issue.t .. ok All tests successful. Files=1, Tests=16, 2 wallclock secs ( 0.06 usr 0.01 sys + 1.09 cusr 0.07 csys = 1.23 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comment: Same situation as the one noted in comment of Bug 10683, test fails unless there is an issuingrule All, All with 1 as renewals allowed. With that condition, it succeeds No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 18:03:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 16:03:14 +0000 Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 18:03:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 16:03:16 +0000 Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20756|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 20829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20829&action=edit Bug 10720 : substitution term in overdue notices shouldn't be removed if they don't match. It prevents use of html in notices to use with css Test plan : - define an overdue notice containing some valid substitution terms + some valid html tags ( or
Without patch, your html tags are missing in your html file With the patch, they are present and can be used with a css to generate a formatted pdf file. If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 18:16:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 16:16:16 +0000 Subject: [Koha-bugs] [Bug 10727] Replace carriage return with
when writing hold notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 18:16:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 16:16:19 +0000 Subject: [Koha-bugs] [Bug 10727] Replace carriage return with
when writing hold notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20755|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 20830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20830&action=edit Bug 10727 : Replace carriage return with
when printing hold notices This patch replaces carriage return with
in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - checkin an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl Without the patch, the script generates a html file without
tags. If you run printoverdues.sh , the text in the resulting pdf file is all on one line With the patch, the script generates a html file with
tags and pdf file created by printoverdues.sh is well formatted. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 18:49:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 16:49:20 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 18:54:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 16:54:07 +0000 Subject: [Koha-bugs] [Bug 10727] Replace carriage return with
when writing hold notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 18:55:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 16:55:52 +0000 Subject: [Koha-bugs] [Bug 10834] New: Add Sort 1 and Sort 2 to list of searchable patron fields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10834 Bug ID: 10834 Summary: Add Sort 1 and Sort 2 to list of searchable patron fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries would like to be able to search on the sort1 and sort2 fields of patron records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 18:57:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 16:57:40 +0000 Subject: [Koha-bugs] [Bug 10834] Add Sort 1 and Sort 2 to list of searchable patron fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10834 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 18:57:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 16:57:42 +0000 Subject: [Koha-bugs] [Bug 10834] Add Sort 1 and Sort 2 to list of searchable patron fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10834 --- Comment #1 from Kyle M Hall --- Created attachment 20831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20831&action=edit Bug 10834 - Add Sort 1 and Sort 2 to list of searchable patron fields Some libraries would like to be able to search on the sort1 and sort2 fields of patron records. Test Plan: 1) Apply this patch 2) Add various values for sort1 and sort2 some patrons 3) Browse to members-home.pl 4) Run searches on sort1 and sort2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 19:10:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 17:10:06 +0000 Subject: [Koha-bugs] [Bug 10835] New: Patron search for using "contains" search type fails with only one search term Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Bug ID: 10835 Summary: Patron search for using "contains" search type fails with only one search term Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The patron search type option "contains" works fine for multiple strings, but returns no results for a single string search. For example, the patron "Henry Acevedo" will be returned for a "contains" search "en ev" but not for just "en" or "ev". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 19:12:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 17:12:42 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 19:12:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 17:12:44 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 --- Comment #1 from Kyle M Hall --- Created attachment 20832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20832&action=edit Bug 10835 - Patron search for using "contains" search type fails with only one search term The patron search type option "contains" works fine for multiple strings, but returns no results for a single string search. For example, the patron "Henry Acevedo" will be returned for a "contains" search "en ev" but not for just "en" or "ev". Test Plan: 1) Create 2 patrons named "Test One" and "Test Two" 2) Run a "contains" search for the term "est" 3) Note no results were found 4) Apply this patch 5) Repeat step 2 6) Note the patrons now display in the search results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 19:13:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 17:13:59 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20832|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 20833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20833&action=edit Added a line break -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 19:14:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 17:14:24 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20833|Added a line break |Bug 10835 - Patron search description| |for using "contains" search | |type fails with only one | |search term -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 19:19:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 17:19:28 +0000 Subject: [Koha-bugs] [Bug 10771] three disused scripts in misc/cronjobs/stats should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 19:19:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 17:19:30 +0000 Subject: [Koha-bugs] [Bug 10771] three disused scripts in misc/cronjobs/stats should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20813|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20834&action=edit Bug 10771: remove disused statistical reports cronjobs This patch removes three cronjobs that are believed to be unused for the following reasons: [1] The commit message that introduces them indicates that they were written for a particular library. A staff member from that library has confirmed that they are not in use. [2] The scripts have received essentially no patches since they were introduced except for being caught up in a broader code-improvement patch. [3] They refer to a column that no longer exists in biblioitems. [4] They no longer adhere to guidelines for command-line utilities, and there's been no sign that anybody has felt the urge to correct that. [5] They are not referenced by another code or the manual, and the mailing list archives do not include any substantive discussion of their use. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 19:20:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 17:20:10 +0000 Subject: [Koha-bugs] [Bug 10771] three disused scripts in misc/cronjobs/stats should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 19:23:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 17:23:41 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 19:23:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 17:23:43 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20580|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 20835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20835&action=edit Bug 8752 - Log circulation renewal Currently, circulation renewals are not being logged. This patch logs renewals under the Circulation module with an action of RENEW. At the moment, it relies on the "IssueLog" preference, but we could add a new syspref for "RenewLog". Personally, I figure it's just a "re-issue" so I don't know that we need another preference, but system preferences are cheap, so if people think a follow-up is necessary, I'm open to the idea. Test Plan: 0) Turn on IssueLog and ReturnLog in the system preferences 1) Checkout an item 2) Note that there is a CIRCULATION ISSUE log entry 3) Renew that item 4) Note that there is NOT a log entry 5) Return that item 6) Note that there is a CIRCULATION RETURN log entry 7) Apply patch 8) Repeat Step #3 (i.e. renew that item). 9) Note that there is now a CIRCULATION RENEW log entry N.B. Logs can be viewed by directly querying the database, viewing the Modification Log for the patron attached to the checkout/renew/ return, or by viewing the logs in the Tools module using the item's itemnumber as the "Object". Signed-off-by: Owen Leonard This works as advertised, and I think it's an appropriate extension to the scope of IssueLog. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 20:26:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 18:26:57 +0000 Subject: [Koha-bugs] [Bug 10771] three disused scripts in misc/cronjobs/stats should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 20:28:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 18:28:34 +0000 Subject: [Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 20:37:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 18:37:54 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Owen Leonard --- Kyle, do you have subtitles configured for display under "Keywords to MARC mapping?" /cgi-bin/koha/admin/fieldmapping.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 20:42:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 18:42:37 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 --- Comment #5 from Kyle M Hall --- Nope, thanks for the help! Kyle (In reply to Owen Leonard from comment #4) > Kyle, do you have subtitles configured for display under "Keywords to MARC > mapping?" > > /cgi-bin/koha/admin/fieldmapping.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 20:42:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 18:42:51 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- I notice that if you renew by going to the patron's summary, then clicking the renew button, only the renewal gets logged -- as expected. However, if you renewal by going to the checkout page, then entering the barcode of the item to renew, the renewal gets logged twice: once as an ISSUE, and once as a RENEW. Would folks agree that it shouldn't be logged twice? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 20:43:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 18:43:06 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 --- Comment #6 from Kyle M Hall --- Created attachment 20836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20836&action=edit Bug 10672 - Add subtitle to display of checkouts, overdues, and holds on the patron summary In the OPAC, the patron summary page (opac-user.pl) should display subtitle along with title in the lists of checkouts, overdues, and holds. This patch adds it. To test, log in to the OPAC as a patron who has checkouts, overdues, and holds which include titles with subtitles. Titles should appear correctly with and without subtitles. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 20:43:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 18:43:04 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 20:43:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 18:43:32 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20053|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 21:48:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2013 19:48:36 +0000 Subject: [Koha-bugs] [Bug 10836] New: New layout for placing holds in the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Bug ID: 10836 Summary: New layout for placing holds in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 20837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20837&action=edit Screenshot of the revised interface I propose to change the layout of the OPAC place hold screen so that information is not displayed in a table. As options are added to the place hold process the table layout gets more an more unwieldy. This revised version makes the layout feel more open and provides a way to show and hide the finer hold controls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 02:23:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 00:23:21 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #42 from Chris Cormack --- (In reply to Martin Renvoize from comment #40) > Created attachment 20821 [details] [review] > Bug 7973: Fixed bug in Auth_with_ldap - Counter patch > > I came across this issue at one of our sites today and patched it before > finding the bugzilla entry. > > The patch already here seems to overcomplicate the issue somewhat unless I'm > completely missing something. > > Attached is my counter patch proposal. The patches here have already been pushed Martin. I am obsoleting them. So your patch is not so much a counter patch as a new one, and should be on its own bug, this bug should not have been reopened once the patches were pushed, a new bug should have been lodged. That is of course not your fault, but it still is probably best you put the patch on a new bug, and we close this again. Sound ok? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 02:23:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 00:23:50 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16703|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 02:25:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 00:25:17 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16704|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 02:33:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 00:33:02 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 02:33:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 00:33:05 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20799|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 20838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20838&action=edit Bug 10817 Return hold items info in Sip Patron Info Resp When requested by the summary flags the sipserver should return in the patron info response barcodes of the relevant titles. For available holds this is the barcode of the captured items. For unavailable holds ( i.e. icurrent unsatisfied holds ) We need to send a barcode so that the unit can use this to request the title info. The barcode could be any one belonging to the title. This patch also corrects the erroneous return of empty items in the patron information response. If the unir supplies a range 1 - 100 unless the title has a hundred or more copies the unit expects all copies. The server was erroneously stuffing the returned arrays with null copies so that all summary requests returned 100 copies (mainly without barcodes) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 02:35:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 00:35:58 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 02:36:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 00:36:02 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20805|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20839&action=edit Bug 10792: fix sorting of funds table on acquisitions home page This patch introduces a DataTables sorting plugin, title-numeric, for sorting cells based on a decimal number embedded in a span title attribute. This allows currency amounts to be formatted properly for display without having to writing a sorting plugin that's super-smart about removing the formatting, particularly for locales that use a comma as the decimal mark. The sorter plugin can be used like this: - In the DataTables config: "aoColumns": [ { "sType": "title-numeric" }, ] - In the table data [% formatted currency %] To test: [1] Go to the acquisitions home page. Note that changing the sort order on the amount, ordered, spent, or avail columns results in incorrect sorting that is either ASCII-betical or which ignores any component of large numbers that occur after the thousands separator. [2] Apply the patch. [3] Verify that the sorting now works correctly and that no JavaScript errors appear in the JS debug console of your choice. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 03:24:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 01:24:37 +0000 Subject: [Koha-bugs] [Bug 10837] New: Checkboxes are missing in Serial > Claims > 'Late Selections list'' . So I cannot do "Exported selected items"" in my installations(v 3.12.0 and 3.12.3) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10837 Bug ID: 10837 Summary: Checkboxes are missing in Serial > Claims > 'Late Selections list'' . So I cannot do "Exported selected items"" in my installations(v 3.12.0 and 3.12.3) Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: bala.allmail at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Check boxes are missing in Serial > Claims > 'Late Selections list'' . So I cannot do "Exported selected items"" in my installations(v 3.12.0 and 3.12.3) In Koha Demo( 3.12v), I have observed same but Manual shows there are check boxes in 3.10v for the same task I am new to KOHA and we, Open university, Sri Lanka testing the system feasibility this is a drawback to us as we have significant amount to Serials to manage. Thanks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 05:19:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 03:19:44 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 05:19:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 03:19:47 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20833|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 20840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20840&action=edit Bug 10835 - Patron search for using "contains" search type fails with only one search term The patron search type option "contains" works fine for multiple strings, but returns no results for a single string search. For example, the patron "Henry Acevedo" will be returned for a "contains" search "en ev" but not for just "en" or "ev". Test Plan: 1) Create 2 patrons named "Test One" and "Test Two" 2) Run a "contains" search for the term "est" 3) Note no results were found 4) Apply this patch 5) Repeat step 2 6) Note the patrons now display in the search results. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 05:22:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 03:22:08 +0000 Subject: [Koha-bugs] [Bug 10838] New: Silence warnings in members/member.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10838 Bug ID: 10838 Summary: Silence warnings in members/member.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 10835 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 05:22:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 03:22:08 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10838 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 05:34:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 03:34:06 +0000 Subject: [Koha-bugs] [Bug 10838] Silence warnings in members/member.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10838 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 05:34:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 03:34:09 +0000 Subject: [Koha-bugs] [Bug 10838] Silence warnings in members/member.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10838 --- Comment #1 from Chris Cormack --- Created attachment 20841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20841&action=edit Bug 10838 : Silence warns in members/member.pl To test 1/ Uncomment the use warnings line 2/ Search for a patron, notice all the warnings 3/ Browse for a patron, notice warnings 4/ Apply patch 5/ Repeat 3 and 4 6/ Notice no errors and the search still works This depends on the patch for Bug 10835 Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 05:38:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 03:38:06 +0000 Subject: [Koha-bugs] [Bug 10405] User-editable sections should have ids In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #8 from M. Tompsett --- Could you explain koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc changes? I can understand removing the IF/END around it, but why did the content line disappear?! [% OPACResultsSidebar %] should be left as is. I eyeballed the other changes and they all make sense and within scope. I'll let someone else change the status of this bug, as perhaps there is a reason of which I am unaware. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 05:39:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 03:39:08 +0000 Subject: [Koha-bugs] [Bug 10802] history.txt missing in packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 05:39:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 03:39:11 +0000 Subject: [Koha-bugs] [Bug 10802] history.txt missing in packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20725|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20842&action=edit Bug 10802: Packages should install history.txt While bug 8911 fixed a problem regarding history.txt, a proper fix for packages was missing. This patch does three things: - Adds docs/history.txt to debian/koha-common.docs so it gets installed. - Moves the line installing the release notes from debian/koha-common.install to debian/koha-common.docs. - Adds an override_dh_compress entry in debian/rules that excludes history.txt from the dh_compress routine [1] To test: - Take a picture of how /usr/share/doc/koha-common looks. - Apply the patch and build a package [2]. - Upgrade and/or install using your package. - Look for the contents of the /usr/share/doc/koha-common, it should look the same, but history.txt must be there. - More > About Koha > Koha Timeline should show the history lines. Regards To+ [1] As 'man dh_compress' says, it is needed as every file considered for the doc dir that is plain text and is more than 4k size will be gzipped unless stated otherwise. We need it uncompressed for about.pl. [2] I did it for you, it can be grabbed here: http://ubuntu.unc.edu.ar/koha/koha-common_3.13-1~git+20130829144510.18a6876b_all.deb Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 09:04:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 07:04:30 +0000 Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 09:04:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 07:04:34 +0000 Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20680|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 20843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20843&action=edit Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries This patch adds the ti,phr index to the search queries for the 780 and 785 MARC fields in the XSLT templates. Test Plan: 1) Use a record with 780 and 785 MARC fields with data in the "a" or "t" subfields. (You might need to add these fields to an existing record, or create a new record. You might also need to change your MARC Bibliographic Framework settings to not "hide" these fields in your framework(s)). N.B. The data in the "a" or "t" subfields should be a title that exists in your database. Otherwise, this test might seem misleading. 2) Set the system preferences "XSLTDetailsDisplay" and "OPACXSLTDetailsDisplay" to "default". 3) Go to your record (which contains the 780/785 fields), and look for links with linktext derived from the "a" or "t" fields in the record. These may or may not be prefaced with labels such as "Continued by" or "Continues". 4) Note that the links are formatted "q=TITLE". Click this link and note the possibly high number of results. 5) APPLY THE PATCH 6) Shift+Refresh your record page, and observe that the link should now say "q=ti,phr:TITLE". Click this link and note that you are either taken directly to the referenced article or that your search results are considerably fewer. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 09:14:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 07:14:32 +0000 Subject: [Koha-bugs] [Bug 10820] Lost items on search results don't jive with record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 09:14:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 07:14:35 +0000 Subject: [Koha-bugs] [Bug 10820] Lost items on search results don't jive with record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20780|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 20844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20844&action=edit Bug 10820 - Lost items on search results don't jive with record details In the OPAC, if an items is both lost and checked out, it will show as lost on the search results, and checkout out in the record details. The lost status should take precedence over the checked out status, as the checked out status may lead a patron to believe the book may return soon. Test Plan: 1) Check an item out to a patron 2) Set it to lost ( requires itemlost to be revealed in the framework for the items editor ). 3) Rebuild your zebra indexes 4) Run a search where that item is in the results list 5) Note the item is marked as lost 6) View the record details 7) Note the item is listed as "checked out" 8) Apply this patch 9) Repeat steps 4-6, note the item is now listed as lost Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 09:15:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 07:15:12 +0000 Subject: [Koha-bugs] [Bug 10839] New: Claim report of all vendors Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10839 Bug ID: 10839 Summary: Claim report of all vendors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Dear Friends, To get list of serial claims, librarian has to select each vendor. This facility is convenient for libraries have single serial vendor. Libraries suscribing serials direct from publishers need to select each vendor to get serial claims. In our library, 100 journals / magazines are receiving direct from publishers. In this situation, generating claim report is very time consuming. It is very convenient to get list of claims from all suppliers with one click from serial module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 11:11:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 09:11:21 +0000 Subject: [Koha-bugs] [Bug 3147] call to ModZebra in DelAuthority fails (fatal error) if record previously deleted but still exists in index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3147 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 11:12:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 09:12:58 +0000 Subject: [Koha-bugs] [Bug 3038] UNIMARC should not show 600$(\d) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3038 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |chris at bigballofwax.co.nz Resolution|--- |INVALID --- Comment #3 from Chris Cormack --- No one has confirmed this as being a problem, despite 2 attempts of asking, spanning 3 years. So it cant be too much of an issue, closing -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 11:51:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 09:51:31 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 skobyanka at mail.ru changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |skobyanka at mail.ru --- Comment #120 from skobyanka at mail.ru --- (In reply to Mike from comment #119) > I found same problem in 3.12.x in Czech translation. Problem on: > /cgi-bin/koha/members/members-home.pl > /cgi-bin/koha/admin/preferences.pl?tab=circulation > /cgi-bin/koha/admin/preferences.pl?tab=opac > /cgi-bin/koha/admin/preferences.pl?tab=patrons I solved the problem in /cgi-bin/koha/members/members-home.pl by removing from the Advanced Search patron Search by category: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/ru-RU/includes/patron-search.inc Delete: [% IF ( categories ) %]

[% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 16:54:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 14:54:29 +0000 Subject: [Koha-bugs] [Bug 10405] User-editable sections should have ids In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405 --- Comment #9 from Jared Camins-Esakov --- That looks like a mistake. Please feel free to open a new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 17:25:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 15:25:04 +0000 Subject: [Koha-bugs] [Bug 10840] New: Re-add missing [% OPACResultsSidebar %] Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 Bug ID: 10840 Summary: Re-add missing [% OPACResultsSidebar %] Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResults Sidebar %] from the opac-facets.inc file. This bug rectifies that problem. Test Plan: Confirm the problem =================== 1) Using version 3.12.4 package installation, set OPACResultsSidebar system preference to some text. 2) In the OPAC, search for something 3) In the facets list on the left, the text should appear. 4) Using master installation, set OPACResultsSidebar system preference to some text. 5) In the OPAC, search for something 6) The facets will not have the text, though viewing the source, there is an empty
. Correct the problem =================== 1) Apply the patch to the master system 2) In the OPAC, search again for something 3) The facets on the left will now have the text showing similar to the 3.12.4 version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 17:43:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 15:43:46 +0000 Subject: [Koha-bugs] [Bug 10840] Re-add missing [% OPACResultsSidebar %] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 --- Comment #1 from M. Tompsett --- Created attachment 20845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20845&action=edit Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %] Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResultsSidebar %] from the opac-facets.inc file. This bug rectifies that problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 17:45:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 15:45:16 +0000 Subject: [Koha-bugs] [Bug 10840] Re-add missing [% OPACResultsSidebar %] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from M. Tompsett --- See the test plan in the first comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 18:28:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 16:28:49 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #12 from Katrin Fischer --- Sorry, Kyle, but one more for Authorised Values slipped in: /home/katrin/kohaclone/koha-tmpl/opac-tmpl/prog/en/includes/item-status-schema-org.inc I am continueing with QA for KohaBranchName. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 18:35:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 16:35:47 +0000 Subject: [Koha-bugs] [Bug 10405] User-editable sections should have ids In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10840 --- Comment #10 from M. Tompsett --- Done. See Bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 18:35:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 16:35:47 +0000 Subject: [Koha-bugs] [Bug 10840] Re-add missing [% OPACResultsSidebar %] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10405 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 19:06:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 17:06:05 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 19:06:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 17:06:08 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20205|0 |1 is obsolete| | Attachment #20660|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 20846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20846&action=edit [PASSED QA] Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script. Also tested with a branch name with umlauts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 19:06:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 17:06:17 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #14 from Katrin Fischer --- Created attachment 20847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20847&action=edit [PASSED QA] Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches - Followup Signed-off-by: Katrin Fischer To test: Make sure - independentbranches is turned on - Your user doesn't have superlibrarian permission Then - Try to check out an item with home and holding branch != logged in branch Patch works alright. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 19:46:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 17:46:28 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20204|0 |1 is obsolete| | Attachment #20659|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 20848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20848&action=edit [PASSED QA] Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Comments on second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 19:46:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 17:46:38 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #16 from Katrin Fischer --- Created attachment 20849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20849&action=edit [PASSED QA] Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup Signed-off-by: Katrin Fischer Trying to write my own test plan here: 1) AllowNotForLoanOverride = Allow Mark single item not for loan and try to check it out. Check item not for loan status shows up correctly in message: Item is normally not for loan (Staff Collection). Check out anyway? 2) Toggle AllowNotForLoanOverride = Not Allow Try to check out your not for loan item again. Message has changed, but not for loan status should still show: Item not for loan (Staff Collection). 3) Check out item that is marked damaged. Check damaged status shows correctly in list of checkouts. 4) Mark item as lost and check it out. Check lost status shows up correctly in message: This item has been lost with a status of "Lange ?berf?llig (Verloren)". 5) Create your own custom SUGGEST_STATUS and check that it shows up correctly on the suggestion page. 6) Test item status show up correctly on OPAC detail page (lost, not for loan, damaged, etc). Requires follow-up patch to be applied. 7) Mark a suggestion with your custom status and make sure it shows up in the patron account in OPAC correctly. Passes tests and QA script - needs a follow up for item-status-schema-org.inc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 19:46:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 17:46:49 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #17 from Katrin Fischer --- Created attachment 20850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20850&action=edit Bug 10626: Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup 2 Removes USE KohaAuthorisedValues plugin from item-status-schema-org.inc as it does not seem to be used in the file. Couldn't detect regressions removing it on OPAC detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:05:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:05:51 +0000 Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 --- Comment #7 from Katrin Fischer --- I think this works as intended now, but it would be good if all fine lines showed not just the one you clicked - that would make more sense of the total given. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:08:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:08:59 +0000 Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:09:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:09:04 +0000 Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17354|0 |1 is obsolete| | Attachment #17355|0 |1 is obsolete| | Attachment #20812|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 20851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20851&action=edit [PASSED QA] Bug 10027 - Fine details not showing when printing a fine Previously printing a fine invoice would result in a page with both the single item charge and the total outstanding dues. Right now only the total outstanding is printed. Test Plan: 1) Print a fine, note the fine doesn't show, only the total 2) Apply patch 3) Print a fine, not the fine does show Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Comments on third patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:09:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:09:20 +0000 Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 --- Comment #9 from Katrin Fischer --- Created attachment 20852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20852&action=edit [PASSED QA] Bug 10027 - Fine details not showing when printing a fine - Tidy members/printinvoice.pl Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:09:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:09:28 +0000 Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 --- Comment #10 from Katrin Fischer --- Created attachment 20853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20853&action=edit [PASSED QA] Bug 10027 - Fine details not showing when printing a fine - QA Followup Signed-off-by: Katrin Fischer Passes all tests and QA script. Checked invoice is correctly printed for - partially paid fines - paid fines - unpaid fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:11:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:11:09 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:15:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:15:56 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:16:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:16:00 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20840|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 20854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20854&action=edit [PASSED QA] Bug 10835 - Patron search for using "contains" search type fails with only one search term The patron search type option "contains" works fine for multiple strings, but returns no results for a single string search. For example, the patron "Henry Acevedo" will be returned for a "contains" search "en ev" but not for just "en" or "ev". Test Plan: 1) Create 2 patrons named "Test One" and "Test Two" 2) Run a "contains" search for the term "est" 3) Note no results were found 4) Apply this patch 5) Repeat step 2 6) Note the patrons now display in the search results. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer All tests and QA script pass. Also checked that 'starts with' still works as expected - searching for ev will only return "Eva Dillon" from the example patrons in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:31:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:31:12 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:34:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:34:06 +0000 Subject: [Koha-bugs] [Bug 10034] "kw,rld:" in Z39.50 research In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Galen Charlton --- *** This bug has been marked as a duplicate of bug 5645 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:34:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:34:06 +0000 Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not parsing query correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gabrielle.dusseault at gmail.c | |om --- Comment #4 from Galen Charlton --- *** Bug 10034 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:34:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:34:35 +0000 Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not parsing query correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10742 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:34:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:34:35 +0000 Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5645 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:35:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:35:32 +0000 Subject: [Koha-bugs] [Bug 9342] zebra UNIMARC dom indexing does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9342 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Z39.50 / SRU / OpenSearch |Searching |Servers | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:35:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:35:40 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Z39.50 / SRU / OpenSearch |Searching |Servers | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:35:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:35:40 +0000 Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not parsing query correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 --- Comment #5 from Galen Charlton --- The patch for bug 10742 fixes the case when the main search returns no results. I will shortly be attaching a patch that fixes this when the main search *does* return results. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:37:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:37:09 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12852|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:39:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:39:59 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 --- Comment #3 from Katrin Fischer --- Created attachment 20855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20855&action=edit Screenshot of acquisiton funds table with non-working sort and patch applied Sadly, this doesn't work for me. I tested in 2 different browsers (Firefox and Chromium), reloading the Javascript files multiple times. Error shown in firebug: datatables.js, line 513 TypeError: a.match(...) is null var x = a.match(/title="*(-?[0-9\.]+)/)[1]; Screenshot of my acquisitions table attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:49:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:49:10 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:49:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:49:14 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20788|0 |1 is obsolete| | --- Comment #105 from Katrin Fischer --- Created attachment 20856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20856&action=edit [PASSED QA] Bug 7143: history.txt and about page updates - two new developers - releases Signed-off-by: Galen Charlton Signed-off-by: Jared Camins-Esakov Signed-off-by: Katrin Fischer Reads all ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:51:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:51:10 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:51:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:51:23 +0000 Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not parsing query correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 --- Comment #6 from Galen Charlton --- Created attachment 20857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20857&action=edit Bug 5645: improve converting simple search to Z39.50 search This patch builds on the patch for bug 10742 by ensuring that when a search initiated from the staff interface simple search returns results, if you click on the Z39.50 search button, the search form is populated with the search string without "kw,wrdl". To test: [1] Perform a search in the staff interface that will return results. [2] Click the Z39.50 search button. [3] Observe that the search string appears in the title field in the Z39.50 search form, but with a prefix of "kw,wrdl". [4] Apply the patch. [5] Repeat steps 1-2. This time, the search string appears without the index prefix. This will make the Z39.50 search much more likely to work. [6] Repeat steps 1-2, but with a search that does *not* return any hits in the Koha database. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:51:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:51:20 +0000 Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not parsing query correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:57:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:57:45 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 20:57:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 18:57:48 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 --- Comment #4 from Galen Charlton --- Created attachment 20858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20858&action=edit Bug 10792: fix sorting of funds table on acquisitions home page This patch introduces a DataTables sorting plugin, title-numeric, for sorting cells based on a decimal number embedded in a span title attribute. This allows currency amounts to be formatted properly for display without having to writing a sorting plugin that's super-smart about removing the formatting, particularly for locales that use a comma as the decimal mark. The sorter plugin can be used like this: - In the DataTables config: "aoColumns": [ { "sType": "title-numeric" }, ] - In the table data [% formatted currency %] To test: [1] Ensure that there is at least one active budget and at least one inactive one. [2] Go to the acquisitions home page. Note that changing the sort order on the amount, ordered, spent, or avail columns results in incorrect sorting that is either ASCII-betical or which ignores any component of large numbers that occur after the thousands separator. [3] Apply the patch. [4] Verify that the sorting now works correctly and that no JavaScript errors appear in the JS debug console of your choice. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 21:01:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 19:01:42 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 21:12:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 19:12:22 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 21:12:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 19:12:25 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20858|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 20859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20859&action=edit [SIGNED OFF] Bug 10792: fix sorting of funds table on acquisitions home page This patch introduces a DataTables sorting plugin, title-numeric, for sorting cells based on a decimal number embedded in a span title attribute. This allows currency amounts to be formatted properly for display without having to writing a sorting plugin that's super-smart about removing the formatting, particularly for locales that use a comma as the decimal mark. The sorter plugin can be used like this: - In the DataTables config: "aoColumns": [ { "sType": "title-numeric" }, ] - In the table data [% formatted currency %] To test: [1] Ensure that there is at least one active budget and at least one inactive one. [2] Go to the acquisitions home page. Note that changing the sort order on the amount, ordered, spent, or avail columns results in incorrect sorting that is either ASCII-betical or which ignores any component of large numbers that occur after the thousands separator. [3] Apply the patch. [4] Verify that the sorting now works correctly and that no JavaScript errors appear in the JS debug console of your choice. Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Sorting now works correctly, for active and inactive funds. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 21:35:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 19:35:50 +0000 Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 21:35:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 19:35:53 +0000 Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20843|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 20860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20860&action=edit [PASSED QA] Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries This patch adds the ti,phr index to the search queries for the 780 and 785 MARC fields in the XSLT templates. Test Plan: 1) Use a record with 780 and 785 MARC fields with data in the "a" or "t" subfields. (You might need to add these fields to an existing record, or create a new record. You might also need to change your MARC Bibliographic Framework settings to not "hide" these fields in your framework(s)). N.B. The data in the "a" or "t" subfields should be a title that exists in your database. Otherwise, this test might seem misleading. 2) Set the system preferences "XSLTDetailsDisplay" and "OPACXSLTDetailsDisplay" to "default". 3) Go to your record (which contains the 780/785 fields), and look for links with linktext derived from the "a" or "t" fields in the record. These may or may not be prefaced with labels such as "Continued by" or "Continues". 4) Note that the links are formatted "q=TITLE". Click this link and note the possibly high number of results. 5) APPLY THE PATCH 6) Shift+Refresh your record page, and observe that the link should now say "q=ti,phr:TITLE". Click this link and note that you are either taken directly to the referenced article or that your search results are considerably fewer. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer XSLT change only, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 21:36:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 19:36:02 +0000 Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Just a note: To my knowledge phrase searches don't work over multiple subfields without additional work/DOM. This patch will create a search string like: ti,phr:<$a><$t>. This seems to produce relevant results, but might not always be as precise as intended. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 21:51:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 19:51:54 +0000 Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for bibliographic information on OPAC results and detail pages (UNIMARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|In OPAC XSLT search |Add individual CSS classes |results, add class to |for bibliographic |'online access' - UNIMARC |information on OPAC results | |and detail pages (UNIMARC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 21:54:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 19:54:57 +0000 Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for bibliographic information on OPAC results and detail pages (UNIMARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 21:55:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 19:55:00 +0000 Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for bibliographic information on OPAC results and detail pages (UNIMARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20679|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 20861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20861&action=edit [PASSED QA] Bug 10218: Add individual CSS classes for bibliographic information in OPAC (UNIMARC) Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works exactly as described on results and detail. No koha-qa errors Signed-off-by: Katrin Fischer XSLT only change. Tested in a UNIMARC install, HTML source code looks ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 22:17:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 20:17:27 +0000 Subject: [Koha-bugs] [Bug 10721] Improve DataTables configuration on transfers to receive report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 22:19:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 20:19:21 +0000 Subject: [Koha-bugs] [Bug 10721] Improve DataTables configuration on transfers to receive report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 22:19:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 20:19:24 +0000 Subject: [Koha-bugs] [Bug 10721] Improve DataTables configuration on transfers to receive report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20523|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20862&action=edit [PASSED QA] Bug 10721 - Improve DataTables configuration on transfers to receive report I noticed this template used a hidden span to allow correct sorting of titles--a relic of the previous table sorting plugin. I have removed that and added an improved DataTables configuration. To test apply the patch and view the transfers to receive report for a library which has multiple transfers to receive. Sorting should work correctly on all columns, including correct date sorting regardless of dateformat system preference. Title sorting should correctly exclude articles. Signed-off-by: David Cook Signed-off-by: Katrin Fischer Passes all tests and works nicely. Tested with different date formats. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 22:34:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 20:34:06 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- Do we have a reference about CURRENT_DATE being a mysqlism? I found it here: http://www.contrib.andrew.cmu.edu/~shadow/sql/sql1992.txt Also bit worried about changing all those statements without tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 22:47:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 20:47:48 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20856|0 |1 is obsolete| | --- Comment #106 from Galen Charlton --- Comment on attachment 20856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20856 [PASSED QA] Bug 7143: history.txt and about page updates Pushed latest to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 22:47:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 20:47:55 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 22:53:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 20:53:37 +0000 Subject: [Koha-bugs] [Bug 10835] Patron search for using "contains" search type fails with only one search term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10835 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 22:57:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 20:57:59 +0000 Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for bibliographic information on OPAC results and detail pages (UNIMARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20861|0 |1 is obsolete| | --- Comment #19 from Galen Charlton --- Comment on attachment 20861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20861 [PASSED QA] Bug 10218: Add individual CSS classes for bibliographic information in OPAC (UNIMARC) Pushed to master. Thanks, Mathieu! Setting back to assigned; only NORMARC remains. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 22:58:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 20:58:05 +0000 Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for bibliographic information on OPAC results and detail pages (UNIMARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 23:01:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 21:01:17 +0000 Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, David! A version of this might be applicable to the NORMARC stylesheets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 23:05:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 21:05:39 +0000 Subject: [Koha-bugs] [Bug 10721] Improve DataTables configuration on transfers to receive report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 23:08:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 21:08:49 +0000 Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts, overdues, and holds on the patron summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 23:24:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 21:24:32 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- I have concerns about the implementation of this -- in particular, for a bib that is /not/ going to end up hidden, the acts of retrieving all of the items and checking which ones are hidden occur /twice/. In my opinion, this is likely to impose too high of a performance penalty for typical OPACs, which don't have high numbers of hidden items. I suggest revising the patch so that rather than adding a call to GetHiddenItems(), the bailing-out occurs after the original call to GetHiddenItems(). Additional refactoring might be called for (but as the topic of a separate bug) to minimize the processing gets wasted whether or not the bib ends up hidden. Also, I'm not a fan of the notion of using 0 as a "magic" biblionumber -- to bail out, just issue the redirect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 23:26:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 21:26:04 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #5 from Katrin Fischer --- A looks good, but it seems something is wrong with my UNIMARC installation, as I am not able to add authorities there :( No matter what I enter in 100$a I always get: Unsupported UNIMARC character encoding [] for XML output for UNIMARCAUTH; 100$a -> a at /usr/share/perl5/MARC/File/XML.pm line 505. Jonathan, maybe you could take a look at this? Adding you as QA contact. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 23:42:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 21:42:00 +0000 Subject: [Koha-bugs] [Bug 10324] Editorial series do not display correctly in normal view (UNIMARC / no XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10324 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 23:42:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 21:42:04 +0000 Subject: [Koha-bugs] [Bug 10324] Editorial series do not display correctly in normal view (UNIMARC / no XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10324 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20754|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20863&action=edit [PASSED QA] Bug 10324 - Editorial series do not display correctly in normal view (UNIMARC / no XSLT) The patch corrects the issue -- the content of the field 225 shall be displayes under Series now. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, no koha-qa errors Signed-off-by: Katrin Fischer Comparing the XSLT with the normal view the patch seems to work correctly. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 7 23:43:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 21:43:38 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 00:05:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 22:05:31 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 00:05:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 22:05:35 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20778|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 20864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20864&action=edit [PASSED QA] Bug 10272 - CheckReserves returns not respecting ReservesControlBranch CheckReserves is using the CircControl system preference to determine what patrons an item can fill a hold for. It should be using ReservesControlBranch instead. Test Plan: 1) Set ReservesControlBranch to "item's home library". 2) Create an item at Library A, place holds for it for patrons at Library B, Library C, and Library A in that order, for pickup at the patrons home library. 3) Make sure the holds policy for Library A is set to Hold Policy = "From home library" and Return Policy = "Item returns home". Make sure the holds policies for the other libraries are set to Hold Policy = "From any library". 4) Check the item in at Library C, the hold for the patron at Library B should pop up, even though it's in violation of the circulation rules. Don't click the confirm button! 5) Apply this patch, and reload the page, now the hold listed should be for the last hold, the hold for the patron at Library A, which is correct. This patch adds the subroutine C4::Reserves::GetReservesControlBranch as an equivilent to C4::Circulation::_GetCircControlBranch. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Fixed POD so that arguments and explanation match (C<$item>). Also tested opac-reserves.pl for regressions. Passes all tests, QA script, and Reserves.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 00:12:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 22:12:08 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Jonathan, I noticed that we use a different icon for duplicating patrons - maybe we could use that here too? Functionally it seems to work fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 00:17:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 22:17:39 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 00:17:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 22:17:42 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20196|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 20865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20865&action=edit [PASSED QA] Bug 10600: Duplicate an authority A simple link allows to duplicate an existing authority. Test plan: 1/ Go to a detail authority page 2/ Click to the "Duplicate" button 3/ Edit some fields 4/ Save 5/ The new authority is created from the existing one. Signed-off-by: Nicole C. Engard tests pass Signed-off-by: Katrin Fischer All tests pass. Template change only. Also compared the original with the duplicated authoritiy in MARCXML - no unwanted differences found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 00:19:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 22:19:50 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #5 from Katrin Fischer --- Hi Jonathan, could you take a look at my question in comment 3? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 00:34:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 22:34:25 +0000 Subject: [Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15327|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 20866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20866&action=edit [SIGNED-OFF] Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation (followup) Add tests : if field < 10 it must not have a subfield if field > 9 is must have a subfield Signed-off-by: Bernardo Gonzalez Kriegel Both patches applied, no koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 00:42:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 22:42:12 +0000 Subject: [Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 20867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20867&action=edit Bug 9192: followup fix typo Fix typo on usage message. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 00:42:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 22:42:47 +0000 Subject: [Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 01:06:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 23:06:34 +0000 Subject: [Koha-bugs] [Bug 10841] New: Edit/Delete item context links in items table are not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Bug ID: 10841 Summary: Edit/Delete item context links in items table are not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr To test: - Install an additional language - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly, but are not translated. Also capitalization is not correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 01:08:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 23:08:03 +0000 Subject: [Koha-bugs] [Bug 10841] Edit/Delete item context links in items table are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 01:08:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 23:08:06 +0000 Subject: [Koha-bugs] [Bug 10841] Edit/Delete item context links in items table are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 --- Comment #1 from Katrin Fischer --- Created attachment 20868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20868&action=edit Bug 10841: Make edit/delete item context links in cataloguing translatable HTML created with Javascript is not translatable the way HTML is normally translated. _() syntax has to be used to have strings translatable. To test: - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly - Apply patch - Verify the links still show the same behaviour Bonus: - Run 'perl translate update ' in misc/translator - Verify that Edit item and Delete item show up in the po file, translate them - Install updated po files running 'perl translate install ' - Verify links show up translated and work correctly Patch also fixes capitalization for a couple of error messages - only change there is: Deleted > deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 01:35:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 23:35:37 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18386|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 20869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20869&action=edit [SIGNED-OFF] Bug 10335 - UNIMARC authorities search doesn't display properly information on parallel form The patch corrects the issue and should not harm those who (improperly) put only one triple in $8 Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors. Same result on OPAC and STAFF Turns out that test plan is wrong, you neet to fill tag 200ab, not 100ab, for main heading. I filled 100a with some example data from UNIMARC auth manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 01:37:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Sep 2013 23:37:55 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 03:11:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 01:11:00 +0000 Subject: [Koha-bugs] [Bug 9128] Text not translatable in OPAC ("Available") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9128 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |bgkriegel at gmail.com Resolution|--- |WORKSFORME --- Comment #1 from Bernardo Gonzalez Kriegel --- This may have been due by a missing string in Portuguese translation. Current master shows correct word (Dispon?vel) with both version of of portuguese translation(BR and PT) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 03:24:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 01:24:45 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Galen Charlton --- Pushed to master, along with a follow-up that adds a regression test. Thanks, Kyle! As a side-note, I care a /lot/ about there being regression tests, especially for changes that touch circulation and/or hold requests. While the unit test for the new routine was necessary, it wasn't sufficient. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 03:28:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 01:28:19 +0000 Subject: [Koha-bugs] [Bug 10810] Fix synopsis for -html option to overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10810 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20749|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 20870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20870&action=edit [SIGNED-OFF] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl The synopsis for the -html option used to be: -html Output html to file but the argument to this option should actually be a directory, not a filename. This patch fixes the synopsis. To test: - Run perldoc misc/cronjobs/overdue_notices.pl - Check that the synopsis is as shown above - Apply this patch - Run perldoc misc/cronjobs/overdue_notices.pl - Check that - the synopsis asks for a directory, not a filename - that the description of the -html option further down in the perldoc now mentions the filename that the HTML file will be created with. Signed-off-by: Bernardo Gonzalez Kriegel Works as described. No koha-qa errors. If feeded with a filename -html option fails with many messages like print() on closed filehandle $html_fh at misc/cronjobs/overdue_notices.pl line 384. Perhaps it could be improved, but that was the old behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 03:28:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 01:28:35 +0000 Subject: [Koha-bugs] [Bug 10810] Fix synopsis for -html option to overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10810 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 03:34:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 01:34:27 +0000 Subject: [Koha-bugs] [Bug 10324] Editorial series do not display correctly in normal view (UNIMARC / no XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10324 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Janusz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 03:49:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 01:49:41 +0000 Subject: [Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 03:59:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 01:59:30 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18058|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 20871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20871&action=edit [SIGNED-OFF] Bug 9739: more options for serialsUpdate.pl Script serialsUpdate.pl must be set in crontab to run daily. It checks serials that are late, modifies status and adds a note. This patch adds some options : --note : defined note, a defaut one is used if not defined --no-note : disable automatic note --verbose : used to control output This patch also implements confirmation option "-c" who whas present but not used. Test plan : Run script on a database with late serials : - serialsUpdate.pl -h => you get help text in output - serialsUpdate.pl --man => you get full help - serialsUpdate.pl -v => you get output of changed serials but database has not changed - serialsUpdate.pl -c -v => you get output of changed serials and database has changed, with note "Automatically set to late" - serialsUpdate.pl -c => database has changed without anything in output - serialsUpdate.pl -c --note "LATE" => database has changed, with note "LATE" - serialsUpdate.pl -c --no-note => database has changed with no note Signed-off-by: Bernardo Gonzalez Kriegel Works as described. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 03:59:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 01:59:45 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18059|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 20872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20872&action=edit [SIGNED-OFF] Bug 9739: more options for serialsUpdate.pl (followup) cosmetic changes : perltidy q{} for query list of columns is query instead of SELECT * Signed-off-by: Bernardo Gonzalez Kriegel Your cosmetic changes missed a comma, fixed in a followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 04:02:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 02:02:47 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 20873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20873&action=edit Bug 9739 - followup - adds missing comma Adds a missing comma in select statement. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 04:03:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 02:03:27 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 04:05:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 02:05:25 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #14 from Galen Charlton --- Pushed to master, along with a couple follow-ups. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 04:07:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 02:07:37 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #16 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 04:30:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 02:30:08 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Galen Charlton --- Pushed to master, along with a follow-up that adds a test case and another that fixes typos. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 05:04:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 03:04:52 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 --- Comment #6 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #5) > A looks good, but it seems something is wrong with my UNIMARC installation, > as I am not able to add authorities there :( > > No matter what I enter in 100$a I always get: Unsupported UNIMARC character > encoding [] for XML output for UNIMARCAUTH; 100$a -> a at > /usr/share/perl5/MARC/File/XML.pm line 505. > Katrin, I used 'YYYYMMDDaengy01030204ba0' for 100a, just copied from UNIMARC auth manual, and worked But I noticed something else unrelated with the bug. If I add a new authority and press save without filling any tag, the error message points the missing fields but the tab number information is missing, at last in my install. For example "fixed length control f in tab ..." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 06:50:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 04:50:53 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 --- Comment #13 from M. Tompsett --- (In reply to Galen Charlton from comment #12) > I have concerns about the implementation of this -- in particular, for a bib > that is /not/ going to end up hidden, the acts of retrieving all of the > items and checking which ones are hidden occur /twice/. After looking for GetHiddenItems and GetItemsInfo, I see what you mean by twice. > In my opinion, this is likely to impose too high of a performance penalty > for typical OPACs, which don't have high numbers of hidden items. This is the opac-details.pl page, I have a hard time imagining tens of thousands of items. Daily Newspapers perhaps? 2N is still order N, but I do agree there is room for optimization. > Also, I'm not a fan of the notion of using 0 as a "magic" biblionumber -- to > bail out, just issue the redirect. I'm not a fan of multiple exits, but you have a valid point. Though, the magic bullet is already used in the case that no biblionumber is passed. > I suggest revising the patch so that rather than adding a call to > GetHiddenItems(), the bailing-out occurs after the original call to > GetHiddenItems(). The code is such that I can move and reuse the @hiddenitems in my patched code, and dump @items2hide. This reduces that to a single call. My concern is more about the GetItemsInfo double call, now that you pointed it out. I'm wondering about the "change back when I've fixed request.pl" comment from 2002. Can I effectively dump @itemsmatchingbiblionumber, and move @all_items into the patched area for use there too, deleting the comment? Or should I stick with a safer pushing the contents of @itemsmatchingbiblionumber to the @all_items, instead of the second call, so as to retain a hint of what the comment might be talking about? > Additional refactoring might be called for (but as the > topic of a separate bug) to minimize the processing gets wasted whether or > not the bib ends up hidden. I think a single line of code, "return () if (! $yaml =~ /\S/ );" or "return () unless $hidingrules;", in the GetHiddenItems code may be a tiny optimization of note, but agree that is best suited for another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 07:16:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 05:16:43 +0000 Subject: [Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 07:44:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 05:44:55 +0000 Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 07:49:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 05:49:40 +0000 Subject: [Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t ("alert" field) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 08:04:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 06:04:07 +0000 Subject: [Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t ("alert" field) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Adrien! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 08:11:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 06:11:39 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #21 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 08:29:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 06:29:12 +0000 Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 08:32:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 06:32:03 +0000 Subject: [Koha-bugs] [Bug 10769] Simplify clearing of input fields when duplicating a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 08:34:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 06:34:42 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 09:07:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 07:07:13 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #29 from Galen Charlton --- Pushed to master, along with follow-ups to correct the license, a typo in the name of one of the system preference, adding the new sysprefs to sysprefs.sql, and handling OverDrive authentication failures encountered by the proxy service a tick more gracefully than by tossing an internal server error. Thanks, Jesse! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 09:12:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 07:12:15 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 09:26:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 07:26:29 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 --- Comment #7 from Katrin Fischer --- Could it be that the English frameworks are missing a plugin here? I would have never guessed that :) Trying again a little later - thx Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 09:40:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 07:40:29 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 --- Comment #10 from Galen Charlton --- Created attachment 20874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20874&action=edit Bug 9924: (follow-up) ensure that correct error message is displayed (Apparently) unlike HTML::Template::Pro, Template Toolkit doesn't like template variables that are entirely numeric -- in conditionals, it consider them integers, most of which are Perl true. This patch changes this by setting the error variable to the error value. To test: [1] Run the test plan from the previous patch. In each case, verify that the error message is specifically applicable to the test. For example, if you try uplaoading a patron image that is larger than 500KB, the error message displayed should specifically say so. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 09:42:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 07:42:03 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- In the course of testing this, I discovered that the patron card errors were broken, probably since the switch to Template Toolkit -- numeric template variable names are not a Good Thing. The follow-up patch I just attached tries to fix this. Setting to signed off for QA review of the follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:04:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:04:22 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:04:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:04:26 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20874|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 20875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20875&action=edit [PASSED QA] Bug 9924: (follow-up) ensure that correct error message is displayed (Apparently) unlike HTML::Template::Pro, Template Toolkit doesn't like template variables that are entirely numeric -- in conditionals, it consider them integers, most of which are Perl true. This patch changes this by setting the error variable to the error value. To test: [1] Run the test plan from the previous patch. In each case, verify that the error message is specifically applicable to the test. For example, if you try uplaoading a patron image that is larger than 500KB, the error message displayed should specifically say so. Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Thank you Galen for catching this. Error messages showing up now are much more specific and according to the error codes given. I testd uploading a file larger then 500KB and triggered several error messages giving the error code in the URL: /cgi-bin/koha/patroncards/manage.pl?card_element=profile&error=201 All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:12:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:12:19 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 --- Comment #8 from mathieu saby --- Hey, you are becoming an UNIMARC expert Bernardo ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:15:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:15:37 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 --- Comment #8 from Katrin Fischer --- Working on this again now - Bernardo, could you file a new bug for the error messages? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:15:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:15:47 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at biblibre.co |katrin.fischer at bsz-bw.de |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:30:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:30:07 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:30:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:30:13 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17261|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer --- Created attachment 20876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20876&action=edit [SIGNED OFF] Bug 7421 Add UNIMARC DOM Filter I took as a base the patch of F. Demians, but made a lot of changes, so I think it is more logical to create a new patch as the behavior is not the same as previous patch. I tried to define DOM config files as a "miror" of record.abs, so the behavior be the same. If it is OK, we will be able to improve indexing later, for example suppressing warns, managing indicators or subdivisions, etc. I made some little changes to record.abs : - comments - 216 was indexed in Conference-name as well as Trademark. I supposes "Conference-name" is an error, so I indexed only in Trademark - index 2 new notes : 340 / 356 The only difference between record.abs and DOM is that DOM config files does not index complete fields, but subfields. Ex : melm 200 ===> I took all the subfields from the UNIMARC Authorities manual. The only subfields not indexed are numeric subfields : $7, $8 for language of record, and $0,2,3,5,6 for 4XX/5XX/7XX To test : - index a set of bib and auth records with GRS-1 - make some searches on different kind of authorities - index the same records with DOM - make the same searches - You are not supposed to see differences Signed-off-by: Katrin Fischer As I am not a UNIMARC user it's hard for me to test this, but while testing other authority related patches I noticed that I couldn't index the UNIMARC authorities of the sample base. The files are obviously missing and reindex_zebra.pl notes this. With this patch applied, indexing works and authorities are searchable in my installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:32:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:32:09 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|koha.sekjal at gmail.com |jonathan.druart at biblibre.co | |m --- Comment #28 from Katrin Fischer --- I have gone ahead and signed off on this, as with this patch applied I was able to get authority searching working with DOM indexing on my test installation and it seems to work well. As I am by no means a UNIMARC expert this is a bit of a weak sign off - Jonathan, could you take a closer look in QA and/or request another sign off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:40:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:40:07 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:40:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:40:11 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20676|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 20877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20877&action=edit [PASSED QA] Bug 10331 - Little errors in unimarc_field_4XX.pl (punctuation) Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, no koha-qa errors Signed-off-by: Katrin Fischer Copying the test plan from the bug report: A. 1) have $a active in one of the linking fields (like 461, 463, etc.). 2) have a biblio record with the field 700 $a, $b, $f filled up 3) go to cataloguing -> field 4XX of your choice, use the plugin to fetch data from biblio rec. mentioned in 2) 4) see the punctuation in $a -- it will be wrong (no closing bracket) B. 1) have $a active in one of the linking fields (like 461, 463, etc.). 2) have a biblio record with the field 700 $a, $b, $c, $f filled up 3) go to cataloguing -> field 4XX of your choice, use the plugin to fetch data from biblio rec. mentioned in 2) 4) see the punctuation in $a -- it will be wrong (dash instead of semicolon between original $c and $f, no closing bracket) C. 1) have $a active in one of the linking fields (like 461, 463, etc.). 2) have a biblio record with the field 702 $a, $b, $c filled up 3) go to cataloguing -> field 4XX of your choice, use the plugin to fetch data from biblio rec. mentioned in 2) 4) see the punctuation in $a -- it will be wrong (unnecessary semicolon after original $c, n.b. lacking space). D. 1) have $a active in one of the linking fields (like 461, 463, etc.). 2) have a biblio record with the field 712 $a, $b filled up 3) go to cataloguing -> field 4XX of your choice, use the plugin to fetch data from biblio rec. mentioned in b) 4) see the punctuation in $a -- it will be wrong (unnecessary opening bracket at the end). Test plan, all tests and QA script pass. Thx Bernardo for his testing and explanations! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:40:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:40:55 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, | |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:42:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:42:27 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 --- Comment #10 from Katrin Fischer --- I have worked on this by using the provided test plan. I am dding some UNIMARC users in CC - Jonathan, Mathieu, please add your comment, if you think this needs more testing. The punctuation looked nice and sane to me - but who knows :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 10:46:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 08:46:31 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I agree, logging it twice will not provide correct statistics. I think logging it as a renewal would be correct, after giving it some thought. What we do in UI is another checkout, but the loan period gets calculated as renewal and the renewal counter is increased - so it's a renwal, not a new check out. What do others think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 11:07:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 09:07:06 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 --- Comment #11 from mathieu saby --- We don't really use cataloguing modyule in Rennes 2 (all records imported from Academic libraries catalog), so I won't test. But I am sure your tests are fine. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 11:10:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 09:10:04 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 --- Comment #29 from mathieu saby --- A french librarian wanted to do some tests on "unimarc patches" next week, but I don't know if he had planned to look at this one. I will ask him. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 11:11:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 09:11:04 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 --- Comment #30 from mathieu saby --- And a great thank you for testing and signing off! I hope french libraries will be able to use DOM in 3.14... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 11:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 09:14:09 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 11:24:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 09:24:20 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 --- Comment #5 from Katrin Fischer --- Hi Colin, working on this now - thank you for providing the test script! It's a great help in figuring this out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 12:28:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 10:28:35 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 12:28:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 10:28:38 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20838|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 20878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20878&action=edit [PASSED QA] Bug 10817 Return hold items info in Sip Patron Info Resp When requested by the summary flags the sipserver should return in the patron info response barcodes of the relevant titles. For available holds this is the barcode of the captured items. For unavailable holds ( i.e. icurrent unsatisfied holds ) We need to send a barcode so that the unit can use this to request the title info. The barcode could be any one belonging to the title. This patch also corrects the erroneous return of empty items in the patron information response. If the unir supplies a range 1 - 100 unless the title has a hundred or more copies the unit expects all copies. The server was erroneously stuffing the returned arrays with null copies so that all summary requests returned 100 copies (mainly without barcodes) Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Testing notes: Using the test script provided on the bug report, but changed it to match sip user and patron existing in my database. Before applying the patch the SIP responses show the behaviour pointed out above regarding the 100 items. After applying the patch and restarting the SIP server responses are much more clean not returning empty IDs. 64 Patron information response AS = hold items hold items count is correct. AS contains barcodes of waiting holds. Before patch, all AS were empty. AT = overdue items overdue items count is correct. AT contains barcodes of overdue items. AU = charged items charged items count is correct. AU contains barcodes of charged items. AV = fine items Judging from behaviour seen and comment in Patrons.pm currently not implemented. BU = recall items Recalls are not implemented in Koha yet. CD = unavailable hold items unavailable items count is correct. CD contains barcode for item level holds and is empty for title level holds where no item can be determined. Before patch, all CD were empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 12:58:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 10:58:28 +0000 Subject: [Koha-bugs] [Bug 9342] zebra UNIMARC dom indexing does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9342 --- Comment #3 from mathieu saby --- To test again when bug 7421 and bug 8252 are pushed. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:11:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:11:30 +0000 Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:11:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:11:59 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|mtj at kohaaloha.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:17:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:17:03 +0000 Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 --- Comment #5 from Katrin Fischer --- Hi Kyle, I am working on testing the SIP2 patches - it would speed things up quite a bit if you could provide me with a test script or some example SIP messages for placing holds. For an example of a test script see bug 10817. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:19:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:19:14 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #8 from mathieu saby --- (In reply to Katrin Fischer from comment #7) > Some of the information proposed by Mathieu is or might be a bit critical - > so it would be nice to have a system preference to determine which fields > are going to be saved into the statistics table. I agreee Maybe we could add the > patron category as a first step. OK for the categorycode in a 1st step. I think the library of the patron could be recorded too. It is not critical. Do you think we need to store more information about items & biblios too ? Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:22:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:22:52 +0000 Subject: [Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:23:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:23:19 +0000 Subject: [Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 --- Comment #1 from mathieu saby --- It would be an important improvement M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:23:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:23:45 +0000 Subject: [Koha-bugs] [Bug 10747] PDF template for order printing should be selectable per order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10747 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:24:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:24:01 +0000 Subject: [Koha-bugs] [Bug 7267] Display accountnumber in PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7267 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:24:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:24:12 +0000 Subject: [Koha-bugs] [Bug 7942] Allow modification of basket group pdf template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7942 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:27:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:27:11 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #9 from Katrin Fischer --- I think items and biblio information is stord in the deleted* tables and can be looked up from there - data privacy not a problem here, so the data doesn't need to be deleted regularly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:34:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:34:43 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #43 from Martin Renvoize --- Oops, I hadn't spotted that this was already in, even though my patch applies on top of it.. what a Muppet! Anywho, I'm glad the original patch is in and makes the ldap code leaner, although I'm still confused as to how it fixes the original bug reported? (It doesn't in my configuration else I wouldn't have got confused and created the patch in the first place ;) ) I'll open a new bug and move my patch over to it. Sounds fine to me to have this bug completely closed to knock it on the head. Apologies for the confusion. Martin (In reply to Chris Cormack from comment #42) > (In reply to Martin Renvoize from comment #40) > > Created attachment 20821 [details] [review] [review] > > Bug 7973: Fixed bug in Auth_with_ldap - Counter patch > > > > I came across this issue at one of our sites today and patched it before > > finding the bugzilla entry. > > > > The patch already here seems to overcomplicate the issue somewhat unless I'm > > completely missing something. > > > > Attached is my counter patch proposal. > > The patches here have already been pushed Martin. I am obsoleting them. > > So your patch is not so much a counter patch as a new one, and should be on > its own bug, this bug should not have been reopened once the patches were > pushed, a new bug should have been lodged. > > That is of course not your fault, but it still is probably best you put the > patch on a new bug, and we close this again. > > Sound ok? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:47:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:47:12 +0000 Subject: [Koha-bugs] [Bug 10842] New: Allow for new type of LDAP authentication - Further Enhancement Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10842 Bug ID: 10842 Summary: Allow for new type of LDAP authentication - Further Enhancement Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org This is related to Bug 7379 where Elliott Davis describes a new authentication method as follows: For some ldap setups there is a different sequence for authentication that koha doesn't account for. The steps are: 1) Bind with a service account 2) Search for user entered 3) Bind as user if found The final patch that went in allowed for a method as follows: 1) Bind with an Anonymous user 2) Search for user entered 3) Bind as user if found. This is close to what Elliott described but not exact. My patch enclosed adds the original method into the accepted and pushed patch such that the initial bind can take place upon a specified service user OR and an anonymous user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:52:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:52:59 +0000 Subject: [Koha-bugs] [Bug 10842] Allow for new type of LDAP authentication - Further Enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10842 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Created attachment 20879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20879&action=edit Allow auth_by_bind with search by service account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:53:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:53:05 +0000 Subject: [Koha-bugs] [Bug 10842] Allow for new type of LDAP authentication - Further Enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10842 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:54:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:54:52 +0000 Subject: [Koha-bugs] [Bug 10842] Allow for new type of LDAP authentication - Further Enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10842 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7973 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:54:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:54:52 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10842 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 13:57:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 11:57:26 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #44 from Martin Renvoize --- Followup patch moved to new bug and this bug re-closed to prevent future confusion (all as requested/prompted by Chris C) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 14:04:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 12:04:16 +0000 Subject: [Koha-bugs] [Bug 10842] Allow for new type of LDAP authentication - Further Enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Thx Martin! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 14:12:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 12:12:07 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer --- Hi Kyle, I am testing this by modifying Colin's test script and I think I found a problem. If I understand the 3M specification correctly the checkout should be processed if 'no block' is set to Y, but that doesn't happen - I still get the 'Patron Blocked' message. Could you take a look? Request:11YY20130908 141050 203000 AOMPL|AAadmin|ABsomething|ACadmin|ADadminAY4AZE6FC Response:120NUN20130908 141050AOMPL|AAadmin|ABsomething|AJDas Sch?ne Konstanz am Bodensee und Rhein, die alte Stadt im deutschen S?den :|AH|AFPatron Blocked|BLY|AY4AZC9CA[0d][0a] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 15:03:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 13:03:21 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #4 from mathieu saby --- I think we also need a way to pass to the basket template the information about the "deletion status" of each record, in order to suppress the HTML link pointing to the biblio for each order (if the biblio is deleted, the title should be display in plain text without link). The ideal would be that the "deletion status" of each record should be included in the results of GetOrders, for each order. Currently there is a "ON DELETE SET NULL" constraint on biblio.biblionumber on table aqorders : CONSTRAINT `aqorders_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE SET NULL ON UPDATE CASCADE I suppose one solution could be alter this constraint to suppress the "ON DELETE SET NULL", so that the biblionumber is kept in aqorders table, even if the biblio is deleted. But maybe it would be better to keep this column unchanged, and to create a new one, "aqorders.deletedbiblionumber", to be filled when a record is suppressed. The advantage would be to be able to know direclty if an order is linked to an existing record or to a deleted record. In fact I wonder why we have deleted(biblio/biblioitems/items) tables. Would not have been simplier to keep suppressed items and records in the main table, and to add a colum "deleted" in those tables? So the subs about Orders, reserves, circulation... won't have to use union between deleted* and main tables. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 15:11:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 13:11:40 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 15:12:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 13:12:31 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #10 from mathieu saby --- The bug was assigned to Kyle, but he is not in the contacts. I add him. Kyle, do you still want to work on this? Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 17:04:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 15:04:54 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #31 from Katrin Fischer --- Not sure if this is a non-issue - but I think worth a question :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 17:12:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 15:12:02 +0000 Subject: [Koha-bugs] [Bug 7933] Fields in marc display not the same In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7933 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18913|0 |1 is obsolete| | --- Comment #23 from Bernardo Gonzalez Kriegel --- Created attachment 20880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20880&action=edit [SIGNED-OFF] Bug 7933: Fields in marc display not the same Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors Solved minor conflict on applying patch. Test: Edited framework and set a tag to hidden for OPAC Correct behavior on both MARC views, exported record and cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 17:12:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 15:12:13 +0000 Subject: [Koha-bugs] [Bug 7933] Fields in marc display not the same In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7933 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18914|0 |1 is obsolete| | --- Comment #24 from Bernardo Gonzalez Kriegel --- Created attachment 20881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20881&action=edit [SIGNED-OFF] Bug 7933: Unit test for C4::Biblio::RemoveHiddenSubfields Signed-off-by: Bernardo Gonzalez Kriegel Run without errors. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 17:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 15:12:41 +0000 Subject: [Koha-bugs] [Bug 7933] Fields in marc display not the same In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7933 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 18:12:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 16:12:33 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |brendan at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 18:44:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 16:44:34 +0000 Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20753|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20882&action=edit [PASSED QA] Bug 10564 - use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl When using UNIMARC XSLT for OPAC detail page, if record has a 856$u its content is displayed as a link. The syspref OPACURLOpenInNewWindow adds the option of opening in a new window (attribute target="_blank"). 856$u is also used in UNIMARC results XSLT but the use of OPACURLOpenInNewWindow syspref is missing. It exists for MARC21. This patch adds the use of OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl. Test plan : - In a UNIMARC catalog, enable XSLT for OPAC results page - Create a record with a link in 856$u and set second indicator to 0 - Set OPACURLOpenInNewWindow syspref on - At OPAC, perform a search that contains the record => You should see the link : "Click here to access online" - click on it => You shoud get to a new window (or tab depending on your browser configuration) - Set OPACURLOpenInNewWindow syspref off - re-perform the search - click on the link => You shoud stay in same window Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, no koha-qa errors Tested following plan after applying patch Signed-off-by: Katrin Fischer XSLT change only, works as described. To test: Catalog 856$u and $a, 2nd indicator = 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 18:44:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 16:44:31 +0000 Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 19:20:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 17:20:00 +0000 Subject: [Koha-bugs] [Bug 10647] OPAC MARC plain view only working for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 19:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 17:22:53 +0000 Subject: [Koha-bugs] [Bug 9740] using XSLT modifies record authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 20:01:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 18:01:15 +0000 Subject: [Koha-bugs] [Bug 10465] Reference to fields 780 and 785 in UNIMARC XSLT should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 20:01:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 18:01:38 +0000 Subject: [Koha-bugs] [Bug 10465] Reference to fields 780 and 785 in UNIMARC XSLT should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|oleonard at myacpl.org |mathieu.saby at univ-rennes2.f | |r Severity|minor |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 20:02:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 18:02:20 +0000 Subject: [Koha-bugs] [Bug 10465] Reference to fields 780 and 785 in UNIMARC XSLT should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 --- Comment #1 from mathieu saby --- Created attachment 20883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20883&action=edit Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files UNIMARCslim2OPACDetail.xsl and UNIMARCslim2intranetDetail.xsl contains references to 780 and 785 fields, that exist in Marc21 but not in UNIMARC. This patch remove the code related to 780 and 785 fields. No effect should be visible. To test : in a UNIMARC Koha 1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay , XSLTDetailsDisplay and XSLTResultsDisplay sysprefs are set to "default" 2. apply the patch 3. search some records in staff interface : the list view and the detail view must be exacty the same as before you apply the patch. 4. search some records in OPAC : the list view and the detail view must be exacty the same as before you apply the patch. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 20:02:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 18:02:28 +0000 Subject: [Koha-bugs] [Bug 10465] Reference to fields 780 and 785 in UNIMARC XSLT should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 21:20:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 19:20:26 +0000 Subject: [Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 21:23:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 19:23:14 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Janusz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 21:26:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 19:26:54 +0000 Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 21:49:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 19:49:13 +0000 Subject: [Koha-bugs] [Bug 10667] ILS-DI: AuthenticatePatron should also work with cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 21:49:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 19:49:16 +0000 Subject: [Koha-bugs] [Bug 10667] ILS-DI: AuthenticatePatron should also work with cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 --- Comment #1 from Katrin Fischer --- Created attachment 20884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20884&action=edit Bug 10667: Add unit tests for ILSDI::Services::AuthenticatePatron This patch adds unit tests for Authenticate patron. To test: - Run perl t/db_dependent/ILSDI_Services.t - Verify all tests pass Note: there are some tests marked as TODO. Rewriting AuthenticatePatron to make cardnumber and userid work for authenticating a patron will be implemented in the next patch. Tests related to this are currently showing as 'not ok', but are still passing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 21:49:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 19:49:26 +0000 Subject: [Koha-bugs] [Bug 10667] ILS-DI: AuthenticatePatron should also work with cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 --- Comment #2 from Katrin Fischer --- Created attachment 20885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20885&action=edit Bug 10667: Allow authentication with cardnumber for ILS-DI Test authentication via ILS-DI: - with userid and password - with userid and wrong password - with cardnumber and password - with cardnumber and wrong password ... Before the patch only userid will authenticate the patron. After the patch was applied, userid and cardnumber will work. To test: - Run t/db_dependent/ILSDI_Services.t - all tests should pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 21:54:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 19:54:36 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:09:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:09:23 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- I'm going to have to fail this one. Some of the individual patches before the squash could have been accepted as is (for example, the one fixing the permissions), but the end result completely breaks the report output when the group option is enabled. I'll post screenshots momentarily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:13:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:13:42 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 --- Comment #12 from Galen Charlton --- Created attachment 20886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20886&action=edit screenshot of output grouping by library before patch Note that each group has a list of its items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:14:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:14:11 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 --- Comment #13 from Galen Charlton --- Created attachment 20887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20887&action=edit screenshot of output grouping by library afterpatch Note that only the first group has its items listed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:28:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:28:55 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #14 from Galen Charlton --- I apologize -- what I'm seeing is breakage of the report when grouping by item type that existed /before/ the patch. In my second screenshot, there is only one item of item type CR in the database, which *had* circulated. Consequently, I think it shouldn't be listed in the report at all, or at the very least, the third column should be more clearly labelled that it's counting /all/ items of that type, regardless of whether they have circulated or not. Consequently, I have pushed the patch to master, but echo Katrin's comment that more work is needed. Thanks, Fridolyn! Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:29:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:29:00 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:29:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:29:01 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #69 from Katrin Fischer --- Jonathan, there are a couple of conflicts, could you please rebase? I will try to come back to this as quick as possible as soon as the patches apply again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:31:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:31:18 +0000 Subject: [Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #8 from Katrin Fischer --- I am not sure how to proceed with this as I think it currently can't be tested. I am moving it to 'BLOCKED' for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:34:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:34:09 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:34:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:34:34 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply QA Contact| |katrin.fischer at bsz-bw.de --- Comment #63 from Katrin Fischer --- Jonathan, I am sorry, but this doesn't apply. There are conflicts in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt that I think would be better if you take a look at. I am adding myself as QA contact - so I can come back to this asap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:38:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:38:02 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 22:50:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 20:50:37 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Kyle, could you please add a regression test for this in a follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 23:16:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 21:16:46 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Hm, I see a problem here. As staff member you can overwrite hold limitations and it might make sense to put a hold on a damaged item to make sure it gets set aside when being returned for repair. But with your patch, the item level hold I set on the damaged item is not triggered on return. As there is only one item level hold on this record now, the hold will never trigger. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 23:29:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 21:29:42 +0000 Subject: [Koha-bugs] [Bug 10667] ILS-DI: AuthenticatePatron should also work with cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20884|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 20888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20888&action=edit [SIGNED-OFF] Bug 10667: Add unit tests for ILSDI::Services::AuthenticatePatron This patch adds unit tests for Authenticate patron. To test: - Run perl t/db_dependent/ILSDI_Services.t - Verify all tests pass Note: there are some tests marked as TODO. Rewriting AuthenticatePatron to make cardnumber and userid work for authenticating a patron will be implemented in the next patch. Tests related to this are currently showing as 'not ok', but are still passing. Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors With both patches applied, all test pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 23:29:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 21:29:52 +0000 Subject: [Koha-bugs] [Bug 10667] ILS-DI: AuthenticatePatron should also work with cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20885|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 20889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20889&action=edit [SIGNED-OFF] Bug 10667: Allow authentication with cardnumber for ILS-DI Test authentication via ILS-DI: - with userid and password - with userid and wrong password - with cardnumber and password - with cardnumber and wrong password ... Before the patch only userid will authenticate the patron. After the patch was applied, userid and cardnumber will work. To test: - Run t/db_dependent/ILSDI_Services.t - all tests should pass. Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors Test: Enable ISL-DI access opac with /cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=XXX&password=YYY With userid/cardnumber & password returns borrowernumber With userid/cardnumber & wrong password returns PatronNotFound -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 23:30:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 21:30:33 +0000 Subject: [Koha-bugs] [Bug 10667] ILS-DI: AuthenticatePatron should also work with cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 23:42:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 21:42:40 +0000 Subject: [Koha-bugs] [Bug 10424] Search against order numbers and pull up the related invoice to see when the item was receipted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Hi Amit, there are a couple of small things: It was decided a while ago that Koha will be distributed under GPL3+ - we have upated the coding guidelines with the appropriate license text: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Could you confirm this is ok for you and if so change receivedorders.pl accordingly? Also, could you please add some unit tests for your new routines? GetReceivedorder (maybe ReceivedOrder?) You can add a follow up and switch the status back to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 23:51:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 21:51:33 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 23:51:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 21:51:36 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20261|0 |1 is obsolete| | Attachment #20262|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 20890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20890&action=edit [PASSED QA] Bug 10678 - Allow framework selection when creating from Z39.50 If we are creating a new record, we are forced to use the default framework and then change it after we have the cataloguing form filled. This patch adds the option to choose (from a splitted button dropdown) which framework to use. To test: - Apply the patch. - Go to More > Cataloguing - Check there's a nice split button that says "New from Z39.50" a) Click the button, the usual Z39.50 search popup should appear and work as expected (check the URL parameters and see frameworkcode= has no value b) Click on the dropdown arrow, choose a framework and the usual Z39.50 search popup should appear, this time frameworkcode= should have the chosen value. Regards To+ Edit: fixed a small bug that prevented the default framework to be called. Thanks Owen for testing. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Melia Meggs Signed-off-by: Katrin Fischer Notes on second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 8 23:51:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 21:51:44 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 --- Comment #10 from Katrin Fischer --- Created attachment 20891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20891&action=edit [PASSED QA] Bug 10678 - Update addbooks help page The button's name changed, and a caret was added. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Melia Meggs Signed-off-by: Katrin Fischer Passes all tests and QA script. If you click the button directly, the default framework is still used. If you use the split button functionality to select another framework, this framework will be used for the imported record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 00:33:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 22:33:50 +0000 Subject: [Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 01:07:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 23:07:29 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #23 from Katrin Fischer --- Hi David, some very first observations from reading the code and the QA script: The license on cataloguing/z3950_auth_search.pl is GPL2+ - maybe you could consider making it GPL3+? There are some .pl files with SQL statements in them - I think it would be nicer to move them out to an existing or new module. I know that most of it probably is kind of a preexisting problem stemming from how we handle bibliographic records. For the changes in Breeding.pm some unit tests should be provided. In your updatedatabase statement could you specify after which column the new column should be added (little pet peeve of mine I guess :) )? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 01:08:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Sep 2013 23:08:40 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #24 from Katrin Fischer --- Oh, in Breeding.pm there are some left over TODOs and FIXMEs - maybe take a look at those again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 02:44:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 00:44:57 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20824|0 |1 is obsolete| | --- Comment #14 from M. Tompsett --- Created attachment 20892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20892&action=edit Bug 10584 - Hide OPAC biblio details if all items are hidden If there are items for a given biblio number, and they are all hidden, then biblio needs to be hidden. If the biblio needs to be hidden, it immediately redirects to a 404.pl page, just as if the biblionumber does not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 02:48:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 00:48:21 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #15 from M. Tompsett --- I believe I addressed Galen's issues. Though, perhaps the "keep the comment entact" philosophy may be flawed. I'll rework if that is a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 03:23:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 01:23:04 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 --- Comment #16 from Srdjan Jankovic --- I don't mean to be a pain, but array copy seems unnecessary. Why not just @all_items = GetItemsInfo( $biblionumber ); if (scalar @hiddenitems == scalar @all_items ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 05:47:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 03:47:57 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20892|0 |1 is obsolete| | --- Comment #17 from M. Tompsett --- Created attachment 20893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20893&action=edit Bug 10584 - Hide OPAC biblio details if all items are hidden If there are items for a given biblio number, and they are all hidden, then biblio needs to be hidden. If the biblio needs to be hidden, it immediately redirects to a 404.pl page, just as if the biblionumber does not exist. Arrays used to represent all the items were relocated and used, added if they didn't exist. Arrays representing the hidden items were relocated and used if they existed, added if they didn't exist. Upon debugging the opac-MARCdetail.pl modification, it was discovered the reason getHiddenItems was failing was because 'use YAML qw/Load/;' was not mentioned in C4::Items, and other libraries were triggering the loading of YAML to compensate for opac-detail.pl and opac-ISBDdetail.pl files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 06:11:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 04:11:31 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 08:21:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 06:21:03 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Wow - this is huge! I am a bit worried about the test plan, although I see that Liz has gone beyond it already. I think it's not only the calendar interface we need to check here, but also due date calculation, overdue fine calculation (on checkin, using the cronjobs, etc.) I think getting some more eyes on this would be good. And also some documentation about the new feature and how it will impact circulation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 08:34:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 06:34:06 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 09:46:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 07:46:47 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #15 from Jonathan Druart --- Added to qa tools: commit c90d0c5e5436daec23d2c6e21e5759e8344ad1f5 Author: Jonathan Druart AuthorDate: Mon Sep 9 09:45:10 2013 +0200 wthdrawn is a typo (see bug 10550). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:02:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:02:05 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19317|0 |1 is obsolete| | --- Comment #70 from Jonathan Druart --- Created attachment 20894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20894&action=edit Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - fund New field aqorders.orderstatus, it can contains following values: 0 => New 1 => Ordered 2 => Partial 3 => Complete 4 => Deleted To test: Search and check if results are consistent in histsearch.pl Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:02:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:02:12 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19318|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart --- Created attachment 20895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20895&action=edit Bug 5336: Late orders search: don't display deleted order. Test plan: Check that deleted orders are not listed in the late orders search results. Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:02:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:02:17 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19319|0 |1 is obsolete| | --- Comment #72 from Jonathan Druart --- Created attachment 20896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20896&action=edit Bug 5336: Merge parent ordernumber and ordernumber columns Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:02:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:02:23 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19320|0 |1 is obsolete| | --- Comment #73 from Jonathan Druart --- Created attachment 20897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20897&action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:02:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:02:29 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19321|0 |1 is obsolete| | --- Comment #74 from Jonathan Druart --- Created attachment 20898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20898&action=edit Bug 5336: QA followup - fix capitalization - fix update database message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:02:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:02:34 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19550|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart --- Created attachment 20899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20899&action=edit Bug 5336: Change numbers with understandable codes for orderstatus This patch uses understandable codes instead of magical numbers for the aqorders.orderstatus field. + execute sql queries in unit tests into a transaction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:03:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:03:12 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #76 from Jonathan Druart --- Rebased patches! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:06:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:06:43 +0000 Subject: [Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #8) > I am not sure how to proceed with this as I think it currently can't be > tested. I am moving it to 'BLOCKED' for now. I know bug 7167 is not a priority for Galen but this path can be tested. Especially because it is a small and easy patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:16:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:16:59 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19587|0 |1 is obsolete| | --- Comment #64 from Jonathan Druart --- Created attachment 20900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20900&action=edit Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information ("Import All" and "Accounting details" areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the "Stage MARC records for import" tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the "planning values" too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the "Accounting details" area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price => listprice = 0 else => - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:17:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:17:07 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19588|0 |1 is obsolete| | --- Comment #65 from Jonathan Druart --- Created attachment 20901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20901&action=edit Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:17:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:17:12 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19589|0 |1 is obsolete| | --- Comment #66 from Jonathan Druart --- Created attachment 20902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20902&action=edit Bug 7180: Add UT for C4::Budgets::GetBudgetByCode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:17:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:17:17 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19590|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart --- Created attachment 20903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20903&action=edit Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:17:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:17:23 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19641|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart --- Created attachment 20904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20904&action=edit Bug 7180: The default quantity is 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:17:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:17:53 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #69 from Jonathan Druart --- Rebased patches! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:19:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:19:33 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #16 from Katrin Fischer --- Thx Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:29:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:29:20 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:29:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:29:23 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 --- Comment #6 from Jonathan Druart --- Created attachment 20905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20905&action=edit Bug 10600: Change the icon for the action duplicate Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:35:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:35:29 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > Do we have a reference about CURRENT_DATE being a mysqlism? > I found it here: http://www.contrib.andrew.cmu.edu/~shadow/sql/sql1992.txt At least, it does not work with PostgreSQL: postgres=# select CURRENT_DATE(); ERREUR: erreur de syntaxe sur ou pr?s de ? ( ? LIGNE 1 : select CURRENT_DATE(); ^ postgres=# select current_date; date ------------ 2013-09-09 > Also bit worried about changing all those statements without tests. I don't have the time to provide unit tests for all modified routines. But MariaDB [koha_devstetienne]> select CURRENT_DATE(); +----------------+ | CURRENT_DATE() | +----------------+ | 2013-09-09 | +----------------+ 1 row in set (0.00 sec) MariaDB [koha_devstetienne]> SELECT CAST(now() AS date); +---------------------+ | CAST(now() AS date) | +---------------------+ | 2013-09-09 | +---------------------+ 1 row in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:41:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:41:26 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:45:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:45:21 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #17 from Katrin Fischer --- Weird, it's in the Postgres documentation too? http://www.postgresql.org/docs/8.1/static/functions-datetime.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:51:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:51:51 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #18 from Jonathan Druart --- (In reply to Katrin Fischer from comment #17) > Weird, it's in the Postgres documentation too? > http://www.postgresql.org/docs/8.1/static/functions-datetime.html Yes select current_date; -- works select current_date(); -- does not work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 10:53:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 08:53:07 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 13:27:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 11:27:01 +0000 Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 13:27:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 11:27:05 +0000 Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 --- Comment #8 from Jonathan Druart --- Created attachment 20906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20906&action=edit Bug 10380: Followup Change prototype for output_pref routine Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 13:58:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 11:58:09 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 13:58:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 11:58:12 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20705|0 |1 is obsolete| | Attachment #20706|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 20907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20907&action=edit Bug 10731 - IntranetSlipPrinterJS is not working for hold slips Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 13:58:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 11:58:18 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #9 from Jonathan Druart --- Created attachment 20908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20908&action=edit Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [v3.10/v3.12] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard Tested successfully in 3.10.x and 3.12.x Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 14:10:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 12:10:22 +0000 Subject: [Koha-bugs] [Bug 10843] New: print a slip can cause an error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 Bug ID: 10843 Summary: print a slip can cause an error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Testing bug 10731, I found a bug: If the pref ReservesMaxPickUpDelay is not defined, C4::Letters::_parseletter raises an error in some cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 14:10:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 12:10:31 +0000 Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 14:22:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 12:22:15 +0000 Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 --- Comment #1 from Jonathan Druart --- Created attachment 20909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20909&action=edit Bug 10843: the DateTime->add method takes a scalar, not undef Test plan: 1) set an empty string for the ReservesMaxPickUpDelay pref 2) place a hold on an item 3) check in the item 4) click on "Print and confirm" 5) an error occurs > The 'days' parameter (undef) to DateTime::Duration::new was an 'undef' 6) apply the patch 7) repeat steps 1 to 4 8) the error does not occur anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 14:22:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 12:22:32 +0000 Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 14:41:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 12:41:44 +0000 Subject: [Koha-bugs] [Bug 10844] New: circs by dewey range Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10844 Bug ID: 10844 Summary: circs by dewey range Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 20910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20910&action=edit dewey report It would be nice if there were a canned report for circ by dewey ranges broken out by tens. See attached example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 14:54:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 12:54:56 +0000 Subject: [Koha-bugs] [Bug 10844] circs by dewey range In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10844 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think maybe this could be a plugin or a SQL report? Or maybe a report that is a bit more flexible to adapt to other classification schemes as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:04:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:04:35 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Nora Blake changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nblake at masslibsystem.org --- Comment #32 from Nora Blake --- I am extremely happy with this and would like to sign off on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:05:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:05:01 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nora Blake changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nblake at masslibsystem.org --- Comment #6 from Nora Blake --- I am extremely happy with this and would like to sign off on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:14:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:14:48 +0000 Subject: [Koha-bugs] [Bug 10841] Edit/Delete item context links in items table are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:14:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:14:50 +0000 Subject: [Koha-bugs] [Bug 10841] Edit/Delete item context links in items table are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20868|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20911&action=edit [SIGNED-OFF] Bug 10841: Make edit/delete item context links in cataloguing translatable HTML created with Javascript is not translatable the way HTML is normally translated. _() syntax has to be used to have strings translatable. To test: - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly - Apply patch - Verify the links still show the same behaviour Bonus: - Run 'perl translate update ' in misc/translator - Verify that Edit item and Delete item show up in the po file, translate them - Install updated po files running 'perl translate install ' - Verify links show up translated and work correctly Patch also fixes capitalization for a couple of error messages - only change there is: Deleted > deleted. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:15:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:15:11 +0000 Subject: [Koha-bugs] [Bug 8833] items with no checkouts has no results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8833 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Sophie MEYNIEUX --- *** This bug has been marked as a duplicate of bug 10718 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:15:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:15:11 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #15 from Sophie MEYNIEUX --- *** Bug 8833 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:16:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:16:01 +0000 Subject: [Koha-bugs] [Bug 10838] Silence warnings in members/member.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10838 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |chris at bigballofwax.co.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:20:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:20:52 +0000 Subject: [Koha-bugs] [Bug 10838] Silence warnings in members/member.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10838 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:20:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:20:55 +0000 Subject: [Koha-bugs] [Bug 10838] Silence warnings in members/member.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10838 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20841|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20912&action=edit [SIGNED-OFF] Bug 10838 : Silence warns in members/member.pl To test 1/ Uncomment the use warnings line 2/ Search for a patron, notice all the warnings 3/ Browse for a patron, notice warnings 4/ Apply patch 5/ Repeat 3 and 4 6/ Notice no errors and the search still works This depends on the patch for Bug 10835 Signed-off-by: Chris Cormack Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:29:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:29:06 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 --- Comment #5 from M. Tompsett --- Created attachment 20913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20913&action=edit bug clean ubuntu docs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:34:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:34:07 +0000 Subject: [Koha-bugs] [Bug 10650] export merge-record.inc javascript into a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10650 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:34:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:34:10 +0000 Subject: [Koha-bugs] [Bug 10650] export merge-record.inc javascript into a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10650 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19962|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 20914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20914&action=edit [SIGNED-OFF] Bug 10650 - export merge-record.inc javascript into a file Bug 9755 added a refactoring of records merge adding the include merge-record.inc. This include contains a block "mergejs" containing all JavaScript code that was in merge.tt. This patch exports this code into a js file. Translatable strings contained in this file are in merge-record-strings.inc. Test plan : - Put two records is a list - Go to this list and check the two records - Click on "Merge selected" - Click on next - Go to second source record - Click on a repeatable field => The field is added to destination record - Click on a subfield of a field existing in destination record => The subfield is added to destination record - Click on a non repeatable field existing in destination record => You get an alert and field is not added - Click on a subfield of a field not existing in destination record => You get an alert and subfield is not added - Click on Merge => Records are merged Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 15:35:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 13:35:08 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 16:08:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 14:08:38 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 20915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20915&action=edit Bug 9735: Unit tests for get_template_and_user (cookies handling) Galen found a case where the cookies array was not built flat. I add a unit test for that (check the cookie array is flat) and also test the cookies output of get_template_and_user so we are sure the &language= parameter is correctly handled. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 16:30:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 14:30:19 +0000 Subject: [Koha-bugs] [Bug 10842] Allow for new type of LDAP authentication - Further Enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10842 --- Comment #3 from Martin Renvoize --- I Suppose I should probably put in a test plan, now I've got my head around it myself! If you've found this bug, then most likely you've found that your LDAP Server requires the setup as explained in the first post, or your just grabbing at straws? To enable this method you'll need to enable auth_by_bind and also include a user and password in your ldap configuration xml for koha as in the below example. 1 ldap://yourldapserver.com:389 DC=yourldapserver,DC=com CN=kohabindaccount gobbledegoop 0 0 1 -->
--> --> TEMP --> --> 2011-07-12 --> 2012-07-12 -->
If it didn't authenticate before, but does now then the patch has fixed your issue ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 16:32:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 14:32:54 +0000 Subject: [Koha-bugs] [Bug 9197] opacnav shows below tabs on opac-user.pl in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9197 --- Comment #4 from Nicole C. Engard --- This is still an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 16:51:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 14:51:32 +0000 Subject: [Koha-bugs] [Bug 10845] New: Multi transport types for holds Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Bug ID: 10845 Summary: Multi transport types for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 9016 adds a UI for creating a message for each transport types for a letter. The patron messaging preferences allow to select one or more transport types to notify when an item is available for pick-up. In order to be consistent, this should be use the notice defined. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 16:51:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 14:51:46 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |9016 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 16:51:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 14:51:46 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10845 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 16:53:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 14:53:34 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #7 from Jonathan Druart --- Created attachment 20916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20916&action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:12:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:12:12 +0000 Subject: [Koha-bugs] [Bug 10846] New: Add preference for naming OverDrive collection Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10846 Bug ID: 10846 Summary: Add preference for naming OverDrive collection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org It would be nice for libraries to be able to name their OverDrive collections, since "OverDrive" may not be the identifying term they use for that collection. In our case our contract with OverDrive is through a consortium, so our patrons know the collection by the consortium name. Instead of seeing "OverDrive search for 'mystery'" patrons could see "Ohio eBook Project search for 'mystery'." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:15:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:15:50 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #1 from Jonathan Druart --- Created attachment 20917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20917&action=edit Bug 10845: Multi transport types for holds The HOLD_PRINT and HOLD_PHONE notices become useless. This patch will modify existing notices in order to group them into the main notices 'HOLD'. Like that, on one screen, all these notices can be edited. Test plan: - apply the patch and execute the update database entry. - verify that yours previous HOLD_PHONE and HOLD_PRINT are displayed when editing the HOLD notice (under phone and print). - choose a patron and check sms, email, phone for "Hold filled" (on the patron messaging preferences). - place a hold. - check the item in and confirm the hold. - if the patron has an email *and* a sms number, 2 new messages are put into the sql message_queue table: 1 sms and 1 email. if the patron does not have 1 of them, there are 2 new messages: 1 sms/email and 1 print. if the user has neither of them, there is 1 new message: 1 print. - the generated messages should correspond with the notices defined, depending the message transport type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:15:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:15:54 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #2 from Jonathan Druart --- Created attachment 20918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20918&action=edit Bug 10845: Remove the notice code HOLD_PRINT The HOLD_PRINT notice code is the HOLD notice code with a message transport type equal to 'print'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:16:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:16:09 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:18:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:18:40 +0000 Subject: [Koha-bugs] [Bug 10847] New: Open external link to website of a vendor in new tab/window Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10847 Bug ID: 10847 Summary: Open external link to website of a vendor in new tab/window Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The link to the vendor's website is a link external to Koha and should open in a new tab/window depending on browser settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:37:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:37:04 +0000 Subject: [Koha-bugs] [Bug 10848] New: Allow configuration of mandatory/required fields on the suggestion form in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Bug ID: 10848 Summary: Allow configuration of mandatory/required fields on the suggestion form in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Several libraries have been suggesting that ISBN should also be mandatory on the suggestion form in OPAC. As some libraries might disagree but prefer other fields it would be nice to have a configuration option for mandatory/required fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:47:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:47:49 +0000 Subject: [Koha-bugs] [Bug 10841] Edit/Delete item context links in items table are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:47:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:47:52 +0000 Subject: [Koha-bugs] [Bug 10841] Edit/Delete item context links in items table are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20911|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 20919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20919&action=edit Bug 10841: Make edit/delete item context links in cataloguing translatable HTML created with Javascript is not translatable the way HTML is normally translated. _() syntax has to be used to have strings translatable. To test: - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly - Apply patch - Verify the links still show the same behaviour Bonus: - Run 'perl translate update ' in misc/translator - Verify that Edit item and Delete item show up in the po file, translate them - Install updated po files running 'perl translate install ' - Verify links show up translated and work correctly Patch also fixes capitalization for a couple of error messages - only change there is: Deleted > deleted. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:48:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:48:08 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #5 from Katrin Fischer --- Hm, I think the separate tables are there for reasons - I am not sure how to resolve the problem with the deleted biblionumbers. I tend to just keep the number, as we do in other places and add querying of the deleted* table if the information we are looking for is not found in the current table. Maybe we can get some more opinions/ideas on this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:52:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:52:15 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #6 from mathieu saby --- Where is it done elsewhere in code? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:54:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:54:43 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #7 from Katrin Fischer --- I think statistics, action_logs, etc. keep the biblionumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 17:56:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 15:56:32 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #53 from Jonathan Druart --- Main patches already passed qa. only latest patches need a signed off here, especially not to get data when loading the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 18:04:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 16:04:41 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #8 from mathieu saby --- Yes, of course, statistics table keeps the itemnumber. I will take a look. I think stats reports page in staff interface do not JOIN on deleteditems, only on items. I would like C4 subs to return the information "this order is / is not link to a deleted biblio". I am not sure it could be done in 1 SQL request, because if I make a "UNION ALL" between biblio and deletedbiblio, I think the resulting temporary table will just have the same fields as biblio and deletedbiblio, without any information about the deleted status of some biblios. Am I wrong? If not, the solution could be to make 2 or 3 requests (one with "select aqorders left join biblio using biblionumber where biblio.biblionumber is not null", the 2d with "select aqorders left join deletedbiblio using biblionumber where deletedbiblio.biblionumber is not null"). I am not a SQL specialist... So what do you think of it? Maybe we could ask koha-devel? Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 18:05:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 16:05:51 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 18:05:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 16:05:53 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #1 from Owen Leonard --- Created attachment 20920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20920&action=edit Bug 10836 - New layout for placing holds in the OPAC This patch changes the layout of the OPAC's place hold screen, eliminating the table in favor of a more flexible, open display. To test, place single and multiple holds under various conditions: - Items which are not available to be place on hold - With OpacHoldNotes on and off - With OPACItemHolds on and off - With OPACAllowHoldDateInFuture on and off - With IndependentBranches on and off - With JavaScript disabled Test setting hold notes, holding specific copies, and setting hold start dates. When setting a hold start date and hold expiration date, the two datepickers should work together to prevent invalid date combinations (dates after today, expiration dates which precede the start date). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 18:35:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 16:35:27 +0000 Subject: [Koha-bugs] [Bug 10730] Use DataTables on the tag review page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10730 --- Comment #1 from Owen Leonard --- Created attachment 20921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20921&action=edit Bug 10730 - Use DataTables on the tag review page This patch enhances the tags review page in the staff client by adding DataTables sorting to the table of tags. It also converts the tag list page (list.tt) to use the new DataTables include introduced by Bug 10649. To test, apply the patch and view the tags review page for various categories: Pending, approved, rejected, all. The table should be sortable by status, term, weight, and date. Sorting by date should work correctly regardless of date format preference. Title sorting on the tag list page should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 18:35:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 16:35:24 +0000 Subject: [Koha-bugs] [Bug 10730] Use DataTables on the tag review page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10730 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 18:48:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 16:48:15 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 20:19:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 18:19:24 +0000 Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 20:22:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 18:22:46 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20913|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 20922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20922&action=edit bug clean ubuntu docs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 20:42:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 18:42:13 +0000 Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices table doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 20:50:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 18:50:41 +0000 Subject: [Koha-bugs] [Bug 10749] patron permissions typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 20:50:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 18:50:43 +0000 Subject: [Koha-bugs] [Bug 10749] patron permissions typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749 --- Comment #1 from Owen Leonard --- Created attachment 20923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20923&action=edit Bug 10794 - Sorting on billing date column in invoices table doesn't work This patch adds the sorting by title string option to the table of invoices. This allows column data to be sorted based on the ISO-formatted date rather than the formatted-for-display date. A "blank" (0000-00-00) date is added to cells which contain no date data. To test, view the Acquisitions Invoices page (acqui/invoices.pl) and confirm that the "Billing date" column is sorted correctly regardless of the dateformat system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 20:52:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 18:52:32 +0000 Subject: [Koha-bugs] [Bug 10749] patron permissions typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20923|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Comment on attachment 20923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20923 Bug 10794 - Sorting on billing date column in invoices table doesn't work Sorry, attached this patch to the wrong bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 20:54:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 18:54:46 +0000 Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices table doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 20:54:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 18:54:48 +0000 Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices table doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 --- Comment #1 from Owen Leonard --- Created attachment 20924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20924&action=edit Bug 10794 - Sorting on billing date column in invoices table doesn't work This patch adds the sorting by title string option to the table of invoices. This allows column data to be sorted based on the ISO-formatted date rather than the formatted-for-display date. A "blank" (0000-00-00) date is added to cells which contain no date data. To test, view the Acquisitions Invoices page (acqui/invoices.pl) and confirm that the "Billing date" column is sorted correctly regardless of the dateformat system preference. http://bugs.koha-community.org/show_bug.cgi?id=10749 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 20:54:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 18:54:59 +0000 Subject: [Koha-bugs] [Bug 10749] patron permissions typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 20:55:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 18:55:07 +0000 Subject: [Koha-bugs] [Bug 10749] patron permissions typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 21:46:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 19:46:52 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 21:46:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 19:46:56 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20051|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 20925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20925&action=edit [PASSED QA] Bug 10513 - Light up a warning/message when returning a chosen item type This patch adds a new column to item types. Text in this column is displayed as a warning when an item of the given type is checked in. The type of message can also be chosen, affecting how the message is displayed. Use case: Items that are on inter-library loan can have a separate item type, and when items of this type are checked in a message saying something like "ILL! Remember to return it to the owning library!" can be displayed. To test: - Apply the patch - Go to Home > Administration > Item types administration - Check that there is a new column, called "Check in message" - Edit an item type and add a check in message - Check that the check in message you added is displayed in the table - Check in an item with an item type that has a check in message - Check that the message is displayed - Repeat the steps above, but select "Alert" instead of the default "Message" as the "Check in message type". Check that the message is displayed in a yellow alert box, not a blue message box. - Check in an item with an item type that does *not* have a check in message, and make sure no false messages are displayed - Create a new item type from scratch and check that it works the way it is supposed to - Run the tests in t/ItemType.t, which are updated by this patch This patch also removes backticks around column names in the itemtypes table in installer/data/mysql/kohastructure.sql UPDATE 2013-07-22 - Rebased on current master (no changes) - Added "AFTER summary" to the SQL statement in updatedatabase.pl - Added another placeholder on line 170 of admin/itemtypes.pl Thanks Katrin! UPDATE 2013-07-29 - Make this message independent of all other messages - thanks Owen! - Make it possible to choose the type of message ("alert" or "message") Sponsored-by: Kultur i Halland - Regionbibliotek Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Fixed some tabs to make the QA script happy. All old and new tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 21:52:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 19:52:21 +0000 Subject: [Koha-bugs] [Bug 10849] New: z3950servers.pl multiple pages features/filter not working as expected Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10849 Bug ID: 10849 Summary: z3950servers.pl multiple pages features/filter not working as expected Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Using 3.12.3, we have 24 total Z targets set up on our system. On .../cgi-bin/koha/admin/z3950servers.pl, it says "Showing 1 to 20 of 20", instead of Showing 1 to 20 of 24". Page 2 it says "Showing 1 to 4 of 4" instead of "Showing 21-24 of 24". Also, when I try to change the dropdown of "Show 20 entries" to Show All entries or any of the other listed options, nothing happens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 22:34:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 20:34:03 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #70 from Katrin Fischer --- Currently working on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 22:47:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 20:47:56 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #9 from mathieu saby --- In statistics table, there is no constraint on biblionumber at all. I suppose it won't be good for safety reason to merely suppress existing constraint in aqorders, so I edited updatedatabse to suppress the "ON DELETE SET NULL", and keep only "ON UPDATE CASCADE". It is the 1st time I try to do this kind of manipulation... and I did it wrong : when I tried to suppress a biblio record linked to an order, it raised a SQL error. Could you tell me how to write the constraint to link aqorders.biblionumber with biblio.biblionumber, but to keep the value of aqorders.biblionumber when the biblio is suppressed ? Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 22:51:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 20:51:08 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #10 from Katrin Fischer --- Sorry Mathieu, I would have to take a look at the documentation and experiment as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 22:57:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 20:57:29 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #71 from Katrin Fischer --- Created attachment 20926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20926&action=edit Bug 7180: Follow-up fixing minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 23:02:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 21:02:45 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #72 from Katrin Fischer --- Hi Jonathan, I have started with a code review and fixed some minor issues in a follow-up patch. Could you take a look at the patch please and add your sign-off if the changes are ok? 2 concerns so far: 1) I think the use of the new system preference is not clear from the description, can we give an example maybe? I am also not so happy about the blank line requirement. Not sure, but could it be handled similar to opachiddenitems? 2) I started with regression testing: When I add a new order by searching for a record from the catalog (neworderempty.pl) and choose my fund, the statistic values are not updated. There is a Javascript error on the page: ReferenceError: fetchSortDropbox is not defined fetchSortDropbox(this.form) I tried refreshing the page multiple times. Failed for 2). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 23:12:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 21:12:36 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 --- Comment #9 from Katrin Fischer --- Hi Jonathan - should this be passed QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 23:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 21:14:09 +0000 Subject: [Koha-bugs] [Bug 10530] PO number search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | QA Contact|amitddng135 at gmail.com | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 9 23:22:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Sep 2013 21:22:46 +0000 Subject: [Koha-bugs] [Bug 10530] PO number search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10530 --- Comment #3 from Katrin Fischer --- Hi Owen, did you test this in combination with bug 4456? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 02:09:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 00:09:01 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #11 from Srdjan Jankovic --- Kyle, I'm afraid DELETE FROM patronimage WHERE cardnumber NOT IN ( SELECT cardnumber FROM borrowers ) is not good. Logically it is ok, however the number of borrowers can be so huge that it will use heaps of resources or even fail (there are some limits on the list size I believe, postgres is 2000, not sure about mysql). I think EXISTS is a better option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 04:40:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 02:40:31 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #25 from David Cook --- (In reply to Katrin Fischer from comment #23) > Hi David, > > some very first observations from reading the code and the QA script: > > The license on cataloguing/z3950_auth_search.pl is GPL2+ - maybe you could > consider making it GPL3+? > > There are some .pl files with SQL statements in them - I think it would be > nicer to move them out to an existing or new module. I know that most of it > probably is kind of a preexisting problem stemming from how we handle > bibliographic records. > > For the changes in Breeding.pm some unit tests should be provided. > > In your updatedatabase statement could you specify after which column the > new column should be added (little pet peeve of mine I guess :) )? Hi Katrin: 1) Sure. I've changed the license on cataloguing/z3950_auth_search.pl to GPL3+. 2) It is a pre-existing problem, so perhaps a separate bug should be opened instead for removing SQL from the .pl files and putting them in an existing or new module? (It's funny that we removed the defunct Z39.50 module since it wasn't being used and now it seems that we could use a new Z39.50 module :P). That'll actually be quite a large re-write, I think. 3) As for the unit tests...I can't think of any way to really create a unit test for this, since "Z3950SearchAuth" is too tightly tied to the template and an actual logged in user. The same goes for the regular "Z3950Search". There should probably be a better separation of code and template with the Z3950 searching, but that also seems like a pre-existing problem. I just copied the code and made it work for authorities instead of bibliographic records. I imagine fixing that would also be better as a separate bug. 4) Fixed updatedatabase to specify an "AFTER" column (as well as removing MySQL backticks). 5) I've removed the FIXMEs and TODOs from the parts of Breeding.pm that I've added. (They weren't "real" FIXMEs.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 04:45:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 02:45:22 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19958|0 |1 is obsolete| | Attachment #19959|0 |1 is obsolete| | Attachment #19960|0 |1 is obsolete| | --- Comment #26 from David Cook --- Created attachment 20927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20927&action=edit Bug 10096 - [FOLLOW-UP] QA Improvements 0) Run updatedatabase.pl (to add "recordtype" to the z3950servers table. 1) Set up Z39.50 client targets for authority databases. (I've included information at the bottom of this message for LibrariesAustralia's test server for authorities as well as instructions on how to use your Koha's z39.50 authority server as well. The Library of Congress also has authority databases available (unsure if these are test or prod), and you might have access to others through OCLC or RLIN. OCLC provides login credentials for their test databases. N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. 2) Go to the Authorities module 3) Click on the new "Z39.50 search button" 4) Select your authority search targets from the list 5) Do a search for an authority you would like using either the "Keyword" input box or the more specific input boxes for names, subjects, subject sub divisions, or titles. (I like searching Author (personal): Eric on the LibrariesAustralia test DB.) 6) You should see a table listing the server, heading, authority type, and two other columns (MARC and a nameless column). "Authority type" is the type of authority it will become when imported in to Koha. In the Eric example, "PERSO_NAME". 7) Click on "MARC" next to the results of interest to review the MARC authority record. 8) When you're satisfied with a record, click on "Import". 9) The pop-up window will close and your original Koha window will change to the "Adding authority Personal Name" screen (in the Eric example). 10) All the relevant fields should be filled out for the record. Review them and make any changes as necessary. (N.B. The 001 will be cleared when saved, so if you have a use for the imported control number, move it to the 010, 016, or 035 as appropriate. If you have a default value for the 003, this will also likely be overwritten. Move it if necessary. The 005 will also be updated when saved, so do not worry about that.) 11) When you're satisfied, click save. 12) Presto! You've imported your first authority record via Z39.50! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 04:46:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 02:46:43 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20927|0 |1 is obsolete| | --- Comment #27 from David Cook --- Created attachment 20928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20928&action=edit Bug 10096 - Add a Z39.50 interface for authority searching This patch introduces a new Z39.50 interface for searching z39.50 compliant databases for MARC authority records. These databases aren't as common as their bibliographic equivalents, but they're out there and very useful. I have included info at the bottom of this messsage for sample authority databases you can try. To test this patch: 1) Set up Z39.50 client targets for authority databases. (I've included information at the bottom of this message for LibrariesAustralia's test server for authorities as well as instructions on how to use your Koha's z39.50 authority server as well. The Library of Congress also has authority databases available (unsure if these are test or prod), and you might have access to others through OCLC or RLIN. OCLC provides login credentials for their test databases. 2) Go to the Authorities module 3) Click on the new "Z39.50 search button" 4) Select your authoriy search targets from the list (N.B. bibliographic targets will also display. These are of no use to you.) 5) Do a search for an authority you would like using either the "Raw" input box or the more specific input boxes for names, subjects, subject sub divisions, or titles. (I like searching Name (personal): Eric on the LibrariesAustralia test DB.) 6) You should see a table listing the server, heading, authority type, and two other columns (MARC and a nameless column). "Authority type" is the type of authority it will become when imported in to Koha. In the Eric example, "PERSO_NAME". 7) Click on "MARC" next to the results of interest to review the MARC authority record. 8) When you're satisfied with a record, click on "Import". 9) The pop-up window will close and your original Koha window will change to the "Adding authority Personal Name" screen (in the Eric example). 10) All the relevant fields should be filled out for the record. Review them and make any changes as necessary. (N.B. The 001 will be cleared when saved, so if you have a use for the imported control number, move it to the 010, 016, or 035 as appropriate. If you have a default value for the 003, this will also likely be overwritten. Move it if necessary. The 005 will also be updated when saved, so do not worry about that.) 11) When you're satisfied, click save. 12) Presto! You've imported your first authority record via Z39.50! -- Here is the info for the LibrariesAustralia test Z39.50 authority database: Z39.50 server: LibrariesAustralia Authorities Hostname: z3950-test.librariesaustralia.nla.gov.au Port: 210 Database: AuthTraining Userid: ANLEZ Password: z39.50 Syntax: MARC21/USMARC Encoding: utf8 - The U.S.A. Library of Congress also provides Z39.50 access to its Name and Subject Authorities (http://www.loc.gov/z3950/lcserver.html). Name Authority: Z39.50 server: Library of Congress Name Authority File Hostname: lx2.loc.gov Port: 210 Database: NAF Syntax: MARC21/USMARC Encoding: utf8 Subject Authority: Z39.50 server: Library of Congress Subject Authority File Hostname: lx2.loc.gov Port: 210 Database: SAF Syntax: MARC21/USMARC Encoding: utf8 (N.B. Both of these databases also include title authorities.) - For testing purposes, you can also set up a Z39.50 client target, which points at your own Koha instance's Z39.50 authority server. To find the hostname, go to /etc/koha-conf.xml and find the value for the element. Depending on your configuration, this could be something like the following: unix:/zebra/koha/var/run/zebradb/authoritysocket (N.B. You might be using a different scheme than unix sockets...) To find the database, scroll down to the bottom of koha-conf.xml until you reach the element. Within this, look for the value of the element . It should probably be "authorities". To set up this Z39.50 client target in Koha... Z39.50 server: my koha authorities Hostname: unix:/zebra/koha/var/run/zebradb/authoritysocket Port: Database: authorities Userid: Password: Syntax: MARC21/USMARC (or whichever flavour you need) Encoding: utf8 Signed-off-by: Mason James Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching This patch adds the "recordtype" column to the "z3950servers" table. The value in this column (biblio or authority) then controls whether the z3950 server shows up in a bibliographic search (through the Acq and Cataloguing modules) or in an authority search (through the Authorities module). I also edited the z3950 management console to show this value and allow users to edit it. The default value is "biblio", since the vast majority of z3950 targets will be bibliographic. However, there is an option to add/edit a z3950 target as a source of authority records. Test Plan: 1) Apply both patches 2) Run updatedatabase.pl (after setting your KOHA_CONF and PERL5 environmental variables) 3) Use the test plan from the 1st patch N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. Signed-off-by: Mason James Bug 10096 [FOLLOW-UP] - fix tabs/whitespace errors to pass QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 04:48:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 02:48:11 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #28 from David Cook --- Created attachment 20929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20929&action=edit Bug 10096 - [FOLLOW-UP] QA Improvements 0) Run updatedatabase.pl (to add "recordtype" to the z3950servers table. 1) Set up Z39.50 client targets for authority databases. (I've included information at the bottom of this message for LibrariesAustralia's test server for authorities as well as instructions on how to use your Koha's z39.50 authority server as well. The Library of Congress also has authority databases available (unsure if these are test or prod), and you might have access to others through OCLC or RLIN. OCLC provides login credentials for their test databases. N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. 2) Go to the Authorities module 3) Click on the new "Z39.50 search button" 4) Select your authority search targets from the list 5) Do a search for an authority you would like using either the "Keyword" input box or the more specific input boxes for names, subjects, subject sub divisions, or titles. (I like searching Author (personal): Eric on the LibrariesAustralia test DB.) 6) You should see a table listing the server, heading, authority type, and two other columns (MARC and a nameless column). "Authority type" is the type of authority it will become when imported in to Koha. In the Eric example, "PERSO_NAME". 7) Click on "MARC" next to the results of interest to review the MARC authority record. 8) When you're satisfied with a record, click on "Import". 9) The pop-up window will close and your original Koha window will change to the "Adding authority Personal Name" screen (in the Eric example). 10) All the relevant fields should be filled out for the record. Review them and make any changes as necessary. (N.B. The 001 will be cleared when saved, so if you have a use for the imported control number, move it to the 010, 016, or 035 as appropriate. If you have a default value for the 003, this will also likely be overwritten. Move it if necessary. The 005 will also be updated when saved, so do not worry about that.) 11) When you're satisfied, click save. 12) Presto! You've imported your first authority record via Z39.50! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 08:35:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 06:35:54 +0000 Subject: [Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 08:35:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 06:35:58 +0000 Subject: [Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20685|0 |1 is obsolete| | Attachment #20686|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 20930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20930&action=edit [PASSED QA] Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl The template for printing a single spine label is a stripped-down version of a standard Koha template, but it should include intranetuserjs and IntranetUserCSS so that libraries can make local customizations. This patch updates the page's DOCTYPE to HTML5 and adds the missing markup for including those preferences. Also added is jQuery, since there's a good chance local customizations are using jQuery. To test, make sure there is something in your intranetuserjs and IntranetUserCSS system preferences. Visit /cgi-bin/koha/labels/spinelabel-home.pl and submit a barcode. View source on the spine label output page and confirm that your custom js and css were included correctly. Signed-off-by: Campbell Reid-Tait Signed-off-by: Katrin Fischer Template only change, works nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 08:36:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 06:36:52 +0000 Subject: [Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 --- Comment #13 from Katrin Fischer --- Created attachment 20931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20931&action=edit [PASSED QA] Bug 9618: Followup Add support for intranetuserjs to labels/spinelabel-print.pl the jQuery lib is useful only if js code is filled into the intranetuserjs pref. Signed-off-by: Campbell Reid-Tait Signed-off-by: Katrin Fischer To test: - Use Quick spine label creator - Make sure you have Javascript in your intranetuserjs system preference - Validate Javascript effect on screen or check source code to make sure your code is visible there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 08:41:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 06:41:01 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 08:41:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 06:41:04 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20905|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 20932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20932&action=edit [PASSED QA] Bug 10600: Change the icon for the action duplicate Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 08:45:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 06:45:20 +0000 Subject: [Koha-bugs] [Bug 10850] New: Give Quick spine label template page its own id Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10850 Bug ID: 10850 Summary: Give Quick spine label template page its own id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To make it easier and safer to address the various elements on the quick spine label template it would be nice if the page had its own CSS id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 08:46:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 06:46:51 +0000 Subject: [Koha-bugs] [Bug 10675] Remove spinelabel.css? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10675 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move spinelabel.css to |Remove spinelabel.css? |system preference | --- Comment #1 from Katrin Fischer --- I have now figured out that you can use intranetusercss and soon intranetuserjs on the page. Maybe the extra CSS file should be removed? It can't be edited by libraries and will be overwritten during updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 08:47:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 06:47:15 +0000 Subject: [Koha-bugs] [Bug 10675] Remove spinelabel.css? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10675 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Label printing |Templates Assignee|cnighswonger at foundations.ed |oleonard at myacpl.org |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 08:47:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 06:47:28 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 09:06:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 07:06:30 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Jonathan Druart --- Yes of course, I forgot to change the status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 09:13:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 07:13:11 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #40 from Katrin Fischer --- (In reply to M. de Rooy from comment #27) > The circulation.tt template also contains another problem: If I cannot renew > because of a hold, it should still be possible to check in the item. But > this is not possible due to the same condition used: > > [% IF ( todayissue.renew_error_on_reserve ) %] > On hold > > > [% ELSE %] > value="[% todayissue.barcode %]" /> > > > [% END %] Hi Marcel, IIRC this was done on purpose, because when checking in items from the patron account the printing of the reserve slip would not be triggered. So it forces you to properly return the items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 10:37:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 08:37:16 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20926|0 |1 is obsolete| | --- Comment #73 from Jonathan Druart --- Created attachment 20933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20933&action=edit Bug 7180: Follow-up fixing minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 10:37:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 08:37:22 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #74 from Jonathan Druart --- Created attachment 20934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20934&action=edit Bug 7180: Change syspref description - the blank line is now useless - add an example for the syspref value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 10:37:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 08:37:27 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #75 from Jonathan Druart --- Created attachment 20935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20935&action=edit Bug 7180: Adapt neworderempty code (js function moved). The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link some av to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 10:39:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 08:39:54 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #76 from Jonathan Druart --- (In reply to Katrin Fischer from comment #72) > Hi Jonathan, Hi Katrin, > I have started with a code review and fixed some minor issues in a follow-up > patch. Could you take a look at the patch please and add your sign-off if > the changes are ok? Yep, thank you for this patch! > 1) I think the use of the new system preference is not clear from the > description, can we give an example maybe? I am also not so happy about the > blank line requirement. Not sure, but could it be handled similar to > opachiddenitems? Yes, I added a followup for that: an example is added to the syspref description and the blank line is useless (added by the script). > 2) I started with regression testing: When I add a new order by searching > for a record from the catalog (neworderempty.pl) and choose my fund, the > statistic values are not updated. There is a Javascript error on the page: > > ReferenceError: fetchSortDropbox is not defined > fetchSortDropbox(this.form) Fixed in the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 11:21:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 09:21:18 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel --- Hi, I did a merge with your remote branch, also did a complete clone and switched to the bootstrap-opac branch In both cases I get " Software error: Template process failed: file error - cssinclude: not found at /home/bgkriegel/kohaclone/C4/Templates.pm line 132. " Is there anything else to do before enable bootstrap theme? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:39:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:39:58 +0000 Subject: [Koha-bugs] [Bug 10851] New: Add missing statuses Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Bug ID: 10851 Summary: Add missing statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The serial module provide some status for serials. The missing status usually is not enough to describe the real status. We will suggest to add 4 new statuses for missing serials: never receipt, sold out, defective or lost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:41:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:41:31 +0000 Subject: [Koha-bugs] [Bug 10852] New: Add 3 filters to the serials search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 Bug ID: 10852 Summary: Add 3 filters to the serials search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The serial module offers some filters to search serials. But 3 are missing: location, callnumber and expiration date. This feature will add them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:44:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:44:02 +0000 Subject: [Koha-bugs] [Bug 10853] New: Create CSV profiles with sql fields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10853 Bug ID: 10853 Summary: Create CSV profiles with sql fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Currently CSV profiles can be created with marc fields only. This feature will allow to create CSV profile for sql fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:46:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:46:58 +0000 Subject: [Koha-bugs] [Bug 10854] New: Choose a CSV profile for exporting serial claims Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Bug ID: 10854 Summary: Choose a CSV profile for exporting serial claims Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Bug 10853 allows to create CSV profile with DB fields. This feature will allow to select a defined CSV profile for serial claims. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:47:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:47:29 +0000 Subject: [Koha-bugs] [Bug 10853] Create CSV profiles with sql fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10854 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:47:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:47:29 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10853 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:50:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:50:57 +0000 Subject: [Koha-bugs] [Bug 10855] New: Additional fields for subscriptions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Bug ID: 10855 Summary: Additional fields for subscriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Some customer requests are about creating custom fields for serials. In order to avoir new specific fields for each customers, this feature will add a new module to create fields dynamically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:51:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:51:56 +0000 Subject: [Koha-bugs] [Bug 10856] New: Improve the previous and next items on the shelf browser Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Bug ID: 10856 Summary: Improve the previous and next items on the shelf browser Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The new and previous links should be a link to the new and previous items in the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:53:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:53:29 +0000 Subject: [Koha-bugs] [Bug 10857] New: Add facets cancellation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Bug ID: 10857 Summary: Add facets cancellation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org When searching (at the OPAC or staff), facets can be enabled but never disabled. So a user must relaunch the search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:54:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:54:53 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Jonathan, I am not sure I understand the intended change? Isn't that how it works now? Showing you what's next and previous on the shelf? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:55:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:55:17 +0000 Subject: [Koha-bugs] [Bug 10858] New: Browse selected biblios Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Bug ID: 10858 Summary: Browse selected biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org After launching a search, lots of people would like to browse some results from several pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:56:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:56:40 +0000 Subject: [Koha-bugs] [Bug 10859] New: Alert if a patron already has an issue for the same biblio Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Bug ID: 10859 Summary: Alert if a patron already has an issue for the same biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This feature will a an alert if a patron already has an issue for the same biblio. The librarian can force the checkout anyway. It doesn't alert the librarian if the biblio is a subscription. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:57:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:57:21 +0000 Subject: [Koha-bugs] [Bug 10860] New: In-House Use Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Bug ID: 10860 Summary: In-House Use Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This feature implements the In-House Use feature for Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:57:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:57:52 +0000 Subject: [Koha-bugs] [Bug 10861] New: Add a check on cardnumber length Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 Bug ID: 10861 Summary: Add a check on cardnumber length Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries would like to add a check on the cardnumber length. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 13:58:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 11:58:50 +0000 Subject: [Koha-bugs] [Bug 10862] New: Add an search history for the staff interface Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Bug ID: 10862 Summary: Add an search history for the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Like OPAC, the search history will be available for the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:00:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:00:12 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Jonathan, I think maybe check the status names with a native speaker? I couldn't make sense of defective :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:00:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:00:40 +0000 Subject: [Koha-bugs] [Bug 10859] Alert if a patron already has an issue for the same biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:00:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:00:53 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #2 from Jonathan Druart --- Created attachment 20936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20936&action=edit Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never receipt, sold out, defective or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:01:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:01:19 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- We currently use statistical patrons for recording in-house use - can you describe a bit more how the new feature will work? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:02:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:02:07 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #2 from Jared Camins-Esakov --- Doesn't Koha already have in-house use tracking with both statistical patrons and RecordLocalUseOnReturn? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:03:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:03:32 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #1) > Hi Jonathan, I think maybe check the status names with a native speaker? I > couldn't make sense of defective :( What do you propose? I had a choice with defective, faulty, flawed, cracked, etc. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:05:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:05:56 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #4 from Katrin Fischer --- What about damaged? And I think maybe Never received? But I think we really need a native speaker here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:08:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:08:37 +0000 Subject: [Koha-bugs] [Bug 10812] Warn when a user had already checked out a title in the past In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|new check-ou warning: |Warn when a user had | |already checked out a title | |in the past -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:08:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:08:39 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #5 from Jared Camins-Esakov --- (In reply to Jonathan Druart from comment #3) > (In reply to Katrin Fischer from comment #1) > > Hi Jonathan, I think maybe check the status names with a native speaker? I > > couldn't make sense of defective :( > > What do you propose? I had a choice with defective, faulty, flawed, cracked, > etc. :) I see what you were looking for. How about "damaged"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:11:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:11:08 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #1 from mathieu saby --- Nice idea of improvement Jonathan. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:16:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:16:27 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #1 from Jonathan Druart --- Created attachment 20937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20937&action=edit Bug 10855: Add the new package Koha::AdditionalField -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:16:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:16:30 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #2 from Jonathan Druart --- Created attachment 20938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20938&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:16:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:16:34 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #3 from Jonathan Druart --- Created attachment 20939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20939&action=edit Bug 10855: Add unit tests for the new package Koha::AdditionalField Test plan: - prove t/db_dependent/AdditionalField.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:16:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:16:37 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #4 from Jonathan Druart --- Created attachment 20940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20940&action=edit Bug 10855: interface configuration for adding new fields to subscriptions This patch adds an interface configuration for adding fields to subscriptions. Test plan: - go to serials/serials-home.pl - click on the "Add subscription fields" link on the left of the screen - try to add/update/delete new fields You are not abble to add a field with an authorised value category and a marcfield. Columns are sortable - for the rest, you should have, at least: * a new field named af1, sortable, linked to a category * a new field named af2, sortable, linked to a marcfield * a new field named af3, not sortable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:16:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:16:40 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #5 from Jonathan Druart --- Created attachment 20941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20941&action=edit Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the "Additional fields" block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:16:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:16:43 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #6 from Jonathan Druart --- Created attachment 20942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20942&action=edit Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:16:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:16:46 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #7 from Jonathan Druart --- Created attachment 20943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20943&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:16:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:16:50 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #8 from Jonathan Druart --- Created attachment 20944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20944&action=edit Bug 10855: FIX: Add additional fields for closed subscriptions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:17:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:17:18 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Large patch Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:19:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:19:00 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 --- Comment #1 from Jonathan Druart --- Created attachment 20945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20945&action=edit Bug 10852: serials search improvements This patch adds 3 filters for the serials search: - location - callnumber - expiration date To test: - Search serials by location and/or callnumber and/or expiration date and check that results are consistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:19:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:19:16 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:25:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:25:55 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #2 from Jonathan Druart --- Created attachment 20946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20946&action=edit Bug 10857: Add facets cancellation When searching (at the OPAC or pro), facets can be enabled but never disabled. So a user is obliged to relaunch the search. This patch adds a new link "[x]" at the right of each selected facet. This link relaunch the search without this facet. Test plan: - Launch a search (OPAC and pro) - Enable some facets - Disable some facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:26:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:26:16 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:31:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:31:06 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #1 from Jonathan Druart --- Created attachment 20947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20947&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:31:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:31:22 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:36:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:36:47 +0000 Subject: [Koha-bugs] [Bug 10863] New: Add 2 circulation permissions: force_checkout and lift_restriction Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Bug ID: 10863 Summary: Add 2 circulation permissions: force_checkout and lift_restriction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:38:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:38:33 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 --- Comment #11 from Owen Leonard --- (In reply to Bernardo Gonzalez Kriegel from comment #10) > Template process failed: file error - cssinclude: not found at > /home/bgkriegel/kohaclone/C4/Templates.pm line 132. Which page gave you this error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:41:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:41:36 +0000 Subject: [Koha-bugs] [Bug 9478] Diacritics in branchname on subscription detail page are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10626 --- Comment #1 from Katrin Fischer --- I think this will probably be resolved by deduplicating the TT plugins - the 'surviving' plugin seems to handle this correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:41:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:41:34 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #1 from Jonathan Druart --- Created attachment 20948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20948&action=edit Bug 10863: Add 2 circulation permissions: force_checkout and lift_restriction This patch adds 2 circulation permissions: force_checkout and lift_restriction. Both are added to existing patrons having circulation flags. force_checkout allows a librarian to force a checkout if a limitation occurred. lift_restriction allows a librarian to lift a restriction for a patron. Test plan: 1/ Find a debarred patron and go on the checkout page. The "Lift restriction" button should be present only if the logged librarian has the lift_restriction permission. 2/ If the force_checkout permission is set, a librarian should be allowed to check out in several cases: - age restriction - the item is issued to another patron - the item is not for loan - the patron has overdue items - the item is lost - the item is a high demand item - the item is reserved - another case ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:41:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:41:36 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9478 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:41:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:41:52 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:43:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:43:34 +0000 Subject: [Koha-bugs] [Bug 10864] New: Diacritics in patron categories in advanced patron search broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10864 Bug ID: 10864 Summary: Diacritics in patron categories in advanced patron search broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org If you search patrons by patron category using the + and patron category search option patron categories with diacritics don't show up correctly. Example: Gasth?rer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:54:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:54:06 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #7 from Nicole C. Engard --- Created attachment 20949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20949&action=edit spine label I got this today from another library on 3.10.9 ---------- We have something wacky going on. Our barcode labels are printing out fine, but our spine labels have suddenly gone nuts. The system is: -creating a period at the beginning of the 2nd or 3rd line where none exists in the Call #. -Making lower case text ALL CAPS -Making long lines extend to the following label ------------ It sounds related to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:56:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:56:22 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #1 from Jonathan Druart --- Created attachment 20950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20950&action=edit Bug 10861: Add a check on cardnumber length Some libraries would like to add a check on the cardnumber length. This patch adds the ability to restrict the cardnumber to a specific length (strictly equal to XX, or length > XX or min < length < max). This restriction is checked on inserting/updating a patron or on importing patrons. This patch adds: - 1 new syspref CardnumberLength. 2 formats: a number or a range (xx,yy). - 1 new unit test file t/Members/checkcardnumber.t for the C4::Members::checkcardnumber routine. Test plan: 1/ Fill the pref CardnumberLength with '5,8' 2/ Create a new patron with an invalid cardnumber (123456789) 3/ Check that you cannot save 4/ With Firebug, replace the pattern attribute value (for the cardnumber input) with ".{5,10}" 5/ You are allowed to save but an error occurred. 6/ Try the same steps for update. 7/ Go to the import borrowers tool. 8/ Play with the import borrowers tool. We must test add/update patrons and the "record matching" field (cardnumber or a uniq patron attribute) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 14:56:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 12:56:52 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:05:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:05:25 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20734|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 20951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20951&action=edit Bug 10807: Add an authority search history for the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:05:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:05:44 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20764|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 20952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20952&action=edit Bug 10807: FIX if zebra is down, total is undef -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:07:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:07:33 +0000 Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 --- Comment #1 from Jonathan Druart --- Created attachment 20953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20953&action=edit Bug 10862: Add an search history for the intranet interface Like OPAC, the search history is now available for intranet. Test plan: 1/ Switch on the 'EnableSearchHistory' syspref. 3/ Launch some biblio and authority searches. 4/ Go on your search history page (top right, under "Set library"). 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Play with the 4 delete links (current / previous and biblio / authority). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:07:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:07:51 +0000 Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Depends on| |10807 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:07:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:07:51 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10862 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:13:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:13:22 +0000 Subject: [Koha-bugs] [Bug 10859] Alert if a patron already has an issue for the same biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 --- Comment #1 from Jonathan Druart --- Created attachment 20954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20954&action=edit Bug 10859: Alert if a borrower already has an issue for the same biblio The librarian can force the checkout anyway. It doesn't alert the librarian if the biblio is a subscription Test plan: 1. Create a biblio with at least 2 items 2. Checkout the first item for a borrower 3. Set syspref AllowMultipleIssuesOnABiblio to OFF. 4. Try to checkout the second item with the same borrower. A message should appear telling you that this borrower already borrowed an item from this biblio. If you have the permission 'force_checkout' You should also see two buttons to confirm (or not) the checkout 5. Click on 'No'. The checkout is not done 6. Repeat step 4 and click 'Yes', the checkout is done. 7. Return the second item. 8. Set syspref AllowMultipleIssuesOnABiblio to ON 9. Try to checkout the second item with the same borrower. This time the checkout is done without warnings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:14:09 +0000 Subject: [Koha-bugs] [Bug 10859] Alert if a patron already has an issue for the same biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Depends on| |10863 Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:14:09 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10859 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:14:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:14:17 +0000 Subject: [Koha-bugs] [Bug 10865] New: Don't show list permissions when adding public lists/sharing lists is not allowed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Bug ID: 10865 Summary: Don't show list permissions when adding public lists/sharing lists is not allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Created attachment 20955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20955&action=edit screenshot We can now prevent patrons from adding public lists, but the interface in the OPAC still shows the pulldown with only 'Private' in that case and also permissions that don't make sense as long as user's can't share lists or work on public lists created from the OPAC together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:23:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:23:24 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 --- Comment #12 from Bernardo Gonzalez Kriegel --- (In reply to Owen Leonard from comment #11) > (In reply to Bernardo Gonzalez Kriegel from comment #10) > > Template process failed: file error - cssinclude: not found at > > /home/bgkriegel/kohaclone/C4/Templates.pm line 132. > > Which page gave you this error? Simply switching theme to bootstrap and reloading main OPAC page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:29:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:29:18 +0000 Subject: [Koha-bugs] [Bug 10853] Create CSV profiles with sql fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10853 --- Comment #1 from Jonathan Druart --- Created attachment 20956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20956&action=edit Bug 10853: Add DB field export_format.type ('marc' or 'sql'). This patch: - adds a new column 'type' to the export_format table. - renames the field name export_format.marcfields with export_format.content. Feel free to propose another name. Test plan: - Check that existing profiles have the type "marc" selected by default - Create a new profile with a type "sql" - Save and verify the profile is correctly displayed when you select it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:29:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:29:33 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 --- Comment #1 from Jonathan Druart --- Created attachment 20957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20957&action=edit Bug 10854: Export serial claims with a csv profile. Test plan: - Create a csv profile (or use the default one) with a type 'sql'. - Go to serials/claims.pl, select the wanted csv profile and click on the "Export selected items data". - Verify the csv file is correctly generated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:29:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:29:53 +0000 Subject: [Koha-bugs] [Bug 10853] Create CSV profiles with sql fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:30:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:30:05 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:35:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:35:07 +0000 Subject: [Koha-bugs] [Bug 10866] New: Books entered in malayalam language cannot to search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10866 Bug ID: 10866 Summary: Books entered in malayalam language cannot to search Change sponsored?: --- Product: Koha Version: 3.12 Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: sameer at kvasu.ac.in QA Contact: testopia at bugs.koha-community.org Sir, Prior to install 3.12, i was using 3.2 and i could search the terms in malayalam language. Now in 3.12 I cannot search the titles in malayalam, but it is ok in English. is there any solution -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:37:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:37:40 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20936|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 20958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20958&action=edit Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:39:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:39:03 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #7 from Jonathan Druart --- (In reply to Jared Camins-Esakov from comment #5) > > What do you propose? I had a choice with defective, faulty, flawed, cracked, > > etc. :) > > I see what you were looking for. How about "damaged"? Go for "damaged"! Last patch replaces "defective" with "damaged" and "never receipt" with "never received". Thank you Katrin & Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:53:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:53:55 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |paul.poulain at biblibre.com Severity|enhancement |major --- Comment #6 from Paul Poulain --- I consider that this patch is not an ENH, but a bugfix needed for libraries that want to put their mySQL server outside from their web one. So i've upgraded the severity & priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:57:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:57:38 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #3 from Jonathan Druart --- The feature will allow to distinguish a checkout to an in-house use (visually: tabs in the circulation history, line "(In-house use)" in the checkout list at the OPAC and staff interfaces, etc.). It will be possible to do a checkout to a debarred patron, which is not possible with the existing feature. The patch won't delete the RecordLocalUseOnReturn, so the 2 features can cohabit ; if this one wins unanimous support, I will submit a followup in order to migrate data from the existing ones (statistics table), if it is possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 15:59:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 13:59:47 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #4 from Katrin Fischer --- > It will be possible to do a checkout to a debarred patron, which is not > possible with the existing feature. Hm, why would you want to check out to a debarred patron? And is it a real checkout? (ends on the patron account - or only for counting? Is there a special option you have to check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:05:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:05:23 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > > It will be possible to do a checkout to a debarred patron, which is not > > possible with the existing feature. > > Hm, why would you want to check out to a debarred patron? It is not a check out but an in-house use, sorry... > And is it a real checkout? (ends on the patron account - or only for counting? Yes, it is a check out, with a new flag in DB. > Is there a special option you have to check? A new checkbox will be added on the circulation page. Patch coming... :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:05:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:05:37 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #6 from Jonathan Druart --- Created attachment 20959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20959&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:05:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:05:58 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:11:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:11:39 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #7 from Jonathan Druart --- Created attachment 20960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20960&action=edit quick view: checkout list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:12:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:12:10 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #8 from Jonathan Druart --- Created attachment 20961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20961&action=edit quick view: circulation history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:38:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:38:19 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20850|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 20962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20962&action=edit Bug 10626: Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues - Followup 2 Removes USE KohaAuthorisedValues plugin from item-status-schema-org.inc as it does not seem to be used in the file. Couldn't detect regressions removing it on OPAC detail page. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:42:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:42:27 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20922|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 20963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20963&action=edit bug clean ubuntu docs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:45:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:45:30 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 --- Comment #2 from Jonathan Druart --- Created attachment 20964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20964&action=edit MT11899: Improve the previous and next items on the shelf browser The next and previous links should be a link to the next and previous items in the list. Before this patch, the previous was the first on the list and the next was the last. For example: [<] [1] [2] [3] [4] [5] [6] [>] Before this patch, the next and previous links were the same as the 1 and 6. Now, the next and previous links are the same as ... 0 and 7. Test plan: - On a detail biblio page, click on a "Browse shelf" link. - Play with the next and previous links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:46:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:46:08 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20964|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 20965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20965&action=edit Bug 10856: Improve the previous and next items on the shelf browser The next and previous links should be a link to the next and previous items in the list. Before this patch, the previous was the first on the list and the next was the last. For example: [<] [1] [2] [3] [4] [5] [6] [>] Before this patch, the next and previous links were the same as the 1 and 6. Now, the next and previous links are the same as ... 0 and 7. Test plan: - On a detail biblio page, click on a "Browse shelf" link. - Play with the next and previous links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:46:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:46:26 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 16:48:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 14:48:45 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 --- Comment #4 from Jonathan Druart --- (In reply to Katrin Fischer from comment #1) > Hi Jonathan, I am not sure I understand the intended change? > Isn't that how it works now? Showing you what's next and previous on the > shelf? I agree with you, the description is not clear... In fact the patch simply increments by 1 the gap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 17:22:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 15:22:27 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 --- Comment #13 from Owen Leonard --- (In reply to Bernardo Gonzalez Kriegel from comment #12) > > > Template process failed: file error - cssinclude: not found at > > > /home/bgkriegel/kohaclone/C4/Templates.pm line 132. Thanks to Katrin for pointing out the explanation for this: You probably have a non-English template specified, whether intentionally or not. You might need to clear your cookies? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 17:22:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 15:22:49 +0000 Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 --- Comment #3 from Jonathan Druart --- Created attachment 20966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20966&action=edit Bug 5031: CSV profiles: content fields are required Some fields are required on editing/adding csv profiles. Test plan: - add a new csv profile (tools/csv-profiles.pl) without any value. - save => error on empty fields. - fill the "marc" content, select type="sql", fill the csv name input. - save => error on sql content field. - fill the sql content - save => the csv profile is saved. - retry for the edit form. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 17:23:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 15:23:20 +0000 Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch Depends on| |10853 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 17:23:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 15:23:20 +0000 Subject: [Koha-bugs] [Bug 10853] Create CSV profiles with sql fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5031 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 17:30:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 15:30:49 +0000 Subject: [Koha-bugs] [Bug 10837] Checkboxes are missing in Serial > Claims > 'Late Selections list'' . So I cannot do "Exported selected items"" in my installations(v 3.12.0 and 3.12.3) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10837 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Created attachment 20967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20967&action=edit Serials claims (In reply to Harsha from comment #0) > Check boxes are missing in Serial > Claims > 'Late Selections list'' . > > So I cannot do "Exported selected items"" in my installations(v 3.12.0 and > 3.12.3) > > In Koha Demo( 3.12v), I have observed same but Manual shows there are check > boxes in 3.10v for the same task > > I am new to KOHA and we, Open university, Sri Lanka testing the system > feasibility this is a drawback to us as we have significant amount to > Serials to manage. > > Thanks Hello Harsha, Could you detail the "Late Selections list" link? Did you get a javascript error (using Firebug)? Here my serial claims screen (on the master branch). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 17:38:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 15:38:53 +0000 Subject: [Koha-bugs] [Bug 10651] Use new DataTables include in administration templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 --- Comment #1 from Owen Leonard --- Created attachment 20968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20968&action=edit Bug 10651 - Use new DataTables include in administration templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all administration-related pages which use DataTables. To test, view the following pages and confirm that table sorting is still working correctly: - Administration -> Budgets - Administration -> Authority types -> MARC structure - Administration -> Authorized values - Administration -> Library transfer limits - Administration -> Libraries and groups - Administration -> Patron types and categories - Administration -> Cities and towns - Administration -> Item types - Administration -> MARC bibliographic framework -> MARC structure - Administration -> System preferences - Administration -> System preferences -> Local use - Administration -> Z39.50 client targets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 17:38:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 15:38:50 +0000 Subject: [Koha-bugs] [Bug 10651] Use new DataTables include in administration templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 17:49:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 15:49:42 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #8 from Nicole C. Engard --- Yet another report of this: ----------- It has come to my attention that our spine labels have begun to behave differently since approx. the beginning of this month (September '13): 1) all characters are being transformed into CAPS. We have conventions here where we use lower case: a) for prefixes to indicate collections like "SpColl" and "Diss" -- now they are "SPCOLL" and "DISS" b) for first 5 characters in author name and in title for our dissertations and theses i.e.: Julic Death --which is now: JULIC DEATH 2) the line breaks on the splitting of call numbers are now all screwy (maybe because of the characters being in all caps?). Where there is a call number prefix (like SpColl), instead of keeping it all on the first line, it is splitting it up with character numbering of 3+1+1+1 (cuttered), so it looks like: SPC .O L L and DIS .S and then it continues with the rest of the call number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 17:52:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 15:52:50 +0000 Subject: [Koha-bugs] [Bug 10867] New: Adding label to batch, search by date requires "on or after date". Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10867 Bug ID: 10867 Summary: Adding label to batch, search by date requires "on or after date". Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: rudolfbyker at gmail.com QA Contact: testopia at bugs.koha-community.org When searching for items to add to a batch of labels, the "Added on or after date" has to be filled in when the "Added on or before date" field is filled in. Steps to reproduce: ** Log in, and go to Home ? Tools ? Labels home ? Manage label Batches ? New Batch ? Add Items ** Select a date in the "on or before" field, but not in the "on or after" field. ** It does not matter whether a keyword/title/etc. is specified. ** Click "Search" ** Error occurs: Software error: Can't call method "output" without a package or object reference at /usr/share/koha/intranet/cgi-bin/labels/label-item-search.pl line 100. Taking a look at the code: 77 $datefrom = $query->param('datefrom'); 78 $dateto = $query->param('dateto'); 79 80 if ($datefrom) { 81 $datefrom = C4::Dates->new($datefrom); 82 if ($QParser) { 83 $ccl_query .= ' && ' if $ccl_textbox; 84 $ccl_query .= 85 "acqdate(" . $datefrom->output("iso") . '-)'; 86 } else { 87 $ccl_query .= ' and ' if $ccl_textbox; 88 $ccl_query .= 89 "acqdate,st-date-normalized,ge=" . $datefrom->output("iso"); 90 } 91 } 92 93 if ($dateto) { 94 $dateto = C4::Dates->new($dateto); 95 if ($QParser) { 96 $ccl_query .= ' && ' if ( $ccl_textbox || $datefrom ); 97 $ccl_query .= "acqdate(-" . $dateto->output("iso") . ')'; 98 } else { 99 $ccl_query .= ' and ' if ( $ccl_textbox || $datefrom ); 100 $ccl_query .= "acqdate,st-date-normalized,le=" . $datefrom->output("iso"); 101 } 102 } At line 100, $datefrom is used, without cheking whether it is set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 17:54:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 15:54:49 +0000 Subject: [Koha-bugs] [Bug 10867] Adding label to batch, search by date requires "on or after date". In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10867 --- Comment #1 from Rudolf Byker --- I forgot to add the workaround! Simply specify a very early date (many years ago). That will solve the problem for most users, but is inconvenient. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 18:03:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 16:03:25 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #24 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Julian and Galen! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 18:18:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 16:18:07 +0000 Subject: [Koha-bugs] [Bug 10868] New: Use new DataTables include in catalog templates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 Bug ID: 10868 Summary: Use new DataTables include in catalog templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Catalog templates which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 18:29:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 16:29:32 +0000 Subject: [Koha-bugs] [Bug 10868] Use new DataTables include in catalog templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 --- Comment #1 from Owen Leonard --- Created attachment 20969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20969&action=edit Bug 10868 - Use new DataTables include in catalog templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all catalog-related pages which use DataTables. The checkout history script has been altered to send unformatted dates to the template, and the template now uses the "title-string" sorting filter to enable sorting on unformatted dates. To test, view the following pages and confirm that table sorting is still working correctly: Catalog -> Biblio detail page Catalog -> Biblio detail page -> Checkout history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 18:29:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 16:29:29 +0000 Subject: [Koha-bugs] [Bug 10868] Use new DataTables include in catalog templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 18:39:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 16:39:50 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Howard Freedman changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |hfreedman at jewishlearningwor | |ks.org Severity|normal |major --- Comment #9 from Howard Freedman --- Chris, if you need any additional information, please let me know. I have no idea why the spine label pdf conversion would have suddenly gone haywire, but this is a real crisis for us. We are unable to print spine labels, which means that we are unable to put new items on the shelves. Thanks, Howard Freedman Director, Jewish Community Library, San Francisco hfreedman at jewishlearningworks.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 18:40:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 16:40:23 +0000 Subject: [Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828 --- Comment #4 from Pedro Ferreira --- Just made 2 fresh intalls koha-3.12.04 and koha-3.08.16 in koha-3.12.04 the labels are also empty as in version 3.12.02 in koha-3.08.16 i get the same error [Tue Sep 10 17:27:42 2013] [error] [client 192.168.20.251] [Tue Sep 10 17:27:42 2013] label-create-pdf.pl: Use of uninitialized value $parts[-1] in pattern match (m//) at /var/www/koha3.08.16/lib/C4/Labels/Label.pm line 160., referer: http://192.168.40.233:86/cgi-bin/koha/labels/label-print.pl [Tue Sep 10 17:27:42 2013] [error] [client 192.168.20.251] [Tue Sep 10 17:27:42 2013] label-create-pdf.pl: Use of uninitialized value $parts[-1] in pattern match (m//) at /var/www/koha3.08.16/lib/C4/Labels/Label.pm line 160., referer: http://192.168.40.233:86/cgi-bin/koha/labels/label-print.pl [Tue Sep 10 17:27:42 2013] [error] [client 192.168.20.251] [Tue Sep 10 17:27:42 2013] label-create-pdf.pl: regexp failed to match string: at /var/www/koha3.08.16/lib/C4/Labels/Label.pm line 165., referer: http://192.168.40.233:86/cgi-bin/koha/labels/label-print.pl I really dont have a clue what is happening and how to start drilling down the problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 18:42:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 16:42:19 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 --- Comment #5 from Owen Leonard --- This still doesn't work the way I expect it should. Perhaps it's not working correctly, or perhaps we have different expectations. I think that if I start from here: [<] [1] [2] [3] [4] [5] [6] [>] ...and click [>], I should see: [<] [7] [8] [9] [10] [11] [12] [>] This is the behavior one finds on, for example, Amazon.com with their "Customers Who Bought This Item Also Bought" feature. After applying this patch I go from this: [<] [1] [2] [3] [4] [5] [6] [>] ...to this: [<] [4] [5] [6] [7] [8] [9] [>] ...and that doesn't make sense to me. I don't want to push my luck, but could a solution to Bug 5500 be rolled into this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 18:43:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 16:43:09 +0000 Subject: [Koha-bugs] [Bug 10869] New: can't delete order line if title deleted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Bug ID: 10869 Summary: can't delete order line if title deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 20970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20970&action=edit deleted title. When looking at a basket in Acq you can't delete an order line if the title has already been deleted. You get no confirmation, no error, it just doesn't delete. It does delete if the title still exists. The problem is a missing parameter. If the title is there the link looks like this: javascript:confirm_delete_item(5547,) If the title doesn't exist the link looks like this: javascript:confirm_delete_item(5557,278226) I know it's better to delete the order line first, but sometimes people do things in cataloging that effect acq and it shouldn't leave this phantom order line - we should be able to delete it. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 18:46:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 16:46:31 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #10 from Chris Nighswonger --- I'm thinking this bug may be a result of a recent code change. I'm away today but will try to have a look tonight. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 19:31:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 17:31:20 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 19:43:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 17:43:37 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #11 from Chris Nighswonger --- Nicole, Will you please post an example call number from this system? And is it LLC? (In reply to Nicole C. Engard from comment #8) > Yet another report of this: > > ----------- > > It has come to my attention that our spine labels have begun to behave > differently since approx. the beginning of this month (September '13): > > 1) all characters are being transformed into CAPS. We have conventions here > where we use lower case: > a) for prefixes to indicate collections like "SpColl" and "Diss" -- now they > are "SPCOLL" and "DISS" > b) for first 5 characters in author name and in title for our dissertations > and theses i.e.: > Julic > Death > --which is now: > JULIC > DEATH > > 2) the line breaks on the splitting of call numbers are now all screwy > (maybe because of the characters being in all caps?). Where there is a call > number prefix (like SpColl), instead of keeping it all on the first line, it > is splitting it up with character numbering of 3+1+1+1 (cuttered), so it > looks like: > SPC > .O > L > v > > and > > DIS > .S > > and then it continues with the rest of the call number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 19:46:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 17:46:47 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #12 from Chris Nighswonger --- Howard, Would you also post an example of a problematic call number and the expected split. Also the classification system used by your library. Tnx. (In reply to Howard Freedman from comment #9) > Chris, if you need any additional information, please let me know. I have > no idea why the spine label pdf conversion would have suddenly gone haywire, > but this is a real crisis for us. We are unable to print spine labels, > which means that we are unable to put new items on the shelves. > > Thanks, > Howard Freedman > Director, Jewish Community Library, San Francisco > hfreedman at jewishlearningworks.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 19:53:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 17:53:22 +0000 Subject: [Koha-bugs] [Bug 10870] New: can't create a profile for patron card creator Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10870 Bug ID: 10870 Summary: can't create a profile for patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When you try to save a profile for the patron card creator in 3.10.9 and master you get this error: Software error: Can't call method "save" without a package or object reference at /home/nengard/kohaclone/patroncards/edit-profile.pl line 72. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 19:54:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 17:54:24 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- A couple of issues: 1. When the logged-in user lacks the permission to lift restrictions the "lift restriction" button is gone from the circulation page but not from the patron detail page (moremember.pl). 2. "Cannot checkout" should be "Cannot check out" 3. I don't think the "high holds" warning should fall into the category of actions needing force_checkout permission. I think in this case the staff member is not overriding something which should normally be blocked. In this case the warning is informational: "Do you still want to check this out even though the loan period has been shortened?" This definitely needs (1) fixed, (2) while you're at it. (3) I could be argued about if I misunderstand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 19:55:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 17:55:32 +0000 Subject: [Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |9394 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 19:55:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 17:55:32 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10247 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 19:59:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 17:59:40 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #13 from Nicole C. Engard --- (In reply to Chris Nighswonger from comment #11) > Nicole, > > Will you please post an example call number from this system? And is it LLC? > It's LCC. Samples: SpColl PS 3505 .U334 A17 1959 SpColl PS 1322 .S45 1962 BF 173 .L14213 1977 Watts PS 3535 .E75 T4 1969 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 20:08:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 18:08:36 +0000 Subject: [Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 --- Comment #10 from Tom?s Cohen Arazi --- It doesn't apply or work on 3.12.x because of its dependency on 9394. Please provide a patch that applies to the stable branch, or comment if you think 9394 should be backported (maybe other patches depend on it). Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 20:15:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 18:15:59 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #14 from Howard Freedman --- Sure, Chris. We actually use LC (for adult), Dewey (for children's collection), and have some idiosyncratic ones for audiovisual media. The LC ones are the least impacted. TX 763 S73 becomes TX 763 .S73 And the standard Deweys are behaving in a similar way: J 295.435 K56 becomes J 295.435 .K56 Where it becomes horrible is in the case of the less standard call numbers: Jpic Rouss becomes: JPI .C ROUSS and DVD HOL Counterfeiters cop.3 would normally break with the border of the label into something like DVD HOL Counte rfeiters cop.3 but instead it now comes out as: DVD .H O L COUNTERFEITERS COP.3 (in addition to the other problems, the unbroken word COUNTERFEITERS goes well into the label to its right) Let me know if you need additional information. Thanks, Howard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:09:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:09:07 +0000 Subject: [Koha-bugs] [Bug 10871] New: Confirmation message for deleting news entries is not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 Bug ID: 10871 Summary: Confirmation message for deleting news entries is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When you delete an entry from the news tool, the confirmation message is not translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:12:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:12:16 +0000 Subject: [Koha-bugs] [Bug 10871] Confirmation message for deleting news entries is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:12:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:12:20 +0000 Subject: [Koha-bugs] [Bug 10871] Confirmation message for deleting news entries is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 --- Comment #1 from Katrin Fischer --- Created attachment 20971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20971&action=edit Bug 10871: Make confirmation message for deleting news translatable To test: - Create a news entry in tools > news - Delete the news entry or multiple entries by selecting them using the checkboxes to the left and the delete button at the bottom of the page. Verify confirmation message shows up correctly with patch applied. Bonus: - Update one of the po files and make sure the new strings shows up there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:15:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:15:05 +0000 Subject: [Koha-bugs] [Bug 7233] matched title open in new window/tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED URL|/cgi-bin/koha/tools/manage- |/cgi-bin/koha/tools/manage- |marc-import.pl?import_batch |marc-import.pl?import_batch |_id=6 |_id=6 CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This was fixed - just not finding the right bug at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:26:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:26:36 +0000 Subject: [Koha-bugs] [Bug 10847] Open external link to website of a vendor in new tab/window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:26:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:26:39 +0000 Subject: [Koha-bugs] [Bug 10847] Open external link to website of a vendor in new tab/window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10847 --- Comment #1 from Katrin Fischer --- Created attachment 20972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20972&action=edit Bug 10847: Open link to vendor's website in new window To test: - Create a new vendor or edit an existing one - Make sure you have entered a valid URL for the website - Click the link from the vendor summary page and verify it opens in a new window/tab (depending on your browser configuration) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:27:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:27:21 +0000 Subject: [Koha-bugs] [Bug 10483] check_uniqueness.pl does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10483 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:27:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:27:59 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #22 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Janusz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:28:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:28:44 +0000 Subject: [Koha-bugs] [Bug 10614] have add order form at top and bottom In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:35:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:35:58 +0000 Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- - Seems to be missing History.pm? - Database update message refers to "MT12541" rather than Bug 10862. - Typically new features like this are not enabled by default. - Preference description says "...patron search history in the OPAC." It should say "staff client." - catalogue/search-history.tt should use new datatables include file (Bug 10649) - The search history page title and breadcrumbs say "History search" where it should say "Search history" - I suggest that we use the term "catalog" instead of "biblio." "biblio" isn't really a word in English, although we use it Koha some places. I think naming the tabs "Catalog" and "Authority" would be clear: "Your catalog search history is empty." "Delete your current catalog search history" "Delete your previous catalog search history" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 21:54:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 19:54:40 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #29 from Katrin Fischer --- Doing a code review of the squashed patches I noticed some things: 1) There are multiple references to items.statisticvalue, but I think we don't have this column in our items table. Is there a dependency to another development? 2) The term 'Total' appears a few times in catalogue_stats.pl but is not translatable (problem was there before). Also those: + ( $i == 0 ) ? "Dewey Classification From" + : ( $i == 1 ) ? "Dewey Classification To" + : ( $i == 2 ) ? "Lccn Classification From" + : ( $i == 3 ) ? "Lccn Classification To" + : ( $i == 4 ) ? "Item CallNumber From" + : ( $i == 5 ) ? "Item CallNumber To" + : ( $i == 6 ) ? "Item type" + : ( $i == 7 ) ? "Publisher" + : ( $i == 8 ) ? "Publication year From" + : ( $i == 9 ) ? "Publication year To" + : ( $i == 10 ) ? "Library" + : ( $i == 11 ) ? "Shelving Location" + : ( $i == 12 ) ? "Collection Code" + : ( $i == 13 ) ? "Status" 3) Same file: DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(), I think we are no longer using this construct. 4) Looking at the code I think the plugin for authorised values could be useful here. 5) Could you please move the tests as suggested by Jared on comment 20? Failed QA for 1) (needs clarification) and 5). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:00:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:00:05 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:00:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:00:20 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:11:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:11:21 +0000 Subject: [Koha-bugs] [Bug 9626] can't pay FU fines without messing things up In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9626 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:13:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:13:21 +0000 Subject: [Koha-bugs] [Bug 10872] New: C4::Items.pm has YAML::Load in GetHiddenItems but lacks use or require Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 Bug ID: 10872 Summary: C4::Items.pm has YAML::Load in GetHiddenItems but lacks use or require Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org I believe the description covers it all. There is no testing, except does anything using C4::Items still work? There should be a: "require YAML;" or "use YAML qw/Load/;" as the GetHiddenItems routine has a reference to YAML::Load. This was discovered while adding GetHiddenItems() calls into opac/opac-MARCdetail.pl. I believe this problem dates back to bug 6488 or bug 5984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:22:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:22:30 +0000 Subject: [Koha-bugs] [Bug 10872] C4::Items.pm has YAML::Load in GetHiddenItems but lacks use or require In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 --- Comment #1 from M. Tompsett --- Created attachment 20973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20973&action=edit Bug 10872 - C4::Items.pm has YAML::Load in GetHiddenItems but lacks use or require There should be a: "require YAML;" or "use YAML qw/Load/;" as the GetHiddenItems routine has a reference to YAML::Load. This was discovered while adding a GetHiddenItems() call into opac/opac-MARCdetail.pl. I believe this problem dates back to bug 6488 or bug 5984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:25:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:25:27 +0000 Subject: [Koha-bugs] [Bug 10838] Silence warnings in members/member.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10838 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:25:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:25:30 +0000 Subject: [Koha-bugs] [Bug 10838] Silence warnings in members/member.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10838 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20912|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20974&action=edit [PASSED QA] Bug 10838 : Silence warns in members/member.pl To test 1/ Uncomment the use warnings line 2/ Search for a patron, notice all the warnings 3/ Browse for a patron, notice warnings 4/ Apply patch 5/ Repeat 3 and 4 6/ Notice no errors and the search still works This depends on the patch for Bug 10835 Signed-off-by: Chris Cormack Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Passes all tests, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:45:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:45:23 +0000 Subject: [Koha-bugs] [Bug 10872] C4::Items GetHiddenItems fix and optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |mtompset at hotmail.com Summary|C4::Items.pm has YAML::Load |C4::Items GetHiddenItems |in GetHiddenItems but lacks |fix and optimization |use or require | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:48:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:48:52 +0000 Subject: [Koha-bugs] [Bug 10872] C4::Items GetHiddenItems fix and optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #2 from M. Tompsett --- It's not really an enhancement, as it should have been optimized in the first place. Changed to a "minor" bug as a result, since part of this wasn't even visible without another bug fix which is yet to come. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:50:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:50:37 +0000 Subject: [Koha-bugs] [Bug 10650] export merge-record.inc javascript into a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10650 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 22:50:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 20:50:40 +0000 Subject: [Koha-bugs] [Bug 10650] export merge-record.inc javascript into a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10650 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20914|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20975&action=edit [PASSED QA] Bug 10650 - export merge-record.inc javascript into a file Bug 9755 added a refactoring of records merge adding the include merge-record.inc. This include contains a block "mergejs" containing all JavaScript code that was in merge.tt. This patch exports this code into a js file. Translatable strings contained in this file are in merge-record-strings.inc. Test plan : - Put two records is a list - Go to this list and check the two records - Click on "Merge selected" - Click on next - Go to second source record - Click on a repeatable field => The field is added to destination record - Click on a subfield of a field existing in destination record => The subfield is added to destination record - Click on a non repeatable field existing in destination record => You get an alert and field is not added - Click on a subfield of a field not existing in destination record => You get an alert and subfield is not added - Click on Merge => Records are merged Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Passes tests and test plan, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 23:07:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 21:07:29 +0000 Subject: [Koha-bugs] [Bug 10810] Fix synopsis for -html option to overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 23:07:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 21:07:32 +0000 Subject: [Koha-bugs] [Bug 10810] Fix synopsis for -html option to overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20870|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20976&action=edit [PASSED QA] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl The synopsis for the -html option used to be: -html Output html to file but the argument to this option should actually be a directory, not a filename. This patch fixes the synopsis. To test: - Run perldoc misc/cronjobs/overdue_notices.pl - Check that the synopsis is as shown above - Apply this patch - Run perldoc misc/cronjobs/overdue_notices.pl - Check that - the synopsis asks for a directory, not a filename - that the description of the -html option further down in the perldoc now mentions the filename that the HTML file will be created with. Signed-off-by: Bernardo Gonzalez Kriegel Works as described. No koha-qa errors. If feeded with a filename -html option fails with many messages like print() on closed filehandle $html_fh at misc/cronjobs/overdue_notices.pl line 384. Perhaps it could be improved, but that was the old behavior. Signed-off-by: Katrin Fischer Improves documentation, no negative side effects found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 23:09:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 21:09:04 +0000 Subject: [Koha-bugs] [Bug 10071] language improvement for holds/transfers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10071 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 23:12:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 21:12:00 +0000 Subject: [Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is Inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 23:12:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 21:12:22 +0000 Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|campbellreidtait at gmail.com |kyle at bywatersolutions.com QA Contact|koha.sekjal at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 23:14:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 21:14:58 +0000 Subject: [Koha-bugs] [Bug 10872] C4::Items GetHiddenItems fix and optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 --- Comment #3 from M. Tompsett --- Created attachment 20977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20977&action=edit Bug 10872 - C4::Items GetHiddenItems fix and optimization There should be a: "require YAML;" or "use YAML qw/Load/;" as the GetHiddenItems routine has a reference to YAML::Load. This was discovered while adding a GetHiddenItems() call into opac/opac-MARCdetail.pl. I believe this problem dates back to bug 6488 or bug 5984. I also added an optimization to GetHiddenItems to prevent processing if there is nothing in the system preference. Test by searching for a biblio which has some or all of its items hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 23:27:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 21:27:06 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #77 from Katrin Fischer --- Continueing testing, but found something small: FAIL acqui/ajax-getauthvaluedropbox.pl OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 23:33:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 21:33:15 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #78 from Katrin Fischer --- Sorry, found something bigger: - Create 2 funds - use 2 authorized values for the first, none for the other. - Create an order, switch to first fund first. - The pull downs now show up correctly - don't touch them. - Realize you have picked the wrong fund, change it to the second. - Notice that the authorized value codes remain and the fields are not cleared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 10 23:57:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 21:57:50 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 --- Comment #14 from Bernardo Gonzalez Kriegel --- (In reply to Owen Leonard from comment #13) > Thanks to Katrin for pointing out the explanation for this: You probably > have a non-English template specified, whether intentionally or not. You > might need to clear your cookies? cait++ :-) Clean install, clean cookies, now it works, testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 00:41:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 22:41:36 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 00:56:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 22:56:47 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 01:28:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Sep 2013 23:28:14 +0000 Subject: [Koha-bugs] [Bug 3591] "Family administrator" account for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3591 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 03:58:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 01:58:14 +0000 Subject: [Koha-bugs] [Bug 10873] New: Lots of wasted space in Serial Search Result table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10873 Bug ID: 10873 Summary: Lots of wasted space in Serial Search Result table Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com /cgi-bin/koha/serials/serials-search.pl?routing=1&searched=1&title_filter= Users with low resolutions or small screens may have an issue where this table exceeds the width of their viewable area. There appears to be a lot of wasted space in the columns, perhaps we could reduce the amount of space allotted to some of those columns and make the experience a little more comfortable for these users. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 04:10:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 02:10:43 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |bgkriegel at gmail.com, | |gmcharlt at gmail.com --- Comment #15 from Chris Nighswonger --- Ok, the common denominator seems to be LCC numbers. This would seem to point to a recent change made to switch LCC splitting to Library::CallNumber::LC. The change was committed to master on 12 June 2013[1] and to the 3.10.x branch the next day [2]. I'm adding Galen and Bernardo to the cc list. Galen: feel free to correct my ignorant attempt at describing what appears to be happening here. According to the docs on L::CN::LC the module "is mostly designed to do call number normalization..." The operative word here is "normalization." The module docs state that the 'components' method used by the new code does this: "Get components suitable for printing (e.g., number and decimal joined, leading dot on first cutter)" Note the "leading dot on first cutter" statement. I think that what is happening is that call numbers passed into this method are first "normalized" which perhaps includes adding a leading dot to the first cutter. As for it returning all uppercase letters, that is most likely because L::CN::LC performs a 'uc()' on the number when the 'new' method is invoked. The exact code is 'callno => uc($lc)' And, indeed, this appears to my very untrained eye to meet the LC spec (if there is such a thing). [3] All of the examples given appear to "violate" the "spec" in some manner, and so suffer from various unexpected anomalies when run through the methods in this module. If this is the case, I'm not sure how to please all of the people some of the time. We probably need to have a wider discussion of the issue if this is true. Indeed, this is what appears to be happening when I run Labels_split_lccn.t on one of the sample CN's Nicole submitted. [4] The same number split fine under the old algorithm in 3.10.07 [5] Some of Howard's numbers do not claim to be LCCNs yet show a strangeness. The results of running one of the DDCNs through the LCCN test seem to indicate that all of his call numbers are being run through as LCCNs. [6] It so happens (by chance) that most DDCNs split fine under the LCCN split algorithm in 3.10.07. (Yes, I see the fail in there, but the split is fine none-the-less.) [7] The label code looks for the classification system in one of two places: either in the item "cn_source" (call number source) or the DefaultClassificationSource system preference (if the item cn_source is not populated). I would hazard a guess that the cn_source is not populated in the item records in his catalog and that the DefaultClassificationSource is set to 'lcc' which results in all of his call numbers being split as LCCNs. The text wrap issue in one of Howard's examples also appears to be victim of this change as the test shows which lends further support to my previous thought. [8] However, there may be other underlying issues with this as the text wrapping algorithm is not very sound. One might wonder why these problems did not show up when the test suite was run after this patch was committed. But the LCCN numbers included in the test suite are compliant with the "spec" and the test runs fine after the patch is applied. That accounts for some of the problem (ie. the LCCN weirdness). The other part of the problem (ie. "other" cataloging system call numbers weirdness) slipping by is probably hard to catch since libraries will run different configurations as well as use a multitude of variations on the theme of XYZ cataloging system. The bottom line is that we will probably have to have some discussion about whether to "fix" this problem and if the answer is "yes," how to "fix" it to most everyone's satisfaction. NOTES: [1] http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=edb8bddff074769a95744b6a7fa59eff61e0cfc1 [2] http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=56ea58ecda26f6ca4e4e8e437296b2aa2a2419d0 [3] http://en.wikipedia.org/wiki/Library_of_Congress_Classification [4] cnighswonger at cnighswonger-dt:~/Repositories/koha.3.2.labels/t (master)$ perl Labels_split_lccn.t 'Script H82 E45' 'Script,H82,E45' 1..11 ok 1 - use C4::Labels::Label; ok 2 - lccn: Script H82 E45 ok 3 - split expected to produce 3 pieces ok 4 - C4::Labels::Label::_split_lccn(Script H82 E45) not ok 5 - 6 of 3 pieces produced # Failed test '6 of 3 pieces produced' # at Labels_split_lccn.t line 56. ok 6 - (Script H82 E45)[0] populated: SCR not ok 7 - (Script H82 E45)[0] matches: Script # Failed test '(Script H82 E45)[0] matches: Script' # at Labels_split_lccn.t line 61. ok 8 - (Script H82 E45)[1] populated: .I not ok 9 - (Script H82 E45)[1] matches: H82 # Failed test '(Script H82 E45)[1] matches: H82' # at Labels_split_lccn.t line 61. ok 10 - (Script H82 E45)[2] populated: P not ok 11 - (Script H82 E45)[2] matches: E45 # Failed test '(Script H82 E45)[2] matches: E45' # at Labels_split_lccn.t line 61. # Looks like you failed 4 tests of 11. [5] cnighswonger at cnighswonger-dt:~/Repositories/koha.3.2.labels/t (v3.10.07)$ perl Labels_split_lccn.t 'Script H82 E45' 'Script,H82,E45' 1..11 ok 1 - use C4::Labels::Label; ok 2 - lccn: Script H82 E45 ok 3 - split expected to produce 3 pieces regexp failed to match string: Script H82 E45 at /home/cnighswonger/Repositories/koha.3.2.labels//C4/Labels/Label.pm line 126. ok 4 - C4::Labels::Label::_split_lccn(Script H82 E45) ok 5 - 3 of 3 pieces produced ok 6 - (Script H82 E45)[0] populated: Script ok 7 - (Script H82 E45)[0] matches: Script ok 8 - (Script H82 E45)[1] populated: H82 ok 9 - (Script H82 E45)[1] matches: H82 ok 10 - (Script H82 E45)[2] populated: E45 ok 11 - (Script H82 E45)[2] matches: E45 [6] cnighswonger at cnighswonger-dt:~/Repositories/koha.3.2.labels/t (master)$ perl Labels_split_lccn.t 'J 295.435 K56' 'J,295.435,K56' 1..11 ok 1 - use C4::Labels::Label; ok 2 - lccn: J 295.435 K56 ok 3 - split expected to produce 3 pieces ok 4 - C4::Labels::Label::_split_lccn(J 295.435 K56) ok 5 - 3 of 3 pieces produced ok 6 - (J 295.435 K56)[0] populated: J ok 7 - (J 295.435 K56)[0] matches: J ok 8 - (J 295.435 K56)[1] populated: 295.435 ok 9 - (J 295.435 K56)[1] matches: 295.435 ok 10 - (J 295.435 K56)[2] populated: .K56 not ok 11 - (J 295.435 K56)[2] matches: K56 # Failed test '(J 295.435 K56)[2] matches: K56' # at Labels_split_lccn.t line 61. # Looks like you failed 1 test of 11. [7] cnighswonger at cnighswonger-dt:~/Repositories/koha.3.2.labels/t (v3.10.07)$ perl Labels_split_lccn.t 'J 295.435 K56' 'J,295.435,K56' 1..11 ok 1 - use C4::Labels::Label; ok 2 - lccn: J 295.435 K56 ok 3 - split expected to produce 3 pieces regexp failed to match string: J 295.435 K56 at /home/cnighswonger/Repositories/koha.3.2.labels//C4/Labels/Label.pm line 126. ok 4 - C4::Labels::Label::_split_lccn(J 295.435 K56) ok 5 - 3 of 3 pieces produced ok 6 - (J 295.435 K56)[0] populated: J ok 7 - (J 295.435 K56)[0] matches: J ok 8 - (J 295.435 K56)[1] populated: 295.435 ok 9 - (J 295.435 K56)[1] matches: 295.435 ok 10 - (J 295.435 K56)[2] populated: K56 ok 11 - (J 295.435 K56)[2] matches: K56 [8] cnighswonger at cnighswonger-dt:~/Repositories/koha.3.2.labels/t (master)$ perl Labels_split_lccn.t 'DVD HOL Counterfeiters cop.3' 'DVD,HOL,Counte,rfeiters,cop.3' 1..15 ok 1 - use C4::Labels::Label; ok 2 - lccn: DVD HOL Counterfeiters cop.3 ok 3 - split expected to produce 5 pieces ok 4 - C4::Labels::Label::_split_lccn(DVD HOL Counterfeiters cop.3) not ok 5 - 6 of 5 pieces produced # Failed test '6 of 5 pieces produced' # at Labels_split_lccn.t line 56. ok 6 - (DVD HOL Counterfeiters cop.3)[0] populated: DVD ok 7 - (DVD HOL Counterfeiters cop.3)[0] matches: DVD ok 8 - (DVD HOL Counterfeiters cop.3)[1] populated: .H not ok 9 - (DVD HOL Counterfeiters cop.3)[1] matches: HOL # Failed test '(DVD HOL Counterfeiters cop.3)[1] matches: HOL' # at Labels_split_lccn.t line 61. ok 10 - (DVD HOL Counterfeiters cop.3)[2] populated: O not ok 11 - (DVD HOL Counterfeiters cop.3)[2] matches: Counte # Failed test '(DVD HOL Counterfeiters cop.3)[2] matches: Counte' # at Labels_split_lccn.t line 61. ok 12 - (DVD HOL Counterfeiters cop.3)[3] populated: L not ok 13 - (DVD HOL Counterfeiters cop.3)[3] matches: rfeiters # Failed test '(DVD HOL Counterfeiters cop.3)[3] matches: rfeiters' # at Labels_split_lccn.t line 61. ok 14 - (DVD HOL Counterfeiters cop.3)[4] populated: COUNTERFEITERS not ok 15 - (DVD HOL Counterfeiters cop.3)[4] matches: cop.3 # Failed test '(DVD HOL Counterfeiters cop.3)[4] matches: cop.3' # at Labels_split_lccn.t line 61. # Looks like you failed 5 tests of 15. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 04:25:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 02:25:53 +0000 Subject: [Koha-bugs] [Bug 10872] C4::Items GetHiddenItems fix and optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 06:12:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 04:12:39 +0000 Subject: [Koha-bugs] [Bug 10874] New: Incremental fine system for various types of documents and patron categories Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10874 Bug ID: 10874 Summary: Incremental fine system for various types of documents and patron categories Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: library.ltce at ltjss.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com bug 6873 (16 Sept 2011) is similar but not resolved till date. our library use this rules for fines and circulation: Circulation periods: books period: 30 days with 2 renewals max journals period: 14 days with 2 renewals max Fines: 1. fine after period, price A 2. fine 30th day after 1. fine, price B 3. fine 14th day after 2. fine, price C (2x price B) 4. fine 14th day after 3. fine, price D (3x price B) 5. next fines we count per day and item. Fine rates varies for patron categories as well as type of documnet. also bug 8776 and 10027 need to be solved as they are related to fine calculation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 07:36:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 05:36:56 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #16 from Howard Freedman --- Thanks so much for pursuing this, Chris. It is true that LCC is our default setting. Through a batch item modification tool, I just switched the classification source from LCC to Dewey in all of the titles for which we want to print spine labels. They now seem to come out fine, with the exception that "Counterfeiters" (in DVD HOL Counterfeiters cop.3) still does not break and goes on to the adjacent label. So the issue seems to be how you characterize it, although I'm disappointed that the breaking problem continues when the item is in Dewey as well. As we can now print labels again, I'm delighted... By the way, I also experimented with selecting the "Other/Generic" classification source option, and it puts the entire call # in a single line. Thanks, Howard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 09:37:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 07:37:41 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #79 from Jonathan Druart --- (In reply to Katrin Fischer from comment #78) > Sorry, found something bigger: > > - Create 2 funds - use 2 authorized values for the first, none for the other. > - Create an order, switch to first fund first. > - The pull downs now show up correctly - don't touch them. > - Realize you have picked the wrong fund, change it to the second. > - Notice that the authorized value codes remain and the fields are not > cleared. Yep, good catch, new patch coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 09:38:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 07:38:07 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 09:38:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 07:38:12 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20935|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart --- Created attachment 20978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20978&action=edit Bug 7180: Adapt neworderempty code (js function moved). The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link some av to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 09:38:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 07:38:17 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #81 from Jonathan Druart --- Created attachment 20979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20979&action=edit Bug 7180: FIX License version Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 09:51:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 07:51:52 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #13 from Sophie MEYNIEUX --- This patch is also needed for 3.8.x and 3.10.x versions. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 10:01:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 08:01:06 +0000 Subject: [Koha-bugs] [Bug 10875] New: addorderiso2709: the link "show all dunfs" is missing. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Bug ID: 10875 Summary: addorderiso2709: the link "show all dunfs" is missing. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org When adding an order from a staged file, there is no link "show all funds". All funds are displayed by default. We want to hide inactive funds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 10:01:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 08:01:19 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all dunfs" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |7180 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 10:01:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 08:01:19 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10875 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 10:03:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 08:03:24 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all dunfs" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 10:03:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 08:03:27 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all dunfs" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 --- Comment #1 from Jonathan Druart --- Created attachment 20980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20980&action=edit Bug 10875: Add order from a staged file should not display inactive funds When adding an order from a staged file, a link "show all funds" is now added on the top of the page. All inactive funds are hidden by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 10:17:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 08:17:23 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|addorderiso2709: the link |addorderiso2709: the link |"show all dunfs" is |"show all funds" is |missing. |missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 10:19:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 08:19:32 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #3 from Jonathan Druart --- Created attachment 20981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20981&action=edit Bug 10863: The lift restriction button should be hide on the moremember page This followup fixes 3 issues: - hide the lift restriction button on the moremember page is needed. - typo checkout => check out. - the force checkout permission does not affect high holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 10:20:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 08:20:34 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Jonathan Druart --- (In reply to Owen Leonard from comment #2) > This definitely needs (1) fixed, (2) while you're at it. (3) I could be > argued about if I misunderstand. Owen, Yes you are right on these 3 points. Thank you to catch them! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 10:39:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 08:39:11 +0000 Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 --- Comment #3 from Jonathan Druart --- Created attachment 20982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20982&action=edit Bug 10862: Followup: fix a couple of issues This followup fixes a couple of issues: - disable the feature by default. - use the datatables include file. - fix the syspref description. - replace "History search" with "Search history". - replace biblio with catalog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 10:40:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 08:40:43 +0000 Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Jonathan Druart --- (In reply to Owen Leonard from comment #2) > - Seems to be missing History.pm? > - Database update message refers to "MT12541" rather than Bug 10862. > - Typically new features like this are not enabled by default. > - Preference description says "...patron search history in the OPAC." It > should > say "staff client." > - catalogue/search-history.tt should use new datatables include file (Bug > 10649) > - The search history page title and breadcrumbs say "History search" where > it should say "Search history" > - I suggest that we use the term "catalog" instead of "biblio." "biblio" > isn't really a word in English, although we use it Koha some places. I think > naming the tabs "Catalog" and "Authority" would be clear: > > "Your catalog search history is empty." > "Delete your current catalog search history" > "Delete your previous catalog search history" Owen, Thanks for testing! The History.pm module is added by the bug 10807. All others requests are fixed in the followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 12:37:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 10:37:32 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #17 from Chris Nighswonger --- (In reply to Howard Freedman from comment #16) > Through a batch item modification tool, I just switched the classification > source from LCC to Dewey in all of the titles for which we want to print > spine labels. They now seem to come out fine, with the exception that > "Counterfeiters" (in DVD HOL Counterfeiters cop.3) still does not break and > goes on to the adjacent label. This is most likely due to the sorry splitting algorithm I wrote years ago. Generally it has done what was needed, but there are cases where it is clearly broken. It is on my list to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 13:37:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 11:37:59 +0000 Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for items "Waiting" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Severity|enhancement |normal --- Comment #1 from Nicole C. Engard --- Not sure this is an enhancement ... because a hold is allowed it's a bug. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 14:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 12:42:05 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17120|0 |1 is obsolete| | --- Comment #81 from Kyle M Hall --- Created attachment 20983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20983&action=edit Bug 7736 - Edifact QUOTE and ORDER functionality This is a patch brining together the original work by Mark Gavillet and the subsequent patches by Mark, Martin Renvoize and myself It contains the code as currently runnng in production In addition I've added updatedatebase entries to installer and replaced the hardcoded currency with a currency extraction. As the db currently does not force the standard codes we check if that is 3 uppercase ascii characters before using it. Elliott Davis: Added unit test for EDI Zeno Tajoli: Rebased on last master git tree. I have change only the file installer/data/mysql/sysprefs.sql Added missing end tag for tools-home.tt Brendan Gallagher: Rebased on current master Changed installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Bug 7736 - Edifact QUOTE and ORDER functionality - Followup - cordinate this with template tools-home.tt After the writting of the patch, the template tools-home.tt has a little change. I have have tested the ench wit instruction and I confirm that works. Attention on dir misc/edi_files, you need to give permission to koha and to web server user (standard: www-data on debian) Signed-off-by: Zeno Tajoli -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 14:42:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 12:42:16 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17121|0 |1 is obsolete| | --- Comment #82 from Kyle M Hall --- Created attachment 20984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20984&action=edit Bug 7736 - Edifact QUOTE and ORDER functionality - Followup - Fix UI Issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 14:57:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 12:57:06 +0000 Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- (In reply to Jonathan Druart from comment #4) > The History.pm module is added by the bug 10807. Whoops, sorry--I missed the dependency! Now that I can test it for real I see a couple more things: 1) search-history.tt lacks [% INCLUDE 'doc-head-open.inc' %] at the top of the page 2) Not blocking, but strange: If my search returns one hit and I'm redirected to the detail page for that title the search doesn't appear in my history. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 14:57:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 12:57:34 +0000 Subject: [Koha-bugs] [Bug 10876] New: opac-MARCdetail.pl display items intended for hiding Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 Bug ID: 10876 Summary: opac-MARCdetail.pl display items intended for hiding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org The opac/opac-MARCdetail.pl file is what is viewed when "MARC view" is clicked while viewing a specific search result. Items hidden on opac/opac-detail.pl based on OpacHiddenItems are shown! This should not happen. I believe this bug goes back several versions, not just master. While coding this, a lack of use or require in C4::Items was discovered. See bug 10872. By adding calls to GetItemsInfo and GetHiddenItems, a filter on the items is placed. As this is processing MARC data, GetMarcFromKohaField was used to properly determine what the item number (952$9) is. Test Plan ========= 1) Find a biblio with multiple items. (e.g. a book with multiple branches) 2) Look it up in OPAC 3) View the details. 4) In the staff client, set the OpacHiddenItems system preference to hide some of the data. (e.g. homebranch: [BRANCH2HIDE]) 5) Refresh the OPAC 6) Some of the details should be hidden now. Save this URL for later (e.g. http://..../opac-detail.pl?biblionumber=#####) 7) Click the MARC view. 8) All the items are showing. 9) Apply patch from 10872 10) Apply this patch 11) Refresh the OPAC 12) The MARC view should now only show the same things the normal view shows. 13) In the staff client hide all the items for this record using OpacHiddenItems. (e.g. homebranch: [BRANCH1,BRANCH2,BRANCH3]) 14) Refresh the OPAC 15) There should be a "404.pl" displayed. 16) Paste the URL saved in step 6. 17) There should be a "404.pl" displayed. 18) In the staff client blank the OpacHiddenItems system preference. 19) Paste the URL saved in step 6. 20) All the items should be displayed in normal view. 21) Click the MARC view and all the items should be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 15:03:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 13:03:45 +0000 Subject: [Koha-bugs] [Bug 10876] opac-MARCdetail.pl display items intended for hiding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 --- Comment #1 from M. Tompsett --- Created attachment 20985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20985&action=edit Bug 10876 - MARC view displays what should be hidden The opac/opac-MARCdetail.pl file is what is viewed when "MARC view" is clicked while viewing a specific search result. Items hidden on opac/opac-detail.pl based on OpacHiddenItems are shown! This should not happen. I believe this bug goes back several versions, not just master. While coding this, a lack of use or require in C4::Items was discovered. See bug 10872. By adding calls to GetItemsInfo and GetHiddenItems, a filter on the items is placed. As this is processing MARC data, GetMarcFromKohaField was used to properly determine what the item number (952$9) is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 15:04:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 13:04:55 +0000 Subject: [Koha-bugs] [Bug 10876] MARC view displays what should be hidden In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10872 Assignee|oleonard at myacpl.org |mtompset at hotmail.com Summary|opac-MARCdetail.pl display |MARC view displays what |items intended for hiding |should be hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 15:04:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 13:04:55 +0000 Subject: [Koha-bugs] [Bug 10872] C4::Items GetHiddenItems fix and optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10876 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 15:43:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 13:43:30 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20963|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 20986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20986&action=edit bug clean ubuntu docs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 15:44:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 13:44:42 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20986|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 20987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20987&action=edit bug clean ubuntu docs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 16:11:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 14:11:12 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 16:11:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 14:11:15 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20951|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 20988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20988&action=edit [SIGNED-OFF] Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 16:11:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 14:11:25 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20952|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 20989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20989&action=edit [SIGNED-OFF] Bug 10807: FIX if zebra is down, total is undef The search_history.total column cannot be undef. This patch adds a default value for the total value. Signed-off-by: Owen Leonard This change doesn't negatively affect search history as far as I can tell but I also can't reproduce the bug it is meant to fix, so take this signoff with a grain of salt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 16:12:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 14:12:05 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #7 from Owen Leonard --- Created attachment 20990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20990&action=edit Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 16:26:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 14:26:40 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #18 from Galen Charlton --- I have filed a feature request for Library::CallNumber::LC - https://code.google.com/p/library-callnumber-lc/issues/detail?id=7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 16:49:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 14:49:04 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #19 from Chris Nighswonger --- Marking this bug as wontfix since it is not really a problem with Koha's code, but with the underlying module we rely on to do LCCN splitting. Galen has opened a bug request with the module's author so any fix should trickel down to us from there. Howard: Please add a note to bug 2499 regarding the wrapping problem. Be sure to include the example from here. Thanks for everyone's help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 16:50:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 14:50:34 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- Testing this again, I realize that there is a bigger problem with the checkout of high hold items: If the staff member doesn't have force_checkout permission they can't check out an item with high holds at all. There should be a "check out/don't check out" option but there isn't. I would also like to suggest a change in wording for the permission. Instead of "Force checkout if a limitation exists," how about "Override blocked checkouts." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 11 16:56:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Sep 2013 14:56:10 +0000 Subject: [Koha-bugs] [Bug 10871] Confirmation message for deleting news entries is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- This doesn't work for me, and I think we've seen this before. If you have the _() function inside an onclick attribute it doesn't work. One solution is to define a variable to pass to the function. Example in virtualshelves/shelves.tt (line 618): The other solution would be to move everything into a This is correct here, but the upload_delete_file.tt needs the same change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 06:19:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 04:19:20 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #122 from M. Tompsett --- Comment on attachment 21432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21432 [SIGNED-OFF] Bug 6874: File upload in MARC Review of attachment 21432: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6874&attachment=21432) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +3202,5 @@ > +-- > +-- Table structure for table uploaded_files > +-- > + > +DROP TABLE IF EXISTS uploaded_files This line is missing a semi-colon. @@ +3211,1 @@ > ) ENGINE=InnoDB DEFAULT CHARSET=utf8; This line should be copied to 3201. ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/upload_delete_file.tt @@ +3,5 @@ > + > + > + Upload plugin > + > + This should be [% interface %] not, [% themelang %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 06:21:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 04:21:09 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #123 from M. Tompsett --- $ giz bz apply 6874 Had to fix up installer/data/mysql/updatedatabase.pl Had to install new dependency for this. $ koha_perl_deps.pl -m -u Listed new requirement (hence revised PerlDependencies.pm checked) $ sudo apt-get install libtest-cgi-multipart-perl Did the database upgrade by starting staff client. $ prove -v t/db_dependent/UploadedFiles.t everything passed. $ ~/qa-test-tools/koha-qa.pl -v 2 -c 10 (I forgot how many patches were applied, so I just said 10) No problems with this set of patches. Noticed POD updates unrelated to patches (C4::Biblio) Probably required to get C4::Biblio to pass QA tool tests. New files include: C4/UploadedFiles.pm cataloguing/value_builder/upload.pl koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/upload.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/upload_delete_file.tt opac/opac-retrieve-file.pl t/db_dependent/UploadedFiles.t Did a opac-detail view, which means the "use C4::Biblio" isn't broken. There are 1,2,3,4,5,6,6a,6b,7,8,9 changes in C4::Biblio $ perldoc C4::Biblio This triggers 2,7,8,9 Refresh of opac-detail page triggers 3,4 Home -> administration -> Marc frameworks -> BKS framework structure -> tag 856 subfield structure -> edit subfields contraint -> advanced -> plugin = upload.pl Attempted to use plug in without configuring koha-conf.xml Correctly gave feedback. $ mkdir ~/uploads $ sudo chown www-data.www-data ~/uploads add in /home/mtompset/uploads Link a file into some biblio entry. Go to opac detail for it: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=14206 Triggers 1,3,4,5 In order to trigger 6, 6a, and 6b, GetMarcUrls needs to be called with something other than MARC21. I couldn't figure out how to do that. I'm attempting a UNIMARC installation. I used https://www.dropbox.com/s/idw98d7jiy5e5xd/dump_unimarc.zip as mentioned by Mathieu Saby in his August 20th email "pending bugs about UNIMARC marc flavor". Linked upload.pl uploaded a dummy file for a known biblio record. went to opac and did an opac detail view of it. (6, 6a) unlinked upload.pl refreshed opac detail page (6, 6b) testing to continue later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:25:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:25:34 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20900|0 |1 is obsolete| | --- Comment #103 from Jonathan Druart --- Created attachment 21462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21462&action=edit Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information ("Import All" and "Accounting details" areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the "Stage MARC records for import" tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the "planning values" too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the "Accounting details" area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price => listprice = 0 else => - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:25:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:25:41 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20901|0 |1 is obsolete| | --- Comment #104 from Jonathan Druart --- Created attachment 21463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21463&action=edit Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:25:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:25:46 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20902|0 |1 is obsolete| | --- Comment #105 from Jonathan Druart --- Created attachment 21464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21464&action=edit Bug 7180: Add UT for C4::Budgets::GetBudgetByCode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:25:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:25:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20903|0 |1 is obsolete| | Attachment #21004|0 |1 is obsolete| | --- Comment #106 from Jonathan Druart --- Created attachment 21465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21465&action=edit Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:25:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:25:57 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20904|0 |1 is obsolete| | --- Comment #107 from Jonathan Druart --- Created attachment 21466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21466&action=edit Bug 7180: The default quantity is 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:26:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:26:03 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20933|0 |1 is obsolete| | --- Comment #108 from Jonathan Druart --- Created attachment 21467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21467&action=edit Bug 7180: Follow-up fixing minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:26:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:26:08 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20934|0 |1 is obsolete| | --- Comment #109 from Jonathan Druart --- Created attachment 21468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21468&action=edit Bug 7180: Change syspref description - the blank line is now useless - add an example for the syspref value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:26:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:26:18 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20978|0 |1 is obsolete| | --- Comment #110 from Jonathan Druart --- Created attachment 21469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21469&action=edit Bug 7180: Adapt neworderempty code (js function moved). The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link some av to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:26:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:26:24 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20979|0 |1 is obsolete| | --- Comment #111 from Jonathan Druart --- Created attachment 21470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21470&action=edit Bug 7180: FIX License version Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:26:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:26:30 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #112 from Jonathan Druart --- Created attachment 21471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21471&action=edit Bug 7180: QA followup - fix unit tests (use a transaction). - add 3 tabs on the page in order to be more understandable. - fix a warn in logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:26:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:26:35 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21014|0 |1 is obsolete| | --- Comment #113 from Jonathan Druart --- Created attachment 21472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21472&action=edit Bug 7180 - QA Followup - Correct minor language issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:26:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:26:41 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21017|0 |1 is obsolete| | --- Comment #114 from Jonathan Druart --- Created attachment 21473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21473&action=edit Bug 7180: Restore the "Add order" link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:26:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:26:46 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21117|0 |1 is obsolete| | --- Comment #115 from Jonathan Druart --- Created attachment 21474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21474&action=edit Bug 7180: Remove useless rrp variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:51:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:51:02 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 --- Comment #15 from mathieu saby --- Currently, coded fields are not supported. So they probably won't be in the first version of the patch. The perl code that uses "mappings" array must be improved later for that. And we could add something like mapping:["UNIMARC":["101a0","101a2","101a3-4"] for map positions 0, 2, 3-4 of 101a. I add an other idea : give the choice to "group" some facets. For that I can add a value "hierarchicallabel" in each facets For ex, for facet "Author (people)": "label": "Author (people)" "hierarchiclabel": ["Author","(people)"] And add a syspref for choosing which kind of label is to be used. So, with hierarchiclabel, you could have facets like that on OPAC or intranet: *Location* - Branches ... - Shelving location ... *Authors - People ... - Organizations ... Would you like it? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 09:52:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 07:52:13 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #116 from mathieu saby --- I am testing it on sandbox 3, thank you for the rebasing. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 10:15:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 08:15:00 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #117 from mathieu saby --- Well, Pierre Angot is testing, I let him work on that. But I will make 2 UX remark : - in syspref description or example, we need to know the list of the data that could be mapped with MARC (Not only price, budget_code and quantity as shown on the example, but also sort1,sort2,discount) - in the syspref description, or in the online help, we need to know too which kind of "price" is supposed to be "price" (vendor catalog price? rrp price?). For us who are testing it's not a big issue, but once it is pushed, it could cause great problems if the average librarian understand it the wrong way (and there are maaaany ways to misunderstand Koha price management). M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 10:25:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 08:25:17 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16792|0 |1 is obsolete| | --- Comment #83 from Zeno Tajoli --- Created attachment 21475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21475&action=edit Instructions to test the patch and how-to use the feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 10:43:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 08:43:45 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #132 from Jonathan Druart --- (In reply to Galen Charlton from comment #131) > I think it would be better to drop the notion of using a string eval at all > and just rewrite ModifyRecordWithTemplate to become a dispatcher that calls > the modification subroutines directly. I say "just rewrite" because, for > once, I think the work can be confined to a single routine. > > Also, the patchset currently includes no tests that run > ModifyRecordWithTemplate directly -- rather a lack, IMO. Resolving that can > go hand-in-hand with removing the eval. I will try to do something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:08:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:08:11 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by C?dric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:08:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:08:23 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20947|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:08:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:08:29 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 21476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21476&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: C -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:15:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:15:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #118 from mathieu saby --- Discount are not taken into account. I put "10" in 966$d field and map it with "discount" in syspref. In the table for this record in "addorderiso2709.pl", I see "discount: 10" I saved the form In the resulting order, the discount is "9.00000" So the standard discount for the vendor applied, instead of the discount defined in the record. Is it normal or not (I suppose not)? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:19:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:19:18 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Just a reminder that controlfields in MARC21 have no subfields :) 101a3-4 can work for UNIMARC, but the syntax is maybe not ideal for MARC21. I think that can be solved later tho. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:19:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:19:49 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #119 from mathieu saby --- 2 other issues (the same as when I tested some days ago) - Koha is still adding VAT to price taken in the order, even if the vendor is defined with "list price include tax" - a unitcost is still calculated. It must not be. Everywhere in Koha unitcost is the real cost define at receipt, never when ordering. So I failed QA. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:23:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:23:04 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 --- Comment #17 from mathieu saby --- Oh yes, I know... That's why DOM indexing was broken with Unimarc. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:25:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:25:12 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #124 from Katrin Fischer --- Hi Mark, could you describe a bit what you tested on the pages? The numbers make your test plan quite cryptic to read. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:27:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:27:13 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #40 from Christophe Croullebois --- As I said, it's ok for me. Signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:28:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:28:42 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 cedric.vita at dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cedric.vita at dracenie.com --- Comment #62 from cedric.vita at dracenie.com --- The patch works with the note circulation in the borrower record, the note appears. But in the note off the borrower record "Add a new message"(circulation.pl?borrowernumber=XXX), the note is not displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:28:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:28:47 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21274|0 |1 is obsolete| | --- Comment #41 from Christophe Croullebois --- Created attachment 21477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21477&action=edit patch signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:31:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:31:09 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #63 from Katrin Fischer --- I think that is ok - the messages notes system was added later and I think it did never show up in the table. This could go on a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:34:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:34:38 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #133 from Ketan Kulkarni --- Created attachment 21478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21478&action=edit Double encoding utf8 problem Use of utf8::upgrade() instead of utf8::encode() appears to be working. While taking inputs, they should be decoded first whereas output should always be encoded. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:35:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:35:08 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:41:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:41:25 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #42 from Koha Team Lyon 3 --- Hey Christophe I posted this one the same minute as yours and there was a collision !. I saw you just signed off but here is my comment nevertheless : I tested the string you told of ('25.5 EUR, $US32, $LD35') with symbol='$US' in a separated perl script, and I get 32 as expected, same for $LD. But I know that testing this import into koha may not be so easy. May be some cache issues caused by testing in a loop or test file with encoding errors ? For me, the important thing is that if the string is not found the returned price must be 0. ( better not price at all than a false one) Anyway, I could not swear it will cover whatever kind of price string but if it can deal with main part of not too screwy ones, you are welcome to sign it off. Oliver C. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:49:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:49:47 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #25 from M. de Rooy --- Created attachment 21479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21479&action=edit Bug 9788: Followup removing the alldates parameter Before bug 9788 the alldates parameter of GetReservesFromItemnumber was actually not used in the codebase. The first patch of bug 9788 did change that and passed true by default. But a closer look revealed that we do not really need it. The parameter is removed by this patch; the SQL statement is slightly adjusted: if reservedate<=now or a waitingdate is filled for the requested itemnumber, GetReservesFromItemnumber will return the reserve. This includes so-called future waits: a future hold that has been confirmed ahead of time with pref ConfirmFutureHolds > 0 days. Note that future item-level holds are not really interesting to return; this just corresponds to original behavior. Future next-available holds are not in view at all; they do not contain an item number. Test plan: Actually, the test plan of the first patch is valid. But for completeness I repeat it here: [1] Enable future holds and set ConfirmFutureHolds to 2 days. [2] Place a future next-available hold for 2 days ahead. [3] Check item status on catalogue detail. Available? That is fine. [4] Confirm the future hold by checking it in. ('future wait') [5] Look at item status again on catalogue detail. Must be Waiting now. [6] Switch to OPAC and login as another opac user. Goto Place a hold. [7] Check item status with item level hold info. Is it waiting? [8] Try to place hold in staff, check item level status again. Waiting? [9] Make a transfer for the item. Switch branch. Check hold status on Transfers to receive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:50:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:50:50 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Pierre Angot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #11 from Pierre Angot --- Is it a duplicate of 9780 ? It seems redundant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:50:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:50:54 +0000 Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used in some order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Pierre Angot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #24 from Pierre Angot --- Is it a duplicate of 10869 ? It seems redundant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:51:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:51:35 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |amitddng135 at gmail.com Assignee|amit.gupta at osslabs.biz |amitddng135 at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:51:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:51:49 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:51:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:51:52 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9761, 9367 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:51:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:51:52 +0000 Subject: [Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9788 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:51:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:51:52 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9788 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:52:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:52:21 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:53:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:53:12 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #12 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:53:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:53:26 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21295|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:53:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:53:32 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #13 from sandboxes at biblibre.com --- Created attachment 21480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21480&action=edit Bug 10869: Allow the deletion of order line if the record is deleted This patch fixes 2 issues : (medium issue) It is not possible to delete an order in a basket if the biblio record is deleted. (minor issue) There is a useless hyperlink around "Deleted bibliographic notice", and "notice" is a frenchism for "record" I had to change the behavior of Acquisitions::DelOrder (which is used only by addorder.pl file), a line in addorder.pl, and a few lines in template basket.tt. To test : 1. Fill a basket with some records (some records with items or holds, some without items) 2. Supress one of the record 3. In the basket (refresh the screen) check that "Deleted bibliographic notice" line was replaced with "Deleted bibliographic record", without hyperlink arround 4. Delete this order with the link "Delete order" to the right column of the table 5. Check there is a new line in the "Deleted orders" table 6. Check there is no regression : felete an other order (one with no item), then check you cannot delete an order with an item (like before patch) Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:55:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:55:10 +0000 Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used in some order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #25 from mathieu saby --- Not really 10869 fixes a bug in basket pages 9780 prevent a dangerous behavior in catalog pages Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:58:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:58:10 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #14 from mathieu saby --- Note : this patch is a bugfix, that should be applied to maintenance versions of Koha. But I also made an other patch with I consider as an ENH, which improves the behavior : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 (which depends on 10869, so it can't be signed off on a sandbox) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:58:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:58:31 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #15 from mathieu saby --- And thank you C?dric! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 11:59:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 09:59:48 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #18 from mathieu saby --- Note : Bug 10869 has been signed off. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 12:30:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 10:30:51 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #26 from M. de Rooy --- Created attachment 21481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21481&action=edit Bug 9788: Unit tests for changed routine GetReservesFromItemnumber Adds three tests to Reserves.t for GetReservesFromItemnumber. We test if this routine does not return a future next available hold, a future item level hold. And if it does return a future wait (that is: a confirmed future hold, using ConfirmFutureHolds). Note that Holds.t does also contains some basic tests for this routine, but the additional tests seem to better located in the direct context of tests for bug 9761 for ConfirmFutureHolds. Test plan: Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t. Verify if both tests do not fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 12:32:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 10:32:09 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9761 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 12:32:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 10:32:09 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9788 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 12:33:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 10:33:00 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 12:41:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 10:41:45 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #27 from M. de Rooy --- With the patch for 9761 pushed, this bug should be considered as just a minor bugfix. I have changed the severity accordingly. I added two patches now: One patch removes an actually superfluous alldates parameter from GetReservesFromItemnumber. All calls have been changed likewise. Note that behavior changes very slightly (only when using ConfirmFutureHolds) and goes back more to original behavior since future item level holds are not reported now (as it was). The second patch adds three tests for this routine to Reserves.t. Running Holds.t is recommended too. The report was in Signed off state as from June 21 (so three months passed). I will set it back to Needs Signoff, since the additional two patches need a signoff. Hopefully, this gets some attention soon though.. The extra patches should help convince QA/RM :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 12:51:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 10:51:04 +0000 Subject: [Koha-bugs] [Bug 10952] New: Store anonymous search history in session Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Bug ID: 10952 Summary: Store anonymous search history in session Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Storing search history into cookie can cause problems, due to the size limitation of 4KB. The solution here is to store search history into the CGI::Session object, so there is no size limitation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 12:52:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 10:52:11 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #1 from Julian Maurice --- Created attachment 21482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21482&action=edit Bug 10952: Store anonymous search history in session Storing search history into cookie can cause problems, due to the size limitation of 4KB. The solution here is to store search history into the CGI::Session object, so there is no size limitation (but anonymous search history still remember up to 15 requests max.) Test plan: - Go to OPAC in anonymous mode. - Check that the "Search history" link is *not* shown in the top right corner of the page - Make some searches on /cgi-bin/koha/opac-search.pl - The "Search history" link must appear. Click. - Your search history must be displayed. - Try to log in with invalid username/password - Go back to search history, it's still there - Now log in with valid username/password - Your anonymous search history must be saved into your own search history. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 12:52:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 10:52:20 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 12:52:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 10:52:27 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 12:56:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 10:56:38 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #17 from Julian Maurice --- Hi all, I think this bug is only due to the cookies size limitation and the way Koha handle them (or maybe the problem comes from Apache or the web browser I don't know), but it is not specific to this patch. So I wrote a patch to store anonymous search history into CGI::Session instead of cookies. Please see Bug 10952 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 13:14:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 11:14:38 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #134 from Ketan Kulkarni --- I have another patch ready which is an enhancement over the earlier patch I submitted. How can I discard the older patch and add a new one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 13:23:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 11:23:05 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #135 from M. de Rooy --- (In reply to Ketan Kulkarni from comment #134) > I have another patch ready which is an enhancement over the earlier patch I > submitted. How can I discard the older patch and add a new one? You can obsolete a patch manually by clicking Details. With git-bz you can do it more or less automatically.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 13:23:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 11:23:38 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 --- Comment #8 from Kyle M Hall --- (In reply to Jonathan Druart from comment #7) > QA comment: > > It works as described but it does not deal with the debarred date. > I don't know how to do but I think the patch should manage it. > > Marked as Passed QA. Jonathan, can you please explain what you mean when you write you think this patch should managed the debarred date? I have no idea what you might mean be that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 14:21:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 12:21:03 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #125 from M. Tompsett --- Comment on attachment 21432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21432 [SIGNED-OFF] Bug 6874: File upload in MARC Review of attachment 21432: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6874&attachment=21432) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +37,4 @@ > use C4::Charset; > use C4::Linker; > use C4::OAI::Sets; > +use C4::UploadedFiles; This is C4::Biblio Change 1. @@ +1908,4 @@ > > =head2 GetMarcUrls > > + $marcurls = GetMarcUrls($record,$marcflavour,$frameworkcode); This is C4::Biblio Change 2. @@ +1919,5 @@ > + my ( $record, $marcflavour, $frameworkcode ) = @_; > + > + my $tagslib = &GetMarcStructure(1, $frameworkcode); > + my $urltag = '856'; > + my $urlsubtag = 'u'; This block is C4::Biblio Change 3. @@ +1924,3 @@ > > my @marcurls; > + for my $field ( $record->field($urltag) ) { This is C4::Biblio Change 4. @@ +1927,5 @@ > my @notes; > for my $note ( $field->subfield('z') ) { > push @notes, { note => $note }; > } > + my @urls = $field->subfield($urlsubtag); This is C4::Biblio Change 5. @@ +1956,3 @@ > $marcurl->{'part'} = $s3 if ($link); > $marcurl->{'toc'} = 1 if ( defined($s3) && $s3 =~ /^[Tt]able/ ); > } else { This begins C4::Biblio Change 6. @@ +1956,5 @@ > $marcurl->{'part'} = $s3 if ($link); > $marcurl->{'toc'} = 1 if ( defined($s3) && $s3 =~ /^[Tt]able/ ); > } else { > + if ($tagslib->{ $urltag }->{ $urlsubtag }->{value_builder} eq "upload.pl" > + and $url =~ /id=([0-9a-f]+)/) { Inside this IF is C4::Biblio Change 6a. @@ +1963,5 @@ > + $marcurl->{'linktext'} = $field->subfield('2') > + || C4::Context->preference('URLLinkText') > + || $file->{filename}; > + $marcurl->{'MARCURL'} = $url; > + } else { Inside this ELSE is C4::Biblio Change 6b. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 14:24:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 12:24:52 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #126 from M. Tompsett --- Comment on attachment 21433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21433 [SIGNED-OFF] Bug 6874: QA follow-up Review of attachment 21433: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6874&attachment=21433) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +1446,4 @@ > =head2 GetMarcPrice > > return the prices in accordance with the Marc format. > + I ignored white space while labeling changes. @@ +3395,5 @@ > =head2 CountBiblioInOrders > > +=over > + > +=item $count = &CountBiblioInOrders( $biblionumber); This is C4::Biblio change 7. @@ +3419,5 @@ > =head2 GetSubscriptionsId > > +=over > + > +=item $subscriptions = &GetSubscriptionsId($biblionumber); This is C4::Biblio change 8. @@ +3443,5 @@ > =head2 GetHolds > > +=over > + > +=item $holds = &GetHolds($biblionumber); This is C4::Biblio change 9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 14:26:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 12:26:08 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #127 from M. Tompsett --- I hope that clarifies the complete testing of the C4::Biblio changes that I have done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 14:49:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 12:49:06 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #128 from Katrin Fischer --- Hi Mark, actually I was more thinking about some 'non-programmer' notes about testing the actual functionality :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 15:03:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 13:03:26 +0000 Subject: [Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- I think client side checking is a good first step and we could open a new bug for the server side to also fix that. I think 'not null' would make sense, I am not so fond of the automatic 'report X' as this is another possible translation issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 15:15:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 13:15:30 +0000 Subject: [Koha-bugs] [Bug 10905] Author tracings incorrect when UseAuthoritiesForTracings is turned on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10905 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 15:21:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 13:21:36 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 15:21:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 13:21:39 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #4 from Owen Leonard --- Created attachment 21483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21483&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 15:54:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 13:54:14 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 15:54:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 13:54:19 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21371|0 |1 is obsolete| | --- Comment #133 from Jonathan Druart --- Created attachment 21484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21484&action=edit Bug 8015: Get rid of the eval in ModifyRecordWithTemplate This patch removes the use of eval in the C4::MarcModificationTemplates::ModifyRecordWithTemplate routine. Now this routine call the wanted modification routine with the list of parameters. This call is done only if the condition is respected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 15:54:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 13:54:27 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #134 from Jonathan Druart --- Created attachment 21485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21485&action=edit Bug 8015: Get rid of eval for evaluating =~ m// Koha::SimpleMarc::field_equals uses eval in order to check if a string matches a pattern. Now this eval is removed and the "regex" variable does not contain the regex separated character (/ or |). Regression: Before this patch, the user was able to user a modifier. Now it is not possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 15:54:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 13:54:33 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #135 from Jonathan Druart --- Created attachment 21486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21486&action=edit Bug 8015: Get rid of the eval for substitution Before this patch, the regex substitution was contain into only one variable (e.g. my $regex = "/foo/bar/i"). Now each member of the regex is stored into a field in the marc_modification_template_actions sql table. In order to avoid a complex code, only modifiers i and g are take into account. Note: If you already add the mmta table, you have to drop it. This patch also adds a foreign key from mmta to mmt tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 15:54:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 13:54:39 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #136 from Jonathan Druart --- Created attachment 21487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21487&action=edit Bug 8015: FIX ui issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 15:56:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 13:56:38 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #137 from Jonathan Druart --- These 4 last patches remove the eval. All 19 patches pass qa tools. Test plan: - Retest *all* the feature with complex actions. - prove t/SimpleMarc.t - prove t/db_dependent/MarcModificationTemplates.t Have fun and good luck! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 16:02:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 14:02:36 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 16:17:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 14:17:09 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 --- Comment #9 from Jonathan Druart --- (In reply to Kyle M Hall from comment #8) > (In reply to Jonathan Druart from comment #7) > > QA comment: > > > > It works as described but it does not deal with the debarred date. > > I don't know how to do but I think the patch should manage it. > > > > Marked as Passed QA. > > Jonathan, can you please explain what you mean when you write you think this > patch should managed the debarred date? I have no idea what you might mean > be that. You had rectified, it was not "Passed QA", but "Failed QA". In fact it is especially for discussion, I will try to explain: If I specify a hard due date with now - 1 day and I check in today, the patron is debarred until now + 3 days (in the issuing rules: Suspension in days(=3) * 1). If I specify a hard due date with now - 30 days and I specify a return date of the day after (now - 29 days), what about the suspension delay? Currently, the patron is suspended until now + 29*3 days. I am not sure it is relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 16:20:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 14:20:19 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Jonathan Druart --- As Julian said, I am not sure the problem is from this patch. I think the issue already exists in master. Switch back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 16:28:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 14:28:08 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #2 from Julian Maurice --- Increasing severity to major as its more a bugfix than an enhancement (cf bug 10807) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 16:44:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 14:44:29 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 16:50:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 14:50:22 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #136 from Ketan Kulkarni --- Created attachment 21488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21488&action=edit utf8 double encoding problem enhancement Search, patron pages, patron search, facets need to be tested with different languages. I have done testing on Devnagari input (Marathi). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 16:58:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 14:58:46 +0000 Subject: [Koha-bugs] [Bug 4166] No way to know what keywords to use for Keyword Mapping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4166 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr at software.coop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 17:00:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 15:00:05 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Hm so I think the point is that when you backdate a return, not only the fine needs to be adjusted, but also the 'fines in days' that is how many days the user is debarred? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 17:07:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 15:07:56 +0000 Subject: [Koha-bugs] [Bug 10953] New: Missing subtitle fieldmapping unless you use ru-RU or uk-UA Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10953 Bug ID: 10953 Summary: Missing subtitle fieldmapping unless you use ru-RU or uk-UA Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: mjr at software.coop QA Contact: testopia at bugs.koha-community.org Steps to Reproduce: 1. View an opac-detail Normal view page Actual Results: subtitle is not displayed. Expected Results: subtitle should be displayed. Additional Information: To fix after installation for English MARC21: a. visit Home ? Administration ? Keyword to MARC mapping b. enter Field name subtitle, tag 245, subfield b c. click Submit I suggest that this should be added to a fieldmapping.sql in marc21/optional similar to those for ru-RU and uk-UA. Bug 4166 is a related problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 17:35:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 15:35:28 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #129 from M. Tompsett --- Fear not. :) I'll be getting to less programmer oriented testing instructions. The programmer oriented instructions are a matter of proving that the code changes introduced do not cause any problems by triggering all the code points. Now, back to testing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 17:47:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 15:47:47 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #130 from M. Tompsett --- Created attachment 21489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21489&action=edit Bug 6874 - Patch kohastructure.sql issues follow up Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:22:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:22:01 +0000 Subject: [Koha-bugs] [Bug 10954] New: Payment receipt does not display the payment made Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954 Bug ID: 10954 Summary: Payment receipt does not display the payment made Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 21490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21490&action=edit Pre-Patch Receipt When printing a payment receipt, the payment does not display, only the total currently owed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:22:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:22:21 +0000 Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the payment made In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954 --- Comment #1 from Kyle M Hall --- Created attachment 21491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21491&action=edit Post-Patch Receipt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:23:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:23:01 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #28 from Galen Charlton --- (In reply to Jonathan Druart from comment #23) > This patch will be in conflict with bug 8367. Can you expand on what sort of conflict? Just a merge conflict that would be resolvable with more or less effort, or conflicting notions of the desired functionality or implementation thereof? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:24:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:24:10 +0000 Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the payment made In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:24:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:24:12 +0000 Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the payment made In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954 --- Comment #2 from Kyle M Hall --- Created attachment 21492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21492&action=edit Bug 10954 - Payment receipt does not display the payment made When printing a payment receipt, the payment does not display, only the total currently owed. Test Plan: 1) Create a payment for a borrower 2) Print the payment with the "print" button to the right of the payment 3) Note the missing payment line 4) Apply this patch 5) Repeat step 2 6) Note the payment line now displays -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:26:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:26:04 +0000 Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the payment made In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:26:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:26:16 +0000 Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the payment made In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:39:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:39:58 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #3 from Galen Charlton --- Haven't looked at the patch in detail, but +1 to the notion of storing it in the session. I do wonder if there should be a limit on the number of searches kept though -- while there is no specific limit on the amount of data that can be stored in a session, consider the case of a public OPAC station that doesn't get reset often. In principle, it could end up with a session that carries hundreds of searches, which might have a notable impact on performance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:47:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:47:04 +0000 Subject: [Koha-bugs] [Bug 10955] New: Add ability to skip deletions in zebraqueue Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955 Bug ID: 10955 Summary: Add ability to skip deletions in zebraqueue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It seems that record deletions can cause extreme slowdowns for Koha installations with extremely large numbers of records. It would be helpful to be able to skip record deletions when processing the zebraqueue with rebuild_zebra.pl so the deletions can be processed with a lower frequency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:50:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:50:09 +0000 Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955 --- Comment #1 from Kyle M Hall --- Created attachment 21493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21493&action=edit Bug 10955 - Add ability to skip deletions in zebraqueue It seems that record deletions can cause extreme slowdowns for Koha installations with extremely large numbers of records. It would be helpful to be able to skip record deletions when processing the zebraqueue with rebuild_zebra.pl so the deletions can be processed with a lower frequency. Test Plan: 1) Disable any zebra indexing cronjobs you may have 2) Delete a record 3) Note the operation recordDelete in the zebraqueue table having done = 0 4) Run misc/migration_tools/rebuild_zebra.pl -b -z --skip-deletes 5) Note the delete still has done = 0 6) Run misc/migration_tools/rebuild_zebra.pl -b -z 7) Note the delete now has done = 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:50:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:50:06 +0000 Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 18:50:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 16:50:17 +0000 Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 19:11:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 17:11:09 +0000 Subject: [Koha-bugs] [Bug 10956] New: Series of OPAC searches can cause a browser crash Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10956 Bug ID: 10956 Summary: Series of OPAC searches can cause a browser crash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org In my tests this series of OPAC searches will result a browser crash (Firefox) or an endlessly loading tab (Chrome): 1. Perform a keyword search which will return a good number of results. 2. Click on a title in those results which will have a good number of works by that author. 3. Click on the author link on the detail page to perform a search by author. 4. Click on a facet on the author search results page (I tested by clicking on a library facet). 5. Click on a title in the refined search results. I've tested this procedure with XSLT on and off, with OpacBrowseResults on and off, and with EnableOpacSearchHistory on and off. I get the same results in both themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 19:12:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 17:12:07 +0000 Subject: [Koha-bugs] [Bug 10956] Series of OPAC searches can cause a browser crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10956 --- Comment #1 from Owen Leonard --- More info: The bug appears to affect master and 3.12.x but not 3.10.x. I couldn't reproduce the problem in the staff client following the same steps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 19:48:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 17:48:48 +0000 Subject: [Koha-bugs] [Bug 10957] New: 710$a with 710$b (subordinate unit) present shows wrong (XSLT) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10957 Bug ID: 10957 Summary: 710$a with 710$b (subordinate unit) present shows wrong (XSLT) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 21494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21494&action=edit sample If both 710$a and 710$b are present they are pasted together without punctuation or space between. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:02:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:02:26 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21157|0 |1 is obsolete| | --- Comment #39 from Jared Camins-Esakov --- Created attachment 21495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21495&action=edit Bug 10240: Offline circulation using HTML5 and IndexedDB This patch adds an HTML5-based offline mode to Koha's existing circulation module, allowing librarians to check out items using a basically familiar interface. The feature will be implemented using the Application Cache and IndexedDB features of the HTML5 specification, both of which are fully supported on Firefox 10+ and Chrome 23+, with limited support going back to Firefox 4 and Chrome 11. The basic workflow enabled by this patch is as follows: Part 1: While connected to the Internet 1. Enable offline functionality by turning on the "AllowOfflineCirculation" system preference. 2. Sync the offline circulation database on the computer that will be used for offline circulation by following the "Offline circulation interface" link on the Circulation home page, choosing "Synchronize (must be online)", and clicking the "Download records" button. This process may take a while. 3. Bookmark /cgi-bin/koha/circ/offline.pl (the page you are currently on) for easy access when offline. Part 2: While disconnected from the Internet 4. Navigate to /cgi-bin/koha/circ/offline.pl using the bookmark you created while online. 5. Start checking books in by scanning the barcode of an item that has been returned into the box in the "Check in" tab. 6. Scan the barcodes of any additional items that have been returned. 7. Start checking out books to a patron by scanning the patron's barcode in the box in the "Check out" tab. 8. Set a due date (the "Remember for session" box will be checked by default, since circulation rules are not computed during offline transactions and therefore a due date must be specified by the librarian). 9. Scan an item barcode (if you did not set a due date, it will prompt you) to check the item out to the patron. 10. If a patron has a fine you can see the total amount (current to when the offline module was synced), and record a payment. Unlike when in online mode, there will be no breakdown of what item(s) fines are for, and you will only be able to record the payment amount and not associate it with a particular item. Part 3: While connected to the Internet 11. Click the "Synchronize" link and choose "Upload transactions" to upload the transactions recorded during the offline circulation session. 12. Navigate to /cgi-bin/koha/offline_circ/list.pl (there will be a link from the Offline circulation page) and review the transactions, as described in the documentation for the Firefox Offline circulation plugin: http://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:02:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:02:35 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21158|0 |1 is obsolete| | --- Comment #40 from Jared Camins-Esakov --- Created attachment 21496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21496&action=edit Bug 10240 QA follow-up Address the following issues: 1/ Address minor qa issues with the templates: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 24) [etc.] OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 509) [etc.] FAIL tt_valid lines 5, 5 2/ Run perltidy on new scripts 3/ download.pl returns data.finished = 1 if number of returned data < 5000 (avoids 1 ajax call) 4/ Replace qq{} around sql queries with q{} Also, a race condition existed that resulted in pending transactions only getting deleted from the local database in certain circumstances (fast connections under Chrome, mostly). This patch fixes that so that successfully-uploaded transactions are always deleted. This patch also addresses Jonathan's suggestion: 3/ add a message on check in (currently the input becomes empty but the user is not informed). ... and Magnus's suggestion about moving the Synchronize link to the right on the homepage. Also, this addresses the further issues Jonathan noted: - The tab of checkouts always shows "*0* Checkouts" - If I am not well-educated, I click on the "Check out" link on the offline home page, I enter a barcode, click on "Check out" and I get a js error (without user message): "TypeError: curpatron is undefined" (with chromium I get: Numeric transaction modes are deprecated in IDBDatabase.transaction. Use "readonly" or "readwrite"). - There is a "border-right" css rule on the h5.patron-title. It is display when there is no patron selected) [really minor!]. - tables are displayed even if there is no data - The "Clear screen" link (X) points to an old script: circ/offline-circulation.pl - There is a warning when clicking on the "Synchronize" link when the user is offline, but not for the "Pending offline circulation actions" link. - Still exists: > The "Checked in item." message text never disappear (even if I go on the > offline home page (circ/offline.pl#offline-home)). Finally, this patch adds a link to the Pending offline operations page on the synchronize page for easier navigation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:02:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:02:41 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21159|0 |1 is obsolete| | --- Comment #41 from Jared Camins-Esakov --- Created attachment 21497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21497&action=edit Bug 10240 follow-up: don't delete transactions if auth fails When uploading transactions, we were not checking that authentication had succeeded before deleting the transactions from the local database. That was bad. With this patch, we check. That is good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:02:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:02:46 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21160|0 |1 is obsolete| | --- Comment #42 from Jared Camins-Esakov --- Created attachment 21498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21498&action=edit Bug 10240 follow-up: fix display Fix the following two issues: 1) After paying a fine when offline the fine amount becomes NaN. 2) For previous checkouts for a pratron the title and barcode fields have the wrong infomation in them (i.e. they have been swapped) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:02:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:02:51 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21161|0 |1 is obsolete| | --- Comment #43 from Jared Camins-Esakov --- Created attachment 21499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21499&action=edit Bug 10240 follow-up: disable logout/set library Logging out/setting the library does not work while using offline mode, so it makes no sense to present those options to the user. Much better is some sort of explanatory message informing them that those two links don't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:02:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:02:58 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #44 from Jared Camins-Esakov --- Created attachment 21500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21500&action=edit Bug 10240: warn when patron's card is expired This patch improves the alert messages to be slightly better English and warns the librarian if a patron's card has expired. Like all alerts, this is non-fatal since in the case of network failure there is no particular reason to expect that the offline database is current. To test this particular patch you can try checking something out to an expired patron, otherwise test plan remains the same as above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:19:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:19:19 +0000 Subject: [Koha-bugs] [Bug 10957] 710$a with 710$b (subordinate unit) present shows wrong (XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10957 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:19:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:19:23 +0000 Subject: [Koha-bugs] [Bug 10957] 710$a with 710$b (subordinate unit) present shows wrong (XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10957 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 21501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21501&action=edit Bug 10957: 710$a with 710$b (subordinate unit) present shows wrong (XSLT) This patch fixes a visualization problem with XSLTs for 710$a and 710$b in both Intranet and OPAC interfaces, on both search results and detail pages. To test: - Create two bibliographic records. a) One with only 710$a b) One with 710$a and 710$b - Do a search on OPAC and Intranet and see 710$a and 710$b are put together without a space in the middle. - Enter the detail page (in both interfaces) and see the problem is present there too. - Apply the patch - It should look as expeced. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:25:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:25:19 +0000 Subject: [Koha-bugs] [Bug 10957] 710$a with 710$b (subordinate unit) present shows wrong (XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10957 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:33:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:33:54 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #131 from M. Tompsett --- Set up VM from scratch (include qa-test-tools, git-bz [fishsoup branch], koha origin/master branch) $ git checkout -b bug_6874 origin/master $ git bz apply 6874 $ perl Makefile.PL $ make $ make test $ make install Remember to set up some useful data after you get a working Koha. :) Configure patch - edit koha-conf.xml and make sure to fill in (e.g. /home/mtompset/uploads) - make sure to give that directory correct permissions (e.g. sudo chown www-data.www-data /home/mtompset/uploads) - attach the plug-in to the 856$u subfield (e.g. - log in to staff client - click 'Koha administration' - click 'MARC bibliographic framework' - click 'MARC structure' for a framework - Find the 856 tag - click 'Subfields' - Find the 'u' subfield - click 'Edit' - click 'Other options (choose one)' - select 'upload.pl' in the Plugin drop-down - click 'Save changes') You will want to test in both MARC21 and UNIMARC systems. $ ./koha_perl_deps -m -u $ perldoc C4::Biblio $ perldoc C4::UploadedFiles This will trigger all the functions in C4::UploadedFiles $ prove -v t/db_dependent/UploadedFiles.t Once you have a bilio with 856$u linked up to a file, go to the same biblio on the OPAC. (e.g. http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=14206) Then unlink the upload.pl plugin and refresh the OPAC. This latter step is necessary to test a secondary code point under UNIMARC. In the staff client, find a biblio. Add it to your cart. Click the cart at the top of the page. This will test opac-retrieve-file.pl fully: While at the OPAC detail page for the item added - Click the 'Online resources:' URL. 1) It should work. - Delete the file from the filesystem. (e.g. sudo rm /home/mtompset/uploads/*) - Click the 'Online resources:' URL. 2) It should fail. - Open up MySQL and delete the record from the uploaded_files table. 3) It should fail. - Make sure to clear the 856$u entry for that biblio manually and save. opac-detail.pl change is tested just by viewing the details of the biblio with an 856$u link. opac-basket.pl change is tested by adding the item to your cart and clicking the "Cart" button. To test the template files, it is a matter of doing a lot of upload, delete, upload, whatever type tests in the staff client. This has not been fully tested, but there are some issues that I want to test to the point of being able to say what is wrong and how I was expecting it to be handled. I'm beginning to run short of testing time today again. However, I am pretty confident that I have tested the following thoroughly: C4/Biblio.pm C4/Installer/PerlDependencies.pm C4/UploadedFiles.pm basket/basket.pl etc/koha-conf.xml installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl opac/opac-basket.pl opac/opac-detail.pl opac/opac-retrieve-file.pl t/db_dependent/UploadedFiles.t Patches with updatedatabase.pl in them need to be rebased. I have already attached an extra patch to correct issues in kohastructure.sql I will continue my testing later of: catalogue/MARCdetail.pl catalogue/detail.pl cataloguing/value_builder/upload.pl koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/upload.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/upload_delete_file.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:34:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:34:52 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com --- Comment #6 from Blou --- Created attachment 21502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21502&action=edit Add forgot password link to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:43:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:43:31 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |philippe.blouin at inlibro.com Assignee|gmcharlt at gmail.com |eric.begin at inLibro.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 20:59:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 18:59:19 +0000 Subject: [Koha-bugs] [Bug 10958] New: no need for home link on home page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 Bug ID: 10958 Summary: no need for home link on home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org On the OPAC there is a Home link on the top left it makes no sense and a lot of libraries are asking to have it removed, but if I remove it with JS I lose the breadcrumbs on every page. Can we get rid of the home link on the home page? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 21:01:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 19:01:50 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #2 from Blou --- Created attachment 21503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21503&action=edit BibTeX export now includes MARC21 main entry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 21:05:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 19:05:07 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #3 from Blou --- Patch attached -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 21:17:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 19:17:49 +0000 Subject: [Koha-bugs] [Bug 10958] no need for home link on home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 --- Comment #1 from Owen Leonard --- I'm not rejecting the idea of this bug, but why not make your JS more specific so that it only targets the home page? $("#opac-main #breadcrumbs").hide(); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 21:18:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 19:18:00 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 21:24:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 19:24:06 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Eric B?gin --- How to test : - Search any books in the OPAC with a main entry (1XX in MARC21, 700-720 in Unimarc) - Export the record in the bibtex format ? The output won't contains the main entry. ---- Apply the patch - Export the record The output file will contain the main entry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 21:33:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 19:33:01 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #7 from Blou --- TEST PLAN: 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. That will cause the link 'Forgot your password' to show up on the welcome page, below connection box. 3) refresh front page, click on 'Forgot your password' and enter a VALID address (one that is associated to an entry in borrowers.email or borrowers.email_pro. 3b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 4) An email should be received at that address with a link. 5) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 6) Go to main page try the new password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 21:36:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 19:36:25 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 21:47:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 19:47:49 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21503|0 |1 is obsolete| | --- Comment #5 from Blou --- Created attachment 21504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21504&action=edit Fix marc2bibtex to consider fields 1xx on author. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 21:48:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 19:48:35 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 21:57:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 19:57:40 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #137 from Josef Moravec --- I've just tried the last patch in sandbox, but unfortunately, it doesn't work for me. In fact, there are another pages broken after applying patch. (e.g. edit patron categories page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 22:00:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 20:00:38 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #6 from Eric B?gin --- Sponsored-by: Institut universitaire en sant? mentale de Montr?al -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 22:26:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 20:26:07 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #2 from Galen Charlton --- Thanks for the patch. I should point out that nowadays it is very common for this sort of minor tweak to be handled using jQuery entered in (in this case) the OPACUserJS system preference. Here is a specific example on the wiki for changing the login help, which accomplishes the intent of this patch without requiring that a new system preference be added. http://wiki.koha-community.org/wiki/JQuery_Library#Change_Login_Help -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 22:46:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 20:46:43 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- See http://wiki.koha-community.org/wiki/System_Preferences for information on adding system preferences. You forgot to modify installer/data/mysql/updatedatabase.pl and installer/data/mysql/kohastructure.sql, but you did get the appropriate .pref file. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 26 23:54:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 21:54:51 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 --- Comment #18 from mathieu saby --- Created attachment 21505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21505&action=edit config page design I've almost finished the config page. But for the moment it is parsing an harcoded json string, not yet in a syspref. And these new facets are not used by opac and staff search. Here is how it will look. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 00:14:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 22:14:28 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 --- Comment #19 from Katrin Fischer --- Comment on attachment 21505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21505 config page design It looks quite nice! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 00:55:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 22:55:03 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #4 from Robin Sheat --- I think having a syspref for this is better, as not everyone runs javascript. My only issue with the idea is that it makes it harder to be language aware. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 01:18:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Sep 2013 23:18:36 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 --- Comment #5 from Owen Leonard --- A more long-term and internationalization-friendly (and complicated) solution would be to build a generalized framework for entering multiple text blocks in a Koha News-style interface tied to available languages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 03:44:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 01:44:20 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #138 from Ketan Kulkarni --- Hello Joseph, Could you please attach a screenshot the broken "edit patron categories" page. I am unable to reproduce the problem after the latest update. i.e. the last patch. Screenshot of any other page showing the problem will also do. Regards, Ketan (In reply to Josef Moravec from comment #137) > I've just tried the last patch in sandbox, but unfortunately, it doesn't > work for me. In fact, there are another pages broken after applying patch. > (e.g. edit patron categories page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 04:34:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 02:34:01 +0000 Subject: [Koha-bugs] [Bug 10075] Extend CGI to provide a param_utf8_decode method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10075 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ketan at carvingit.com --- Comment #3 from Ketan Kulkarni --- I am working on a related bug - 6554. utf decoding needs to be done in a few places. Would be great if people submit more ideas/preferences here. Ketan (In reply to M. de Rooy from comment #2) > I do not oppose to this idea, but have some questions: > Why not use -utf8 on CGI? > Should you really add a no_decode parameter? It is a rather complicated way > of using CGI without this wrapper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 05:43:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 03:43:21 +0000 Subject: [Koha-bugs] [Bug 8871] many warnings for 'perl -w ./C4/Reserves' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8871 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ketan at carvingit.com --- Comment #1 from Ketan Kulkarni --- Modules like C4::Members C4::Circulation C4::Accounts C4::Letters have use Reserve; in them. And C4::Reserve in turn uses the above modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 07:26:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 05:26:53 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #139 from Josef Moravec --- Created attachment 21506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21506&action=edit Edit patron categories after patch 21488 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 07:30:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 05:30:47 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #140 from Josef Moravec --- I've just uploaded the screenshot. But there is a weird issue... After night, on the same sandbox setup, the problem with catron categories somehow disappeared, but after new setup, with the same parameters, the problem again appeared. Problem on the members home page is still the same. (In reply to Ketan Kulkarni from comment #138) > Hello Joseph, > > Could you please attach a screenshot the broken "edit patron categories" > page. I am unable to reproduce the problem after the latest update. i.e. the > last patch. > > Screenshot of any other page showing the problem will also do. > > Regards, > Ketan > > (In reply to Josef Moravec from comment #137) > > I've just tried the last patch in sandbox, but unfortunately, it doesn't > > work for me. In fact, there are another pages broken after applying patch. > > (e.g. edit patron categories page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:01:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:01:45 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- We've had a longer discussion about this on IRC last night. I agree with both Owen and Robin. We actually should find a better way than sysprefs - one that allows you to offer the ocntent in multiple languages. But as long as we don't have that this system preference could be really helpful. I know a lot of people who turn off Javascript on websites - a system preference allows to always display a text and you can toggle it with jQuery between languages then (I am using different div blocks with a language class). It's not perfect, but a little better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:16:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:16:30 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:28:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:28:51 +0000 Subject: [Koha-bugs] [Bug 10959] New: Processing of pending orders table should be done server side Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10959 Bug ID: 10959 Summary: Processing of pending orders table should be done server side Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Loading the pending orders page is extremely slow and expensive when you have a lot of pending orders (5,884 on my system). The processing of the table should be done server side, not client side. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:29:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:29:55 +0000 Subject: [Koha-bugs] [Bug 10959] Processing of pending orders table should be done server side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:32:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:32:28 +0000 Subject: [Koha-bugs] [Bug 10725] Add filters on the pending orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725 --- Comment #4 from Katrin Fischer --- Created attachment 21507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21507&action=edit [PASSED QA] Bug 10725: Add filters on the pending orders table Since the parcel.pl script get *all* pending orders, there is no reason not to display all of them. Like that, DataTable manages pagination and sorting correctly (on all data). This patch adds filters on the table header (using columnFilter). Test plan: Try filters on the left of the screen and filters on the table header. Signed-off-by: Pierre Angot Signed-off-by: Katrin Fischer Passes all tests and QA script. Searching and sorting the table works correctly. Larger result sets are a performance problem on this page, I have filed bug 10595 for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:33:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:33:19 +0000 Subject: [Koha-bugs] [Bug 10725] Add filters on the pending orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:33:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:33:21 +0000 Subject: [Koha-bugs] [Bug 10725] Add filters on the pending orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21350|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:44:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:44:09 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #79 from Katrin Fischer --- Working on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:44:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:44:50 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 --- Comment #20 from Fr?d?ric Demians --- Sweet! In a brave new worlds, it would be great to split facets definition and facet layout in OPAC/intra. So: - Section 1: a table with your current columns, except both columns Order - Section 2: a ordered list of OPAC facets - Section 3: a ordered list of intra facets This way you could avoid showing the facet display order, which isn't that much user-friendly. You could use jQuery UI 'sortable' widget. For example: http://jqueryui.com/sortable/#empty-lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:49:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:49:05 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 --- Comment #21 from Katrin Fischer --- I think Jared has done a drag and drop for the sorting of the search result plugins. Maybe this could be helpful if you want to do the drag and drop. But it might be an issue with accessibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 08:57:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 06:57:54 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Stefano Bargioni changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bargioni at pusc.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 11:52:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 09:52:04 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 --- Comment #23 from Julian Maurice --- Created attachment 21508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21508&action=edit Bug 10856: Fix cover display in shelf browser This is an attempt to fix the bug discovered by Galen. I think I have enabled all "cover image" syspref and all seems to work well, but please test! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 13:10:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 11:10:05 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #141 from Ketan Kulkarni --- Thank you Josef for uploading the screenshot. We are getting closer :-) The problem is thus. Now, the data coming from the db appears ok. e.g. patron names, category names etc. However, the templates are not rendered as they should be. Let me see how we can fix this. Ketan (In reply to Josef Moravec from comment #140) > I've just uploaded the screenshot. > > But there is a weird issue... After night, on the same sandbox setup, the > problem with catron categories somehow disappeared, but after new setup, > with the same parameters, the problem again appeared. > > Problem on the members home page is still the same. > > > (In reply to Ketan Kulkarni from comment #138) > > Hello Joseph, > > > > Could you please attach a screenshot the broken "edit patron categories" > > page. I am unable to reproduce the problem after the latest update. i.e. the > > last patch. > > > > Screenshot of any other page showing the problem will also do. > > > > Regards, > > Ketan > > > > (In reply to Josef Moravec from comment #137) > > > I've just tried the last patch in sandbox, but unfortunately, it doesn't > > > work for me. In fact, there are another pages broken after applying patch. > > > (e.g. edit patron categories page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 13:34:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 11:34:19 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #24 from Jonathan Druart --- Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 13:48:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 11:48:22 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #142 from Ketan Kulkarni --- Created attachment 21509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21509&action=edit The template problem with utf8 For non-latin templates, almost all pages need to be seen along with the patron categories page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 14:01:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 12:01:01 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 --- Comment #22 from mathieu saby --- (In reply to Fr?d?ric Demians from comment #20) > Sweet! > > In a brave new worlds, it would be great to split facets definition and > facet layout in OPAC/intra. So: > > - Section 1: a table with your current columns, except both columns > Order > - Section 2: a ordered list of OPAC facets > - Section 3: a ordered list of intra facets Good idea, in 3 tabs. > > This way you could avoid showing the facet display order, which isn't > that much user-friendly. You could use jQuery UI 'sortable' widget. For > example: > > http://jqueryui.com/sortable/#empty-lists I'll look at it. What I need is something to re-sort the table in real time when sbdy click on the link for changing the order. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:04:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:04:12 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21460|0 |1 is obsolete| | --- Comment #7 from Blou --- Created attachment 21510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21510&action=edit Bug 10951 - Adding NoLoginInstructions to system preferences On a failed login, the default message is harcorded into opac-auth.tt. It would be preferable to allow for a preference to override that message (for example: ...Please bring an ID to the front desk located on 3rd floor...) The changes modify -opac-auth.tt to allow for custom value -admin/preferences/opac.pref to add it to the preferences with a description -C4/Auth.pm for the loading of the preference TESTING 1) in OPAC, logged out, try login in by entering no or wrong credentials. Acknowledge the "Don't have a passord yet?" message 2) Apply the patch 3) Regression Test: Redo step 1. Same (default) message should appear. 4) Log in to intranet, - select NoLoginInstructions in system preferences. - Enter new (xml) message. Possible:
Welcome to Koha, please bring your passport to the front office
- and save 5) refresh the OPAC, try login again with invalid credentials. The new message should appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:06:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:06:45 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|eric.begin at inLibro.com |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:12:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:12:22 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 --- Comment #8 from M. Tompsett --- Thank you for noting the updatedatabase.pl missing part, but you still forgot installer/data/mysql/kohastructure.sql which is important for fresh installs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:15:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:15:52 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21504|0 |1 is obsolete| | --- Comment #7 from Blou --- Created attachment 21511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21511&action=edit Add fields 1xxx to marc2bibtex Amended the last commit message to follow the standards. Redid the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:16:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:16:55 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 --- Comment #9 from Katrin Fischer --- I think the file Mark means is syspref.sql - if you had changed the database structure it would go in kohastructure.sql, but for a system preference we only need an entry in sysprefs.sql :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:23:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:23:24 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21502|0 |1 is obsolete| | --- Comment #8 from Blou --- Created attachment 21512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21512&action=edit Add forgot password link to OPAC The commit message has been updated to match the standards. Sponsor added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:37:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:37:49 +0000 Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the 'status' option switch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21242|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 21513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21513&action=edit Added the PID parameter to daemon as it failed to check SIP servers were running otherwise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:46:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:46:36 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- One observation during testing: - From search results, select multiple records and click the place hold button - Select the "a specific copy" option for one of the titles. - Select the "a specific copy" option for another one -- instead of it displaying the copies for that title, it instead display an alert whose text is "Expecting a specific copy selection". I wouldn't expect that alert to occur prior to attempting to place the holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:49:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:49:53 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #7 from Galen Charlton --- (In reply to Galen Charlton from comment #6) > One observation during testing: > > - From search results, select multiple records and click the place hold > button > - Select the "a specific copy" option for one of the titles. > - Select the "a specific copy" option for another one -- instead of it > displaying the copies for that title, it instead display an alert whose text > is "Expecting a specific copy selection". > > I wouldn't expect that alert to occur prior to attempting to place the holds. Further testing shows, however, that this was occurring before the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:53:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:53:25 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #120 from Jonathan Druart --- (In reply to mathieu saby from comment #118) > Discount are not taken into account. > Is it normal or not (I suppose not)? No, there is a bug, the discount value was divided by 100 twice. A followup coming. (In reply to mathieu saby from comment #119) > 2 other issues (the same as when I tested some days ago) > > - Koha is still adding VAT to price taken in the order, even if the vendor > is defined with "list price include tax" with the following: - syspref: price: 947$c - a biblio with 947$c=100 - a supplier with "list price include tax = 0", I got a rrp (include tax) = 94.79 (gst is 5.5%). - a supplier with "list price include tax = 1", I got a rrp (include tax) = 100 It is what is expected. See the test plan, step 6. > - a unitcost is still calculated. It must not be. Everywhere in Koha > unitcost is the real cost define at receipt, never when ordering. The unitcosts can be filled when ordering, so I don't considered that as an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:54:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:54:13 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 16:54:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 14:54:17 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #121 from Jonathan Druart --- Created attachment 21514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21514&action=edit Bug 7180: FIX: discount was divided by 100 twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:05:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:05:30 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard --- Looks like this requires an update to the database, but I don't see any changes in updatedatabase.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:08:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:08:18 +0000 Subject: [Koha-bugs] [Bug 10960] New: Holds Queue Report display loc code not description Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10960 Bug ID: 10960 Summary: Holds Queue Report display loc code not description Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The holds queue report is displaying the loc code in the call number column rather than the description. This can be very confusion depending on the codes a library is using. I found this in 3.10 as well as 3.12 Ed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:14:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:14:00 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #8 from Galen Charlton --- Comment on attachment 21416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21416 Bug 10836 - New layout for placing holds in the OPAC Review of attachment 21416: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10836&attachment=21416) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt @@ +184,5 @@ > + var optionsID = this.id.replace("toggle-hold-options-",""); > + var copiesRow = $("#copiesrow_"+optionsID) > + $("#hold-options-"+optionsID).toggle(0, function() { > + if( copiesRow.is(':visible') ){ > + $("#reqany_"+optionsID).prop("checked",true); I'm not sure about this -- if you expand options, choose to select a specific copy, then hide the options (say, because you're placing several holds at once and want to reclaim screen real estate), the request type gets silently changed to a title hold. Is there a reason to do that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:14:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:14:20 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 --- Comment #10 from Blou --- Created attachment 21515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21515&action=edit Second patch to the bug, contains sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:15:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:15:33 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21515|0 |1 is obsolete| | --- Comment #11 from Blou --- Created attachment 21516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21516&action=edit Bug 10951 - Second patch to the bug, contains sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:19:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:19:22 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 --- Comment #12 from Blou --- Live and learn. I now have to do that for my other patches. If there's a standard/preference when naming a second patch, please let me know. git-bz throws me error so I'm doing it all manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:23:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:23:04 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #9 from Galen Charlton --- (In reply to Galen Charlton from comment #8) > I'm not sure about this -- if you expand options, choose to select a > specific copy, then hide the options (say, because you're placing several > holds at once and want to reclaim screen real estate), the request type gets > silently changed to a title hold. Is there a reason to do that? Looks like moving the copy table into the hold options div eliminates the need for special code to hide the copy table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:42:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:42:46 +0000 Subject: [Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff --- Comment #13 from M. Tompsett --- Just apply the 3.8.x patches to 3.8.x for testing. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:57:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:57:00 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:57:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:57:05 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21416|0 |1 is obsolete| | --- Comment #10 from Galen Charlton --- Created attachment 21517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21517&action=edit Bug 10836 - New layout for placing holds in the OPAC This patch changes the layout of the OPAC's place hold screen, eliminating the table in favor of a more flexible, open display. To test, place single and multiple holds under various conditions: - Items which are not available to be place on hold - With OpacHoldNotes on and off - With OPACItemHolds on and off - With OPACAllowHoldDateInFuture on and off - With IndependentBranches on and off - With JavaScript disabled Test setting hold notes, holding specific copies, and setting hold start dates. When setting a hold start date and hold expiration date, the two datepickers should work together to prevent invalid date combinations (dates after today, expiration dates which precede the start date). Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:57:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:57:17 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #11 from Galen Charlton --- Created attachment 21518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21518&action=edit Bug 10836: (follow-up) improve display toggles on the OPAC hold request form This patch improves the the toggles for displaying and hiding the hold options div and the toggles for displaying the table of specific copies to request. It also moves the copy table into the hold options div. To test: [1] Select a single title in the OPAC and click on the place hold button. [2] Click 'Show more options', and select a specific copy to request. [3] Click 'Hide options'. Verify that the hold options, including the copy table, are hidden. [4] Click 'Show more options'. Verify that the specific copy radio button is still selected and that the copy selected in step to is selected. [5] Enable DisplayMultiPlaceHold and select several titles to request. [6] Do steps 2, 3, and 4 on various titles on the request form. Verify that toggling the options link for one title on the form affects the visibility only for that title. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 17:58:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 15:58:11 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #12 from Galen Charlton --- I've attached a follow-up that addresses my concerns with the display toggling. I want another pair of eyes on the follow-up; either a QA person or Owen can do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 18:23:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 16:23:35 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Srdjan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 18:39:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 16:39:27 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21518|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 21519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21519&action=edit [SIGNED-OFF] Bug 10836: (follow-up) improve display toggles on the OPAC hold request form This patch improves the the toggles for displaying and hiding the hold options div and the toggles for displaying the table of specific copies to request. It also moves the copy table into the hold options div. To test: [1] Select a single title in the OPAC and click on the place hold button. [2] Click 'Show more options', and select a specific copy to request. [3] Click 'Hide options'. Verify that the hold options, including the copy table, are hidden. [4] Click 'Show more options'. Verify that the specific copy radio button is still selected and that the copy selected in step to is selected. [5] Enable DisplayMultiPlaceHold and select several titles to request. [6] Do steps 2, 3, and 4 on various titles on the request form. Verify that toggling the options link for one title on the form affects the visibility only for that title. Signed-off-by: Galen Charlton Signed-off-by: Owen Leonard While signing off I removed one
tag and corrected a float in the CSS. This helps keep the border between individual hold listings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 18:40:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 16:40:42 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 18:42:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 16:42:49 +0000 Subject: [Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 18:53:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 16:53:29 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #132 from M. Tompsett --- initial state: blank, no records in uploaded_files, no files on filesystem. click plug in icon - expected window pops up. click submit query with nothing clicked. - nothing happens, refreshes as expected. click submit query with root selected - nothing happens, refreshes as expected. click browse, but cancel - nothing happens as expected click browse and choose a file - file name appears as expected click submit query with root not selected - "Error: Failed to upload file. See logs for details." current state: file is uploaded, but database is blank. checked error logs jquery.js issue and "Use of uninitialized $dir" error. click Close. delete file from file system. make sure the jquery.js line in upload.tt has interface not themelang click plug in icon - expected window pops up click browse and choose a file - file name appears as expected click submit query with root not selected - "Error: Failed to upload file. See logs for details." ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ FIX REQUESTED: I was expecting to have a refresh of the page with perhaps a "You forgot to select a location" in red, just above/beside/below the "Choose where to upload file". I was also expect to NOT have the file uploaded. This disconnect between the file existing and the record not existing in the database leads to weird problems. ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ click Close. delete file from file system. click plug in icon - expected window pops up click browse and choose a file - file name appears as expected click root - NOTE: I was lazy and didn't create subdirectories in this testing. click submit query - happy it worked kind of message click close - URL is filled in nicely. Not finished fully testing, but I thought I'd mention this problem since I found it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 18:53:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 16:53:28 +0000 Subject: [Koha-bugs] [Bug 10961] New: Error in GetMarcBiblio can cause severe data loss Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 Bug ID: 10961 Summary: Error in GetMarcBiblio can cause severe data loss Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org A bug in GetMarcBiblio can cause severe data loss if your database has records where the biblionumber and biblioitemnumber do not match and the script misc/batchRebuildBiblioTables.pl is run. The Biblio::GetMarcBiblio makes a kall to C4::Biblio::_koha_marc_update_bib_ids which passes the biblionumber as both the biblionumber *and the biblioitemnumber*. Thus, if your biblio and biblioitem numbers are not always equal, you will end up with a record where the biblioitemnumber is incorrect in the record! This is usually not a severe issue, but since batchRebuildBiblioTables uses that record to update the database tables, it ends up updating the wrong biblioitem row! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 18:54:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 16:54:12 +0000 Subject: [Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 18:54:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 16:54:14 +0000 Subject: [Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 --- Comment #1 from Kyle M Hall --- Created attachment 21520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21520&action=edit Bug 10961 - Error in GetMarcBiblio can cause severe data loss A bug in GetMarcBiblio can cause severe data loss if your database has records where the biblionumber and biblioitemnumber do not match and the script misc/batchRebuildBiblioTables.pl is run. The Biblio::GetMarcBiblio makes a kall to C4::Biblio::_koha_marc_update_bib_ids which passes the biblionumber as both the biblionumber *and the biblioitemnumber*. Thus, if your biblio and biblioitem numbers are not always equal, you will end up with a record where the biblioitemnumber is incorrect in the record! This is usually not a severe issue, but since batchRebuildBiblioTables uses that record to update the database tables, it ends up updating the wrong biblioitem row! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 18:54:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 16:54:25 +0000 Subject: [Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 19:02:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 17:02:55 +0000 Subject: [Koha-bugs] [Bug 10901] Filters is needed on the add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10901 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Jonathan! Since the two initial columns for the record actions have been collapsed into one, additional visual tweaking might be a good idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 19:11:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 17:11:31 +0000 Subject: [Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 --- Comment #2 from Galen Charlton --- Comment on attachment 21520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21520 Bug 10961 - Error in GetMarcBiblio can cause severe data loss Review of attachment 21520: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10961&attachment=21520) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +1252,4 @@ > my $biblionumber = shift; > my $embeditems = shift || 0; > my $dbh = C4::Context->dbh; > + my $sth = $dbh->prepare("SELECT * FROM biblioitems WHERE biblionumber=? "); You don't need * here, just "marcxml, biblioitemnumber". Since biblioitems also contains the marc column, select * just causes unnecessary network traffic for remote DB servers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 19:16:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 17:16:39 +0000 Subject: [Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #3 from Galen Charlton --- Also, as with any change to a routine in the C4 or Koha namespace, please provide a regression test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 19:19:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 17:19:10 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #10 from Blou --- Created attachment 21521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21521&action=edit Bug 8753 - Add forgot password link to OPAC Includes the database scripts modifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 19:20:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 17:20:28 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #11 from Blou --- The second patch "Bug 8753 - Add forgot password link to OPAC" contains the db scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 19:23:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 17:23:32 +0000 Subject: [Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 --- Comment #4 from Galen Charlton --- Also, while the bug in GetMarcBiblio() is real, consideration should be given to removing misc/batchRebuildBiblioTables.pl for the following reasons: [1] It calls internal routines in C4::Biblio directly in the name of performance, but doing so is the direct cause of the bug. [2] misc/maintenance/touch_all_biblios.pl will do the same thing, but does not call private routines in C4::Biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 19:46:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 17:46:29 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21510|0 |1 is obsolete| | Attachment #21516|0 |1 is obsolete| | --- Comment #13 from Blou --- Created attachment 21522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21522&action=edit Adding NoLoginInstructions to system preferences Fixed issue in previous patch. Merged all the patches together for simpler install. 1 > 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 20:15:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 18:15:45 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 21:02:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 19:02:53 +0000 Subject: [Koha-bugs] [Bug 8876] branch not always stored in the stats table for payments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8876 alexh at cctexas.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexh at cctexas.com --- Comment #2 from alexh at cctexas.com --- Has there been movement of fixing this bug? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:29:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:29:41 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:29:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:29:46 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21398|0 |1 is obsolete| | --- Comment #80 from Katrin Fischer --- Created attachment 21523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21523&action=edit [PASSED QA] Bug 7298: Followup: CSV strings are translatables. Following the same way as bug 10935, the headers are in an include file. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Translatability tested successfully. Passes all tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:30:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:30:22 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #81 from Katrin Fischer --- This has taken a while... thx Jonathan for your patience! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:39:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:39:09 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21522|0 |1 is obsolete| | --- Comment #14 from Blou --- Created attachment 21524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21524&action=edit Adding NoLoginInstructions to system preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:41:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:41:58 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21511|0 |1 is obsolete| | --- Comment #8 from Blou --- Created attachment 21525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21525&action=edit Add fields 1xxx to marc2bibtex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:50:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:50:55 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 --- Comment #13 from Katrin Fischer --- Created attachment 21526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21526&action=edit [PASSED QA] Bug 9735 - Let the language be selected through URL parameters Passing language= as a parameter in any Koha's URL can be used to set the desired language. This patch touches - C4::Templates - C4::Auth Adds a new method getlanguagecookie that does exactly that, for use in get_template_and_user. Also modifies getlanguage so it checks (a) if there's a 'language' parameter in the CGI object and (b) checks if its valid and enabled for the desired interface. To test: * Without the patch - access any koha page - add ?language=code to the end of the URL (change code for a valid language code it needs to be installed using perl translate install code, and enabled either for the staff or opac interface, depending where are you testing) - Nothing happens with the language parameter * With the patch - access any koha page - add ?language=code (the same as before) and hit enter - the language should be changed to the one you chose - if you browse through some links, you will see koha 'remembers' the language you passed as a parameter (i.e. the language cookie has been updated). Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Brendan Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works very well. No errors. Signed-off-by: Chris Cormack Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer Passes all tests and QA script. More comments on last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:51:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:51:07 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 --- Comment #14 from Katrin Fischer --- Created attachment 21527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21527&action=edit [PASSED QA] Bug 9735 - Build the cookie array correctly The current implementation didn't build the cookie array correctly, yielding login problems in some scenarios. Regards To+ Sponsored-by: Universidad Nacional de C?rdoba http://bugs.koha-community.org/show_bug.cgi?id=6735 Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:51:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:51:16 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 --- Comment #15 from Katrin Fischer --- Created attachment 21528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21528&action=edit [PASSED QA] Bug 9735: Unit tests for get_template_and_user (cookies handling) Galen found a case where the cookies array was not built flat. I add a unit test for that (check the cookie array is flat) and also test the cookies output of get_template_and_user so we are sure the &language= parameter is correctly handled. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer - Tests in t/db_dependent/Auth.t pass - Tested in intranet, OPAC logged in, OPAC logged out * Adding a valid language code to the URL switches the language as expected * Adding an invalid language code causes no change Nice feature! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:51:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:51:43 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:51:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:51:46 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:51:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:51:48 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21422|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 22:51:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 20:51:51 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 23:17:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 21:17:20 +0000 Subject: [Koha-bugs] [Bug 8368] List email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 23:17:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 21:17:23 +0000 Subject: [Koha-bugs] [Bug 8368] List email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21457|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 21529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21529&action=edit [PASSED QA] Bug 8368 List email broken for non english templates This patch ports to list sending by email, the technic used in sending cart, ie (1) format email in HTML, and (2) transform it into Text with TT filter html2text. Note: V2 of this patch: Restore proper subtile display. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Fixes a very annoying translation bug successfully. Also passes all tests and QA script. To test: - Add a few records to a shelf, ideally use some with diacritics. - Send shelf from English templates, verify email is ok - Send shelf from translated templates (de-DE or similar) - verify email content is broken. - Apply patches, update po files and reinstall the language. - Send shelf from English templates again, verify there is no regression. - Send shelf form translates templates - verify this email is now also working correctly. Patch also changes the name of the file attachement from shelf.iso2709 to list.iso2709. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 23:19:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 21:19:00 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Chris Rohde changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 23:34:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 21:34:21 +0000 Subject: [Koha-bugs] [Bug 10949] hold request not retrieved when printing hold slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10949 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 27 23:34:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 21:34:24 +0000 Subject: [Koha-bugs] [Bug 10949] hold request not retrieved when printing hold slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10949 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21453|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 21530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21530&action=edit [PASSED QA] Bug 10949: restore ability to successfully print hold slips This fixes a regression introduced by the patch for bug 9394 -- when printing a hold slip using the 'print and confirm' button, the slip would contain only the text 'reserve not found', not a full hold slip. This patch also adds a regression test. To test: [1] Check in an item that would fill a hold. Use the 'print and confirm button' to confirm the hold. [2] The printout will only contain text to the effect of 'reserve not found'. [3] Apply the patch. [4] Repeat step 1. This time, a full hold slip should be printed. [5] Verify that prove -v t/db_dependent/Reserves.t passes. Signed-off-by: Galen Charlton Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Pass all tests, new and old, and QA script. Verified wrong and corrected behaviour. Note: Sometimes there will not be the message 'reserve not found' showing up, but hold information for a different record. This happens when there exists a reserve_id with the borrowernumber of the patron in question in your database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:03:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:03:42 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:03:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:03:47 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21424|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 21531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21531&action=edit [PASSED QA] Bug 7764 - INSTALL.ubuntu needs to be updated This is a major rework. Key improvements include: - Removed confusing multiple versions for Ubuntu leaving only one set of instructions. - The packages koha-deps and koha-perldeps are used. - License has been updated to reflect GPL3. - More wiki reference links have been included. - It is aimed to be based on source, not just tarball or just git. - Sample output has been cut as much as possible. - Almost cut-and-paste easy, making it friendlier than INSTALL.debian. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Fixed a tiny typo: seperate Makes all sense to me - only wondering a bit about the recommendation of using lynx for the web installer. Quite an improvement, so passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:15:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:15:58 +0000 Subject: [Koha-bugs] [Bug 10962] New: Update MARC21 frameworks to Update Nr. 17 (September 2013) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 Bug ID: 10962 Summary: Update MARC21 frameworks to Update Nr. 17 (September 2013) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl There is a new update for MARC21 bibliographic and authorities Update Nr. 17 (September 2013) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:16:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:16:16 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:19:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:19:07 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 21532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21532&action=edit Bug 10962 - Update MARC21 frameworks to Update Nr. 17 (September 2013) This patch updates MARC21 default bibliografic framework and authorities frameworks to Update Nr. 17 (September 2013) Source Bibliographic: http://www.loc.gov/marc/bibliographic/bdapndxg.html Authorities: http://www.loc.gov/marc/authority/adapndxf.html Only to new installs. To test 1) Remove default MARC21 framework 2) Load marc21_framework_DEFAULT.sql 3) Verify new subtags 015_q 020_q 024_q 027_q 800_7 810_7 811_7 830_7 4) Remove authorities frameworks 5) Load authorities_normal_marc21.sql 6) Verify new subtags 020_q 024_q -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:19:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:19:46 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:22:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:22:40 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #122 from mathieu saby --- Thank you for corecting the discount > with the following: > - syspref: price: 947$c > - a biblio with 947$c=100 > - a supplier with "list price include tax = 0", I got a rrp (include tax) = > 94.79 (gst is 5.5%). > - a supplier with "list price include tax = 1", I got a rrp (include tax) = > 100 > > It is what is expected. See the test plan, step 6. I continue to find that strange. For me, if the vendor price in 947c is 100 EUR and this price "does NOT include tax", it means the book price is 100 EUR without tax, so 105.5 with tax. I cannot understand it in an other way... For unitprice, it is clearly NOT a big issue (I'm more concerned with taxes management), but for Koha it means "actual price". So how could I know the "actual" price before receipt? Do you know libraries which are using this field when ordering? Here we don't use it, and we were always said it must be left at "0" and will be automaticaly filled by Koha at receipt. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:50:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:50:40 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- I am not entirely sure how to test this, but I have started with running the automated and db_dependent tests and it looks to me like the change breaks t/db_dependent/Context.t. On master: [~/kohaclone (master)]> prove t/db_dependent/Context.t t/db_dependent/Context.t .. # Note: The overall number of tests may vary by configuration. # First we need to check your environmental variables t/db_dependent/Context.t .. 1/? # Number of keys in %$koha: 13 # Examining defined key values. # Testing syspref caching. t/db_dependent/Context.t .. ok All tests successful. Files=1, Tests=38, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.16 cusr 0.01 csys = 0.21 CPU) Result: PASS With patch applied: [~/kohaclone (71-10611-contextdb)]> prove t/db_dependent/Context.t t/db_dependent/Context.t .. # Note: The overall number of tests may vary by configuration. # First we need to check your environmental variables t/db_dependent/Context.t .. 1/? # Number of keys in %$koha: 13 # Examining defined key values. # Testing syspref caching. # Failed test 'Retrieved syspref (value='thing1') successfully with default behavior' # at t/db_dependent/Context.t line 74. # got: undef # expected: 'thing1' Can't use an undefined value as an ARRAY reference at t/db_dependent/Context.t line 76. # Tests were run but no plan was declared and done_testing() was not seen. t/db_dependent/Context.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/25 subtests Test Summary Report ------------------- t/db_dependent/Context.t (Wstat: 65280 Tests: 25 Failed: 1) Failed test: 25 Non-zero exit status: 255 Parse errors: No plan found in TAP output Files=1, Tests=25, 0 wallclock secs ( 0.04 usr 0.01 sys + 0.17 cusr 0.00 csys = 0.22 CPU) Result: FAIL Jonathan, can you please take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:53:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:53:41 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:53:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:53:49 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #17 from Katrin Fischer --- Working on this now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 00:54:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 22:54:48 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #18 from Katrin Fischer --- Fails xt/permissions.t for missing entries in various translated permissions.sql files, I will provide a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 01:36:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 23:36:09 +0000 Subject: [Koha-bugs] [Bug 10963] New: Simplified creation of MARC21 sample frameworks Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bug ID: 10963 Summary: Simplified creation of MARC21 sample frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl As mentioned on IRC, use of current sample frameworks is discouraged because they are incomplete or out of sync with default framework. I propose to build sample and fast add frameworks using default framework. New files are smaller and we need to mantain a single framework. Also there will be less strings to translate, when time comes for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 01:36:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Sep 2013 23:36:22 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 03:11:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 01:11:32 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 --- Comment #14 from M. Tompsett --- The reason for lynx for the web browser portion of the install is to facilitate text-only servers without having to try to get them to understand apache and network configuration. If you know of another text-only browser, I'd be more than willing to try that. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 04:23:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 02:23:36 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #133 from M. Tompsett --- Comment on attachment 21432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21432 [SIGNED-OFF] Bug 6874: File upload in MARC Review of attachment 21432: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6874&attachment=21432) ----------------------------------------------------------------- ::: cataloguing/value_builder/upload.pl @@ +50,5 @@ > + var id = document.getElementById(index).value; > + if(id.match(/id=([0-9a-f]+)/)){ > + id = RegExp.\$1; > + } > + window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=upload.pl&index=\"+index+\"&id=\"+id, 'upload', 'width=600,height=400,toolbar=false,scrollbars=no'); var newin=... (this line) newin.focus(); ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/upload.tt @@ +3,5 @@ > + > + > + Upload plugin > + > + This should be interface, not themelang. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 04:52:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 02:52:09 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 --- Comment #15 from M. Tompsett --- This looks good, Blou, but I haven't tested it. I just eyeballed it. I should be able to sign this off pretty quickly later. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:18:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:18:07 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 21533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21533&action=edit Bug 10963 - [1/9] - Simplified creation of MARC21 sample frameworks Patch 1/9 This patch modifies fast add framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:18:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:18:15 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 21534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21534&action=edit Bug 10963 - [2/9] - Simplified creation of MARC21 sample frameworks Patch 2/9 This patch modifies simple bibs frameworks for BKS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:18:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:18:23 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 21535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21535&action=edit Bug 10963 - [3/9] - Simplified creation of MARC21 sample frameworks Patch 3/9 This patch modifies simple bibliographic frameworks for CF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:18:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:18:31 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 21536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21536&action=edit Bug 10963 - [4/9] - Simplified creation of MARC21 sample frameworks Patch 4/9 This patch modifies simple bibs frameworks for VR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:18:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:18:40 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 21537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21537&action=edit Bug 10963 - [5/9] - Simplified creation of MARC21 sample frameworks Patch 5/9 This patch modifies simple bibs frameworks for VR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:18:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:18:49 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 21538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21538&action=edit Bug 10963 - [6/9] - Simplified creation of MARC21 sample frameworks Patch 6/9 This patch modifies simple bibs frameworks for AR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:18:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:18:57 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 21539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21539&action=edit Bug 10963 - [7/9] - Simplified creation of MARC21 sample frameworks Patch 7/9 This patch modifies simple bibs frameworks for KT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:19:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:19:05 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 21540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21540&action=edit Bug 10963 - [8/9] - Simplified creation of MARC21 sample frameworks Patch 8/9 This patch modifies simple bibs frameworks for IR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:19:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:19:14 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 21541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21541&action=edit Bug 10963 - [9/9] - Simplified creation of MARC21 sample frameworks Patch 9/9 This patch modifies simple bibs frameworks for SER -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:20:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:20:12 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #10 from Bernardo Gonzalez Kriegel --- Patch is too big to fit, so I splitted it in 9 patches Here main description and test plan Bug 10963 - Simplified creation of MARC21 sample frameworks This patch series implements the creation of sample frameworks using MARC21 default framework as base, just by copy it. There are lots of obsoleted tags/subtags, but if default is the recommended then as far as they remain hidden I think there is no problem. Only to new installs To test: 1) Apply all patches 2) Remove all frameworks 3) Load default MARC21 framework 4) Load marc21_fastadd_framework.sql 5) Verify that Fast Add framework has same tags as before 6) Load marc21_simple_bib_frameworks.sql 7) Verify all sample frameworks are created -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 05:28:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 03:28:23 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #11 from Bernardo Gonzalez Kriegel --- > Patch 4/9 > > This patch modifies simple bibs frameworks for VR Wrong description but patch is good, modifies SR framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 11:24:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 09:24:31 +0000 Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939 --- Comment #5 from Fridolyn SOMERS --- (In reply to Galen Charlton from comment #1) > Can you expand on this bug report? "Not working well" is rather vague. I mean I does not work at all, polish "l stroke" is not considered as the same character has "l". (In reply to Jared Camins-Esakov from comment #2) > (In reply to Fridolyn SOMERS from comment #0) > > When indexing records in Zebra using ICU (in etc/default.idx), non latin > > characters are transliterate to latin one. > > Are you sure about this? It sounds to me like you are describing the > behavior of Zebra with charmap, not Zebra with ICU. I do not know the real behavior of Zebra+ICU, but I mean that non latin characters can be searched using latin characters and the opposite. That is the aim of ICU. (In reply to mathieu saby from comment #4) > Hi > Some years ago, I find out the polish "l stroke" was not considered as a > variant of "l". Even if true, It would be easier use the "l" to search into polish records no ? "l stroke" does not exist in a QWERTY nor AZERTY keyboard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 11:59:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 09:59:53 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- But after running the web installer... how would you continue to do anything with your freshly installed Koha if you had no access to it from outside and no graphical interface on your server? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 12:49:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 10:49:10 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #19 from Katrin Fischer --- Created attachment 21542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21542&action=edit Bug 10863: Follow-up: Adding missing permissions to translated files This patch adds the 2 new permissions to all remaining sample files. If the permissions don't get installed, the problem is bigger than having an English description. Also adds back the question "Check out anyway?" for high demand items (HIGHHOLDS). Test xt/permissions.t passes now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 12:55:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 10:55:06 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- Hi Jonathan, I have one bigger and some smaller issues with "Lift restriction for restricted accounts" I think either the description is wrong, or it does not work like it should. We have 3 possible restrictions on patron accounts: - Restricted - Lost - Gone no address It would be nice if it was clearer that it only affected "Restricted", but that is ok. (1) What I have a problem with is, that you can also not restrict someone if you are missing the permission - which means it's not only for 'lifting' but also for 'setting' the restriction. Is this by design? (2) If you don't set a date for the restriction, which you can to indicate an unlimited restriction, the message shown without permission is: "Restricted: Yes, until" (3) Failed for (2) - please verify what the expected behaviour is and provide a follow-up. Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 12:58:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 10:58:52 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- Hi Kyle, I am sorry, but this patch no longer applies and I was not sure how to resolve the conflict, could you please take a look? [~/kohaclone (73-10612-deletepatronsbatch)]> git bz apply 10612 Bug 10612 - Add ability to delete patrons with batch patron modification tool 21081 - Bug 10612 - Add ability to delete patrons with batch patron modification tool 21446 - Bug 10612 - Add ability to delete patrons with batch patron modification tool - QA Followup - Move member deletion related calls to DelMember Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10612 - Add ability to delete patrons with batch patron modification tool /home/katrin/kohaclone/.git/rebase-apply/patch:41: trailing whitespace. Cannot delete patron /home/katrin/kohaclone/.git/rebase-apply/patch:49: trailing whitespace. Cannot delete patron /home/katrin/kohaclone/.git/rebase-apply/patch:101: trailing whitespace. warning: 3 lines add whitespace errors. Using index info to reconstruct a base tree... :41: trailing whitespace. Cannot delete patron :49: trailing whitespace. Cannot delete patron :101: trailing whitespace. warning: 3 lines applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging tools/modborrowers.pl CONFLICT (content): Merge conflict in tools/modborrowers.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt Failed to merge in the changes. Patch failed at 0001 Bug 10612 - Add ability to delete patrons with batch patron modification tool When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-10612---Add-ability-to-delete-patrons-with-bat-_BRqbC.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 13:01:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 11:01:02 +0000 Subject: [Koha-bugs] [Bug 10927] C4::Utils becomes useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- This is BLOCKED, because 10925 still waits for sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 13:03:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 11:03:35 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 13:05:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 11:05:13 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 --- Comment #8 from Katrin Fischer --- It looks to me like this doesn't touch files relevant for the packages, but wonder if it should - I am adding Robin in CC to take a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 13:14:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 11:14:07 +0000 Subject: [Koha-bugs] [Bug 10806] The staff benchmark script does not check authentication failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Is it by intention that benchmark_staff.pl is not executable? -rw-rw-r-- 1 katrin katrin 12879 Sep 28 13:06 benchmark_staff.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 13:23:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 11:23:37 +0000 Subject: [Koha-bugs] [Bug 10806] The staff benchmark script does not check authentication failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl --- Comment #4 from Katrin Fischer --- It seems I can't get this to work with my locally running Koha. I have tried various variations of localhost and 127.0.0.1 in the URL parameter, maybe someone else can take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 13:27:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 11:27:22 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #30 from Katrin Fischer --- Back to this, sorry it took me so long. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 14:11:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 12:11:12 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #134 from Katrin Fischer --- Reading through the comments of M.Tompset I think this is failed QA. There are issues and further testing should be postponed until those are fixed. Julian, could you please take a look and provide follow-ups where needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 14:11:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 12:11:19 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 14:20:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 12:20:55 +0000 Subject: [Koha-bugs] [Bug 10806] The staff benchmark script does not check authentication failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806 --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #4) > It seems I can't get this to work with my locally running Koha. I have tried > various variations of localhost and 127.0.0.1 in the URL parameter, maybe > someone else can take a look? Just copying my results, I used a real staff URL on port 80 1) bgkriegel at sentey:~/kohaclone$ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://staffdev.local.koha/cgi-bin/koha/ --password="test" --user="test" Authentication successful Use of uninitialized value $author in split at misc/load_testing/benchmark_staff.pl line 124. Use of uninitialized value $author in split at misc/load_testing/benchmark_staff.pl line 124. -------------- Koha STAFF benchmarking utility -------------- Benchmarking with 20 occurences of each operation and 30 concurrent sessions Step 1: staff client main page 13537ms 1.477 pages/sec Skipping step 2 Skipping step 3 Skipping step 4 Skipping step 5 Skipping step 6 Skipping 'testing all transactions at once' (step 0) 2) bgkriegel at sentey:~/kohaclone$ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://staffdev.local.koha/cgi-bin/koha/ --password="badtest" --user="test" Authentication failure: bad login/password at misc/load_testing/benchmark_staff.pl line 87. 3) bgkriegel at sentey:~/kohaclone$ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://badhost.local.koha/cgi-bin/koha/ --password="test" --user="test" Authentication failure: 500 Can't connect to badhost.local.koha:80 (Bad hostname) at misc/load_testing/benchmark_staff.pl line 89. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 14:25:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 12:25:33 +0000 Subject: [Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |chrish at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 14:47:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 12:47:56 +0000 Subject: [Koha-bugs] [Bug 2629] Diacritics not being ignored when searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2629 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #45 from mathieu saby --- A note about right truncation and ICU : The existing issue was fixed in version 2.0.53 of Zebra (2012/12/03) source : http://www.indexdata.com/zebra/doc/NEWS I don't know how to take profit of that fix in Koha? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 15:21:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 13:21:40 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 --- Comment #16 from M. Tompsett --- The scope of the instructions are to get a Koha installation functional, not necessarily usable. If the concern is usability, the instructions would need to include a whole segment on networking, which is beyond the scope of Koha installation. This is why they repeatedly suggest requesting assistance from a system administrator, network administrator or IT department. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 15:31:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 13:31:09 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #135 from M. Tompsett --- Created attachment 21543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21543&action=edit Bug 6874 - Focus and jquery.js fix Clicking the plug in show cause the popup window to refocus. The patch to the jquery.js script was wrong. Changed [% themelang %] to [% interface %]. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 15:35:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 13:35:11 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #136 from M. Tompsett --- Seeing as I can't sign off on my own patches. Could you squash these into a single patch, re-test, and re-post, Julian? Thanks. I'll continue testing once reposted. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 15:40:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 13:40:18 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #137 from Katrin Fischer --- As they haven't been signed off you could squash your patches into one - but don't squash them with Julian's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 15:41:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 13:41:32 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 --- Comment #17 from Katrin Fischer --- I was just thinking why make it harder than it has to be - it could say... or use your browser instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 15:49:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 13:49:08 +0000 Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 --- Comment #18 from M. Tompsett --- Because someone somewhere is going to try this from scratch, because they are installing Koha for the first time and know nothing of Linux. Saying just use a browser, and expecting the networking portion of the problem to just work is fanciful dreaming. It most likely won't. It is about managing expectations. People expect the instructions to work. This method just works. Yes, they'll be wondering, "So how do I use it now?" but they won't be going "Why are these instructions broken?" Which problem would you prefer? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 17:24:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 15:24:24 +0000 Subject: [Koha-bugs] [Bug 10806] The staff benchmark script does not check authentication failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 17:24:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 15:24:27 +0000 Subject: [Koha-bugs] [Bug 10806] The staff benchmark script does not check authentication failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21300|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 21544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21544&action=edit [PASSED QA] Bug 10806: The staff benchmark script does not check authentication failure. Currently, if you launch the script misc/load_testing/benchmark_staff.pl, it always displays "Authentication successful" or continue to execute the script even if nothing is done. This patch checks if the url is right and if the authentication is correctly done. Test plan: Suppose that a correct login/pwd is koha/koha 1/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: Authentication successful ... Step 1 ... 2/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="KOHA" --user="KOHA" should produce: Authentication failure: bad login/password 3/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.kobe.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: Authentication failure: 500 Can't connect to admin.kobe.local:80 (Bad hostname) Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works as described, detects bad url and user credentials. No koha-qa errors Signed-off-by: Katrin Fischer Works as described and gives better error messages. There are some warnings output when running the script before and after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 17:47:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 15:47:56 +0000 Subject: [Koha-bugs] [Bug 10925] LDAP Auth fails if DEBUG is enable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10925 --- Comment #3 from M. Tompsett --- Created attachment 21545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21545&action=edit [SIGNED OFF] Bug 10925: LDAP auth fails if DEBUG is enable To reproduce: 1/ Edit your apache virtual host and set the DEBUG environment variable (SetEnv DEBUG 1). 2/ Try to login with an ldap user 3/ You will be redirected to the 500 error page. The Koha logs contains: malformed header from script. Bad header=------------------------------: mainpage.pl The hashdump routine directly punks to the STDOUT (!) and breaks the headers. It appears Net::LDAP::?->dump does the same thing. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 17:48:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 15:48:55 +0000 Subject: [Koha-bugs] [Bug 10925] LDAP Auth fails if DEBUG is enable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10925 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21282|0 |1 is obsolete| | CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- Comment on attachment 21282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21282 Bug 10925: LDAP auth fails if DEBUG is enable Figured out how to test this.... I set up an LDAP server on my koha VM: $ sudo apt-get install ldap-server $ sudo slapcat The second entry's 'dn' line will be important in setting up LDAP authentication. Made sure to set up the koha-conf.xml 1 demo.library.kohasystem.ca dc=nodomain CN=admin,OU=Special,OU=Accounts,DC=nodomain ldap123 1 1 1 CN=%s,DC=nodomain
3900 University Blvd
Tyler, TX 75799 MNL PT 903-566-7343 2011-03-27 2011-05-13
It is important to get the patron type and branch code to match something in your DB. Notice the principle_name line is similar to the second entry's 'dn' line. And yes, I was lazy setting it up and used ldap123 as the password for the admin account. And since I didn't know how to set up any other accounts, I just used the admin account. I then proceeded to log in using OPAC. BEFORE PATCH: #SetEnv DEBUG 1 delete patron log in, log out, log in, log out (previously exist or not cases) -- ALL GOOD! SetEnv DEBUG 1 delete patron log in, log in (previously exist or not cases) -- ALL FAIL! AFTER PATCH: -- ALL GOOD! Signed off. YAY! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 17:49:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 15:49:05 +0000 Subject: [Koha-bugs] [Bug 10925] LDAP Auth fails if DEBUG is enable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10925 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 17:51:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 15:51:29 +0000 Subject: [Koha-bugs] [Bug 10927] C4::Utils becomes useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #12 from M. Tompsett --- Perhaps it is premature, but I switched this to signed off, as I got around to testing 10925 and signing it off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 18:16:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 16:16:12 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #138 from M. Tompsett --- Created attachment 21546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21546&action=edit Bug 6874 - kohastructure.sql & jquery.js fix with refocus Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 18:19:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 16:19:10 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 18:19:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 16:19:28 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21543|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 18:20:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 16:20:57 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #139 from M. Tompsett --- Squashed my patches together as per Katrin Fischer's request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 18:28:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 16:28:06 +0000 Subject: [Koha-bugs] [Bug 10927] C4::Utils becomes useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #13 from Katrin Fischer --- Please leave at BLOCKED, it can go back to Signed off when the dependency is resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 18:31:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 16:31:42 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #35 from Jared Camins-Esakov --- Created attachment 21547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21547&action=edit Bug 10402 follow-up: choose contacts for serials and acq claims This patch makes it possible to choose a particular contact for acquisitions and serials claims. To test: 1) Select a contact to use for claiming late orders and a contact to use for claiming late issues. 2) Send a claim for a late order and a claim for a late issue. 3) Note that the claims went out to the proper people. 4) Sign off. Note: the claim messages are recorded in the logs in the *Acquisitions* module, not the Letters module as you might expect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 19:34:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 17:34:59 +0000 Subject: [Koha-bugs] [Bug 10964] New: Update MARC21 de-DE default framework to Update Nr. 17 (September 2013) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10964 Bug ID: 10964 Summary: Update MARC21 de-DE default framework to Update Nr. 17 (September 2013) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr MARC21 de-DE default framework is missing many tags/subtags -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 19:36:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 17:36:06 +0000 Subject: [Koha-bugs] [Bug 10964] Update MARC21 de-DE default framework to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10964 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 21548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21548&action=edit Bug 10964 - Update MARC21 de-DE default framework to Update Nr. 17 (September 2013) This patch updates missing tags/subtags for de-DE MARC21 default famework (but with english legends!) Not to sign, needs translation If desired, I could put all updates at the bottom. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 19:37:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 17:37:39 +0000 Subject: [Koha-bugs] [Bug 10964] Update MARC21 de-DE default framework to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10964 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 19:44:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 17:44:31 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21547|0 |1 is obsolete| | --- Comment #36 from Jared Camins-Esakov --- Created attachment 21549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21549&action=edit Bug 10402 follow-up: choose contacts for serials and acq claims This patch makes it possible to choose a particular contact for acquisitions and serials claims. To test: 1) Select a contact to use for claiming late orders and a contact to use for claiming late issues. 2) Send a claim for a late order and a claim for a late issue. 3) Note that the claims went out to the proper people. 4) Run the unit test with: > prove t/db_dependent/Letters.t 5) Sign off. Note: the claim messages are recorded in the logs in the *Acquisitions* module, not the Letters module as you might expect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 19:45:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 17:45:58 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 20:55:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 18:55:23 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21482|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 21550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21550&action=edit [SIGNED-OFF] Bug 10952: Store anonymous search history in session Storing search history into cookie can cause problems, due to the size limitation of 4KB. The solution here is to store search history into the CGI::Session object, so there is no size limitation (but anonymous search history still remember up to 15 requests max.) Test plan: - Go to OPAC in anonymous mode. - Check that the "Search history" link is *not* shown in the top right corner of the page - Make some searches on /cgi-bin/koha/opac-search.pl - The "Search history" link must appear. Click. - Your search history must be displayed. - Try to log in with invalid username/password - Go back to search history, it's still there - Now log in with valid username/password - Your anonymous search history must be saved into your own search history. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors Well, search history saving is similar before and after patch. i.e. anonmymous search is saved when user logs in, but cookie KohaOpacRecentSearches is empty. Shows current an previous session searches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 20:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 18:55:40 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 21:44:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 19:44:01 +0000 Subject: [Koha-bugs] [Bug 10965] New: Sample itemtypes can't load on new install Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Bug ID: 10965 Summary: Sample itemtypes can't load on new install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Sample itemtypes can't load with new itemtypes table structure. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 21:44:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 19:44:17 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 21:46:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 19:46:32 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 21551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21551&action=edit Bug 10965 - Sample itemtypes can't load on new install Bug 10513 added two columns to table itemtypes, but sample_itemtypes can't be loaded because it relies on old structure. This patch rewrites sample_itemtypes.sql, stating explicitly columns, removing backticks and consolidates all in one insertion. To test: 1) On master with current DB structure, delete item types 2) try loading sample_itemtyes.sql It fails with "ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1" 3) apply patch 4) try again, this time it will load and itemtypes created -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 21:49:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 19:49:02 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 21:50:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 19:50:08 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #16 from Bernardo Gonzalez Kriegel --- Warning: with this change, sample imtemtypes can't load. See Bug 10965 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 22:07:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 20:07:30 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 22:47:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 20:47:37 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #45 from Bernardo Gonzalez Kriegel --- Tested and works, with Firefox 24.0. Questions 1) At first I have problems with diacritics, title an author showed funny chars in position of accented letters on checkout/in pages. To test more I loaded arabic records and then all was fine. Don't know how that was fixed. I have screen captures 2) I can checkin many times one title, that was no problem un re-sycronize, only states that the item is not checked-out 3) I can checkout many times a title to the same patron. On synchronization all seems fine, but fines/charges are computed for every checkout, so I ended up owing for more than one item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 23:06:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 21:06:25 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #46 from Jared Camins-Esakov --- (In reply to Bernardo Gonzalez Kriegel from comment #45) > Tested and works, with Firefox 24.0. > > Questions > 1) At first I have problems with diacritics, title an author showed funny > chars in position of accented letters on checkout/in pages. To test more I > loaded arabic records and then all was fine. Don't know how that was fixed. > I have screen captures Could you please e-mail them to me? I don't have problems with accents on my installation. > 2) I can checkin many times one title, that was no problem un re-sycronize, > only states that the item is not checked-out > > 3) I can checkout many times a title to the same patron. On synchronization > all seems fine, but fines/charges are computed for every checkout, so I > ended up owing for more than one item That's by design. If you use hourly loans, you could check out a book to a person several times before going back online. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 23:40:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 21:40:41 +0000 Subject: [Koha-bugs] [Bug 10966] New: in advanced search, location should be handled in a better way Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10966 Bug ID: 10966 Summary: in advanced search, location should be handled in a better way Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org In advanced search, location is handled like author, titles, subjects, etc. But location index contains coded information (mapped with authorized value), so it should be searchable in a better way, by choosing some locations in a list of available locations. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 23:50:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 21:50:45 +0000 Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939 --- Comment #6 from mathieu saby --- I don't speak polish, but I agree with you Fridolyn. Maybe for Poles it is a very different letter than "l", but if we have a polish book with this stroke l in our collection, we need a way to search it with a simple "l" ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 28 23:53:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 21:53:17 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #47 from Jared Camins-Esakov --- Created attachment 21552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21552&action=edit Bug 10240 follow-up: make sure datepicker icons are available offline The next month/previous month icons for the datepicker were not available offline. With this patch they are. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 00:29:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 22:29:20 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21552|0 |1 is obsolete| | --- Comment #48 from Jared Camins-Esakov --- Created attachment 21553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21553&action=edit Bug 10240 follow-up: make sure datepicker icons are available offline The next month/previous month icons for the datepicker were not available offline. With this patch they are. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 00:42:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 22:42:29 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21495|0 |1 is obsolete| | --- Comment #49 from Bernardo Gonzalez Kriegel --- Created attachment 21554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21554&action=edit [SIGNED-OFF] Bug 10240: Offline circulation using HTML5 and IndexedDB This patch adds an HTML5-based offline mode to Koha's existing circulation module, allowing librarians to check out items using a basically familiar interface. The feature will be implemented using the Application Cache and IndexedDB features of the HTML5 specification, both of which are fully supported on Firefox 10+ and Chrome 23+, with limited support going back to Firefox 4 and Chrome 11. The basic workflow enabled by this patch is as follows: Part 1: While connected to the Internet 1. Enable offline functionality by turning on the "AllowOfflineCirculation" system preference. 2. Sync the offline circulation database on the computer that will be used for offline circulation by following the "Offline circulation interface" link on the Circulation home page, choosing "Synchronize (must be online)", and clicking the "Download records" button. This process may take a while. 3. Bookmark /cgi-bin/koha/circ/offline.pl (the page you are currently on) for easy access when offline. Part 2: While disconnected from the Internet 4. Navigate to /cgi-bin/koha/circ/offline.pl using the bookmark you created while online. 5. Start checking books in by scanning the barcode of an item that has been returned into the box in the "Check in" tab. 6. Scan the barcodes of any additional items that have been returned. 7. Start checking out books to a patron by scanning the patron's barcode in the box in the "Check out" tab. 8. Set a due date (the "Remember for session" box will be checked by default, since circulation rules are not computed during offline transactions and therefore a due date must be specified by the librarian). 9. Scan an item barcode (if you did not set a due date, it will prompt you) to check the item out to the patron. 10. If a patron has a fine you can see the total amount (current to when the offline module was synced), and record a payment. Unlike when in online mode, there will be no breakdown of what item(s) fines are for, and you will only be able to record the payment amount and not associate it with a particular item. Part 3: While connected to the Internet 11. Click the "Synchronize" link and choose "Upload transactions" to upload the transactions recorded during the offline circulation session. 12. Navigate to /cgi-bin/koha/offline_circ/list.pl (there will be a link from the Offline circulation page) and review the transactions, as described in the documentation for the Firefox Offline circulation plugin: http://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin Signed-off-by: Chris Cormack Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works very well, no koha-qa errors Test with Firefox 24.0 1) did some checkouts pre sync 2) synchronize database (Download) 3) go offline 4) Proceed to checkin some items from patron 5) Proceed to checkout items to patrons, setting date 6) Proceed to checkout to expired patron, warning appears 7) go online 8) Upload records 9) go to review transacctions and proceed 10) verified on patrons that checkin/out are done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 00:42:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 22:42:43 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21496|0 |1 is obsolete| | --- Comment #50 from Bernardo Gonzalez Kriegel --- Created attachment 21555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21555&action=edit [SIGNED-OFF] Bug 10240 QA follow-up Address the following issues: 1/ Address minor qa issues with the templates: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 24) [etc.] OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 509) [etc.] FAIL tt_valid lines 5, 5 2/ Run perltidy on new scripts 3/ download.pl returns data.finished = 1 if number of returned data < 5000 (avoids 1 ajax call) 4/ Replace qq{} around sql queries with q{} Also, a race condition existed that resulted in pending transactions only getting deleted from the local database in certain circumstances (fast connections under Chrome, mostly). This patch fixes that so that successfully-uploaded transactions are always deleted. This patch also addresses Jonathan's suggestion: 3/ add a message on check in (currently the input becomes empty but the user is not informed). ... and Magnus's suggestion about moving the Synchronize link to the right on the homepage. Also, this addresses the further issues Jonathan noted: - The tab of checkouts always shows "*0* Checkouts" - If I am not well-educated, I click on the "Check out" link on the offline home page, I enter a barcode, click on "Check out" and I get a js error (without user message): "TypeError: curpatron is undefined" (with chromium I get: Numeric transaction modes are deprecated in IDBDatabase.transaction. Use "readonly" or "readwrite"). - There is a "border-right" css rule on the h5.patron-title. It is display when there is no patron selected) [really minor!]. - tables are displayed even if there is no data - The "Clear screen" link (X) points to an old script: circ/offline-circulation.pl - There is a warning when clicking on the "Synchronize" link when the user is offline, but not for the "Pending offline circulation actions" link. - Still exists: > The "Checked in item." message text never disappear (even if I go on the > offline home page (circ/offline.pl#offline-home)). Finally, this patch adds a link to the Pending offline operations page on the synchronize page for easier navigation. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 00:42:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 22:42:54 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21497|0 |1 is obsolete| | --- Comment #51 from Bernardo Gonzalez Kriegel --- Created attachment 21556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21556&action=edit [SIGNED-OFF] Bug 10240 follow-up: don't delete transactions if auth fails When uploading transactions, we were not checking that authentication had succeeded before deleting the transactions from the local database. That was bad. With this patch, we check. That is good. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 00:43:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 22:43:07 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21498|0 |1 is obsolete| | --- Comment #52 from Bernardo Gonzalez Kriegel --- Created attachment 21557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21557&action=edit [SIGNED-OFF] Bug 10240 follow-up: fix display Fix the following two issues: 1) After paying a fine when offline the fine amount becomes NaN. 2) For previous checkouts for a pratron the title and barcode fields have the wrong infomation in them (i.e. they have been swapped) Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 00:43:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 22:43:21 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21499|0 |1 is obsolete| | --- Comment #53 from Bernardo Gonzalez Kriegel --- Created attachment 21558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21558&action=edit [SIGNED-OFF] Bug 10240 follow-up: disable logout/set library Logging out/setting the library does not work while using offline mode, so it makes no sense to present those options to the user. Much better is some sort of explanatory message informing them that those two links don't work. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 00:43:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 22:43:32 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21500|0 |1 is obsolete| | --- Comment #54 from Bernardo Gonzalez Kriegel --- Created attachment 21559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21559&action=edit [SIGNED-OFF] Bug 10240: warn when patron's card is expired This patch improves the alert messages to be slightly better English and warns the librarian if a patron's card has expired. Like all alerts, this is non-fatal since in the case of network failure there is no particular reason to expect that the offline database is current. To test this particular patch you can try checking something out to an expired patron, otherwise test plan remains the same as above. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 00:43:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 22:43:43 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21553|0 |1 is obsolete| | --- Comment #55 from Bernardo Gonzalez Kriegel --- Created attachment 21560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21560&action=edit [SIGNED-OFF] Bug 10240 follow-up: make sure datepicker icons are available offline The next month/previous month icons for the datepicker were not available offline. With this patch they are. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 00:44:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Sep 2013 22:44:30 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 02:57:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 00:57:52 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #57 from Bernardo Gonzalez Kriegel --- (In reply to Srdjan Jankovic from comment #55) > I do not have a LDAP facility, so I cheated. I ran > perl -e 'use C4::Auth_with_ldap; > C4::Auth_with_ldap::_do_changepassword("srdjan", 1000022259, "srdjan");' > and was able to change the password. This part of the cheat I can't replicate. Could you explain a little more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 04:04:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 02:04:50 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21324|0 |1 is obsolete| | --- Comment #36 from Bernardo Gonzalez Kriegel --- Created attachment 21561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21561&action=edit [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. Signed-off-by: Kyle M Hall Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 04:05:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 02:05:03 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21325|0 |1 is obsolete| | --- Comment #37 from Bernardo Gonzalez Kriegel --- Created attachment 21562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21562&action=edit [SIGNED-OFF] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 04:05:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 02:05:14 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21326|0 |1 is obsolete| | --- Comment #38 from Bernardo Gonzalez Kriegel --- Created attachment 21563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21563&action=edit [SIGNED-OFF] Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 04:05:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 02:05:25 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21327|0 |1 is obsolete| | --- Comment #39 from Bernardo Gonzalez Kriegel --- Created attachment 21564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21564&action=edit [SIGNED-OFF] Bug 9044: Change dropdown list into links list Signed-off-by: Bernardo Gonzalez Kriegel That's the one I sign. Comment: At first I don't know where to find links, until I selected an item. Works as described. No koha-qa errors. Solved merge conflict on updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 04:06:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 02:06:33 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 04:37:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 02:37:54 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #58 from Robin Sheat --- (In reply to Bernardo Gonzalez Kriegel from comment #57) > This part of the cheat I can't replicate. > Could you explain a little more? What happens when you try to replicate it? It seems to me like it should work, though I haven't tested it myself. It's just loading the module and calling the password changing function directly, as a real LDAP auth process would. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 05:00:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 03:00:56 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20553|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 21565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21565&action=edit [SIGNED-OFF] Bug 10038: Doubled 'default' entry when creating a new authority type Test plan: - Create a new authority type - Click MARC structure - Verify the pull down has only 1 entry for Default - Go on the authority type home (admin/authtypes.pl) - Click on the "MARC structure" link for the default type - Verify the pull down has only 1 entry for Default This patch adds a sort (on the authtypecode) for these 2 lists. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works as described. No koha-qa errors. When creating a new framework it would be better to have Default on top, but one is way better than two :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 05:01:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 03:01:23 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 05:14:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 03:14:37 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #59 from Bernardo Gonzalez Kriegel --- (In reply to Robin Sheat from comment #58) > (In reply to Bernardo Gonzalez Kriegel from comment #57) > > This part of the cheat I can't replicate. > > Could you explain a little more? > > What happens when you try to replicate it? It seems to me like it should > work, though I haven't tested it myself. > > It's just loading the module and calling the password changing function > directly, as a real LDAP auth process would. If I feed perl -e 'use C4::Auth_with_ldap; C4::Auth_with_ldap::_do_changepassword("test", 12345, "test");' with current password, it returns nothing, and pass is not updated If I put a new password, last argument I suppose, then it returns Password mismatch after update to borrowernumber=12345 at /home/bgkriegel/kohaclone/C4/Auth_with_ldap.pm line 274, line 522. and pass is not updated I enabled ldap changing to 1 1 and just copy/paste ladp server conf from perldoc. And did this because the oneliner do not run if there is no configuration. So, perhaps I'm just doing something wrong, I don't know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:03:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:03:55 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- Testing this. Solved little merge conflict in updatedatabase.pl Run it, new column added. Edit framework, put default value on sample tag, ej. 040c Nothing is saved :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:30:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:30:18 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot --- Applying: Bug 10602: Set a default value for authorities Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 10602: Set a default value for authorities The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:31:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:31:09 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #60 from I'm just a bot --- Applying: bug_9611: use checkpw_hash() instead of md5 hash Using index info to reconstruct a base tree... M C4/SIP/ILS/Patron.pm Falling back to patching base and 3-way merge... Auto-merging C4/SIP/ILS/Patron.pm CONFLICT (content): Merge conflict in C4/SIP/ILS/Patron.pm Patch failed at 0001 bug_9611: use checkpw_hash() instead of md5 hash The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:31:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:31:39 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:37:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:37:05 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:37:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:37:09 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21181|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 21566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21566&action=edit Bug 10602: Set a default value for authorities Some code already exist but the feature does not work. This patch allows to define default values in the authorities framework. Test plan: 1/ Choose a framework, field and subfields. 2/ Define a default value. 3/ Create a new authority and check that the subfield is automatically filled with the default value. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:38:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:38:09 +0000 Subject: [Koha-bugs] [Bug 10967] New: POD ERROR in acqui/booksellers.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10967 Bug ID: 10967 Summary: POD ERROR in acqui/booksellers.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Developer documentation Assignee: gmcharlt at gmail.com Reporter: bartonski at gmail.com QA Contact: testopia at bugs.koha-community.org $ perldoc acqui/booksellers.pl results in POD ERRORS Hey! The above document had some coding errors, which are explained below: Around line 44: '=item' outside of any '=over' Removing '=back' at line 42 resolves issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:39:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:39:29 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:39:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:39:33 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21551|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 21567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21567&action=edit Bug 10965 - Sample itemtypes can't load on new install Bug 10513 added two columns to table itemtypes, but sample_itemtypes can't be loaded because it relies on old structure. This patch rewrites sample_itemtypes.sql, stating explicitly columns, removing backticks and consolidates all in one insertion. To test: 1) On master with current DB structure, delete item types 2) try loading sample_itemtyes.sql It fails with "ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1" 3) apply patch 4) try again, this time it will load and itemtypes created Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:42:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:42:30 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #37 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:43:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:43:09 +0000 Subject: [Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #14 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:44:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:44:07 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #12 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:44:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:44:35 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #16 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:48:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:48:14 +0000 Subject: [Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13369|0 |1 is obsolete| | Attachment #21378|0 |1 is obsolete| | --- Comment #15 from Chris Cormack --- Created attachment 21568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21568&action=edit Bug 9046: FIX wrong test on an arrayref instead of an array EmbedItemsInMarcBiblio does not embed items when the itemnumbers param is given. That breaks the export tools (used from commandline). Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:49:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:49:05 +0000 Subject: [Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13413|0 |1 is obsolete| | Attachment #21379|0 |1 is obsolete| | --- Comment #16 from Chris Cormack --- Created attachment 21569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21569&action=edit Bug 9046: Followup FIX perl v.10 raises an error if itemnumbers if undefined If the itemnumbers parameter is undef, perl raises an error : "Can't use an undefined value as an ARRAY reference" Signed-off-by: Mason James Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:50:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:50:10 +0000 Subject: [Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Chris Cormack --- Signed off the 3.8.x patches, probably can skip QA as they have been in master for a while, but up to the RMaint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:54:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:54:32 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #123 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:55:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:55:02 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:55:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:55:29 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:55:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:55:59 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #9 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:58:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:58:07 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:58:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:58:33 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #7 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:59:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:59:00 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #12 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 06:59:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 04:59:35 +0000 Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #49 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:00:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:00:20 +0000 Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #50 from I'm just a bot --- Applying: Bug 9921 - Make it possible to force 001 = biblionumber Using index info to reconstruct a base tree... M C4/Biblio.pm M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging C4/Biblio.pm Patch failed at 0001 Bug 9921 - Make it possible to force 001 = biblionumber The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:00:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:00:47 +0000 Subject: [Koha-bugs] [Bug 10482] add items limit and sort to rebuild zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:10:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:10:42 +0000 Subject: [Koha-bugs] [Bug 10967] POD ERROR in acqui/booksellers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10967 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ketan at carvingit.com --- Comment #1 from Ketan Kulkarni --- Created attachment 21570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21570&action=edit minor fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:11:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:11:13 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:11:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:11:16 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21525|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 21571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21571&action=edit Bug 6201 - Add fields 1xx to marc2bibtex Modified Record::marc2bibtex to varlidate fields 100,110 and 111 in non-Unimarc flavours. Test plan: 1)Search any books in the OPAC with a main entry (1XX in MARC21, 700-720 in Unimarc) 2)Export the record in the bibtex format ==>The output won't contains the main entry. 3)Apply the patch \n4)Export the record ==>The record will contain the main entry Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:11:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:11:55 +0000 Subject: [Koha-bugs] [Bug 10967] POD ERROR in acqui/booksellers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10967 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |ketan at carvingit.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:16:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:16:58 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:17:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:17:04 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21532|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 21572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21572&action=edit Bug 10962 - Update MARC21 frameworks to Update Nr. 17 (September 2013) This patch updates MARC21 default bibliografic framework and authorities frameworks to Update Nr. 17 (September 2013) Source Bibliographic: http://www.loc.gov/marc/bibliographic/bdapndxg.html Authorities: http://www.loc.gov/marc/authority/adapndxf.html Only to new installs. To test 1) Remove default MARC21 framework 2) Load marc21_framework_DEFAULT.sql 3) Verify new subtags 015_q 020_q 024_q 027_q 800_7 810_7 811_7 830_7 4) Remove authorities frameworks 5) Load authorities_normal_marc21.sql 6) Verify new subtags 020_q 024_q Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:24:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:24:32 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21554|0 |1 is obsolete| | --- Comment #56 from Chris Cormack --- Created attachment 21573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21573&action=edit Bug 10240: Offline circulation using HTML5 and IndexedDB This patch adds an HTML5-based offline mode to Koha's existing circulation module, allowing librarians to check out items using a basically familiar interface. The feature will be implemented using the Application Cache and IndexedDB features of the HTML5 specification, both of which are fully supported on Firefox 10+ and Chrome 23+, with limited support going back to Firefox 4 and Chrome 11. The basic workflow enabled by this patch is as follows: Part 1: While connected to the Internet 1. Enable offline functionality by turning on the "AllowOfflineCirculation" system preference. 2. Sync the offline circulation database on the computer that will be used for offline circulation by following the "Offline circulation interface" link on the Circulation home page, choosing "Synchronize (must be online)", and clicking the "Download records" button. This process may take a while. 3. Bookmark /cgi-bin/koha/circ/offline.pl (the page you are currently on) for easy access when offline. Part 2: While disconnected from the Internet 4. Navigate to /cgi-bin/koha/circ/offline.pl using the bookmark you created while online. 5. Start checking books in by scanning the barcode of an item that has been returned into the box in the "Check in" tab. 6. Scan the barcodes of any additional items that have been returned. 7. Start checking out books to a patron by scanning the patron's barcode in the box in the "Check out" tab. 8. Set a due date (the "Remember for session" box will be checked by default, since circulation rules are not computed during offline transactions and therefore a due date must be specified by the librarian). 9. Scan an item barcode (if you did not set a due date, it will prompt you) to check the item out to the patron. 10. If a patron has a fine you can see the total amount (current to when the offline module was synced), and record a payment. Unlike when in online mode, there will be no breakdown of what item(s) fines are for, and you will only be able to record the payment amount and not associate it with a particular item. Part 3: While connected to the Internet 11. Click the "Synchronize" link and choose "Upload transactions" to upload the transactions recorded during the offline circulation session. 12. Navigate to /cgi-bin/koha/offline_circ/list.pl (there will be a link from the Offline circulation page) and review the transactions, as described in the documentation for the Firefox Offline circulation plugin: http://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin Signed-off-by: Chris Cormack Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works very well, no koha-qa errors Test with Firefox 24.0 1) did some checkouts pre sync 2) synchronize database (Download) 3) go offline 4) Proceed to checkin some items from patron 5) Proceed to checkout items to patrons, setting date 6) Proceed to checkout to expired patron, warning appears 7) go online 8) Upload records 9) go to review transacctions and proceed 10) verified on patrons that checkin/out are done Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:25:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:25:07 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21555|0 |1 is obsolete| | --- Comment #57 from Chris Cormack --- Created attachment 21574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21574&action=edit Bug 10240 QA follow-up Address the following issues: 1/ Address minor qa issues with the templates: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 24) [etc.] OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 509) [etc.] FAIL tt_valid lines 5, 5 2/ Run perltidy on new scripts 3/ download.pl returns data.finished = 1 if number of returned data < 5000 (avoids 1 ajax call) 4/ Replace qq{} around sql queries with q{} Also, a race condition existed that resulted in pending transactions only getting deleted from the local database in certain circumstances (fast connections under Chrome, mostly). This patch fixes that so that successfully-uploaded transactions are always deleted. This patch also addresses Jonathan's suggestion: 3/ add a message on check in (currently the input becomes empty but the user is not informed). ... and Magnus's suggestion about moving the Synchronize link to the right on the homepage. Also, this addresses the further issues Jonathan noted: - The tab of checkouts always shows "*0* Checkouts" - If I am not well-educated, I click on the "Check out" link on the offline home page, I enter a barcode, click on "Check out" and I get a js error (without user message): "TypeError: curpatron is undefined" (with chromium I get: Numeric transaction modes are deprecated in IDBDatabase.transaction. Use "readonly" or "readwrite"). - There is a "border-right" css rule on the h5.patron-title. It is display when there is no patron selected) [really minor!]. - tables are displayed even if there is no data - The "Clear screen" link (X) points to an old script: circ/offline-circulation.pl - There is a warning when clicking on the "Synchronize" link when the user is offline, but not for the "Pending offline circulation actions" link. - Still exists: > The "Checked in item." message text never disappear (even if I go on the > offline home page (circ/offline.pl#offline-home)). Finally, this patch adds a link to the Pending offline operations page on the synchronize page for easier navigation. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:25:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:25:27 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21556|0 |1 is obsolete| | --- Comment #58 from Chris Cormack --- Created attachment 21575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21575&action=edit Bug 10240 follow-up: don't delete transactions if auth fails When uploading transactions, we were not checking that authentication had succeeded before deleting the transactions from the local database. That was bad. With this patch, we check. That is good. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:25:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:25:41 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21557|0 |1 is obsolete| | --- Comment #59 from Chris Cormack --- Created attachment 21576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21576&action=edit Bug 10240 follow-up: fix display Fix the following two issues: 1) After paying a fine when offline the fine amount becomes NaN. 2) For previous checkouts for a pratron the title and barcode fields have the wrong infomation in them (i.e. they have been swapped) Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:25:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:25:55 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21558|0 |1 is obsolete| | --- Comment #60 from Chris Cormack --- Created attachment 21577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21577&action=edit Bug 10240 follow-up: disable logout/set library Logging out/setting the library does not work while using offline mode, so it makes no sense to present those options to the user. Much better is some sort of explanatory message informing them that those two links don't work. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:26:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:26:12 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21559|0 |1 is obsolete| | --- Comment #61 from Chris Cormack --- Created attachment 21578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21578&action=edit Bug 10240: warn when patron's card is expired This patch improves the alert messages to be slightly better English and warns the librarian if a patron's card has expired. Like all alerts, this is non-fatal since in the case of network failure there is no particular reason to expect that the offline database is current. To test this particular patch you can try checking something out to an expired patron, otherwise test plan remains the same as above. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:26:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:26:27 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21560|0 |1 is obsolete| | --- Comment #62 from Chris Cormack --- Created attachment 21579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21579&action=edit Bug 10240 follow-up: make sure datepicker icons are available offline The next month/previous month icons for the datepicker were not available offline. With this patch they are. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:28:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:28:16 +0000 Subject: [Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #7 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:28:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:28:34 +0000 Subject: [Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:28:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:28:54 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #18 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:29:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:29:21 +0000 Subject: [Koha-bugs] [Bug 7484] Keeping typed values when searching for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #3 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:29:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:29:50 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #8 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:30:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:30:35 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #16 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:31:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:31:04 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:31:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:31:36 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #36 from I'm just a bot --- Applying: Bug 8773 - Start per-instance koha-index-daemon in .deb setup Using index info to reconstruct a base tree... M debian/koha-common.init M debian/koha-common.install M debian/scripts/koha-create Falling back to patching base and 3-way merge... Auto-merging debian/scripts/koha-create Auto-merging debian/koha-common.install Auto-merging debian/koha-common.init CONFLICT (content): Merge conflict in debian/koha-common.init Auto-merging debian/koha-common.default CONFLICT (add/add): Merge conflict in debian/koha-common.default Patch failed at 0001 Bug 8773 - Start per-instance koha-index-daemon in .deb setup The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:32:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:32:07 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:32:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:32:34 +0000 Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:33:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:33:09 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #8 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:33:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:33:36 +0000 Subject: [Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start zebra due to log permission problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:34:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:34:06 +0000 Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #4 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:35:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:35:47 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #9 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:36:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:36:15 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #4 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:36:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:36:42 +0000 Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #5 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:37:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:37:18 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #7 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:37:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:37:45 +0000 Subject: [Koha-bugs] [Bug 10750] Correct capitalization on suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:38:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:38:15 +0000 Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #3 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:38:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:38:42 +0000 Subject: [Koha-bugs] [Bug 10776] Subscription notification screen has awkward wording In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:39:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:39:09 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #8 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:39:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:39:36 +0000 Subject: [Koha-bugs] [Bug 10789] Excessive and often incorrect use of finish in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10789 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:40:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:40:10 +0000 Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #17 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:41:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:41:03 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #7 from I'm just a bot --- Applying: Bug 10609: Use branch name rather than branch code in serials-collection.pl (3.12.x) Using index info to reconstruct a base tree... M C4/Serials.pm M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Auto-merging C4/Serials.pm Patch failed at 0001 Bug 10609: Use branch name rather than branch code in serials-collection.pl (3.12.x) The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:41:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:41:21 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #9 from I'm just a bot --- This bug depends on 9740 which is in status Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:41:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:41:47 +0000 Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:48:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:48:32 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:48:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:48:35 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20707|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 21580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21580&action=edit Bug 10609: Use branch name rather than branch code in serials-collection.pl (3.12.x) This is the 3.12.x compatible version of the patch for 10609. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:51:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:51:03 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #5 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:51:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:51:30 +0000 Subject: [Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #4 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:51:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:51:57 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:52:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:52:24 +0000 Subject: [Koha-bugs] [Bug 10829] Browse across pages breaks for authority searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #3 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:52:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:52:55 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #4 from I'm just a bot --- Applying: Bug 9016: DB changes: new table overduerules_transport_types Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 9016: DB changes: new table overduerules_transport_types The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:53:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:53:09 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #5 from I'm just a bot --- This bug depends on bug9016 which is in status Needs Signoff but the patches for it do not apply cleanly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:53:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:53:40 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Applying: Bug 9016: DB changes: new table overduerules_transport_types Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 9016: DB changes: new table overduerules_transport_types The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:53:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:53:54 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 --- Comment #3 from I'm just a bot --- This bug depends on bug9016 which is in status Needs Signoff but the patches for it do not apply cleanly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:54:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:54:20 +0000 Subject: [Koha-bugs] [Bug 10834] Add Sort 1 and Sort 2 to list of searchable patron fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10834 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:54:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:54:48 +0000 Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:55:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:55:16 +0000 Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices table doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:55:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:55:42 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:56:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:56:10 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #8 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:56:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:56:37 +0000 Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted the same on all forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:57:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:57:08 +0000 Subject: [Koha-bugs] [Bug 10850] Give Quick spine label template page its own id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10850 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:57:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:57:37 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #9 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:58:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:58:05 +0000 Subject: [Koha-bugs] [Bug 9084] Dates in notices should be formatted according to dateformat system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #9 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:58:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:58:32 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #8 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:58:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:58:59 +0000 Subject: [Koha-bugs] [Bug 10890] Autobarcode "yymm00001" Fails in Acquisitions When Receiving Item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10890 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #3 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 07:59:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 05:59:35 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #16 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:00:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:00:29 +0000 Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #7 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:00:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:00:56 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #13 from I'm just a bot --- Applying: Bug 9016: DB changes: new table overduerules_transport_types Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 9016: DB changes: new table overduerules_transport_types The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:01:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:01:24 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #24 from I'm just a bot --- Applying: Bug 6149 - Stopwords for Result Highlighting Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Patch failed at 0001 Bug 6149 - Stopwords for Result Highlighting The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:02:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:02:10 +0000 Subject: [Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #10 from I'm just a bot --- This bug depends on 7167 which has no valid patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:02:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:02:40 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #17 from I'm just a bot --- Applying: Bug 10212: Columns configuration for tables Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 10212: Columns configuration for tables The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:03:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:03:39 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21509|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:04:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:04:34 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:04:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:04:37 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot --- Applying: Bug 10875: Add order from a staged file should not display inactive funds Using index info to reconstruct a base tree... M acqui/addorderiso2709.pl M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt Auto-merging acqui/addorderiso2709.pl Patch failed at 0001 Bug 10875: Add order from a staged file should not display inactive funds The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:05:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:05:06 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #10 from I'm just a bot --- Applying: Bug 8992: Interfacing with the Idref webservice Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl M koha-tmpl/opac-tmpl/prog/en/css/opac.css M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 8992: Interfacing with the Idref webservice The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:05:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:05:26 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #143 from Ketan Kulkarni --- Created attachment 21581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21581&action=edit one more file updated ... opac-search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:05:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:05:38 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #18 from I'm just a bot --- Applying: Bug 10855: Update database entry Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 10855: Update database entry The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:06:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:06:11 +0000 Subject: [Koha-bugs] [Bug 9163] Cataloguing validation workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #23 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:06:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:06:48 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #11 from I'm just a bot --- Applying: Bug 10860: In-House Use Using index info to reconstruct a base tree... M C4/Circulation.pm M C4/Items.pm M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Items.pm Auto-merging C4/Circulation.pm Patch failed at 0001 Bug 10860: In-House Use The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:07:17 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #4 from I'm just a bot --- Applying: Bug 10861: Add a check on cardnumber length Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 10861: Add a check on cardnumber length The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:08:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:08:24 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #11 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:08:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:08:51 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #8 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:09:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:09:11 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #5 from I'm just a bot --- This bug depends on 9016 which is in status Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:09:44 +0000 Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #4 from I'm just a bot --- Applying: Bug 2693 - Tagging: Add filter by name Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt Patch failed at 0001 Bug 2693 - Tagging: Add filter by name The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:10:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:10:03 +0000 Subject: [Koha-bugs] [Bug 10859] Alert if a patron already has an issue for the same biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #4 from I'm just a bot --- This bug depends on 10863 which is in status Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:10:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:10:34 +0000 Subject: [Koha-bugs] [Bug 10689] public note does not appear in subscriptions search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:11:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:11:03 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #4 from I'm just a bot --- Applying: Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:11:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:11:31 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #10 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:12:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:12:08 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #24 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:12:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:12:40 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #11 from I'm just a bot --- Applying: Bug 10853: Add DB field export_format.type ('marc' or 'sql'). Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 10853: Add DB field export_format.type ('marc' or 'sql'). The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:12:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:12:54 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 --- Comment #12 from I'm just a bot --- This bug depends on bug10853 which is in status Passed QA but the patches for it do not apply cleanly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:13:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:13:29 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #30 from I'm just a bot --- Applying: Bug 9043 - Changes to the advanced search page Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref M koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt M opac/opac-search.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Patch failed at 0001 Bug 9043 - Changes to the advanced search page The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:15:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:15:28 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #7 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:15:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:15:55 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in opac results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:16:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:16:26 +0000 Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list turned out untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:17:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:17:29 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #64 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:17:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:17:57 +0000 Subject: [Koha-bugs] [Bug 10905] Author tracings incorrect when UseAuthoritiesForTracings is turned on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10905 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:18:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:18:28 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #5 from I'm just a bot --- Applying: Bug 10858 [Follow-up] Browse selected biblios Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/prog/en/css/opac.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css Patch failed at 0001 Bug 10858 [Follow-up] Browse selected biblios The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:20:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:20:25 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #138 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:21:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:21:06 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #29 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:21:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:21:41 +0000 Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the payment made In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #3 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:22:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:22:09 +0000 Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:22:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:22:40 +0000 Subject: [Koha-bugs] [Bug 10957] 710$a with 710$b (subordinate unit) present shows wrong (XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10957 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:23:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:23:19 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #25 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:23:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:23:50 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #12 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:24:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:24:21 +0000 Subject: [Koha-bugs] [Bug 10967] POD ERROR in acqui/booksellers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10967 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:50:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:50:42 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:50:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:50:46 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #25 from Chris Cormack --- Created attachment 21582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21582&action=edit Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Chris Cormack Works as advertised, I fixed the updatedatabase to use XXX so it won't clash as much -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:53:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:53:32 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:53:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:53:37 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21178|0 |1 is obsolete| | --- Comment #18 from Chris Cormack --- Created attachment 21583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21583&action=edit Bug 10212: Columns configuration for tables - Add Colvis files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:53:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:53:53 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21179|0 |1 is obsolete| | --- Comment #19 from Chris Cormack --- Created attachment 21584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21584&action=edit Bug 10212: Columns configuration for tables This development introduces ColVis into Koha and provides a configuration page for columns visibility. ColVis is a plugin for DataTables. It allows to change the visibility of the columns in the table. * This development adds: - the js and css file for ColVis - a new DB table 'columns_settings' - a new template plugin 'ColumnsSettings' - a new package C4::Utils::DataTables::ColumnsSettings - a new admin page admin/columns_settings.pl * How it works: A yaml file is created (admin/columns_settings.yml) in order to take an inventory of all tables where ColVis is implemented. This file is read to create the list of modules, pages and tables in the configuration page. There are 3 possible keys in the yml: - is_hidden: default is 0 The column will be hidden. - cannot_be_toggled: default is 0. ColVis will allow to hide/show the column. - cannot_be_modified: default is 0 Default values (in the yml) won't be modifiable. When a user changes (or saves) the configuration for one module, all columns are added to the DB table. The values in the DB get the upper hand on the yaml values. * Humm, strange? It seems weird to have 2 storages for the same values. But I think it will be easy to add an entry and maintain the yaml rather than adding a new row (and new entry in updatedatabase script) in the DB. * Test plan: 1/ Execute the updatedatabase in order to create the new table. 2/ Take a look to the yml structure. 3/ Go on the checkouts page (circ/circulation.pl). 4/ Check that you cannot hide the 3 last columns on the issues table. 5/ Check that you cannot hide the 2 last columns on the holds table. 6/ Try to hide/show columns. 7/ Go on the columns configuration page (admin/columns_settings.pl). 8/ Only the last tab are filled with data. Check/uncheck checkboxes and save. 9/ Go on the checkouts/holds page and check that the behavior is what you expected. 10/ Give me some feedback :) * To go further: We can imagine that the configuration is saved for each user (and not globally like it is made with this patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:54:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:54:06 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21180|0 |1 is obsolete| | --- Comment #20 from Chris Cormack --- Created attachment 21585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21585&action=edit Bug 10212: Make the table names translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:56:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:56:14 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |chris at bigballofwax.co.nz Bot Control|--- |No Status change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:58:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:58:08 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 08:58:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 06:58:11 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21196|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 21586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21586&action=edit Bug 10861: Add a check on cardnumber length Some libraries would like to add a check on the cardnumber length. This patch adds the ability to restrict the cardnumber to a specific length (strictly equal to XX, or length > XX or min < length < max). This restriction is checked on inserting/updating a patron or on importing patrons. This patch adds: - 1 new syspref CardnumberLength. 2 formats: a number or a range (xx,yy). - 1 new unit test file t/Members/checkcardnumber.t for the C4::Members::checkcardnumber routine. Test plan: 1/ Fill the pref CardnumberLength with '5,8' 2/ Create a new patron with an invalid cardnumber (123456789) 3/ Check that you cannot save 4/ With Firebug, replace the pattern attribute value (for the cardnumber input) with ".{5,10}" 5/ You are allowed to save but an error occurred. 6/ Try the same steps for update. 7/ Go to the import borrowers tool. 8/ Play with the import borrowers tool. We must test add/update patrons and the "record matching" field (cardnumber or a uniq patron attribute) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 09:00:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 07:00:23 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 09:00:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 07:00:26 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21216|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 21587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21587&action=edit Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults This patch adds a default record matching rule for biblionumber using the 999$c and the Local-Number index. This is part of the optional marc21 SQL, as well as in the updatabase.pl script. TEST PLAN 0) Apply the patch 1) Run updatedatabase.pl 2) Export some MARC bibliographic records from Koha 3) Import those same MARC bibliographic records using the "KohaBiblio" record matching rule. 4) The incoming records should match perfectly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 09:02:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 07:02:24 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |chris at bigballofwax.co.nz Bot Control|--- |No Status change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 10:05:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 08:05:05 +0000 Subject: [Koha-bugs] [Bug 10454] Duplicate card numbers may be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion CC| |z.tajoli at cineca.it --- Comment #22 from Zeno Tajoli --- Hi to all, I try to check the situation, and It appears that every SQL software uses a different solution for this problem. For example on Postegresql: http://stackoverflow.com/questions/2944297/postgresql-function-for-last-inserted-id So i think that mysqlism (and xxxism) are mandatory for this problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 10:34:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 08:34:30 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Pierre Angot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #77 from Pierre Angot --- Hi ! We are interrested by this patch and by 8230 :) Did someone do the QA for this one ? Is it possible do have this patch for 3.10 and 3.12 ? Do we need to make other tests ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 10:39:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 08:39:39 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #9 from mathieu saby --- Bug 8252 has been signed off by Bernardo Gonzales Kriegel and Fr?d?ric Demians. I'm waiting for its QA. When it is pushed we could do other improvements/corrections, like the one proposed by Fridolyn. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 10:55:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 08:55:08 +0000 Subject: [Koha-bugs] [Bug 10966] in advanced search, location should be handled in a better way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Hi Mathieu, you can already do that using the AdvancedSearchTypes system preference. I think we should remove location from the pull down. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 10:59:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 08:59:36 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Bit worried about Bernardo's comment a bit earlier - do we know what happened there? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 11:25:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 09:25:00 +0000 Subject: [Koha-bugs] [Bug 10966] in advanced search, location should be handled in a better way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10966 --- Comment #2 from mathieu saby --- Hi Katrin I did not check the syspref ;-) All I know is that it is unneeded in the pulldown. By the way, a way to defining the indexes to display in the pulldown on advanced and simple search (on staff and opac) could be interesting too. I know it could be done in jquery, like other stuff, but I would prefer a config page. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 11:26:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 09:26:26 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #78 from Katrin Fischer --- This is a new feature waiting for QA - I have it on my list and hope to get some work done in it today. As it's a new feature it is very unlikely to get backported to older versions like 3.12 and 3.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 11:26:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 09:26:38 +0000 Subject: [Koha-bugs] [Bug 10968] New: Add a way to choose which indexes to display on simple and advanced search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10968 Bug ID: 10968 Summary: Add a way to choose which indexes to display on simple and advanced search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org A way to defining the indexes to display in the pulldown on advanced and simple search (on staff and opac) could be interesting. I know it could be done in jquery, like other stuff, but I would prefer a config page. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 11:27:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 09:27:42 +0000 Subject: [Koha-bugs] [Bug 10966] in advanced search, location should be handled in a better way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10966 --- Comment #3 from Katrin Fischer --- I agree it would be nice - lots of people here are complaining about "Curriculum" - the problem is the usual: translatability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 11:30:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 09:30:59 +0000 Subject: [Koha-bugs] [Bug 10968] Add a way to choose which indexes to display on simple and advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10968 --- Comment #1 from mathieu saby --- I'm working on a bug for choosing indexes to use for building facets. When it is pushed, maybe parts of code could be reuse for that. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 11:32:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 09:32:15 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #79 from mathieu saby --- I understand Katrin, but it's sad, because this feature has apparently been developped in 2011, and I first tested it one year ago... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 11:35:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 09:35:03 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #80 from Katrin Fischer --- It often makes me sad too to see things sit for a long time, but we can all only do as much as we can. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 12:26:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 10:26:43 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #81 from Pierre Angot --- Thank's for your answers ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 13:09:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 11:09:29 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- I have found some smaller problems with this script that I wanted to note: 1) When I start the script without giving any parameters nothing happens. Maybe it would be helpful to print out the help in this case? 2) The script updates serial issues that are already late and claimed with the note. I think it shouldn't touch issues that are already marked late in the interface. 3) The script overwrites and deletes existing notes on the issues. I think all this problems predate your patch, but I am quite worried about 2) and 3). The existing notes can now be preserved using the --no-note option, but I think ideally the new notes should be amended to the existing one in general. Still, this patch is an improvement, so it will pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 13:10:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 11:10:12 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #9 from mathieu saby --- I put it in discussion, as the patch probably need to be fixed (I had no time to do that for the moment.) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 13:14:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 11:14:54 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 13:14:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 11:14:57 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20871|0 |1 is obsolete| | Attachment #20872|0 |1 is obsolete| | Attachment #20873|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 21588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21588&action=edit [PASSED QA] Bug 9739: more options for serialsUpdate.pl Script serialsUpdate.pl must be set in crontab to run daily. It checks serials that are late, modifies status and adds a note. This patch adds some options : --note : defined note, a defaut one is used if not defined --no-note : disable automatic note --verbose : used to control output This patch also implements confirmation option "-c" who whas present but not used. Test plan : Run script on a database with late serials : - serialsUpdate.pl -h => you get help text in output - serialsUpdate.pl --man => you get full help - serialsUpdate.pl -v => you get output of changed serials but database has not changed - serialsUpdate.pl -c -v => you get output of changed serials and database has changed, with note "Automatically set to late" - serialsUpdate.pl -c => database has changed without anything in output - serialsUpdate.pl -c --note "LATE" => database has changed, with note "LATE" - serialsUpdate.pl -c --no-note => database has changed with no note Signed-off-by: Bernardo Gonzalez Kriegel Works as described. No koha-qa errors. Signed-off-by: Katrin Fischer Passes all tests and QA script. New options behave as described. There are some existing problems with this script that I have noted directly on the bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 13:15:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 11:15:10 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #14 from Katrin Fischer --- Created attachment 21589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21589&action=edit [PASSED QA] Bug 9739: more options for serialsUpdate.pl (followup) cosmetic changes : perltidy q{} for query list of columns is query instead of SELECT * Signed-off-by: Bernardo Gonzalez Kriegel Your cosmetic changes missed a comma, fixed in a followup Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 13:15:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 11:15:21 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #15 from Katrin Fischer --- Created attachment 21590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21590&action=edit [PASSED QA] Bug 9739 - followup - adds missing comma Adds a missing comma in select statement. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 14:08:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 12:08:43 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #82 from Katrin Fischer --- Pierre, if you could confirm that partially received orders are correctly recognized by the database update that would be helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 14:12:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 12:12:36 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #83 from Katrin Fischer --- Well, Pierre or anyone else :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 14:33:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 12:33:34 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #40 from Katrin Fischer --- Created attachment 21591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21591&action=edit Screnshot, search filters for materials and barcode are broken. I think this is very close to ready, but there is a problem with the search filters (see screenshot). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 14:34:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 12:34:07 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 14:36:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 12:36:52 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #41 from Katrin Fischer --- I verified the search filters show correctly for all columns on master. Apart from that I found no problems - also tested with SeparateHoldings and SeparateHoldingsBranch. Please provide a follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 15:04:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 13:04:34 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer --- I have started testing this, but ran into something that doesn't seem right: Testing notes: ./delete_patrons.pl Gives a helpful message about the use of the script. ./delete_patrons.pl -h Outputs useful information about the use of the script and its various options. ./delete_patrons.pl --category_code ST --library CPL Gives the correct results in numbers and deletion was done properly. Testing various conditions where a delete should not occur: - Patron has checkouts Patron is not in list of patrons to delete (x patrons to delete) - Patron has fines Patron is still in list of patrons to delete (x patrons to delete) Patron is deleted, script gives no success message. ./delete_patrons.pl --category_code ST --library CPL -c 1 patrons to delete When you check the database, the patron has been deleted (including the move to deletedborrowers), although he owed money to the library. (I used a MANUAL_INV of copier fees here). I verified that deleting patrons with fines is not possible in the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 15:06:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 13:06:24 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #32 from Katrin Fischer --- Also, I think there should be feedback about when the script is done? Even if it was just: x patrons deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 15:34:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 13:34:42 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #16 from Katrin Fischer --- Created attachment 21592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21592&action=edit Bug 9739: Follow-up - Improve help text a bit Changes only strings in the script: the help text and the success message for updated serial issues. Thx to Jared for proof reading! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 15:41:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 13:41:46 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 --- Comment #13 from Katrin Fischer --- I think we need this one to make sense of the other depending bug - can I please get a sign off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 15:54:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 13:54:40 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- I am sorry, but I have to agree with Bernardo - this is not yet working for me: Verified database update is done correctly. Controlfields 0xx - Editing an existing field (001) - Setting a default value for subfield @ NOT OK There is nothing in the logs, but the default value does not save Also somehow the plugin information ended up in the default column when I tried this? Fields - Editing an existing field 100 - Setting a default value for subfield e NOT OK Default value is not saved - it doesn't show on repeated editing and it's also not in the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 17:43:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 15:43:41 +0000 Subject: [Koha-bugs] [Bug 10967] POD ERROR in acqui/booksellers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10967 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21570|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 21593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21593&action=edit [SIGNED-OFF] Bug 10967 - minor fix http://bugs.koha-community.org/show_bug.cgi?id=10967 Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors. Fixes problem, but I think is better to remove =back than to add nother =over 4, but I'm not a POD expert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 17:44:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 15:44:15 +0000 Subject: [Koha-bugs] [Bug 10967] POD ERROR in acqui/booksellers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10967 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 17:49:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 15:49:12 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21572|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 21594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21594&action=edit [PASSED QA] Bug 10962 - Update MARC21 frameworks to Update Nr. 17 (September 2013) This patch updates MARC21 default bibliografic framework and authorities frameworks to Update Nr. 17 (September 2013) Source Bibliographic: http://www.loc.gov/marc/bibliographic/bdapndxg.html Authorities: http://www.loc.gov/marc/authority/adapndxf.html Only to new installs. To test 1) Remove default MARC21 framework 2) Load marc21_framework_DEFAULT.sql 3) Verify new subtags 015_q 020_q 024_q 027_q 800_7 810_7 811_7 830_7 4) Remove authorities frameworks 5) Load authorities_normal_marc21.sql 6) Verify new subtags 020_q 024_q Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 17:49:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 15:49:09 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 17:50:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 15:50:12 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Bernardo, will you also provide a database update to add those new fields for existing installations? How does this go together with your other pending patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 17:57:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 15:57:17 +0000 Subject: [Koha-bugs] [Bug 10967] POD ERROR in acqui/booksellers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 17:57:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 15:57:21 +0000 Subject: [Koha-bugs] [Bug 10967] POD ERROR in acqui/booksellers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21593|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 21595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21595&action=edit [PASSED QA] Bug 10967 - minor fix http://bugs.koha-community.org/show_bug.cgi?id=10967 Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors. Fixes problem, but I think is better to remove =back than to add nother =over 4, but I'm not a POD expert Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:13:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:13:09 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 --- Comment #6 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #5) > Hi Bernardo, > will you also provide a database update to add those new fields for existing > installations? How does this go together with your other pending patches? Yes, it can be done easily. As a folloup or another bug? As for pending patches, there is only Bug 10963 and that just copy from default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:18:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:18:59 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 --- Comment #7 from Katrin Fischer --- Mm, maybe on another, as this is already passed QA? This way there will be no confusion with status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:20:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:20:41 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:20:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:20:44 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21565|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 21596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21596&action=edit [PASSED QA] Bug 10038: Doubled 'default' entry when creating a new authority type Test plan: - Create a new authority type - Click MARC structure - Verify the pull down has only 1 entry for Default - Go on the authority type home (admin/authtypes.pl) - Click on the "MARC structure" link for the default type - Verify the pull down has only 1 entry for Default This patch adds a sort (on the authtypecode) for these 2 lists. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works as described. No koha-qa errors. When creating a new framework it would be better to have Default on top, but one is way better than two :) Signed-off-by: Katrin Fischer Agreed, one is better than two :) All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:23:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:23:03 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I think we need follow-ups to fix the translated installers as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:27:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:27:54 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:27:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:27:57 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21567|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 21597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21597&action=edit [PASSED QA] Bug 10965 - Sample itemtypes can't load on new install Bug 10513 added two columns to table itemtypes, but sample_itemtypes can't be loaded because it relies on old structure. This patch rewrites sample_itemtypes.sql, stating explicitly columns, removing backticks and consolidates all in one insertion. To test: 1) On master with current DB structure, delete item types 2) try loading sample_itemtyes.sql It fails with "ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1" 3) apply patch 4) try again, this time it will load and itemtypes created Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer SQL change only. Tested by running the web installer on an empty database. All sample data loads without errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:40:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:40:42 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 --- Comment #6 from Katrin Fischer --- Working on a follow-up for translated installers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:45:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:45:28 +0000 Subject: [Koha-bugs] [Bug 10689] public note does not appear in subscriptions search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21100|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 21598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21598&action=edit [SIGNED-OFF] Bug 10689 - public note does not appear in subscriptions search In a serials module, when searching subscriptions, the results table as a "Notes" column. In TT code, you see that it tries to display public note "subscription.notes" and internal note "subscription.internalnotes". Internal note is well displayed but not public note. You can see the 2 notes in serial details in summary tab. The problem commes from the SQL query. A join is perform on subscription and biblio, both containing a "notes" column. This patch solves the problem by using a alias in query for both columns (biblio.notes is acutally not used in template but could be). Test plan : - Edit a subscription - Add public and internal notes. For example : "too busy" and "on holiday" - Perform a subscription search that returns this subscription => "Notes" column contains both notes. For example : "too busy (on holiday)" - Test with only public note - Test with only internal note ==== Works as described. Signed-off-by:Mathieu Saby Signed-off-by: Bernardo Gonzalez Kriegel Adding a sign -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:45:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:45:40 +0000 Subject: [Koha-bugs] [Bug 10689] public note does not appear in subscriptions search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21207|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 21599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21599&action=edit [SIGNED-OFF] Bug 10689 - public note does not appear in new order form a subscription Test by creating a new order to a basket using "From a subscription" link Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works as described. No koha-qa errors When creating a new basket from a susbcription, public note shows on Notes column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:46:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:46:26 +0000 Subject: [Koha-bugs] [Bug 10689] public note does not appear in subscriptions search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:48:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:48:45 +0000 Subject: [Koha-bugs] [Bug 10969] New: Fix sample itemtypes for translated installers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969 Bug ID: 10969 Summary: Fix sample itemtypes for translated installers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Because of a change in the itemtypes table structure some of the sample files can no longer be loaded correctly. Patch applies change from 10965 to the translated itemtype sample files. To test: - Install the specific language and run the web installer. Or: - Truncate or delete all from the itemtypes table in your database. - Try to run the complete SQL in the itemtypes sample files. - Verify the table is filled correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:49:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:49:43 +0000 Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated installers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10965 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:49:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:49:43 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10969 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:49:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:49:49 +0000 Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated installers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:50:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:50:10 +0000 Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated installers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 18:50:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 16:50:14 +0000 Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated installers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969 --- Comment #1 from Katrin Fischer --- Created attachment 21600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21600&action=edit Bug 10969: Fix sample itemtypes for translated installers To test: - Install the specific language and run the web installer. Or: - Truncate or delete all from the itemtypes table in your database. - Try to run the complete SQL in the itemtypes sample files. Verify the table is filled correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:11:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:11:34 +0000 Subject: [Koha-bugs] [Bug 10970] New: Update MARC21 frameworks to Update Nr. 17 - DB update Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970 Bug ID: 10970 Summary: Update MARC21 frameworks to Update Nr. 17 - DB update Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Update MARC21 frameworks to Update Nro. 17 for current installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:22:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:22:40 +0000 Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 - DB update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 21601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21601&action=edit Bug 10970 - Update MARC21 frameworks to Update Nr. 17 - DB update Database counterpart of Bug 10962. Updates existing MARC21 default frameworks to Update Nr. 17 (September 2013) To test 1) Apply patch 2) run updatedatabase.pl 3) Verify new subtags biblio 015_q 020_q 024_q 027_q 800_7 810_7 811_7 830_7 authorities 020_q 024_q -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:26:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:26:46 +0000 Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17 (September 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962 --- Comment #8 from Bernardo Gonzalez Kriegel --- Done! Bug 10970 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:26:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:26:52 +0000 Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 - DB update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:29:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:29:32 +0000 Subject: [Koha-bugs] [Bug 10971] New: Hide EAN search option for MARC21 when Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 Bug ID: 10971 Summary: Hide EAN search option for MARC21 when Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:30:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:30:51 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hide EAN search option for |Hide EAN search option for |MARC21 when |MARC21 when 'ordering from | |subscription' --- Comment #1 from Katrin Fischer --- The filters on the subscription search when you 'order from subscription' should not show EAN, as this is only functional for UNIMARC installations. Also "branch" should be "library" and "supplier" should be labelled "vendor". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:31:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:31:59 +0000 Subject: [Koha-bugs] [Bug 10689] public note does not appear in subscriptions search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:32:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:32:04 +0000 Subject: [Koha-bugs] [Bug 10689] public note does not appear in subscriptions search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21598|0 |1 is obsolete| | Attachment #21599|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 21602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21602&action=edit [PASSED QA] Bug 10689 - public note does not appear in subscriptions search In a serials module, when searching subscriptions, the results table as a "Notes" column. In TT code, you see that it tries to display public note "subscription.notes" and internal note "subscription.internalnotes". Internal note is well displayed but not public note. You can see the 2 notes in serial details in summary tab. The problem commes from the SQL query. A join is perform on subscription and biblio, both containing a "notes" column. This patch solves the problem by using a alias in query for both columns (biblio.notes is acutally not used in template but could be). Test plan : - Edit a subscription - Add public and internal notes. For example : "too busy" and "on holiday" - Perform a subscription search that returns this subscription => "Notes" column contains both notes. For example : "too busy (on holiday)" - Test with only public note - Test with only internal note ==== Works as described. Signed-off-by:Mathieu Saby Signed-off-by: Bernardo Gonzalez Kriegel Adding a sign Signed-off-by: Katrin Fischer All tests and QA script pass. Works as described, fixes a bug as the templates show that the intention was to display both notes in the column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:32:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:32:18 +0000 Subject: [Koha-bugs] [Bug 10689] public note does not appear in subscriptions search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 --- Comment #10 from Katrin Fischer --- Created attachment 21603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21603&action=edit [PASSED QA] Bug 10689 - public note does not appear in new order form a subscription Test by creating a new order to a basket using "From a subscription" link Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works as described. No koha-qa errors When creating a new basket from a susbcription, public note shows on Notes column. Signed-off-by: Katrin Fischer Tiny enhancement, passes tests and QA script. Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:33:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:33:03 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 --- Comment #7 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #6) > Working on a follow-up for translated installers. If you like I can do this. Somehow I forget other languages :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:34:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:34:56 +0000 Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 --- Comment #8 from Katrin Fischer --- Already done - bug 10969 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:45:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:45:13 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #11 from Katrin Fischer --- Comment on attachment 21571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21571 Bug 6201 - Add fields 1xx to marc2bibtex Review of attachment 21571: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6201&attachment=21571) ----------------------------------------------------------------- ::: C4/Record.pm @@ +668,2 @@ > } > $author = join ' and ', @texauthors; This is an old line, but also a bug. We should never hardcode English strings in Perl modules. Never ever. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:47:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:47:27 +0000 Subject: [Koha-bugs] [Bug 10972] New: BibTex export code hardcodes 'and' between multiple authors Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10972 Bug ID: 10972 Summary: BibTex export code hardcodes 'and' between multiple authors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Record.pm contains this line: $author = join ' and ', @texauthors; When you export a record with multiple authors the 'and' will appear between them. I am not sure if this is standard, but it's a translation problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:47:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:47:48 +0000 Subject: [Koha-bugs] [Bug 10972] BibTex export code hardcodes 'and' between multiple authors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10972 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6201 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:47:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:47:48 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10972 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:48:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:48:51 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 19:48:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 17:48:55 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21571|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 21604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21604&action=edit [PASSED QA] Bug 6201 - Add fields 1xx to marc2bibtex Modified Record::marc2bibtex to varlidate fields 100,110 and 111 in non-Unimarc flavours. Test plan: 1)Search any books in the OPAC with a main entry (1XX in MARC21, 700-720 in Unimarc) 2)Export the record in the bibtex format ==>The output won't contains the main entry. 3)Apply the patch 4)Export the record ==>The record will contain the main entry Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Fixes a long standing bug. Passes all tests and QA script. Tested with multiple records, seems to work well. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 20:18:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 18:18:31 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21402|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 21605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21605&action=edit [SIGNED-OFF] Bug 10854: Export serial claims with a csv profile. Test plan: - Create a csv profile (or use the default one) with a type 'sql'. - Go to serials/claims.pl, select the wanted csv profile and click on the "Export selected items data". - Verify the csv file is correctly generated. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors On top of 10853 (solving merge conflict) Need to do homework to test. Add subscription and serial claim notice. 1) Create a new CSV profile, type SQL, copy sample fields 2) Go to claims, select vendor 3) Go to Export selected items with created profile 4) CSV (in my case I use | as separator) download successfully 5) All fields present, file correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 20:19:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 18:19:07 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 20:25:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 18:25:51 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #62 from Katrin Fischer --- Starting with a code review based on squashed patches: 1) Bug number missing from database update 2) In subscription-add.pl there is a typo, not sure the consequences: - $templte->param(letterloop => $letterloop); + $templte->param( letterloop => $letterloop ); 3) I'd really like to have more information about the use of the published_end_date and bound volumes - this seems to be a separate feature. The test plan says: >Part 4: >1) Apply the patch. Add/update a serial, and choose a published end date. >2) Verify the date was stored in the database correctly ( >serials.published_end_date ) >NOTE: The purpose of this feature is to better handle the dates of bound >volumes of serials. Right now, we specify the first published date, but not the >published date of the last issue in a bound volume. There is currently no real workflow for adding bound volumes - what are you referring to here? What steps lead to a bound volume for this library? -- I am a bit worried about the amount of testing this has seen - was an existing database converted with this patch? What were the results? Were other more unusual subscription patterns tested as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 21:00:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 19:00:54 +0000 Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated installers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21600|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 21606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21606&action=edit [SIGNED-OFF] Bug 10969: Fix sample itemtypes for translated installers To test: - Install the specific language and run the web installer. Or: - Truncate or delete all from the itemtypes table in your database. - Try to run the complete SQL in the itemtypes sample files. Verify the table is filled correctly. Signed-off-by: Bernardo Gonzalez Kriegel Works for all languages. No koha-qa errors. Tested removing itemtypes, then loading new file, and checking on staff. For de, es, nb, and pl no problems. For ru I disable foreign keys constraint before TRUNCATE and reenable it afterwards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 21:01:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 19:01:56 +0000 Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated installers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:16:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:16:13 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:16:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:16:16 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21605|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 21607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21607&action=edit Bug 10854: Follow-up - Some changes to the template Changing the link to a button and a pull down, matching the layout for the notification pull down and send notification button. To test: - Try to export claims as CSV and verify that the layout change didn't break the functionality. - Decide if you like the change or not :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:16:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:16:35 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21607|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 21608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21608&action=edit Bug 10854: Export serial claims with a csv profile. Test plan: - Create a csv profile (or use the default one) with a type 'sql'. - Go to serials/claims.pl, select the wanted csv profile and click on the "Export selected items data". - Verify the csv file is correctly generated. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors On top of 10853 (solving merge conflict) Need to do homework to test. Add subscription and serial claim notice. 1) Create a new CSV profile, type SQL, copy sample fields 2) Go to claims, select vendor 3) Go to Export selected items with created profile 4) CSV (in my case I use | as separator) download successfully 5) All fields present, file correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:21:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:21:58 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21608|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 21609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21609&action=edit [PASSED QA] Bug 10854: Export serial claims with a csv profile. Test plan: - Create a csv profile (or use the default one) with a type 'sql'. - Go to serials/claims.pl, select the wanted csv profile and click on the "Export selected items data". - Verify the csv file is correctly generated. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors On top of 10853 (solving merge conflict) Need to do homework to test. Add subscription and serial claim notice. 1) Create a new CSV profile, type SQL, copy sample fields 2) Go to claims, select vendor 3) Go to Export selected items with created profile 4) CSV (in my case I use | as separator) download successfully 5) All fields present, file correct Signed-off-by: Katrin Fischer Passes all tests and QA script. Works as advertised, keeps existing format by porting it to a SQL profile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:22:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:22:11 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 --- Comment #18 from Katrin Fischer --- Created attachment 21610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21610&action=edit Bug 10854: Follow-up - Some changes to the template Changing the link to a button and a pull down, matching the layout for the notification pull down and send notification button. To test: - Try to export claims as CSV and verify that the layout change didn't break the functionality. - Decide if you like the change or not :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:23:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:23:17 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 --- Comment #19 from Katrin Fischer --- Ok, now I finally got the patches up and in the right order... getting a little late her. Jonathan, could you take a look at the follow-up? Leaving it to Passed QA as the first patch is fine alone too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:29:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:29:46 +0000 Subject: [Koha-bugs] [Bug 10973] New: Make the use of basketgroup an option Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10973 Bug ID: 10973 Summary: Make the use of basketgroup an option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org Some libraries does not use basket groups. So for them, all information about basketgroups are irrelevant. I propose to add a syspref "UseBasketgroups". If the syspref is disable, all the information about basketgroups will be hidden in the templates and in perl files if necessary. Then, we could add a button for exporting baskets in pdf, as this is a feature which is only present at basketgroup level. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:42:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:42:42 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #84 from Katrin Fischer --- Still applies cleanly, all tests and QA script pass. Have to prepare a database to test the databaes update and setting of correct status next. If someone wants to help with additonal testing, noting the test plan and results - it would be very welcome :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:55:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:55:31 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20928|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer --- Created attachment 21611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21611&action=edit Bug 10096 - Add a Z39.50 interface for authority searching This patch introduces a new Z39.50 interface for searching z39.50 compliant databases for MARC authority records. These databases aren't as common as their bibliographic equivalents, but they're out there and very useful. I have included info at the bottom of this messsage for sample authority databases you can try. To test this patch: 1) Set up Z39.50 client targets for authority databases. (I've included information at the bottom of this message for LibrariesAustralia's test server for authorities as well as instructions on how to use your Koha's z39.50 authority server as well. The Library of Congress also has authority databases available (unsure if these are test or prod), and you might have access to others through OCLC or RLIN. OCLC provides login credentials for their test databases. 2) Go to the Authorities module 3) Click on the new "Z39.50 search button" 4) Select your authoriy search targets from the list (N.B. bibliographic targets will also display. These are of no use to you.) 5) Do a search for an authority you would like using either the "Raw" input box or the more specific input boxes for names, subjects, subject sub divisions, or titles. (I like searching Name (personal): Eric on the LibrariesAustralia test DB.) 6) You should see a table listing the server, heading, authority type, and two other columns (MARC and a nameless column). "Authority type" is the type of authority it will become when imported in to Koha. In the Eric example, "PERSO_NAME". 7) Click on "MARC" next to the results of interest to review the MARC authority record. 8) When you're satisfied with a record, click on "Import". 9) The pop-up window will close and your original Koha window will change to the "Adding authority Personal Name" screen (in the Eric example). 10) All the relevant fields should be filled out for the record. Review them and make any changes as necessary. (N.B. The 001 will be cleared when saved, so if you have a use for the imported control number, move it to the 010, 016, or 035 as appropriate. If you have a default value for the 003, this will also likely be overwritten. Move it if necessary. The 005 will also be updated when saved, so do not worry about that.) 11) When you're satisfied, click save. 12) Presto! You've imported your first authority record via Z39.50! -- Here is the info for the LibrariesAustralia test Z39.50 authority database: Z39.50 server: LibrariesAustralia Authorities Hostname: z3950-test.librariesaustralia.nla.gov.au Port: 210 Database: AuthTraining Userid: ANLEZ Password: z39.50 Syntax: MARC21/USMARC Encoding: utf8 - The U.S.A. Library of Congress also provides Z39.50 access to its Name and Subject Authorities (http://www.loc.gov/z3950/lcserver.html). Name Authority: Z39.50 server: Library of Congress Name Authority File Hostname: lx2.loc.gov Port: 210 Database: NAF Syntax: MARC21/USMARC Encoding: utf8 Subject Authority: Z39.50 server: Library of Congress Subject Authority File Hostname: lx2.loc.gov Port: 210 Database: SAF Syntax: MARC21/USMARC Encoding: utf8 (N.B. Both of these databases also include title authorities.) - For testing purposes, you can also set up a Z39.50 client target, which points at your own Koha instance's Z39.50 authority server. To find the hostname, go to /etc/koha-conf.xml and find the value for the element. Depending on your configuration, this could be something like the following: unix:/zebra/koha/var/run/zebradb/authoritysocket (N.B. You might be using a different scheme than unix sockets...) To find the database, scroll down to the bottom of koha-conf.xml until you reach the element. Within this, look for the value of the element . It should probably be "authorities". To set up this Z39.50 client target in Koha... Z39.50 server: my koha authorities Hostname: unix:/zebra/koha/var/run/zebradb/authoritysocket Port: Database: authorities Userid: Password: Syntax: MARC21/USMARC (or whichever flavour you need) Encoding: utf8 Signed-off-by: Mason James Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching This patch adds the "recordtype" column to the "z3950servers" table. The value in this column (biblio or authority) then controls whether the z3950 server shows up in a bibliographic search (through the Acq and Cataloguing modules) or in an authority search (through the Authorities module). I also edited the z3950 management console to show this value and allow users to edit it. The default value is "biblio", since the vast majority of z3950 targets will be bibliographic. However, there is an option to add/edit a z3950 target as a source of authority records. Test Plan: 1) Apply both patches 2) Run updatedatabase.pl (after setting your KOHA_CONF and PERL5 environmental variables) 3) Use the test plan from the 1st patch N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. Signed-off-by: Mason James Bug 10096 [FOLLOW-UP] - fix tabs/whitespace errors to pass QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:55:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:55:56 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20929|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer --- Created attachment 21612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21612&action=edit Bug 10096 - [FOLLOW-UP] QA Improvements 0) Run updatedatabase.pl (to add "recordtype" to the z3950servers table. 1) Set up Z39.50 client targets for authority databases. (I've included information at the bottom of this message for LibrariesAustralia's test server for authorities as well as instructions on how to use your Koha's z39.50 authority server as well. The Library of Congress also has authority databases available (unsure if these are test or prod), and you might have access to others through OCLC or RLIN. OCLC provides login credentials for their test databases. N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. 2) Go to the Authorities module 3) Click on the new "Z39.50 search button" 4) Select your authority search targets from the list 5) Do a search for an authority you would like using either the "Keyword" input box or the more specific input boxes for names, subjects, subject sub divisions, or titles. (I like searching Author (personal): Eric on the LibrariesAustralia test DB.) 6) You should see a table listing the server, heading, authority type, and two other columns (MARC and a nameless column). "Authority type" is the type of authority it will become when imported in to Koha. In the Eric example, "PERSO_NAME". 7) Click on "MARC" next to the results of interest to review the MARC authority record. 8) When you're satisfied with a record, click on "Import". 9) The pop-up window will close and your original Koha window will change to the "Adding authority Personal Name" screen (in the Eric example). 10) All the relevant fields should be filled out for the record. Review them and make any changes as necessary. (N.B. The 001 will be cleared when saved, so if you have a use for the imported control number, move it to the 010, 016, or 035 as appropriate. If you have a default value for the 003, this will also likely be overwritten. Move it if necessary. The 005 will also be updated when saved, so do not worry about that.) 11) When you're satisfied, click save. 12) Presto! You've imported your first authority record via Z39.50! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 22:56:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 20:56:31 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #31 from Katrin Fischer --- Rebased and fixed some tabs the QA script was complaining about. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 23:00:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 21:00:17 +0000 Subject: [Koha-bugs] [Bug 10973] Make the use of basketgroup an option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10973 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mathieu.saby at univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 23:00:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 21:00:25 +0000 Subject: [Koha-bugs] [Bug 10973] Make the use of basketgroup an option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10973 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 23:05:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 21:05:46 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #21 from Katrin Fischer --- Hi Kyle, the QA script found something: FAIL circ/returns.pl OK pod OK forbidden patterns FAIL valid "my" variable $itemnumber masks earlier declaration in same scope OK critic Could you check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 23:08:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 21:08:29 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 --- Comment #51 from Katrin Fischer --- Still applies cleanly and passes all the tests. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 23:10:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 21:10:31 +0000 Subject: [Koha-bugs] [Bug 10892] Make facets customisable - step 1 : store facet config in YAML block In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10892 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #7 from mathieu saby --- No need to consider this bug. I will use JSON for storing configuration of facets. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 23:14:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 21:14:41 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #25 from Bernardo Gonzalez Kriegel --- Testing this. It's a good feature. Our university students need to get a 'discharge' certificate (we call it "libre deuda"). The best we can do with Koha is print a circulation slip that shows no items on loan. Test 1) Patches applied, a few touchs on updatedatabase.pl (using CheckVersion($DBversion) instead of C4::Context->preference("Version") < TransformToNum($DBversion), add Bug number to update message) 2) Enabled sysprefs, created dir, etc. 3) OPAC, patron view Discarged tab (I think it could be "my discharge" or "discharges" with lower case for consistency) 4) OPAC, patron with an issue can't generate discharge, but the message do not state that fact, only tells that can?t be generated 5) OPAC, patron without issue can request discharge, mail to library sent 6) STAFF, Discharge tab is Upercase, in sync with others 7) STAFF, trying to generate discharge for patron with issue states that fact. 8) STAFF, patron without issue... This is when I run into problems. Staff interface only tells "An error has ..." Files are created!! ( kohaclone$ ls -l ../kohadev/discharges/52 total 8 -rw-r--r-- 1 www-data www-data 668 sep 29 16:50 discharge-2013-09-29.html -rw-r--r-- 1 www-data www-data 2801 sep 29 16:50 discharge-2013-09-29.pdf ) Log shows this: discharge.pl: readline() on unopened filehandle at /home/bgkriegel/kohaclone/C4/Discharges.pm line 68., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/members/discharge.pl?borrowernumber=52 Looking into the code (line 68) I fund that you read files in user dir like my $pdf_path = qq{$dischargePath/$borrowernumber/*.pdf}; my @files = <$pdf_path>; I can replicate the error message using perl -e 'use Modern::Perl; my $p = qq{52/*.pdf}; my @f = <$p>;' readline() on unopened filehandle at -e line 1. [with or without files] So, all stops trying to read files. I think this is a bug, or perhaps I'm doing something wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 29 23:51:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 21:51:46 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #13 from Eric B?gin --- > > $author = join ' and ', @texauthors; > > This is an old line, but also a bug. We should never hardcode English > strings in Perl modules. Never ever. >From what I know, the 'and' is part of the bibtex standard and is language agnostic. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 00:13:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 22:13:27 +0000 Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #14 from Katrin Fischer --- Hm, weird format:) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 00:15:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 22:15:12 +0000 Subject: [Koha-bugs] [Bug 10972] BibTex export code hardcodes 'and' between multiple authors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10972 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 01:00:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 23:00:35 +0000 Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 01:04:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 23:04:21 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 01:04:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 23:04:35 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 01:44:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Sep 2013 23:44:19 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20791|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 21613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21613&action=edit Bug 10824 - OAI-PMH repository/server not handling time in "from" argument This patch remotes the DATE() function from around timestamp, and adds a sub that strips the UTC designators "T" and "Z" from incoming "from" and "until" arguments in OAI-PMH requests so that they're more compliant with MySQL (and probably other databases as well). TEST PLAN: 0) Note down a selection of timestamps from your biblio table 1) Enable your OAI-PMH server through the global system preferences Web services tab. 2) Craft and submit a similar request to the following in your browser: KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc& from=2013-09-02T13:44:33Z&until=2013-09-05T13:44:33Z Change the exact dates to accord with your timestamps, but keep the YYYY-MM-DDTHH:MM:SSZ format. 3) Note the unexpected behaviour. A "from" argument with the timestamp 2013-09-02T13:44:33Z will show records from 2013-09-03 but not records from 2013-09-02 even though the timestamp in the database will say "2013-09-02 13:44:33". 4) APPLY THE PATCH 5) Resubmit the links you tried above 6) Note that the applicable records now appear! -- Developer Note: We could've not stripped the UTC designators and used DATE() around the parameters in the SQL queries, but that would have lost the whole purpose of using times in the "from" arguments, since they would've been generalized to just the dates. I think this is probably the best solution. Admittedly, creating "form_arg" and "until_arg" hashrefs in the ResumptionToken object might not be ideal, but I preferred that to copying the _strip_UTC_designator subroutine into two other objects. Perhaps this sub could go somewhere else and be imported into those other two objects but this seemed to be the most sensible decision. I'm open to other opinions though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 02:14:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 00:14:07 +0000 Subject: [Koha-bugs] [Bug 10454] Duplicate card numbers may be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #23 from M. Tompsett --- I'm not sure there is a way to $dbh->last_insert_id() query a value, increment it, and update it in a way that is consistent in a multi-user scenario. $dbh doesn't let us "SQL;SQL;SQL" as far as I can tell. Unless we want to evil things like serialize a thread or process, which is just too evil and full of potential problems, I can't see a non-mysqlism way to handle the LAST_INSERT_ID code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 02:26:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 00:26:56 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 02:27:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 00:27:00 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20623|0 |1 is obsolete| | --- Comment #61 from Srdjan Jankovic --- Created attachment 21614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21614&action=edit bug_9611: use checkpw_hash() instead of md5 hash Test: * SIP: Have an old user and create a new user - use either tenet sip test or C4/SIP/interactive_patron_check_password.pl to check old userid/password - do the same for the new user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 02:45:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 00:45:49 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #62 from Srdjan Jankovic --- > If I feed > perl -e 'use C4::Auth_with_ldap; > C4::Auth_with_ldap::_do_changepassword("test", 12345, "test");' > with current password, it returns nothing, and pass is not updated > > If I put a new password, last argument I suppose, then it returns > Password mismatch after update to borrowernumber=12345 at > /home/bgkriegel/kohaclone/C4/Auth_with_ldap.pm line 274, line 522. > and pass is not updated > 12345 should be the borrowernumber for the user 'test'. Is that the case? > I enabled ldap changing to 1 1 > and just copy/paste ladp server conf from perldoc. And did this > because the oneliner do not run if there is no configuration. No, this scripts goes directly to Auth_with_ldap.pm, the purpose was to avoid checking the config and doing the LDAP bit so we can test password change only without having to connect to an LDAP server. > > So, perhaps I'm just doing something wrong, I don't know. No, you are doing the right thing, just please check the borrowernumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 02:56:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 00:56:05 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20254|0 |1 is obsolete| | --- Comment #63 from Srdjan Jankovic --- Created attachment 21615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21615&action=edit Bug 9611: Database update, changing password from varchar(30) to varchar(60) This is necessary because Bcrypt hashes are longer than MD5 hashes. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mason James Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 03:32:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 01:32:04 +0000 Subject: [Koha-bugs] [Bug 10864] Diacritics in patron categories in advanced patron search broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10864 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ketan at carvingit.com --- Comment #1 from Ketan Kulkarni --- I think this is related to bug number 6554. I have added a patch there. Could you please see if that fixes the problem. (In reply to Katrin Fischer from comment #0) > If you search patrons by patron category using the + and patron category > search option patron categories with diacritics don't show up correctly. > Example: Gasth?rer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 03:54:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 01:54:47 +0000 Subject: [Koha-bugs] [Bug 3206] OAI repositry deleted record support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 --- Comment #4 from David Cook --- Something to check into would be how biblios are deleted when a batch import is reverted...we'll need to make sure that the bibs are logged in the deletedbiblio table and not just nuked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:14:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:14:26 +0000 Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |ketan at carvingit.com Assignee|koha-bugs at lists.koha-commun |ketan at carvingit.com |ity.org | --- Comment #1 from Ketan Kulkarni --- Created attachment 21616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21616&action=edit minor template edit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:17:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:17:17 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 --- Comment #21 from Robin Sheat --- Created attachment 21617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21617&action=edit Bug 10733: add 'memcached' as suggested dependency Adds 'memcached' to the control.in file so the user is suggested by apt to install it. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mark Tompsett Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:17:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:17:21 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 --- Comment #22 from Robin Sheat --- Created attachment 21618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21618&action=edit Bug 10733: Memcached on package installs This patch makes the koha-create script adjust the koha-conf.xml file with the proper string substitutions to enable the use of memcached for the created Koha instance. It adds three option switches that control this: --use-memcached (defaults to "no") --memcached-servers "host1:port1,..." (defaults to '127.0.0.1:11211') --memcached-prefix "desired_namespace prefix" (defaults to 'koha_') It respects the current schema configuration schema, where configuration values are pondered like this: hardcoded < koha-sites.conf < koha-create option switches koha-sites.conf is read for USE_MEMCACHED, MEMCACHED_SERVERS and MEMCACHED_PREFIX. Note: the docs discourage setting user's own namespace prefix. Using memcached is off as the default. The relevant configuration variables will remain empty if the user doesn't pass --use-memcached to the command. It matches the current behaviour. To test: - Apply the patch - Build your own packages and install them on a test server a) Create a new instance without using the new switches like: $ koha-create --create-db memctest - Check that /etc/koha/sites/memctest/koha-conf.xml contains: * Empty tag. * Empty tag. b) Play with the possible combination of option switches (Note that the code defaults to empty and will remain like that if --use-memcached is not used, so less tests...) $ koha-create --create-db --use-memcached memctest $ koha-create --create-db --use-memcached --memcached-servers "anything:xxx" memctest $ koha-create --create-db --use-memcached --memcached-servers "anything:xxx" --memcached-prefix "something" memctest $ koha-create --create-db --use-memcached --memcached-prefix "something" memctest - Check the koha-conf.xml and /etc/apache2/sites-enabled/memctest file reflect the chosen options. c) Run $ koha-create --help - It should advertise this addition accordingly. d) Run $ man koha-create - Man page for koha-create should provide good information on the new switches behaviour Enjoy To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mark Tompsett Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:17:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:17:25 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 --- Comment #23 from Robin Sheat --- Created attachment 21619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21619&action=edit Bug 10733: Follow up - unset variables from koha-sites.conf if USE_MEMCACHED=no As configuration variables from koha-sites.conf overwrite the ones in the koha-create script we need to unset them in case we have USE_MEMCACHED="no". Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mark Tompsett Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:18:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:18:32 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:18:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:18:36 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:18:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:18:57 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:20:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:20:24 +0000 Subject: [Koha-bugs] [Bug 10733] Memcached on package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Robin Sheat --- These look fine to me. One suggestion might be having a default prefix relating to the instance name, as this will reduce the chance of a collision a lot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:25:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:25:21 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #64 from Bernardo Gonzalez Kriegel --- (In reply to Srdjan Jankovic from comment #62) > No, this scripts goes directly to Auth_with_ldap.pm, the purpose was to > avoid checking the config and doing the LDAP bit so we can test password > change only without having to connect to an LDAP server. > > > > > So, perhaps I'm just doing something wrong, I don't know. > > No, you are doing the right thing, just please check the borrowernumber. Well, not so :) I need to add stanza, if not perl -e 'use C4::Auth_with_ldap; C4::Auth_with_ldap::_do_changepassword("test", 12345, "xxxx");' No "ldapserver" in server hash from KOHA_CONF: /home/bgkriegel/kohadev/etc/koha-conf.xml at /home/bgkriegel/kohaclone/C4/Auth_with_ldap.pm line 57, line 522. Compilation failed in require at -e line 1, line 522. BEGIN failed--compilation aborted at -e line 1, line 522. But my previous problem was not using correct borrowernumber, so it's ready I'll re-upload all, with a followup to fix a small POD error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:29:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:29:03 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #65 from Srdjan Jankovic --- the borrowernumber. > > Well, not so :) > I need to add stanza, if not > > perl -e 'use C4::Auth_with_ldap; > C4::Auth_with_ldap::_do_changepassword("test", 12345, "xxxx");' > No "ldapserver" in server hash from KOHA_CONF: > /home/bgkriegel/kohadev/etc/koha-conf.xml at > /home/bgkriegel/kohaclone/C4/Auth_with_ldap.pm line 57, line 522. > Compilation failed in require at -e line 1, line 522. > BEGIN failed--compilation aborted at -e line 1, line 522. > Oops, sorry about that, was some time ago, and my memory is perishable obviously. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:38:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:38:29 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:38:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:38:32 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21256|0 |1 is obsolete| | --- Comment #19 from Srdjan Jankovic --- Created attachment 21620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21620&action=edit Bug 10589 - Override OpacHiddenItems based on Patron Category Two system preferences, PatronSingleBranch and PatronEveryBranch, have been added to facilitate some granularity on the override. If the home branch of the item and the patron match and the catgegory code of the patron matches one of the pipe delimited values in the PatronSingleBranch patron category code, then an item which would normally be hidden will be visible. If the patron category matches one of the pipe delimited values in the PatronEveryBranch patron category, then every item hidden by OpacHiddenItems will be visible. Since the patron category codes used by default for these two system preferences are not added, OpacHiddenItems will continue function as expected until individual patrons and system preferences are configured. There is no need to provide this functionality to staff, as they have access to the staff client. Rebased to current master (again). Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:50:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:50:56 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20255|0 |1 is obsolete| | --- Comment #66 from Bernardo Gonzalez Kriegel --- Created attachment 21621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21621&action=edit [SIGNED-OFF] Bug 9611: add Crypt::Eksblowfish::Bcrypt to list of Perl dependencies Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mason James Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:51:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:51:15 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20578|0 |1 is obsolete| | --- Comment #67 from Bernardo Gonzalez Kriegel --- Created attachment 21622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21622&action=edit [SIGNED-OFF] Bug 9611: Change the password hashing algorithm from MD5 to Bcrypt What this patch aims to accomplish? * All new passwords are stored as Bcrypt-hashes * For password verification: - If the user was created before this patch was applied then use MD5 to hash the entered password <-- backwards compatibility - If the user was created after this patch was applied then use Bcrypt to hash the entered password * Any password change made via the staff interface or the OPAC will be automatically Bcrypt-hashed; this applies to old users whose passwords were stored as MD5 hashes previously Test plan: 1) Add new users and check whether their passwords are stored as Bcrypt hashes or not. 2) To test that authentication works for both old as well as new users: a) Login as an existing user whose password is stored as a MD5 hash b) Login as an existing user whose password is stored as a Bcrypt hash 3) In the staff interface, change the password of an existing user whose password is stored as an MD5 hash a) Check the new password is stored as a Bcrypt-hash in the database b) Try to login with the new password 4) In the OPAC, verify that a) Old user with old pass can change password, new format b) New user with new pass can change password c) Old and new user with self-updated pass can login Whitespace cleanup was contributed by Bernardo Gonzalez Kriegel. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mason James Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:51:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:51:31 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20621|0 |1 is obsolete| | --- Comment #68 from Bernardo Gonzalez Kriegel --- Created attachment 21623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21623&action=edit [SIGNED-OFF] bug_9611: Extracted checkpw_internal() and checkpw_hash() from checkpw() Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:51:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:51:51 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20622|0 |1 is obsolete| | --- Comment #69 from Bernardo Gonzalez Kriegel --- Created attachment 21624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21624&action=edit [SIGNED-OFF] bug_9611: removed md5_base64 from imports - not used Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:52:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:52:07 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20624|0 |1 is obsolete| | --- Comment #70 from Bernardo Gonzalez Kriegel --- Created attachment 21625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21625&action=edit [SIGNED-OFF] bug_9611: use hash_password() and checkpw_* instead of md5 hash Test: * LDAP: - Turn on LDAP auth in koha-config.xml. Sset "update" in your server config to 1 - Change user's password on LDAP - Login to Koha using LDAP - Koha password should be updated, to check - Turn off LDAP auth in koha-config.xml - You should be ble to log in with the new password I do not have a LDAP facility, so I cheated. I ran perl -e 'use C4::Auth_with_ldap; C4::Auth_with_ldap::_do_changepassword("srdjan", 1000022259, "srdjan");' and was able to change the password. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Test 1) change to 1 2) copy/paste sample config from perldoc C4/Auth_with_ldap 3) using sample script was able to change password, use (userid, borrowernumber, newpass) as arguments 4) checked with OPAC and in database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:52:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:52:24 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21614|0 |1 is obsolete| | --- Comment #71 from Bernardo Gonzalez Kriegel --- Created attachment 21626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21626&action=edit [SIGNED-OFF] bug_9611: use checkpw_hash() instead of md5 hash Test: * SIP: Have an old user and create a new user - use either tenet sip test or C4/SIP/interactive_patron_check_password.pl to check old userid/password - do the same for the new user Signed-off-by: Bernardo Gonzalez Kriegel Work as described Test 1) using perl C4/SIP/interactive_patron_check_password.pl can check current (short) and new (long) passwords -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:52:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:52:51 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21615|0 |1 is obsolete| | --- Comment #72 from Bernardo Gonzalez Kriegel --- Created attachment 21627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21627&action=edit [SIGNED-OFF] Bug 9611: Database update, changing password from varchar(30) to varchar(60) This is necessary because Bcrypt hashes are longer than MD5 hashes. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Mason James Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 04:56:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 02:56:32 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #73 from Bernardo Gonzalez Kriegel --- Created attachment 21628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21628&action=edit Bug 9611 - followup to fix POD Small patch to make koha-qa happy. Fixes small POD error Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 05:09:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 03:09:32 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #74 from Bernardo Gonzalez Kriegel --- Last comment: for QA sake, perhaps you can summarize in a comment all tests that need to be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 05:19:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 03:19:17 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21581|0 |1 is obsolete| | --- Comment #144 from Srdjan Jankovic --- Created attachment 21629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21629&action=edit bug 6554: double utf8 encoding fix * added ENCODING=>utf8 to Template->new * added utf8::decode for ms_query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 05:28:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 03:28:13 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #145 from Srdjan Jankovic --- I cannot sign off, it has tabs instead of spaces. I have replaced the multi-patch with this consolidated one. Please check if the commit message is ok. Also, I don't have time to look deeper, but utf8::upgrade($some_var) if utf8::is_utf8($some_var); looks wrong, that should not be needed. Or at least looks like the problem is being addressed in the wrong place. ENCODING => 'utf8' makes sense. Encode::decode() would also makes sense I presume. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 05:34:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 03:34:28 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #146 from Ketan Kulkarni --- Thank you Srdjan for consolidating the patch and also for removing the if() from utf8::upgrade($some_var) if utf8::is_utf8($some_var); The condition is not needed. Regards, Ketan (In reply to Srdjan Jankovic from comment #145) > I cannot sign off, it has tabs instead of spaces. > > I have replaced the multi-patch with this consolidated one. Please check if > the commit message is ok. > > Also, I don't have time to look deeper, but > utf8::upgrade($some_var) if utf8::is_utf8($some_var); > looks wrong, that should not be needed. Or at least looks like the problem > is being addressed in the wrong place. > > ENCODING => 'utf8' makes sense. > > Encode::decode() would also makes sense I presume. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 05:39:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 03:39:18 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #147 from Ketan Kulkarni --- Oops. Sorry .. That was an oversight. I think we can safely remove the if() from those lines. I'd like to hear from fellow developers. How do I remove tabs and put spaces? I use vi editor and I use tab for indentation. Regards, Ketan (In reply to Ketan Kulkarni from comment #146) > Thank you Srdjan for consolidating the patch and also for removing the if() > from > > utf8::upgrade($some_var) if utf8::is_utf8($some_var); > > The condition is not needed. > > Regards, > Ketan > > (In reply to Srdjan Jankovic from comment #145) > > I cannot sign off, it has tabs instead of spaces. > > > > I have replaced the multi-patch with this consolidated one. Please check if > > the commit message is ok. > > > > Also, I don't have time to look deeper, but > > utf8::upgrade($some_var) if utf8::is_utf8($some_var); > > looks wrong, that should not be needed. Or at least looks like the problem > > is being addressed in the wrong place. > > > > ENCODING => 'utf8' makes sense. > > > > Encode::decode() would also makes sense I presume. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 05:41:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 03:41:59 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21613|0 |1 is obsolete| | --- Comment #4 from David Cook --- Created attachment 21630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21630&action=edit Bug 10824 - OAI-PMH repository/server not handling time in 'until' and 'from' This patch removes the DATE() function from a query on timestamp, and adds a sub that strips the UTC designators "T" and "Z" from incoming "from" and "until" arguments in OAI-PMH requests so that they're more compliant with MySQL (and probably other databases as well). This means that the date and time for the 'from' and 'until' arguments will be matched correctly in the database. This patch also adds 'T00:00:00Z' to 'from' arguments and 'T23:59:59Z' to until arguments, when only dates are provided via the OAI parameters. The zero time isn't necessary, since MySQL treats '2013-09-30' as '2013-09-30 00:00:00' by default. However, the near midnight time is needed for 'until'. Otherwise, you'll never be able to retrieve a record with a date/time matching the 'until' argument. In summary, this patch adds handling for times as well as dates, which is necessary so that Koha is closer to meeting the actual OAI-PMH spec. TEST PLAN: 0) Note down a selection of timestamps from your biblio table 1) Enable your OAI-PMH server through the global system preferences Web services tab. 2) Craft and submit a similar request to the following in your browser: KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc& from=2013-09-02T13:44:33Z&until=2013-09-05T13:44:33Z Change the exact dates to accord with your timestamps, but keep the YYYY-MM-DDTHH:MM:SSZ format. 3) Note the unexpected behaviour. A "from" argument with the timestamp 2013-09-02T13:44:33Z will show records from 2013-09-03 but not records from 2013-09-02 even though the timestamp in the database will say "2013-09-02 13:44:33". Also note that records with a timestamp later than 13:44:33 will show up for the day 2013-09-05, even though they shouldn't. 4) APPLY THE PATCH 5) Resubmit the links you tried above 6) Note that the applicable records now appear (or do not appear) in accordance with the precise date/time ranges! -- Developer Note: We could've not stripped the UTC designators and used DATE() around the parameters in the SQL queries, but that would have lost the whole purpose of using times in the "from" arguments, since they would've been generalized to just the dates. I think this is probably the best solution. Admittedly, creating "form_arg" and "until_arg" hashrefs in the ResumptionToken object might not be ideal, but I preferred that to copying the _strip_UTC_designator subroutine into two other objects. Perhaps this sub could go somewhere else and be imported into those other two objects but this seemed to be the most sensible decision. I'm open to other opinions though. -- This latest patch adds full support for date/time for OAI requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 05:48:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 03:48:09 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #148 from Bernardo Gonzalez Kriegel --- > > How do I remove tabs and put spaces? I use vi editor and I use tab for > indentation. > Don't use tabs if you expect to pass QA http://stackoverflow.com/questions/426963/replace-tab-with-spaces-in-vim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 05:55:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 03:55:53 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 --- Comment #9 from Robin Sheat --- Should be fine, they get installed by the makefile, and building packages runs that, so they get picked up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 06:12:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 04:12:29 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 --- Comment #75 from Srdjan Jankovic --- That's why I prefer testing instructions in the comments rather than in the commits. Maybe the best way would be to have a separate attachment. Anyway, by popular demand: Test plan: 1) Add new users and check whether their passwords are stored as Bcrypt hashes or not (directly on the database). 2) To test that authentication works for both old as well as new users: a) Login as an existing user whose password is stored as a MD5 hash b) Login as an existing user whose password is stored as a Bcrypt hash 3) In the staff interface, change the password of an existing user whose password is stored as an MD5 hash a) Check the new password is stored as a Bcrypt-hash in the database b) Try to login with the new password 4) In the OPAC, verify that a) Old user with old pass can change password, new format b) New user with new pass can change password c) Old and new user with self-updated pass can login 5) SIP: Have an old user and create a new user a) use either tenet sip test or C4/SIP/interactive_patron_check_password.pl to check old userid/password b) do the same for the new user 6) LDAP: - Turn on LDAP auth in koha-config.xml. - Set "update" in your server config to 1 a) Change user's password on LDAP b) Login to Koha using LDAP - Koha password should be updated. To check turn off LDAP auth in koha-config.xml. You should be ble to log in with the new password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 06:46:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 04:46:06 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #149 from Ketan Kulkarni --- Created attachment 21631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21631&action=edit Replaced tabs with spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:22:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:22:59 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:23:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:23:04 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21629|0 |1 is obsolete| | Attachment #21631|0 |1 is obsolete| | --- Comment #150 from Srdjan Jankovic --- Created attachment 21632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21632&action=edit bug 6554: UTF8 double encoding fixes. Commits squashed into one. double utf8 encoding fix .. second try minor formatting updates enhancement to the previous patch related to utf8 double encoding added ENCODING=>utf8 to new-> added space which is there in master added utf8::decode for ms_query replaced tabs with spaces replaced tabs with spaces removed extra space Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:29:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:29:45 +0000 Subject: [Koha-bugs] [Bug 10974] New: OAI-PMH Resumption Tokens Do Not Handle Time Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974 Bug ID: 10974 Summary: OAI-PMH Resumption Tokens Do Not Handle Time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, it is possible to retrieve 50 or so records from Koha via OAI-PMH, when using times in your 'from' and 'until' arguments. Here is an example that will return a list of records (if your OAI server syspref is turned on). http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc&from=2012-09-05T13:44:33Z&until=2014-09-05T13:44:33Z However, if you need to retrieve the rest of the results via a resumption token, Koha won't return your results. http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&resumptionToken=oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z: This is because Koha joins and splits the resumption token using colons. Obviously, since the timestamps use colons, the string isn't going to be split correctly. I propose that we change the separator colons to slashes. This is the method that DSpace uses when serving records via OAI-PMH. You can see an example here: http://papyrus.bib.umontreal.ca/dspace-oai/request?verb=ListRecords&metadataPrefix=oai_dc -- Note: Koha doesn't handle times 100% correctly in master either. That's why I opened bug 10824. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:29:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:29:57 +0000 Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10824 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:29:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:29:57 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10974 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:30:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:30:07 +0000 Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:42:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:42:58 +0000 Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- Why // 0? An empty string would break it too, so I believe || 0 is better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:44:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:44:03 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 --- Comment #5 from David Cook --- In hindsight, I suppose this could technically be called an enhancement, since using a granularity of YYYY-MM-DD instead of YYYY-MM-DDThh:mm:ssZ is valid. Personally, I don't see why we don't use the finer granularity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:48:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:48:16 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #85 from Pierre Angot --- Ok. I'll test this afternoon ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:54:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:54:43 +0000 Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:54:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:54:46 +0000 Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974 --- Comment #1 from David Cook --- Created attachment 21633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21633&action=edit Bug 10974 - OAI-PMH Resumption Tokens Do Not Handle Time This patch changes the value separator in OAI-PMH resumption tokens from colons to slashes, so that the token string isn't split incorrectly when a time is included. TEST PLAN: 1) Turn on the OAI-PMH server syspref in Koha 2) Send a ListRecords request using 'from' and 'until' arguments that include times (Best to use very far apart times so that you retrieve more than 50 records which will likely be the trigger for a resumptionToken). Here is an example: http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords& metadataPrefix=oai_dc&from=2012-09-05T13:44:33Z&until=2014-09-05T13:44:33Z N.B. Replace KOHAINSTANCE with the URL of your Koha instance. 3) Scroll down to the bottom of the page until you find the resumptionToken. It will look similar to this: oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z: 4) Copy that resumption token and send a request with it like so: http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords& resumptionToken=oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z: 5) The page should (incorrectly) show no records. 6) APPLY PATCH 7) Repeat steps 2, 3, and 4 8) Note that the resumptionToken now uses slashes (e.g. /) instead of colons. Note also that now the second request will show records!!! N.B. This will only happen if Koha has enough records to serve to you. If your Koha has less than 50 records, try lowering the number provided in the "OAI-PMH:MaxCount" system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 07:57:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 05:57:41 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 --- Comment #6 from Srdjan Jankovic --- Not nitpicking or anything, just curious: why adding T...Z string just to strip it off? Wouldn't it be better to do something on the lines of $arg = length($date_string) == 10 ? ($date_string .= " $time_string") # 00:00:00 or 23:59:59 : _strip_UTC_designators($date_string); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:04:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:04:01 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #42 from Julian Maurice --- Created attachment 21634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21634&action=edit Bug 9044: Set the number of filters according to number of columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:05:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:05:35 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #43 from Julian Maurice --- Simple patch, easy to signoff :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:30:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:30:38 +0000 Subject: [Koha-bugs] [Bug 6286] Making classification indexes searchable in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6286 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10968 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:30:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:30:38 +0000 Subject: [Koha-bugs] [Bug 10968] Add a way to choose which indexes to display on simple and advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10968 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6286 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:31:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:31:11 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #9 from M. de Rooy --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:34:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:34:31 +0000 Subject: [Koha-bugs] [Bug 7490] Add CSS classes/ids to OPAC and staff NORMARC XSLT views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7490 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10218 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:34:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:34:31 +0000 Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for bibliographic information on OPAC results and detail pages (UNIMARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7490 --- Comment #20 from Magnus Enger --- There is already a bug called "Bug 7490 - Add CSS classes/ids to OPAC and staff NORMARC XSLT views" - I'll use that when I get around to dealing with this issue. Thanks for remembering poor old NORMARC! :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:38:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:38:19 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #140 from Julian Maurice --- Created attachment 21635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21635&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:39:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:39:22 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:40:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:40:15 +0000 Subject: [Koha-bugs] [Bug 10927] C4::Utils becomes useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 --- Comment #14 from Jonathan Druart --- (In reply to Katrin Fischer from comment #13) > Please leave at BLOCKED, it can go back to Signed off when the dependency is > resolved. Hi Katrin, I'm not sure to understand : if the dependency is signed off, I think this one could be have a signed off status too. On this way, 2 patches could be QA together, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:42:05 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from M. de Rooy --- QA Comment: This looks quite good to me. No complaints from qa tools. I just have one question: I think it would be even more friendly to the user if you could report the errors DelBiblio returns on refused deletions (because of items not connected to orders). At this time your code does not look at a possible return value of DelBiblio. Would it be possible for you to add this in a followup? (But I do not think this should block your patch..) And I got struck by another problem when testing your patch, but it does not depend on your changes but is connected to booksellers.pl. If I delete a basket, the return page is booksellers.pl. Every time I get the Firefox message: A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete. Script: http://[servername]/intranet-tmpl/lib/jquery/jquery.js:4 Just mentioning it here for completeness. Changing the bug status for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:46:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:46:08 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21164|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 21636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21636&action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:46:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:46:13 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21165|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 21637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21637&action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:46:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:46:18 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21166|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 21638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21638&action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:46:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:46:23 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21167|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 21639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21639&action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:46:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:46:43 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:48:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:48:00 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Jonathan Druart --- (In reply to I'm just a bot from comment #5) > This bug depends on bug9016 which is in status Needs Signoff but the patches > for it do not apply cleanly bug 9016 rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:49:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:49:39 +0000 Subject: [Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Bot Control|--- |Ignore this bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:52:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:52:34 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:52:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:52:36 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20980|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 21640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21640&action=edit Bug 10875: Add order from a staged file should not display inactive funds When adding an order from a staged file, a link "show all funds" is now added on the top of the page. All inactive funds are hidden by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:54:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:54:13 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 09:54:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 07:54:16 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21182|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 21641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21641&action=edit Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:09:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:09:41 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:09:44 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21195|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 21642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21642&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:13:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:13:17 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:13:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:13:21 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20316|0 |1 is obsolete| | Attachment #20717|0 |1 is obsolete| | Attachment #20718|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 21643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21643&action=edit Bug 9043: Syspref improvement: add new type "multiple" This patch adds a new type "multiple" for syspref. This new type allows to select several values for one syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:13:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:13:29 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #32 from Jonathan Druart --- Created attachment 21644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21644&action=edit Bug 9043: Changes to the advanced search page New syspref: OpacAdvSearch. This syspref is multivalued and you can add or remove some elements on the adv search page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:13:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:13:35 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #33 from Jonathan Druart --- Created attachment 21645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21645&action=edit Bug 9043: Add the dropdown check list jquery plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:16:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:16:55 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:16:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:16:59 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21476|0 |1 is obsolete| | Attachment #21483|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 21646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21646&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:17:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:17:08 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #7 from Jonathan Druart --- Created attachment 21647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21647&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:33:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:33:37 +0000 Subject: [Koha-bugs] [Bug 10927] C4::Utils becomes useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #15 from Katrin Fischer --- Hm, I thought it was Failed QA when I checked - so there was not much one could do here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:43:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:43:28 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 --- Comment #20 from Jonathan Druart --- (In reply to Katrin Fischer from comment #18) > Created attachment 21610 [details] [review] > Bug 10854: Follow-up - Some changes to the template > > Changing the link to a button and a pull down, matching the > layout for the notification pull down and send notification button. > > To test: > - Try to export claims as CSV and verify that the layout > change didn't break the functionality. > - Decide if you like the change or not :) Katrin, This patch introduces an issue. To reproduce: - go on serials/claims.pl - select a vendor with serials (claimdate should be != today) - check 1 or + serials and export them as CSV - refresh the page - select a vendor - the issues have been claimed! It is why I left the link. Having 2 submit buttons (with different actions) on the same form is not a good idea. I let you obsolete the patch. Thanks to tried :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:47:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:47:17 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 --- Comment #21 from Katrin Fischer --- Hmpf :) It's ok, but maybe we should fix the wording a bit then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:47:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:47:29 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21610|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:52:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:52:12 +0000 Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list turned out untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21450|0 |1 is obsolete| | Status|Needs Signoff |Signed Off CC| |nunyo at masmedios.com Assignee|koha-bugs at lists.koha-commun |nunyo at masmedios.com |ity.org | --- Comment #3 from Nu?o L?pez Ans?tegui --- Created attachment 21648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21648&action=edit Bug 10948: make reference labels translatable in OPAC auth results This patch works fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:56:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:56:12 +0000 Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list turned out untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21648|0 |1 is obsolete| | --- Comment #4 from Nu?o L?pez Ans?tegui --- Created attachment 21649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21649&action=edit Bug 10948: make reference labels translatable in OPAC auth results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 10:59:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 08:59:13 +0000 Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list turned out untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21649|0 |1 is obsolete| | --- Comment #5 from Nu?o L?pez Ans?tegui --- Created attachment 21650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21650&action=edit Bug 10948: make reference labels translatable in OPAC auth results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 11:09:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 09:09:39 +0000 Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 --- Comment #4 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #3) > Why // 0? An empty string would break it too, so I believe || 0 is better. Yes, you are right! I will fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 11:09:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 09:09:52 +0000 Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20909|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 21651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21651&action=edit Bug 10843: the DateTime->add method takes a scalar, not undef Test plan: 1) set an empty string for the ReservesMaxPickUpDelay pref 2) place a hold on an item 3) check in the item 4) click on "Print and confirm" 5) an error occurs > The 'days' parameter (undef) to DateTime::Duration::new was an 'undef' 6) apply the patch 7) repeat steps 1 to 4 8) the error does not occur anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 11:21:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 09:21:04 +0000 Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ulrich.kleiber at bsz-bw.de --- Comment #6 from Ulrich Kleiber --- Created attachment 21652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21652&action=edit Bug 10908 - fix broken LDAP tested with OpenLDAP in front of AD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 11:22:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 09:22:14 +0000 Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 --- Comment #7 from Ulrich Kleiber --- Created attachment 21653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21653&action=edit Bug 10908 - restore docs on principal_name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 11:22:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 09:22:47 +0000 Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21155|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 11:23:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 09:23:22 +0000 Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21154|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 11:23:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 09:23:42 +0000 Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 11:28:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 09:28:36 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 --- Comment #22 from Jonathan Druart --- Created attachment 21654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21654&action=edit Bug 10854: Followup: Small changes to the template Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 11:41:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 09:41:12 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #82 from Jonathan Druart --- (In reply to Katrin Fischer from comment #81) > This has taken a while... thx Jonathan for your patience! Thanks for your patience too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 11:56:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 09:56:58 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 --- Comment #11 from mathieu saby --- (In reply to M. de Rooy from comment #10) > QA Comment: > This looks quite good to me. No complaints from qa tools. > I just have one question: I think it would be even more friendly to the user > if you could report the errors DelBiblio returns on refused deletions > (because of items not connected to orders). > At this time your code does not look at a possible return value of DelBiblio. > Would it be possible for you to add this in a followup? (But I do not think > this should block your patch..) Hi I will look if it is possible and add a followup. > > And I got struck by another problem when testing your patch, but it does not > depend on your changes but is connected to booksellers.pl. > If I delete a basket, the return page is booksellers.pl. Every time I get > the Firefox message: A script on this page may be busy, or it may have > stopped responding. You can stop the script now, or you can continue to see > if the script will complete. > Script: http://[servername]/intranet-tmpl/lib/jquery/jquery.js:4 > Just mentioning it here for completeness. To be clear : does it occur in master without my patch? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 12:16:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 10:16:00 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 --- Comment #12 from M. de Rooy --- (In reply to mathieu saby from comment #11) > To be clear : does it occur in master without my patch? Hi Matthieu, Yes it does. So nothing to do with your patch.. Note that if I am in a basket from some supplier and I delete it, I actually would like to return to the basket list of that supplier instead of getting a list of all suppliers. But that is outside the scope of this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 13:48:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 11:48:08 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 13:48:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 11:48:11 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 --- Comment #9 from Jonathan Druart --- Created attachment 21655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21655&action=edit Bug 10611: Followup: remove useless calls to dbh->disconnect These 3 calls to disconnect are done at the end of the script, they are useless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 13:48:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 11:48:32 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21655|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 21656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21656&action=edit Bug 10611: add a "new" parameter to C4::Context->dbh When dbh->disconnect is called and the mysql_auto_reconnect flag is set, the dbh is not recreated: the old one is used. Adding a new flag, we can now force the C4::Context->dbh method to return a new dbh. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 13:48:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 11:48:36 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 --- Comment #11 from Jonathan Druart --- Created attachment 21657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21657&action=edit Bug 10611: Followup: remove useless calls to dbh->disconnect These 3 calls to disconnect are done at the end of the script, they are useless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 14:15:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 12:15:57 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 14:16:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 12:16:00 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #33 from Jonathan Druart --- Created attachment 21658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21658&action=edit Bug 10419: Patrons with fines should not be deleted Test plan: - add a fine for a patron - verify the script does not delete this patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 14:26:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 12:26:27 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21566|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 21659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21659&action=edit Bug 10602: Set a default value for authorities Some code already exist but the feature does not work. This patch allows to define default values in the authorities framework. Test plan: 1/ Choose a framework, field and subfields. 2/ Define a default value. 3/ Create a new authority and check that the subfield is automatically filled with the default value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 14:26:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 12:26:24 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 14:27:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 12:27:37 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 --- Comment #11 from Jonathan Druart --- Yes, my bad. Little error on inserting in DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 14:47:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 12:47:33 +0000 Subject: [Koha-bugs] [Bug 10975] New: addbiblio.pl checks if marcflavour equals "usmarc" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10975 Bug ID: 10975 Summary: addbiblio.pl checks if marcflavour equals "usmarc" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl On line 924 of cataloguing/addbiblio.pl we have this line: $template->param( title => $record->title() ) if ($record ne "-1" && C4::Context->preference('marcflavour') eq "usmarc"); As far as I know, the 'marcflavour' syspref will never, ever be equal to "usmarc". I'm not sure if this has any practical sideeffects, though, I just spotted it while looking for something else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 15:13:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 13:13:25 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #26 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #25) > Testing this. Thanks Bernardo for testing! > I think this is a bug, or perhaps I'm doing something wrong. Yes, it is a bug. I will provide a followup which will fix 3 issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 15:13:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 13:13:56 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #27 from Jonathan Druart --- Created attachment 21660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21660&action=edit Bug 8007: Followup: fix read dir error This patch fixes: - an error on reading the discharges directory - the parameter sent to CancelReserves (API has been changed) - the parameters sent to output_pref (API has been changed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 15:16:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 13:16:19 +0000 Subject: [Koha-bugs] [Bug 10976] New: the assistant for reports uses the wrong value for the list of item types Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Bug ID: 10976 Summary: the assistant for reports uses the wrong value for the list of item types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: gaetan.boisson at biblibre.com QA Contact: testopia at bugs.koha-community.org When using the assistant to create a new report (guided_reports.pl), if you choose to limit according to the itemtype, the generated code is <>, but the proper value for the report to work should be <> (with an extra 's'). (This was also wrong in the wiki. Fixed now.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 15:40:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 13:40:03 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #30 from Jonathan Druart --- (In reply to Galen Charlton from comment #28) > (In reply to Jonathan Druart from comment #23) > > This patch will be in conflict with bug 8367. > > Can you expand on what sort of conflict? Just a merge conflict that would > be resolvable with more or less effort, or conflicting notions of the > desired functionality or implementation thereof? When I wrote this note, bug 8367 was signed off. Now, it does not apply :) In bug 8367 I change the list of returned values for the GetReservesFromItemnumber routine (I return directly the reserve hashref). Patches from this report add a returned value too (waitingdate). So I thought it would be good to base them onto bug 8267's patches. The first argument was: patches are really (reaally) boring to rebase. It was certainly not relevant, so please don't take into account this note. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 15:58:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 13:58:26 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #21 from Jonathan Druart --- (In reply to Katrin Fischer from comment #20) > Hi Jonathan, > > I have one bigger and some smaller issues with "Lift restriction for > restricted accounts" > > I think either the description is wrong, or it does not work like it should. > We have 3 possible restrictions on patron accounts: > > - Restricted > - Lost > - Gone no address > > It would be nice if it was clearer that it only affected "Restricted", but > that is ok. (1) > > What I have a problem with is, that you can also not restrict someone if you > are missing the permission - which means it's not only for 'lifting' but > also for 'setting' the restriction. Is this by design? (2) Katrin, In fact I completely forgot a staff can change the flags on editing a patron. The goal of this patch was to hide/show the "Lift restriction" button on top of the circulation page. But it is not enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 16:06:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 14:06:55 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #22 from Jonathan Druart --- (In reply to Jonathan Druart from comment #21) > Katrin, > In fact I completely forgot a staff can change the flags on editing a patron. > The goal of this patch was to hide/show the "Lift restriction" button on top > of the circulation page. > But it is not enough. Looking at the patch, I did not forget :) What do you think about changing the lift_restriction permission to manage_restrictions (including Restricted, Lost and Gone no address)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 16:12:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 14:12:33 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #23 from Katrin Fischer --- I am not sure about including the gone no adress and lost flag - but I like manage_restrictions. Maybe we can have a quick poll on IRC? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 16:18:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 14:18:39 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 16:18:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 14:18:43 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #24 from Jonathan Druart --- Created attachment 21661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21661&action=edit Bug 10863: Rename lift_restriction with manage_restrictions The pref manage_restrictions now takes into account "Lost card" and "Gone no address" restrictions. Test plan: - log in with a user with manage_restrictions permission - verify you can set/unset restrictions when editing a patron - log in with a user without manage_restrictions permission - verify you cannot set/unset restrictions when editing a patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 16:20:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 14:20:20 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #25 from Jonathan Druart --- (In reply to Katrin Fischer from comment #23) > I am not sure about including the gone no adress and lost flag - but I like > manage_restrictions. Maybe we can have a quick poll on IRC? Oops, I did not wait for your answer. I think it makes sense to include 3 restrictions, but maybe I'm wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 16:37:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 14:37:30 +0000 Subject: [Koha-bugs] [Bug 10977] New: Connexion Gateway: biblios not importing as a batch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10977 Bug ID: 10977 Summary: Connexion Gateway: biblios not importing as a batch Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: drnoe at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 21662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21662&action=edit screenshot In Staged MARC Management, when importing multiple records and set to import_mode: stage, each biblio is staged individually not as a batch. ----------------- Steps to replicate: 1) Configure Connexion Client. 2) Set connexion.conf to import_mode: stage 3) Import a batch of records. Each biblio is a separate file in Manage staged MARC records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 16:41:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 14:41:50 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #19 from Jonathan Druart --- Created attachment 21663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21663&action=edit Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 16:58:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 14:58:52 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #28 from Bernardo Gonzalez Kriegel --- Worked! :) Last question: On a dev install, koha-tmpl is accesible from oapc and staff, but on a packages/tar install DocumentRoot for opac and staff do not overlap. opac -> DocumentRoot /usr/share/koha/opac/htdocs staff -> DocumentRoot /usr/share/koha/intranet/htdocs I solved this doing a symlink of discharges dir to both htdocs but this must be stated on instructions Do you plan some followup to remove these files? I think that if the patron is lifted from a discharge the files must be removed, or make them inaccesible (from opac) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 17:28:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 15:28:42 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21659|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 21664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21664&action=edit [SIGNED-OFF] Bug 10602: Set a default value for authorities Some code already exist but the feature does not work. This patch allows to define default values in the authorities framework. Test plan: 1/ Choose a framework, field and subfields. 2/ Define a default value. 3/ Create a new authority and check that the subfield is automatically filled with the default value. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. koha-qa reports some tabs, fixed in followup Test 1) Apply patch, run updatedatabase.pl 2) Edit auth framework, put default value someware, save 3) Add new auth, default value present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 17:29:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 15:29:25 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 21665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21665&action=edit Bug 10602 - followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 17:29:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 15:29:58 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 18:43:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 16:43:12 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21508|0 |1 is obsolete| | --- Comment #26 from Owen Leonard --- Created attachment 21666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21666&action=edit [SIGNED-OFF] Bug 10856: Fix cover display in shelf browser Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 18:43:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 16:43:09 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:28:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:28:36 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21264|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 21667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21667&action=edit [SIGNED-OFF] Bug 10611: Use mysql_auto_reconnect instead of ping DBD::Mysql provides a mysql_auto_reconnect flag. Using it avoid to do a ping. Benchmarks: use Modern::Perl; use C4::Context; for ( 1 .. 1000 ) { $dbh = C4::Context->dbh; } * without this patch on a local DB: perl t.pl 0,49s user 0,02s system 98% cpu 0,525 total * without this patch on a remote DB: perl t.pl 0,52s user 0,05s system 1% cpu 37,358 total * with this patch on a local DB: perl t.pl 0,46s user 0,04s system 99% cpu 0,509 total * with this patch on a remote DB: perl t.pl 0,49s user 0,02s system 56% cpu 0,892 total Testing the auto reconnect: use Modern::Perl; use C4::Context; my $ping = $dbh->ping; say $ping; $dbh->disconnect; $ping = $dbh->ping; say $ping; Signed-off-by: Bernardo Gonzalez Kriegel Comment: Real improvement. No koha-qa errors prove t/db_dependent/Circulation_issuingrules.t produces no error prove t/db_dependent/Context.t produces no error Test 1) dumped Koha DB, load it on a non-local server 2) run sample script whit and without patch, local and remote use Modern::Perl; use C4::Context; for ( 1 .. 100000 ) { my $dbh = C4::Context->dbh; } Main difference I note is with remote server a) without patch real 0m16.357s user 0m2.592s sys 0m2.132s b) with patch real 0m0.259s user 0m0.240s sys 0m0.012s I think this could be good for DBs placed on remote servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:28:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:28:47 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21656|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 21668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21668&action=edit [SIGNED-OFF] Bug 10611: add a "new" parameter to C4::Context->dbh When dbh->disconnect is called and the mysql_auto_reconnect flag is set, the dbh is not recreated: the old one is used. Adding a new flag, we can now force the C4::Context->dbh method to return a new dbh. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:28:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:28:56 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21657|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 21669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21669&action=edit [SIGNED-OFF] Bug 10611: Followup: remove useless calls to dbh->disconnect These 3 calls to disconnect are done at the end of the script, they are useless. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:29:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:29:32 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:41:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:41:40 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:41:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:41:45 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21319|0 |1 is obsolete| | Attachment #21320|0 |1 is obsolete| | Attachment #21321|0 |1 is obsolete| | Attachment #21666|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer --- Created attachment 21670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21670&action=edit [PASSED QA] Bug 10856: Improve the previous and next items on the shelf browser The next and previous links should completely refresh the shelf. For example: [<] [1] [2] [3] [4] [5] [6] [>] Before this patch, the next and previous links were the same as the 1 and 6. With this patch, after clicking on next, we will get: [<] [7] [8] [9] [10] [11] [12] [13] [>] This patch adds a new ajax script to get the shelf browser block. Test plan: - On a detail biblio page, click on a "Browse shelf" link. - Play with the next and previous links. - Deactivate Javascript (using NoScript for example) and check that you get the same behavior (but the page is reloaded). - Launch the unit tests: prove t/db_dependent/ShelfBrowser.t Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:41:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:41:58 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 --- Comment #28 from Katrin Fischer --- Created attachment 21671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21671&action=edit [PASSED QA] Bug 10856: If callnumbers are equals, order should be on itemnumbers If a lot of items has the same callnumber, the order should be on the itemnumbers. Otherwise the left side is always filled with the same items. + Fix a bad c/p for the next link (when js is disabled). Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:42:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:42:08 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 --- Comment #29 from Katrin Fischer --- Created attachment 21672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21672&action=edit [PASSED QA] Bug 10856 [Follow-up] Improve the previous and next items on the shelf browser In Firefox at least, the shelf browser cannot be reopened after hiding it with the "close shelf browser" link. This followup improves the behavior of the "close shelf browser" link so that the shelf browser can be redisplayed. To test, open a bibliographic detail page in the OPAC and click a "browse shelf" link. Click the "close shelf browser" link--the shelf browser should be hidden. Click the original "browse shelf" link and the shelf browser should reappear without reloading the page. Test with Firefox and Chrome (at least). Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer All tests and QA script pass. Testing notes: - New unit tests in t/db_dependent/ShelfBrowser.t pass. - System preference OPACShelfBrowser still works as expected. - Closing and opening the shelf browser works as expected. - Next and Previous links show new and nicer behaviour. - Logs are clean. Tested with Firefox and Chromium under Ubuntu. Notes: The currently displayed record could maybe be highlighted a bit better. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:42:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:42:38 +0000 Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 --- Comment #30 from Katrin Fischer --- Created attachment 21673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21673&action=edit [PASSED QA] Bug 10856: Fix cover display in shelf browser Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer I was able to reproduce the problem with local covers and the patch fixes it in my tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:43:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:43:31 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21394|0 |1 is obsolete| | --- Comment #29 from Bernardo Gonzalez Kriegel --- Created attachment 21674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21674&action=edit [SIGNED-OFF] Bug 8007: Discharge management At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and download discharges already generated. Requirements: aptitude install python-pisa New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge - dischargePath: Sets the upload path for the generated discharges - dischargeWebPath: Sets the upload path starting from documentroot for the generated discharges New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Fill the syspref dischargePath (e.g. /home/koha/src/koha-tmpl/discharges) - Fill the syspref dischargeWebPath (e.g. /discharges) - For a security reason create a .htaccess in your dischargePath with the following content: Options -Indexes and change the rights: sudo chown www-data:www-data /home/koha/src/koha-tmpl/discharges - Check that a new tab appears in the patron page (intranet and opac) - Check that the discharge cannot be generated if the patron has issues. - Check that the patron can request a discharge from it's opac area. - The request is a mail sent via the sendmail command - Generate the discharge from the intranet - Try to download it (from the opac and the intranet) Sponsored-by: SCD Limoges Signed-off-by: Bernardo Gonzalez Kriegel Works well. No koha-qa errors Solved merge conflict in updatedatabase.pl Test following test plan 1) enable sysprefs, put discharges dir somewhere in filesystem, with correct permissions, for webpath I did a symlink to koha-tmpl 2) created .htacces as example 3) new tab appears on user OPAC 4) patron can't request discharge with items on loan 5) patron can request dischrage without issues, email sent correct, 6) Discharge generated from intranet, also check that can't be generated if patron has issues 7) Download correct from OPAC and STAFF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:43:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:43:42 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21395|0 |1 is obsolete| | --- Comment #30 from Bernardo Gonzalez Kriegel --- Created attachment 21675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21675&action=edit [SIGNED-OFF] Bug 8007: Add a discharges example file Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:43:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:43:56 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21396|0 |1 is obsolete| | --- Comment #31 from Bernardo Gonzalez Kriegel --- Created attachment 21676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21676&action=edit [SIGNED-OFF] Bug 8007: QA Followup Change GPL version to v3+. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:44:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:44:12 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #32 from Bernardo Gonzalez Kriegel --- Created attachment 21677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21677&action=edit [SIGNED-OFF] Bug 8007: Followup: fix read dir error This patch fixes: - an error on reading the discharges directory - the parameter sent to CancelReserves (API has been changed) - the parameters sent to output_pref (API has been changed) Signed-off-by: Bernardo Gonzalez Kriegel Reading files problem solved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:45:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:45:24 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 --- Comment #15 from Bernardo Gonzalez Kriegel --- sorry, missed one patch. re-uploading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:46:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:46:20 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 --- Comment #16 from Bernardo Gonzalez Kriegel --- (In reply to Bernardo Gonzalez Kriegel from comment #15) > sorry, missed one patch. re-uploading oops, wrong Bug. No problem here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:48:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:48:38 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21660|0 |1 is obsolete| | --- Comment #33 from Bernardo Gonzalez Kriegel --- Created attachment 21678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21678&action=edit [SIGNED-OFF] Bug 8007: Followup: fix read dir error This patch fixes: - an error on reading the discharges directory - the parameter sent to CancelReserves (API has been changed) - the parameters sent to output_pref (API has been changed) Signed-off-by: Bernardo Gonzalez Kriegel Reading files problem solved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:50:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:50:08 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21678|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:51:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:51:23 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:53:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:53:09 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset at hotmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:53:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:53:52 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:53:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:53:56 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21664|0 |1 is obsolete| | Attachment #21665|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 21679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21679&action=edit [PASSED QA] Bug 10602: Set a default value for authorities Some code already exist but the feature does not work. This patch allows to define default values in the authorities framework. Test plan: 1/ Choose a framework, field and subfields. 2/ Define a default value. 3/ Create a new authority and check that the subfield is automatically filled with the default value. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. koha-qa reports some tabs, fixed in followup Test 1) Apply patch, run updatedatabase.pl 2) Edit auth framework, put default value someware, save 3) Add new auth, default value present Signed-off-by: Katrin Fischer Passes all tests and QA script. Verified database update is done correctly. Controlfields 0xx - Edited an existing field (001) - Set a default value for subfield @ - Edited subfield again, checking default was saved correctly - Verified the default shows up correctly when creating a new authority using this authority type Fields - Edited an existing field (100) - Set a default value for subfield e - Edited subfield again, checking default was saved correctly - Verified the default shows up correctly when creating a new authority using this authority type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 19:54:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 17:54:10 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 --- Comment #15 from Katrin Fischer --- Created attachment 21680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21680&action=edit [PASSED QA] Bug 10602 - followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 20:18:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 18:18:17 +0000 Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 --- Comment #23 from Katrin Fischer --- I was thinking maybe not use 'items' as this is confusing in translation and we are exporting information about issues here. But not sure how to phrase it best. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 20:20:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 18:20:42 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10952 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 20:20:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 18:20:42 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10857 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 20:35:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 18:35:39 +0000 Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list turned out untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948 --- Comment #6 from Katrin Fischer --- Created attachment 21681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21681&action=edit [PASSED QA] Bug 10948: make reference labels translatable in OPAC auth results For some reason the translator script was not picking up the see also and used for/see from labels on the OPAC. This patch fixes the problem. To test: 1) Apply patch. 2) Generate PO files. 3) Note that "see from" and "used for/see from" appear. 4) Sign off. Signed-off-by: Nu?o L?pez Ans?tegui Signed-off-by: Katrin Fischer Works nicely, thx for the fix. Tested by updating the German po files, translating the strings and installing the templates. Verified strings show up in German in the authority result list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 20:36:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 18:36:00 +0000 Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list turned out untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 20:36:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 18:36:03 +0000 Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list turned out untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 20:41:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 18:41:17 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 --- Comment #10 from Katrin Fischer --- Thx for taking a look Robin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 21:03:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 19:03:59 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Owen Leonard --- I haven't run across the "Bad request" error again, but I did find this: 1. Perform a search 2. Click a library facet 3. Cancel the library facet 4. Click another library facet At this point there is no "[x]" by the facet I clicked in step 4. Same results in the OPAC and staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 21:57:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 19:57:39 +0000 Subject: [Koha-bugs] [Bug 10978] New: redirect to basket list of a supplier after deleting a baset Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978 Bug ID: 10978 Summary: redirect to basket list of a supplier after deleting a baset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org I copy here a remark that M. de Rooy made while QAing bug 7791. It could be a little improvement "Note that if I am in a basket from some supplier and I delete it, I actually would like to return to the basket list of that supplier instead of getting a list of all suppliers. But that is outside the scope of this report." M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 21:58:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 19:58:00 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 --- Comment #13 from mathieu saby --- (In reply to M. de Rooy from comment #12) > (In reply to mathieu saby from comment #11) > > To be clear : does it occur in master without my patch? > Hi Matthieu, > Yes it does. So nothing to do with your patch.. > > Note that if I am in a basket from some supplier and I delete it, I actually > would like to return to the basket list of that supplier instead of getting > a list of all suppliers. But that is outside the scope of this report. I filled a new bug for that 10978 ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 22:07:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 20:07:19 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 --- Comment #10 from mathieu saby --- Hello Lyon3 do you still disagree with me, especially on the last test? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 22:11:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 20:11:27 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- I am sorry, but this doesn't work for me. My installation uses DOM indexing (authority and bibliographic records) and ICU. What I did: - Reindexed my date, search works correctly - Applied patch - perl Makefile.PL --prev-install-log ../koha-dev/misc/koha-install-log - make upgrade - restarted Zebra server Then tried to reindex: [~/kohaclone (98-10729-icuphrase)?]> ./misc/migration_tools/rebuild_zebra.pl -b -v -r Zebra configuration information ================================ Zebra biblio directory = /home/katrin/koha-dev/var/lib/zebradb/biblios Zebra authorities directory = /home/katrin/koha-dev/var/lib/zebradb/authorities Koha directory = /home/katrin/kohaclone BIBLIONUMBER in : 999$c BIBLIOITEMNUMBER in : 999$d ================================ skipping authorities ==================== exporting biblio ==================== 101.................................................................................................. Records exported: 118 ==================== REINDEXING zebra ==================== *** stack smashing detected ***: zebraidx terminated ======= Backtrace: ========= ... lots of unhappiness ... Without the patch the same database reidexes without any problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 22:46:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 20:46:14 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com --- Comment #151 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 22:49:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 20:49:16 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21632|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 22:49:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 20:49:26 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #152 from sandboxes at biblibre.com --- Created attachment 21682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21682&action=edit UTF8 double encoding fixes. Commits squashed into one. double utf8 encoding fix .. second try minor formatting updates enhancement to the previous patch related to utf8 double encoding added ENCODING=>utf8 to new-> added space which is there in master added utf8::decode for ms_query replaced tabs with spaces replaced tabs with spaces removed extra space Signed-off-by: Srdjan http://bugs.koha-community.org/show_bug.cgi?id=6554 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 23:11:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 21:11:25 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #86 from Katrin Fischer --- I have finally started configuring a shiny new database with examples to test the update with. I am currently stuck on receiving records - there are no orders showing up for receiving in the table of pending orders. I have 2 closed baskets that are assigned to a closed basket group. It's too late to figure out what's going wrong here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 23:17:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 21:17:01 +0000 Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 --- Comment #8 from Robin Sheat --- Thanks Uli! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 23:31:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 21:31:02 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #87 from Katrin Fischer --- Any hints appreciated... the logs are clean. I am not seeing what I am doing wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 23:39:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 21:39:59 +0000 Subject: [Koha-bugs] [Bug 9375] Logging in with LDAP creates duplicate users In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9375 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This does sound bad - any progress on replicating and squashing the bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 23:42:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 21:42:55 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 23:43:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 21:43:12 +0000 Subject: [Koha-bugs] [Bug 3032] Enhancement: ability to deny some patrons password resets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, I have started working on this, but will not be able to finish before the deadlines for 3.14. I am using a new column in categories, so tying it to the patron category. (bug 10796) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 23:47:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 21:47:47 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21634|0 |1 is obsolete| | --- Comment #44 from Bernardo Gonzalez Kriegel --- Created attachment 21683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21683&action=edit [SIGNED-OFF] Bug 9044: Set the number of filters according to number of columns Signed-off-by: Bernardo Gonzalez Kriegel Filters now shows correctly. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 30 23:48:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2013 21:48:16 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.