[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

--- Comment #7 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
No, this is as good as it can be. The only thing that I'm not sure of is
whether you should reinstate AutoCommit and RaiseError straight after eval. I
hate to admit that whenever I had a db update it was always simple and I
started with copying one before, so I'm not familiar with AutoCommit and
RaiseError policy in updatedatabase.pl.

In a way, because it is a single change within transaction, you can even get
away with not changing AutoCommit at all (RaiseError is still in order).

If you are happy I'll proceed with sign-off, and we'll let QA team cast the
final verdict.

-- 
You are receiving this mail because:
You are watching all bug changes.