[Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973

--- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Oops, I hadn't spotted that this was already in, even though my patch applies
on top of it.. what a Muppet!

Anywho, I'm glad the original patch is in and makes the ldap code leaner,
although I'm still confused as to how it fixes the original bug reported? (It
doesn't in my configuration else I wouldn't have got confused and created the
patch in the first place ;) )

I'll open a new bug and move my patch over to it.  Sounds fine to me to have
this bug completely closed to knock it on the head.

Apologies for the confusion.

Martin



(In reply to Chris Cormack from comment #42)
> (In reply to Martin Renvoize from comment #40)
> > Created attachment 20821 [details] [review] [review]
> > Bug 7973: Fixed bug in Auth_with_ldap - Counter patch
> > 
> > I came across this issue at one of our sites today and patched it before
> > finding the bugzilla entry.
> > 
> > The patch already here seems to overcomplicate the issue somewhat unless I'm
> > completely missing something.
> > 
> > Attached is my counter patch proposal.
> 
> The patches here have already been pushed Martin. I am obsoleting them.
> 
> So your patch is not so much a counter patch as a new one, and should be on
> its own bug, this bug should not have been reopened once the patches were
> pushed, a new bug should have been lodged.
> 
> That is of course not your fault, but it still is probably best you put the
> patch on a new bug, and we close this again.
> 
> Sound ok?

-- 
You are receiving this mail because:
You are watching all bug changes.