[Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David,

some very first observations from reading the code and the QA script:

The license on cataloguing/z3950_auth_search.pl is GPL2+ - maybe you could
consider making it GPL3+?

There are some .pl files with SQL statements in them - I think it would be
nicer to move them out to an existing or new module. I know that most of it
probably is kind of a preexisting problem stemming from how we handle
bibliographic records.

For the changes in Breeding.pm some unit tests should be provided.

In your updatedatabase statement could you specify after which column the new
column should be added (little pet peeve of mine I guess :) )?

-- 
You are receiving this mail because:
You are watching all bug changes.