[Koha-bugs] [Bug 7180] Order from staged file improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #72 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

I have started with a code review and fixed some minor issues in a follow-up
patch. Could you take a look at the patch please and add your sign-off if the
changes are ok?

2 concerns so far:

1) I think the use of the new system preference is not clear from the
description, can we give an example maybe? I am also not so happy about the
blank line requirement. Not sure, but could it be handled similar to
opachiddenitems?

2) I started with regression testing: When I add a new order by searching for a
record from the catalog (neworderempty.pl) and choose my fund, the statistic
values are not updated. There is a Javascript error on the page:

ReferenceError: fetchSortDropbox is not defined
fetchSortDropbox(this.form)

I tried refreshing the page multiple times. Failed for 2).

-- 
You are receiving this mail because:
You are watching all bug changes.