[Koha-bugs] [Bug 7180] Order from staged file improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #76 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #72)
> Hi Jonathan,

Hi Katrin,

> I have started with a code review and fixed some minor issues in a follow-up
> patch. Could you take a look at the patch please and add your sign-off if
> the changes are ok?

Yep, thank you for this patch!

> 1) I think the use of the new system preference is not clear from the
> description, can we give an example maybe? I am also not so happy about the
> blank line requirement. Not sure, but could it be handled similar to
> opachiddenitems?

Yes, I added a followup for that: an example is added to the syspref
description and the blank line is useless (added by the script).

> 2) I started with regression testing: When I add a new order by searching
> for a record from the catalog (neworderempty.pl) and choose my fund, the
> statistic values are not updated. There is a Javascript error on the page:
> 
> ReferenceError: fetchSortDropbox is not defined
> fetchSortDropbox(this.form)

Fixed in the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.