[Koha-bugs] [Bug 7683] statistic wizard: cataloging

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Doing a code review of the squashed patches I noticed some things:

1) There are multiple references to items.statisticvalue, but I think we don't
have this column in our items table. Is there a dependency to another
development?

2) The term 'Total' appears a few times in catalogue_stats.pl but is not
translatable (problem was there before). Also those:

+                ( $i == 0 )  ? "Dewey Classification From"
+              : ( $i == 1 )  ? "Dewey Classification To"
+              : ( $i == 2 )  ? "Lccn Classification From"
+              : ( $i == 3 )  ? "Lccn Classification To"
+              : ( $i == 4 )  ? "Item CallNumber From"
+              : ( $i == 5 )  ? "Item CallNumber To"
+              : ( $i == 6 )  ? "Item type"
+              : ( $i == 7 )  ? "Publisher"
+              : ( $i == 8 )  ? "Publication year From"
+              : ( $i == 9 )  ? "Publication year To"
+              : ( $i == 10 ) ? "Library"
+              : ( $i == 11 ) ? "Shelving Location"
+              : ( $i == 12 ) ? "Collection Code"
+              : ( $i == 13 ) ? "Status"

3) Same file:
DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(),
I think we are no longer using this construct.

4) Looking at the code I think the plugin for authorised values could be useful
here.

5) Could you please move the tests as suggested by Jared on comment 20?

Failed QA for 1) (needs clarification) and 5).

-- 
You are receiving this mail because:
You are watching all bug changes.