[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #99 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, what I did was create 2 branches, one with all patches, and another with a
squashed version to allow for easier code review. The QA script fails in
several places. Bit worried about some of those, so I will wait for a follow
up:

QA SCRIPT
testing 1 commit(s) (applied to 6fcb671 'Bug 10678 - Update addbooks help
page')

 OK    C4/Charset.pm
   OK      pod
   OK      forbidden patterns
   OK      valid
   OK      critic

 FAIL    C4/ImportBatch.pm
   OK      pod
   OK      forbidden patterns
   FAIL      valid
        Useless use of private variable in void context 
   OK      critic

 OK    C4/Koha.pm
   OK      pod
   OK      forbidden patterns
   OK      valid
   OK      critic

 FAIL    C4/MarcModificationTemplates.pm
   OK      pod
   FAIL      forbidden patterns
        forbidden pattern: Koha is now under the GPLv3 license (line 9)
   FAIL      valid
        Useless use of private variable in void context 
   OK      critic

 FAIL    Koha/SimpleMARC.pm
   OK      pod
   OK      forbidden patterns
   OK      valid
   FAIL      critic
        Expression form of "eval" at line 89, column 7. See page 161 of PBP.
        Expression form of "eval" at line 242, column 12. See page 161 of PBP.

 OK    installer/data/mysql/updatedatabase.pl
   OK      pod
   OK      forbidden patterns
   OK      valid
   OK      critic

 OK    t/SimpleMARC.t
   OK      pod
   OK      forbidden patterns
   OK      valid
   OK      critic

 OK    t/db_dependent/MarcModificationTemplates.t
   OK      pod
   OK      forbidden patterns
   OK      valid
   OK      critic

 FAIL    tools/marc_modification_templates.pl
   OK      pod
   FAIL      forbidden patterns
        forbidden pattern: Koha is now under the GPLv3 license (line 8)
   FAIL      valid
        Useless use of private variable in void context 
   OK      critic

 FAIL    tools/stage-marc-import.pl
   OK      pod
   OK      forbidden patterns
   FAIL      valid
        Useless use of private variable in void context 
   OK      critic

 OK    koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
   OK      forbidden patterns
   OK      tt_valid
   OK      valid_template

 OK    koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
   OK      forbidden patterns
   OK      tt_valid
   OK      valid_template

 FAIL   
koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
   FAIL      forbidden patterns
        forbidden pattern: intranet-tmpl should certainly replaced with [%
interface %] (line 301)
        forbidden pattern: intranet-tmpl should certainly replaced with [%
interface %] (line 305)
        forbidden pattern: intranet-tmpl should certainly replaced with [%
interface %] (line 293)
        forbidden pattern: intranet-tmpl should certainly replaced with [%
interface %] (line 297)
   OK      tt_valid
   OK      valid_template

 OK    koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt
   OK      forbidden patterns
   OK      tt_valid
   OK      valid_template

 OK    koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
   OK      forbidden patterns
   OK      tt_valid
   OK      valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.