[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #100 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #99)
> Ok, what I did was create 2 branches, one with all patches, and another with
> a squashed version to allow for easier code review. The QA script fails in
> several places. Bit worried about some of those, so I will wait for a follow
> up:

Katrin,
These failures are not critical for testing.

* Useless use of private variable in void context 
Can be fixed replacing eval{$eval}; with eval $eval;

* forbidden pattern: Koha is now under the GPLv3 license (line 9)
is easy to fix, just c/p lines from the coding guidelines wiki page

* Expression form of "eval" at line 89, column 7. See page 161 of PBP.
I already see this one, but I don't know how to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.