[Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584

--- Comment #19 from M. Tompsett <mtompset at hotmail.com> ---
I set the depends on, because bug 10872 just fixes that one line in C4::Items
which is clear enough to eyeball. See GetHiddenItems() call to YAML::Load and
ask yourself, where is it required or used? opac-detail.pl and
opac-ISBDdetail.pl both load something which uses or requires YAML, but
opac-MARCdetail.pl has a smaller use list, which does not.

This fixes the entire block displaying. Bug 10876 is a partial display issue
for opac-MARCdetail.pl

Test Before Apply
=================
Somehow part of an earlier version of this made it into master. This means that
opac-details.pl will generate a 404.pl page following the "Test After Apply"
steps, but the other two URLs will not.

1) Log into staff client and blank OPACHiddenItems
2) Open a browser to the OPAC.
3) Find something that has multiple items (e.g. same book in two branches)
4) Click on the link (e.g.
demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=33158)
5) Click on "Marc view", and the same number of items should be displayed.
6) Click on "ISBD view", and an entry should come up.
7) In the staff client hide all the items (e.g. homebranch: [DAV,MNL])
8) Click on the "Normal View", and you should get a 404.pl page.
-- this is due to the push that was already done.
9) Paste in the opac-MARCdetail.pl url (e.g.
demo.library.kohasystem.ca/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=33158)
   Items should display as before. :(
10) Paste in the opac-ISBDdetail.pl url (e.g.
demo.library.kohasystem.ca/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=33158)
    Page should be as before.
11) Click the logo, and redo the initial search
12) Nothing related to the biblionumber used should come up.

Test After Apply
================
1) Log into staff client and blank OPACHiddenItems
2) Open a browser to the OPAC.
3) Find something that has multiple items (e.g. same book in two branches)
4) Click on the link (e.g.
demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=33158)
5) Click on "Marc view", and the same number of items should be displayed.
6) Click on "ISBD view", and an entry should come up.
7) In the staff client hide all the items (e.g. homebranch: [DAV,MNL])
8) Click on the "Normal View", and you should get a 404.pl page.
9) Paste in the opac-MARCdetail.pl url (e.g.
demo.library.kohasystem.ca/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=33158)
   A 404.pl page should be given. IF NOT, YOU FORGOT TO TEST AND APPLY BUG
10872.
10) Paste in the opac-ISBDdetail.pl url (e.g.
demo.library.kohasystem.ca/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=33158)
    A 404.pl page should be given.
11) Click the logo, and redo the initial search
12) Nothing related to the biblionumber used should come up.

This bug fixes the full hidden case.

-- 
You are receiving this mail because:
You are watching all bug changes.