[Koha-bugs] [Bug 7180] Order from staged file improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #93 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hello Jonathan
At first it seemed to work, but with further tests I found some issues : 

--
issues : 
When I click on "Card" in front of each line, I have a software error : 
Empty String at /home/msaby/kohamaster/src/catalogue/showmarc.pl line 64.


I also tried to set "rrp: 010$d", without a "price..." line in syspref.
I was surprise to see a blank field for "price". Because some price was
imported, from $010$d. So the librarian must see it is ok. Otherwise, he will
be confused and fill himself manually a price.

In fact, the price was imported, but wrongly calculated
My vendor had these settings : 
List item price includes tax: Yes
Invoice item price includes tax: Yes
Discount: 10.0 %
Tax rate: 5.5 %

My record had "20.00 EUR" in 010$d. So RRP = 20.00
So the listprice would have been "20 EUR", and the ecost "20 - 2 = 18"
Instead, I had in my basket a line with
- RRP tax inc = 22.22
- ecost tax inc = 20
- ecost tax ecl = 18.96

So something went wrong. RRP should have been taken from the record. Of course,
my main currency is EUR.

--
Some questions:
Regarding prices : currently, "unitprice" is set to 0 when we fill an order.
The unitprice (aka unit cost) is filled when we receive the document. It must
be equal to the price actually printed on the invoice joined with the parcel.
We have always been said it was not used before in Koha.
But with your patch, unitprice is filled when we create the basket.
Is it normal or not? Could it be a source of mistake in Koha price calculation?
(I am always a bit lost with price management in Koha...)

I suppressed mapping of price and rrp in the syspref, and a price was still
imported, from $010 I suppose. Is it still hardcoded somehow ? Is it a wanted
behavior?

--
Some remarks : 

There are 2 buttons "Save" on the 1st and the 3rd tab. I suppose they do the
same action (not a problem for me) ?

I like the tabs, and the renaming "DEFAULT accounting details". It could help
libs to understand that these values are overridden by the values defined in
each line.

I think restoring "Add order" link was needed to avoid a functional regression
for ppl using the duplicate check feature.
But maybe the "Add order" link for each line could be deleted in a further
development, because it will be strange from user point of view to have the
ability to check a box in front of a line, OR to click on a link.

Librarians will need to know clearly that :
- they don't need to fill the field "discount" in a line if it is void (because
it is defined at vendor level)
- they can click on "Add order" to add the order with a duplicate check before
(like in current master, but this has never been obvious for us...)

I don't konw if it should be written in online help or in the template itself.

===
Could you check the software error please and the prices questions? 

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.