[Koha-bugs] [Bug 10869] can't delete order line if title deleted

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
It is not only a js pbm, because without biblionumber, addorder.pl cannot
delete the order...
The biblionumber is needed by Acquisitions::DelOrder sub.

So I made changes to addorder.pl and to DelOrder sub (which it not used in
code).
Now, DelOrder sub takes the ordernumber before the biblionumber. And if there
is no biblionumber given, it does not try to suppress items.


====
commit message
This patch fixes 2 issues :
(medium issue) It is not possible to delete an order in a basket if the biblio
record is deleted.
(minor issue) There is a useless hyperlink around "Deleted bibliographic
notice", and "notice" is a frenchism for "record"

I had to change the behavior of Acquisitions::DelOrder (which is used only by
addorder.pl file), a line in addorder.pl, and a few lines in template
basket.tt.

To test :
1. Fill a basket with some records (some records with items or holds, some
without items)
2. Supress one of the record
3. In the basket (refresh the screen) check that "Deleted bibliographic notice"
line was replaced with "Deleted bibliographic record", without hyperlink
arround
4. Delete this order with the link "Delete order" to the right column of the
table
5. Check there is a new line in the "Deleted orders" table
6. Check there is no regression : felete an other order (one with no item),
then check you cannot delete an order with an item (like before patch)



Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.