[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle,

starting with the tests and a first code review:

Would you be ok updating to GPLv3+?
FAIL    members/purchase-suggestions.pl
   OK      pod
   FAIL      forbidden patterns
        forbidden pattern: Koha is now under the GPLv3 license (line 9)

Is this still relevant?
+    DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(),

I wonder if we need a way to allow for disabling this functionality in the
patron account or a way to differentiate between suggestions created by the
user in the OPAC and by a staff member. And not failing for this - but so you
can take a look at the other 2 things.

-- 
You are receiving this mail because:
You are watching all bug changes.