[Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509

--- Comment #21 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Chris Cormack from comment #18)
> This no longer applies because the tests (that weren't being used) have been
> removed. It would be good to add a test for the 2 new subroutines added.

Chris, if you refer to the two subroutines _run_mysql_file and  _tr_sql_fname,
I just consider them as internal 'private' routines (with an underscore) for
load_sql_in_order. That would not (always/explicitly) require unit tests.

Note that the changes would certainly justify changes in the unit tests for
load_sql_in_order, but unfortunately we do not even have a unit test for this
routine or its module. Should that block this change?

-- 
You are receiving this mail because:
You are watching all bug changes.