[Koha-bugs] [Bug 10500] Improve isbn matching when importing records

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Kyle M Hall from comment #11)
> > 1/ In UNIMARC the isbn index is "ISBN". I will provide a followup.
> 
> Thanks!
>  
> > 2/ Even with this patch, I got "0 records with at least one match in catalog
> > per matching rule "ISBN"".
> 
> It that with the new syspref on, off, or both?

both.

> > Some debugging: If I add the line:
> >   warn "$source_key $target_key" unless $source_key eq $target_key;
> > to C4/Matcher.pm:770 (in the foreach @{ $matchchecks } loop).
> > I got, in logs:
> >   "0394502884 RANDOMHOUSE 0394502884 UNRANDOMHOUSE"
> > 
> > And C4::Matcher::get_matches always returns an empty array.
> > 
> > Marked as Failed QA (but maybe I am wrong somewhere...)
> 
> You use use Data::Dumper on @source_keys on line 639? That will tell use if
> the isbn's are being transformed correctly.

Yes, I get: ['0-394-50288-4', '0-394-50288-4', '978-0-394-50288-5',
'0394502884', '9780394502885']

> Does the unit test pass for you?

Yes.

-- 
You are receiving this mail because:
You are watching all bug changes.