[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032

--- Comment #32 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to M. de Rooy from comment #31)
> (In reply to Jonathan Druart from comment #26)
> First of all, thanks for your QA, although the results were negative :)
> 
> > - The new letter should be added to others languages.
> I would really get rid of that restriction. I started some development on
> that (look for i18n). But unfortunately there is not that much support for
> it.

So should this patch depends on them?

> > - The new pl file contains a lot of routines. Some of them use global
> > variables which are not defined as global.
> Please explain.

If you use a global variable in a routine, you should declare it as 'our'
instead of 'my'.

> > Marked as Failed QA.
> If this should really fail for the reasons given, I will have to let this
> development rest for some time. I do not have the time to keep everything in
> the air now ;) Note that this impacts also unit tests and the accept a
> share-followup reports.

-- 
You are receiving this mail because:
You are watching all bug changes.