[Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20747|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21241
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21241&action=edit
Bug 10683: CRUD routines in C4::Circulation need unit tests

This patch adds some unit tests wrap in a transaction for C4::Circulation.pm.

Circulation_Branch.t adds tests for routines which deal with
branch_item_rules,branch_borrower_circ_rules, default_branch_circ_rules,
default_circ_rules, default_branch_item_rules in the database.

Circulation_issue.t adds tests for routines which deal with accountline and
issues in the database.

NOTE: Some commented tests have to be fixed, and some tests can be added.More,
other routines of Circulation.pm are tested in the patches:
10692    UT: Routines about transfers in Circulation.pm need unit tests
10710    UT : OfflineOperation's routines in C4/Circulation.t need unit tests
10767   UT: Routines which interact with the table issuingrules in
C4/Circulation need unit test

Test plan:
prove t/db_dependent/Circulation_issue.t
t/db_dependent/Circulation_issue.t .. ok
All tests successful.
Files=1, Tests=16,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.40 cusr  0.02
csys =  0.44 CPU)
Result: PASS

prove t/db_dependent/Circulation_Branch.t
t/db_dependent/Circulation_Branch.t .. ok
All tests successful.
Files=1, Tests=10,  2 wallclock secs ( 0.06 usr  0.00 sys +  1.02 cusr  0.06
csys =  1.14 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Comment: Well, I don't know exactly what to do with this, so
I left it to QA

a) prove t/db_dependent/Circulation_Branch.t works well and without erros

b) prove t/db_dependent/Circulation_issue.t works without errors for me
ONLY if I have a issuingrule for All, All with 1 as renewals allowed, in
other cases it fails.

No koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.