[Koha-bugs] [Bug 10921] New: You can edit an order even when it is in a closed basket

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10921

            Bug ID: 10921
           Summary: You can edit an order even when it is in a closed
                    basket
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

You can edit an order even when it is in a closed basket.

I think it should be only allowed to some librarians.
In fact, there is a piece of code supposed to make a control, but it is broken
:
In neworderempty.tt, I think the [% IF ( close ) %] condition is always false,
or is not true when it need to be, because in neworderempty.pl, "close"
parameter is not passed to the template if you try to look at an order in a
closed basket (by tweaking the url of an open order for ex)

in perl file : 

my $close           = $input->param('close');
[...]
if ($close) {
    $budget_id      =  $data->{'budget_id'};
    $budget_name    =   $budget->{'budget_name'};

}
[...]
# fill template
$template->param(
    close        => $close,
    budget_id    => $budget_id,
    budget_name  => $budget_name
) if ($close);


M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.