[Koha-bugs] [Bug 10821] label pdf adding in strange breaking

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821

--- Comment #22 from Chris Nighswonger <cnighswonger at foundations.edu> ---
Just a few comments to hopefully assist in understanding what has happened and
why.

1. This change was intended to improve the quality of the code underlying LCCN
splitting as well as standardize it. It was not intended to radically alter the
high-level functionality of this splitting algorithm.

2. This change was routine. In other words, it was well within the norms of
code maintenance in the software development profession.

3. This change does not affect the splitting of LCCN standard compliant
numbers. It is numbers of this nature that are included in Koha's test suite.
The test suite runs fine both before and after the change as expected.

4. While acknowledging the liberty permitted by LCCN for the addition of
prefixes and suffixes, we must also acknowledge that anticipating and providing
test cases for every library's individual implementation of that liberty would
prove to be an unrealistic goal.

5. However, there are some things which can be "loosened up." (ie. dropping
normalization, etc.) But this must be done in a forward looking direction with
the goal of keeping the code maintainable. This means not going back to code
which is less maintainable. As everyone is no doubt aware, much of the work
done on Koha is gratis. Indeed, the vast majority of the label code has been
provided at no cost. Thus it is important to keep it easy to maintain. We have
done this by filing a bug with the new LCCN Perl library's maintainer. I
suspect the changes will be forthcoming.

6. It is possible (but probably not a good idea) to overwrite your current
version of C4/Labels/Label.pm with a 3.10.07 copy and return to the older
algorithm. Do this at your own risk as it may have unintended consequences of
which I am incapable of knowing.

Please, this is not intended as a snub and "WONTFIX" does not mean "DONTCARE."
I have hundreds of hours of coding time into the label tool, working alongside
the catalogers at the library here. I completely empathize with your pain. This
is why we are constantly stressing the need of pre-testing prior to doing an
upgrade of any sort. Setting up a test server, installing the version of Koha
you intend to upgrade to on it, loading up your data, and testing the features
you use will prevent nasty surprises like this one.

Kindest Regards,
Chris

-- 
You are receiving this mail because:
You are watching all bug changes.