[Koha-bugs] [Bug 10808] Thesaurus search form does not correspond to current search query

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21261|0                           |1
        is obsolete|                            |
  Attachment #21262|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21322
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21322&action=edit
[PASSED QA] Bug 10808 - Thesaurus search form does not correspond to current
search query

When cataloging a field defined with a thesaurus, an authority search popup is
displayed with a search from. Once operators, values and sort selected in this
form the search can be performed. The bug is that the values entered are kept
but not the selected operators and sort.
The same bug was existing in authorities module, solved by Bug 8692.

This patch corrects the bug.
Also uses in 'sort by' options the same text as search in authorities module :
Heading A-Z (default), Heading Z-A, None.
Also removes duplicated code in auth_finder.pl : value_mainstr =>
$query->param('value_mainstr') || "", ...

Test plan :
- Create a new biblio with a framework containing a field linked to a
thesaurus. For example : 600
- Click on small icon of main entry. For example : 600$a
=> You get a search form with all operators to "contains" and sort by "Heading
A-Z"
- Enter a value in each text box and perform search
=> You get a search form with values in text boxes and all operators to
"contains"
- Select "starts with" in all operator comboboxes and perform search
=> You get a search form with all operators to "starts with"
- Select "is exactly" in all operator comboboxes and perform search
=> You get a search form with all operators to "is exactly"
- Select "Heading Z-A" in sort by and perform search
=> You get a search form with "Heading Z-A" in sort by
- Select "None" in sort by and perform search
=> You get a search form with "None" in sort by

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comment: With both patches applied no koha-qa errors

Test
1) Original behavior is whatever selection you do before patch,
search form returns to default options
2) After patch, selection remains

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All tests and QA script pass, further comments on second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.