[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

--- Comment #69 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #65)
> Hi Jonathan,
Hi Katrin,

> [...]
> Could you take a look? I will continue testing the functionality.

Will be fixed.

(In reply to Katrin Fischer from comment #66)
> Some additional notes from code review:
> - GetBasketGroupAsCSV could use some unit tests as the SQL 
>   statement has been altered quite a bit.

The modified routine is GetOrder. It already has a unit test (not really good
but exists).

> - lateissues-export.pl could use Modern::Perl
Will be done.

(In reply to Katrin Fischer from comment #67)
> Hi Jonathan,
>   * Exporting as CSV
>      * Exported single line > CSV appears correct.
>      * Exporting multiple lines > CSV appears correct.
>      PROBLEM: Translated CSV don't work correctly, as line
>      breaks are lost in the translation process.

>   * Sending serial claim email
>      * No regressions found - there are some problems with the
>        email contents noted on bug 7298.

We are on bug 7298 :)


> In order to reproduce the problem with translated CSV files make sure you
> test with updated po files containing a translated version of the header row
> or a copy of it. I think we already ran into this problem with the templates
> for the cart email, which are plain text and not HTML. Not sure how to solve
> this, but currently it seems not to work for translated templates at all as
> you will get
> all data on one single line.

I will have a look at bug 10931. But the problem does not occur for others csv
export (basket and basketgroup)?

-- 
You are receiving this mail because:
You are watching all bug changes.