[Koha-bugs] [Bug 10305] _increment_barcode is called twice

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Works. Looks good to me. There was no problem before, just a duplicate
executing of a select max in the database.

Note that the code used for this increment might still be wrong with concurrent
edits, since the max calculation and the update of the table are quite separate
parts in code. Reminds me of the discussion about the seqno engine..

No complaints from qa tools.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.