[Koha-bugs] [Bug 10807] OPAC: There is no authority search history

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807

--- Comment #25 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #23)
> (In reply to Jonathan Druart from comment #21)
> > I created the module in the C4 namespace precisely because it is not a OO
> > module.
> 
> I don't recall there be any requirement that the Koha names *only* be for
> OO-modules.  New modules should preferentially be OO, but there is a place
> in Koha for modules that are simply collections of utility code.

Galen,

It is in the coding guidelines:
http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL15:_Object-oriented_code_and_the_Koha::_namespace
To me this module is not perfect (by far). So I had a preference for submitting
the module as it into the C4 namespace.

> In this case, Koha::Search::History can be readily made OO, IMO.

I will try to move the existing module to the Koha namespace. But I prefer to
do it after these patches (and patches from bug 10862) will be pushed.

Hope that make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.