[Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961

--- Comment #2 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 21520
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21520
Bug 10961 - Error in GetMarcBiblio can cause severe data loss

Review of attachment 21520:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10961&attachment=21520)
-----------------------------------------------------------------

::: C4/Biblio.pm
@@ +1252,4 @@
>      my $biblionumber = shift;
>      my $embeditems   = shift || 0;
>      my $dbh          = C4::Context->dbh;
> +    my $sth          = $dbh->prepare("SELECT * FROM biblioitems WHERE biblionumber=? ");

You don't need * here, just "marcxml, biblioitemnumber".  Since biblioitems
also contains the marc column, select * just causes unnecessary network traffic
for remote DB servers.

-- 
You are receiving this mail because:
You are watching all bug changes.