[Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not entirely sure how to test this, but I have started with running the
automated and db_dependent tests and it looks to me like the change breaks
t/db_dependent/Context.t.

On master:
[~/kohaclone (master)]> prove t/db_dependent/Context.t 
t/db_dependent/Context.t .. # Note: The overall number of tests may vary by
configuration.
# First we need to check your environmental variables
t/db_dependent/Context.t .. 1/? # Number of keys in %$koha: 13
# Examining defined key values.
# Testing syspref caching.
t/db_dependent/Context.t .. ok    
All tests successful.
Files=1, Tests=38,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.16 cusr  0.01
csys =  0.21 CPU)
Result: PASS

With patch applied:
[~/kohaclone (71-10611-contextdb)]> prove t/db_dependent/Context.t 
t/db_dependent/Context.t .. # Note: The overall number of tests may vary by
configuration.
# First we need to check your environmental variables
t/db_dependent/Context.t .. 1/? # Number of keys in %$koha: 13
# Examining defined key values.
# Testing syspref caching.

#   Failed test 'Retrieved syspref (value='thing1') successfully with default
behavior'
#   at t/db_dependent/Context.t line 74.
#          got: undef
#     expected: 'thing1'
Can't use an undefined value as an ARRAY reference at t/db_dependent/Context.t
line 76.
# Tests were run but no plan was declared and done_testing() was not seen.
t/db_dependent/Context.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/25 subtests 

Test Summary Report
-------------------
t/db_dependent/Context.t (Wstat: 65280 Tests: 25 Failed: 1)
  Failed test:  25
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
Files=1, Tests=25,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.17 cusr  0.00
csys =  0.22 CPU)
Result: FAIL

Jonathan, can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.