[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

--- Comment #62 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Starting with a code review based on squashed patches:

1) Bug number missing from database update

2) In subscription-add.pl there is a typo, not sure the consequences:
   -    $templte->param(letterloop => $letterloop);
   +    $templte->param( letterloop => $letterloop );

3) I'd really like to have more information about the use of the 
   published_end_date and bound volumes - this seems to be a separate 
   feature. The test plan says:

>Part 4:
>1) Apply the patch. Add/update a serial, and choose a published end date.
>2) Verify the date was stored in the database correctly ( >serials.published_end_date )
>NOTE: The purpose of this feature is to better handle the dates of bound >volumes of serials. Right now, we specify the first published date, but not the >published date of the last issue in a bound volume.

There is currently no real workflow for adding bound volumes - what are you
referring to here? What steps lead to a bound volume for this library?

--
I am a bit worried about the amount of testing this has seen - was an existing
database converted with this patch? What were the results? Were other more
unusual subscription patterns tested as well?

-- 
You are receiving this mail because:
You are watching all bug changes.