[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #147 from Ketan Kulkarni <ketan at carvingit.com> ---
Oops. Sorry .. That was an oversight. I think we can safely remove the if()
from those lines.  I'd like to hear from fellow developers.

How do I remove tabs and put spaces? I use vi editor and I use tab for
indentation.

Regards,
Ketan

(In reply to Ketan Kulkarni from comment #146)
> Thank you Srdjan for consolidating the patch and also for removing the if()
> from
> 
> utf8::upgrade($some_var) if utf8::is_utf8($some_var);
> 
> The condition is not needed.
> 
> Regards,
> Ketan
> 
> (In reply to Srdjan Jankovic from comment #145)
> > I cannot sign off, it has tabs instead of spaces.
> > 
> > I have replaced the multi-patch with this consolidated one. Please check if
> > the commit message is ok.
> > 
> > Also, I don't have time to look deeper, but
> >   utf8::upgrade($some_var) if utf8::is_utf8($some_var); 
> > looks wrong, that should not be needed. Or at least looks like the problem
> > is being addressed in the wrong place.
> > 
> > ENCODING => 'utf8' makes sense.
> > 
> > Encode::decode() would also makes sense I presume.

-- 
You are receiving this mail because:
You are watching all bug changes.