[Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
This looks quite good to me. No complaints from qa tools.
I just have one question: I think it would be even more friendly to the user if
you could report the errors DelBiblio returns on refused deletions (because of
items not connected to orders).
At this time your code does not look at a possible return value of DelBiblio.
Would it be possible for you to add this in a followup? (But I do not think
this should block your patch..)

And I got struck by another problem when testing your patch, but it does not
depend on your changes but is connected to booksellers.pl.
If I delete a basket, the return page is booksellers.pl. Every time I get the
Firefox message: A script on this page may be busy, or it may have stopped
responding. You can stop the script now, or you can continue to see if the
script will complete. 
Script: http://[servername]/intranet-tmpl/lib/jquery/jquery.js:4
Just mentioning it here for completeness.

Changing the bug status for now.

-- 
You are receiving this mail because:
You are watching all bug changes.