From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 01:53:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 31 Mar 2014 23:53:40 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 02:25:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 00:25:18 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26696|0 |1
is obsolete| |
--- Comment #24 from Srdjan Jankovic ---
Created attachment 26713
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26713&action=edit
bug_11213: C4::VirtualShelves::Page::shelf_contents()
* Extracted shelf items processing from shelfpage() into a separate sub
shelf_contents() in order to be able to test it
* Added tests for shelf_contents() with XSLT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 02:36:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 00:36:44 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
--- Comment #25 from M. Tompsett ---
You modified GetItemsInfo.
t/db_dependent/Items.t needs to have GetItemsInfo calls.
You modified searchResults.
t/db_dependent/Search.t needs to have calls to searchResults that will trigger
changed code.
You modified shelfpage.
t/db_dependent/VirtualShelves_Page.t needs to at least have a call to shelfpage
added. You moved most of the changes into the shelf_contents and properly added
a test for it, but the removal of code in shelfpage still may merit a call to
shelfpage too.
Your tweaks in C4/XSLT don't expressly need a test, but
t/db_dependent/XSLT.t probably should be created with at least a call to
XSLTParse4Display.
These are the tests I am expecting.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 05:18:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 03:18:28 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998
--- Comment #4 from Robin Sheat ---
Created attachment 26714
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26714&action=edit
Bug 11998 - sysprefs in memcached
The caching mechanism has been abstracted a little bit, and now supports
memcached for storing sysprefs. These should be correctly stored and
cleared so caching will work between processes.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 05:19:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 03:19:15 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 05:21:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 03:21:01 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998
--- Comment #5 from Robin Sheat ---
These patches will need to be treated as a series, they depend on the previous
ones.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:13:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 04:13:22 +0000
Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links
authority records to a biblio record during edition. (AJAX)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |aleishaamohia at hotmail.com
--- Comment #5 from Aleisha Amohia ---
Created attachment 26715
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26715&action=edit
Adding bug number for signing off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:14:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 04:14:26 +0000
Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links
authority records to a biblio record during edition. (AJAX)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23146|Add a button to the biblio |Bug 11299: Add a button to
description|edition page to |the biblio edition page to
|automatically add authority |automatically add authority
|links. |links.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:15:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 04:15:09 +0000
Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links
authority records to a biblio record during edition. (AJAX)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26715|Adding bug number for |Bug 11299: Adding bug
description|signing off |number for signing off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:15:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 04:15:25 +0000
Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links
authority records to a biblio record during edition. (AJAX)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26715|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:19:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 04:19:19 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998
--- Comment #6 from Robin Sheat ---
Created attachment 26716
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26716&action=edit
Bug 11998 - add test case, fix issue found
Adds a test case with improved coverage of the caching functionality.
Fixes a bug that was uncovered by writing the test case.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:22:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 04:22:04 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26716|0 |1
is obsolete| |
--- Comment #7 from Robin Sheat ---
Created attachment 26717
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26717&action=edit
Bug 11998 - add test case, fix issue found
Adds a test case with improved coverage of the caching functionality.
Fixes a bug that was uncovered by writing the test case.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:42:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 04:42:39 +0000
Subject: [Koha-bugs] [Bug 12020] New: label-edit-batch has hardcoded error
messages
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020
Bug ID: 12020
Summary: label-edit-batch has hardcoded error messages
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: I18N/L10N
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at pttk.fi
QA Contact: testopia at bugs.koha-community.org
CC: frederic at tamil.fr
$ grep errstr labels/label-edit-batch.pl
koha-tmpl/intranet-tmpl/prog/en/modules/labels/*
labels/label-edit-batch.pl:my $errstr = undef;
labels/label-edit-batch.pl: $errstr = "item(s) not removed from batch
$batch_id." if $err;
labels/label-edit-batch.pl: $errstr = "batch $batch_id was not deleted." if
$err;
labels/label-edit-batch.pl: $errstr = "item(s) not added to batch
$batch_id." if $err;
labels/label-edit-batch.pl: $errstr = "items(s) not added, the error
was: Branch is not set, you please set your branch before adding items to a
batch";
labels/label-edit-batch.pl: $errstr = "batch $batch_id not fully
de-duplicated." if $duplicate_count == -1;
labels/label-edit-batch.pl: errstr => $errstr,
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt:
WARNING: An error was encountered and [%
errstr %] Please have your system administrator check the error log for
details.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 07:46:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 05:46:05 +0000
Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739
--- Comment #119 from Katrin Fischer ---
Testing this again, please have a little patience.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 07:48:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 05:48:33 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
--- Comment #26 from Srdjan Jankovic ---
Created attachment 26718
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26718&action=edit
bug_11213: Use branch codes from the database rather than hardcoded CPL and MPL
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 07:48:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 05:48:43 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
--- Comment #27 from Srdjan Jankovic ---
Created attachment 26719
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26719&action=edit
bug_11213: GetItemsInfo() test
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 08:17:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 06:17:38 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
--- Comment #28 from Srdjan Jankovic ---
Created attachment 26720
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26720&action=edit
bug_11213: Added XSLTParse4Display() to Items test
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 08:19:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 06:19:15 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
--- Comment #29 from Srdjan Jankovic ---
Created attachment 26721
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26721&action=edit
bug_11213: Check for $item->{itype} presence to avoid warning
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 09:29:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 07:29:03 +0000
Subject: [Koha-bugs] [Bug 11763] Consolidate fund action links into menu
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763
--- Comment #6 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #5)
> The dependent bug still needs a sign off - hoping to get back to this soon.
Does someone check the BLOCKED queue?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 09:43:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 07:43:29 +0000
Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744
--- Comment #16 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #15)
> Could showing an alert: 'There is at least 1 hold on this record, please
> delete items manually' be an option?
Did you see I added a 'title' on the "Can't cancel receipt" span?
It displays "Cannot cancel receipt of this order line because at least one
reservation exists on the records." on mouse over.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 10:35:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 08:35:21 +0000
Subject: [Koha-bugs] [Bug 7673] New patron permissions
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673
--- Comment #40 from Jonathan Druart ---
Created attachment 26722
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26722&action=edit
Bug 7673: the limitation on editing an item does not affect FA framework
The pref SubfieldsToAllowForLimitedEdition should not affect Fast
cataloguing framework (FA).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 11:07:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 09:07:14 +0000
Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't
properly respect HomeOrHoldingBranchReturn syspref
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981
--- Comment #2 from Benjamin Rokseth ---
Actually, on second look, circ/returns.pl uses
C4::Context->preference('HomeOrHoldingBranchReturn');
Others should probably decide, but there cannot be two conflicting return
policies, and I believe C4::Circulation should be the preferred setting.
C4::GetBranchItemRule returns noreturn|holdingbranch|homebranch and defaults to
homebranch if no default circulation rule is set.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:15:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 10:15:15 +0000
Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't
properly respect HomeOrHoldingBranchReturn syspref
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981
--- Comment #3 from Benjamin Rokseth ---
Created attachment 26723
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26723&action=edit
Bug 7981 - Transfer message when returning doesn't properly respect
HomeOrHoldingBranchReturn syspref
This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl
respect branch
circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip
notice should reflect this.
Default should always be to return item to home branch.
Test plan:
- make sure syspref 'AutomaticItemReturn' is set to 'false'
- unset 'Default checkout, hold and return policy' or set 'Return policy' to
'Item returns home'
- checkout an item and do a checkin from different branch than items homebranch
- verify that you're prompted with a transfer message to item's home branch and
that print slip matches
- set 'Return policy' to 'Item returns to issuing library'
- do a checkout and a checkin from branch different than item's home branch
- verify that you're not prompted with a transfer message and that holding
library is your current branch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:17:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 10:17:01 +0000
Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't
properly respect HomeOrHoldingBranchReturn syspref
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:20:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 10:20:44 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
--- Comment #30 from M. Tompsett ---
Comment on attachment 26718
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26718
bug_11213: Use branch codes from the database rather than hardcoded CPL and MPL
Review of attachment 26718:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11213&attachment=26718)
-----------------------------------------------------------------
::: t/db_dependent/Items.t
@@ +29,5 @@
> }
>
> my $dbh = C4::Context->dbh;
> +my $branches = GetBranches;
> +my ($branch1, $branch2) = keys %$branches;
I like the idea, but you are missing a check to make sure they are defined. And
if they aren't, you need to temporarily add them and then roll them back.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:31:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 10:31:20 +0000
Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't
properly respect HomeOrHoldingBranchReturn syspref
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981
Petter Goks?yr ?sen changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |boutrosboutrosboutros at gmail
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:40:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 10:40:59 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26691|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:41:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 10:41:15 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26694|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:42:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 10:42:10 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:04:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 11:04:41 +0000
Subject: [Koha-bugs] [Bug 3050] Add an option to upload scanned invoices.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:04:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 11:04:44 +0000
Subject: [Koha-bugs] [Bug 3050] Add an option to upload scanned invoices.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050
--- Comment #6 from Jacek Ablewicz ---
Created attachment 26724
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26724&action=edit
Bug 3050: [QA Followup] Fix various QA issues, plus some minor improvements
QA followup for: Bug 3050 - Add an option to upload scanned invoices.
- Fixed various QA issues.
- Added unit tests for the new module.
- Improved error handling; extended pod documentation
in Koha::Misc::Files
- Attached file records were not properly handled when merging
invoices; fixed.
Test plan add-ons:
1/ prove t/db_dependent/Koha_Misc_Files.t
2/ try to merge some invoices with files attached; after merge,
all files previously attached to individual invoices being
merged should be attached to resulting invoice (merge destination)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:25:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 11:25:02 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
invoice page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613
--- Comment #40 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #39)
> Ok, this gives me a headache :( Can I get a consolidated test plan?
A test plan could be:
0) Add a value in the gist pref (0.1 or 0.25 or something else easy).
1)
a) Create a supplier "10613 0 0" with
List item price includes tax: No
Invoice item price includes tax: No
b) Create a supplier "10613 0 1" with
List item price includes tax: No
Invoice item price includes tax: Yes
c) Create a supplier "10613 1 0" with
List item price includes tax: Yes
Invoice item price includes tax: No
d) Create a supplier "10613 1 1" with
List item price includes tax: Yes
Invoice item price includes tax: Yes
2) Create a basket for each supplier
3) Create 1+ order(s) with 1+ item(s) for each basket with a discount and a gst
value.
4) Close the baskets
5) Receive the items
6) Go on acqui/invoice.pl?invoiceid=XX acqui/basket.pl?basketno=YY for each
basket/invoice, click on the "Show all details" checkbox and verify that the
values are the same.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:28:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 11:28:54 +0000
Subject: [Koha-bugs] [Bug 7673] New patron permissions
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:37:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 11:37:31 +0000
Subject: [Koha-bugs] [Bug 3050] Add an option to upload scanned invoices.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050
--- Comment #7 from Jacek Ablewicz ---
(In reply to Jonathan Druart from comment #5)
> Review of attachment 25306 [details] [review]:
> -----------------------------------------------------------------
>
> FAIL acqui/invoice-files.pl
> FAIL forbidden patterns
> forbidden pattern: trailing space char (line 130)
I was unable to locate that trailing space[s] in line 130, but this part of the
code was rewrited anyway, so this issue should now be fixed.
> You should check the syspref value in the templates using
> Koha.Preference('AcqEnableFiles')
Btw, this nice little TT plugin doesn't seem to utf8-encode it's output, unless
I'm very much mistaken.. Not really a problem with 0|1 kind of a syspref,
though.
> > + while (<$uploaded_file>) {
> > + $file_content .= $_;
> > + }
>
> I think
> my $file_content = <$uploaded_file>;
> does the same thing.
>
Doesn't work for files with "\n" 's in them. Replaced it with:
my $file_content = do { local $/; <$uploaded_file>; };
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:56:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 11:56:51 +0000
Subject: [Koha-bugs] [Bug 12021] New: SIP2 checkin should alert on transfer
and use CT for return branch
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021
Bug ID: 12021
Summary: SIP2 checkin should alert on transfer and use CT for
return branch
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs at lists.koha-community.org
Reporter: benjamin.rokseth at kul.oslo.kommune.no
QA Contact: testopia at bugs.koha-community.org
CC: colin.campbell at ptfs-europe.com
According to SIP2 specs for checkin:
AO is where the transaction took place,
AQ is the "permanent location", and
CT is the "destination location" (i.e., pickup lib for a hold or target lib
for a transfer).
A SIP2 checkin should respect circulation rules and alert (CV04 - send to other
branch) with destination location in CT.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 14:13:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 12:13:46 +0000
Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and
use CT for return branch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021
--- Comment #1 from Benjamin Rokseth ---
Created attachment 26725
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26725&action=edit
Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch
This small patch corrects the SIP2 checkin response if branch transfer is
needed.
It depends on bug 7981 and also removes an obsolete alert check in SIP2.
Test plan:
- apply bug 7981
- make sure syspref AutomaticItemReturn is false
- check 'Return policy' in 'Default checkout, hold and return policy'
- make a SIP2 checkout and checkin from a branch different than item's home
branch.
- verify that SIP2 response gives alert CV04 (=send to different branch)
- also verify that response field CT gives correct branch according to 'Return
policy'
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 14:14:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 12:14:57 +0000
Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and
use CT for return branch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Depends on| |7981
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 14:14:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 12:14:57 +0000
Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't
properly respect HomeOrHoldingBranchReturn syspref
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12021
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 14:34:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 12:34:40 +0000
Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and
use CT for return branch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021
Petter Goks?yr ?sen changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |boutrosboutrosboutros at gmail
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 15:49:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 13:49:34 +0000
Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292
--- Comment #4 from Marjorie Barry-Vila ---
(In reply to jdemuth at roseville.ca.us from comment #3)
> I wrote a script and put in the the intranetusersjs field that removes the
> noEnterSubmit function from specific fields. This is now allowing us to scan
> barcodes without it try to save automatically because of the carriage return
> set in the scanners.
>
> //Remove noEnterSubmit from fields - JD
> $(document).ready(function(){
> $("#userid").removeClass("noEnterSubmit");
> $("#cardnumber").removeClass("noEnterSubmit");
> $("#subfield952p637072").removeClass("noEnterSubmit");
> });
Thank you for the script but it is not working for me.
In wich version of koha you tested it?
Regards,
Marjorie
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 15:57:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 13:57:06 +0000
Subject: [Koha-bugs] [Bug 11786] Improve RDFa schema.org mappings in prog
and bootstrap
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11786
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |gmcharlt at gmail.com
--- Comment #4 from Galen Charlton ---
Pushed to master. Thanks, Dan!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 16:02:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 14:02:25 +0000
Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&"
character was wrongly replaced with "& "
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |ASSIGNED
Assignee|christophe.croullebois at bibl |jonathan.druart at biblibre.co
|ibre.com |m
--- Comment #20 from Jonathan Druart ---
I am going to rewrite this script according coding guidelines.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 16:39:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 14:39:23 +0000
Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133
Koha Team AMU changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |koha.aixmarseille at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 17:00:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 15:00:59 +0000
Subject: [Koha-bugs] [Bug 7673] New patron permissions
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673
Koha Team AMU changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #41 from Koha Team AMU ---
- The pref SubfieldsToAllowForLimitedEdition should not affect Fast
cataloguing framework (FA) : ok the framework FA is exclued
- The delete_all_items is ok
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 17:16:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 15:16:24 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |paola.rossi at cineca.it
--- Comment #18 from Paola Rossi ---
I test against master 3.15.00.26
The second patch doesn't apply:
Applying: Bug 11944: replace use of utf8 with Encode
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging Koha/Database.pm
CONFLICT (content): Merge conflict in Koha/Database.pm
Failed to merge in the changes.
This is ./Koha/Database.pm:
60 my $schema = Koha::Schema->connect(
61 "DBI:$db_driver:dbname=$db_name;host=$db_host;port=$db_port",
62 <<<<<<< HEAD
63 $db_user, $db_passwd, $db_opts );
64 =======
65 $db_user, $db_passwd );
66
67 >>>>>>> Bug 11944: replace use of utf8 with Encode
68 return $schema;
69 }
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 20:56:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 18:56:52 +0000
Subject: [Koha-bugs] [Bug 11763] Consolidate fund action links into menu
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Signed Off
--- Comment #7 from Katrin Fischer ---
Hm, I was hoping the developers would, but you might be right that it could get
lost there. For me I was looking at this bug for the fifth time or so,
realizing that I couldn't really test it yet. Someone, please signoff 11578?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 22:06:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 20:06:06 +0000
Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 22:23:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 20:23:17 +0000
Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292
--- Comment #5 from jdemuth at roseville.ca.us ---
Sorry, I forgot to include we just upgraded to 3.14.4. I did notice that it is
not "saving" the page which it great, but it is losing focus. I think I know
how to fix that and I will test tonight and If it works I will include the
updated script.
Jen
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 22:27:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 20:27:06 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
--- Comment #4 from Marjorie Barry-Vila ---
(In reply to Katrin Fischer from comment #3)
> Maybe try removing your superlibrairan flag for a test? And keep all other
> permissions? I think that could be the difference, that a superlibriarian
> can always see the funds now.
I tested several flags but nothing change on acquisition home.
Have you tested it?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 22:32:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 20:32:19 +0000
Subject: [Koha-bugs] [Bug 11340] make the 'print summary' a custom
slip/notice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340
jdemuth at roseville.ca.us changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jdemuth at roseville.ca.us
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:34:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:34:34 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
--- Comment #40 from Brendan Gallagher ---
Created attachment 26726
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26726&action=edit
Bug 7413: Unit test
This patch makes the new parameter norenewalbefore known to
unit test Circulation_Issuingrule.t.
To test:
1) Before applying the patch:
prove t/db_dependent/Circulation_Issuingrule.t
2) Notice that the test fails with:
$got->{norenewalbefore} = undef
$expected->{norenewalbefore} = Does not exist
3) Apply the patch.
4) Run test again and it should pass.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Martin Renvoize
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:35:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:35:13 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
Brendan Gallagher changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26726|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:50:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:50:35 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
--- Comment #41 from Brendan Gallagher ---
Created attachment 26727
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26727&action=edit
Bug 7413: Unit test
This patch makes the new parameter norenewalbefore known to
unit test Circulation_Issuingrule.t.
To test:
1) Before applying the patch:
prove t/db_dependent/Circulation_Issuingrule.t
2) Notice that the test fails with:
$got->{norenewalbefore} = undef
$expected->{norenewalbefore} = Does not exist
3) Apply the patch.
4) Run test again and it should pass.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Martin Renvoize
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:52:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:52:47 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
Brendan Gallagher changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26727|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:56:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:56:30 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
--- Comment #42 from Brendan Gallagher ---
Created attachment 26728
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26728&action=edit
Bug 7413: Add issuingrules.norenewalbefore to database
Currently multiple renewals can be done in immediate succsession.
To optionally prevent this, a new parameter "No renewal before"
is introduced.
This patch adds issuingrules.norenewalbefore to the database.
Default value is NULL.
To test:
1) Run installer/data/mysql/updatedatabase.pl
2) Create a SQL report like:
SELECT * FROM issuingrules
3) Confirm that norenewalbefore was added after renewalperiod.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Martin Renvoize
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:56:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:56:43 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
--- Comment #43 from Brendan Gallagher ---
Created attachment 26729
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26729&action=edit
Bug 7413: Add "No renewal before" to the circulation and fine rules
This patch adds a column "No renewal before" to the circulation and
fine rules table.
To test:
1) Add or edit some issuing rules.
2) Confirm that an empty entry, zero and non-numerical values for
"No renewal before" are saved as undefined.
3) Confirm that numerical values can be entered and saved.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Martin Renvoize
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:56:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:56:52 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
--- Comment #44 from Brendan Gallagher ---
Created attachment 26730
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26730&action=edit
Bug 7413: Code and intranet template changes
This patch modifies CanBookBeRenewed, so that based on
issuingrules.norenewalbefore a new error "too_soon" can be returned.
Also adds a new subroutine GetSoonestRenewDate.
To test:
1) Create an issuing rule with "No renewal before" set to value X
and "Unit" set to days.
2) Test the following steps for both:
Home > Patron > Patron details
Home > Circulation > Checkouts
3) On the checkout page, test for today's issues as well as previous
issues. (Check something out on one day and something else on the
next day, then do the testing.)
4) Confirm that items can't be renewed if current date is more than
X days before due date.
5) Confirm that the date and time of the soonest possible renewal are
displayed in the format specified by global sysprefs "dateformat"
and "TimeFormat".
6) Confirm that items can be renewed if "No renewal before" is
undefined or current date is X or less days before due date.
7) Confirm that if the number of allowed renewals is exceeded
"Not renewable" is displayed, no matter what "No renewal before"
is set to.
8) Test the same things with "Unit" set to hours.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Martin Renvoize
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:57:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:57:03 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
--- Comment #45 from Brendan Gallagher ---
Created attachment 26731
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26731&action=edit
Bug 7413: OPAC bootstrap theme changes
This patch makes opac-user.pl and the bootstrap version of opac-user.tt
handle the new renewal error "too_soon".
To test:
1) Set global syspref "opacthemes" to bootstrap.
2) Set global syspref "OpacRenewalAllowed" to Allow.
3) Test the same things as in previous patch, this time for the OPAC
summary page.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Martin Renvoize
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:57:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:57:13 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
--- Comment #46 from Brendan Gallagher ---
Created attachment 26732
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26732&action=edit
Bug 7413: OPAC prog theme changes
This patch makes the prog version of opac-user.tt handle the new
renewal error "too_soon".
To test:
1) Set global syspref "opacthemes" to prog.
2) Test the same things as in previous patch.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Martin Renvoize
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:57:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:57:23 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
--- Comment #47 from Brendan Gallagher ---
Created attachment 26733
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26733&action=edit
Bug 7413: Unit test
This patch makes the new parameter norenewalbefore known to
unit test Circulation_Issuingrule.t.
To test:
1) Before applying the patch:
prove t/db_dependent/Circulation_Issuingrule.t
2) Notice that the test fails with:
$got->{norenewalbefore} = undef
$expected->{norenewalbefore} = Does not exist
3) Apply the patch.
4) Run test again and it should pass.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
Signed-off-by: Martin Renvoize
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:57:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:57:49 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
Brendan Gallagher changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:58:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:58:37 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
Brendan Gallagher changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25856|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:58:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:58:25 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
Brendan Gallagher changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25855|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:58:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:58:55 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
Brendan Gallagher changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25857|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:59:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:59:11 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
Brendan Gallagher changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25858|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:59:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:59:22 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
Brendan Gallagher changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25859|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:59:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 21:59:35 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413
Brendan Gallagher changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25860|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 00:00:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 22:00:38 +0000
Subject: [Koha-bugs] [Bug 12022] New: Independent branches does not isolate
pending and approved comments by branch.
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022
Bug ID: 12022
Summary: Independent branches does not isolate pending and
approved comments by branch.
Change sponsored?: ---
Product: Koha
Version: 3.14
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: gmcharlt at gmail.com
Reporter: bartonski at gmail.com
QA Contact: testopia at bugs.koha-community.org
Given Branches A and B
Branch A patron logs on to OPAC and leaves a comment for a title.
Branch B staff is then able to see these comments in Home > Tools > Comments >
Approved comments, in both the "Approved Comments" and "Comments awaiting
moderation" tabs.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 00:00:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 22:00:52 +0000
Subject: [Koha-bugs] [Bug 11340] make the 'print summary' a custom
slip/notice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=11869
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 00:00:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 22:00:52 +0000
Subject: [Koha-bugs] [Bug 11869] Add more informations to the member
printing pages.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=11340
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 00:01:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 22:01:28 +0000
Subject: [Koha-bugs] [Bug 11340] make the 'print summary' a custom
slip/notice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340
--- Comment #1 from M. Tompsett ---
If this was implemented bug 11869 would not be necessary.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 01:18:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Apr 2014 23:18:32 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
--- Comment #31 from Srdjan Jankovic ---
(In reply to M. Tompsett from comment #30)
> Comment on attachment 26718 [details] [review]
> bug_11213: Use branch codes from the database rather than hardcoded CPL and
> MPL
>
> Review of attachment 26718 [details] [review]:
> -----------------------------------------------------------------
>
> ::: t/db_dependent/Items.t
> @@ +29,5 @@
> > }
> >
> > my $dbh = C4::Context->dbh;
> > +my $branches = GetBranches;
> > +my ($branch1, $branch2) = keys %$branches;
>
> I like the idea, but you are missing a check to make sure they are defined.
> And if they aren't, you need to temporarily add them and then roll them back.
That's true, however it is not worse then it used to be. Former test depended
on having CPL and MPL branches, this one depends on having *any* two branches,
thus is more permissive. I'm happy to drop the patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 04:38:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 02:38:14 +0000
Subject: [Koha-bugs] [Bug 12002] Koha does not pick up installed languages
when running under Plack
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12002
--- Comment #2 from Robin Sheat ---
I can't reproduce this at all using master. If I koha-translate --install or
--remove, it updates immediately. This is using plack and memcached. In
C4::Languages, getTranslatedLanguages is memoised, but I can't see it actually
getting stored in memcache, oddly enough.
I think that's not the issue, given you restarted memcache. Did you also
restart starman, and what was the result of that? How many workers are you
running? Are you running plack on the staff client or just the opac?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 05:32:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 03:32:11 +0000
Subject: [Koha-bugs] [Bug 9941] with Plack,
Web installer should not die with stacktrace when database does not
exist
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9941
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |robin at catalyst.net.nz
Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 05:57:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 03:57:05 +0000
Subject: [Koha-bugs] [Bug 12023] New: Web installer fails under plack
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023
Bug ID: 12023
Summary: Web installer fails under plack
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: gmcharlt at gmail.com
Reporter: robin at catalyst.net.nz
QA Contact: testopia at bugs.koha-community.org
Could not compile /mnt/catalyst/koha/installer/install.pl: Can't locate
InstallAuth.pm in @INC (you may need to install the InstallAuth module) (@INC
contains: /mnt/catalyst/koha /etc/perl /usr/local/lib/perl/5.18.2
/usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18
/usr/share/perl/5.18 /usr/local/lib/site_perl .) at
/mnt/catalyst/koha/installer/install.pl line 7.
BEGIN failed--compilation aborted at /mnt/catalyst/koha/installer/install.pl
line 7.
at /usr/share/perl5/CGI/Compile.pm line 108
This is because InstallAuth.pm is in the installer directory, not C4 where
everything else is expected to be.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 05:57:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 03:57:12 +0000
Subject: [Koha-bugs] [Bug 12023] Web installer fails under plack
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:22:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:22:33 +0000
Subject: [Koha-bugs] [Bug 12023] Web installer fails under plack
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023
--- Comment #1 from Robin Sheat ---
Created attachment 26734
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26734&action=edit
Bug 12023 - move InstallAuth.pm to be in C4
InstallAuth was in the installer directory, which meant that plack was
unable to find it, and so running the webinstaller would fail. This
moves it into C4,
Test plan:
* Make sure the web installer runs under plack
* Make sure the web installer runs under non-plack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:22:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:22:48 +0000
Subject: [Koha-bugs] [Bug 12023] Web installer fails under plack
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:25:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:25:39 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
--- Comment #5 from Bernardo Gonzalez Kriegel ---
(In reply to Katrin Fischer from comment #4)
> Hi Bernardo, my impression was that the translations where used to build the
> langauage sarch pull down on advanced search, but I am not sure if that
> changed at some point.
Hi Katrin, you are right. But I reworked it to do that, and other things :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:26:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:26:17 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
--- Comment #6 from Bernardo Gonzalez Kriegel ---
Created attachment 26735
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26735&action=edit
Bug 12017 - Move language description out of database
This patch moves language descriptions from database into template files, in
part to ease the translation of some strings, but mostly to have one place to
define languages.
All languages/scripts/regions are defined at languages.inc template file, with
native versi?n and translatable version.
As a bonus, language descriptions are present at webinstaller stage.
To test:
1) Do some fake translations, for example all langs
for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do
mkdir koha-tmpl/intranet-tmpl/prog/$l;
mkdir koha-tmpl/opac-tmpl/bootstrap/$l;
mkdir koha-tmpl/opac-tmpl/prog/$l;
mkdir koha-tmpl/opac-tmpl/ccsr/$l;
done
2) Go to Administration > System preferences > I18N/L10N
There are many missing descriptions
3) Enable some random languages, some in groups (fr|en) on staff/opac. Enable
OPAC changelanguage
4) Reload page, look at the bottom for language changer. Also open a OPAC view,
look for language changer.
Do NOT change languages
5) Apply the patch
6) Reload STAFF page, verify all descriptions in native language.
7) CHANGE in Language changer (staff/opac).
Currently we show Lang+Code, and in lang groups Lang+Script+Region+Code
I think it's too long, I propose to show only Lang, and in groups Region+Code,
all native.
Change OPAC theme (prog|ccsr) and check again. On prog and ccsr the result is
not pretty, but works
8) Go to Administration > System preferences > Local use
Add a new local syspref, any Explanation|Variable|Value, type Languages, Save.
Check that all languages look good. Also Edit that syspref, on edition a list
of languages must show in value box, check that they look good
NOTE: There is a Bug in this kind of preference, selected languages are passed
but ignored at save/load time. Only staff selected languages are shown. A
problem for another report
9) NEW - Installer languages. This patch enable view of languages on Web
installer.
Edit your koha-conf.xml, change database name to a new name, create that
database and grant access, reload staff page, log in, you will be redirected to
step1 of installer, check names and codes for installed languages.
(revert to your old database before proceed)
10) Advanced Search. On staff/opac{bootstrap/prog/ccsr}, go to advanced search,
clic more options, go to limit by language, select one and press search, verify
the search term "Search with limit(s): 'ln,rtrn:XXX'" with XXX the iso639-2
code of your selected lang
NOTE: This is the ONLY place where translated language names are used!!!
11) Translations. Update language files for one of the active languages, say
de-DE
(cd misc/translator; perl translate update de-DE;
perl translate update de-DE; perl translate install de-DE)
12) Change language to German (DE), go to advanced search 'Suche' (staff), clic
'mehr Optionen', look for 'Sprache' pulldown, verify some translations (ej.
Greek -> Griechisch) [this translations are not present on opac]
I think that all previous functionality is present.
Lines starting
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:38:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:38:39 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
--- Comment #5 from Katrin Fischer ---
Hi Marjorie, I did test now - and I think you are right. Something about the
visibility is broken. I removed the permission to manage all funds, I am not a
superlibrarian, the fund access is restricted to another branch and I can still
see it :( I am quite sure this used to work differently and it quite a problem.
The view is also the same on the acquisition start page and the fund list for
the budget.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:39:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:39:53 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26735|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:39:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:39:59 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|3.12 |master
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:41:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:41:01 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
--- Comment #7 from Bernardo Gonzalez Kriegel ---
Sorry, resubmit to fix koha-qa errors
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:43:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:43:58 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
--- Comment #8 from Bernardo Gonzalez Kriegel ---
Created attachment 26736
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26736&action=edit
Bug 12017 - Move language description out of database
This patch moves language descriptions from database into template files, in
part to ease the translation of some strings, but mostly to have one place to
define languages.
All languages/scripts/regions are defined at languages.inc template file, with
native versi?n and translatable version.
As a bonus, language descriptions are present at webinstaller stage.
To test:
1) Do some fake translations, for example all langs
for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do
mkdir koha-tmpl/intranet-tmpl/prog/$l;
mkdir koha-tmpl/opac-tmpl/bootstrap/$l;
mkdir koha-tmpl/opac-tmpl/prog/$l;
mkdir koha-tmpl/opac-tmpl/ccsr/$l;
done
2) Go to Administration > System preferences > I18N/L10N
There are many missing descriptions
3) Enable some random languages, some in groups (fr|en) on staff/opac. Enable
OPAC changelanguage
4) Reload page, look at the bottom for language changer. Also open a OPAC view,
look for language changer.
Do NOT change languages
5) Apply the patch
6) Reload STAFF page, verify all descriptions in native language.
7) CHANGE in Language changer (staff/opac).
Currently we show Lang+Code, and in lang groups Lang+Script+Region+Code
I think it's too long, I propose to show only Lang, and in groups Region+Code,
all native.
Change OPAC theme (prog|ccsr) and check again. On prog and ccsr the result is
not pretty, but works
8) Go to Administration > System preferences > Local use
Add a new local syspref, any Explanation|Variable|Value, type Languages, Save.
Check that all languages look good. Also Edit that syspref, on edition a list
of languages must show in value box, check that they look good
NOTE: There is a Bug in this kind of preference, selected languages are passed
but ignored at save/load time. Only staff selected languages are shown. A
problem for another report
9) NEW - Installer languages. This patch enable view of languages on Web
installer.
Edit your koha-conf.xml, change database name to a new name, create that
database and grant access, reload staff page, log in, you will be redirected to
step1 of installer, check names and codes for installed languages.
(revert to your old database before proceed)
10) Advanced Search. On staff/opac{bootstrap/prog/ccsr}, go to advanced search,
clic more options, go to limit by language, select one and press search, verify
the search term "Search with limit(s): 'ln,rtrn:XXX'" with XXX the iso639-2
code of your selected lang
NOTE: This is the ONLY place where translated language names are used!!!
11) Translations. Update language files for one of the active languages, say
de-DE
(cd misc/translator; perl translate update de-DE;
perl translate update de-DE; perl translate install de-DE)
12) Change language to German (DE), go to advanced search 'Suche' (staff), clic
'mehr Optionen', look for 'Sprache' pulldown, verify some translations (ej.
Greek -> Griechisch) [this translations are not present on opac]
I think that all previous functionality is present.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:44:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:44:15 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:46:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:46:39 +0000
Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973
--- Comment #11 from Bernardo Gonzalez Kriegel ---
Katrin, I did a new version. Now all is native, and advanced search shows
translations. All in templates.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:50:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 04:50:06 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
--- Comment #6 from Katrin Fischer ---
Hm, I tried a git bisect, because I wondered when it changed and the change
seems to have been introduced by:
203757e353cbbb2add934523fdbd7113c6180207 is the first bad commit
commit 203757e353cbbb2add934523fdbd7113c6180207
Author: Julian Maurice
Date: Fri May 18 09:12:43 2012 +0200
Bug 7304: More permissions for budgets
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:24:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 05:24:51 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
paxed changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pasi.kallinen at pttk.fi
--- Comment #9 from paxed ---
[%# "WARNING: This file must be replicated on 'include' dir" %]
[%# "for each staff/opac theme" %]
It's the exact same information in each file. To reduce the chance of these
files getting out of sync, wouldn't it be better to have a single file? And,
IMO, these language names have no need to be translatable, either.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:35:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 05:35:37 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
--- Comment #10 from Katrin Fischer ---
If we aim for keeping the same functionality, the translations are needed - we
use them on the advanced search language pull down. I think there is currently
no way to use the same file for OPAC and staff as the template directories are
separate.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:43:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 05:43:12 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
--- Comment #7 from Katrin Fischer ---
Note: IndependentBranches also doesn't make any difference.
I have upgraded the severity, as this is quite a problem for bigger libraries
that don't want other branches to see their funds.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:44:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 05:44:31 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
--- Comment #11 from paxed ---
(In reply to Katrin Fischer from comment #10)
> If we aim for keeping the same functionality, the translations are needed -
> we use them on the advanced search language pull down. I think there is
> currently no way to use the same file for OPAC and staff as the template
> directories are separate.
Yes, but if I understand correctly, after this patch, these would be picked up
into the po-files. Why would these need to be translatable in there?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:46:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 05:46:04 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
--- Comment #12 from Katrin Fischer ---
Hm, I am not sure I understand the problem. Currently we keep the native name
of the language and the (quite incomplete) translations in the sql files. This
just moves it to the standard procedure, enabling every translator to have the
translations without adding to the SQL file?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:59:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 05:59:43 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
--- Comment #13 from paxed ---
(In reply to Katrin Fischer from comment #12)
> Hm, I am not sure I understand the problem. Currently we keep the native
> name of the language and the (quite incomplete) translations in the sql
> files. This just moves it to the standard procedure, enabling every
> translator to have the translations without adding to the SQL file?
Nevermind, you're right about that.
Still, having the same code in triplicate (once for each theme), is a bit
fragile.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:25:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:25:51 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26364|0 |1
is obsolete| |
--- Comment #19 from Jonathan Druart ---
Created attachment 26737
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26737&action=edit
Bug 11944: Remove all utf8 filter from templates
This patch
- removes all html_entity usages in tt file which hide utf8 bugs
- removes all encode utf8 in tt plugins because we should get correctly
marked data from DBIC and other sources directly (cf plugin EncodeUTF8
used in renew.tt)
- adds some cleanup in C4::Templates::output: we now use perl utf8 file
handler output so we don't need to decode tt variables manually.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:25:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:25:58 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26365|0 |1
is obsolete| |
--- Comment #20 from Jonathan Druart ---
Created attachment 26738
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26738&action=edit
Bug 11944: replace use of utf8 with Encode
See the wiki page for the explanation.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:26:02 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26366|0 |1
is obsolete| |
--- Comment #21 from Jonathan Druart ---
Created attachment 26739
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26739&action=edit
Bug 11944: Encoding UTF8 in C4::Templates
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:26:08 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26367|0 |1
is obsolete| |
--- Comment #22 from Jonathan Druart ---
Created attachment 26740
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26740&action=edit
Bug 11944: Set ImplicitUnicode for YAML
Before this patch, string for yaml files used in preferences.pl were
broken.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:26:13 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26368|0 |1
is obsolete| |
--- Comment #23 from Jonathan Druart ---
Created attachment 26741
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26741&action=edit
Bug 11944: use CGI( -utf8 ) everywhere
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:26:18 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26369|0 |1
is obsolete| |
--- Comment #24 from Jonathan Druart ---
Created attachment 26742
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26742&action=edit
Bug 11944: Library name variable should be decoded
Test on preferences.pl and on some others pages when mysql is used to
store session.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:26:47 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26742|0 |1
is obsolete| |
--- Comment #25 from Jonathan Druart ---
Created attachment 26743
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26743&action=edit
Bug 11944: Library name variable should be decoded
Test on preferences.pl and on some others pages when mysql is used to
store session.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:26:51 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26370|0 |1
is obsolete| |
--- Comment #26 from Jonathan Druart ---
Created attachment 26744
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26744&action=edit
Bug 11944: replace uri_escape with uri_escape_utf8 everywhere
To reproduce, edit, index notice with ?? and search "??"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:26:56 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26371|0 |1
is obsolete| |
--- Comment #27 from Jonathan Druart ---
Created attachment 26745
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26745&action=edit
Bug 11944: Never use decode/encode in TT Plugins
The EncodeUTF8 TT plugin is useless, we should NEVER use encode in
templates.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:27:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:27:00 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26372|0 |1
is obsolete| |
--- Comment #28 from Jonathan Druart ---
Created attachment 26746
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26746&action=edit
Bug 11944: Remove obsolete encoding routines
We don't need to decode manually which provide nice performance boost.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:27:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:27:04 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26407|0 |1
is obsolete| |
--- Comment #29 from Jonathan Druart ---
Created attachment 26747
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26747&action=edit
Bug 11944: TT Plugins should not encode strings
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:27:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:27:09 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26409|0 |1
is obsolete| |
--- Comment #30 from Jonathan Druart ---
Created attachment 26748
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26748&action=edit
Bug 11944: Fix encoding issue on searching - latin characters
The search is still broken for non-latin characters.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:27:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 07:27:34 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:01:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 08:01:41 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26176|0 |1
is obsolete| |
--- Comment #28 from Martin Renvoize ---
Created attachment 26749
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26749&action=edit
[SIGNED OFF] MT8122: Adds Shibboleth authentication
- Use the shibbolethAuthentication syspref to enable Shibboleth authentication
- Configure the shibbolethLoginAttribute to specify which shibboleth user
attribute matches the koha login
- Make sure the OPACBaseURL is correctly set
MT8122, Follow-up: Adds Shibboleth authentication
- Fix logout bug: shibboleth logout now occurs only when
the session is a shibboleth one.
- Do some refactoring: getting shibboleth username is now
done in C4::Auth_with_Shibboleth.pm (get_login_shib function)
MT8122, Follow-up: Adds Shibboleth authentication
- Adds redirect to opac after logout
MT8122, Follow-up: Adds Shibboleth authentication
- Shibboleth is not compatible with basic http authentication
in C4/Auth.pm. This patch fixes that.
MT8122, Follow-up: Adds Shibboleth authentication
- Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with
multiple vhosts.
MT8122, Follow-up: Adds Shibboleth authentication
- Adds missing protocol for $ENV{'SERVER_NAME'}
Signed-off-by: Martin Renvoize
http://bugs.koha-community.org/show_bug.cgi?id=8446
Signed-off-by: Jesse Weaver
(ByWater employee.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:01:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 08:01:56 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26177|0 |1
is obsolete| |
--- Comment #29 from Martin Renvoize ---
Created attachment 26750
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26750&action=edit
[SIGNED OFF] BUG8446, Follow up: Adds Shibboleth authentication
- Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont
work if koha is behind a reverse proxy.
- To use multiple vhosts, set OpacBaseURL per vhost explicitly with
'SetEnv OpacBaseURL Value' as per Bug 10325
BUG8446, Follow up: Adds Shibboleth authentication
- Ensure user is returned to requested page after authentication
- Added querystring to the target path in shibboleth URL so
that when a user is authenticated he/she is returned to the
correct page they requested before authentication.
Example where this is important: When a user clicks a direct
biblio link of the form - /opac-detail.pl?biblionumber=12345
BUG8446, Follow up: Remove unused imports from scripts
- Remove import of deprecated C4::Utils module from shibboleth
authentication module: Auth_with_shibboleth.pm
Signed-off-by: Jesse Weaver
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:02:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 08:02:15 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26187|0 |1
is obsolete| |
--- Comment #30 from Martin Renvoize ---
Created attachment 26751
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26751&action=edit
[SIGNED OFF] BUG8446, Follow up: Remove unnecessary sysprefs, move to config
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:03:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 08:03:35 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
--- Comment #31 from Martin Renvoize ---
Created attachment 26752
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26752&action=edit
BUG8446, Follow up: Improve local login fallback
- Local fallback was not very well implimented, this patch adds
better handling for such cases allowing clearer failure messages
- This patch also adds the ability to use single sign on via the
top bar menu in the bootstrap theme.
BUG8446, Follow up: Adds perldoc documentation
- Add some documentation to the Auth_with_Shibboleth module
including some guidance as to configuration.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:04:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 08:04:02 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:06:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 08:06:58 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
--- Comment #32 from Martin Renvoize ---
Some follow-up work to allow better error handling when a shibboleth session
exists but does not match a koha user, and allow for shibboleth login from the
front page in bootstrap should you not already be logged in.
I've also added the beginnings of a perldoc to the Auth_with_shibboleth.pm
module to guide configuration.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 11:44:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 09:44:38 +0000
Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23698|0 |1
is obsolete| |
--- Comment #15 from Benjamin Rokseth ---
Created attachment 26753
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26753&action=edit
Bug 8769 - Allow SIP2 return backdating
Currently Koha's SIP server ignores the return date part of an 09 ( aka
CHECKIN ) message. Koha should backdate a return, and remove
fines accordingly.
Signed-off-by: Benjamin Rokseth
Works as notified, second date field in SIP checkin (return date) is
used as return date. Return shows up in history with correct date.
Comments:
- patron is fined if return date is before issue date, but that
is largely irrelevant anyway.
- dependent bug 10694 is marked as Failed QA but seems to have passed?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 11:45:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 09:45:18 +0000
Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Signed Off
CC| |benjamin.rokseth at kul.oslo.k
| |ommune.no
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 12:25:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 10:25:18 +0000
Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&"
character was wrongly replaced with "& "
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 12:25:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 10:25:21 +0000
Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&"
character was wrongly replaced with "& "
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #16720|0 |1
is obsolete| |
--- Comment #21 from Jonathan Druart ---
Created attachment 26754
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26754&action=edit
Bug 8218 : Add a maintenance script to sanitize biblio records
This patch adds:
- a new maintenance script batch_sanitize_records
- a new subroutine C4::Charset::SanitizeRecord
- new unit tests for the new subroutine
Test plan:
1/ prove t/db_dependent/Charset.t
2/ Create a record containing "&" (could be follow with as many
'amp;' as you want) in one of its fields and the same for the field
linked to biblioitems.url.
The url should not be sanitized, it cans contain "&".
3/ Launch the maintenance script with the -h paramters to see how to use
it.
4/ Launch the script using the different parameters:
--filename=FILENAME
--biblionumbers='XXX'
--auto-search
The auto-search permits to sanitize all records containing "&" in
the marcxml field.
Use the verbose flag for testing.
Without the --confirm flag, nothing is done.
5/ Use the --confirm flag and verify in the biblioitems.marcxml field
that the record has been sanitized.
6/ Try the --reindex flag to reindex records which have been modified.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 12:29:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 10:29:46 +0000
Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&"
character was wrongly replaced with "& "
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26754|0 |1
is obsolete| |
--- Comment #22 from Jonathan Druart ---
Created attachment 26755
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26755&action=edit
Bug 8218 : Add a maintenance script to sanitize biblio records
This patch adds:
- a new maintenance script batch_sanitize_records
- a new subroutine C4::Charset::SanitizeRecord
- new unit tests for the new subroutine
Test plan:
1/ prove t/db_dependent/Charset.t
2/ Create a record containing "&" (could be follow with as many
'amp;' as you want) in one of its fields and the same for the field
linked to biblioitems.url.
The url should not be sanitized, it cans contain "&".
3/ Launch the maintenance script with the -h paramters to see how to use
it.
4/ Launch the script using the different parameters:
--filename=FILENAME
--biblionumbers='XXX'
--auto-search
The auto-search permits to sanitize all records containing "&" in
the marcxml field.
Use the verbose flag for testing.
Without the --confirm flag, nothing is done.
5/ Use the --confirm flag and verify in the biblioitems.marcxml field
that the record has been sanitized.
6/ Try the --reindex flag to reindex records which have been modified.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 12:46:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 10:46:23 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 12:46:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 10:46:49 +0000
Subject: [Koha-bugs] [Bug 12023] Web installer fails under plack
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:09:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 11:09:41 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #8 from Jonathan Druart ---
Marjorie,
Try to define an owner for the fund. If no owner is defined, it seems there is
no restriction.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:11:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 11:11:38 +0000
Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently
under Plack
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005
--- Comment #2 from Jacek Ablewicz ---
I did some Q&D measurements trying to estimate what kind of performance penalty
we can expect when ditching Zconn caching entirely. While cached Zconn
connections are generally not used all that often by Koha, there are some
notable exceptions, like (e.g.) authority searches (for each authority record
on the result list Koha does one extra search to find out how many biblio
records are attached to the specific authority).
Creating & immediately destroying Zebra connection - without doing any search
with it - is surprisingly lightweight (ca 46 ?s per connection). But it goes up
to 2.6 - 3.0 ms if the connection was used to perform some actual search. So
for a typical case (20 authority search results per request) an extra latency
when not caching would be 60 milliseconds or so. Not too bad, considering that:
(testing
"/cgi-bin/koha/opac-authorities-home.pl?startfrom=0&marclist=any&and_or=and&excluding=&operator=contains&value=&resultsperpage=20&type=opac&op=do_search&authtypecode=PERSO_NAME&orderby=HeadingAsc"
page loading time):
- mod_perl (semi-persistent; persistent would be ~50 ms faster) with zebra
connection caching enabled: 290 ms
- mod_perl with zebra connection caching disabled: 350 ms
- regular CGI with zebra connection caching enabled: 890 ms
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:32:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 11:32:22 +0000
Subject: [Koha-bugs] [Bug 12024] New: Add to list opens the list adding UI
in two windows
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024
Bug ID: 12024
Summary: Add to list opens the list adding UI in two windows
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at pttk.fi
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
Created attachment 26756
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26756&action=edit
Fix Add To List in item details
In Item details, when using the menu toolbar for Add To > List, the list adding
UI opens in a popup window, and also in the original window. The original
window should stay showing the item details page.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:33:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 11:33:00 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:33:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 11:33:04 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
--- Comment #9 from Jonathan Druart ---
Created attachment 26757
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26757&action=edit
Bug 12019: FIX budget_owner_id node is duplicated
The input witht the budget_owner_id id is duplicated.
It breaks the jQuery selector
$('#budget_owner_id').val('');
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:33:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 11:33:10 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
--- Comment #10 from Jonathan Druart ---
Created attachment 26758
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26758&action=edit
Bug 12019: If a fund has a restriction, a owner is mandatory
The C4::Budgets::CanUserUseBudget assumes that budget_owner_id is
set if a restriction (budget_permission) exists.
see
&& $budget->{budget_owner_id}
&& $budget->{budget_owner_id} != $borrower->{borrowernumber}
Test plan:
Edit a fund and try to save it with a limitation and no owner. It should
not be possible.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:38:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 11:38:27 +0000
Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two
windows
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:19:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:19:11 +0000
Subject: [Koha-bugs] [Bug 12025] New: Inventory tool fails with "Could not
reads headers", or sometimes a timeout
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12025
Bug ID: 12025
Summary: Inventory tool fails with "Could not reads headers",
or sometimes a timeout
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: Tools
Assignee: gmcharlt at gmail.com
Reporter: jason at esilibrary.com
QA Contact: testopia at bugs.koha-community.org
Created attachment 26759
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26759&action=edit
sample file
This happens with small test files of one or two barcodes.
jason-temp at lumen:~$ od BARCODES.TXT
0000000 030063 033065 030463 030060 030060 030060 033062 031412
0000020 032460 031466 030061 030060 030060 031460 000064
0000035
jason-temp at lumen:~$ cat BARCODES.TXT
30563100000026
30563100000034jason-temp at lumen:~$
On the server side, it looks inventory.pl spins out of control, and is looping
on commands like this:
write(5, "s\0\0\0\3select authorised_value fro"..., 119) = 119
read(5, "\1\0\0\1\1h\0\0\2\3def\4salt\27marc_subfield"..., 16384) = 144
poll([{fd=5, events=POLLIN|POLLPRI}], 1, 0) = 0 (Timeout)
write(5, "Y\0\0\0\3select authorised_value, li"..., 93) = 93
read(5, "\1\0\0\1\3\\\0\0\2\3def\4salt\21authorised_va"..., 16384) = 337
poll([{fd=5, events=POLLIN|POLLPRI}], 1, 0) = 0 (Timeout)
write(5, "\1\0\0\0\16", 5) = 5
read(5, "\7\0\0\1\0\0\0\2\0\0\0", 16384) = 11
poll([{fd=5, events=POLLIN|POLLPRI}], 1, 0) = 0 (Timeout)
write(5, "\1\0\0\0\16", 5) = 5
read(5, "\7\0\0\1\0\0\0\2\0\0\0", 16384) = 11
poll([{fd=5, events=POLLIN|POLLPRI}], 1, 0) = 0 (Timeout)
This is with Koha 3.14.03.000, but Chris Cormack confirmed that it happens with
master, 3.14.1, and 3.14.5, but that it works fine on 3.12.12. He tracked it
down to this commit for this bug:
0313856d9a1a9c0c002da0aead8c8516b51e1c11
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684
There is an email thread discussing this on the Koha list:
http://lists.katipo.co.nz/public/koha/2014-March/039092.html
http://lists.katipo.co.nz/public/koha/2014-April/thread.html#39127
With the Chrome development tools, I also see the following errors when I first
load the interface:
Uncaught SyntaxError: Unexpected token ILLEGAL inventory.pl:62
event.returnValue is deprecated. Please use the standard event.preventDefault()
instead. jquery.js:3
Let me know if there's anything else I can do to help. Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:38:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:38:45 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26752|0 |1
is obsolete| |
--- Comment #33 from Martin Renvoize ---
Created attachment 26760
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26760&action=edit
BUG8446, Follow up: Improve local login fallback
- Local fallback was not very well implimented, this patch adds
better handling for such cases allowing clearer failure messages
- This patch also adds the ability to use single sign on via the
top bar menu in the bootstrap theme.
BUG8446, Follow up: Adds perldoc documentation
- Add some documentation to the Auth_with_Shibboleth module
including some guidance as to configuration.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:41:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:41:15 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
--- Comment #34 from Martin Renvoize ---
I have a work in progress branch for all things shib related available at:
https://github.com/PTFS-Europe/koha/tree/bug_8466-shibboleth
I intend so add some new bugs in the coming days to enhance upon this base.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:44:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:44:02 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
--- Comment #35 from Martin Renvoize ---
Created attachment 26761
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26761&action=edit
BUG8446, Follow up: Correct filenames to match guidlines
- Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match
other files present on the system.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:44:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:44:10 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
--- Comment #36 from Martin Renvoize ---
Created attachment 26762
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26762&action=edit
BUG8446, Follow up: Correct paths after file rename
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:47:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:47:45 +0000
Subject: [Koha-bugs] [Bug 12026] New: Shibboleth auto-provisioning
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026
Bug ID: 12026
Summary: Shibboleth auto-provisioning
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Authentication
Assignee: gmcharlt at gmail.com
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
CC: dpavlin at rot13.org, francart at gmail.com,
frederic at tamil.fr, katrin.fischer at bsz-bw.de,
martin.renvoize at ptfs-europe.com,
matthias.meusburger at biblibre.com,
pgsengstock at wisc.edu, tomascohen at gmail.com,
z.tajoli at cineca.it
Depends on: 8446
Shibboleth authentication has the ability to send an arbitrary number of
attributes to koha; These attributes can be used to dynamically create and
update user records in koha. Our shibboleth patches should support this.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:47:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:47:45 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12026
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:49:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:49:25 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12027
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:49:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:49:25 +0000
Subject: [Koha-bugs] [Bug 12027] New: Shibboleth authentication for staff
client
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027
Bug ID: 12027
Summary: Shibboleth authentication for staff client
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Authentication
Assignee: gmcharlt at gmail.com
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
CC: dpavlin at rot13.org, francart at gmail.com,
frederic at tamil.fr, katrin.fischer at bsz-bw.de,
martin.renvoize at ptfs-europe.com,
matthias.meusburger at biblibre.com,
pgsengstock at wisc.edu, tomascohen at gmail.com,
z.tajoli at cineca.it
Depends on: 8446, 12026
The current shibboleth implementation only support authentication into the
opac. We should also enable shibboleth for the staff client.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:49:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:49:25 +0000
Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12027
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:54:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:54:06 +0000
Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12025
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:54:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 12:54:06 +0000
Subject: [Koha-bugs] [Bug 12025] Inventory tool fails with "Could not reads
headers", or sometimes a timeout
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12025
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
Depends on| |7684
--- Comment #1 from Jonathan Druart ---
Hello Jason,
I don't reproduce the issue against master (and even on the 3.14.x branch).
On the inventory tools page (tools/inventory.pl), I filled the "Barcode file"
with a barcodes file, I clicked on submit and I did not get any error.
Could you try to reproduce on a sandbox please?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 15:41:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 13:41:40 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
module could order by email
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |h.meissner.82 at web.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 15:50:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 13:50:04 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
--- Comment #11 from Marjorie Barry-Vila ---
(In reply to Jonathan Druart from comment #8)
> Marjorie,
> Try to define an owner for the fund. If no owner is defined, it seems there
> is no restriction.
Jonathan,
I defined an owner for the fund but for me it is the same on acquisition home
page, i can see funds of the other branches and of the other owners.
I should see only the budgets that I am an owner, right?
We need to change something in the drop down menu restrictions?
Thanks!
Marjorie
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 15:55:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 13:55:36 +0000
Subject: [Koha-bugs] [Bug 11979] items status not for loan on course reserve
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979
--- Comment #1 from Marjorie Barry-Vila ---
Created attachment 26763
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26763&action=edit
not for loan reserve
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 15:56:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 13:56:02 +0000
Subject: [Koha-bugs] [Bug 11979] items status not for loan on course reserve
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979
--- Comment #2 from Marjorie Barry-Vila ---
Created attachment 26764
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26764&action=edit
not for loan reserve
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:30:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 14:30:09 +0000
Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two
windows
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024
paxed changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at pttk.fi
|ity.org |
Severity|enhancement |minor
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:40:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 14:40:27 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
module could order by email
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
URL|bib.math.uni-bonn.de |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:47:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 14:47:04 +0000
Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:47:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 14:47:07 +0000
Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018
--- Comment #1 from Owen Leonard ---
Created attachment 26765
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26765&action=edit
Bug 12018 - add table sorting to patron card batches
When viewing batches of patrons in the patron card creator module the
table is not sortable. This patch adds table sorting.
The patch also makes some corrections of invalid markup and moves
informational/error messages to the top of the page rather than in a
sidebar. This change lets the table and sorting controls expand into a
wider space.
This patch also corrects a translation issue with table headers
identical to that addressed by Bug 11505.
To test, go to Tools -> Patron card creator -> Manage batches.
View an existing batch or create a new batch and populate it with
patrons. Table sorting controls should work correctly. Batch management
operations should work correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:49:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 14:49:35 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
the detailed views.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
--- Comment #21 from Olli-Antti Kivilahti ---
Created attachment 26766
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26766&action=edit
Bug 11175 - Rebased to parse XML result from SimpleSearch instead of the
ISO2709-version which it used to be.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:55:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 14:55:15 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
the detailed views.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
Olli-Antti Kivilahti changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26404|0 |1
is obsolete| |
--- Comment #22 from Olli-Antti Kivilahti ---
Created attachment 26767
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26767&action=edit
Bug 11175 - Show the parent record's component parts in the detailed views.
Presentation for bootstrap-theme.
This displays the injected component part records in the bootstrap theme.
--------------------------------------
TEST PLAN
--------------------------------------
PREREQUISITES:
-AddChildRecordsToDetailedViews system preference needs to be activated.
-opacthemes system preference needs to be 'bootstrap'.
-Catalog a bunch of child records for a host record.
--Search a record and go to detailed view.
--Use the existing functionality "+ New" -> "New Child Record" to catalog child
records.
------------------------
TEST CASE1 - OPAC
------------------------
-Reindex Zebra
-Search for the record you just made childs for and display it in the
opac-detail.pl -view.
-Verify that a list of child records are displayed on the right side of the
browser window.
------------------------
Thank you!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:07:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 15:07:33 +0000
Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744
--- Comment #17 from Marjorie Barry-Vila ---
(In reply to Katrin Fischer from comment #15)
> Hi Jonathan,
>
> I have tested this again and it works as described. But I am a bit worried
> still - before the patch you could undo a receipt any time, being aware that
> the items would not be deleted. Now you can undo and the items will be
> deleted, which is nice. But if there is a hold on the record, you can't undo
> until you cancel he hold.
>
> This could be a problem for a very popular book with multiple holds and
> multiple copies outside of the order. Then you'd have to cancel all of them,
> to reenter them again after undoing the receipt.
>
> Could showing an alert: 'There is at least 1 hold on this record, please
> delete items manually' be an option?
>
> Or a check on remaining items? If no items remain you shouldn't be able to
> undo the receipt without fixing it. If there is an item and it's not an item
> level hold on your ordered item, you could.
>
> I am not feeling very sure about this, maybe we could get the bug reporter's
> (Marjorie?) and some others opinion on this?
Hi Katrin,
I tested it with new patch of Jonathan and for me it works.
Test plan:
-create one item available
-order one item on the same record
-receive item ordered
-do a reservation on item available
-you can undo the receipt
It is normal for me to delete a hold of a item which is not realy received. But
if a hold is on a item already received in a other basket, you do not have to
delete the hold.
I am sorry, my english is bad. Do you understand the same thing that me?
Marjorie
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:27:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 15:27:43 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #31 from Paola Rossi ---
I apply against 3.15.00.026.
In "Authorized values" of Administration module, I add a "New category", whose
name is (newcat-mu):
newcat-?
1) ERROR:
Soon after I save it, 3 greek chars are shown badly here:
"New authorized values for newcat-??:"
"Authorized values for category newcat-??:"
"There are no authorized values defined for newcat-??"
The current URL is bad too:
http://192.168.40.128:8080/cgi-bin/koha/admin/authorised_values.pl?searchfield=newcat-??&offset=0
2) OK:
The new category has been added to the list "Show category". Its name is shown
OK.
Now I select the new category "newcat-?" inside this list, and I select "Show
category".
Koha answers with a page where all the 5 occurrences of newcat-? are shown OK.
So I pass to Failed QA status.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:30:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 15:30:10 +0000
Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show
funds of all branches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019
--- Comment #12 from Jonathan Druart ---
(In reply to Marjorie Barry-Vila from comment #11)
> I defined an owner for the fund but for me it is the same on acquisition
> home page, i can see funds of the other branches and of the other owners.
> I should see only the budgets that I am an owner, right?
> We need to change something in the drop down menu restrictions?
Could you confirm the issue still appears with these patches?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:38:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 15:38:39 +0000
Subject: [Koha-bugs] [Bug 12028] New: add cardnumber on update patron
records page
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12028
Bug ID: 12028
Summary: add cardnumber on update patron records page
Change sponsored?: ---
Product: Koha
Version: 3.12
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs at lists.koha-community.org
Reporter: marjorie.barry-vila at ccsr.qc.ca
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Created attachment 26768
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26768&action=edit
patron update
Hi,
It would be fine to have patron cardnumber on member-update.pl. This will avoid
confusion of homonymous.
Marjorie
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:45:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 15:45:47 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
--- Comment #32 from Jonathan Druart ---
(In reply to Paola Rossi from comment #31)
> In "Authorized values" of Administration module, I add a "New category",
> whose name is (newcat-mu):
> newcat-?
>
> 1) ERROR:
> Soon after I save it, 3 greek chars are shown badly here:
> "New authorized values for newcat-??:"
> "Authorized values for category newcat-??:"
> "There are no authorized values defined for newcat-??"
Hum, weird, I did not reproduce on my local instance. Same on sandbox 17:
http://pro.test17.biblibre.com/cgi-bin/koha/admin/authorised_values.pl
Templates fr-FR and it-IT generated.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:56:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 15:56:03 +0000
Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:56:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 15:56:08 +0000
Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026
--- Comment #1 from Martin Renvoize ---
Created attachment 26769
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26769&action=edit
BUG12026: Adds auto-provisioning to shibboleth
- Adds the option to map shibboleth attributes to koha user columns
and allows mapping to auto create non-existant users
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:57:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 15:57:56 +0000
Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026
--- Comment #2 from Martin Renvoize ---
Shamelessly grabbed the patches from Jesse's branch.. available here:
https://github.com/pianohacker/koha/commits/shibboleth-v3.12.10
Re-based against master bug 8446, but kept original authorship as Jesse
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 18:11:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 16:11:38 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
--- Comment #33 from Paola Rossi ---
Dear Mr. Jonathan,
two images are available at:
1)http://koha.wdfiles.com/local--files/immaginibugs/newcat-mu.png
2)http://koha.wdfiles.com/local--files/immaginibugs/newcat2-mu.png
The first image shows the error, while the second one shows correct chars.
The second one shows the already added category.
The first one shows the moment soon after the adding.
Your test at comment 32 references to the second moment, where no error is
shown.
When I cancel the category too, I see wrong chars.
In the Sandbox 17, I recreated the error, see link:
3) http://www.koha.it/local--files/immaginibugs/newcat3-mu.png
I use Firefox v.28.0 on Windows 7 environment.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 19:57:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 17:57:00 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
--- Comment #14 from Bernardo Gonzalez Kriegel ---
(In reply to paxed from comment #13)
> Still, having the same code in triplicate (once for each theme), is a bit
> fragile.
It's fragile, a lot.
I add a patch to show how this could be solved.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 19:57:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 17:57:54 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
--- Comment #15 from Bernardo Gonzalez Kriegel ---
Created attachment 26770
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26770&action=edit
Bug 12017 - Followup to set one location for languages.inc
This patch implements things that needs their own reports.
Just consider it a proof of concept. Don't sign
It:
1) Adds a new function to Koha.tt plugin to get any value
of config variable
(needs own report)
2) Create a include dir on opachtdocs to be used as a
general include dir for all interefaces and themes
I opted for opachtdocs in the thinking that it's has
more public access than intrahtdocs
(needs own report)
3) Adds "USE Koha" in doc-head-close.inc on every interface/theme
to use Koha template plugin. It's used in almost all
opac files, and many staff. So make it universal
I suppose there is a better way
(needs own report)
4) Copy languages.inc to new created general include dir
and rewrite all relevant files to find and use this only file
looking for it by PATH. Removed all other languages.inc files.
Main idea is remove the need to n-plicate template files of general use.
If you want to test:
1) Apply the patch
2) Check that all works as first patch test plan, EXCEPT for
translations because strings to translate are looked only on
theme dir. But if Bug 7939 pass, an arbitrary dir can be
searched and its strings added to some OPAC po file to
be translated. Another solution is to use as general include
dir en/bootstrap's
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 20:32:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 18:32:45 +0000
Subject: [Koha-bugs] [Bug 12029] New: Patrons should be able to delete their
patron messages
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Bug ID: 12029
Summary: Patrons should be able to delete their patron messages
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: cbrannon at cdalibrary.org
QA Contact: testopia at bugs.koha-community.org
It would be great if patrons could delete private messages displayed to them in
the OPAC. Right now, if staff use this feature, patrons have to remind staff
to remove the message.
Christopher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 20:36:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 18:36:34 +0000
Subject: [Koha-bugs] [Bug 12030] New: Common messages
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12030
Bug ID: 12030
Summary: Common messages
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: cbrannon at cdalibrary.org
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
How about adding an editable list of common messages to the message feature in
the patron checkout screen or in the custom restrictions? Of course, the
message should be editable itself once it is selected and put in the text box.
Christopher
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 22:11:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 20:11:06 +0000
Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 22:11:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 20:11:09 +0000
Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018
Nicole C. Engard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26765|0 |1
is obsolete| |
--- Comment #2 from Nicole C. Engard ---
Created attachment 26771
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26771&action=edit
[SIGNED-OFF] Bug 12018 - add table sorting to patron card batches
When viewing batches of patrons in the patron card creator module the
table is not sortable. This patch adds table sorting.
The patch also makes some corrections of invalid markup and moves
informational/error messages to the top of the page rather than in a
sidebar. This change lets the table and sorting controls expand into a
wider space.
This patch also corrects a translation issue with table headers
identical to that addressed by Bug 11505.
To test, go to Tools -> Patron card creator -> Manage batches.
View an existing batch or create a new batch and populate it with
patrons. Table sorting controls should work correctly. Batch management
operations should work correctly.
Signed-off-by: Nicole C. Engard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 22:18:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 20:18:20 +0000
Subject: [Koha-bugs] [Bug 2894] Routing list holds are broken
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894
Marjorie Barry-Vila changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marjorie.barry-vila at ccsr.qc
| |.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 23:29:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 21:29:48 +0000
Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same
information for each language
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bgkriegel at gmail.com
Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 23:37:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 21:37:45 +0000
Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same
information for each language
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593
--- Comment #1 from Bernardo Gonzalez Kriegel ---
Created attachment 26772
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26772&action=edit
Bug 11593 - subtag_registry.sql files contain the same information for each
language
This patch removes subtag_registry.sql from lang dirs,
and put it on a new mandatory dir
In that way we need to update only one file.
All similar files are removed.
To test:
1) Try a new install, or simply create a new database,
grant permissions on it, change koha-conf.xml to use
this database and go to staff page
2) Go step by step until all mandatory or optional sql
files are loaded. Check that subtag_registry.sql is
loaded.
3) Do it again but on other language. First install
translation and repeat 2), could use de-DE or fr-FR
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 23:38:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Apr 2014 21:38:57 +0000
Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same
information for each language
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 02:36:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 00:36:12 +0000
Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 02:36:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 00:36:16 +0000
Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885
--- Comment #7 from M. Tompsett ---
Created attachment 26773
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26773&action=edit
Bug 11885 - Follow-up to address issues raised
Jonathan Druart raised the following three issues:
1/ subtags was bold before patch
2/ 1 dash existed between tag and tag name
3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet
nom commun", "101 ## - Langue" becomes "101 # # Langue")
This patch addresses them in the following way:
1/ You will note that @ was not bold on the 0 tab.
Every other tab were bold. By making the similar template
into a procedure based on the 0XX tab, bolding was lost.
This patch bolds all subtags including the @, so that
the visible change is minimized.
2/ The dash was programmatically added in at the code stage
previously. This bug fix splits the the single concatenation
mess into parts which can be styled. This puts the dash back
into the template. However, it should be noted that the
spacing for the 0 tab's tag and tag description will have an
extra space after the hypen that was lacking before.
3/ ...... is different than
...
...
The later puts that extra space. This patch fixes that.
See comment 1 for the test plan.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:14:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 01:14:05 +0000
Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC
user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864
--- Comment #13 from M. Tompsett ---
Created attachment 26774
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26774&action=edit
Bug 6864 - Corrected alphabetical order of sysprefs.sql
Original patch lazily added OpacBelowLoginBox to the end. This puts it in
proper alphabetical order location.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:16:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 01:16:56 +0000
Subject: [Koha-bugs] [Bug 11726] Untranslatable loading page overlay in
offline circ
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11726
--- Comment #1 from Bernardo Gonzalez Kriegel ---
Created attachment 26775
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26775&action=edit
Bug 11726 - Untranslatable loading page overlay in offline circ
This patch reformats a message to be catched by translation script.
To test:
1) Grep for the offending string
egrep -Rn "Loading page |\", please wait" *
only occurrence on koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
2) Apply the patch
3) Update your preferred language, ej. fi-FI
(cd misc/translator; perl translate update fi-FI)
4) Repeat 1), there are 2 new strings on staff po
file, out of context :), but now can be translated
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:17:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 01:17:17 +0000
Subject: [Koha-bugs] [Bug 11726] Untranslatable loading page overlay in
offline circ
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11726
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
CC| |bgkriegel at gmail.com
Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:20:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 01:20:52 +0000
Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC
user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864
--- Comment #14 from M. Tompsett ---
Created attachment 26776
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26776&action=edit
Bug 6864 - Added missing bootstrap template changes.
The original patch only touches the prog template. This updates
the bootstrap theme in a corresponding manner.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:28:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 01:28:55 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |robin at catalyst.net.nz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:55:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 01:55:55 +0000
Subject: [Koha-bugs] [Bug 12031] New: Task Scheduler not sending mail
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
Bug ID: 12031
Summary: Task Scheduler not sending mail
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Task Scheduler
Assignee: gmcharlt at gmail.com
Reporter: liz at catalyst.net.nz
QA Contact: testopia at bugs.koha-community.org
The task scheduler to schedule reports from the UI is not passing the correct
command to runreport.pl, so it doesn't send email correctly.
To replicate:
1. make sure that your user is not in at.deny, and (if applicable/necessary) is
in at.allow
Useful, but not required step: make sure email can be sent from your server,
also helpful is access to the Koha user's mail box (to see the bounce messages)
2. create a saved sql report to run
3. Go to Tools -> Task Scheduler and schedule a job to be run, and results
emailed to you
4. note that you do not get an email, also note that the Koha user has received
a bounce message with the report contents and an error message:
[Thu Apr 3 14:02:00 2014] runreport.pl: ERROR: No saved report
report-recipient at the.email.address.you.specified found at
/usr/share/koha/intranet/cgi-bin/tools/runreport.pl line 193.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:03:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:03:22 +0000
Subject: [Koha-bugs] [Bug 6716] Database Documentation
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716
--- Comment #136 from Liz Rea ---
Created attachment 26777
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26777&action=edit
Bug 6716 - Document Items Table
This patch documents the items table. Some fields were left
undocumented because I was unsure of what data was stored there:
stack - might be linked to shelving number, but need confirmation
paidfor - pretty sure this is unused, but don't want to document it that way
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:03:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:03:41 +0000
Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:03:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:03:45 +0000
Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
--- Comment #1 from Liz Rea ---
Created attachment 26778
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26778&action=edit
Bug 12031 - Task Scheduler not sending mail
At some stage the runreport.pl cronjob was changed to accept longopts, but the
scheduler script wasn't changed along with it. This patch fixes the mismatch.
To test:
1. make sure that your user is not in at.deny, and (if applicable/necessary) is
in at.allow
Useful, but not required step: make sure email can be sent from your server,
also helpful is access to the Koha user's mail box (to see the bounce messages)
2. create a saved sql report to run
3. Go to Tools -> Task Scheduler and schedule a job to be run, and results
emailed to you
4. note that you do not (without the patch) get an email. Make a note of the
command it reports it is going to run.
5. apply the patch
6. schedule another job, you will notice that the command to run the scheduled
job is slightly changed compared to the one in step 4.
7. Receiving an email when your job runs means the patch worked. Seeing
--format= and --to= in the command also means the patch worked, as this is the
command that runreport.pl is expecting.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:07:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:07:18 +0000
Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC
user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26774|0 |1
is obsolete| |
--- Comment #15 from M. Tompsett ---
Created attachment 26779
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26779&action=edit
Bug 6864 - Corrected alphabetical order of sysprefs.sql
Original patch lazily added OpacBelowLoginBox to the end. This
puts it in proper alphabetical order location.
TEST PLAN
---------
1) Apply only the first patch
2) Run the Koha QA Test tool
-- FAILED on the system preferences SQL file.
3) Apply only the second patch (this one)
4) Run the Koha QA Test tool
-- Everything OK now.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:09:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:09:46 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
--- Comment #3 from Robin Sheat ---
Attempting to reproduce:
* Plack setup with 10 workers for the staff client.
* Go to add an item to a biblio (to populate caches.)
* Added a new value in LOC, "TOASTER"
* Selected New -> Item again on the biblio.
* "Toaster" showed up in shelving location.
* Went to "Items" tab, selected an item to edit.
* "Toaster" did _not_ appear in the shelving location.
* After some other unidentifiable messing around, it did appear.
Definitely seems to be a bug.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:24:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:24:03 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
--- Comment #4 from Robin Sheat ---
Ah, I did manage to see the issue when adding a new item too. It may depend
what worker you end up hitting.
This is good, as otherwise it made no sense at all.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:25:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:25:33 +0000
Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC
user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26465|0 |1
is obsolete| |
--- Comment #16 from M. Tompsett ---
Created attachment 26780
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26780&action=edit
[SIGNED OFF] Add OpacBelowLoginBox preference to add custom text below the
login box.
This patch file adds the ability to customize the text below
the login area which appears when 'Log in to your account'
in clicked in the top right of the OPAC.
TEST PLAN
----------
0) Back up your data if you care about it.
1) Open a staff client in your browser.
2) Make sure the OPAC system preference opacthemes is set
to 'prog'.
3) Make sure the OPAC system preference opacuserlogin is
set to 'Allow'.
NOTE: Required to make the 'Log in to your account' in the top
left of OPAC appear.
4) Make sure the OPAC system preference PatronSelfRegistration
is set to 'Allow'.
5) Make sure the OPAC system preference
PatronSelfRegistrationDefaultCategory is set to a value
of patron category that exists (eg. PT is a sample one)
NOTE: These are required to make the 'Register here' links
appear after the text.
6) Open the OPAC in another tab.
7) Click the 'Log in to your account' link.
8) Note the text below the login area.
9) Apply the patch and run an update.
(git bz apply 6864 -- interactive just this one)
(./installer/data/mysql/updatedatabase.pl)
10) Refresh the OPAC page.
-- the text should be identical.
11) In the staff client, modify the OPAC system preference
OpacBelowLoginText to have some text, and save.
12) Refresh the OPAC page.
-- the text should reflect what was entered in the
OpacBelowLoginText system preference.
13) Open your mysql.
14) Drop and recreate the koha database.
15) Do a web install by going to the staff client URL.
16) Log in as the system user.
17) Confirm the OPAC system preference OpacBelowLoginBox
exists.
18) Modify its value (blank, non-blank) and confirm that
the OPAC page reflects the default message or custom
message as expected each reload.
19) Run the Koha QA Test Tool
-- This will FAIL on the system preferences SQL file.
The next patch by me, Mark Tompsett, will fix it.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:25:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:25:50 +0000
Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC
user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26779|0 |1
is obsolete| |
--- Comment #17 from M. Tompsett ---
Created attachment 26781
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26781&action=edit
Bug 6864 - Corrected alphabetical order of sysprefs.sql
Original patch lazily added OpacBelowLoginBox to the end. This
puts it in proper alphabetical order location.
TEST PLAN
---------
1) Apply only the first patch
2) Run the Koha QA Test tool
-- FAILED on the system preferences SQL file.
3) Apply only the second patch (this one)
4) Run the Koha QA Test tool
-- Everything OK now.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:25:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:25:59 +0000
Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC
user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26776|0 |1
is obsolete| |
--- Comment #18 from M. Tompsett ---
Created attachment 26782
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26782&action=edit
Bug 6864 - Added missing bootstrap template changes.
The original patch only touches the prog template. This updates
the bootstrap theme in a corresponding manner.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:46:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:46:11 +0000
Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC
user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26782|0 |1
is obsolete| |
--- Comment #19 from M. Tompsett ---
Created attachment 26783
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26783&action=edit
Bug 6864 - Bootstrap OpacBelowLoginBox
This adds OpacBelowLoginBox to bootstrap.
It also corrects the placement of setting the opacbelowloginbox
template parameter, so that it will work under bootstrap.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:49:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 02:49:09 +0000
Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC
user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26783|0 |1
is obsolete| |
--- Comment #20 from M. Tompsett ---
Created attachment 26784
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26784&action=edit
Bug 6864 - Bootstrap OpacBelowLoginBox
This adds OpacBelowLoginBox to bootstrap.
It also corrects the placement of setting the opacbelowloginbox
template parameter, so that it will work under bootstrap.
TEST PLAN
---------
Run steps similar to the first patch except with opacthemese
set to 'bootstrap'.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 05:12:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 03:12:10 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz
--- Comment #5 from Robin Sheat ---
Ah yes, there is a local cache for GetMarcStructure. It is also supposed to be
memoised, but I don't see any result of that in memcache, which is strange to
me.
I think the way to fix this is to:
* add a convenient ClearFrameworkCache function and call that from places like
the framework editor, the authorised values editor, and so on,
* remove the memoisation of the function (which I've found tends to be slower
than the local cache anyway, when it works), and
* add a cache timeout (5 minutes?) so that it won't screw up long-term if we
fail to clear the cache somewhere, but still long enough that it'll likely come
out of the woodwork as a bug. This'll also let us tide things over when under
load.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 05:20:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 03:20:19 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
--- Comment #6 from Robin Sheat ---
Actually, I may have spoken too soon there. It doesn't seem to actually be
storing authorised values in there. So while that caching should be fixed, this
particular instance might be coming from somewhere else.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 05:24:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 03:24:20 +0000
Subject: [Koha-bugs] [Bug 12032] New: TinyMCE rewrites urls in a very
annoying and unexpected way
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032
Bug ID: 12032
Summary: TinyMCE rewrites urls in a very annoying and
unexpected way
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Tools
Assignee: gmcharlt at gmail.com
Reporter: liz at catalyst.net.nz
QA Contact: testopia at bugs.koha-community.org
When making a news item on the Tools -> News page, trying to link to anything
inside Koha gets rewritten as a relative path. Sometimes we may not want that,
it's probably better to make it so that we have to be explicit about what url
we want in there, rather than having TinyMCE try to help.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 05:28:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 03:28:44 +0000
Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying
and unexpected way
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 05:28:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 03:28:48 +0000
Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying
and unexpected way
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032
--- Comment #1 from Liz Rea ---
Created attachment 26785
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26785&action=edit
Bug 12032 - TinyMCE rewrites urls in a very annoying and unexpected way
To test:
* create a news item with a link in it that is within the same domain
example: my koha was at http://demo.mykoha.co.nz, I created a link in a news
item to http://demo-intra.mykoha.co.nz
* note that when the item is saved, the url changes to ../../../../ (or
something like)
* apply the patch
* edit the link again, and save it
* note that the link is saved correctly
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:31:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 04:31:08 +0000
Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |mtompset at hotmail.com
--- Comment #2 from M. Tompsett ---
A default kohagit as misc/cronjobs/runreports.pl not tools/runreports.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:31:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 04:31:19 +0000
Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12031
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:31:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 04:31:19 +0000
Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |1993
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:33:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 04:33:42 +0000
Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885
--- Comment #8 from paxed ---
(In reply to M. Tompsett from comment #7)
> Created attachment 26773 [details] [review]
> Bug 11885 - Follow-up to address issues raised
>
> This patch addresses them in the following way:
> 1/ You will note that @ was not bold on the 0 tab.
> Every other tab were bold. By making the similar template
> into a procedure based on the 0XX tab, bolding was lost.
> This patch bolds all subtags including the @, so that
> the visible change is minimized.
Why hard-coded tags? Isn't there some good reason to separate presentation
and content?
> 2/ The dash was programmatically added in at the code stage
> previously. This bug fix splits the the single concatenation
> mess into parts which can be styled. This puts the dash back
> into the template. However, it should be noted that the
> spacing for the 0 tab's tag and tag description will have an
> extra space after the hypen that was lacking before.
Wrap the dash and the spaces before the description in or something, so it'll be easier to hide with css.
> 3/ ...... is different than
> ...
> ...
> The later puts that extra space. This patch fixes that.
This one is good.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:58:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 04:58:47 +0000
Subject: [Koha-bugs] [Bug 12034] New: MSG_REMOVE_FROM_LIST different wording
between OPAC and staff client
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034
Bug ID: 12034
Summary: MSG_REMOVE_FROM_LIST different wording between OPAC
and staff client
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: I18N/L10N
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at pttk.fi
QA Contact: testopia at bugs.koha-community.org
CC: frederic at tamil.fr
Staff client: "Are you sure you want to remove these records from the shelf?"
OPAC: "Are you sure you want to remove these items from the list?"
Should probably pick one wording, and use that in both staff client and OPAC.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:59:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 04:59:46 +0000
Subject: [Koha-bugs] [Bug 12035] New: Purchase Order Overflows Incorrectly
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12035
Bug ID: 12035
Summary: Purchase Order Overflows Incorrectly
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs at lists.koha-community.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
Currently, if you add a large number of baskets while using a "OrderPdfFormat"
of "pdfformat::layout3pages" or "pdfformat::layout3pagesfr", the basket table
will overlap over the bottom footer (which includes the page numbers), and the
overflow will start mid-way down the new page.
This is because we've configured our PDF::Table objects incorrectly for the
printbaskets() sub.
Of course, the chances of having enough baskets in a basket group to trigger
such an overflow might be quite small, so this might not happen very often.
Still, it's a bug nonetheless. You can test it out by filling your database
with bogus baskets; I've included some SQL at the bottom of this bug report to
aid with that.
Layout Config:
layout3pages.pm,layout3pagesfr.pm:
Current config for printbaskets:
start_y => 230/mm,
next_y => 230/mm,
start_h => 230/mm,
next_h => 230/mm,
Note that the "next_y" and "next_h" are the same as the "start_*". This means
that they'll start midway down the page on the new (overflow) page.
My suggested replacement for printbaskets:
start_y => 230/mm, #($start_y - $start_h = $bottom_margin), according to
PDF::Table source code
next_y => ($height - 5)/mm,
start_h => 210/mm,
next_h => ($height - 25)/mm,
I'm using the $height variable here because that's the same measurement used by
some page headers in the printorders() sub in this same module.
--
The printorders() subs are all right in all the "OrderPdfFormat" options. The
bottom margin is probably too large in layout3pages(fr).pm, but better too
large than too small.
layout2pages.pm:
printorders:
start_y => 285/mm,
next_y => 285/mm,
start_h => 260/mm,
next_h => 260/mm,
layout3pages.pm,layout3pagesfr.pm:
printorders:
start_y => 270/mm,
next_y => 285/mm,
start_h => 250/mm,
next_h => 250/mm,
---
[Note: the following SQL was created based on a Koha 3.8 database so YMMV.]
*Create bogus baskets:
INSERT INTO aqbasket Select null,rand() as
basketname,note,booksellernote,contractnumber,creationdate,closedate,booksellerid,authorisedby,booksellerinvoicenumber,basketgroupid
from kohatest38.aqbasket where basketno = 8;
*Create bogus orders:
INSERT INTO aqorders Select null, 1,
entrydate,quantity,currency,listprice,totalamount,datereceived,booksellerinvoicenumber,freight,unitprice,quantityreceived,cancelledby,datecancellationprinted,notes,supplierreference,purchaseordernumber,subscription,serialid,(SELECT
basketno FROM aqbasket WHERE basketno not in (select basketno from aqorders)
limit 1) as
'basketno',biblioitemnumber,timestamp,rrp,ecost,gst,budget_id,budgetgroup_id,budgetdate,sort1,sort2,sort1_authcat,sort2_authcat,uncertainprice,claims_count,claimed_date
from aqorders limit 1;
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 07:04:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 05:04:55 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
--- Comment #7 from Robin Sheat ---
Oh, GetAuthorisedValues is memoised using a method that just sticks it in a
hash. That'll be it.
So, there is the Memoize::Expire package that we can plug in and give
authorised values a low timeout. Probably something like 10 seconds so that
it'll cover that request and not much more. We can also force a clear when we
set something, so that the current process will see the update immediately.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 07:33:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 05:33:09 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
--- Comment #8 from Robin Sheat ---
Created attachment 26786
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26786&action=edit
Bug 9967 - expire cached GetAuthorisedValues
Adds Memoize::Expire to the caching for GetAuthorisedValues so that
updates actually show up in a persistent environment (e.g. Plack)
NOTE: This is an experimental patch only. It doesn't work in my testing
for no reason I can see. It's for review in case someone can see what
silly mistake I made.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 07:40:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Apr 2014 05:40:06 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To: