From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 01:53:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 23:53:40 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 02:25:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 00:25:18 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26696|0 |1 is obsolete| | --- Comment #24 from Srdjan Jankovic --- Created attachment 26713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26713&action=edit bug_11213: C4::VirtualShelves::Page::shelf_contents() * Extracted shelf items processing from shelfpage() into a separate sub shelf_contents() in order to be able to test it * Added tests for shelf_contents() with XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 02:36:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 00:36:44 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #25 from M. Tompsett --- You modified GetItemsInfo. t/db_dependent/Items.t needs to have GetItemsInfo calls. You modified searchResults. t/db_dependent/Search.t needs to have calls to searchResults that will trigger changed code. You modified shelfpage. t/db_dependent/VirtualShelves_Page.t needs to at least have a call to shelfpage added. You moved most of the changes into the shelf_contents and properly added a test for it, but the removal of code in shelfpage still may merit a call to shelfpage too. Your tweaks in C4/XSLT don't expressly need a test, but t/db_dependent/XSLT.t probably should be created with at least a call to XSLTParse4Display. These are the tests I am expecting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 05:18:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 03:18:28 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #4 from Robin Sheat --- Created attachment 26714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26714&action=edit Bug 11998 - sysprefs in memcached The caching mechanism has been abstracted a little bit, and now supports memcached for storing sysprefs. These should be correctly stored and cleared so caching will work between processes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 05:19:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 03:19:15 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 05:21:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 03:21:01 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #5 from Robin Sheat --- These patches will need to be treated as a series, they depend on the previous ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:13:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 04:13:22 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #5 from Aleisha Amohia --- Created attachment 26715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26715&action=edit Adding bug number for signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:14:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 04:14:26 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23146|Add a button to the biblio |Bug 11299: Add a button to description|edition page to |the biblio edition page to |automatically add authority |automatically add authority |links. |links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:15:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 04:15:09 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26715|Adding bug number for |Bug 11299: Adding bug description|signing off |number for signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:15:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 04:15:25 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26715|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:19:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 04:19:19 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #6 from Robin Sheat --- Created attachment 26716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26716&action=edit Bug 11998 - add test case, fix issue found Adds a test case with improved coverage of the caching functionality. Fixes a bug that was uncovered by writing the test case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:22:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 04:22:04 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26716|0 |1 is obsolete| | --- Comment #7 from Robin Sheat --- Created attachment 26717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26717&action=edit Bug 11998 - add test case, fix issue found Adds a test case with improved coverage of the caching functionality. Fixes a bug that was uncovered by writing the test case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 06:42:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 04:42:39 +0000 Subject: [Koha-bugs] [Bug 12020] New: label-edit-batch has hardcoded error messages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 Bug ID: 12020 Summary: label-edit-batch has hardcoded error messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr $ grep errstr labels/label-edit-batch.pl koha-tmpl/intranet-tmpl/prog/en/modules/labels/* labels/label-edit-batch.pl:my $errstr = undef; labels/label-edit-batch.pl: $errstr = "item(s) not removed from batch $batch_id." if $err; labels/label-edit-batch.pl: $errstr = "batch $batch_id was not deleted." if $err; labels/label-edit-batch.pl: $errstr = "item(s) not added to batch $batch_id." if $err; labels/label-edit-batch.pl: $errstr = "items(s) not added, the error was: Branch is not set, you please set your branch before adding items to a batch"; labels/label-edit-batch.pl: $errstr = "batch $batch_id not fully de-duplicated." if $duplicate_count == -1; labels/label-edit-batch.pl: errstr => $errstr, koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt: WARNING: An error was encountered and [% errstr %] Please have your system administrator check the error log for details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 07:46:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 05:46:05 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #119 from Katrin Fischer --- Testing this again, please have a little patience. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 07:48:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 05:48:33 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #26 from Srdjan Jankovic --- Created attachment 26718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26718&action=edit bug_11213: Use branch codes from the database rather than hardcoded CPL and MPL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 07:48:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 05:48:43 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #27 from Srdjan Jankovic --- Created attachment 26719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26719&action=edit bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 08:17:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 06:17:38 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #28 from Srdjan Jankovic --- Created attachment 26720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26720&action=edit bug_11213: Added XSLTParse4Display() to Items test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 08:19:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 06:19:15 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #29 from Srdjan Jankovic --- Created attachment 26721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26721&action=edit bug_11213: Check for $item->{itype} presence to avoid warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 09:29:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 07:29:03 +0000 Subject: [Koha-bugs] [Bug 11763] Consolidate fund action links into menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > The dependent bug still needs a sign off - hoping to get back to this soon. Does someone check the BLOCKED queue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 09:43:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 07:43:29 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > Could showing an alert: 'There is at least 1 hold on this record, please > delete items manually' be an option? Did you see I added a 'title' on the "Can't cancel receipt" span? It displays "Cannot cancel receipt of this order line because at least one reservation exists on the records." on mouse over. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 10:35:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 08:35:21 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #40 from Jonathan Druart --- Created attachment 26722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26722&action=edit Bug 7673: the limitation on editing an item does not affect FA framework The pref SubfieldsToAllowForLimitedEdition should not affect Fast cataloguing framework (FA). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 11:07:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 09:07:14 +0000 Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #2 from Benjamin Rokseth --- Actually, on second look, circ/returns.pl uses C4::Context->preference('HomeOrHoldingBranchReturn'); Others should probably decide, but there cannot be two conflicting return policies, and I believe C4::Circulation should be the preferred setting. C4::GetBranchItemRule returns noreturn|holdingbranch|homebranch and defaults to homebranch if no default circulation rule is set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:15:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 10:15:15 +0000 Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #3 from Benjamin Rokseth --- Created attachment 26723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26723&action=edit Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:17:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 10:17:01 +0000 Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:20:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 10:20:44 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #30 from M. Tompsett --- Comment on attachment 26718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26718 bug_11213: Use branch codes from the database rather than hardcoded CPL and MPL Review of attachment 26718: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11213&attachment=26718) ----------------------------------------------------------------- ::: t/db_dependent/Items.t @@ +29,5 @@ > } > > my $dbh = C4::Context->dbh; > +my $branches = GetBranches; > +my ($branch1, $branch2) = keys %$branches; I like the idea, but you are missing a check to make sure they are defined. And if they aren't, you need to temporarily add them and then roll them back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:31:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 10:31:20 +0000 Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros at gmail | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:40:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 10:40:59 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26691|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:41:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 10:41:15 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26694|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 12:42:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 10:42:10 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:04:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 11:04:41 +0000 Subject: [Koha-bugs] [Bug 3050] Add an option to upload scanned invoices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:04:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 11:04:44 +0000 Subject: [Koha-bugs] [Bug 3050] Add an option to upload scanned invoices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 --- Comment #6 from Jacek Ablewicz --- Created attachment 26724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26724&action=edit Bug 3050: [QA Followup] Fix various QA issues, plus some minor improvements QA followup for: Bug 3050 - Add an option to upload scanned invoices. - Fixed various QA issues. - Added unit tests for the new module. - Improved error handling; extended pod documentation in Koha::Misc::Files - Attached file records were not properly handled when merging invoices; fixed. Test plan add-ons: 1/ prove t/db_dependent/Koha_Misc_Files.t 2/ try to merge some invoices with files attached; after merge, all files previously attached to individual invoices being merged should be attached to resulting invoice (merge destination) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:25:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 11:25:02 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #40 from Jonathan Druart --- (In reply to Katrin Fischer from comment #39) > Ok, this gives me a headache :( Can I get a consolidated test plan? A test plan could be: 0) Add a value in the gist pref (0.1 or 0.25 or something else easy). 1) a) Create a supplier "10613 0 0" with List item price includes tax: No Invoice item price includes tax: No b) Create a supplier "10613 0 1" with List item price includes tax: No Invoice item price includes tax: Yes c) Create a supplier "10613 1 0" with List item price includes tax: Yes Invoice item price includes tax: No d) Create a supplier "10613 1 1" with List item price includes tax: Yes Invoice item price includes tax: Yes 2) Create a basket for each supplier 3) Create 1+ order(s) with 1+ item(s) for each basket with a discount and a gst value. 4) Close the baskets 5) Receive the items 6) Go on acqui/invoice.pl?invoiceid=XX acqui/basket.pl?basketno=YY for each basket/invoice, click on the "Show all details" checkbox and verify that the values are the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:28:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 11:28:54 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:37:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 11:37:31 +0000 Subject: [Koha-bugs] [Bug 3050] Add an option to upload scanned invoices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 --- Comment #7 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #5) > Review of attachment 25306 [details] [review]: > ----------------------------------------------------------------- > > FAIL acqui/invoice-files.pl > FAIL forbidden patterns > forbidden pattern: trailing space char (line 130) I was unable to locate that trailing space[s] in line 130, but this part of the code was rewrited anyway, so this issue should now be fixed. > You should check the syspref value in the templates using > Koha.Preference('AcqEnableFiles') Btw, this nice little TT plugin doesn't seem to utf8-encode it's output, unless I'm very much mistaken.. Not really a problem with 0|1 kind of a syspref, though. > > + while (<$uploaded_file>) { > > + $file_content .= $_; > > + } > > I think > my $file_content = <$uploaded_file>; > does the same thing. > Doesn't work for files with "\n" 's in them. Replaced it with: my $file_content = do { local $/; <$uploaded_file>; }; -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 13:56:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 11:56:51 +0000 Subject: [Koha-bugs] [Bug 12021] New: SIP2 checkin should alert on transfer and use CT for return branch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Bug ID: 12021 Summary: SIP2 checkin should alert on transfer and use CT for return branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: benjamin.rokseth at kul.oslo.kommune.no QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com According to SIP2 specs for checkin: AO is where the transaction took place, AQ is the "permanent location", and CT is the "destination location" (i.e., pickup lib for a hold or target lib for a transfer). A SIP2 checkin should respect circulation rules and alert (CV04 - send to other branch) with destination location in CT. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 14:13:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 12:13:46 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 --- Comment #1 from Benjamin Rokseth --- Created attachment 26725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26725&action=edit Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch This small patch corrects the SIP2 checkin response if branch transfer is needed. It depends on bug 7981 and also removes an obsolete alert check in SIP2. Test plan: - apply bug 7981 - make sure syspref AutomaticItemReturn is false - check 'Return policy' in 'Default checkout, hold and return policy' - make a SIP2 checkout and checkin from a branch different than item's home branch. - verify that SIP2 response gives alert CV04 (=send to different branch) - also verify that response field CT gives correct branch according to 'Return policy' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 14:14:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 12:14:57 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |7981 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 14:14:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 12:14:57 +0000 Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12021 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 14:34:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 12:34:40 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros at gmail | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 15:49:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 13:49:34 +0000 Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #4 from Marjorie Barry-Vila --- (In reply to jdemuth at roseville.ca.us from comment #3) > I wrote a script and put in the the intranetusersjs field that removes the > noEnterSubmit function from specific fields. This is now allowing us to scan > barcodes without it try to save automatically because of the carriage return > set in the scanners. > > //Remove noEnterSubmit from fields - JD > $(document).ready(function(){ > $("#userid").removeClass("noEnterSubmit"); > $("#cardnumber").removeClass("noEnterSubmit"); > $("#subfield952p637072").removeClass("noEnterSubmit"); > }); Thank you for the script but it is not working for me. In wich version of koha you tested it? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 15:57:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 13:57:06 +0000 Subject: [Koha-bugs] [Bug 11786] Improve RDFa schema.org mappings in prog and bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11786 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Dan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 16:02:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 14:02:25 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|christophe.croullebois at bibl |jonathan.druart at biblibre.co |ibre.com |m --- Comment #20 from Jonathan Druart --- I am going to rewrite this script according coding guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 16:39:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 14:39:23 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 17:00:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 15:00:59 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #41 from Koha Team AMU --- - The pref SubfieldsToAllowForLimitedEdition should not affect Fast cataloguing framework (FA) : ok the framework FA is exclued - The delete_all_items is ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 17:16:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 15:16:24 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi at cineca.it --- Comment #18 from Paola Rossi --- I test against master 3.15.00.26 The second patch doesn't apply: Applying: Bug 11944: replace use of utf8 with Encode Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging Koha/Database.pm CONFLICT (content): Merge conflict in Koha/Database.pm Failed to merge in the changes. This is ./Koha/Database.pm: 60 my $schema = Koha::Schema->connect( 61 "DBI:$db_driver:dbname=$db_name;host=$db_host;port=$db_port", 62 <<<<<<< HEAD 63 $db_user, $db_passwd, $db_opts ); 64 ======= 65 $db_user, $db_passwd ); 66 67 >>>>>>> Bug 11944: replace use of utf8 with Encode 68 return $schema; 69 } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 20:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 18:56:52 +0000 Subject: [Koha-bugs] [Bug 11763] Consolidate fund action links into menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #7 from Katrin Fischer --- Hm, I was hoping the developers would, but you might be right that it could get lost there. For me I was looking at this bug for the fifth time or so, realizing that I couldn't really test it yet. Someone, please signoff 11578? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 22:06:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 20:06:06 +0000 Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 22:23:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 20:23:17 +0000 Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #5 from jdemuth at roseville.ca.us --- Sorry, I forgot to include we just upgraded to 3.14.4. I did notice that it is not "saving" the page which it great, but it is losing focus. I think I know how to fix that and I will test tonight and If it works I will include the updated script. Jen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 22:27:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 20:27:06 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #4 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #3) > Maybe try removing your superlibrairan flag for a test? And keep all other > permissions? I think that could be the difference, that a superlibriarian > can always see the funds now. I tested several flags but nothing change on acquisition home. Have you tested it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 22:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 20:32:19 +0000 Subject: [Koha-bugs] [Bug 11340] make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:34:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:34:34 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #40 from Brendan Gallagher --- Created attachment 26726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26726&action=edit Bug 7413: Unit test This patch makes the new parameter norenewalbefore known to unit test Circulation_Issuingrule.t. To test: 1) Before applying the patch: prove t/db_dependent/Circulation_Issuingrule.t 2) Notice that the test fails with: $got->{norenewalbefore} = undef $expected->{norenewalbefore} = Does not exist 3) Apply the patch. 4) Run test again and it should pass. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:35:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:35:13 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26726|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:50:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:50:35 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #41 from Brendan Gallagher --- Created attachment 26727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26727&action=edit Bug 7413: Unit test This patch makes the new parameter norenewalbefore known to unit test Circulation_Issuingrule.t. To test: 1) Before applying the patch: prove t/db_dependent/Circulation_Issuingrule.t 2) Notice that the test fails with: $got->{norenewalbefore} = undef $expected->{norenewalbefore} = Does not exist 3) Apply the patch. 4) Run test again and it should pass. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:52:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:52:47 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26727|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:56:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:56:30 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #42 from Brendan Gallagher --- Created attachment 26728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26728&action=edit Bug 7413: Add issuingrules.norenewalbefore to database Currently multiple renewals can be done in immediate succsession. To optionally prevent this, a new parameter "No renewal before" is introduced. This patch adds issuingrules.norenewalbefore to the database. Default value is NULL. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create a SQL report like: SELECT * FROM issuingrules 3) Confirm that norenewalbefore was added after renewalperiod. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:56:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:56:43 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #43 from Brendan Gallagher --- Created attachment 26729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26729&action=edit Bug 7413: Add "No renewal before" to the circulation and fine rules This patch adds a column "No renewal before" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that an empty entry, zero and non-numerical values for "No renewal before" are saved as undefined. 3) Confirm that numerical values can be entered and saved. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:56:52 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #44 from Brendan Gallagher --- Created attachment 26730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26730&action=edit Bug 7413: Code and intranet template changes This patch modifies CanBookBeRenewed, so that based on issuingrules.norenewalbefore a new error "too_soon" can be returned. Also adds a new subroutine GetSoonestRenewDate. To test: 1) Create an issuing rule with "No renewal before" set to value X and "Unit" set to days. 2) Test the following steps for both: Home > Patron > Patron details Home > Circulation > Checkouts 3) On the checkout page, test for today's issues as well as previous issues. (Check something out on one day and something else on the next day, then do the testing.) 4) Confirm that items can't be renewed if current date is more than X days before due date. 5) Confirm that the date and time of the soonest possible renewal are displayed in the format specified by global sysprefs "dateformat" and "TimeFormat". 6) Confirm that items can be renewed if "No renewal before" is undefined or current date is X or less days before due date. 7) Confirm that if the number of allowed renewals is exceeded "Not renewable" is displayed, no matter what "No renewal before" is set to. 8) Test the same things with "Unit" set to hours. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:57:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:57:03 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #45 from Brendan Gallagher --- Created attachment 26731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26731&action=edit Bug 7413: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal error "too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:57:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:57:13 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #46 from Brendan Gallagher --- Created attachment 26732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26732&action=edit Bug 7413: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal error "too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:57:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:57:23 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #47 from Brendan Gallagher --- Created attachment 26733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26733&action=edit Bug 7413: Unit test This patch makes the new parameter norenewalbefore known to unit test Circulation_Issuingrule.t. To test: 1) Before applying the patch: prove t/db_dependent/Circulation_Issuingrule.t 2) Notice that the test fails with: $got->{norenewalbefore} = undef $expected->{norenewalbefore} = Does not exist 3) Apply the patch. 4) Run test again and it should pass. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:57:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:57:49 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:58:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:58:37 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:58:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:58:25 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25855|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:58:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:58:55 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25857|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:59:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:59:11 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:59:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:59:22 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25859|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 1 23:59:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 21:59:35 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25860|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 00:00:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 22:00:38 +0000 Subject: [Koha-bugs] [Bug 12022] New: Independent branches does not isolate pending and approved comments by branch. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022 Bug ID: 12022 Summary: Independent branches does not isolate pending and approved comments by branch. Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: bartonski at gmail.com QA Contact: testopia at bugs.koha-community.org Given Branches A and B Branch A patron logs on to OPAC and leaves a comment for a title. Branch B staff is then able to see these comments in Home > Tools > Comments > Approved comments, in both the "Approved Comments" and "Comments awaiting moderation" tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 00:00:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 22:00:52 +0000 Subject: [Koha-bugs] [Bug 11340] make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11869 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 00:00:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 22:00:52 +0000 Subject: [Koha-bugs] [Bug 11869] Add more informations to the member printing pages. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11340 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 00:01:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 22:01:28 +0000 Subject: [Koha-bugs] [Bug 11340] make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 --- Comment #1 from M. Tompsett --- If this was implemented bug 11869 would not be necessary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 01:18:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Apr 2014 23:18:32 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #31 from Srdjan Jankovic --- (In reply to M. Tompsett from comment #30) > Comment on attachment 26718 [details] [review] > bug_11213: Use branch codes from the database rather than hardcoded CPL and > MPL > > Review of attachment 26718 [details] [review]: > ----------------------------------------------------------------- > > ::: t/db_dependent/Items.t > @@ +29,5 @@ > > } > > > > my $dbh = C4::Context->dbh; > > +my $branches = GetBranches; > > +my ($branch1, $branch2) = keys %$branches; > > I like the idea, but you are missing a check to make sure they are defined. > And if they aren't, you need to temporarily add them and then roll them back. That's true, however it is not worse then it used to be. Former test depended on having CPL and MPL branches, this one depends on having *any* two branches, thus is more permissive. I'm happy to drop the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 04:38:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 02:38:14 +0000 Subject: [Koha-bugs] [Bug 12002] Koha does not pick up installed languages when running under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12002 --- Comment #2 from Robin Sheat --- I can't reproduce this at all using master. If I koha-translate --install or --remove, it updates immediately. This is using plack and memcached. In C4::Languages, getTranslatedLanguages is memoised, but I can't see it actually getting stored in memcache, oddly enough. I think that's not the issue, given you restarted memcache. Did you also restart starman, and what was the result of that? How many workers are you running? Are you running plack on the staff client or just the opac? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 05:32:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 03:32:11 +0000 Subject: [Koha-bugs] [Bug 9941] with Plack, Web installer should not die with stacktrace when database does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9941 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 05:57:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 03:57:05 +0000 Subject: [Koha-bugs] [Bug 12023] New: Web installer fails under plack Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023 Bug ID: 12023 Summary: Web installer fails under plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Could not compile /mnt/catalyst/koha/installer/install.pl: Can't locate InstallAuth.pm in @INC (you may need to install the InstallAuth module) (@INC contains: /mnt/catalyst/koha /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at /mnt/catalyst/koha/installer/install.pl line 7. BEGIN failed--compilation aborted at /mnt/catalyst/koha/installer/install.pl line 7. at /usr/share/perl5/CGI/Compile.pm line 108 This is because InstallAuth.pm is in the installer directory, not C4 where everything else is expected to be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 05:57:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 03:57:12 +0000 Subject: [Koha-bugs] [Bug 12023] Web installer fails under plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:22:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:22:33 +0000 Subject: [Koha-bugs] [Bug 12023] Web installer fails under plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023 --- Comment #1 from Robin Sheat --- Created attachment 26734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26734&action=edit Bug 12023 - move InstallAuth.pm to be in C4 InstallAuth was in the installer directory, which meant that plack was unable to find it, and so running the webinstaller would fail. This moves it into C4, Test plan: * Make sure the web installer runs under plack * Make sure the web installer runs under non-plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:22:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:22:48 +0000 Subject: [Koha-bugs] [Bug 12023] Web installer fails under plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:25:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:25:39 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #4) > Hi Bernardo, my impression was that the translations where used to build the > langauage sarch pull down on advanced search, but I am not sure if that > changed at some point. Hi Katrin, you are right. But I reworked it to do that, and other things :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:26:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:26:17 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 26735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26735&action=edit Bug 12017 - Move language description out of database This patch moves language descriptions from database into template files, in part to ease the translation of some strings, but mostly to have one place to define languages. All languages/scripts/regions are defined at languages.inc template file, with native versi?n and translatable version. As a bonus, language descriptions are present at webinstaller stage. To test: 1) Do some fake translations, for example all langs for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do mkdir koha-tmpl/intranet-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/bootstrap/$l; mkdir koha-tmpl/opac-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/ccsr/$l; done 2) Go to Administration > System preferences > I18N/L10N There are many missing descriptions 3) Enable some random languages, some in groups (fr|en) on staff/opac. Enable OPAC changelanguage 4) Reload page, look at the bottom for language changer. Also open a OPAC view, look for language changer. Do NOT change languages 5) Apply the patch 6) Reload STAFF page, verify all descriptions in native language. 7) CHANGE in Language changer (staff/opac). Currently we show Lang+Code, and in lang groups Lang+Script+Region+Code I think it's too long, I propose to show only Lang, and in groups Region+Code, all native. Change OPAC theme (prog|ccsr) and check again. On prog and ccsr the result is not pretty, but works 8) Go to Administration > System preferences > Local use Add a new local syspref, any Explanation|Variable|Value, type Languages, Save. Check that all languages look good. Also Edit that syspref, on edition a list of languages must show in value box, check that they look good NOTE: There is a Bug in this kind of preference, selected languages are passed but ignored at save/load time. Only staff selected languages are shown. A problem for another report 9) NEW - Installer languages. This patch enable view of languages on Web installer. Edit your koha-conf.xml, change database name to a new name, create that database and grant access, reload staff page, log in, you will be redirected to step1 of installer, check names and codes for installed languages. (revert to your old database before proceed) 10) Advanced Search. On staff/opac{bootstrap/prog/ccsr}, go to advanced search, clic more options, go to limit by language, select one and press search, verify the search term "Search with limit(s): 'ln,rtrn:XXX'" with XXX the iso639-2 code of your selected lang NOTE: This is the ONLY place where translated language names are used!!! 11) Translations. Update language files for one of the active languages, say de-DE (cd misc/translator; perl translate update de-DE; perl translate update de-DE; perl translate install de-DE) 12) Change language to German (DE), go to advanced search 'Suche' (staff), clic 'mehr Optionen', look for 'Sprache' pulldown, verify some translations (ej. Greek -> Griechisch) [this translations are not present on opac] I think that all previous functionality is present. Lines starting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:38:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:38:39 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #5 from Katrin Fischer --- Hi Marjorie, I did test now - and I think you are right. Something about the visibility is broken. I removed the permission to manage all funds, I am not a superlibrarian, the fund access is restricted to another branch and I can still see it :( I am quite sure this used to work differently and it quite a problem. The view is also the same on the acquisition start page and the fund list for the budget. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:39:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:39:53 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26735|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:39:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:39:59 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:41:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:41:01 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #7 from Bernardo Gonzalez Kriegel --- Sorry, resubmit to fix koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:43:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:43:58 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 26736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26736&action=edit Bug 12017 - Move language description out of database This patch moves language descriptions from database into template files, in part to ease the translation of some strings, but mostly to have one place to define languages. All languages/scripts/regions are defined at languages.inc template file, with native versi?n and translatable version. As a bonus, language descriptions are present at webinstaller stage. To test: 1) Do some fake translations, for example all langs for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do mkdir koha-tmpl/intranet-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/bootstrap/$l; mkdir koha-tmpl/opac-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/ccsr/$l; done 2) Go to Administration > System preferences > I18N/L10N There are many missing descriptions 3) Enable some random languages, some in groups (fr|en) on staff/opac. Enable OPAC changelanguage 4) Reload page, look at the bottom for language changer. Also open a OPAC view, look for language changer. Do NOT change languages 5) Apply the patch 6) Reload STAFF page, verify all descriptions in native language. 7) CHANGE in Language changer (staff/opac). Currently we show Lang+Code, and in lang groups Lang+Script+Region+Code I think it's too long, I propose to show only Lang, and in groups Region+Code, all native. Change OPAC theme (prog|ccsr) and check again. On prog and ccsr the result is not pretty, but works 8) Go to Administration > System preferences > Local use Add a new local syspref, any Explanation|Variable|Value, type Languages, Save. Check that all languages look good. Also Edit that syspref, on edition a list of languages must show in value box, check that they look good NOTE: There is a Bug in this kind of preference, selected languages are passed but ignored at save/load time. Only staff selected languages are shown. A problem for another report 9) NEW - Installer languages. This patch enable view of languages on Web installer. Edit your koha-conf.xml, change database name to a new name, create that database and grant access, reload staff page, log in, you will be redirected to step1 of installer, check names and codes for installed languages. (revert to your old database before proceed) 10) Advanced Search. On staff/opac{bootstrap/prog/ccsr}, go to advanced search, clic more options, go to limit by language, select one and press search, verify the search term "Search with limit(s): 'ln,rtrn:XXX'" with XXX the iso639-2 code of your selected lang NOTE: This is the ONLY place where translated language names are used!!! 11) Translations. Update language files for one of the active languages, say de-DE (cd misc/translator; perl translate update de-DE; perl translate update de-DE; perl translate install de-DE) 12) Change language to German (DE), go to advanced search 'Suche' (staff), clic 'mehr Optionen', look for 'Sprache' pulldown, verify some translations (ej. Greek -> Griechisch) [this translations are not present on opac] I think that all previous functionality is present. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:44:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:44:15 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:46:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:46:39 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #11 from Bernardo Gonzalez Kriegel --- Katrin, I did a new version. Now all is native, and advanced search shows translations. All in templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 06:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 04:50:06 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #6 from Katrin Fischer --- Hm, I tried a git bisect, because I wondered when it changed and the change seems to have been introduced by: 203757e353cbbb2add934523fdbd7113c6180207 is the first bad commit commit 203757e353cbbb2add934523fdbd7113c6180207 Author: Julian Maurice Date: Fri May 18 09:12:43 2012 +0200 Bug 7304: More permissions for budgets -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:24:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 05:24:51 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #9 from paxed --- [%# "WARNING: This file must be replicated on 'include' dir" %] [%# "for each staff/opac theme" %] It's the exact same information in each file. To reduce the chance of these files getting out of sync, wouldn't it be better to have a single file? And, IMO, these language names have no need to be translatable, either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:35:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 05:35:37 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #10 from Katrin Fischer --- If we aim for keeping the same functionality, the translations are needed - we use them on the advanced search language pull down. I think there is currently no way to use the same file for OPAC and staff as the template directories are separate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:43:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 05:43:12 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #7 from Katrin Fischer --- Note: IndependentBranches also doesn't make any difference. I have upgraded the severity, as this is quite a problem for bigger libraries that don't want other branches to see their funds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:44:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 05:44:31 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #11 from paxed --- (In reply to Katrin Fischer from comment #10) > If we aim for keeping the same functionality, the translations are needed - > we use them on the advanced search language pull down. I think there is > currently no way to use the same file for OPAC and staff as the template > directories are separate. Yes, but if I understand correctly, after this patch, these would be picked up into the po-files. Why would these need to be translatable in there? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:46:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 05:46:04 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #12 from Katrin Fischer --- Hm, I am not sure I understand the problem. Currently we keep the native name of the language and the (quite incomplete) translations in the sql files. This just moves it to the standard procedure, enabling every translator to have the translations without adding to the SQL file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 07:59:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 05:59:43 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #13 from paxed --- (In reply to Katrin Fischer from comment #12) > Hm, I am not sure I understand the problem. Currently we keep the native > name of the language and the (quite incomplete) translations in the sql > files. This just moves it to the standard procedure, enabling every > translator to have the translations without adding to the SQL file? Nevermind, you're right about that. Still, having the same code in triplicate (once for each theme), is a bit fragile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:25:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:25:51 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26364|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 26737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26737&action=edit Bug 11944: Remove all utf8 filter from templates This patch - removes all html_entity usages in tt file which hide utf8 bugs - removes all encode utf8 in tt plugins because we should get correctly marked data from DBIC and other sources directly (cf plugin EncodeUTF8 used in renew.tt) - adds some cleanup in C4::Templates::output: we now use perl utf8 file handler output so we don't need to decode tt variables manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:25:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:25:58 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26365|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 26738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26738&action=edit Bug 11944: replace use of utf8 with Encode See the wiki page for the explanation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:26:02 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26366|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 26739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26739&action=edit Bug 11944: Encoding UTF8 in C4::Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:26:08 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26367|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 26740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26740&action=edit Bug 11944: Set ImplicitUnicode for YAML Before this patch, string for yaml files used in preferences.pl were broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:26:13 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26368|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 26741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26741&action=edit Bug 11944: use CGI( -utf8 ) everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:26:18 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26369|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 26742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26742&action=edit Bug 11944: Library name variable should be decoded Test on preferences.pl and on some others pages when mysql is used to store session. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:26:47 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26742|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 26743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26743&action=edit Bug 11944: Library name variable should be decoded Test on preferences.pl and on some others pages when mysql is used to store session. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:26:51 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26370|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 26744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26744&action=edit Bug 11944: replace uri_escape with uri_escape_utf8 everywhere To reproduce, edit, index notice with ?? and search "??" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:26:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:26:56 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26371|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 26745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26745&action=edit Bug 11944: Never use decode/encode in TT Plugins The EncodeUTF8 TT plugin is useless, we should NEVER use encode in templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:27:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:27:00 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26372|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 26746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26746&action=edit Bug 11944: Remove obsolete encoding routines We don't need to decode manually which provide nice performance boost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:27:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:27:04 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26407|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 26747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26747&action=edit Bug 11944: TT Plugins should not encode strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:27:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:27:09 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26409|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 26748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26748&action=edit Bug 11944: Fix encoding issue on searching - latin characters The search is still broken for non-latin characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 09:27:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 07:27:34 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:01:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 08:01:41 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26176|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 26749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26749&action=edit [SIGNED OFF] MT8122: Adds Shibboleth authentication - Use the shibbolethAuthentication syspref to enable Shibboleth authentication - Configure the shibbolethLoginAttribute to specify which shibboleth user attribute matches the koha login - Make sure the OPACBaseURL is correctly set MT8122, Follow-up: Adds Shibboleth authentication - Fix logout bug: shibboleth logout now occurs only when the session is a shibboleth one. - Do some refactoring: getting shibboleth username is now done in C4::Auth_with_Shibboleth.pm (get_login_shib function) MT8122, Follow-up: Adds Shibboleth authentication - Adds redirect to opac after logout MT8122, Follow-up: Adds Shibboleth authentication - Shibboleth is not compatible with basic http authentication in C4/Auth.pm. This patch fixes that. MT8122, Follow-up: Adds Shibboleth authentication - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with multiple vhosts. MT8122, Follow-up: Adds Shibboleth authentication - Adds missing protocol for $ENV{'SERVER_NAME'} Signed-off-by: Martin Renvoize http://bugs.koha-community.org/show_bug.cgi?id=8446 Signed-off-by: Jesse Weaver (ByWater employee.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:01:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 08:01:56 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26177|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 26750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26750&action=edit [SIGNED OFF] BUG8446, Follow up: Adds Shibboleth authentication - Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont work if koha is behind a reverse proxy. - To use multiple vhosts, set OpacBaseURL per vhost explicitly with 'SetEnv OpacBaseURL Value' as per Bug 10325 BUG8446, Follow up: Adds Shibboleth authentication - Ensure user is returned to requested page after authentication - Added querystring to the target path in shibboleth URL so that when a user is authenticated he/she is returned to the correct page they requested before authentication. Example where this is important: When a user clicks a direct biblio link of the form - /opac-detail.pl?biblionumber=12345 BUG8446, Follow up: Remove unused imports from scripts - Remove import of deprecated C4::Utils module from shibboleth authentication module: Auth_with_shibboleth.pm Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:02:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 08:02:15 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26187|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 26751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26751&action=edit [SIGNED OFF] BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:03:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 08:03:35 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #31 from Martin Renvoize --- Created attachment 26752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26752&action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implimented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:04:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 08:04:02 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 10:06:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 08:06:58 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #32 from Martin Renvoize --- Some follow-up work to allow better error handling when a shibboleth session exists but does not match a koha user, and allow for shibboleth login from the front page in bootstrap should you not already be logged in. I've also added the beginnings of a perldoc to the Auth_with_shibboleth.pm module to guide configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 11:44:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 09:44:38 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23698|0 |1 is obsolete| | --- Comment #15 from Benjamin Rokseth --- Created attachment 26753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26753&action=edit Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. Signed-off-by: Benjamin Rokseth Works as notified, second date field in SIP checkin (return date) is used as return date. Return shows up in history with correct date. Comments: - patron is fined if return date is before issue date, but that is largely irrelevant anyway. - dependent bug 10694 is marked as Failed QA but seems to have passed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 11:45:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 09:45:18 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |benjamin.rokseth at kul.oslo.k | |ommune.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 12:25:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 10:25:18 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 12:25:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 10:25:21 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16720|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 26754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26754&action=edit Bug 8218 : Add a maintenance script to sanitize biblio records This patch adds: - a new maintenance script batch_sanitize_records - a new subroutine C4::Charset::SanitizeRecord - new unit tests for the new subroutine Test plan: 1/ prove t/db_dependent/Charset.t 2/ Create a record containing "&amp;" (could be follow with as many 'amp;' as you want) in one of its fields and the same for the field linked to biblioitems.url. The url should not be sanitized, it cans contain "&". 3/ Launch the maintenance script with the -h paramters to see how to use it. 4/ Launch the script using the different parameters: --filename=FILENAME --biblionumbers='XXX' --auto-search The auto-search permits to sanitize all records containing "&amp;" in the marcxml field. Use the verbose flag for testing. Without the --confirm flag, nothing is done. 5/ Use the --confirm flag and verify in the biblioitems.marcxml field that the record has been sanitized. 6/ Try the --reindex flag to reindex records which have been modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 12:29:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 10:29:46 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26754|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 26755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26755&action=edit Bug 8218 : Add a maintenance script to sanitize biblio records This patch adds: - a new maintenance script batch_sanitize_records - a new subroutine C4::Charset::SanitizeRecord - new unit tests for the new subroutine Test plan: 1/ prove t/db_dependent/Charset.t 2/ Create a record containing "&amp;" (could be follow with as many 'amp;' as you want) in one of its fields and the same for the field linked to biblioitems.url. The url should not be sanitized, it cans contain "&". 3/ Launch the maintenance script with the -h paramters to see how to use it. 4/ Launch the script using the different parameters: --filename=FILENAME --biblionumbers='XXX' --auto-search The auto-search permits to sanitize all records containing "&amp;" in the marcxml field. Use the verbose flag for testing. Without the --confirm flag, nothing is done. 5/ Use the --confirm flag and verify in the biblioitems.marcxml field that the record has been sanitized. 6/ Try the --reindex flag to reindex records which have been modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 12:46:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 10:46:23 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 12:46:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 10:46:49 +0000 Subject: [Koha-bugs] [Bug 12023] Web installer fails under plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:09:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 11:09:41 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- Marjorie, Try to define an owner for the fund. If no owner is defined, it seems there is no restriction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:11:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 11:11:38 +0000 Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 --- Comment #2 from Jacek Ablewicz --- I did some Q&D measurements trying to estimate what kind of performance penalty we can expect when ditching Zconn caching entirely. While cached Zconn connections are generally not used all that often by Koha, there are some notable exceptions, like (e.g.) authority searches (for each authority record on the result list Koha does one extra search to find out how many biblio records are attached to the specific authority). Creating & immediately destroying Zebra connection - without doing any search with it - is surprisingly lightweight (ca 46 ?s per connection). But it goes up to 2.6 - 3.0 ms if the connection was used to perform some actual search. So for a typical case (20 authority search results per request) an extra latency when not caching would be 60 milliseconds or so. Not too bad, considering that: (testing "/cgi-bin/koha/opac-authorities-home.pl?startfrom=0&marclist=any&and_or=and&excluding=&operator=contains&value=&resultsperpage=20&type=opac&op=do_search&authtypecode=PERSO_NAME&orderby=HeadingAsc" page loading time): - mod_perl (semi-persistent; persistent would be ~50 ms faster) with zebra connection caching enabled: 290 ms - mod_perl with zebra connection caching disabled: 350 ms - regular CGI with zebra connection caching enabled: 890 ms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:32:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 11:32:22 +0000 Subject: [Koha-bugs] [Bug 12024] New: Add to list opens the list adding UI in two windows Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024 Bug ID: 12024 Summary: Add to list opens the list adding UI in two windows Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 26756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26756&action=edit Fix Add To List in item details In Item details, when using the menu toolbar for Add To > List, the list adding UI opens in a popup window, and also in the original window. The original window should stay showing the item details page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:33:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 11:33:00 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:33:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 11:33:04 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #9 from Jonathan Druart --- Created attachment 26757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26757&action=edit Bug 12019: FIX budget_owner_id node is duplicated The input witht the budget_owner_id id is duplicated. It breaks the jQuery selector $('#budget_owner_id').val(''); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:33:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 11:33:10 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #10 from Jonathan Druart --- Created attachment 26758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26758&action=edit Bug 12019: If a fund has a restriction, a owner is mandatory The C4::Budgets::CanUserUseBudget assumes that budget_owner_id is set if a restriction (budget_permission) exists. see && $budget->{budget_owner_id} && $budget->{budget_owner_id} != $borrower->{borrowernumber} Test plan: Edit a fund and try to save it with a limitation and no owner. It should not be possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 13:38:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 11:38:27 +0000 Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:19:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:19:11 +0000 Subject: [Koha-bugs] [Bug 12025] New: Inventory tool fails with "Could not reads headers", or sometimes a timeout Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12025 Bug ID: 12025 Summary: Inventory tool fails with "Could not reads headers", or sometimes a timeout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jason at esilibrary.com QA Contact: testopia at bugs.koha-community.org Created attachment 26759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26759&action=edit sample file This happens with small test files of one or two barcodes. jason-temp at lumen:~$ od BARCODES.TXT 0000000 030063 033065 030463 030060 030060 030060 033062 031412 0000020 032460 031466 030061 030060 030060 031460 000064 0000035 jason-temp at lumen:~$ cat BARCODES.TXT 30563100000026 30563100000034jason-temp at lumen:~$ On the server side, it looks inventory.pl spins out of control, and is looping on commands like this: write(5, "s\0\0\0\3select authorised_value fro"..., 119) = 119 read(5, "\1\0\0\1\1h\0\0\2\3def\4salt\27marc_subfield"..., 16384) = 144 poll([{fd=5, events=POLLIN|POLLPRI}], 1, 0) = 0 (Timeout) write(5, "Y\0\0\0\3select authorised_value, li"..., 93) = 93 read(5, "\1\0\0\1\3\\\0\0\2\3def\4salt\21authorised_va"..., 16384) = 337 poll([{fd=5, events=POLLIN|POLLPRI}], 1, 0) = 0 (Timeout) write(5, "\1\0\0\0\16", 5) = 5 read(5, "\7\0\0\1\0\0\0\2\0\0\0", 16384) = 11 poll([{fd=5, events=POLLIN|POLLPRI}], 1, 0) = 0 (Timeout) write(5, "\1\0\0\0\16", 5) = 5 read(5, "\7\0\0\1\0\0\0\2\0\0\0", 16384) = 11 poll([{fd=5, events=POLLIN|POLLPRI}], 1, 0) = 0 (Timeout) This is with Koha 3.14.03.000, but Chris Cormack confirmed that it happens with master, 3.14.1, and 3.14.5, but that it works fine on 3.12.12. He tracked it down to this commit for this bug: 0313856d9a1a9c0c002da0aead8c8516b51e1c11 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 There is an email thread discussing this on the Koha list: http://lists.katipo.co.nz/public/koha/2014-March/039092.html http://lists.katipo.co.nz/public/koha/2014-April/thread.html#39127 With the Chrome development tools, I also see the following errors when I first load the interface: Uncaught SyntaxError: Unexpected token ILLEGAL inventory.pl:62 event.returnValue is deprecated. Please use the standard event.preventDefault() instead. jquery.js:3 Let me know if there's anything else I can do to help. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:38:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:38:45 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26752|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 26760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26760&action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implimented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:41:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:41:15 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #34 from Martin Renvoize --- I have a work in progress branch for all things shib related available at: https://github.com/PTFS-Europe/koha/tree/bug_8466-shibboleth I intend so add some new bugs in the coming days to enhance upon this base. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:44:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:44:02 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #35 from Martin Renvoize --- Created attachment 26761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26761&action=edit BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:44:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:44:10 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #36 from Martin Renvoize --- Created attachment 26762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26762&action=edit BUG8446, Follow up: Correct paths after file rename -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:47:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:47:45 +0000 Subject: [Koha-bugs] [Bug 12026] New: Shibboleth auto-provisioning Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Bug ID: 12026 Summary: Shibboleth auto-provisioning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org, francart at gmail.com, frederic at tamil.fr, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, matthias.meusburger at biblibre.com, pgsengstock at wisc.edu, tomascohen at gmail.com, z.tajoli at cineca.it Depends on: 8446 Shibboleth authentication has the ability to send an arbitrary number of attributes to koha; These attributes can be used to dynamically create and update user records in koha. Our shibboleth patches should support this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:47:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:47:45 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12026 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:49:25 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12027 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:49:25 +0000 Subject: [Koha-bugs] [Bug 12027] New: Shibboleth authentication for staff client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Bug ID: 12027 Summary: Shibboleth authentication for staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org, francart at gmail.com, frederic at tamil.fr, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, matthias.meusburger at biblibre.com, pgsengstock at wisc.edu, tomascohen at gmail.com, z.tajoli at cineca.it Depends on: 8446, 12026 The current shibboleth implementation only support authentication into the opac. We should also enable shibboleth for the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:49:25 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12027 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:54:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:54:06 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12025 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 14:54:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 12:54:06 +0000 Subject: [Koha-bugs] [Bug 12025] Inventory tool fails with "Could not reads headers", or sometimes a timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12025 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |7684 --- Comment #1 from Jonathan Druart --- Hello Jason, I don't reproduce the issue against master (and even on the 3.14.x branch). On the inventory tools page (tools/inventory.pl), I filled the "Barcode file" with a barcodes file, I clicked on submit and I did not get any error. Could you try to reproduce on a sandbox please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 15:41:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 13:41:40 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |h.meissner.82 at web.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 15:50:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 13:50:04 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #11 from Marjorie Barry-Vila --- (In reply to Jonathan Druart from comment #8) > Marjorie, > Try to define an owner for the fund. If no owner is defined, it seems there > is no restriction. Jonathan, I defined an owner for the fund but for me it is the same on acquisition home page, i can see funds of the other branches and of the other owners. I should see only the budgets that I am an owner, right? We need to change something in the drop down menu restrictions? Thanks! Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 15:55:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 13:55:36 +0000 Subject: [Koha-bugs] [Bug 11979] items status not for loan on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979 --- Comment #1 from Marjorie Barry-Vila --- Created attachment 26763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26763&action=edit not for loan reserve -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 15:56:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 13:56:02 +0000 Subject: [Koha-bugs] [Bug 11979] items status not for loan on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979 --- Comment #2 from Marjorie Barry-Vila --- Created attachment 26764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26764&action=edit not for loan reserve -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:30:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 14:30:09 +0000 Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at pttk.fi |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:40:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 14:40:27 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- URL|bib.math.uni-bonn.de | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:47:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 14:47:04 +0000 Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:47:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 14:47:07 +0000 Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018 --- Comment #1 from Owen Leonard --- Created attachment 26765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26765&action=edit Bug 12018 - add table sorting to patron card batches When viewing batches of patrons in the patron card creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. This patch also corrects a translation issue with table headers identical to that addressed by Bug 11505. To test, go to Tools -> Patron card creator -> Manage batches. View an existing batch or create a new batch and populate it with patrons. Table sorting controls should work correctly. Batch management operations should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:49:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 14:49:35 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #21 from Olli-Antti Kivilahti --- Created attachment 26766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26766&action=edit Bug 11175 - Rebased to parse XML result from SimpleSearch instead of the ISO2709-version which it used to be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 16:55:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 14:55:15 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26404|0 |1 is obsolete| | --- Comment #22 from Olli-Antti Kivilahti --- Created attachment 26767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26767&action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Presentation for bootstrap-theme. This displays the injected component part records in the bootstrap theme. -------------------------------------- TEST PLAN -------------------------------------- PREREQUISITES: -AddChildRecordsToDetailedViews system preference needs to be activated. -opacthemes system preference needs to be 'bootstrap'. -Catalog a bunch of child records for a host record. --Search a record and go to detailed view. --Use the existing functionality "+ New" -> "New Child Record" to catalog child records. ------------------------ TEST CASE1 - OPAC ------------------------ -Reindex Zebra -Search for the record you just made childs for and display it in the opac-detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. ------------------------ Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:07:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 15:07:33 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #17 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #15) > Hi Jonathan, > > I have tested this again and it works as described. But I am a bit worried > still - before the patch you could undo a receipt any time, being aware that > the items would not be deleted. Now you can undo and the items will be > deleted, which is nice. But if there is a hold on the record, you can't undo > until you cancel he hold. > > This could be a problem for a very popular book with multiple holds and > multiple copies outside of the order. Then you'd have to cancel all of them, > to reenter them again after undoing the receipt. > > Could showing an alert: 'There is at least 1 hold on this record, please > delete items manually' be an option? > > Or a check on remaining items? If no items remain you shouldn't be able to > undo the receipt without fixing it. If there is an item and it's not an item > level hold on your ordered item, you could. > > I am not feeling very sure about this, maybe we could get the bug reporter's > (Marjorie?) and some others opinion on this? Hi Katrin, I tested it with new patch of Jonathan and for me it works. Test plan: -create one item available -order one item on the same record -receive item ordered -do a reservation on item available -you can undo the receipt It is normal for me to delete a hold of a item which is not realy received. But if a hold is on a item already received in a other basket, you do not have to delete the hold. I am sorry, my english is bad. Do you understand the same thing that me? Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:27:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 15:27:43 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Paola Rossi --- I apply against 3.15.00.026. In "Authorized values" of Administration module, I add a "New category", whose name is (newcat-mu): newcat-? 1) ERROR: Soon after I save it, 3 greek chars are shown badly here: "New authorized values for newcat-??:" "Authorized values for category newcat-??:" "There are no authorized values defined for newcat-??" The current URL is bad too: http://192.168.40.128:8080/cgi-bin/koha/admin/authorised_values.pl?searchfield=newcat-??&offset=0 2) OK: The new category has been added to the list "Show category". Its name is shown OK. Now I select the new category "newcat-?" inside this list, and I select "Show category". Koha answers with a page where all the 5 occurrences of newcat-? are shown OK. So I pass to Failed QA status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:30:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 15:30:10 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #12 from Jonathan Druart --- (In reply to Marjorie Barry-Vila from comment #11) > I defined an owner for the fund but for me it is the same on acquisition > home page, i can see funds of the other branches and of the other owners. > I should see only the budgets that I am an owner, right? > We need to change something in the drop down menu restrictions? Could you confirm the issue still appears with these patches? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:38:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 15:38:39 +0000 Subject: [Koha-bugs] [Bug 12028] New: add cardnumber on update patron records page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12028 Bug ID: 12028 Summary: add cardnumber on update patron records page Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 26768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26768&action=edit patron update Hi, It would be fine to have patron cardnumber on member-update.pl. This will avoid confusion of homonymous. Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:45:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 15:45:47 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #32 from Jonathan Druart --- (In reply to Paola Rossi from comment #31) > In "Authorized values" of Administration module, I add a "New category", > whose name is (newcat-mu): > newcat-? > > 1) ERROR: > Soon after I save it, 3 greek chars are shown badly here: > "New authorized values for newcat-??:" > "Authorized values for category newcat-??:" > "There are no authorized values defined for newcat-??" Hum, weird, I did not reproduce on my local instance. Same on sandbox 17: http://pro.test17.biblibre.com/cgi-bin/koha/admin/authorised_values.pl Templates fr-FR and it-IT generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:56:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 15:56:03 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:56:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 15:56:08 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #1 from Martin Renvoize --- Created attachment 26769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26769&action=edit BUG12026: Adds auto-provisioning to shibboleth - Adds the option to map shibboleth attributes to koha user columns and allows mapping to auto create non-existant users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 17:57:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 15:57:56 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #2 from Martin Renvoize --- Shamelessly grabbed the patches from Jesse's branch.. available here: https://github.com/pianohacker/koha/commits/shibboleth-v3.12.10 Re-based against master bug 8446, but kept original authorship as Jesse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 18:11:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 16:11:38 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #33 from Paola Rossi --- Dear Mr. Jonathan, two images are available at: 1)http://koha.wdfiles.com/local--files/immaginibugs/newcat-mu.png 2)http://koha.wdfiles.com/local--files/immaginibugs/newcat2-mu.png The first image shows the error, while the second one shows correct chars. The second one shows the already added category. The first one shows the moment soon after the adding. Your test at comment 32 references to the second moment, where no error is shown. When I cancel the category too, I see wrong chars. In the Sandbox 17, I recreated the error, see link: 3) http://www.koha.it/local--files/immaginibugs/newcat3-mu.png I use Firefox v.28.0 on Windows 7 environment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 19:57:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 17:57:00 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #14 from Bernardo Gonzalez Kriegel --- (In reply to paxed from comment #13) > Still, having the same code in triplicate (once for each theme), is a bit > fragile. It's fragile, a lot. I add a patch to show how this could be solved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 19:57:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 17:57:54 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #15 from Bernardo Gonzalez Kriegel --- Created attachment 26770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26770&action=edit Bug 12017 - Followup to set one location for languages.inc This patch implements things that needs their own reports. Just consider it a proof of concept. Don't sign It: 1) Adds a new function to Koha.tt plugin to get any value of config variable (needs own report) 2) Create a include dir on opachtdocs to be used as a general include dir for all interefaces and themes I opted for opachtdocs in the thinking that it's has more public access than intrahtdocs (needs own report) 3) Adds "USE Koha" in doc-head-close.inc on every interface/theme to use Koha template plugin. It's used in almost all opac files, and many staff. So make it universal I suppose there is a better way (needs own report) 4) Copy languages.inc to new created general include dir and rewrite all relevant files to find and use this only file looking for it by PATH. Removed all other languages.inc files. Main idea is remove the need to n-plicate template files of general use. If you want to test: 1) Apply the patch 2) Check that all works as first patch test plan, EXCEPT for translations because strings to translate are looked only on theme dir. But if Bug 7939 pass, an arbitrary dir can be searched and its strings added to some OPAC po file to be translated. Another solution is to use as general include dir en/bootstrap's -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 20:32:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 18:32:45 +0000 Subject: [Koha-bugs] [Bug 12029] New: Patrons should be able to delete their patron messages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Bug ID: 12029 Summary: Patrons should be able to delete their patron messages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would be great if patrons could delete private messages displayed to them in the OPAC. Right now, if staff use this feature, patrons have to remind staff to remove the message. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 20:36:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 18:36:34 +0000 Subject: [Koha-bugs] [Bug 12030] New: Common messages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12030 Bug ID: 12030 Summary: Common messages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com How about adding an editable list of common messages to the message feature in the patron checkout screen or in the custom restrictions? Of course, the message should be editable itself once it is selected and put in the text box. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 22:11:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 20:11:06 +0000 Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 22:11:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 20:11:09 +0000 Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26765|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 26771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26771&action=edit [SIGNED-OFF] Bug 12018 - add table sorting to patron card batches When viewing batches of patrons in the patron card creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. This patch also corrects a translation issue with table headers identical to that addressed by Bug 11505. To test, go to Tools -> Patron card creator -> Manage batches. View an existing batch or create a new batch and populate it with patrons. Table sorting controls should work correctly. Batch management operations should work correctly. Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 22:18:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 20:18:20 +0000 Subject: [Koha-bugs] [Bug 2894] Routing list holds are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 23:29:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 21:29:48 +0000 Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same information for each language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 23:37:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 21:37:45 +0000 Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same information for each language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 26772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26772&action=edit Bug 11593 - subtag_registry.sql files contain the same information for each language This patch removes subtag_registry.sql from lang dirs, and put it on a new mandatory dir In that way we need to update only one file. All similar files are removed. To test: 1) Try a new install, or simply create a new database, grant permissions on it, change koha-conf.xml to use this database and go to staff page 2) Go step by step until all mandatory or optional sql files are loaded. Check that subtag_registry.sql is loaded. 3) Do it again but on other language. First install translation and repeat 2), could use de-DE or fr-FR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 2 23:38:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Apr 2014 21:38:57 +0000 Subject: [Koha-bugs] [Bug 11593] subtag_registry.sql files contain the same information for each language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 02:36:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 00:36:12 +0000 Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 02:36:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 00:36:16 +0000 Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #7 from M. Tompsett --- Created attachment 26773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26773&action=edit Bug 11885 - Follow-up to address issues raised Jonathan Druart raised the following three issues: 1/ subtags was bold before patch 2/ 1 dash existed between tag and tag name 3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet nom commun", "101 ## - Langue" becomes "101 # # Langue") This patch addresses them in the following way: 1/ You will note that @ was not bold on the 0 tab. Every other tab were bold. By making the similar template into a procedure based on the 0XX tab, bolding was lost. This patch bolds all subtags including the @, so that the visible change is minimized. 2/ The dash was programmatically added in at the code stage previously. This bug fix splits the the single concatenation mess into parts which can be styled. This puts the dash back into the template. However, it should be noted that the spacing for the 0 tab's tag and tag description will have an extra space after the hypen that was lacking before. 3/ ...... is different than ... ... The later puts that extra space. This patch fixes that. See comment 1 for the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:14:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 01:14:05 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #13 from M. Tompsett --- Created attachment 26774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26774&action=edit Bug 6864 - Corrected alphabetical order of sysprefs.sql Original patch lazily added OpacBelowLoginBox to the end. This puts it in proper alphabetical order location. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:16:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 01:16:56 +0000 Subject: [Koha-bugs] [Bug 11726] Untranslatable loading page overlay in offline circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11726 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 26775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26775&action=edit Bug 11726 - Untranslatable loading page overlay in offline circ This patch reformats a message to be catched by translation script. To test: 1) Grep for the offending string egrep -Rn "Loading page |\", please wait" * only occurrence on koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt 2) Apply the patch 3) Update your preferred language, ej. fi-FI (cd misc/translator; perl translate update fi-FI) 4) Repeat 1), there are 2 new strings on staff po file, out of context :), but now can be translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:17:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 01:17:17 +0000 Subject: [Koha-bugs] [Bug 11726] Untranslatable loading page overlay in offline circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11726 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:20:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 01:20:52 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #14 from M. Tompsett --- Created attachment 26776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26776&action=edit Bug 6864 - Added missing bootstrap template changes. The original patch only touches the prog template. This updates the bootstrap theme in a corresponding manner. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:28:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 01:28:55 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 03:55:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 01:55:55 +0000 Subject: [Koha-bugs] [Bug 12031] New: Task Scheduler not sending mail Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Bug ID: 12031 Summary: Task Scheduler not sending mail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Task Scheduler Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org The task scheduler to schedule reports from the UI is not passing the correct command to runreport.pl, so it doesn't send email correctly. To replicate: 1. make sure that your user is not in at.deny, and (if applicable/necessary) is in at.allow Useful, but not required step: make sure email can be sent from your server, also helpful is access to the Koha user's mail box (to see the bounce messages) 2. create a saved sql report to run 3. Go to Tools -> Task Scheduler and schedule a job to be run, and results emailed to you 4. note that you do not get an email, also note that the Koha user has received a bounce message with the report contents and an error message: [Thu Apr 3 14:02:00 2014] runreport.pl: ERROR: No saved report report-recipient at the.email.address.you.specified found at /usr/share/koha/intranet/cgi-bin/tools/runreport.pl line 193. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:03:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:03:22 +0000 Subject: [Koha-bugs] [Bug 6716] Database Documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716 --- Comment #136 from Liz Rea --- Created attachment 26777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26777&action=edit Bug 6716 - Document Items Table This patch documents the items table. Some fields were left undocumented because I was unsure of what data was stored there: stack - might be linked to shelving number, but need confirmation paidfor - pretty sure this is unused, but don't want to document it that way Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:03:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:03:41 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:03:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:03:45 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #1 from Liz Rea --- Created attachment 26778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26778&action=edit Bug 12031 - Task Scheduler not sending mail At some stage the runreport.pl cronjob was changed to accept longopts, but the scheduler script wasn't changed along with it. This patch fixes the mismatch. To test: 1. make sure that your user is not in at.deny, and (if applicable/necessary) is in at.allow Useful, but not required step: make sure email can be sent from your server, also helpful is access to the Koha user's mail box (to see the bounce messages) 2. create a saved sql report to run 3. Go to Tools -> Task Scheduler and schedule a job to be run, and results emailed to you 4. note that you do not (without the patch) get an email. Make a note of the command it reports it is going to run. 5. apply the patch 6. schedule another job, you will notice that the command to run the scheduled job is slightly changed compared to the one in step 4. 7. Receiving an email when your job runs means the patch worked. Seeing --format= and --to= in the command also means the patch worked, as this is the command that runreport.pl is expecting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:07:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:07:18 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26774|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 26779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26779&action=edit Bug 6864 - Corrected alphabetical order of sysprefs.sql Original patch lazily added OpacBelowLoginBox to the end. This puts it in proper alphabetical order location. TEST PLAN --------- 1) Apply only the first patch 2) Run the Koha QA Test tool -- FAILED on the system preferences SQL file. 3) Apply only the second patch (this one) 4) Run the Koha QA Test tool -- Everything OK now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:09:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:09:46 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #3 from Robin Sheat --- Attempting to reproduce: * Plack setup with 10 workers for the staff client. * Go to add an item to a biblio (to populate caches.) * Added a new value in LOC, "TOASTER" * Selected New -> Item again on the biblio. * "Toaster" showed up in shelving location. * Went to "Items" tab, selected an item to edit. * "Toaster" did _not_ appear in the shelving location. * After some other unidentifiable messing around, it did appear. Definitely seems to be a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:24:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:24:03 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #4 from Robin Sheat --- Ah, I did manage to see the issue when adding a new item too. It may depend what worker you end up hitting. This is good, as otherwise it made no sense at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:25:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:25:33 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26465|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 26780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26780&action=edit [SIGNED OFF] Add OpacBelowLoginBox preference to add custom text below the login box. This patch file adds the ability to customize the text below the login area which appears when 'Log in to your account' in clicked in the top right of the OPAC. TEST PLAN ---------- 0) Back up your data if you care about it. 1) Open a staff client in your browser. 2) Make sure the OPAC system preference opacthemes is set to 'prog'. 3) Make sure the OPAC system preference opacuserlogin is set to 'Allow'. NOTE: Required to make the 'Log in to your account' in the top left of OPAC appear. 4) Make sure the OPAC system preference PatronSelfRegistration is set to 'Allow'. 5) Make sure the OPAC system preference PatronSelfRegistrationDefaultCategory is set to a value of patron category that exists (eg. PT is a sample one) NOTE: These are required to make the 'Register here' links appear after the text. 6) Open the OPAC in another tab. 7) Click the 'Log in to your account' link. 8) Note the text below the login area. 9) Apply the patch and run an update. (git bz apply 6864 -- interactive just this one) (./installer/data/mysql/updatedatabase.pl) 10) Refresh the OPAC page. -- the text should be identical. 11) In the staff client, modify the OPAC system preference OpacBelowLoginText to have some text, and save. 12) Refresh the OPAC page. -- the text should reflect what was entered in the OpacBelowLoginText system preference. 13) Open your mysql. 14) Drop and recreate the koha database. 15) Do a web install by going to the staff client URL. 16) Log in as the system user. 17) Confirm the OPAC system preference OpacBelowLoginBox exists. 18) Modify its value (blank, non-blank) and confirm that the OPAC page reflects the default message or custom message as expected each reload. 19) Run the Koha QA Test Tool -- This will FAIL on the system preferences SQL file. The next patch by me, Mark Tompsett, will fix it. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:25:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:25:50 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26779|0 |1 is obsolete| | --- Comment #17 from M. Tompsett --- Created attachment 26781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26781&action=edit Bug 6864 - Corrected alphabetical order of sysprefs.sql Original patch lazily added OpacBelowLoginBox to the end. This puts it in proper alphabetical order location. TEST PLAN --------- 1) Apply only the first patch 2) Run the Koha QA Test tool -- FAILED on the system preferences SQL file. 3) Apply only the second patch (this one) 4) Run the Koha QA Test tool -- Everything OK now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:25:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:25:59 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26776|0 |1 is obsolete| | --- Comment #18 from M. Tompsett --- Created attachment 26782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26782&action=edit Bug 6864 - Added missing bootstrap template changes. The original patch only touches the prog template. This updates the bootstrap theme in a corresponding manner. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:46:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:46:11 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26782|0 |1 is obsolete| | --- Comment #19 from M. Tompsett --- Created attachment 26783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26783&action=edit Bug 6864 - Bootstrap OpacBelowLoginBox This adds OpacBelowLoginBox to bootstrap. It also corrects the placement of setting the opacbelowloginbox template parameter, so that it will work under bootstrap. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 04:49:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 02:49:09 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26783|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 26784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26784&action=edit Bug 6864 - Bootstrap OpacBelowLoginBox This adds OpacBelowLoginBox to bootstrap. It also corrects the placement of setting the opacbelowloginbox template parameter, so that it will work under bootstrap. TEST PLAN --------- Run steps similar to the first patch except with opacthemese set to 'bootstrap'. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 05:12:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 03:12:10 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz --- Comment #5 from Robin Sheat --- Ah yes, there is a local cache for GetMarcStructure. It is also supposed to be memoised, but I don't see any result of that in memcache, which is strange to me. I think the way to fix this is to: * add a convenient ClearFrameworkCache function and call that from places like the framework editor, the authorised values editor, and so on, * remove the memoisation of the function (which I've found tends to be slower than the local cache anyway, when it works), and * add a cache timeout (5 minutes?) so that it won't screw up long-term if we fail to clear the cache somewhere, but still long enough that it'll likely come out of the woodwork as a bug. This'll also let us tide things over when under load. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 05:20:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 03:20:19 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #6 from Robin Sheat --- Actually, I may have spoken too soon there. It doesn't seem to actually be storing authorised values in there. So while that caching should be fixed, this particular instance might be coming from somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 05:24:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 03:24:20 +0000 Subject: [Koha-bugs] [Bug 12032] New: TinyMCE rewrites urls in a very annoying and unexpected way Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 Bug ID: 12032 Summary: TinyMCE rewrites urls in a very annoying and unexpected way Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org When making a news item on the Tools -> News page, trying to link to anything inside Koha gets rewritten as a relative path. Sometimes we may not want that, it's probably better to make it so that we have to be explicit about what url we want in there, rather than having TinyMCE try to help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 05:28:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 03:28:44 +0000 Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying and unexpected way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 05:28:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 03:28:48 +0000 Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying and unexpected way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 --- Comment #1 from Liz Rea --- Created attachment 26785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26785&action=edit Bug 12032 - TinyMCE rewrites urls in a very annoying and unexpected way To test: * create a news item with a link in it that is within the same domain example: my koha was at http://demo.mykoha.co.nz, I created a link in a news item to http://demo-intra.mykoha.co.nz * note that when the item is saved, the url changes to ../../../../ (or something like) * apply the patch * edit the link again, and save it * note that the link is saved correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:31:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 04:31:08 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- A default kohagit as misc/cronjobs/runreports.pl not tools/runreports.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:31:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 04:31:19 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12031 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:31:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 04:31:19 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1993 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:33:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 04:33:42 +0000 Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #8 from paxed --- (In reply to M. Tompsett from comment #7) > Created attachment 26773 [details] [review] > Bug 11885 - Follow-up to address issues raised > > This patch addresses them in the following way: > 1/ You will note that @ was not bold on the 0 tab. > Every other tab were bold. By making the similar template > into a procedure based on the 0XX tab, bolding was lost. > This patch bolds all subtags including the @, so that > the visible change is minimized. Why hard-coded tags? Isn't there some good reason to separate presentation and content? > 2/ The dash was programmatically added in at the code stage > previously. This bug fix splits the the single concatenation > mess into parts which can be styled. This puts the dash back > into the template. However, it should be noted that the > spacing for the 0 tab's tag and tag description will have an > extra space after the hypen that was lacking before. Wrap the dash and the spaces before the description in or something, so it'll be easier to hide with css. > 3/ ...... is different than > ... > ... > The later puts that extra space. This patch fixes that. This one is good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:58:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 04:58:47 +0000 Subject: [Koha-bugs] [Bug 12034] New: MSG_REMOVE_FROM_LIST different wording between OPAC and staff client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Bug ID: 12034 Summary: MSG_REMOVE_FROM_LIST different wording between OPAC and staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Staff client: "Are you sure you want to remove these records from the shelf?" OPAC: "Are you sure you want to remove these items from the list?" Should probably pick one wording, and use that in both staff client and OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 06:59:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 04:59:46 +0000 Subject: [Koha-bugs] [Bug 12035] New: Purchase Order Overflows Incorrectly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12035 Bug ID: 12035 Summary: Purchase Order Overflows Incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, if you add a large number of baskets while using a "OrderPdfFormat" of "pdfformat::layout3pages" or "pdfformat::layout3pagesfr", the basket table will overlap over the bottom footer (which includes the page numbers), and the overflow will start mid-way down the new page. This is because we've configured our PDF::Table objects incorrectly for the printbaskets() sub. Of course, the chances of having enough baskets in a basket group to trigger such an overflow might be quite small, so this might not happen very often. Still, it's a bug nonetheless. You can test it out by filling your database with bogus baskets; I've included some SQL at the bottom of this bug report to aid with that. Layout Config: layout3pages.pm,layout3pagesfr.pm: Current config for printbaskets: start_y => 230/mm, next_y => 230/mm, start_h => 230/mm, next_h => 230/mm, Note that the "next_y" and "next_h" are the same as the "start_*". This means that they'll start midway down the page on the new (overflow) page. My suggested replacement for printbaskets: start_y => 230/mm, #($start_y - $start_h = $bottom_margin), according to PDF::Table source code next_y => ($height - 5)/mm, start_h => 210/mm, next_h => ($height - 25)/mm, I'm using the $height variable here because that's the same measurement used by some page headers in the printorders() sub in this same module. -- The printorders() subs are all right in all the "OrderPdfFormat" options. The bottom margin is probably too large in layout3pages(fr).pm, but better too large than too small. layout2pages.pm: printorders: start_y => 285/mm, next_y => 285/mm, start_h => 260/mm, next_h => 260/mm, layout3pages.pm,layout3pagesfr.pm: printorders: start_y => 270/mm, next_y => 285/mm, start_h => 250/mm, next_h => 250/mm, --- [Note: the following SQL was created based on a Koha 3.8 database so YMMV.] *Create bogus baskets: INSERT INTO aqbasket Select null,rand() as basketname,note,booksellernote,contractnumber,creationdate,closedate,booksellerid,authorisedby,booksellerinvoicenumber,basketgroupid from kohatest38.aqbasket where basketno = 8; *Create bogus orders: INSERT INTO aqorders Select null, 1, entrydate,quantity,currency,listprice,totalamount,datereceived,booksellerinvoicenumber,freight,unitprice,quantityreceived,cancelledby,datecancellationprinted,notes,supplierreference,purchaseordernumber,subscription,serialid,(SELECT basketno FROM aqbasket WHERE basketno not in (select basketno from aqorders) limit 1) as 'basketno',biblioitemnumber,timestamp,rrp,ecost,gst,budget_id,budgetgroup_id,budgetdate,sort1,sort2,sort1_authcat,sort2_authcat,uncertainprice,claims_count,claimed_date from aqorders limit 1; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 07:04:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 05:04:55 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #7 from Robin Sheat --- Oh, GetAuthorisedValues is memoised using a method that just sticks it in a hash. That'll be it. So, there is the Memoize::Expire package that we can plug in and give authorised values a low timeout. Probably something like 10 seconds so that it'll cover that request and not much more. We can also force a clear when we set something, so that the current process will see the update immediately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 07:33:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 05:33:09 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #8 from Robin Sheat --- Created attachment 26786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26786&action=edit Bug 9967 - expire cached GetAuthorisedValues Adds Memoize::Expire to the caching for GetAuthorisedValues so that updates actually show up in a persistent environment (e.g. Plack) NOTE: This is an experimental patch only. It doesn't work in my testing for no reason I can see. It's for review in case someone can see what silly mistake I made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 07:40:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 05:40:06 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #9 from Robin Sheat --- According to the docs, this patch _should_ work, but it's not. I've verified that it's not actually expiring the cache. However I don't know why, so if someone can have a quick look and see what I've missed, that'd be handy. If no one else can work it out, I'll add a simple hand-rolled cache to it instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 10:00:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 08:00:12 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #34 from Jonathan Druart --- (In reply to Paola Rossi from comment #33) > Your test at comment 32 references to the second moment, where no error is > shown. I create the new category after applying patches? > In the Sandbox 17, I recreated the error, see link: > 3) http://www.koha.it/local--files/immaginibugs/newcat3-mu.png Could you please describe, step by step, how do you arrive on this page? >From http://pro.test17.biblibre.com/cgi-bin/koha/admin/authorised_values.pl I select "Italiano" in languages, I select "newcat-?" in the dropdown list. And I see the table with my authorized value, correctly displayed. The only problem I see is that the dropdown list does not preselect the good value. What is the character encoding of your browser? (Edition > Character encoding) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 10:09:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 08:09:06 +0000 Subject: [Koha-bugs] [Bug 9075] Show material type and item type on staff detail (with xslt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14447|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 10:09:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 08:09:36 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type on staff detail (with xslt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show material type and item |Rename type to material |type on staff detail (with |type on staff detail (with |xslt) |xslt) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 10:15:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 08:15:21 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type on staff detail (with xslt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 10:15:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 08:15:23 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type on staff detail (with xslt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #12 from M. de Rooy --- Created attachment 26787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26787&action=edit Bug 9075: Rename type to material type on staff detail (with XSLT) The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Test plan: Enable XSLT on staff detail. Check if you see the new label on catalogue detail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 10:15:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 08:15:34 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26769|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 26788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26788&action=edit BUG12026: Adds auto-provisioning to shibboleth - Adds the option to map shibboleth attributes to koha user columns and allows mapping to auto create non-existant users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 10:17:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 08:17:58 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type on staff detail (with xslt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |String patch Severity|enhancement |trivial --- Comment #13 from M. de Rooy --- I decided to simplify the approach of this report. Instead of discussing whether we should have the item type icon or not in the items table for the different settings of item_level_itypes, I now just rename Type to what is really is: Material type. That makes this patch a trivial string patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 11:09:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 09:09:36 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #10 from Jacek Ablewicz --- (In reply to Robin Sheat from comment #9) 1/ In AddAuthorisedValue() there is a call to flush_cache('AddAuthorisedValue') instead of flush_cache('GetAuthorisedValue') - probably irrelevant. 2/ There are some Memoize and Memoize::Expire bugs reported in CPAN, perl monks etc. which are still unresolved since last available version (1.03) was published, e.g.: http://www.perlmonks.org/index.pl?node_id=1049426 . 3/ I'm wondering if memoizing GetAuthorisedValue is such a good idea in the persistent environment.. Same thing for any subroutines which return references of any kind - unless we are 100% sure than the result data structures are always used in strictly read-only mode. Looks like it's not a case for GetAuthorisedValue(): it returns reference to array of hashrefs, and it's result is often passed directly to C4::Templates::param() in various scripts. C4::Templates::output() will then traverse this result and utf8::encode() any scalar values in the data structures. Subsequent GetAuthorisedValue() calls will return the same, memoized arrayref but with contents which got possibly altered by previous request. Not pretty :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 12:17:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 10:17:46 +0000 Subject: [Koha-bugs] [Bug 11974] Enable unix socket connections for database connections. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11974 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 13:45:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 11:45:30 +0000 Subject: [Koha-bugs] [Bug 12036] New: Neworderempty.pl fails to add items when itemrecorddisplay is too long (acqCreateItem=ordering) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12036 Bug ID: 12036 Summary: Neworderempty.pl fails to add items when itemrecorddisplay is too long (acqCreateItem=ordering) Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org In 3.14.4 I encounter this problem in Acquisition, neworderempty.pl: The output of PrepareItemrecordDisplay (called by itemrecorddisplay.pl in additem.js [cloneItemBlock]) seems to be too long. The line $(clone).append(data) in the ajax success function in cloneItemBlock fails silently. This makes it impossible to add items to a new empty order when AcqCreateItem=ordering. Did anyone else see that already or solved it? (I created the ACQ framework by just copying from Default.) On a clean master I could not reproduce this problem, but it seemed that the output of PrepareItemrecordDisplay was around 23000 there instead of 27000 chars. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:31:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:31:24 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:44:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:44:47 +0000 Subject: [Koha-bugs] [Bug 12036] Neworderempty.pl fails to add items when itemrecorddisplay is too long (acqCreateItem=ordering) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12036 --- Comment #1 from M. de Rooy --- >From IRC: Joubu marcelr: It works for meI added some subfields to my ACQ framework. itemrecorddisplay.pl?frameworkcode=ACQ returns 38098 chars and the form is correctly displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:47:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:47:36 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 --- Comment #1 from Owen Leonard --- Created attachment 26789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26789&action=edit Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client The staff client lists template contains a warning which differs from the same warning in the OPAC. The OPAC version is correct because it refers to a list rather than a shelf. This patch copies the OPAC version to the staff client template. This patch also corrects a few of other instances where the incorrect term "shelf" is used. To test, apply the patch and view a list in the staff client which is populated with items. Check the box next to one or more items on the list and click the "Remove selected" button. You should see the message, "Are you sure you want to remove these items from the list?" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:47:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:47:33 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:47:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:47:56 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:52:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:52:39 +0000 Subject: [Koha-bugs] [Bug 9088] Default values for fund and item type on neworderempty form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:52:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:52:42 +0000 Subject: [Koha-bugs] [Bug 9088] Default values for fund and item type on neworderempty form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14957|0 |1 is obsolete| | Attachment #14958|0 |1 is obsolete| | --- Comment #8 from M. de Rooy --- Created attachment 26790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26790&action=edit Bug 9088: neworderempty should preselect the only fund If there is only one fund in the select combo (and the fund is mandatory), neworderempty should just select it already. If there are more choices, behavior does not change. This patch implements this change in the template itself. Test plan: With more funds, check if neworderempty does not preselect a fund (at least when adding a line; when you modify, you should see what you had chosen). With one fund, check if it is already selected (add or modify). Toggle the setting of AcqCreateItem and check again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:53:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:53:25 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Default values for fund and |neworderempty should |item type on neworderempty |preselect the only fund |form | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:53:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:53:40 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:55:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:55:02 +0000 Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying and unexpected way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |liz at catalyst.net.nz Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 14:55:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 12:55:08 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #9 from M. de Rooy --- I decided to simplify the approach on this report. There is no preference anymore. And we ignore itemtype now. It is just: If there is only one fund, select it rightaway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:00:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:00:10 +0000 Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:00:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:00:14 +0000 Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018 --- Comment #3 from Jonathan Druart --- Created attachment 26791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26791&action=edit Bug 12018 - add table sorting to patron card batches When viewing batches of patrons in the patron card creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. This patch also corrects a translation issue with table headers identical to that addressed by Bug 11505. To test, go to Tools -> Patron card creator -> Manage batches. View an existing batch or create a new batch and populate it with patrons. Table sorting controls should work correctly. Batch management operations should work correctly. Signed-off-by: Nicole C. Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:04:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:04:08 +0000 Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying and unexpected way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:04:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:04:12 +0000 Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying and unexpected way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 --- Comment #2 from Owen Leonard --- Created attachment 26792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26792&action=edit [SIGNED-OFF] Bug 12032 - TinyMCE rewrites urls in a very annoying and unexpected way To test: * create a news item with a link in it that is within the same domain example: my koha was at http://demo.mykoha.co.nz, I created a link in a news item to http://demo-intra.mykoha.co.nz * note that when the item is saved, the url changes to ../../../../ (or something like) * apply the patch * edit the link again, and save it * note that the link is saved correctly Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:17:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:17:16 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type on staff detail (with xslt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #14 from Owen Leonard --- If "Material type" is correct should it not be changed in all views? The term "type" appears in OPAC search results, OPAC detail page, staff client search results, and staff client detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:24:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:24:14 +0000 Subject: [Koha-bugs] [Bug 11227] Staff po files contain some Javascript In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:24:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:24:45 +0000 Subject: [Koha-bugs] [Bug 11227] Staff po files contain some Javascript In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 26793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26793&action=edit Bug 11227 - Staff po files contain some Javascript This patch rewrites authorities_js.inc so translate script process it correctly. To that I add at the file To test: 1) Update po files for your preffered language 2) Check occurrence of mergeAuth on staff PO file or try egrep -n "Merging with authority: |Cancel merge" strings appear in a JS func 3) Apply the patch 4) Update translations again, chech again, old strings now begin with #~ (obsoleted) and there are new entries for the messages 5) Check functionality provided by script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:25:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:25:07 +0000 Subject: [Koha-bugs] [Bug 11227] Staff po files contain some Javascript In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:26:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:26:07 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #35 from Paola Rossi --- IOO the error depended on the 3 lines of ./admin/authorised_values.pl: print "Content-Type: text/html ........... (165,195,227) because of the lack of charset="utf-8". Now the 165-th line appears so: 165 print "Content-Type: text/html; charset=\"utf-8\"...... We add charset="utf-8" in these 3 lines in our installation, and now everything's OK. Now the current category is correctly shown in the dropdown list, even if its name contains some UTF-8 chars. So now the dropdown list preselects the good value. The error appeared only with Firefox 28.0; it didn't appear with Explorer v.10 nor with Chrome v.33. With Zeno some lines like those are similar in others cgi. See f.i.: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:27:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:27:52 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type on staff detail (with xslt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #15 from M. de Rooy --- (In reply to Owen Leonard from comment #14) > If "Material type" is correct should it not be changed in all views? The > term "type" appears in OPAC search results, OPAC detail page, staff client > search results, and staff client detail page. Hm. I agree that it is at least inconsistent to not apply the same change to staff client results. I will resend this patch. Note that the non-XSLT view in staff does not include this same Type-line (in results and detail). As for OPAC, it might be different. Here we come into the discussion if a more precise wording in staff is still appropriate for the general public of the opac. (Similar example: should you say authority search in opac). Before doing that change, I would like some feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 15:33:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 13:33:15 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #36 from Jonathan Druart --- (In reply to Paola Rossi from comment #35) > IOO the error depended on the 3 lines of ./admin/authorised_values.pl: > > print "Content-Type: text/html ........... > > (165,195,227) > > because of the lack of charset="utf-8". Great! I am going to provide a followup for that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:11:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:11:48 +0000 Subject: [Koha-bugs] [Bug 12007] http://manual.koha-community.org/3.12/en/basicparams.html#authorizedvalues needs more info In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12007 --- Comment #1 from Nicole C. Engard --- I'm not 100% sure what you're going for here. I added this note: IMPORTANT: Note that items with locations already set on them will not be altered. The branch limitation only limits the choosing of an authorized value based on the home branch of the current staff login. All authorized values for item records (LOC, LOST, CCODE, etc) will show in the OPAC for all patrons. Let me know if that's enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:13:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:13:55 +0000 Subject: [Koha-bugs] [Bug 12006] help.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12006 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|enhancement |normal --- Comment #1 from Nicole C. Engard --- This will be updated with the next release. Help files are editable by the libraries and as such we try not to edit them mid stream as it will overwrite local library changes. I will update the 3.16 help files before that release with this info. Thanks Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:14:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:14:04 +0000 Subject: [Koha-bugs] [Bug 12006] help.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12006 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:16:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:16:50 +0000 Subject: [Koha-bugs] [Bug 12006] authorized value help needs updating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12006 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|help.pl |authorized value help needs | |updating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:24:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:24:07 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:24:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:24:13 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #37 from Jonathan Druart --- Created attachment 26794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26794&action=edit Bug 11944: Some refresh don't indicate the charset to use This patch replaces occurrences of META HTTP-EQUIV=Refresh with a redirection. Note: The list of modified files has been got with the following grep: git grep Content-Type | grep -v -i utf | grep Refresh | grep -v translator | grep -v \.js Test plan: 1) admin/auth_tag_structure.pl - Go on an authority MARC framework for an authority type (admin/auth_tag_structure.pl?authtypecode=CO for instance) - Click on the "Add a new tag" button - Fill fields - Save - You should be redirected on the auth_tag_structure.pl page - Try to modify an existing tag - The redirection should be done 2) admin/auth_subfields_structure.pl - From the previous page, click on a "subfields" link - Edit/Add a new subfields - Save - You should be redirected to the subfield list - Delete a subfield - You should be redirected to the subfield list 3) admin/authorised_values.pl - Add/Edit an authorised value - Save - You should be redirected to the authorised value list (with the right category selected) 4) admin/categorie.pl - Add/Edit a patron category - Save - You should be redirected to the category list - Delete a patron category - You should be redirected to the category list 5) admin/koha2marclinks.pl - Go on the Koha to MARC mapping configuration page - Edit a field - Map a field and click on "OK" - You should be redirected to the list 6) admin/marc_subfields_structure.pl - Go on the MARC frameworks page - Click on "MARC structure" for one on the list - Click on "Subfields" for one on the list - Add/Edit a subfield - Save - You should be redirected to the subfield list 7) admin/systempreferences.pl - Go on the system preferences admin page - Click on the "Local use" tab - Add/Edit a pref - Save - You shold be redirected to the Local use preference list 8) serials/subscription-detail.pl - Go on a subscription detail page - Delete the subscription (using Edit > Delete subscription) - You should be redirected on the serials home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:25:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:25:29 +0000 Subject: [Koha-bugs] [Bug 11993] Untranslatable confirm popup in request.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:25:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:25:34 +0000 Subject: [Koha-bugs] [Bug 11993] Untranslatable confirm popup in request.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 --- Comment #2 from Owen Leonard --- Created attachment 26795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26795&action=edit [SIGNED-OFF] Bug 11993 - Untranslatable confirm popup in request.tt This patch makes confirm popup text translatable. It implements a similar function as used on OPAC deleteConfirm() and a JS var message. This funcion, or variants, can also be found on other files on intranet, I think that the only valid places are staff-global.js and help-top.inc Redefinitions of this function: prog/en/modules/serials/subscription-frequencies.tt:6 prog/en/modules/tools/marc_modification_templates.tt:158 prog/en/modules/virtualshelves/shelves.tt:92 Last case is a little different To test: 1) Confirm that the "cancel hold" link correctly prompts for confirmation: a) Place an item-level hold on a title. b) Check in the item and confirm the hold. c) Return to the place hold screen for that title and submit another patron to place a hold for. d) On the place hold screen for that patron, look at the table of items. There should be a "cancel hold" link next to the item for which the hold was confirmed in step (b). e) Click "cancel hold." You should see a confirmation message. Cancelling this dialog should cancel the operation. Confirming it should cancel the hold. 2) Check the string is not present on staff PO file 3) Apply the patch 4) Update translation files (cd misc/translator; perl translate update xx-YY) 5) Verify the string is now present Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:25:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:25:55 +0000 Subject: [Koha-bugs] [Bug 12007] http://manual.koha-community.org/3.12/en/basicparams.html#authorizedvalues needs more info In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12007 --- Comment #2 from Christopher Brannon --- Yes, I think that should do. I was just seeing a gap of information. One might assume that if you limit a library from using a shelving location, you would no longer see that location in use by that library, but it needed to be more clear that it doesn't affect records that are already using that location. Thanks. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:33:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:33:56 +0000 Subject: [Koha-bugs] [Bug 11993] Untranslatable confirm popup in request.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 --- Comment #3 from Bernardo Gonzalez Kriegel --- Thank you Owen! First patch can be obsoleted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:36:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:36:06 +0000 Subject: [Koha-bugs] [Bug 11993] Untranslatable confirm popup in request.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26620|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Comment on attachment 26620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26620 Bug 11993 - Untranslatable confirm popup in request.tt Sorry, I thought git-bz had marked the old patch as obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:50:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:50:33 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #12 from Owen Leonard --- > It seems that mixings.css and sco-old.css are not used. > Maybe should we remove them too? opac-old.css and sco-old.css are unwanted byproducts of my development process and should not have been committed. They should be removed. responsive.css and mixins.css are byproducts of the automatic LESS build process and should not be added (they are currently not in git). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:52:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:52:31 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #9 from Olli-Antti Kivilahti --- Created attachment 26796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26796&action=edit Bug 11676 - Loading shelving locations based on stuff. For acquisitions. Found out that there is another way of adding items, which has a different mechanism (datatables yay) of addition, so this feature enables shelving location updating in the newordere Centralized the shelving location fetching code (to koha-to-marc-mapping-api.js) to have a central place to share related features. ------------- - TEST PLAN - ------------- Same as in the first patch, but this time use the neworderempty.pl-script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:59:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:59:21 +0000 Subject: [Koha-bugs] [Bug 11993] Untranslatable confirm popup in request.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 16:59:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 14:59:28 +0000 Subject: [Koha-bugs] [Bug 11993] Untranslatable confirm popup in request.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26795|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 26797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26797&action=edit Bug 11993 - Untranslatable confirm popup in request.tt This patch makes confirm popup text translatable. It implements a similar function as used on OPAC deleteConfirm() and a JS var message. This funcion, or variants, can also be found on other files on intranet, I think that the only valid places are staff-global.js and help-top.inc Redefinitions of this function: prog/en/modules/serials/subscription-frequencies.tt:6 prog/en/modules/tools/marc_modification_templates.tt:158 prog/en/modules/virtualshelves/shelves.tt:92 Last case is a little different To test: 1) Confirm that the "cancel hold" link correctly prompts for confirmation: a) Place an item-level hold on a title. b) Check in the item and confirm the hold. c) Return to the place hold screen for that title and submit another patron to place a hold for. d) On the place hold screen for that patron, look at the table of items. There should be a "cancel hold" link next to the item for which the hold was confirmed in step (b). e) Click "cancel hold." You should see a confirmation message. Cancelling this dialog should cancel the operation. Confirming it should cancel the hold. 2) Check the string is not present on staff PO file 3) Apply the patch 4) Update translation files (cd misc/translator; perl translate update xx-YY) 5) Verify the string is now present Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 17:00:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 15:00:25 +0000 Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying and unexpected way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26785|0 |1 is obsolete| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 17:26:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 15:26:17 +0000 Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 17:33:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 15:33:59 +0000 Subject: [Koha-bugs] [Bug 11993] Untranslatable confirm popup in request.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 17:43:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 15:43:26 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 18:34:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 16:34:36 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22850|0 |1 is obsolete| | --- Comment #2 from mathieu saby --- Created attachment 26798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26798&action=edit [PATCH] Bug 11230 - Refactor C4::Stats::UpdateStats and add UT fix trailing whitespaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 18:34:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 16:34:53 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11230 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 18:34:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 16:34:53 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7021 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 18:35:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 16:35:47 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #13 from mathieu saby --- Before working on that, I would like bug 11230 to be tested. Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 18:37:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 16:37:08 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 --- Comment #3 from mathieu saby --- I think this bug should be tested before improving stats (bug 7021) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 18:38:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 16:38:06 +0000 Subject: [Koha-bugs] [Bug 11438] Add creation date and closing date to basketgroups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11438 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 19:33:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 17:33:44 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26789|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 26799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26799&action=edit [SIGNED OFF] Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client The staff client lists template contains a warning which differs from the same warning in the OPAC. The OPAC version is correct because it refers to a list rather than a shelf. This patch copies the OPAC version to the staff client template. This patch also corrects a few of other instances where the incorrect term "shelf" is used. To test, apply the patch and view a list in the staff client which is populated with items. Check the box next to one or more items on the list and click the "Remove selected" button. You should see the message, "Are you sure you want to remove these items from the list?" Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 19:34:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 17:34:08 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 19:42:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 17:42:56 +0000 Subject: [Koha-bugs] [Bug 11438] Add creation date and closing date to basketgroups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11438 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23797|0 |1 is obsolete| | --- Comment #4 from mathieu saby --- Created attachment 26800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26800&action=edit [PATCH] Bug 11438 - Add creation date and closing date to basketgroups REBASED This patch change the way Koha is dealing with closing basketgroups, taking as a model the way it deals with closing baskets. This improvement will serve as a base for further enh: - displaying the closing date in PDF instead of current date (this can be syspref-dependant) - usign the closing date for calculation of late orders, instead of closing date of the basket (this can be syspref-dependant) The patch provides 3 changes in in aqbasketgroups table structure: - The closing date is stored in bg_closedate column - The creation date is stored in bg_creationdate column - The closed column is removed When a basketgroup is open, or reopened, the closing date is set to NULL. I add a "bg_" prefix in column names to avoid all possible confusion between them and closedate/creationdate column in aqbaskets. Some changes are made to subs dealing with basketgroups in C4/Acquisition.pm. The 2 dates are displayed in basketgroup template - in lists of opened/closed basketgroups - in an individual basketgroup. updatedatabase.pl creates the 2 columns and removes closed column, but also populates the 2 new columns: - bg_creationdate with the most recent closing date of the baskets included in each basketgroup - bg_closingdate with NULL is the bg is open, or with the most recent closing date of the baskets included in each basketgroup You have 2 elements to test: - the behavior of Koha after the patch is applied - the changes made by updatedatabase.pl Plan test: (bg = basketgroup) 1. Before applying the patch, prepare some bgs : at least 1 open with 1 basket, 1 open with 2 baskets closed on different dates, 1 closed with 1 basket, 1 closed with 2 baskets closed on different dates 2. Apply the patch and run installer/data/mysql/updatedatabase.pl 3. Show the list of open and closed bg and check the creation dates are correct (it should be the most recent closing date of the baskets included in each basketgroup) 4. Check the open bg have no closing date 5. Check the closed bg have a closing date, which must be the same as the creation date 6. Click on "View" to display an individual closed bg : check you the same dates as in the list of bgs 7. Reopen the closed bg. Check it is actually reopened and displayed in "open" tab, with no value in "closing date" column 8. Click on "Edit" to edit an individual open bg : check you the same creation date as in the list of bgs, and no closing date 9. Make some changes to this bg, and Save it without closing it 10. Check the changes were actually saved, and that the bg is still in "Open" tab, with no value in "closing date column" 11. Edit again the bg 12. Make some changes, but this time, check "Close basket group" box at the bottom of the form before Saving it 13. Check the changes were actually saved, and that the bg is now in "Closed" tab, with the today date in "closing date" column 14. Click on "New basketgroup" to create a new bg 15. Check no date at all is displayed in the creation form. 16. Give it a name, and Save it without closing it 17. Check the bg has been created, and is displayed in "Open" tab, with today date in "creation date" column, and no value in "closing date" 18. Click on "New basketgroup" to create an other new bg 19. Give it a name, but this time, check "Close basket group" box at the bottom of the form before Saving it 20. Check the bg has been created, and is displayed in "Open" tab, with today date in "creation date" column, and no value in "closing date" 23. In basket pages, Close an open basket, and ask to create a new bg with the same name 24. Check in bg page that a new closed bg with the same name as the closed basket has been created 25. In basket pages, Close basket without creating a bg, then put this basket in an open bg, using the "change group" dropdown menu 26. Check in bg page that the basket is now included in the bg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 19:43:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 17:43:08 +0000 Subject: [Koha-bugs] [Bug 11438] Add creation date and closing date to basketgroups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11438 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 19:44:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 17:44:03 +0000 Subject: [Koha-bugs] [Bug 11438] Add creation date and closing date to basketgroups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11438 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P4 |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 20:08:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 18:08:53 +0000 Subject: [Koha-bugs] [Bug 11487] Untranslatable tooltip "Dates of birth should be entered in the format ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |bgkriegel at gmail.com Resolution|--- |FIXED --- Comment #9 from Bernardo Gonzalez Kriegel --- This problem was fixed in Bug 11753 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 21:21:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 19:21:32 +0000 Subject: [Koha-bugs] [Bug 11497] i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 26801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26801&action=edit Bug 11497 - i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation i18n toolchain fails to pick text defined inside [% ... %] This patch fixes all the cases I could find To test: 1. Update your preferred language (cd misc/translator; perl translate update fi-FI) 2. Count headers for example egrep "^msgid.*Koha online" misc/translator/po/fi-FI-* | wc -l 3. Apply the patch 4. Repeat 1 and 2, now there are more lines Or translate to som lang and visit every touched page and look the title -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 21:22:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 19:22:00 +0000 Subject: [Koha-bugs] [Bug 11497] i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 21:24:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 19:24:34 +0000 Subject: [Koha-bugs] [Bug 11497] i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 22:37:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 20:37:26 +0000 Subject: [Koha-bugs] [Bug 11289] sticky due date is always active In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11289 Jackson Public Library changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |jacksonpubliclibrary at gmail. | |com --- Comment #1 from Jackson Public Library --- This appears to be the same issue as "Bug 10391 - specify due date remaining even if not selected". We too were having trouble when using this feature to checkout ILLs to patrons. It was "sticking" and carrying over to next patrons without our having selected the box which says "remember for session". We found we had to log out of Koha alltogether to get it to unstick. Even using the clear box didn't seem to unstick it. But today I quickly tested it and now it seems to be working. I've asked my staff to start trying to check out ILLs using that due date to see if it consistently works. We were running 3.10 when we noticed it and did a ticket to Bywater for it. They said it was a bug. I just did a webinar with Nicole Engard and asked her about the bug's status and she showed me how to login and comment on bugs myself. Maybe it was fixed in the the 3.12 upgrade? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 23:06:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 21:06:26 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Liz Rea --- This patch fixes the problem for package users, and makes it no worse for other users. I request reconsideration. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 23:16:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 21:16:57 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26778|0 |1 is obsolete| | --- Comment #4 from Liz Rea --- Created attachment 26802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26802&action=edit Bug 12031 - Task Scheduler not sending mail At some stage the runreport.pl cronjob was changed to accept longopts, but the scheduler script wasn't changed along with it. This patch fixes the mismatch. To test: 1. make sure that your user is not in at.deny, and (if applicable/necessary) is in at.allow 1.5 test this on a package install, sending mails will still not work for git installs, even with this patch. Useful, but not required step: make sure email can be sent from your server, also helpful is access to the Koha user's mail box (to see the bounce messages) 2. create a saved sql report to run 3. Go to Tools -> Task Scheduler and schedule a job to be run, and results emailed to you 4. note that you do not (without the patch) get an email. Make a note of the command it reports it is going to run. 5. apply the patch 6. schedule another job, you will notice that the command to run the scheduled job is slightly changed compared to the one in step 4. 7. Receiving an email when your job runs means the patch worked. Seeing --format= and --to= in the command also means the patch worked, as this is the command that runreport.pl is expecting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 23:18:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 21:18:49 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I think as this patch doesn't actually change the path, but fix the options, we could have this is as a first step to more improvements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 23:19:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 21:19:23 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #6 from Galen Charlton --- (In reply to Liz Rea from comment #3) > This patch fixes the problem for package users, and makes it no worse for > other users. > > I request reconsideration. Done. Mark, your comment 2 is too brief -- brief enough to not be comprehensible, frankly. As an incremental improvement is acceptable until such time that somebody steps up to provide a better scheduler, I've removed the dependency on bug 1993 as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 23:19:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 21:19:30 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12031 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 23:19:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 21:19:30 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|1993 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 23:52:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 21:52:08 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11224 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 23:52:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 21:52:08 +0000 Subject: [Koha-bugs] [Bug 11224] C4::Acquisition need more UT, and more robust ones. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11224 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10758 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 3 23:52:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 21:52:59 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #32 from mathieu saby --- Bug 11224 is pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 00:34:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 22:34:08 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- (In reply to Liz Rea from comment #3) > This patch fixes the problem for package users, and makes it no worse for > other users. > > I request reconsideration. > > Liz I'm confused about how it would fix the problem for package users :(. When I check my package install, there is no "tools/runreports.pl" either, so I'm not sure how it could work. Does Catalyst add in the script for its packages or maybe adds a symlink? If this patch fixes the problem for package users, but makes it no worse for other users...what happens when a patch fixes the problem for non-package users but breaks it for package users? I'm not opposed to this patch, but I am a bit...bewildered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 00:42:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 22:42:20 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #8 from Liz Rea --- Now that is actually legitimate - I hadn't noticed that there is in fact a symlink on that system, and it does actually need to be changed for this to work - so I'll fix that too. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 00:42:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 22:42:42 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 00:49:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 22:49:22 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #11 from Robin Sheat --- (In reply to Jacek Ablewicz from comment #10) > 1/ In AddAuthorisedValue() there is a call to > flush_cache('AddAuthorisedValue') instead of > flush_cache('GetAuthorisedValue') - probably irrelevant. Doh! But not the source of this issue. > 2/ There are some Memoize and Memoize::Expire bugs reported in CPAN, perl > monks etc. which are still unresolved since last available version (1.03) > was published, e.g.: http://www.perlmonks.org/index.pl?node_id=1049426 . Yeah, that's a bit fishy. > 3/ I'm wondering if memoizing GetAuthorisedValue is such a good idea in the > persistent environment.. Same thing for any subroutines which return > references of any kind - unless we are 100% sure than the result data > structures are always used in strictly read-only mode. Looks like it's not a > case for GetAuthorisedValue(): it returns reference to array of hashrefs, Well, it's something that gets called a lot so we need some optimisation. Really what should happen is that you ask for all the authorised values in a category, and then use the result of that for the rest of your scope. However I don't plan on refactoring that right now :) What I'll do instead is make some simple caching functions, including the ability to a deep copy to avoid the need for a structure to never be modified. This is something that'll come up more and more with plack. I'd still expect it to be faster than a bazillion database requests, and it'll be safe enough with persistence (and can be extended to use memcache in the future should that be considered worthwhile.) Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 00:53:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 22:53:12 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #12 from Robin Sheat --- > What I'll do instead is make some simple caching functions, including the > ability to a deep copy to avoid the need for a structure to never be ...Or allow Koha::Cache to do this sort of thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 01:00:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 23:00:53 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 01:00:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 23:00:57 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #9 from Liz Rea --- Created attachment 26803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26803&action=edit Bug 12031 - Task Scheduler not sending mail At some stage the runreport.pl cronjob was changed to accept longopts, but the scheduler script wasn't changed along with it. This patch fixes the mismatch. To test: 1. make sure that your user is not in at.deny, and (if applicable/necessary) is in at.allow 1.5 test this on a package install, sending mails will still not work for git installs, even with this patch. Useful, but not required step: make sure email can be sent from your server, also helpful is access to the Koha user's mail box (to see the bounce messages) 2. create a saved sql report to run 3. Go to Tools -> Task Scheduler and schedule a job to be run, and results emailed to you 4. note that you do not (without the patch) get an email. Make a note of the command it reports it is going to run. 5. apply the patch 6. schedule another job, you will notice that the command to run the scheduled job is slightly changed compared to the one in step 4. 7. Receiving an email when your job runs means the patch worked. Seeing --format= and --to= in the command also means the patch worked, as this is the command that runreport.pl is expecting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 01:04:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 23:04:31 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 01:16:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 23:16:44 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25979|0 |1 is obsolete| | Attachment #26002|0 |1 is obsolete| | Attachment #26017|0 |1 is obsolete| | Attachment #26129|0 |1 is obsolete| | --- Comment #40 from Jesse Weaver --- Created attachment 26804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26804&action=edit Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC This adds a new page to the OPAC that can search several Z39.50 targets using Pazpar2. Test plan: 1) Apply patches. 2) Update database. 3) Add one or more Z39.50 targets, using the Administration -> External targets screen. Note that not all targets support keyword search, but here are some that do: * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8 * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8 4) Perform a search on the OPAC, check to see if the "external targets" notice pops up at the top. 5) Click on the results link near that message. 6) This should bring back results from all enabled targets, all of which should be clickable to bring up a detailed view of the record. (This version incorporates previous QA followups and some fixes for translation and per-branch-limiting.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 01:16:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 23:16:51 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 01:48:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Apr 2014 23:48:52 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #10 from M. Tompsett --- (In reply to Galen Charlton from comment #6) > Mark, your comment 2 is too brief -- brief enough to not be comprehensible, > frankly. Oops... $ cd /usr/share/koha $ find . | grep runreport ./bin/cronjobs/runreport.pl ./man/man3/misc::cronjobs::runreport.3pm $ cd ~/kohaclone $ find . | grep runreport ./misc/cronjobs/runreport.pl The idea I was getting at was captured in the third patch which is currently obsoleted. Though, perhaps FindBin logic should be added? > As an incremental improvement is acceptable until such time that > somebody steps up to provide a better scheduler, I've removed the dependency > on bug 1993 as well. Did I put it as a depends? I meant to put it as a See Also, because bug 1993 is related. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 04:07:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 02:07:10 +0000 Subject: [Koha-bugs] [Bug 5052] Can't choose languages if all choices are sublanguages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5052 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 04:07:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 02:07:59 +0000 Subject: [Koha-bugs] [Bug 5052] Can't choose languages if all choices are sublanguages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5052 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 26805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26805&action=edit Bug 5052 - Can't choose languages if all choices are sublanguage This was tricky to catch. In current implementation, Bug 6755 introduced in C4/Templates.pm as condition to send the array of hashrefs of languages that (@$languages_loop<2), but with one language group that condition is false, there is only one element in that array. This patch changes that condition to have more than one language selected, grouped or not. Also send $bidi value always, that was only sent if there is more than one group language. To test: 1. Translate to en-GB and en-NZ, or simply do mkdirs on intranet-tmpl/prog and opac-tmpl/bootstrap 2. Go to Administration > System preferences > I18N enable those languages on staff/opac 3. Check that language chooser is nowhere to be found 4. Apply the patch 5. Reload staff/opac, now you can see language chooser NOTE: I made little changes on staff, but can't replicate bootstrap colors for selected/unselected language. Someone need to touch css files to make it happen. But that is current behavior. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 04:10:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 02:10:08 +0000 Subject: [Koha-bugs] [Bug 5052] Can't choose languages if all choices are sublanguages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5052 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 04:36:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 02:36:15 +0000 Subject: [Koha-bugs] [Bug 12007] http://manual.koha-community.org/3.12/en/basicparams.html#authorizedvalues needs more info In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12007 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 07:54:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 05:54:25 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Just wondering - couldn't you set the default itemtype in the acq framework? I think I have set that up for some libraries in the past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 07:58:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 05:58:46 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type on staff detail (with xslt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #16 from Katrin Fischer --- I think material type would work for me in OPAC too. It's more specific than type and easier to translate for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 09:48:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 07:48:46 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |magnus at enger.priv.no --- Comment #13 from Magnus Enger --- $ git bz apply 11759 Bug 11759 - Batch checkout 25255 - Bug 11759: Batch checkout - prepare the ground 25256 - Bug 11759: Batch checkout - Add the new template 25257 - Bug 11759: Add links to the new page 25258 - Bug 11759: Add some css to highlight warnings and errors 25260 - Bug 11759: Batch checkout - DB changes 26455 - Bug 11759: (follow-up) Prevent access to the batch checkout if not allowed Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11759: Batch checkout - prepare the ground Applying: Bug 11759: Batch checkout - Add the new template fatal: sha1 information is lacking or useless (circ/circulation.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11759: Batch checkout - Add the new template The copy of the patch that failed is found in: /home/magnus/scripts/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11759-Batch-checkout---Add-the-new-template-tEAbBf.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:04:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:04:44 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:04:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:04:47 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25255|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 26806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26806&action=edit Bug 11759: Batch checkout - prepare the ground This patch does not introduce any changes. It prepares the circulation script to accept several barcodes in parameter. A loop is done on all barcodes (until now, only 1) to generate a structure to sent to the template. At the end, only the first generated data is sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:04:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:04:52 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25256|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 26807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26807&action=edit Bug 11759: Batch checkout - Add the new template This patch is the main patch. It adds: - the new template circ/circulation_batch_checkouts.tt - the change into circ/circulation.pl === Why this feature is useful for some libraries? === Currently Koha does not allow to checkout several items at once to a user. This can cause a waste of time when a user want to checkout more than 10 items. This development has been asked to have statistics on in-house use. Every night, a librarian will enter a barcode list (from a file or a scanner : the librarian scans the barcode of the documents that users let on the tables). Barcodes will be added to a statistics patron in order to count the number of items consulted. The development has been expanded to cover another need: some special libraries (BDP for "Bibliotheque departementale de pret": "Loan Regional Library"). These libraries loan items to smaller libraries (municipal). The number of items could be very important and the current way offered by Koha is not adequate. === Test plan === 0/ Apply all patches and execute the DB change entry. 1/ Verify you are abble to do some checkouts (with confirmations, errors). = Statistics way = 2/ Create a statistical patron (e.g. category code STATS). 3/ Update the batch_checkouts pref with the category code (STATS). 4/ Go on the member page and verify the new "Batch check out" tab appears (and only for this user). 5/ Check some items out on the new page using the textarea or a file. 6/ Verify the table contains the item's information and the "Information" column contains "Local use recorded". = Real checkouts = 7/ Create a non statistical patron and update the pref. 8/ Check some items out on the new page using the textarea or a file. 9/ Verify the information in the table is consistent. 10/ Verify item without confirmation needed or impossible alert is checked out. 11/ If the logged in user has the "force_checkout" permission, all checkouts with a "confirmation needed" message can be done. If the logged in user does not have it, there is no way to force the checkout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:04:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:04:57 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25257|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 26808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26808&action=edit Bug 11759: Add links to the new page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:05:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:05:02 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25258|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 26809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26809&action=edit Bug 11759: Add some css to highlight warnings and errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:05:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:05:12 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26455|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 26811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26811&action=edit Bug 11759: (follow-up) Prevent access to the batch checkout if not allowed If a user pass '&batch=1' to the url, he was allowed to access to the batch checkout page even if the patron is not in an authorised category. This patch also fixes the link to "Batch check out" from the "Details" tab (cf changes in circ-menu.inc). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:05:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:05:07 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25260|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 26810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26810&action=edit Bug 11759: Batch checkout - DB changes Add the new pref batch_checkouts in DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:49:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:49:41 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:49:44 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 --- Comment #3 from Jonathan Druart --- Created attachment 26812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26812&action=edit Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client The staff client lists template contains a warning which differs from the same warning in the OPAC. The OPAC version is correct because it refers to a list rather than a shelf. This patch copies the OPAC version to the staff client template. This patch also corrects a few of other instances where the incorrect term "shelf" is used. To test, apply the patch and view a list in the staff client which is populated with items. Check the box next to one or more items on the list and click the "Remove selected" button. You should see the message, "Are you sure you want to remove these items from the list?" Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:49:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:49:55 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26799|0 |1 is obsolete| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 10:59:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 08:59:15 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #20 from Magnus Enger --- Created attachment 26813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26813&action=edit Message says "The hold will be canceled." Just a question: If I include an item with a (item level) hold in the batch, I get the attached message, which says: "This Item has been on hold for another patron. The hold will be canceled." But when I click on the "Checkout or renew" button, the hold is not actually cancelled, just overridden so the item can be issued to the current patron. Is the hold really ment to be cancelled? I think it would work if the message was something like: "This item is on hold for another patron. The hold will be overridden, but not cancelled." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 11:00:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 09:00:46 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #21 from Magnus Enger --- And let me just add that everything else seems to be working fine so far, and I think this will be a very good enhancement, speeding up the checkout process a lot! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 12:01:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 10:01:48 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #22 from Jonathan Druart --- Created attachment 26814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26814&action=edit Bug 11759: FIX cancel the hold after the checkout If an item is on hold, it will be cancelled after the checkout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 12:01:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 10:01:54 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #23 from Jonathan Druart --- Created attachment 26815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26815&action=edit Bug 11759: FIX Javascript error The following JS error occurred: ReferenceError: MSG_ADD_MESSAGE is not defined The circulation.js file is useless and should not be included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 12:02:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 10:02:42 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #24 from Jonathan Druart --- (In reply to Magnus Enger from comment #20) Thanks for testing Magnus! > If I include an item with a (item level) hold in the batch, I get the > attached message, which says: > > "This Item has been on hold for another patron. The hold will be canceled." Yes, it is the expected behavior. I provided a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 12:09:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 10:09:58 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #38 from Jacek Ablewicz --- Regarding problem described in comment #13 (this issue is not yet fixed in current version): it seems to be caused by / related to '|url' TT filter usage. In OPAC prog theme facets links are not affected; difference being that includes/opac-facets.inc in prog is using (a lot of) |html instead of |url. Problems with sorting criteria change/link not working are occurring in OPAC bootstrap & prog themes and in the staff searches too. Probably the same underlying cause. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 13:16:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 11:16:34 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22162|0 |1 is obsolete| | Attachment #22163|0 |1 is obsolete| | Attachment #22164|0 |1 is obsolete| | Attachment #22165|0 |1 is obsolete| | --- Comment #15 from Alex Sassmannshausen --- Created attachment 26816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26816&action=edit Bug 5670: Housebound Readers Module New module to handle management of circulation to Housebound readers. - Ability to record users as housebound (HB category), volunteers (combined deliverers and choosers, VOL category), deliverers (DELIV category) choosers (CHO category). - Ability to link users to individual delivery runs. - Ability to check on issuing to housebound users flagging if title has previously been issued to this user, to aid choosers. - 'Delivery Days' and 'Delivery Frequencies' are customizable through authorised values ('Day' and 'Frequency' categories respectively. Sponsored by Halton Borough Council * C4/Auth.pm: Add check: useHouseboundModule. * C4/Circulation.pm: use Housebound to check for previous issue. * koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add Housebound menu if appropriate. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: add 'previous checkout' warning. * C4/Housebound.pm: new. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: new. * koha-tmpl/intranet-tmpl/prog/en/modules/members/houseboundedit.tt: new. * koha-tmpl/intranet-tmpl/prog/en/modules/members/houseboundinstances.tt: new. * members/housebound.pl: new. * members/houseboundedit.pl: new. * members/houseboundinstances.pl: new. * installer/data/mysql/atomicupdate/housebound_tables.sql: new. - create 'housebound', 'housebound_instance' tables, - create 'HB', 'VOL', 'DELIV', 'CHO' borrower categories, - create sample 'Day', 'Frequency' authorised values, - add 'useHouseboundModule', 'useHouseboundCheckPrevious' syspref. * t/Housebound.t: new. Test plan: - Apply patch. - Run atomic update script. - Optionally, run Unit Tests (t/Housebound.t) - Create at least 1 of each: 'HB', 'VOL', 'DELIV', 'CHO' borrower. - Optionally, add additional authorised values of 'Day' and 'Frequency' categories. - Verify 'useHouseboundModule' & 'useHouseboundCheckPrevious' sysprefs are on. - On the page of the 'HB' borrower, open the new 'Housebound' menu. - create housebound profile + ensure Day and Frequency values are from correct authorised values - create 'housebound instances' (deliveries) + ensure chooser/deliverer lists are populated with VOL, DELIV, CHO borrowers - edit the profile/instances. - delete the profile/instances. - For a borrower with a housebound profile, issue an item, then - return that item - attempt to re-issue that item (you should get a warning) - Switch off 'useHouseboundCheckPrevious', repeat last test - the warning should not appear - Switch off 'useHouseboundModule' - the Housebound menu should disappear - the issue warnings should no longer appear. Largely based on prior work from Mark Gavillet and Colin Campbell. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 13:18:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 11:18:26 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |alex.sassmannshausen at gmail. | |com --- Comment #16 from Alex Sassmannshausen --- Hello, We have now had some time to revise this patch series. The different patches are now replaced with one big patch, which includes unit tests and a polished version of this module. I believe this is ready for sign off and QA. Let me know if you have any queries. Best wishes, Alex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 14:27:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 12:27:13 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #11 from M. de Rooy --- (In reply to Katrin Fischer from comment #10) > Just wondering - couldn't you set the default itemtype in the acq framework? > I think I have set that up for some libraries in the past. Probably. But this report now focuses on the fund. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 14:41:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 12:41:13 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 15:32:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 13:32:27 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #24 from Olli-Antti Kivilahti --- Firstly two merge conflicts: (got it working tho) CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Cronjob seems to work as intended and is a welcome addition. The purpose of the items.new-column is unclear. I didn't manage to get it populated, even if the comments here say that the cronjob's purpose is to empty the new-column. Apparently the new-column is a field, but then again it is a flag, and in the CREATE TABLE directive it is a VARCHAR(32). It is also the (status == new). It is extremely confusing. Apparently we can use it as we want, but then shouldn't it be labeled as such. My suggestion, replace the new-column definition with this: CREATE TABLE... `system_note` VARCHAR(32) DEFAULT NULL, -- You can put whatever free-text information regarding this item here. This field is meant for local modifications only and should not be used in features intended for master ... ; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 15:49:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 13:49:32 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #39 from Paola Rossi --- (In reply to Jonathan Druart from comment #37) > Created attachment 26794 [details] [review] > Bug 11944: Some refresh don't indicate the charset to use > > This patch replaces occurrences of META HTTP-EQUIV=Refresh with a > redirection. > > Note: > The list of modified files has been got with the following grep: > git grep Content-Type | grep -v -i utf | grep Refresh | grep -v translator > | grep -v \.js > > Test plan: [...] All the 8 tests are OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 16:25:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 14:25:13 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24146|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 26817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26817&action=edit Bug 11023: Toggle "new" status This patch adds: - a new DB field items.new. - a new page to configure this new status (tools/toggle_new_status.pl). - a new cronjob script (misc/cronjob/toggle_new_status.pl). Why this status is useful for some libraries ? The use cases are: - to know easily what are the new items (with a simple sql query). - to display an icon in the search results. - issuing rules can be adapt for new items. Automatically (using the cronjob script), the status change (depending the configuration) and the item can be issued, for example. - a RSS/Atom feeds can be created on these new items. Test plan: - log in with a librarian having the tools > items_batchmod permission. - navigate to Home > Tools > Toggle new status - click on the edit button - there are 3 "blocks": * duration: the duration during an item is considered as new. * conditions: the status will change only if the conditions are meet. * substitutions: if there is no substitution, no action will be done. You can add some change to apply to the matching items. E.g. ccode=3 new='' If the value is an empty string (in other words, the input does not contain anything), the field will be deleted. You can create as many rules as you want. - test the interface : add/remove rule, conditions, substitutions, submit the form, edit, etc. (There is a looot of JS everywhere, so certainly a looot of bugs...). - when you have your rules defined, you can now launch the cronjob script without any parameter. A report will be displayed with the matching itemnumber and the substitutions to apply. Verify results are consistent. - launch the script with the -c argument and verify values have been modified depending the substitution rules. Signed-off-by: juliette et r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 16:25:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 14:25:17 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24147|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 26818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26818&action=edit Bug 11023: Add the ability to specify fields from biblioitems table. Test plan: Same as before but try with fields from the biblioitems table. Signed-off-by: juliette et r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 16:25:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 14:25:22 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24148|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 26819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26819&action=edit Bug 11023: Add UT for C4::Items::ToggleNewStatus Test plan: prove t/db_dependent/Items/ToggleNewStatus.t Signed-off-by: juliette et r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 16:25:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 14:25:26 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25767|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 26820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26820&action=edit Bug 11023: FIX - condition on biblioitems table does not work If a rule contains a condition on the biblioitems table, the match won't work. This patch fixes this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 16:25:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 14:25:31 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25833|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 26821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26821&action=edit Bug 11023: Use DBIx-Class to retrieve column names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 16:25:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 14:25:35 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #30 from Jonathan Druart --- Created attachment 26822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26822&action=edit Bug 11023: Update DB field description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 16:26:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 14:26:26 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #31 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #24) I disagree, this field is created to manage a "new" status, so I think "new" is a good name :) I provided a followup to change the description. Last patches have been rebased against master. Thank you for testing Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 16:30:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 14:30:15 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #32 from Olli-Antti Kivilahti --- We can agree to that :) Good work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 17:00:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 15:00:11 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 17:08:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 15:08:27 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename type to material |Rename type to material |type on staff detail (with |type |xslt) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 17:08:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 15:08:59 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26787|0 |1 is obsolete| | --- Comment #17 from M. de Rooy --- Created attachment 26823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26823&action=edit Bug 9075: Rename type to material type on staff XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Test plan: Enable XSLT on staff detail/results. Check if you see the new label on catalogue detail/results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 17:16:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 15:16:09 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 17:16:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 15:16:12 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #18 from M. de Rooy --- Created attachment 26824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26824&action=edit Bug 9075: Rename type to material type on OPAC XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Test plan: Enable XSLT on OPAC detail/results. Check if you see the new label on OPAC detail/results (bootstrap, prog). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 17:18:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 15:18:14 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #19 from M. de Rooy --- Note that both patches only deal with xslt views; the non-xslt views do not have a similar Type-display. Also note that the code in the various xslt files for determining material type should probably be moved into a shared function. I might open up a new report for that one.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 17:32:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 15:32:43 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 17:48:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 15:48:40 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 19:23:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 17:23:46 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26823|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 26825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26825&action=edit [SIGNED OFF] Bug 9075: Rename type to material type on staff XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Revised Test Plan ----------------- 1) Set the Staff system preference XSLTDetailsDisplay to 'default' and save. 2) Set the Staff system preference XSLTResultsDisplay to 'default' and save. 3) Click 'Search the catalog' tab in the search area. 4) Search for something 5) Look for a biblio that has 942$c set to some type. -- It should display "Type:" Or take a result and modify it to have a 942$c. 6) Look at the biblio details -- It should also display "Type:" 7) Apply the patch 8) Search for the same biblio again. -- It should display "Material type:" this time. 9) Look at the biblio details -- It should display "Material type:" this time. 10) Run the koha qa test tool. Signed-off-by: Mark Tompsett Note: This is a simple string substitution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 19:39:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 17:39:57 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 19:40:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 17:40:00 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26824|0 |1 is obsolete| | --- Comment #21 from M. Tompsett --- Created attachment 26826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26826&action=edit [SIGNED OFF] Bug 9075: Rename type to material type on OPAC XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Revised Test Plan ----------------- 1) In the staff client, set the OPAC system preference OPACXSLTDetailsDisplay to 'default' and save. 2) In the staff client, set the OPAC system preference OPACXSLTResultsDisplay to 'default' and save. 3) In the staff client, set the OPAC system preference opacthemes to 'bootstrap' and save. 4) In the OPAC, search for biblio used in previous patch testing. -- It should display "Type:" 6) Look at the biblio details -- It should also display "Type:" 7) In the staff client, set the OPAC system preference opacthemes to 'prog' and save. 8) In the OPAC, search for biblio used in previous patch testing. -- It should display "Type:" 9) Look at the biblio details -- It should also display "Type:" 10) Apply the patch 11) In the staff client, set the OPAC system preference opacthemes to 'bootstrap' and save. 12) In the OPAC, search for biblio used in previous patch testing. -- It should display "Material type:" this time. 13) Look at the biblio details -- It should display "Material type:" this time. 14) In the staff client, set the OPAC system preference opacthemes to 'prog' and save. 15) In the OPAC, search for biblio used in previous patch testing. -- It should display "Material type:" this time. 16) Look at the biblio details -- It should display "Material type:" this time. 17) Run the koha qa test tool. Signed-off-by: Mark Tompsett Note: Just a simple string change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 19:50:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 17:50:18 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #32 from M. Tompsett --- And now patch doesn't apply. Side comment: I personally don't like splitting the if condition on an assignment to the next line, because one may accidentally think you forgot a semi-colon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 19:55:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 17:55:47 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14415|0 |1 is obsolete| | --- Comment #24 from M. Tompsett --- Created attachment 26827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26827&action=edit [SIGNED OFF] Bug 8244: Add PPI to the list of Perl dependencies Signed-off-by: Kyle M Hall NOTE: rebased to master only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 20:07:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 18:07:46 +0000 Subject: [Koha-bugs] [Bug 7867] Same text for username/login in OPAC and intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #4 from M. Tompsett --- Created attachment 26828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26828&action=edit Bug 7867 - Same text for username/login in OPAC and intranet This patch corrects the bootstrap login modal to have the 'Username:' instead of 'Login:' text. Test Plan --------- 1) In the staff client, set the OPAC system preference opacthemes to 'bootstrap'. 2) Open the OPAC 3) Click the 'Log in to your account' link. -- It should say 'Login:'. 4) Click 'Cancel' 5) Apply the patch 6) Refresh the OPAC page 7) Click the 'Log in to your account' link. -- It should say 'Username:'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 20:20:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 18:20:21 +0000 Subject: [Koha-bugs] [Bug 7867] Same text for username/login in OPAC and intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- I'm running through the Failed QA's trying to see if there is anything I can rescue. I don't understand why this failed QA though. Did the 'Click here' say 'login' before? 'Log in' as an action link or button seems fine. The label for the text box, however, should be consistent. This patch believes it should be 'Username'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 20:41:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 18:41:37 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 20:59:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 18:59:43 +0000 Subject: [Koha-bugs] [Bug 11798] Problems with column sorting and row visibility in invoices table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Suzanne Fayle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 4 21:03:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 19:03:39 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Suzanne Fayle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 00:24:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 22:24:08 +0000 Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- I am not seeing this problem in the 3.15 master in sandboxes or in 3.12.10. Can you tell us what browser and Koha version you are using? Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 00:56:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Apr 2014 22:56:27 +0000 Subject: [Koha-bugs] [Bug 11201] List pending in-house uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- Tried applying this patch in a sandbox and got this message: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11201:

Something went wrong !

Applying: Bug 11201: Add a in-house use list pages fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11201: Add a in-house use list pages When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11201 - List pending in-house uses 22718 - Bug 11201: Add a in-house use list pages Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11201-Add-a-in-house-use-list-pages-69ntjD.patch . Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 02:11:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 00:11:45 +0000 Subject: [Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 02:12:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 00:12:14 +0000 Subject: [Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 26829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26829&action=edit Bug 11508 - Untranslatable pull-down in auth_subfields_structure.pl OMG!!, this file is full of tabs and CGI::scrolling_list !!! This patch fix the reported strings and also another one. It removes 2 occurrences of CGI::scrolling_list with untranslatable labels. Fixed capitalization. To test 1. Go to Administration > Authority types, click 'MARC structure' of any auth type, click 'subfields' for any Tag >= 010, clic 'Edit subfields' Check pulldowns 'Manged in tab' and 'Select to display or not' 2. Apply the patch 3. Reload and verify functionality of both pulldowns 4. Check that strings are not present on staff PO file egrep "^msgid \"(Show all|Hide all|ignore)" misc/translator/po/fi-FI-i-staff-t-prog-v-3006000.po 5. Update language file (cd misc/translator/; perl translate update fi-FI) 6. Check that strings are now present, repeat 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 02:18:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 00:18:53 +0000 Subject: [Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 03:54:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 01:54:18 +0000 Subject: [Koha-bugs] [Bug 12037] New: MARC21 authority editor: can't edit/add 'Koha field' to auth subfield Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12037 Bug ID: 12037 Summary: MARC21 authority editor: can't edit/add 'Koha field' to auth subfield Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org Go to Administration > Authority types Click MARC structure of any framework, For tag 001 or 942, click subfields. Both have one subfield linked to some Koha field, but this value can't be changed. If you press Edit, 001 shows a dual edition screen and 942 only one, but neither shows an option to change Koha field. The data is sent to the template, as an scalar value in former screen, and as an CGI::scrolling_list output on editor (admin/auth_subfields_structure.pl) But template file (auth_subfields_structure.tt) does not have the code to show the corresponding pulldown. Don't know if this is a design decision, if yes some code could be removed from pl file, if no some code is needed on tt file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 09:43:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 07:43:23 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #25 from Katrin Fischer --- Hm I think I agree with Magnus here. I am not sure cancelling the hold makes sense - why not just check it out to the other patron, but leave the hold intact so the other patron can get the book later? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 09:47:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 07:47:57 +0000 Subject: [Koha-bugs] [Bug 7867] Same text for username/login in OPAC and intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I am not sure about username, as it might look like only the username works in the field, but we also have the option to use the cardnumber for logging in. So I thought login was not bad there, but maybe someone else has a good idea? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 11:26:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 09:26:09 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22106|0 |1 is obsolete| | --- Comment #33 from mathieu saby --- Created attachment 26830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26830&action=edit [PATCH 1/2] Bug 10758 - Show bibliographic information of deleted records in acquisitions No more dependancy Fully testable, but a second patch will be provided for fixing and improving the UTs Aim of the patch : when a record is deleted but used in an order, display information stored in deletedbiblio and deletedbiblioitems tables on some pages of acquisition module Note that this patch will only have real effects for records deleted AFTER its application. Changes : - modification of database structure : new column "deletedbiblionumber" in aqorders We keep the constraint between aqorders.biblionumber and biblio.biblionumber, but we create a new one between aqorders.deletedbiblionumber and deletedbiblio.biblionumber With this system, we can make a JOIN between aqorders and deleted(biblio/biblioitems) table, and retreive information. - modification of GetOrder, GetOrders, GetCancelledOrders and SearchOrders in C4::Acquisition : Those subs are now also getting bibliographic information from deleted tables deletedbiblio and deletedbiblioitems Only usefull or potentially usefull fields are retreived (no more biblio.* and biblioitems.*) For each field, I used COALESCE in SQL query. Ex: COALESCE (biblio.title,deletedbiblio.title) AS title - modification of DelBiblio in C4::Biblio Wen a record is deleted with DelBiblio, the sub checks if it used in an order If so, the biblionumber is deleted from aqorders.biblionumber (as before), but it is copied to aqorder.deletedbiblionumber - modification of files in acqui : basket.pl, neworderempty.pl To transmit the new key "deletedbiblionumber" to the templates - modification of templates in intranet/module/acqui : basket.tt, histsearch.tt, lateorders.tt, neworderempty.tt, parcel.tt Test plan : A. BEFORE applying the patch - create a basket with at least 4 orders,using different records - in the catalog, delete one of the record used by 1st order, whithout cancelling the order (there will be an alert, but you can do that) - return to the basket page (or refresh it) : the information about the record is lost - if you want, try to receive orders or to search orders : in those pages too the information for this record will be lost B. Apply the patch and run updatedatabase.pl C. Go back to your basket and refresh it - the information of the record deleted before the application of the patch is still lost ("Can't find title") - in the catalog, delete one of the record used by 2d order, whithout cancelling the order - return to the basket page (or refresh it) : the information about the record is still visible, with the mention (Deleted record) - Try to modify the 2d order : click on "Modifiy" on the right column of the table - you will get on neworderempty.pl, but with a message "(Deleted record, not editable)". You will be able to change accounting details but not bibliographic information (In a future development, we could imagine to recreate a record and in order to make the order editable even if the original record is deleted, but it would be dangerous to do so now) - in the basket, cancel the 3rd order AND the record (click on "Delete order and record") - in the "Cancelled orders", you still could see bibliographic information about the cancelled order, with the mention "(Deleted record)" D. Go on late orders page - check you can see information about 2d order (which is linked with a deleted record) E. Go on order advanced search page - fill the form with the title of 2d order and click on Search - check Koha can retreive the order, and show correct information F. Try to receive orders from the vendor used for your basket - in the filters on the left of the page which displays the table of pending orders, search the title of the 2d order - Koha should retreive the 2d order - you must have a mention "Deleted record, order cannot be received" above the title - you must not have a link "Receive" on the left of the table (In a future development, we could imagine to recreate a record to do the receipt, but it would be dangerous to do so now. The best to do if a record was deleted and the order not yet received is probably to cancel the order, and to recreate it by hand) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 11:26:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 09:26:25 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 11:26:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 09:26:41 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10869 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 11:26:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 09:26:41 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10758 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 11:27:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 09:27:16 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #34 from mathieu saby --- I'm working on UT, but you can already test. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 15:48:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 13:48:42 +0000 Subject: [Koha-bugs] [Bug 7867] Same text for username/login in OPAC and intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #7 from M. Tompsett --- Created attachment 26831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26831&action=edit Bug 7867: Staff and OPAC login areas lack consistency This patch: - Changes the Staff client's login area text from "Username:" into "Login:", since login is more generic than username. - Adds a tool tip to the staff client's login area 'Login:' textbox: "Please enter your username or card number." - Adds a tool tip to the main OPAC screen's login area 'Login:' textbox using the bootstrap theme: "Please enter your username or card number." - Adds a tool tip to the main OPAC screen's login area 'Login:' textbox using the prog theme: "Please enter your username or card number." - Adds a tool tip to the OPAC screen triggered by clicking the 'Log in to your account' link in the top right using the bootstrap theme: "Please enter your username or card number." - Adds a tool tip to the OPAC screen triggered by clicking the 'Log in to your account' link in the top right using the bootstrap theme: "Please enter your username or card number." NOTE: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt was modified similarly as well, though I don't think it can be triggered, since the modal login screen of bootstrap is triggered by the 'Log in to your account' link, and it no longer goes to page it did before. The page still exists by going there by pasting in the known URL. TEST PLAN --------- 1) Go to staff client. 2) Log in and change the OPAC system preference opacthemes to 'bootstrap'. 3) Logout. 4) Go to OPAC in a different tab. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 5) Click the 'Log in to your account' link in the top right. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 6) Go to http://YOUROPAC/cgi-bin/koha/opac-user.pl -- notice staff client's "Username:" differs from the OPAC's "Login" text. 7) Log in to the staff client and change the OPAC system preference opacthemes to 'prog'. 8) Logout 9) In the OPAC tab, reload the page. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 10) Click the icon in the top left to return to the main Koha screen. -- notice staff client's "Username:" differs from the OPAC's "Login" text. 11) Apply the patch 12) Repeat steps 1-10 again. -- The textbox associated with the login should have a tooltip: "Please enter your username or card number." 13) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 15:49:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 13:49:28 +0000 Subject: [Koha-bugs] [Bug 7867] Staff and OPAC areas lack consistency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Same text for |Staff and OPAC areas lack |username/login in OPAC and |consistency |intranet | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 15:56:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 13:56:43 +0000 Subject: [Koha-bugs] [Bug 7867] Staff and OPAC areas lack consistency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #8 from M. Tompsett --- I have attached a 3rd patch, which is a counter patch to the first two patches. That is, they change the Staff client to 'Login' and add an explanatory tooltip to the text boxes where you are expected to enter either a username or card number. Based on Katrin Fischer's comment 6, I think my counter patch would acceptable. I do agree that login is more generic than username. If the latter one is acceptable for QA purposes, please obsolete the first two (the one I signed off [2.17KB] and the one I added for bootstrap [2.08KB]). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 17:07:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 15:07:26 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #35 from mathieu saby --- Created attachment 26832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26832&action=edit [PATCH 2/2] Bug 10758 - Fix Acquisition unit tests This patch fixes Acquisition UT Maybe more work could be done to write specific UT for testing the new features introduced by bug 10758 To test : prove -v t/db_dependant/Acquisition.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 17:10:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 15:10:30 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 19:36:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 17:36:07 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #26 from Magnus Enger --- Created attachment 26833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26833&action=edit Checking out a book with a hold for another patron Item X is on the shelf, but also on hold for Patron A. Patron B finds it on the shelf and takes it to the checkout desk. The librarian is given the option to check the book out to Patron B or not, and optionally to delete the hold for Patron A. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 19:46:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 17:46:18 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26522|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 26834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26834&action=edit Bug 11631 - Followup to extend pattern This followup extendes and compile the pattern. Moved to proper place To test: Same procedure as signed patch Ammended patch, change description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 19:51:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 17:51:08 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Magnus Enger --- With the new patch series, holds for other patrons are cancelled/deleted when a book is checked out with batch checkout. This is the opposite behaviour of the "normal" checkout (see attachment 26833 and comment 26). I think the default has to be to keep the holds, but possibly with an *option* to delete them, like in the "normal" checkout. Marking as "failed QA". Jonathan: Can you try and explain why you think the holds should be deleted? I hope we can resolve this quickly, I'd love to see this in 3.16! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 20:49:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 18:49:00 +0000 Subject: [Koha-bugs] [Bug 12038] New: Need a provision to search specific barcode/accession number Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12038 Bug ID: 12038 Summary: Need a provision to search specific barcode/accession number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org Librarians need to search and find specific book using barcode. In present situation, advanced search has the provision to search barcode, it give a big list of books instead of single book. I think koha search barcode from xml, so it display a big list of books. We need to get details of specific book from advanced search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 20:58:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 18:58:03 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #40 from Jacek Ablewicz --- So here and there we uri-escape some strings twice (mostly various search query parts, plus some more): - directly, by uri_escape_utf8() followed by '|url' or '|uri' TT filter, - indirectly, by using already uri-escaped string in which will trigger 2nd uri-escape in browser The other way around, they are uri-unescaped twice too: first in CGI.pm and 2nd time directly by using uri_unescape in Search.pm etc. (including some places when they rather shouldn't; funny things might happen when searching for something with '%' in it..). But what's more important, delayed 2nd uri_unescape() would prevent those strings from being promoted to 'wide character' despite CGI qw(-utf8). This terribly dirty fix seems to resolve both problems mentioned in comment #13 (in OPAC search; staff search may need another one): diff --git a/opac/opac-search.pl b/opac/opac-search.pl index 7a35085..db0545e 100755 --- a/opac/opac-search.pl +++ b/opac/opac-search.pl @@ -387,7 +387,8 @@ if ($indexes[0] && !$indexes[1]) { } # an operand can be a single term, a phrase, or a complete ccl query my @operands = $cgi->param('q'); - at operands = map { uri_unescape($_) } @operands; +## Not a proper fix, just proof-of-concept!! + at operands = map { /%[a-f\d]{2}/i? Encode::decode('UTF-8', uri_unescape($_)): $_; } @operands; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 5 23:03:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Apr 2014 21:03:25 +0000 Subject: [Koha-bugs] [Bug 7867] Staff and OPAC areas lack consistency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 06:38:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 04:38:39 +0000 Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26756|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 26835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26835&action=edit [SIGNED OFF] Bug 12024 - Add to list opens the list adding UI in two windows In Item details, when using the menu toolbar for Add To > List, the list adding UI opens in a popup window, and also in the original window. The original window should stay showing the item details page. Signed-off-by: Bernardo Gonzalez Kriegel Works fixing problem. No koha-qa errors. Test: 1. On staff, go to detail of some biblio, click add to List, described behavior 2. With patch applied, origina windows stay on item detail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 06:39:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 04:39:00 +0000 Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 06:44:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 04:44:46 +0000 Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024 --- Comment #3 from Bernardo Gonzalez Kriegel --- Well, for me the problem occurs on Chrome/Opera, not Fireforx (Win) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 13:50:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 11:50:52 +0000 Subject: [Koha-bugs] [Bug 11780] Need to prevent specific fields from being overwritten with z39.50 import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11780 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 14:07:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 12:07:42 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 --- Comment #19 from Katrin Fischer --- I can't test LDAP currently, can someone else take on QA here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 16:08:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 14:08:07 +0000 Subject: [Koha-bugs] [Bug 11984] Show number of item(s) on order in the catalogue holdings without having to create item records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11984 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- I think bug 11169 could be what you are looking for. *** This bug has been marked as a duplicate of bug 11169 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 16:08:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 14:08:07 +0000 Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imingchan at yahoo.com.au --- Comment #19 from Katrin Fischer --- *** Bug 11984 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 19:54:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 17:54:50 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #120 from Katrin Fischer --- Back to this... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:10:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:10:26 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #121 from Katrin Fischer --- Created attachment 26836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26836&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall Signed-off-by: Melia Meggs Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:10:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:10:34 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #122 from Katrin Fischer --- Created attachment 26837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26837&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:10:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:10:39 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #123 from Katrin Fischer --- Created attachment 26838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26838&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:10:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:10:45 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #124 from Katrin Fischer --- Created attachment 26839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26839&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces "opac actions such as placing a hold or reserve" by "opac actions such as placing holds or renrw books" - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo "categori" and syspref name case Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:10:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:10:51 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #125 from Katrin Fischer --- Created attachment 26840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26840&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening

instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : instead of , maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. => Verified all actions work as expected. => Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) => OK, both actions are blocked. b) category: use syspref (default) syspref: don't block => OK, both actions possible. c) category: block syspref: don't block => OK, both actions are blocked. d) category: block syspref: block => OK, both actions are blocked. e) category: don't block sypref: block => OK, both actions possible. Signed-off-by: Katrin Fischer 2014-04-06 Update: Will repeat and amend above test plan on last patch in this series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:10:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:10:56 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #126 from Katrin Fischer --- Created attachment 26841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26841&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: "you account" - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization "Don't Block" in system preference description. - Adding . to the end of the warning, when renewals are blocked. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:11:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:11:02 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #127 from Katrin Fischer --- Created attachment 26842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26842&action=edit [PASSED QA] Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:11:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:11:09 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #128 from Katrin Fischer --- Created attachment 26843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26843&action=edit [PASSED QA] Bug 6739: Template changes for the bootstrap theme Signed-off-by: Katrin Fischer Passes QA script, t, xt and t/db_dependent/Members*. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default! * Ran database update succesfully. * Note: Expired patrons are now blocked by default in new AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. => Verified all actions work as expected. => Verified chosen value for BlockExpiredPatronOpacActions is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block f) category: don't block syspref: don't block Holds and renewals were always possible. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Verified holds and renewals are still blocked, when the user has a restriction with a date in the future. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) Holds and renewals blocked. b) category: use syspref (default) syspref: don't block Holds an renewals possible. c) category: block syspref: don't block Holds and renewals blocked. d) category: block syspref: block Holds and renewals blocked. e) category: don't block sypref: block Holds and renewals possible. f) category: don't block syspref: don't block Holds and renewals possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:11:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:11:49 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:11:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:11:53 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26546|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:11:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:11:57 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:12:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:12:01 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26548|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:12:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:12:06 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26549|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:12:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:12:19 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26550|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:12:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:12:23 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26551|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:12:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:12:28 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26552|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:12:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:12:32 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26553|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:13:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:13:20 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #129 from Katrin Fischer --- There are a few more things to note: - Changing the existing behaviour by activating the feature by default might be debatable. I am going to leave this as it is and it could be changed easily if we get some opionions on this before release. - The changes to GetMemberDetails are currently not covered by unit tests. All existing tests in for Members* pass, so I am going to pass this on the condition, that we get some more to cover the changes. Enhancements: - Show the new value on the patron category summary table - Show the new field when deleting a patron category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:31:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:31:15 +0000 Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying and unexpected way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:31:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:31:18 +0000 Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying and unexpected way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26792|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 26844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26844&action=edit [PASSED QA] Bug 12032 - TinyMCE rewrites urls in a very annoying and unexpected way To test: * create a news item with a link in it that is within the same domain example: my koha was at http://demo.mykoha.co.nz, I created a link in a news item to http://demo-intra.mykoha.co.nz * note that when the item is saved, the url changes to ../../../../ (or something like) * apply the patch * edit the link again, and save it * note that the link is saved correctly Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:42:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:42:37 +0000 Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 22:42:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 20:42:40 +0000 Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26835|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 26845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26845&action=edit [PASSED QA] Bug 12024 - Add to list opens the list adding UI in two windows In Item details, when using the menu toolbar for Add To > List, the list adding UI opens in a popup window, and also in the original window. The original window should stay showing the item details page. Signed-off-by: Bernardo Gonzalez Kriegel Works fixing problem. No koha-qa errors. Test: 1. On staff, go to detail of some biblio, click add to List, described behavior 2. With patch applied, origina windows stay on item detail Signed-off-by: Katrin Fischer Confirmed problem in Chromium/Ubuntu. Patch passes all tests and QA script, works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 23:07:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 21:07:51 +0000 Subject: [Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 6 23:07:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 21:07:54 +0000 Subject: [Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26314|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 26846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26846&action=edit [PASSED QA] Bug 11850: [SIGNED-OFF] Adds a -append option to add data to the logfile Signed-off-by: Magnus Enger Keeps current behaviour as default. The -append option is described in the POD and works as expected. Signed-off-by: Katrin Fischer Works as described. Adding a date/time to the output might be good, to make it easier to find the entry you were looking for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 00:00:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 22:00:59 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 00:01:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 22:01:04 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #11 from Liz Rea --- Created attachment 26847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26847&action=edit Bug 12031 - Task scheduler not sending mail At some stage the runreport.pl cronjob was changed to accept longopts, but the scheduler script wasn't changed along with it. This patch fixes the mismatch and also corrects some path issues created by Debian packaging/Standard installs vs git installs Note: This patch makes it so that email sending is supported by default for package and standard debian tarball installs. For everyone else, if you specify a configuration option pointing to where your cronjobs are kept, in the form of /path/to/koha/misc task scheduling will be working in your install. Example: My runreports.pl is in /home/liz/koha-src/koha/misc/cronjobs my would be as follows: /home/liz/koha-src/koha/misc To test: 1. make sure that your user is not in at.deny, and (if applicable/necessary) is in at.allow 1a. set up your if required for your test installation type. Useful, but not required step: make sure email can be sent from your server, also helpful is access to the Koha user's mail box (to see the bounce messages) 2. create a saved sql report to run (handy tip, if you schedule them a few days away you can see all of your tasks listed with the command used to invoke the job for comparison) 3. Go to Tools -> Task Scheduler and schedule a job to be run, and results emailed to you 4. note that you do not (without the patch) get an email. Make a note of the command it reports it is going to run. 5. apply the patch 6. schedule another job, you will notice that the command to run the scheduled job is slightly changed compared to the one in step 4. 7. Receiving an email when your job runs means the patch worked. Seeing --format= and --to= in the command also means the patch worked, as this is the command that runreport.pl is expecting. 8. add (or remove) your directive from your koha-conf.xml, schedule another task, note how the command is changed yet again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 00:06:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 22:06:29 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #12 from Liz Rea --- Should probably add that the config option belongs in koha-conf.xml in the section. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 00:12:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 22:12:00 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 00:21:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 22:21:25 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 00:57:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 22:57:40 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 00:57:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Apr 2014 22:57:43 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 --- Comment #3 from Liz Rea --- Created attachment 26848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26848&action=edit bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user To test: In both prog and bootstrap: * Enable Amazon images in the system preferences * Issue a book you know will have images for, verify that without SSL 1. the images show on the borrower's logged in home page (opac-user, both checkouts and overdue tab) and on the opac-readingrecord 2. the image source is from an Amazon url that uses http:// 3. the images are the right size, and look ok * Do the same using https, verify that with SSL 1. the images show on the borrower's logged in home page (opac-user, both checkouts and overdue tab) and on the opac-readingrecord 2. the image source is from an Amazon url that uses https:// 3. the images are the right size, and look ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 03:42:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 01:42:36 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #13 from M. Tompsett --- Comment on attachment 26847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26847 Bug 12031 - Task scheduler not sending mail Review of attachment 26847: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12031&attachment=26847) ----------------------------------------------------------------- ::: tools/scheduler.pl @@ +35,5 @@ > > my $input = new CGI; > +my $base; > + > +if ( C4::Context::->config('supportdir') ) { ::-> ?! Nope. Should be just ->. I'm seeing if I can generate a patch with your name on it that fixes this. I have a sha1 hash issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 03:46:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 01:46:20 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26847|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 03:46:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 01:46:33 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #14 from Liz Rea --- Don't bother I'll fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 03:49:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 01:49:33 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #15 from Liz Rea --- Created attachment 26849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26849&action=edit Bug 12031 - Task Scheduler not sending mail At some stage the runreport.pl cronjob was changed to accept longopts, but the scheduler script wasn't changed along with it. This patch fixes the mismatch. To test: 1. make sure that your user is not in at.deny, and (if applicable/necessary) is in at.allow 1.5 test this on a package install, sending mails will still not work for git installs, even with this patch. Useful, but not required step: make sure email can be sent from your server, also helpful is access to the Koha user's mail box (to see the bounce messages) 2. create a saved sql report to run 3. Go to Tools -> Task Scheduler and schedule a job to be run, and results emailed to you 4. note that you do not (without the patch) get an email. Make a note of the command it reports it is going to run. 5. apply the patch 6. schedule another job, you will notice that the command to run the scheduled job is slightly changed compared to the one in step 4. 7. Receiving an email when your job runs means the patch worked. Seeing --format= and --to= in the command also means the patch worked, as this is the command that runreport.pl is expecting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 03:49:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 01:49:30 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 03:51:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 01:51:40 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26849|0 |1 is obsolete| | --- Comment #16 from Liz Rea --- Created attachment 26850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26850&action=edit Bug 12031 - Task scheduler not sending mail At some stage the runreport.pl cronjob was changed to accept longopts, but the scheduler script wasn't changed along with it. This patch fixes the mismatch and also corrects some path issues created by Debian packaging/Standard installs vs git installs Note: This patch makes it so that email sending is supported by default for package and standard debian tarball installs. For everyone else, if you specify a configuration option pointing to where your cronjobs are kept, in the form of /path/to/koha/misc task scheduling will be working in your install. Example: My runreports.pl is in /home/liz/koha-src/koha/misc/cronjobs my would be as follows: /home/liz/koha-src/koha/misc To test: 1. make sure that your user is not in at.deny, and (if applicable/necessary) is in at.allow 1a. set up your if required for your test installation type. Useful, but not required step: make sure email can be sent from your server, also helpful is access to the Koha user's mail box (to see the bounce messages) 2. create a saved sql report to run (handy tip, if you schedule them a few days away you can see all of your tasks listed with the command used to invoke the job for comparison) 3. Go to Tools -> Task Scheduler and schedule a job to be run, and results emailed to you 4. note that you do not (without the patch) get an email. Make a note of the command it reports it is going to run. 5. apply the patch 6. schedule another job, you will notice that the command to run the scheduled job is slightly changed compared to the one in step 4. 7. Receiving an email when your job runs means the patch worked. Seeing --format= and --to= in the command also means the patch worked, as this is the command that runreport.pl is expecting. 8. add (or remove) your directive from your koha-conf.xml, schedule another task, note how the command is changed yet again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 04:00:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 02:00:50 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 04:00:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 02:00:53 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26850|0 |1 is obsolete| | --- Comment #17 from M. Tompsett --- Created attachment 26851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26851&action=edit [SIGNED OFF] Bug 12031 - Task Scheduler not sending mail At some stage the runreport.pl cronjob was changed to accept longopts, but the scheduler script wasn't changed along with it. This patch fixes the mismatch. To test: 1. make sure that your user is not in at.deny, and (if applicable/necessary) is in at.allow 1.5 test this on a package install, sending mails will still not work for git installs, even with this patch. Useful, but not required step: make sure email can be sent from your server, also helpful is access to the Koha user's mail box (to see the bounce messages) 2. create a saved sql report to run 3. Go to Tools -> Task Scheduler and schedule a job to be run, and results emailed to you 4. note that you do not (without the patch) get an email. Make a note of the command it reports it is going to run. 5. apply the patch 6. schedule another job, you will notice that the command to run the scheduled job is slightly changed compared to the one in step 4. 7. Receiving an email when your job runs means the patch worked. Seeing --format= and --to= in the command also means the patch worked, as this is the command that runreport.pl is expecting. 8. Run the koha QA test tool. Signed-off-by: Mark Tompsett NOTE: The line that changes is visible in the bottom section, "Jobs already entered", with the corrected parameters and path used. If you do not have the config parameter set up in koha-conf.xml, it defaults to the typical package path. If you have the parameter set up, the path given matches what you tell it. Only tested in git. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 04:08:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 02:08:43 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #18 from Liz Rea --- The commit message is a bit wrong on the signed off version - that's my fault I noticed it but Mark had already gotten to it before I uploaded a corrected commit message. Anyway, attachment 26850 has the correct commit message if anyone really feels it bears getting a new signoff. The content of the patch is the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 05:28:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 03:28:00 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 05:28:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 03:28:04 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26848|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 26852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26852&action=edit [SIGNED OFF] bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user To test: 0) It goes without saying that images being looked at should continue to be the proper size and look ok. 1) In the staff client, change the OPAC system preference opacthemes to 'bootstrap'. 2) Enable Amazon images in the system preferences 3) Issue a book you know will have images for a known user 4) Issue a book you know will have images for intentionally overdue for the same user 5) git reset --hard origin/master 6) In OPAC, log in as the user. -- On the 'your summary' tab on the left (which is default), a) In the 'Checked out' tab, there should be at least two books. The two books issued should have http images. b) In the 'Overdue' tag, there should be at least one book. The image for the overdue book issued should have http images. 7) Click the 'your reading history' tab on the left. -- The images for the two books issued should have http images. 8) Apply the patch 9) Repeat steps 6-7, but all the images in question should have https images now. 10) In the staff client, change the OPAC system preference opacthemes to 'prog'. 11) Repeat steps 5-9 12) Run the koha QA test tool Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 05:37:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 03:37:42 +0000 Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #9 from M. Tompsett --- (In reply to paxed from comment #8) > (In reply to M. Tompsett from comment #7) > > Created attachment 26773 [details] [review] [review] > > Bug 11885 - Follow-up to address issues raised > > > > This patch addresses them in the following way: > > 1/ ... > > Why hard-coded tags? Isn't there some good reason to separate > presentation and content? Because that is the way it was done before. I'm not saying it was the best way to do it, but it reduces visible differences. > > 2/ ... > > Wrap the dash and the spaces before the description in class="dashwrapper"> or something, so it'll be easier to hide with css. Sure, why not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 05:49:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 03:49:36 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 05:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 03:49:44 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 06:42:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 04:42:38 +0000 Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26773|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 26853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26853&action=edit Bug 11885 - Follow-up to address issues raised Jonathan Druart raised the following three issues: 1/ subtags was bold before patch 2/ 1 dash existed between tag and tag name 3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet nom commun", "101 ## - Langue" becomes "101 # # Langue") This patch addresses them in the following way: 1/ You will note that @ was not bold on the 0 tab. Every other tab were bold. By making the similar template into a procedure based on the 0XX tab, bolding was lost. This patch bolds all subtags including the @, so that the visible change is minimized. 2/ The dash was programmatically added in at the code stage previously. This bug fix splits the the single concatenation mess into parts which can be styled. This puts the dash back into the template. However, it should be noted that the spacing for the 0 tab's tag and tag description will have an extra space after the hypen that was lacking before. 3/ ...... is different than ... ... The later puts that extra space. This patch fixes that. See comment 1 for the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 09:29:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 07:29:16 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #33 from Jonathan Druart --- (In reply to M. Tompsett from comment #32) > And now patch doesn't apply. Fridolin, can you have a look please? fatal: sha1 information is lacking or useless (tools/picture-upload.pl). > Side comment: I personally don't like splitting the if condition on an > assignment to the next line, because one may accidentally think you forgot a > semi-colon. The file has been formatted using perltidy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 09:35:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 07:35:43 +0000 Subject: [Koha-bugs] [Bug 11201] List pending in-house uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Jonathan Druart --- (In reply to Christopher Brannon from comment #2) > Tried applying this patch in a sandbox and got this message: This patch depends on bug 10859 and bug 10860. You must apply them before applying this one. That cannot be done with a sandbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 09:47:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 07:47:40 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #28 from Jonathan Druart --- (In reply to Magnus Enger from comment #27) > Jonathan: Can you try and explain why you think the holds should be deleted? > I hope we can resolve this quickly, I'd love to see this in 3.16! No, you are right, we should apply the default behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 09:49:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 07:49:41 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 09:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 07:49:44 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26814|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 26854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26854&action=edit Bug 11759: FIX the alert message if an item is on hold. If an item is on hold, the hold is not cancelled. This patch corrects the message displayed in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 10:10:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 08:10:06 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #33 from paxed --- (In reply to Jonathan Druart from comment #30) > Created attachment 26822 [details] [review] > Bug 11023: Update DB field description Typo: "indented" should be "intended" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 10:29:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 08:29:18 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26822|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 26855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26855&action=edit Bug 11023: Update DB field description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 13:02:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 11:02:17 +0000 Subject: [Koha-bugs] [Bug 12039] New: Typo in ReservesMaxPickUpDelayCharge description Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12039 Bug ID: 12039 Summary: Typo in ReservesMaxPickUpDelayCharge description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com ExpireReservesMaxPickUpDelayCharge description says: 'If ExpireReservesMaxPickUpDelay is enabled, and this field has a non-zero value, than a borrower whose waiting hold has expired will be charged this amount.' Typo: "than" should be "then" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 14:38:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 12:38:38 +0000 Subject: [Koha-bugs] [Bug 10581] Authority search: no results should not display as 404 error page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10581 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 14:43:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 12:43:10 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #41 from Paola Rossi --- New-ing or updating a patron, a password like this one: ?provo causes the error: Software error: input must contain only octets at /usr/lib/perl5/Crypt/Eksblowfish/Bcrypt.pm line 84. For help, please send mail to the webmaster (webmaster at linux-test), giving this error message and the time and date of the error. Against master, the error doesn't appear. NB. From Koha devel, from M.de.Rooy at rijksmuseum.nl: Quoting from a previous try to get UTF8- moving, report 9951: [[ A nice one to start with: opac-password.pl: The password may contain diacritics. It should be decoded. But this needs a dive into C4/Auth.pm also (and probably in staff too). And we still have the problem with old incorrect hashes in the table. If you would have an old password with diacritics, you would still like to login. This is not just adding a flag to CGI, but a report on its own. So I leave that for now; these hashes still work ]] How would you suggest to resolve the old passwords given that Koha and used perl libs would encode/decode properly ? No reason not to support it, but it needs some more thought.. ----------------------------------------------------------------- So I pass the status to "Failed QA". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 14:59:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 12:59:04 +0000 Subject: [Koha-bugs] [Bug 11978] OverDrive API now prepends http:// to URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 14:59:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 12:59:08 +0000 Subject: [Koha-bugs] [Bug 11978] OverDrive API now prepends http:// to URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26497|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 26856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26856&action=edit [SIGNED-OFF] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. Signed-off-by: Owen Leonard I can reproduce the problem and confirm that this patch fixes it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 15:15:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 13:15:08 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #13 from Marjorie Barry-Vila --- (In reply to Jonathan Druart from comment #12) > (In reply to Marjorie Barry-Vila from comment #11) > > I defined an owner for the fund but for me it is the same on acquisition > > home page, i can see funds of the other branches and of the other owners. > > I should see only the budgets that I am an owner, right? > > We need to change something in the drop down menu restrictions? > > Could you confirm the issue still appears with these patches? Hi Jonathan, I tested it on a sandbox but it is not working for me. I think it's me I do something wrong. I added an owner, a library and a restriction to only owner and i can still see fund of the other library. I changed flags too but without results. See the video attached, maybe you will see what i do wrong Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 15:18:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 13:18:47 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #14 from Marjorie Barry-Vila --- (In reply to Jonathan Druart from comment #12) > (In reply to Marjorie Barry-Vila from comment #11) > > I defined an owner for the fund but for me it is the same on acquisition > > home page, i can see funds of the other branches and of the other owners. > > I should see only the budgets that I am an owner, right? > > We need to change something in the drop down menu restrictions? > > Could you confirm the issue still appears with these patches? see the video here http://bit.ly/1mU7Hlt Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 15:21:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 13:21:17 +0000 Subject: [Koha-bugs] [Bug 11172] Reports need a clear filter button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11172 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 15:29:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 13:29:14 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #42 from Jacek Ablewicz --- (In reply to Paola Rossi from comment #41) > input must contain only octets at /usr/lib/perl5/Crypt/Eksblowfish/Bcrypt.pm > line 84. Hm, we can't realy expect Bcrypt to handle perl wide-characters reliably, those hashing algorithms were designed to deal with octets/bytes only.. In particular, if we want all hashes allready stored in the database still to work, the only reasonable solution IMO will be to hash passwords in utf-8 encoded form - and preferably to keep them in as much unaltered form as possible before hashing. Right now we get password params already decoded thanks to CGI qw( -utf8); I guess we can [re]encode them before hashing, but there is no guarantee result string will be allways the same after utf-8 encode(decode()). BTW, is there some way to fetch on demand a specific parameter from CGI.pm in non-decoded form, i.e. bypassing en effect of qw( -uft8)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:11:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:11:22 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26737|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart --- Created attachment 26857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26857&action=edit Bug 11944: Remove all utf8 filter from templates This patch - removes all html_entity usages in tt file which hide utf8 bugs - removes all encode utf8 in tt plugins because we should get correctly marked data from DBIC and other sources directly (cf plugin EncodeUTF8 used in renew.tt) - adds some cleanup in C4::Templates::output: we now use perl utf8 file handler output so we don't need to decode tt variables manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:11:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:11:29 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26738|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart --- Created attachment 26858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26858&action=edit Bug 11944: replace use of utf8 with Encode See the wiki page for the explanation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:11:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:11:34 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26739|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 26859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26859&action=edit Bug 11944: Encoding UTF8 in C4::Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:11:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:11:39 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26740|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart --- Created attachment 26860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26860&action=edit Bug 11944: Set ImplicitUnicode for YAML Before this patch, string for yaml files used in preferences.pl were broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:11:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:11:45 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26741|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart --- Created attachment 26861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26861&action=edit Bug 11944: use CGI( -utf8 ) everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:11:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:11:50 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26743|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart --- Created attachment 26862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26862&action=edit Bug 11944: Library name variable should be decoded Test on preferences.pl and on some others pages when mysql is used to store session. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:11:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:11:55 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26744|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart --- Created attachment 26863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26863&action=edit Bug 11944: replace uri_escape with uri_escape_utf8 everywhere To reproduce, edit, index notice with ?? and search "??" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:12:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:12:00 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26745|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart --- Created attachment 26864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26864&action=edit Bug 11944: Never use decode/encode in TT Plugins The EncodeUTF8 TT plugin is useless, we should NEVER use encode in templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:12:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:12:05 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26746|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart --- Created attachment 26865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26865&action=edit Bug 11944: Remove obsolete encoding routines We don't need to decode manually which provide nice performance boost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:12:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:12:10 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26747|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart --- Created attachment 26866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26866&action=edit Bug 11944: TT Plugins should not encode strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:12:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:12:15 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26794|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart --- Created attachment 26867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26867&action=edit Bug 11944: Some refresh don't indicate the charset to use This patch replaces occurrences of META HTTP-EQUIV=Refresh with a redirection. Note: The list of modified files has been got with the following grep: git grep Content-Type | grep -v -i utf | grep Refresh | grep -v translator | grep -v \.js Test plan: 1) admin/auth_tag_structure.pl - Go on an authority MARC framework for an authority type (admin/auth_tag_structure.pl?authtypecode=CO for instance) - Click on the "Add a new tag" button - Fill fields - Save - You should be redirected on the auth_tag_structure.pl page - Try to modify an existing tag - The redirection should be done 2) admin/auth_subfields_structure.pl - From the previous page, click on a "subfields" link - Edit/Add a new subfields - Save - You should be redirected to the subfield list - Delete a subfield - You should be redirected to the subfield list 3) admin/authorised_values.pl - Add/Edit an authorised value - Save - You should be redirected to the authorised value list (with the right category selected) 4) admin/categorie.pl - Add/Edit a patron category - Save - You should be redirected to the category list - Delete a patron category - You should be redirected to the category list 5) admin/koha2marclinks.pl - Go on the Koha to MARC mapping configuration page - Edit a field - Map a field and click on "OK" - You should be redirected to the list 6) admin/marc_subfields_structure.pl - Go on the MARC frameworks page - Click on "MARC structure" for one on the list - Click on "Subfields" for one on the list - Add/Edit a subfield - Save - You should be redirected to the subfield list 7) admin/systempreferences.pl - Go on the system preferences admin page - Click on the "Local use" tab - Add/Edit a pref - Save - You shold be redirected to the Local use preference list 8) serials/subscription-detail.pl - Go on a subscription detail page - Delete the subscription (using Edit > Delete subscription) - You should be redirected on the serials home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:12:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:12:25 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #55 from Jonathan Druart --- Created attachment 26869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26869&action=edit Bug 11944: Fix encoding issue on searching The search patch should fix non-latin character searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:12:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:12:20 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #54 from Jonathan Druart --- Created attachment 26868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26868&action=edit Bug 11944: FIX Error on editing an authority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:12:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:12:31 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #56 from Jonathan Druart --- Created attachment 26870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26870&action=edit Bug 11944: Facets and resort This patch should fix facets and resort encoding issues. Note: This patch will certainly break the search history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:12:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:12:36 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #57 from Jonathan Druart --- Created attachment 26871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26871&action=edit Bug 11944: Authentication The password should be encoded before hashing. Test plan: - Before applying the patch, create a user with a password "????" - apply patches - try to log in - change the password - log out - try to log in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:20:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:20:09 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #58 from Jonathan Druart --- (In reply to Paola Rossi from comment #41) > New-ing or updating a patron, a password like this one: > > ?provo > > causes the error: This should be fixed by patch "Bug 11944: Authentication" (In reply to Jacek Ablewicz from comment #40) It seems I managed to fix that in patch "Bug 11944: Facets and resort". But I'm not really sure... Last patch set fix some problems in previous patches: Encode::decode does not work on MARC::Record (of course!) Encode::decode returns the decoded value (and does not modify the variable passed in parameter). I don't reproduce the "importing" error any longer, it seems fixed. Please add known bugs on the wiki page: http://wiki.koha-community.org/wiki/Handling_UTF8_in_development#Known_bugs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:36:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:36:23 +0000 Subject: [Koha-bugs] [Bug 12040] New: Add STMP authentication parameters to runreports.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Bug ID: 12040 Summary: Add STMP authentication parameters to runreports.pl Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: cnighswonger at foundations.edu QA Contact: testopia at bugs.koha-community.org Created attachment 26872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26872&action=edit Patch to add auth params This patch adds three params to allow for SMTP authentication -username -> Username to pass to the SMTP server for authentication -password -> Password to pass to the SMTP server for authentication -method -> Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. See the misc/cronjobs/CONFIGURE.gmail for an example of the use of these params. I'm not quite sure how to approach constructing an automated test for this as any test will require a working SMTP account on a server requiring authentication. As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying "LOGIN" for the method. 5. Note the successful send. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:37:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:37:05 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |cnighswonger at foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:45:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:45:08 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:46:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:46:14 +0000 Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying and unexpected way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:47:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:47:33 +0000 Subject: [Koha-bugs] [Bug 12024] Add to list opens the list adding UI in two windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12024 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Pasi! This appears to be the first patch of yours that has been accepted into Koha master. Congratulations! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:48:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:48:17 +0000 Subject: [Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Matthias! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:48:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:48:31 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:52:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:52:04 +0000 Subject: [Koha-bugs] [Bug 10790] adding/editing item types screen mis aligned if noItemTypeImages not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:58:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:58:11 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26872|0 |1 is obsolete| | --- Comment #1 from Chris Nighswonger --- Comment on attachment 26872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26872 Patch to add auth params Yikes! Monday strikes again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 17:58:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 15:58:56 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 --- Comment #2 from Chris Nighswonger --- Created attachment 26873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26873&action=edit Patch to add auth params -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 18:18:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 16:18:46 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- This may overlap / cause rebase needs with bug 12031. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 18:40:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 16:40:14 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26873|0 |1 is obsolete| | --- Comment #4 from Chris Nighswonger --- Created attachment 26874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26874&action=edit Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 19:08:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 17:08:05 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 19:08:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 17:08:08 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26874|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 26875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26875&action=edit [SIGNED OFF] Bug 12040 - Add 3 parameters for SMTP authentication -username -> Username to pass to the SMTP server for authentication -password -> Password to pass to the SMTP server for authentication -method -> Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. Test Plan --------- As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying "LOGIN" for the method. 5. Note the successful send. Signed-off-by: Chris Nighswonger Signed-off-by: Mark Tompsett Note: My Mail/Sendmail.pm was in /usr/share/perl5/Mail/Sendmail.pm I tested the case with the patch applied, with and without expected parameters. The parameters don't exist before, so I don't see how to pass values for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 19:14:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 17:14:24 +0000 Subject: [Koha-bugs] [Bug 11883] News Editor Changing Koha URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11883 --- Comment #1 from Galen Charlton --- I think it likely that the patch for bug 12032 fixes this. Since that patch is in master, please test, and if I'm right, mark this bug as a duplicate of 12032. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 19:19:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 17:19:04 +0000 Subject: [Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 --- Comment #2 from M. Tompsett --- Comment on attachment 26559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26559 Bug 11995: Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl Review of attachment 26559: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11995&attachment=26559) ----------------------------------------------------------------- ::: misc/cronjobs/serialsUpdate.pl @@ +110,4 @@ > while ( my $issue = $sth->fetchrow_hashref ) { > > my $subscription = &GetSubscription( $issue->{subscriptionid} ); > + my $publisheddate = $issue->{publisheddate}; What is the difference between publisheddate and planneddate? This is the only thing holding me back from signing off. @@ +114,3 @@ > > + if ( $subscription && $publisheddate && $publisheddate ne "0000-00-00" ) { > + my $nextpublisheddate = GetNextDate( $subscription, $publisheddate ); Yikes! Swapping parameter order is kind of important in non-hashref parameter lists. Good thing you are fixing this. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 19:27:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 17:27:43 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 --- Comment #6 from Chris Nighswonger --- (In reply to M. Tompsett from comment #5) > expected parameters. The parameters don't exist before, so > I don't see how to pass values for them. Sorry. Running 'perldoc runreport.pl' should show them up along with all other available params. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 19:39:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 17:39:20 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26875|0 |1 is obsolete| | --- Comment #7 from Chris Nighswonger --- Created attachment 26876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26876&action=edit Fixup documentation of new params -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 20:00:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 18:00:28 +0000 Subject: [Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26876|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 26877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26877&action=edit [SIGNED OFF] Bug 12040 - Add 3 parameters for SMTP authentication -username -> Username to pass to the SMTP server for authentication -password -> Password to pass to the SMTP server for authentication -method -> Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. Test Plan --------- As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying "LOGIN" for the method. 5. Note the successful send. 6. perldoc misc/cronjobs/runreport.pl 7. Run the koha qa test tool. Signed-off-by: Chris Nighswonger Signed-off-by: Mark Tompsett Note: My Mail/Sendmail.pm was in /usr/share/perl5/Mail/Sendmail.pm I tested the case with the patch applied, with and without expected parameters. The parameters don't exist before, so I don't see how to pass values for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 20:18:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 18:18:15 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #114 from Galen Charlton --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 20:54:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 18:54:49 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #8 from M. Tompsett --- Comment on attachment 26621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26621 Bug 11998 - move most syspref db access into Context.pm Review of attachment 26621: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11998&attachment=26621) ----------------------------------------------------------------- ::: C4/Context.pm @@ +645,2 @@ > > + $value = 0 if ( $db_type && $db_type eq 'YesNo' && $value eq '' ); What if $value = undef? The eq check will blow up. Should it not be !$value instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:17:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:17:02 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #9 from M. Tompsett --- Comment on attachment 26714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26714 Bug 11998 - sysprefs in memcached Review of attachment 26714: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11998&attachment=26714) ----------------------------------------------------------------- ::: C4/Context.pm @@ +740,4 @@ > my $sth = $dbh->prepare("DELETE FROM systempreferences WHERE variable=?"); > my $res = $sth->execute($var); > if ($res) { > + C4::Context->set_preference($var, undef); Isn't this supposed to be a _cache_preference call? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:20:05 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #10 from M. Tompsett --- Comment on attachment 26717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26717 Bug 11998 - add test case, fix issue found Review of attachment 26717: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11998&attachment=26717) ----------------------------------------------------------------- ::: C4/Context.pm @@ +744,4 @@ > my $sth = $dbh->prepare("DELETE FROM systempreferences WHERE variable=?"); > my $res = $sth->execute($var); > if ($res) { > + _cache_preference($var, undef); Ah, there's the fix. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:42:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:42:44 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #186 from M. Tompsett --- Created attachment 26878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26878&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:43:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:43:04 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #187 from M. Tompsett --- Created attachment 26879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26879&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:43:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:43:14 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #188 from M. Tompsett --- Created attachment 26880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26880&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:43:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:43:23 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #189 from M. Tompsett --- Created attachment 26881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26881&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:43:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:43:34 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #190 from M. Tompsett --- Created attachment 26882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26882&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:43:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:43:42 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #191 from M. Tompsett --- Created attachment 26883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26883&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:43:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:43:49 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26424|0 |1 is obsolete| | --- Comment #192 from M. Tompsett --- Created attachment 26884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26884&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:44:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:44:28 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26418|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:44:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:44:42 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26419|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:44:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:44:58 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26420|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:45:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:45:13 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:45:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:45:42 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26422|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:46:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:46:15 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:48:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:48:38 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #193 from M. Tompsett --- Given that master has had things added to it. I rebased against master. The only thing that really needs sign off is the last patch (kohastructure.sql, jquery.js, refocus, and more). You can find a mega test plan in comment 175. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 21:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 19:50:06 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 22:00:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 20:00:36 +0000 Subject: [Koha-bugs] [Bug 11978] OverDrive API now prepends http:// to URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 22:00:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 20:00:39 +0000 Subject: [Koha-bugs] [Bug 11978] OverDrive API now prepends http:// to URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26856|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 26885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26885&action=edit [PASSED QA] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. Signed-off-by: Owen Leonard I can reproduce the problem and confirm that this patch fixes it. Signed-off-by: Katrin Fischer Patch removes hardcoded http:// from URLs in the Overdrive code. Trusting Jesse and Owen to have tested this with Overdrive, code review reveals no additional changes or possible problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 22:15:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 20:15:35 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 22:15:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 20:15:38 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26825|0 |1 is obsolete| | Attachment #26826|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 26886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26886&action=edit [PASSED QA] Bug 9075: Rename type to material type on staff XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Revised Test Plan ----------------- 1) Set the Staff system preference XSLTDetailsDisplay to 'default' and save. 2) Set the Staff system preference XSLTResultsDisplay to 'default' and save. 3) Click 'Search the catalog' tab in the search area. 4) Search for something 5) Look for a biblio that has 942$c set to some type. -- It should display "Type:" Or take a result and modify it to have a 942$c. 6) Look at the biblio details -- It should also display "Type:" 7) Apply the patch 8) Search for the same biblio again. -- It should display "Material type:" this time. 9) Look at the biblio details -- It should display "Material type:" this time. 10) Run the koha qa test tool. Signed-off-by: Mark Tompsett Note: This is a simple string substitution. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 22:15:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 20:15:54 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #23 from Katrin Fischer --- Created attachment 26887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26887&action=edit [PASSED QA] Bug 9075: Rename type to material type on OPAC XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Revised Test Plan ----------------- 1) In the staff client, set the OPAC system preference OPACXSLTDetailsDisplay to 'default' and save. 2) In the staff client, set the OPAC system preference OPACXSLTResultsDisplay to 'default' and save. 3) In the staff client, set the OPAC system preference opacthemes to 'bootstrap' and save. 4) In the OPAC, search for biblio used in previous patch testing. -- It should display "Type:" 6) Look at the biblio details -- It should also display "Type:" 7) In the staff client, set the OPAC system preference opacthemes to 'prog' and save. 8) In the OPAC, search for biblio used in previous patch testing. -- It should display "Type:" 9) Look at the biblio details -- It should also display "Type:" 10) Apply the patch 11) In the staff client, set the OPAC system preference opacthemes to 'bootstrap' and save. 12) In the OPAC, search for biblio used in previous patch testing. -- It should display "Material type:" this time. 13) Look at the biblio details -- It should display "Material type:" this time. 14) In the staff client, set the OPAC system preference opacthemes to 'prog' and save. 15) In the OPAC, search for biblio used in previous patch testing. -- It should display "Material type:" this time. 16) Look at the biblio details -- It should display "Material type:" this time. 17) Run the koha qa test tool. Signed-off-by: Mark Tompsett Note: Just a simple string change. Signed-off-by: Katrin Fischer String change, works as advertised in staff, prog and bootstrap OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 22:59:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 20:59:29 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Chris Rohde changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 23:27:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 21:27:58 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 23:28:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 21:28:04 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26852|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 26888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26888&action=edit [PASSED QA] Bug 11684: mixed content warnings using SSL with amazon - opac-readingrecord and opac-user To test: 0) It goes without saying that images being looked at should continue to be the proper size and look ok. 1) In the staff client, change the OPAC system preference opacthemes to 'bootstrap'. 2) Enable Amazon images in the system preferences 3) Issue a book you know will have images for a known user 4) Issue a book you know will have images for intentionally overdue for the same user 5) git reset --hard origin/master 6) In OPAC, log in as the user. -- On the 'your summary' tab on the left (which is default), a) In the 'Checked out' tab, there should be at least two books. The two books issued should have http images. b) In the 'Overdue' tag, there should be at least one book. The image for the overdue book issued should have http images. 7) Click the 'your reading history' tab on the left. -- The images for the two books issued should have http images. 8) Apply the patch 9) Repeat steps 6-7, but all the images in question should have https images now. 10) In the staff client, change the OPAC system preference opacthemes to 'prog'. 11) Repeat steps 5-9 12) Run the koha QA test tool Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Passes all tests and QA script. Checked reading history, overdoes, and checkouts in bootstrap and prog OPAC. Amazon image URL is now https://. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 7 23:48:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 21:48:07 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #34 from Katrin Fischer --- There is a conflict in opac.css now - I am not sure how this needs to be resolved now with less - Owen, could you take a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 00:27:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 22:27:07 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #11 from Robin Sheat --- (In reply to M. Tompsett from comment #8) > > + $value = 0 if ( $db_type && $db_type eq 'YesNo' && $value eq '' ); > > What if $value = undef? The eq check will blow up. Should it not be !$value > instead? That was in the original code, and hadn't blown up that I've seen before. It probably be !$value though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 00:32:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 22:32:32 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 00:32:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 22:32:35 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26061|0 |1 is obsolete| | Attachment #26062|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer --- Created attachment 26889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26889&action=edit [PASSED QA] Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead Signed-off-by: Christopher Brannon Signed-off-by: Michot Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 00:33:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 22:33:06 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #34 from Katrin Fischer --- Created attachment 26890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26890&action=edit [PASSED QA] Bug 11489: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett Signed-off-by: Michot Signed-off-by: Katrin Fischer Passes all tests and QA script. Tested: - Record with 1 lost item, result list = 1 - Verified without both patches 404 error page is shown - Verified with 1st patch, no results page is shown - Verified with 2nd patch, the still showing facets are gone - Record with 1 lost item, result list > 1 - Record is hidden from result list, but - result count is wrong - result numbering is wrong > This is an old problem, just noting - Record with 1 lost and 1 available item, result list = 1 - Detail page is shown, only lost item is hidden - Record with 1 lost and 1 available item, result list > 1 - Only available item is shown in result list Also checked that the lost item shows up with hidelostitems off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 01:16:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 23:16:41 +0000 Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #15 from Katrin Fischer --- Hm, some problems to fix here: FAIL t/db_dependent/Circulation_issue.t OK pod OK forbidden patterns FAIL valid "my" variable $biblionumber masks earlier declaration in same scope "my" variable $biblioitemnumber masks earlier declaration in same scope OK critic FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs UNIMARCAuthorityField100 is bad placed (see bug 10610) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 01:33:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 23:33:37 +0000 Subject: [Koha-bugs] [Bug 12041] New: Improve Koha::Cache Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 Bug ID: 12041 Summary: Improve Koha::Cache Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Koha::Cache can be improved to fall back more reliably, to handle complex data types, and so on. This is necessary to allow caching of things properly under plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 01:33:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 23:33:58 +0000 Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9967 Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 01:33:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 23:33:58 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12041 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 01:34:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 23:34:55 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #13 from Robin Sheat --- I've spun off the improvement of Koha::Cache into its own bug (bug 12041), as it was getting bigger. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 01:45:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Apr 2014 23:45:20 +0000 Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when memcache is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 05:23:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 03:23:50 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #46 from Robin Sheat --- I found quite a few issues in Koha::Cache, so I'm improving it in bug 12041. This might affect some stuff here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 07:57:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 05:57:11 +0000 Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 07:57:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 05:57:16 +0000 Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 --- Comment #1 from Robin Sheat --- Created attachment 26891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26891&action=edit Bug 12041 - improve Koha::Cache This makes Koha::Cache behave better by default. It will use memcached if available to do shared caching, if that's not available it will fall back to in-memory caching. It also allows for a singleton accessor to allow a single cache to be shared within a process. Test plan: * The t/Cache.t file runs successfully with and without the MEMCACHED_SERVERS envvar set (and memcached running in the environment.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 09:46:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 07:46:41 +0000 Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- (In reply to Robin Sheat from comment #1) > Created attachment 26891 [details] [review] > Bug 12041 - improve Koha::Cache > > This makes Koha::Cache behave better by default. It will use memcached > if available to do shared caching, if that's not available it will fall > back to in-memory caching. It also allows for a singleton accessor to > allow a single cache to be shared within a process. > > Test plan: > * The t/Cache.t file runs successfully with and without the > MEMCACHED_SERVERS envvar set (and memcached running in the > environment.) You will want to test that storing utf8 and retrieving it still works. If this change munches utf8 then it makes the caching unusable in a lot of situations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 09:55:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 07:55:58 +0000 Subject: [Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 --- Comment #3 from Jonathan Druart --- (In reply to M. Tompsett from comment #2) > Comment on attachment 26559 [details] [review] > > my $subscription = &GetSubscription( $issue->{subscriptionid} ); > > + my $publisheddate = $issue->{publisheddate}; > > What is the difference between publisheddate and planneddate? This is the > only thing holding me back from signing off. publisheddate is the date of the publication and planneddate is the planned date of the reception (and becomes the date of the reception, when it has been done). Before bug 7688, the GetNextDate was called with planneddate sometimes and publisheddate other times. To get the next published date, it is logical to be based on the current published date (and not planneddate, which could be different for each library). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 10:30:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 08:30:26 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #15 from Jonathan Druart --- (In reply to Marjorie Barry-Vila from comment #13) > Hi Jonathan, > I tested it on a sandbox but it is not working for me. I think it's me I do > something wrong. I added an owner, a library and a restriction to only owner > and i can still see fund of the other library. > I changed flags too but without results. The "test" patron has the manage_all_buggets permission. So he can edit all budgets, even if a restriction is set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 11:21:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 09:21:16 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D_New=3A__Change_text_?= =?utf-8?b?4oCYQWRkIHRvIGJhc2tldOKAmSBpbnRvIOKAmEFkZCBvcmRlciB0byBiYXNr?= =?utf-8?b?ZXTigJk=?= Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Bug ID: 12042 Summary: Change text ?Add to basket? into ?Add order to basket? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: s.simonetti at cineca.it QA Contact: testopia at bugs.koha-community.org I think it would be a good idea to clarify better the function of the "add to basket" button on the vendor search results page /cgi-bin/koha/acqui/booksellers.pl and on the single basket page cgi-bin/koha/acqui/basket.pl?basketno=1. To make that, I suggest to add the word order. So "add to basket" could become ?add order to basket? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 11:23:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 09:23:43 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 11:49:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 09:49:07 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 --- Comment #1 from Silvia Simonetti --- Created attachment 26892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26892&action=edit Change text ?Add to basket? into ?Add order to basket? This patch changes the text ?Add to basket? into ?Add order to basket? in vendor search results page and the single basket page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 11:53:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 09:53:06 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26892|0 |1 is obsolete| | Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |s.simonetti at cineca.it |ity.org | --- Comment #2 from Silvia Simonetti --- Created attachment 26893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26893&action=edit patch for this bug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 11:56:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 09:56:43 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|s.simonetti at cineca.it |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 11:57:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 09:57:07 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 11:57:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 09:57:49 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 11:58:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 09:58:14 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |z.tajoli at cineca.it Severity|trivial |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 11:58:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 09:58:29 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 11:59:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 09:59:13 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |s.simonetti at cineca.it |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 12:00:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 10:00:10 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.simonetti at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 12:00:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 10:00:11 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at pttk.fi |ity.org | --- Comment #1 from paxed --- Created attachment 26894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26894&action=edit Add syspref MarcFieldDocURL to config the MARC format documentation URL for marc edit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 12:06:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 10:06:48 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #59 from Paola Rossi --- Today I've installed master 3.15.00.027 I try to apply the patches. At the 6-th patch there a conflict, perhaps due to the rebasing: Applying: Bug 11944: use CGI( -utf8 ) everywhere Using index info to reconstruct a base tree... :2009: trailing whitespace. use CGI qw ( -utf8 ); warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging tools/koha-news.pl CONFLICT (content): Merge conflict in tools/koha-news.pl Auto-merging opac/opac-main.pl CONFLICT (content): Merge conflict in opac/opac-main.pl Auto-merging mainpage.pl CONFLICT (content): Merge conflict in mainpage.pl Failed to merge in the changes. Patch failed at 0001 Bug 11944: use CGI( -utf8 ) everywhere ------------------ So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 12:15:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 10:15:41 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #2 from paxed --- Add a new system preference MarcFieldDocURL. Setting it to some URL will make all the MARC documentation links point to that in the MARC edit UI. Leaving the value empty will use the old defaults (http://loc.gov for MARC21 and http://archive.ifla.org for UNIMARC). There are some possible substitutions usable in the URL: - {MARC} is replaced with either "MARC21" or "UNIMARC" - {FIELD} is replaced by the MARC field number, eg. "000", "048", ... - {LANG} is replaced by the UI language, eg. "en", or "fi-FI" To test: 1) Install Koha 2) Go to Cataloguing > New record 3) Clicking on the question mark links in the MARC edit will open a window to either loc.gov or archive.ifla.org 4) Install patch 5) Redo parts 1, 2, and 3. 6) Set the value of MarcFieldDocURL to http://example.com/?field={FIELD}&marc={MARC}&lang={LANG} 7) Redo parts 1 and 2 8) Clicking on the question mark links in the MARC edit will open a window to example.com, with the proper substitutions in the URL for the field, marc flavour and language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 12:21:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 10:21:18 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26748|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 12:24:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 10:24:01 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 12:24:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 10:24:09 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26861|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart --- Created attachment 26895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26895&action=edit Bug 11944: use CGI( -utf8 ) everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 12:25:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 10:25:18 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #61 from Jonathan Druart --- Last patch resolves conflicts with bug 7567. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 13:02:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 11:02:16 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11684 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 13:02:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 11:02:16 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10944, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8952 --- Comment #6 from Jonathan Druart --- It seems the same stuff is done on bug 8952. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 13:02:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 11:02:16 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11684 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 13:26:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 11:26:11 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Alessandra Carassiti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.carassiti at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 14:08:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 12:08:23 +0000 Subject: [Koha-bugs] [Bug 12043] New: Popup when reserved item checked in at wrong branch should generate transfer slip Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043 Bug ID: 12043 Summary: Popup when reserved item checked in at wrong branch should generate transfer slip Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: benjamin.rokseth at kul.oslo.kommune.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com There are a number of bugs addressing print slip and holds issues, so this bug addresses solely the following three scenari: Item with homebranch A is reserved for pickup at branch B. 1) Item is checked in at A (parameters $reserved and $transfertodo are set) 2) Item is checked in at C (parameters $diffbranch and $transfertodo are set) 3) Item is checked in at A, then at C (parameter $WrongTransfer is set) 4) Item is checked in at A, then at B (parameter $reserved is set) In all of these, messages are created correctly, but hold-transfer-slip.pl popup is generated with transfer=1. hold-transfer-slip.pl ignores $transfer so all cases opens a dialog generated from template RESERVESLIP, where the three first actually should generate TRANSFERSLIP. Either hold-transfer-slip.pl must respect $transfer variable or transfer-slip.pl must be used in cases of transfer. Popups are generated in returns.tt, e.g.: hold-transfer-slip.pl?transfer=1&borrowernumber=[% borrowernumber %]&biblionumber=[% itembiblionumber %]&op=slip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 14:34:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 12:34:00 +0000 Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at wrong branch should generate transfer slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043 --- Comment #1 from Benjamin Rokseth --- Created attachment 26896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26896&action=edit Bug 12043 - Popup when reserved item checked in at wrong branch should generate transfer slip This patch corrects some wrong popups in Returns.tt handling transfers of reserved items. Instead of using hold-transfer-slip.pl with param transfer=1 (which seems to be silently ignored) it uses transfer-slip.pl with itemnumber and destination branch, which allows for printing correct slips. It also removes the non-used param $tranfer in hold-transfer-slip.pl. Test plan: ( see cases in bug description ) 1) Make a reservation on item with homebranch A to branch B 2) checkin item at its homebranch A 3) press 'Print slip and confirm transfer' 4) verify that slip uses template RESERVESLIP 5) apply patch 6) repeat steps 1-3 7) verify that slip now uses template TRANSFERSLIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 14:34:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 12:34:28 +0000 Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at wrong branch should generate transfer slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 15:30:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 13:30:39 +0000 Subject: [Koha-bugs] [Bug 12044] New: Checkout should not be possible if a patron's fines will block the transaction Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12044 Bug ID: 12044 Summary: Checkout should not be possible if a patron's fines will block the transaction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron cannot check out because they are over the limit specified by the noissuescharge system preference and the logged in user doesn't have permission to override the limit the barcode input field should not appear. The user should see a message explaining that checking out is blocked by the outstanding charge. Currently the user is able to submit the barcode without any warnings about the block, and only after the page refreshes do they get a warning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 15:56:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 13:56:43 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #16 from Marjorie Barry-Vila --- (In reply to Jonathan Druart from comment #15) > (In reply to Marjorie Barry-Vila from comment #13) > > Hi Jonathan, > > I tested it on a sandbox but it is not working for me. I think it's me I do > > something wrong. I added an owner, a library and a restriction to only owner > > and i can still see fund of the other library. > > I changed flags too but without results. > > The "test" patron has the manage_all_buggets permission. So he can edit all > budgets, even if a restriction is set. ok! it's works! Sorry for all my comments! I signed off. Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 15:57:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 13:57:08 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #17 from sandboxes at biblibre.com --- Patch tested with a sandbox, by marjorie barry-vila -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 15:57:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 13:57:25 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26757|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 15:57:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 13:57:29 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26758|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 15:57:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 13:57:35 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #18 from sandboxes at biblibre.com --- Created attachment 26897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26897&action=edit Bug 12019: FIX budget_owner_id node is duplicated The input witht the budget_owner_id id is duplicated. It breaks the jQuery selector $('#budget_owner_id').val(''); Signed-off-by: marjorie barry-vila -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 15:57:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 13:57:38 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #19 from sandboxes at biblibre.com --- Created attachment 26898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26898&action=edit Bug 12019: If a fund has a restriction, a owner is mandatory The C4::Budgets::CanUserUseBudget assumes that budget_owner_id is set if a restriction (budget_permission) exists. see && $budget->{budget_owner_id} && $budget->{budget_owner_id} != $borrower->{borrowernumber} Test plan: Edit a fund and try to save it with a limitation and no owner. It should not be possible. Signed-off-by: marjorie barry-vila -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 16:12:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 14:12:14 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24087|0 |1 is obsolete| | Attachment #24088|0 |1 is obsolete| | Attachment #24089|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 26899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26899&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACHideOpenURLForItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are not in OPACHideOpenURLForItemTypes) 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" 9/ Repeat steps 5 to 7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 16:12:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 14:12:20 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #16 from Jonathan Druart --- Created attachment 26900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26900&action=edit Bug 8995: Use uri_escape_utf8 instead of uri_escape -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 16:12:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 14:12:26 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #17 from Jonathan Druart --- Created attachment 26901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26901&action=edit Bug 8995: Show OpenURL links in bootstrap theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 16:18:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 14:18:57 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 BiAA changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heullant at mmsh.univ-aix.fr Version|master |3.14 --- Comment #32 from BiAA --- Hello, We've just changed for Koha 3.14 and I see that the bug, reported by Paul Poulain, about the biblioitems.collectiontitle fields (UNIMARC 225Sa)in the orders, has not been resolved yet. The field is not saved between suggestions and orders. It's a real problem because we can't use fully koha to manage our acquisitions. I must use another software (ACCESS) to make the link between purchasers and suggestions, its a waste of time... pity. Regards, Fabienne Heullant, Head Librarian Frantiq, French archaeology libraries network (more than 40 libraries) http://frantiq.mom.fr/ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 16:24:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 14:24:04 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 BiAA changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker --- Comment #33 from BiAA --- Hello, We've just changed for Koha 3.14 and I see that the bug, reported by Paul Poulain, about the biblioitems.collectiontitle fields (UNIMARC 225Sa)in the orders, has not been resolved yet. The field is not saved between suggestions and orders. It's a real problem because we can't use fully koha to manage our acquisitions. I must use another software (ACCESS) to make the link between purchasers and suggestions, its a waste of time... pity. Regards, Fabienne Heullant, Head Librarian Frantiq, French archaeology libraries network (more than 40 libraries) http://frantiq.mom.fr/ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 16:43:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 14:43:09 +0000 Subject: [Koha-bugs] [Bug 12045] New: Transfer impossible if barcode includes spaces Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045 Bug ID: 12045 Summary: Transfer impossible if barcode includes spaces Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: verolencinas at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Barcodes in Koha can include spaces but if such an item is transferred you get the message "No Item with barcode: nnnn" where nnnn is the barcode with spaces stripped. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 16:48:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 14:48:22 +0000 Subject: [Koha-bugs] [Bug 12046] New: Authentication using CAS - bootstrap Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Bug ID: 12046 Summary: Authentication using CAS - bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. A link should be displayed, as on the opac-user.pl page (and on the prog theme). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 16:51:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 14:51:11 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 16:51:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 14:51:15 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 --- Comment #1 from Jonathan Druart --- Created attachment 26902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26902&action=edit Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. A link should be displayed, as on the opac-user.pl page (and on the prog theme). Test plan: - set opacthemes to bootstrap - enable the casAuthentication pref - fill the casServerUrl pref with "something" - go on the opac home page - click on the "log in" link (top right) - you should see 2 login blocks 'CAS' and 'Local' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 17:09:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 15:09:03 +0000 Subject: [Koha-bugs] [Bug 12047] New: Add new suggestion page should hide inactive funds Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12047 Bug ID: 12047 Summary: Add new suggestion page should hide inactive funds Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org When adding a suggestion, all funds are showing. It would be great to have the same option like in new order page to select active/inactive funds. Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 17:24:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 15:24:54 +0000 Subject: [Koha-bugs] [Bug 12048] New: Doesn't display other libraries subscriptions when superlibrarian user Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Bug ID: 12048 Summary: Doesn't display other libraries subscriptions when superlibrarian user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com This is a regression in master and 3.14. When a user has superlibrian permissions, a search on serials subscriptions must display other libraries subscriptions even when IndependantBranch syspref is enabled. To reproduce/test the bug/patch: 1. Enable IndependanBranch 2. Login as a user not having superlibrarian permission 3. Search for a serial subscription on: /cgi-bin/koha/serials/serials-search.pl 4. Search a title which has at least 2 subscriptions: one in the user branch, and one in another branch 5. On the result page, just 1 subscription is displayed: the one attached to the userbranch => this is normal 6. Login as a user having superlibrarian permission 7. Repeat step 3-5. 8. You get the same result as 5. You should have seen all subscriptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 17:28:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 15:28:47 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr |ity.org | --- Comment #1 from Fr?d?ric Demians --- Created attachment 26903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26903&action=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 17:50:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 15:50:28 +0000 Subject: [Koha-bugs] [Bug 12049] New: DatePicker not translated Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12049 Bug ID: 12049 Summary: DatePicker not translated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Tested on 3.14.05, the JavaScript calendar aka DatePicker is not translated in circulation page for date due and renew date (you see Now, Done ...). Strange because the page calls calendar.inc which contains translated texts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 18:14:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 16:14:00 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 --- Comment #34 from mathieu saby --- Hello If it is still in master, it must be fixed! And bug status should not be "in discussion". But it is definitely not a "P1 blocker" bug. You can see the definition of bug priority in the wiki http://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines More likely something like "Normal P3" Mathieu Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 18:14:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 16:14:50 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P3 Severity|blocker |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 19:22:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 17:22:13 +0000 Subject: [Koha-bugs] [Bug 12049] DatePicker not translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12049 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- This bug was fixed by 11618 which has been pushed to master but not stable. It applies cleanly to 3.14.x. *** This bug has been marked as a duplicate of bug 11618 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 19:22:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 17:22:13 +0000 Subject: [Koha-bugs] [Bug 11618] jQuery timepicker is not picked up by the i18n toolchain In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Owen Leonard --- *** Bug 12049 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 19:23:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 17:23:14 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 --- Comment #7 from M. Tompsett --- Similar, but not the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 22:11:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 20:11:05 +0000 Subject: [Koha-bugs] [Bug 12050] New: batch bib deletion tool Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12050 Bug ID: 12050 Summary: batch bib deletion tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org it would be nice to have a batch bib deletion tool that took a batch of bib numbers or ran a report with the criteria of the user's choosing (like all bibs without items). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 23:35:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 21:35:56 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 8 23:35:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 21:35:59 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26902|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 26904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26904&action=edit [SIGNED OFF] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. A link should be displayed, as on the opac-user.pl page (and on the prog theme). Test plan: - set opacthemes to bootstrap - enable the casAuthentication pref - fill the casServerUrl pref with "something" - go on the opac home page - click on the "log in" link (top right) - you should see 2 login blocks 'CAS' and 'Local' Signed-off-by: Mark Tompsett NOTE: Without CAS properly set up, the URL will actually be empty for the CAS' click here to login link. COMMENT: Though this does do what it says it does, would it not be better to redirect to the opac-user page and get the old page loaded up as before, so not just CAS but all potential authentication mechanisms will work? Increasing the size of the modal seems to defeat the purpose of the modal, in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 00:45:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 22:45:47 +0000 Subject: [Koha-bugs] [Bug 12051] New: add renew tab to top on staff client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Bug ID: 12051 Summary: add renew tab to top on staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org On pages that have the check out and check in tabs on the quick search box at the top, it would be nice to also have a renew tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 01:32:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 23:32:07 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #48 from Galen Charlton --- Pushed to master, along with several follow-ups. Thanks, Holger! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 01:35:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 23:35:06 +0000 Subject: [Koha-bugs] [Bug 9075] Rename type to material type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Galen Charlton --- Pushed to master. I note that "material type" is library jargon, not patron jargon, but the distinction expressed is valid. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 01:36:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 23:36:42 +0000 Subject: [Koha-bugs] [Bug 11978] OverDrive API now prepends http:// to URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Jesse! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 01:37:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 23:37:02 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Suzanne Fayle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 01:46:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 23:46:42 +0000 Subject: [Koha-bugs] [Bug 11855] Tiny code cleanup in members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Marcel and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 01:50:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 23:50:10 +0000 Subject: [Koha-bugs] [Bug 11711] Use new DataTables include in circ templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 01:52:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Apr 2014 23:52:01 +0000 Subject: [Koha-bugs] [Bug 11734] Use new DataTables include in batch modification templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11734 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 02:55:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 00:55:35 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #47 from Bernardo Gonzalez Kriegel --- Today I re-invented this fix trying to answer a mail :( Comments: 1. Of DejaVu fonts, only Sans version has a good collection of chars, so we can advice to use only Helvetica if you want Arabic for example. It's not a problem of the proposed solution, but a shortcoming of the available font. I think it's the best we can do for now. 2. Helvetica (DejaVuSans) PDF fails because the wrong code is passed to the file selection on Creators/PDF.pm, I will add a followup 3. Have you tried changing justification on layout? The result is wrong. I will add another followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 02:56:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 00:56:38 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #48 from Bernardo Gonzalez Kriegel --- Created attachment 26905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26905&action=edit Bug 8375 - Followup - Fix font code This follow up fixes font code taking it from layout. To test: 1. Try making a batch using Helv?tica, downloaded PDF do not open. 2. Apply the patch 3. Try again, now it's correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 02:57:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 00:57:28 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #49 from Bernardo Gonzalez Kriegel --- Created attachment 26906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26906&action=edit Bug 8375 - Followup 2 - Fix label justification/aligning This patch use prText alignment to produce center or right align in text To test (with former patches applied): 1. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. I would suggest to use Helvetica 2. Apply the patch 3. Verify again, now strings must be correctly aligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 02:59:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 00:59:29 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 03:35:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 01:35:35 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #50 from Bernardo Gonzalez Kriegel --- Created attachment 26907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26907&action=edit pic2 another pic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 04:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 02:47:08 +0000 Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 --- Comment #3 from Robin Sheat --- Created attachment 26908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26908&action=edit Bug 12041 - utf8 compatibility changes Switched to Cache::Memcached::Fast due to its better support for unicode, added to the test case so that we notice if something causes it to break. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 04:49:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 02:49:18 +0000 Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26891|0 |1 is obsolete| | Attachment #26908|0 |1 is obsolete| | --- Comment #4 from Robin Sheat --- Created attachment 26909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26909&action=edit Bug 12041 - improve Koha::Cache This makes Koha::Cache behave better by default. It will use memcached if available to do shared caching, if that's not available it will fall back to in-memory caching. It also allows for a singleton accessor to allow a single cache to be shared within a process. Added tests to confirm UTF8-cleanness. Test plan: * The t/Cache.t file runs successfully with and without the MEMCACHED_SERVERS envvar set (and memcached running in the environment.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 05:58:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 03:58:01 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 --- Comment #14 from Robin Sheat --- Created attachment 26910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26910&action=edit Bug 9967 - Cache authorised value requests properly Authorised values are now cached using the proper Koha::Cache mechanism, rather than a simple internal cache. Memoize has been removed because it didn't really work like we needed it to. Test plan: * running a persistent environment: * load the edit item screen * refresh several times to ensure any process-based caches are filled * add a new LOC authorised value as fast as possible (prepare it on another tab.) * refresh the edit item page * note that the new LOC value may or may not be showing in the "shelving location" * if more than 5 seconds have passed since saving it, it must now show up. * refresh a few times to ensure that it's showing on all processes. Note: * This patch depends on the caching changes of 9967. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 05:58:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 03:58:47 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 05:58:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 03:58:59 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26786|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 06:08:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 04:08:46 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #36 from wajasu --- Created attachment 26911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26911&action=edit 0001-Bug-11232-support-zebra-facet-queries-in-search.patch Minimal support for zebra facet queries with indexes being made available in the zidx fields added to the Koha::getFacets routine. Search falls back to current implementation when facet query has and error or no results. This enables folks to roll out index changes. Currently supports the existing facets. Test Plan: 1) Setup a working git clone dev install with a database with biblios (be sure to have your KOHA_CONF and PERL5LIB set. dom, icu 2) Run searches with current facet behavior (keeping browser tab for later reference) (use staff client to find some biblios and on the marc tab write down the biblionumber for later use. get about 5 or more) (enable syspref for showing facet counters in staff client admin) 3) (Optional) Setup yaz-client for manual validation (on a console tab) yaz-client unix:/home/koha/koha-dev/var/run/zebradb/bibliosocket base biblios form xml elem zebra::facet::Author:0 f @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 "Ferguson, Sinclair B." ... some hits s (should show results when thedesignated index Author:0 is specified) elem Subject-to:0,Subject-geo:0,Subject-ut:0,Author:0,Title-series:0,itype:0,location:0,holdingbranch:0 s (should show all facets results if all are configured ) 4) Apply patch 5) cd to your chosen .../koha-dev/etc/zebradb/marc_defs/marc21/biblios (on another console tab) 6) xsltproc ../../../xsl/koha-indexdefs-to-zebra.xsl biblio-koha-indexdefs.xml > biblio-zebra-indexdefs.xsl (rerun this after changing biblio-koha-indexdefs.xml) 7) from kohaclone dir (setup this up in another console tab for steps 7 & 8) run misc/migration_tools/rebuild_zebra.pl --where "biblionumber in (n1, n1, ...)" -b -r --run-as-root -v where n1 ... are the biblios you write down above. (For a quick index turnaround) Later for a full database rebuild, that will use the new biblio-zebra-indexdefs.xsl from kohaclone dir run misc/migration_tools/rebuild_zebra.pl -a -b -r --run-as-root -v (--run-as-root if needed) 8) zebrasrv -f /home/koha/koha-dev/etc/koha-conf.xml (can watch this on output and cut RPN queries for yaz if you desire) 9) use browser to search as you did in step 2 to see if you have larger counters (when you have a bigger database/result) 10) if facets are satisfactory, we pass. please report anomalies. You can edit the C4/Search.pm line that defines $element_set_all_indexes and make adjustments removing selectively,save and then do a search to see things fallback to the current code behavior. Write now this patch demonstrates this strategy as a baby step for a release. Things that need to be done: - clean code (warnings, comments, long/bad var names, etc) - add facet usage syspref detection (if needed) - pubdate, and other desired additions (can be a future/followup enhancment) - think about UTF-8 and check if diacritics etc show in facet term - discuss naming of some added indexes Subject-to vs su-to, Subject-geo vs su-geo - handle HideLostItems, and check if Suppress is handled. - grs1 and other adjustments (if needed) - future enhancment can: support syspref/editing of element_indexes_all and the order to display - communicate the adjustment to biblio-koha-indexdefs.xml for upgrades to take advantage. - if this patch strategy is acceptable, the UNIMARC and NORMARC facets can be worked on. fallback allows us to rollout. - no restrictions on the total amount of facets are configured (Author:0:100 might be worth trying) - facet consolidation for the presentation UI is the same but could return all results to the UI and let CSS hide/unhide. (another bug exists for this) I did NYTProf, but others can and suggest performance enhancements. When zebra facet indexes are available no marc records are being read etc, as of now, unless things fallback. Note: Title-series:0 seemed to not show a 490a in a certain case where I had 10 results with a certain resultset. Weird, but me might just decide to fallback for that index if its an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 06:09:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 04:09:49 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 06:26:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 04:26:35 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #60 from M. Tompsett --- Comment on attachment 13018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13018 Bug 6030 [3.8.x] Allow html content in letters Review of attachment 13018: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6030&attachment=13018) ----------------------------------------------------------------- ::: misc/cronjobs/overdue_notices.pl @@ +344,4 @@ > > our $csv; # the Text::CSV_XS object > our $csv_fh; # the filehandle to the CSV file. > +if ( $csvfilename ) { No, because the file name could be "0". Old code is better. @@ +563,4 @@ > email => $email, > itemcount => $itemcount, > titles => $titles, > + outputformat => $csvfilename ? 'csv' : defined $htmlfilename ? 'html' : '', This nested mess should be made clearer elsewhere. And no, defined $csvfilename should be used. @@ +591,4 @@ > email => $email, > itemcount => $itemcount, > titles => $titles, > + outputformat => $csvfilename ? 'csv' : defined $htmlfilename ? 'html' : '', This nested mess should be made clearer elsewhere. And no, defined $csvfilename should be used. @@ +602,4 @@ > } > > if (@output_chunks) { > + if ( $csvfilename ) { This nested mess should be made clearer elsewhere. And no, defined $csvfilename should be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 06:35:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 04:35:00 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #28 from Robin Sheat --- See also bug 9967 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 06:39:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 04:39:22 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12041 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 06:39:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 04:39:22 +0000 Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8089 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 07:08:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 05:08:30 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 07:08:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 05:08:33 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21114|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 26912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26912&action=edit Bug 10893: fix location facet in UNIMARC Location facet in UNIMARC is void. In the code, it is build on 995$c, while location is store in 995$e (see record.abs). This patch replace 995$c with 995$e in Koha.pm To test : 1. Use a UNIMARC Koha instance with ONE branch, and SEVERAL locations 2. Make a search in opac and staff interface : no location facet on the left side of the screen 3. apply the patch 4. Make the same search : location facets will be displayed NOTE: I, Mark Tompsett, rebased this. I confirmed that 995$c should be 995$e (wiki, Holdings_data_fields_(9xx) page) Also note that the code relocated based on bug 10078, causing the patch to not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 08:13:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 06:13:10 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 08:13:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 06:13:13 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26912|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 26913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26913&action=edit [SIGNED OFF] Bug 10893: fix location facet in UNIMARC Location facet in UNIMARC is void. In the code, it is build on 995$c, while location is store in 995$e (see record.abs). This patch replace 995$c with 995$e in Koha.pm To test : 1. Use a UNIMARC Koha instance with ONE branch, and SEVERAL locations 2. Make a search in opac and staff interface : no location facet on the left side of the screen 3. apply the patch 4. Make the same search : location facets will be displayed NOTE: I, Mark Tompsett, rebased this. I confirmed that 995$c should be 995$e (wiki, Holdings_data_fields_(9xx) page) Also note that the code relocated based on bug 10078, causing the patch to not apply. Signed-off-by: Mark Tompsett NOTE: The location facet did not appear in master, but after applying the patch, it did appear. Because of the code being moved, it is no longer affected by the branch count or singleBranchMode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 08:21:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 06:21:18 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #14 from M. Tompsett --- Question of interest, are the changes in C4/Acquisition.pm properly tested in some test file somewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 08:36:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 06:36:18 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |fridolyn.somers at biblibre.co | |m Assignee|paul.poulain at biblibre.com |fridolyn.somers at biblibre.co | |m --- Comment #35 from Paul Poulain --- I haven't tested/checked that the patch still applies, but it should not stay "in discussion", as that's a real bug. Fridolin, can you have a look please ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 10:34:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 08:34:10 +0000 Subject: [Koha-bugs] [Bug 12052] New: Display a patron message on the summary page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Bug ID: 12052 Summary: Display a patron message on the summary page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org There is no way (or I missed something) to display a note for all patrons at the OPAC. The note should only be displayed if the user is logged in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 10:34:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 08:34:19 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 10:36:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 08:36:03 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 --- Comment #12 from mathieu saby --- Thank Mark you for rebasing and signing off! Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 10:42:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 08:42:04 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 10:42:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 08:42:08 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 --- Comment #1 from Jonathan Druart --- Created attachment 26914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26914&action=edit Bug 12052: Display a patron message on the summary page Test plan: Fill the OPACMySummaryNote with html code or just text. The content should be displayed at the OPAC on the summary page for patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 10:43:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 08:43:41 +0000 Subject: [Koha-bugs] [Bug 12053] New: Borrower attributes not visible anymore at OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12053 Bug ID: 12053 Summary: Borrower attributes not visible anymore at OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In OPAC user account, the borrower attributes are not visible anymore. There where visible in opac-userdetails.pl that as been replaced by opac-memberentry.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 10:52:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 08:52:17 +0000 Subject: [Koha-bugs] [Bug 12053] Borrower attributes not visible anymore at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12053 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 11:12:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 09:12:40 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D_New=3A__It=E2=80=99s_possib?= =?utf-8?q?le_to_make_order_from_an_inactive_vendor?= Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Bug ID: 12054 Summary: It?s possible to make order from an inactive vendor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: a.carassiti at cineca.it QA Contact: testopia at bugs.koha-community.org Created attachment 26915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26915&action=edit Order from an inactive vendor When you make a vendor inactive, koha is able to order from it although if the help says you it?s not possible (see the attachment). I think it would be convenient to have at least a message that inform you of the vendor status. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 11:41:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 09:41:01 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #62 from Katrin Fischer --- Hi Kyle, could you please rebase? Sorry it took me so long to get back to this. I fixed a conflict in the third patch, but then there is another on the last, that I can't resolve: Applying: Bug 9303 [QA Followup] - Set AUTO_INCREMENT value for issues.issue_id Applying: Bug 9303 [QA Followup 2] - Undo changes to GetReserve Applying: Bug 9303 [QA Followup 3] - Add borrowerRelationship syspref check Applying: Bug 9303 [QA Followup 4] - Syspref the feature for staff fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9303 [QA Followup 4] - Syspref the feature for staff The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9303-QA-Followup-4---Syspref-the-feature-for-s-hwC6Eh.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 11:45:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 09:45:16 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 11:45:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 09:45:19 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26913|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 26916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26916&action=edit [PASSED QA] Bug 10893: fix location facet in UNIMARC Location facet in UNIMARC is void. In the code, it is build on 995$c, while location is store in 995$e (see record.abs). This patch replace 995$c with 995$e in Koha.pm To test : 1. Use a UNIMARC Koha instance with ONE branch, and SEVERAL locations 2. Make a search in opac and staff interface : no location facet on the left side of the screen 3. apply the patch 4. Make the same search : location facets will be displayed NOTE: I, Mark Tompsett, rebased this. I confirmed that 995$c should be 995$e (wiki, Holdings_data_fields_(9xx) page) Also note that the code relocated based on bug 10078, causing the patch to not apply. Signed-off-by: Mark Tompsett NOTE: The location facet did not appear in master, but after applying the patch, it did appear. Because of the code being moved, it is no longer affected by the branch count or singleBranchMode. Signed-off-by: Katrin Fischer Fixes wrong subfield code for UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 11:51:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 09:51:11 +0000 Subject: [Koha-bugs] [Bug 7901] Add batch delete borrowers script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901 --- Comment #8 from Katrin Fischer --- I wonder if those options should be added to the delete_borrowers.pl script that already is in Koha. If we have 2 scripts, we should make clear where the differences are and they should both delete patrons the same way, taking fines, holds etc. into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 12:19:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 10:19:55 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #41 from Katrin Fischer --- Hi Jonathan, thx for the test plan, I am back on testing this now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 13:01:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 11:01:09 +0000 Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at wrong branch should generate transfer slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros at gmail | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 13:03:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 11:03:36 +0000 Subject: [Koha-bugs] [Bug 12055] New: Typo "holdiay" in calendar Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12055 Bug ID: 12055 Summary: Typo "holdiay" in calendar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org The calendar has typo "holdiay" in three different places. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 13:07:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 11:07:08 +0000 Subject: [Koha-bugs] [Bug 12056] New: Untranslatable strings in calendar Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12056 Bug ID: 12056 Summary: Untranslatable strings in calendar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In the calendar, the javascript function dateStatusHandler() returns eg. "Single holiday: " + the name of the holiday. The string is not picked up for translation. In total, the function has 5 different strings that are not picked up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 13:16:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 11:16:33 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel at gmail.com --- Comment #36 from Bernardo Gonzalez Kriegel --- Does not apply on master or 3.14.x -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 13:40:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 11:40:57 +0000 Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26462|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 26917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26917&action=edit [SIGNED-OFF] Bug 11885 - Inconsistent HTML in MARC Details In Catalog > MARC Details, the HTML in the different tabs is slightly inconsistent and doesn't differentiate different elements, making CSS styling complicated or impossible: * tab 0 has

whereas all the other tabs have just

* all other tabs wrap the subfield character in tags, except for tab 0 * the MARC tag title is a single div with the tag, the indicators and the field description. Attached patch folds all the tab outputs into a single TT BLOCK, which is then reused. It also marks the separate parts of the tag title in their own spans. The output should be nearly identical to previous behaviour, minus a dash from the tag title descriptions - it was used to separate the tag from the description. The description can now be styled separately from the tag itself, so the dash can be added with CSS, if necessary. Revised test: 1) Find a biblio 2) Edit the record so that there is something in every tab (0-9). 3) Save and then click 'MARC' in the left pane to view the MARC details. 4) Note the contents of each tab. 5) Apply patch 6) Compare the MARC details output to what was noted. Should be the same, minus a dash in each of the tag title descriptions. http://bugs.koha-community.org/show_bug.cgi?id=11885 Signed-off-by: Pasi Kallinen Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 13:41:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 11:41:11 +0000 Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26853|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 26918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26918&action=edit [SIGNED-OFF] Bug 11885 - Follow-up to address issues raised Jonathan Druart raised the following three issues: 1/ subtags was bold before patch 2/ 1 dash existed between tag and tag name 3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet nom commun", "101 ## - Langue" becomes "101 # # Langue") This patch addresses them in the following way: 1/ You will note that @ was not bold on the 0 tab. Every other tab were bold. By making the similar template into a procedure based on the 0XX tab, bolding was lost. This patch bolds all subtags including the @, so that the visible change is minimized. 2/ The dash was programmatically added in at the code stage previously. This bug fix splits the the single concatenation mess into parts which can be styled. This puts the dash back into the template. However, it should be noted that the spacing for the 0 tab's tag and tag description will have an extra space after the hypen that was lacking before. 3/ ...... is different than ... ... The later puts that extra space. This patch fixes that. See comment 1 for the test plan. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Small koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 13:45:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 11:45:04 +0000 Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 26919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26919&action=edit Bug 11885 - followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 13:45:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 11:45:50 +0000 Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 14:16:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 12:16:31 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #62 from Paola Rossi --- In ACQ, I create a fund whose name is "fund1 ???" for a budget. I order a biblio, and I receive the order. In the "Receipt summary", in the table of the "Already received", I see: 1.A) in the 8-th column "Fund", the name of the fund with the right chars; 1.B) in the 7-th column "Quantity", at the "Subtotal for", the name of the fund with bad chars: "Subtotal for fund1 ??????". ----------------------------------------------------------------- So I pass the status to "Failed QA". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 14:26:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 12:26:16 +0000 Subject: [Koha-bugs] [Bug 12056] Untranslatable strings in calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12056 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 14:44:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 12:44:05 +0000 Subject: [Koha-bugs] [Bug 12056] Untranslatable strings in calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12056 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 14:44:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 12:44:24 +0000 Subject: [Koha-bugs] [Bug 12055] Typo "holdiay" in calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12055 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 14:44:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 12:44:30 +0000 Subject: [Koha-bugs] [Bug 12056] Untranslatable strings in calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12056 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 15:18:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 13:18:21 +0000 Subject: [Koha-bugs] [Bug 12056] Untranslatable strings in calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12056 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 15:18:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 13:18:24 +0000 Subject: [Koha-bugs] [Bug 12056] Untranslatable strings in calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12056 --- Comment #1 from Owen Leonard --- Created attachment 26920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26920&action=edit Bug 12056 - Untranslatable strings in calendar In the calendar there are some strings in a JavaScript function which are not properly wrapped in a function for translation. This patch corrects this. This patch also corrects some minor validation issues and spelling and grammar issues, including those covered by Bug 12055. To test, apply the patch and view the calendar in Tools -> Calendar. When you hover your mouse over a day in the calendar you should see a title tooltip indicating what kind of day/holiday it is and showing the title of the holiday, if any. To test that the strings are now being picked up for translation, run translate update on a po file and confirm that the affected strings are now present: "Weekly holiday," "Yearly holiday," etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 15:25:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 13:25:54 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 15:25:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 13:25:58 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #63 from Jonathan Druart --- Created attachment 26921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26921&action=edit Bug 11944: Fix fund names encoding on the parcel page On the parcel page, the subtotal values are stored in an hashref. The key was the fund name. The fund name being encoded in utf8, the hashref was broken. This patch replaces this logic creating a key based on an integer. The budget name is now stored in a new "budget_name" key. Note: It also fixes a small ergonomic issue (a td was missing in the tfoot). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 15:57:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 13:57:13 +0000 Subject: [Koha-bugs] [Bug 12057] New: anonymous suggestions showing to all Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12057 Bug ID: 12057 Summary: anonymous suggestions showing to all Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org If a library allows anonymous suggestions it looks like those are showing to all patrons. Since the anonymous suggestions do have a borrowernumber I'm not sure how or why this is happening, but I have seen it with my own eyes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 16:24:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 14:24:02 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 17:18:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 15:18:04 +0000 Subject: [Koha-bugs] [Bug 9979] convert ./C4/Installer/PerlDependencies.pm into a YAML file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 17:18:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 15:18:48 +0000 Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in opac-detail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 17:18:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 15:18:58 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fcapovilla at live.ca |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:09:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:09:25 +0000 Subject: [Koha-bugs] [Bug 12058] New: OverDrive search results page doesn't show cart, lists, or login links Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Bug ID: 12058 Summary: OverDrive search results page doesn't show cart, lists, or login links Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-overdrive-search.pl?q=X OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The template for the OverDrive search results page in the OPAC lacks "[% USE Koha %]," so all preference checks (e.g. "[% IF ( Koha.Preference( 'opacbookbag' ) == 1 ) %]") fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:18:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:18:28 +0000 Subject: [Koha-bugs] [Bug 12058] OverDrive search results page doesn't show cart, lists, or login links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 --- Comment #1 from Owen Leonard --- More specifically, in the Bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:21:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:21:18 +0000 Subject: [Koha-bugs] [Bug 12058] OverDrive search results page doesn't show cart, lists, or login links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:21:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:21:21 +0000 Subject: [Koha-bugs] [Bug 12058] OverDrive search results page doesn't show cart, lists, or login links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 --- Comment #2 from Owen Leonard --- Created attachment 26922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26922&action=edit Bug 12058 - OverDrive search results page doesn't show cart, lists, or login links The template for OverDrive search results in the Bootstrap OPAC doesn't show the cart, lists, or login links because the template's checks of related system preferences relies on [% USE Koha %], which is not present. This patch adds it. To test, enable the bootstrap theme and OverDrive integration (OverDriveClientKey, etc.). Perform a search in the OPAC and click to view results from your OverDrive library. Confirm that cart, lists, and login links appear in the header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:48:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:48:00 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:48:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:48:05 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26077|0 |1 is obsolete| | --- Comment #35 from Owen Leonard --- Created attachment 26923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26923&action=edit Bug 10865 [Follow-up] Add style to warning This patch adds a new "hint" class for displaying information relating to a form field. On the list edit screen the hint also has an alert class to highlight it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:50:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:50:48 +0000 Subject: [Koha-bugs] [Bug 12059] New: Publisher code always empty on invoice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Bug ID: 12059 Summary: Publisher code always empty on invoice Change sponsored?: --- Product: Koha Version: master Hardware: All URL: cgi-bin/koha/acqui/invoice.pl?invoiceid=34 OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The invoice has a column labelled 'Publisher' that always appears to be empty. I checked that the title I tested with had 260$a$b$c and biblioitems.publishercode in the database had a value. Note: Also the library column there seems to have no function? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:52:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:52:31 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:52:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:52:35 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26534|0 |1 is obsolete| | Attachment #26535|0 |1 is obsolete| | Attachment #26558|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer --- Created attachment 26924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26924&action=edit [PASSED QA] Bug 10613: The gst rate is not correctly calculated on the invoice page. Test plan: Defined a gst rate on creating an order, receive it and check that all prices are correctly calculated. /!\ Behavior change function of supplier parameters (Include/Don't include tax for list prices and invoice prices) Notes: patch tested with Bug 11755 applied first; confirmed that: - price calculations are correct for all combinations of listincgst/invoiceincgst settings in the vendor record - unitprice (aka "Actual cost") is taken into account on the invoice page instead of rrp/ecost, like it should. Amended patch: Don't change the supplierid/booksellerid parameter. Signed-off-by: Jacek Ablewicz Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:53:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:53:21 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off Patch complexity|Small patch |--- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12059 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:53:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:53:21 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10613 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:53:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:53:28 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #43 from Katrin Fischer --- Created attachment 26925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26925&action=edit [PASSED QA] Bug 10613: FIX typo supplierid vs booksellerid GetInvoiceDetails returns a hashref with a key named booksellerid, not supplierid. The bookseller was not retrieved from the DB and the listincgst value was always false. Signed-off-by: Jacek Ablewicz Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:53:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:53:57 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #44 from Katrin Fischer --- Created attachment 26926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26926&action=edit [PASSED QA] Bug 10613: FIX QA issues This patch fixes the following QA issue: FAIL acqui/invoice.pl FAIL valid Useless use of private variable in void context Signed-off-by: Jacek Ablewicz Signed-off-by: Katrin Fischer Patch passes all tests and QA script. Specifically checked the t/db_depenedent/Acq* tests. A test plan could be: 0) Add a value in the gist pref (0.1 or 0.25 or something else easy). 1) a) Create a supplier "10613 0 0" with List item price includes tax: No Invoice item price includes tax: No Tax: 10% b) Create a supplier "10613 0 1" with List item price includes tax: No Invoice item price includes tax: Yes Tax: 10% c) Create a supplier "10613 1 0" with List item price includes tax: Yes Invoice item price includes tax: No Tax: 10% d) Create a supplier "10613 1 1" with List item price includes tax: Yes Invoice item price includes tax: Yes Tax: 10% 2) Create a basket for each supplier a) 00 List price: 10.00 (11.00 with 10% taxes) b) 01 List price: 10.00 (11.00 with 10% taxes) c) 10 List price: 10.00 (9.09 without taxes) d) 11 List price: 10.00 (9.09 without taxes) Note: Information on the basket page is shown correctly. If you look at the list of ordered items for the fund, the list price is used. 3) Create 1+ order(s) with 1+ item(s) for each basket with a discount and a gst value. 4) Close the baskets 5) Receive the items Left actual price as suggested: a) 00 Actual cost: 10.00 b) 01 Actual cost: 11.00 c) 10 Actual cost: 9.09 d) 11 Actual cost: 10.00 Calculations on the invoice page now all appear to be correct. Note: When you take a look at the 'ordered' list for the fund, the actual price is used as entered. 6) Go on acqui/invoice.pl?invoiceid=XX acqui/basket.pl?basketno=YY for each basket/invoice, click on the "Show all details" checkbox and verify that the values are all correct. Calculations are exactly the same for tax registered yes and no. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:54:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:54:37 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10461 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 18:54:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 16:54:37 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10613 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 19:06:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 17:06:44 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #51 from MJ Ray (software.coop) --- Is there any reason not to fix the alignment? In other words, could we combine the two patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 19:14:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 17:14:22 +0000 Subject: [Koha-bugs] [Bug 12055] Typo "holdiay" in calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12055 --- Comment #1 from M. Tompsett --- Created attachment 26927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26927&action=edit Bug 12055 - Typo "holdiay" in calendar $ git grep holdiay | grep -v \.po: This shows there were three typos in koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt TEST PLAN --------- 1) Log in to staff client 2) Click 'Tools' 3) In the Additional tools column, click 'Calendar' -- Note that the word holiday is not spelled correctly in the legend area on the right. 4) Apply patch 5) Refresh page -- Note the spelling is corrected. 6) Run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 19:22:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 17:22:46 +0000 Subject: [Koha-bugs] [Bug 12055] Typo "holdiay" in calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12055 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26927|0 |1 is obsolete| | CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Comment on attachment 26927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26927 Bug 12055 - Typo "holdiay" in calendar Owen has patch in the works on another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 19:34:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 17:34:34 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #52 from Bernardo Gonzalez Kriegel --- (In reply to MJ Ray (software.coop) from comment #51) > Is there any reason not to fix the alignment? In other words, could we > combine the two patches? Yes, of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 19:42:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 17:42:07 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #53 from Bernardo Gonzalez Kriegel --- Created attachment 26928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26928&action=edit Bug 8375 - Followup - Fix font code and alignment This follow up fixes font code taking it from layout, and alignment. To test: 1. Try making a batch using Helv?tica, downloaded PDF do not open. 2. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. 3. Apply the patch 4. Try again 1, now PDF opens 5. Try 2, now alignment is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 19:42:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 17:42:37 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26905|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 19:42:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 17:42:55 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 9 19:58:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Apr 2014 17:58:05 +0000 Subject: [Koha-bugs] [Bug 12056] Untranslatable strings in calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12056 --- Comment #2 from M. Tompsett --- Comment on attachment 26920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26920 Bug 12056 - Untranslatable strings in calendar Review of attachment 26920: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12056&attachment=26920) ----------------------------------------------------------------- Okay. Eyeballed. Now to test. ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt @@ +4,4 @@ > [% INCLUDE 'calendar.inc' %] > > [% INCLUDE 'datatables.inc' %] > + -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 17:05:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 15:05:36 +0000 Subject: [Koha-bugs] [Bug 12003] Next issues for irregular pattern not correctly predicted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26683|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 27050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27050&action=edit [SIGNED-OFF] Bug 12003: Do not calculate next pubdate for irregular subscriptions Show 'Unknown' when planneddate and publisheddate cannot be calculated Also fixes SQL query in misc/cronjobs/serialsUpdate.pl that was still using "periodicity != 32" to exclude irregular subscriptions from results Test plan: 1) Create a subscription in the serials module. Make sure to choose: Frequency = Irregular 2) Test the prediction pattern, first publication date is set to "First issue publication date" field, others will show as 'unknown' 3) Save the subscription 4) Check the created issue - it will show a published date and a planned date (same as "First issue publication date" field) 5) Receive the issue and check the next generated issue, planned date and published date should show as 'Unknown' 6) Generate a next issue, planned date and published date should also show as 'Unknown' Signed-off-by: Bernardo Gonzalez Kriegel Work as described following test plan. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 17:05:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 15:05:52 +0000 Subject: [Koha-bugs] [Bug 12003] Next issues for irregular pattern not correctly predicted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 17:41:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 15:41:43 +0000 Subject: [Koha-bugs] [Bug 12073] OPAC detail page printing show links URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 17:41:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 15:41:46 +0000 Subject: [Koha-bugs] [Bug 12073] OPAC detail page printing show links URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27030|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 27051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27051&action=edit [PASSED QA] Bug 12073 - OPAC detail page printing show links URL On OPAC Bootstrap detail page, by clicking Print link on the right the page is printed. But the printed page contains HTML anchors URL attribute. It's useless, and unreadable. It isn't the case with prog theme. This page hide all href attributes when printing any OPAC page. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works as described and improves the printed detail page's readability. Currently there is no less file for the print.css. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 17:49:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 15:49:18 +0000 Subject: [Koha-bugs] [Bug 12069] If you access members/mod_debarment.pl when logged out you are redirected to OPAC login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 17:49:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 15:49:23 +0000 Subject: [Koha-bugs] [Bug 12069] If you access members/mod_debarment.pl when logged out you are redirected to OPAC login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27028|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 27052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27052&action=edit [PASSED QA] Bug 12069 - If you access members/mod_debarment.pl when logged out you are redirected to OPAC login members/mod_debarment.pl's call to checkauth should pass 'intranet' so that if the user happens to be logged out they will be redirected to the staff client login form. To test, apply the patch and log in to the staff client: - Add a restriction to a patron's account. - View the restrictions tab on the patron's account. You should see the restriction and a "Remove" link for that restriction. - In another tab, log out of the staff client. - In the first tab, click the "Remove" link. You should be redirected to the staff client login page. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Good catch! Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 17:54:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 15:54:34 +0000 Subject: [Koha-bugs] [Bug 11481] new reservation syspref HoldOnlyWhenAllItemsOnLoan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 --- Comment #8 from michot --- Sorry but I don't accede to any sandbox, so i can't look at the rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 18:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 16:04:40 +0000 Subject: [Koha-bugs] [Bug 12076] xt/tt_valid.t can miss an invalid construct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 18:04:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 16:04:43 +0000 Subject: [Koha-bugs] [Bug 12076] xt/tt_valid.t can miss an invalid construct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27043|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 27053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27053&action=edit [PASSED QA] Bug 12076: better detect an untranslatable template construct Per bug 6458, template constructs of the form

  • [2] Run prove -v xt/tt_valid.t. Note that no error is reported. [3] Apply the patch, and rerun the tt_valid.t test. This time, an error should be reported. Signed-off-by: Galen Charlton Signed-off-by: Bernardo Gonzalez Kriegel Works well, detects the forbidden pattern No koha-qa errors. Signed-off-by: Katrin Fischer Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 19:36:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 17:36:56 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23744|0 |1 is obsolete| | Attachment #26971|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 27054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27054&action=edit [PASSED QA] Bug 11219 - CAS authentication fails with URL parameters Bug 10029 tries to fix the use of URL parameters in CAS authentication. But is does not work. The full URL must be used in all methods of C4::Auth_with_cas. Also, in checkpw_cas(), the 'ticket' parameter must be removed to find the original URL. This patch removes the 'ticket' parameter from query before calling checkpw_cas() since the ticket is passed as method arguemnt. In C4::Auth_with_cas, many methods use the same code to get the CAS handler and the service URI. This patch adds a private method _get_cas_and_service() to do the job. Test plan: - Enable CAS - Go to opac without been logged-in - Try to place hold on a record => You get to /cgi-bin/koha/opac-reserve.pl?biblionumber=XXX showing authentication page => Check that CAS link contains query param "biblionumber" - Click on CAS link and log in => Check you return well logged-in to reserve page with biblionumber param - Check CAS loggout - Check Proxy CAS auth Signed-off-by: Koha team AMU Signed-off-by: Katrin Fischer Passes all tests in t, xt, and t/db_dependent/Auth.t. Also passes QA script. As I have no working CAS server, I focused on regression testing: Activated Persona and casAuthentication. - Verified normal login against database still works. - Verified Persona login works. Note: With Persona you are always forwarded to the patron account - so you have to search for the record again before you can place a hold. - Verified that the CAS URL contains the biblionumber when logging in while placing a hold. Signed-off-by: Katrin Fischer Retested 2014-04-12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 19:37:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 17:37:54 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 --- Comment #11 from Katrin Fischer --- First patch is PQA, I signed off on the second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 19:54:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 17:54:47 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 --- Comment #12 from Katrin Fischer --- Created attachment 27055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27055&action=edit [SIGNED OFF] Bug 11219 - CAS authentication fails with URL parameters - followup This followup corrects the fact that when using $query->url(), both GET and POST params are get. Using $query->url_param() will only get params directly in URL. Test plan : - Enable CAS - Go to login page : cgi-bin/koha/opac-user.pl - Try to connect with local login using random login and password (they will be transmitted by POST) - You stay to login page - Look at CAS login URL => Without this patch it will contain the random login and password as parameters of opac-user.pl => With this patch it does not contain any parameter Signed-off-by: Matthias Meusburger Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 19:59:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 17:59:09 +0000 Subject: [Koha-bugs] [Bug 12076] xt/tt_valid.t can miss an invalid construct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12076 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 20:01:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 18:01:19 +0000 Subject: [Koha-bugs] [Bug 12069] If you access members/mod_debarment.pl when logged out you are redirected to OPAC login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 20:09:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 18:09:14 +0000 Subject: [Koha-bugs] [Bug 12073] OPAC detail page printing show links URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12073 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Fr?d?ric! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:14:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:14:36 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:14:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:14:52 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21535|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:15:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:15:10 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21536|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:15:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:15:25 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21537|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:15:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:15:41 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21538|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:15:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:15:54 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:16:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:16:11 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:16:28 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:16:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:16:42 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21857|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:18:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:18:17 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:20:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:20:28 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #30 from Bernardo Gonzalez Kriegel --- Created attachment 27056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27056&action=edit Bug 10963 - Simplified creation - FA framework Patch 1/9 This patch modifies Fast Add framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:20:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:20:36 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #31 from Bernardo Gonzalez Kriegel --- Created attachment 27057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27057&action=edit Bug 10963 - Simplified creation - BKS framework Patch 2/9 This patch rewrites BKS framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:20:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:20:44 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #32 from Bernardo Gonzalez Kriegel --- Created attachment 27058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27058&action=edit Bug 10963 - Simplified creation - CF framework Patch 3/9 This patch rewrites CF framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:20:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:20:52 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #33 from Bernardo Gonzalez Kriegel --- Created attachment 27059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27059&action=edit Bug 10963 - Simplified creation - SR framework Patch 4/9 This patch rewrites SR framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:20:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:20:59 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #34 from Bernardo Gonzalez Kriegel --- Created attachment 27060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27060&action=edit Bug 10963 - Simplified creation - VR framework Patch 5/9 This patch rewrites VR framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:21:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:21:07 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #35 from Bernardo Gonzalez Kriegel --- Created attachment 27061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27061&action=edit Bug 10963 - Simplified creation - AR framework Patch 6/9 This patch rewrites AR framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:21:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:21:15 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #36 from Bernardo Gonzalez Kriegel --- Created attachment 27062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27062&action=edit Bug 10963 - Simplified creation - KT framework Patch 7/9 This patch rewrites KT framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:21:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:21:24 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #37 from Bernardo Gonzalez Kriegel --- Created attachment 27063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27063&action=edit Bug 10963 - Simplified creation - IR framework Patch 8/9 This patch rewrites IR framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:21:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:21:31 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #38 from Bernardo Gonzalez Kriegel --- Created attachment 27064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27064&action=edit Bug 10963 - Simplified creation - SER framework Patch 9/9 This patch rewrites SER framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:21:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:21:39 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #39 from Bernardo Gonzalez Kriegel --- Created attachment 27065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27065&action=edit Bug 10963 - Revert old hidden values This patch reverts old hidden values to marc_subfield_structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 12 21:25:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Apr 2014 19:25:12 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #40 from Bernardo Gonzalez Kriegel --- New set of patches. Some kind of test plan on Comment 26 I have checked that all old hidden values are present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 13 11:18:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Apr 2014 09:18:55 +0000 Subject: [Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Marc V?ron --- I reported this bug in 2012. I can no longer reproduce the behaviour on current master (3.15.00.028) I hope it's OK to set it to RESOLVED WORKSFORME Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 13 11:31:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Apr 2014 09:31:22 +0000 Subject: [Koha-bugs] [Bug 7985] In Checkout, list of items checked out should show Charge from table accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7985 --- Comment #2 from Marc V?ron --- Re-tested with current master (3.15.00.028), bug is still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 13 11:37:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Apr 2014 09:37:00 +0000 Subject: [Koha-bugs] [Bug 8894] Software error calling Help on Local use in System preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8894 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Marc V?ron --- Works now with current master (3.15.00.028) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 13 11:42:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Apr 2014 09:42:20 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 13 12:18:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Apr 2014 10:18:18 +0000 Subject: [Koha-bugs] [Bug 7997] can create a notice with the same code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #13 from Marc V?ron --- Still valid with 3.15.00.028 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 13 12:49:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Apr 2014 10:49:04 +0000 Subject: [Koha-bugs] [Bug 7047] renewing serials note not visible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 13 13:03:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Apr 2014 11:03:04 +0000 Subject: [Koha-bugs] [Bug 8797] can't delete quote of the day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 --- Comment #3 from Marc V?ron --- Still valid with 3.15.00.028 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 13 23:13:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Apr 2014 21:13:28 +0000 Subject: [Koha-bugs] [Bug 11955] Remove spaces in empty indicators after linking an authority to a biblio record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26438|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 27066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27066&action=edit [SIGNED-OFF] Remove spaces in empty indicators when linking an authority to a biblio record. http://bugs.koha-community.org/show_bug.cgi?id=11955 Signed-off-by: Bernardo Gonzalez Kriegel To test: 1. Open some authority on editor, save with empty indicators. They are saved as ind1=" " ind2=" " on auth_header tables, with spaces 2. Edit some record, link some tag with previous auth, indicators now have a space on it (or ind1 at last) 3. Apply the patch 4. repeat 2, space is gone Work as described. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 13 23:13:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Apr 2014 21:13:54 +0000 Subject: [Koha-bugs] [Bug 11955] Remove spaces in empty indicators after linking an authority to a biblio record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 13 23:25:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Apr 2014 21:25:11 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Liz Rea --- Kyle, No, I don't think so - it should only be added for git installations and probably then by hand. If someone wants to submit a follow up for that they are welcome to. Mark, I think that is hard to read and that's not the way I would write it. You are welcome to submit a follow up that changes it. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 02:46:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 00:46:23 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #22 from M. Tompsett --- (In reply to Liz Rea from comment #21) > No, I don't think so - it should only be added for git installations and > probably then by hand. The intent is for correcting package installations, and the default value is correct for that. > If someone wants to submit a follow up for that they are welcome to. Though, I still think there may be merit to having something added, at least somewhere, so a person using a git install knows what to tweak. That's the thing I really dislike about LDAP configuration. It's not in the koha-conf.xml file by default. A commented out line would be nice. > Mark, I think that is hard to read and that's not the way I would write it. > You are welcome to submit a follow up that changes it. Granted, your code is easier to read for people unfamiliar with the // operator -- as I was a few months ago. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 05:38:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 03:38:16 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|pasi.kallinen at pttk.fi |bgkriegel at gmail.com Summary|New dateformats are |New dateformat dd.mm.yyyy |stupidly hard to add | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 06:18:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 04:18:54 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 06:18:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 04:18:56 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26790|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 27067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27067&action=edit [SIGNED OFF] Bug 9088: neworderempty should preselect the only fund If there is only one fund in the select combo (and the fund is mandatory), neworderempty should just select it already. If there are more choices, behavior does not change. This patch implements this change in the template itself. Test plan: With more funds, check if neworderempty does not preselect a fund (at least when adding a line; when you modify, you should see what you had chosen). With one fund, check if it is already selected (add or modify). Toggle the setting of AcqCreateItem and check again. Signed-off-by: Mark Tompsett NOTE: I don't think AcqCreateItem affects this. However, I did toggle AcqCreateItem to 'receiving an order' from 'placing an order'. Tested before and after patch with 1 fund Tested after patch with 2 funds. Tiny patch, does what it says. Defaults fund dropdown if there is only one fund. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 06:22:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 04:22:41 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Please use the function C4::Context->IsSuperLibrarian() instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 06:29:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 04:29:18 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 27068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27068&action=edit Bug 12072 - New dateformat dd.mm.yyyy I changed bug description, not quite apropriate language. Really, it's hard :( This patch adds dd.mm.yyyy format as requested. For lack of a better name, I used 'dol', for 'dot on the line' To test: 1. apply the patch 2. run updatedatabase.pl 3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save 4. Test. There are some places where dates are in iso format by design (yyyy-mm-dd), others must shows new 'dol' format Works for circulation, reserves, staff & opac, patrons... But... built-in offline shows correct format on datepicker, but not on checked out items, have not discovered yet how this works. So, not ready for sign-off I suppose, but can be tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 06:32:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 04:32:42 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #5 from Bernardo Gonzalez Kriegel --- A question: in this format a leading zero (as 01.04.2014) is forbidden or allowed? Switch to Needs Signoff, for your consideration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 06:36:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 04:36:06 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27068|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 27069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27069&action=edit Bug 12072 - New dateformat dd.mm.yyyy I changed bug description, not quite apropriate language. Really, it's hard :( This patch adds dd.mm.yyyy format as requested. For lack of a better name, I used 'dol', for 'dot on the line' To test: 1. apply the patch 2. run updatedatabase.pl 3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save 4. Test. There are some places where dates are in iso format by design (yyyy-mm-dd), others must shows new 'dol' format Works for circulation, reserves, staff & opac, patrons... But... built-in offline shows correct format on datepicker, but not on checked out items, have not discovered yet how this works. So, not ready for sign-off I suppose, but can be tested Resubmited, bad message on updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 06:38:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 04:38:23 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 --- Comment #3 from M. Tompsett --- Created attachment 27070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27070&action=edit Bug 12042 - Change text 'Add to basket' into 'Add order to basket' It would be a good idea to clarify better the function of the "add to basket" button on the vendor search results page and on the single basket page. To make that, I suggest to add the word 'order'. So, 'add to basket' would become 'add order to basket'. This is completely based on a cut-paste and git am of work done by Silvia Simonetti. TEST PLAN --------- 1) Log in to the staff client 2) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/booksellers.pl -- It should say 'add to basket'. 3) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/basket.pl?basketno=1 -- Assuming you have a basketno=1, it should say 'add to basket'. 4) Apply patch 5) Repeat steps 2 and 3. -- They should both have 'add order to basket' now. 6) Run koha qa test tools NOTE: I generated the proper patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 06:38:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 04:38:46 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26893|0 |1 is obsolete| | CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 06:53:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 04:53:04 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 06:53:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 04:53:07 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27070|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 27071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27071&action=edit [SIGNED OFF] Bug 12042 - Change text 'Add to basket' into 'Add order to basket' It would be a good idea to clarify better the function of the "add to basket" button on the vendor search results page and on the single basket page. To make that, I suggest to add the word 'order'. So, 'add to basket' would become 'add order to basket'. This is completely based on a cut-paste and git am of work done by Silvia Simonetti. TEST PLAN --------- 1) Log in to the staff client 2) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/booksellers.pl -- It should say 'add to basket'. 3) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/basket.pl?basketno=1 -- Assuming you have a basketno=1, it should say 'add to basket'. 4) Apply patch 5) Repeat steps 2 and 3. -- They should both have 'add order to basket' now. 6) Run koha qa test tools -- The problems mentioned on "221" are not related to this patch. Signed-off-by: Mark Tompsett NOTE: I generated the proper patch. And wrote the test plan more clearly. This patch does what it says it will do. However, I am not sure the rewording is best. Consider that the button on the basket page triggers a modal similar to the section at the bottom of the page. That is, is the button even necessary? Though, the rename of the button now will match the section header 'Add order to basket'. I leave the design decisions to someone else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 07:33:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 05:33:57 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27049|0 |1 is obsolete| | --- Comment #30 from M. Tompsett --- Created attachment 27072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27072&action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new OPAC system preference, OpacProtocol, in the Policy subsection. It defaults to "doesn't use" (http://), but can be changed to "uses" (https://). Both basket/sendbasket.pl and virtualshelves/sendshelf.pl were tweaked to always set OPACBaseURL. If OPACBaseURL is undef or not set, the URL is not given in the corresponding template files. opac/opac-sendshelf.pl was returned to previous state, because it affects doc-head-close.inc if OPACBaseURL is not passed. This should be fixed to use the OpacProtocol system preference in another bug fix. However, this is OPAC, not Staff, and outside of the bugs scope. Both basket/sendbasket.tt and virtualshelves/sendshelf.tt template files contain the suggested Koha.Preference logic recommended by Kyle in comment #21. TEST PLAN --------- 1) Back up your database 2) Drop your koha database and recreate it empty 3) In the mysql client: > SOURCE .../installer/data/mysql/sysprefs.sql; -- It should run without error. > SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 4) Restore your database 5) $ ./installer/data/mysql/updatedatabase.pl -- It should run the upgrade to insert OpacProtocol. 6) In the mysql client: > SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 7) Log into the staff client 8) Click 'Koha administration' 9) Click 'Global system preferences' 10) Click the 'OPAC' tab on the left side. 11) Scroll down to the Policy section, and find the OpacProtocol preference. -- It should have a value of "doesn't use" in the drop down. 12) Fill your cart with something(s). 13) Make sure you have a list filled with something(s). 14) Click 'Cart' in the top menu bar area. 15) Click 'Send', and send it to yourself. 16) Click 'Close window' 17) Click 'Hide window' 18) Click 'More' and click 'Lists' 19) Choose a list and 'Send list' to yourself. 20) Check your email -- both emails should have OPAC URLs which start with http:// 21) Change the OPAC system preference OpacProtocol to 'uses' (https://), log out and log in (to force refresh of cached system preferences), and repeat steps 14 through 19. 22) Check your email -- the two new emails should have OPAC URLS which start with https:// NOTE: Other URLs may be broken as well, this bug only fixes carts and lists sent from staff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 08:01:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 06:01:14 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26709|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 27073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27073&action=edit Bug 10823 - add class info to enumchron data in detail.tt, for better styling By adding span tags, styling ability can be improved. This included serialseq and pubdate classes. This update reflects suggestions by Katrin (comment #7) and a conversation with oleonard our resident expert. (http://irc.koha-community.org/koha/2014-04-03#i_1491135) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 08:02:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 06:02:35 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20790|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 08:06:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 06:06:58 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27073|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 27074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27074&action=edit Bug 10823 - Follow up to correct problem with origin patch This fixes the itemloo's by changing them to item. This update reflects suggestions by Katrin (comment #7) and a conversation with oleonard our resident expert. (http://irc.koha-community.org/koha/2014-04-03#i_1491135) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 08:13:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 06:13:13 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27074|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 27075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27075&action=edit Bug 10823 - Follow up to correct problem with origin patch This fixes the itemloo's by changing them to item. This restores proper logic for the --'s. This update reflects suggestions by Katrin (comment #7) and a conversation with oleonard our resident expert. (http://irc.koha-community.org/koha/2014-04-03#i_1491135) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 08:27:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 06:27:00 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10825 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 08:27:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 06:27:00 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion Depends on| |10823 --- Comment #19 from M. Tompsett --- This will solve the duplicate problem after the styling issue is dealt with. Hence, I have made this depend on 10823. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 08:51:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 06:51:48 +0000 Subject: [Koha-bugs] [Bug 11441] Ability to globally remove authorities with no bibliographic record linked. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11441 --- Comment #9 from Juan Romay Sieira --- (In reply to Galen Charlton from comment #8) > Pushed to master. Thanks, Juan! You're welcome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 09:47:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 07:47:29 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #37 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #36) > This gives a koha-qa error, but on another user/env not. > Really don't know Maybe your koha-qa repository is not up-to-date? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 09:54:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 07:54:07 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 --- Comment #3 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #2) > Works, but > > 1. Think you need to add the new syspref on > installer/data/mysql/updatedatabase.pl In sysprefs.sql, yes :) > 2. The check > if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { > must be written > if ( CheckVersion($DBversion) ) { > because it does not run as is on master Oops, originally this patch was for a 3.10 branch, I forgot to change that. New patch coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 09:54:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 07:54:18 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 09:54:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 07:54:21 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26914|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 27076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27076&action=edit Bug 12052: Display a patron message on the summary page Test plan: Fill the OPACMySummaryNote with html code or just text. The content should be displayed at the OPAC on the summary page for patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 10:09:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 08:09:44 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #23 from M. de Rooy --- This patch does not deal with DOM indexing. In the biblio-koha-indexdefs.xml/biblio-zebra-indexdefs.xsl files that govern dom indexing (compare them with record.abs for grs1), I see Date/time-last-modified. I think it would be consistent to use the same fieldname here too. Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 10:34:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 08:34:44 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 10:34:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 08:34:47 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25884|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 27077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27077&action=edit Bug 11797 - Odd number of elements in hash This was discovered when someone triggered an authority search on an authority record that was missing what is assumed the default subfield for a given field. It, however, also can be triggered in an OPAC authority search by looking at the record that lacks the default subfield for a given field. TEST PLAN --------- 1) Create an authority record with 180$x and NOT 180$v. See C4::AuthoritiesMarc::BuildSummary in the 1.. foreach loop for known tags and default values. The default subfields are the first letter of the $subfields_to_report string. 2) Trigger the bug: Method 1: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=# Where # is the authority id of your tweaked record. The error occurs in Normal view. Method 2: Home -> Cataloging -> + New record -> Click the 'Tag Editor' on 100$a Editing of $a to $b and back may be required. 3) Notice there is an error log entry. 4) Apply the patch 5) Attempt to trigger the bug again 6) That specific error log entry is not generated. Signed-off-by: Marcel de Rooy Could generate the warning with a missing 151$a with both methods. No warning anymore after applying this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 10:44:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 08:44:42 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 10:44:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 08:44:46 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26321|0 |1 is obsolete| | --- Comment #133 from M. de Rooy --- Created attachment 27078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27078&action=edit Bug 7143 : Updating history with new developers Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 10:46:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 08:46:27 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #134 from M. de Rooy --- QA Comment: Taking the liberty to pass QA on this trivial (recurring) string patch. Verified the new names with git log. Note that we still miss some names (see earlier comment). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 11:00:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 09:00:45 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 11:45:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 09:45:32 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 --- Comment #11 from M. de Rooy --- (In reply to Katrin Fischer from comment #10) > Is there a reason not to fix the old update? :) I agree that we can fix older updates. And in this case testing the older dbrev is more or less a theoretical problem. (By resetting Version and adding one SetVersion line in updatedatabase, we can achieve the same result.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 11:46:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 09:46:14 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 11:46:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 09:46:17 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26542|0 |1 is obsolete| | --- Comment #12 from M. de Rooy --- Created attachment 27079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27079&action=edit Bug 11846 - Correct database update for debarments with 9999-12-31 The borrowers with infinite debarments have borrowers.debarred with '9999-12-31'. Database update for this bug contained : INSERT INTO borrower_debarments ( borrowernumber, expiration, comment ) SELECT borrowernumber, debarred, debarredcomment FROM borrowers WHERE debarred IS NOT NULL For borrowers where borrowers.debarred is '9999-12-31', this value is copied into borrower_debarments.expiration. This is not correct because borrower_debarments.expiration must be NULL for infinite debarments. This patch corrects update 3.13.00.035 and also adds an update for databases already updated. Test plan : - Use a database with version 3.13.00.000 - Set a borrower as restricted for ever (leave until empty) - Use sources to master + patch - Perform updatedatabase - Look at borrower details, tab "Restrictions" => Without patch, you see Expiration 31/12/9999 => With patch, you see Expiration Infinite Signed-off-by: Marcel de Rooy I tested both db revisions by resetting Version of my database (and adding a SetVersion after the revised older dbrev). This was possible since the debarred field still exists in borrowers. (I have my doubts about that, but that goes outside the scope of this report.) Also note that routine _UpdateBorrowerDebarmentFlags puts back 9999-12-31 into borrowers for indefinite debarments (which looks not very consistent). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 11:57:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 09:57:48 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 11:57:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 09:57:53 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27021|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart --- Created attachment 27080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27080&action=edit Bug 11944: Fix encoding issue on adding a subscription If frequencies or numbering patterns contain non-latin characters, so output was broken. To reproduce: - Create a frequency and a numbering pattern with non-latin characters - Add a new subscription using these values - The screen should not contain bad encoded characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 12:06:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 10:06:39 +0000 Subject: [Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 12:06:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 10:06:42 +0000 Subject: [Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26437|0 |1 is obsolete| | --- Comment #10 from M. de Rooy --- Created attachment 27081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27081&action=edit Bug 11253 - tools/inventory.pl output_pref ignores 'iso' parameter passed Took all the output_pref function calls and converted them to the newer hash format parameter. This then gave blank output. Looking at the template file, I decided that the html filter should be after the KohaDates filter. This corrected the display of the date for the dd/mm/yyyy case. TEST PLAN --------- Create a small barcode file from books in a given branch. Set I18N/L10N system preference of dateformat to mm/dd/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Select the branch (i.e. not All libraries) to match. Click submit Table displays dates in "Unseen since" column. Set I18N/L10N system preference of dateformat to yyyy-mm-dd. Go to inventory/stocktaking tool. Browse for the barcode file. Select the branch (i.e. not All libraries) to match. Click submit Table displays dates in "Unseen since" column. Set I18N/L10N system preference of dateformat to dd/mm/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Select the branch (i.e. not All libraries) to match. Click submit KABOOM! Apply patch Go to inventory/stocktaking tool. Browse for the barcode file. Select the branch (i.e. not All libraries) to match. Click submit Table displays dates in "Unseen since" column. Signed-off-by: Marcel de Rooy Before the patch, I had this error when using dateformat=ddmmyy: Template process failed: undef error - The 'day' parameter ("2014") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback at /usr/local/share/perl5/Params/Validate/PP.pm line 633. This patch corrects the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 12:06:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 10:06:58 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #27 from Jonathan Druart --- (In reply to M. de Rooy from comment #26) > OK. In that case I do not exactly understand what keeps you from passing QA > on this patch? I saw that Kyle signed off on it. There are 2 reasons. 1/ I don't see the load difference following the test plan. 2/ There are some calls to memoize_memcached('subroutine_name', memcached => C4::Context->memcached); in the code. If the call is wrong, we should fix it everywhere. If I am wrong, I am not able to pass qa on it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 12:20:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 10:20:35 +0000 Subject: [Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 --- Comment #11 from Jonathan Druart --- Why the last past does not change the call to output_pref for the $cdls variable? It made sense! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 12:32:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 10:32:45 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #21 from Jonathan Druart --- The "owner" field has been introduced in 3.01.00.077 and the restriction by owner already existed before bug 7304. Could you please detail what could be broken? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 12:33:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 10:33:02 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #7 from paxed --- Created attachment 27082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27082&action=edit Add dateformat dd.mm.yyyy Here's my version, which makes things a bit more generic. ---- Add date format dd.mm.yyyy, known internally as dmydot. Make it much easier to add other date formats by passing the date format string to the templates, instead of hard-coding the allowed formats. Testing: (same as bgkriegel's) ---- Things that should be revisited one day: -tinyCME init uses hard-coded dateformat, but the dateformat plugin is not enabled. -dt_add_type_uk_date() should perhaps be made more general. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 12:34:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 10:34:06 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #22 from Jonathan Druart --- Ok, maybe if a restriction exist on "Owner, users and library" and no owner is defined. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 12:49:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 10:49:41 +0000 Subject: [Koha-bugs] [Bug 7985] In Checkout, list of items checked out should show Charge from table accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7985 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkopaczka at afm.edu.pl --- Comment #3 from Rafal Kopaczka --- (In reply to Marc V?ron from comment #2) > Re-tested with current master (3.15.00.028), bug is still valid. It should by fixed in bug 9481 patch. You may test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 12:56:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 10:56:47 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 --- Comment #3 from Marc V?ron --- Kyle, I think it is a good idea to have a subroutine for the age restriction. Until now the code is used only at this place, but later we could expand the age restrictions e.g. to suppress titles in the catalogue if a kid is logged in etc. However, this is a small patch that makes an existing feature usable for Finland as well, and I can imagine that they need it immediately. That's why I kindly ask you to QA paxed's patch. In a next step we could open a bug to clean up the whole sub CanBookBeIssued in Circulation.pm (there is more functionality that could be moved in separate sbroutines). What do you think about? Thanks Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:02:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:02:18 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #70 from Paola Rossi --- I create a list whose name is: ???. ?? I add some biblios to the list [the titles of the added biblios contain greek and japanese chars]. I try to "Send list" to my email. Either I give over-255 chars in the "Comment" of the mail, or I don't give any over-255 char in the "Comment" of the mail, I see this abnormal termination: Software error: Wide character in subroutine entry at /var/root-koha/bug-11944/virtualshelves/sendshelf.pl line 134. I use the 17 sandbox. I create a list whose name is: ???. ?? I add some biblios to the list [the titles of the added biblios contain greek and japanese chars]. Either I give over-255 chars in the "Comment" of the mail, or I don't give any over-255 char in the "Comment" of the mail, the answer of koha is right: Messaggio inviato La lista ? stata mandata a: paola.rossi at cineca.it Chiudi la finestra So I receive the expected mail. The received file is OK with right chars, while the subject of the mail is the string "no subject". So I pass the patch to "Failed QA" status. NB. In the messagge: La lista ? stata mandata a: ... [i.e. the list has been sent to ...] the name of the list is not shown, whilest I might select among a lot of lists of mine. So koha gives no feedback about which list has been sent, and I can't see the list name on this page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:12:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:12:30 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26903|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 27083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27083&action=edit Proposed patch v2 Use IsSuperLibrarian function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:12:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:12:38 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:28:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:28:50 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #20 from Mason James --- (In reply to M. Tompsett from comment #16) > Magnus, the first one does not account for Nicole's comment #12. However, > since I do not know the validity of the suggestion, I coded a counter-patch > which does account for it as noted in comment #14. > > You apply one or the other -- not both. > > The first patch will only put out enumchron if enumchron is defined, and if > it is not defined, then it will consider putting out serialseq. > > The second patch will put out both enumchron and serialseq if they are > different. And it will only put them out if they are defined. > > Hope this clears that up. Mark's patch sounds better than my patch, lets use that one... i will mark my patch 'obsolete' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:29:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:29:30 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:33:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:33:27 +0000 Subject: [Koha-bugs] [Bug 12075] jQueryUI upgrade broke keyboard shortcuts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12075 --- Comment #2 from Marc V?ron --- Created attachment 27084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27084&action=edit [Signed-off] Bug 12075 - jQueryUI upgrade broke keyboard shortcuts The recent jQueryUI upgrade broke keyboard shortcuts in the staff client because of changes to the jQueryUI API. This patch fixes the problem. To test, apply the patch and clear your browser cache if necessary. - View any page in the staff which includes header search tabs for check out, check in, or catalog search (staff client home page or circulation page for instance). - Test the keyboard shortcuts: Alt-q for catalog search, Alt-u for check out, Alt-r for check in. - Each keyboard shortcut should select the correct tab. Followed test plan, patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:34:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:34:16 +0000 Subject: [Koha-bugs] [Bug 12075] jQueryUI upgrade broke keyboard shortcuts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12075 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27034|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:34:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:34:40 +0000 Subject: [Koha-bugs] [Bug 12075] jQueryUI upgrade broke keyboard shortcuts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12075 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:35:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:35:39 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #23 from Katrin Fischer --- Hi Jonathan, the git bisect I did led me back to bug 7304 - so somehow the behaviour change was introduced at this point. I am not trying to be difficult here, but I think fixing the logic would really be better. If you select owners, users and library, and there are no users, it still works - why rely on an owner if the library is set? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:38:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:38:34 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 --- Comment #11 from Mason James --- Created attachment 27085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27085&action=edit Bug 10823 - Follow up to add to '--' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:41:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:41:52 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27075|0 |1 is obsolete| | --- Comment #12 from Mason James --- Created attachment 27086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27086&action=edit Bug 10823 - Follow up to correct problem with origin patch This fixes the itemloo's by changing them to item. This restores proper logic for the --'s. This update reflects suggestions by Katrin (comment #7) and a conversation with oleonard our resident expert. (http://irc.koha-community.org/koha/2014-04-03#i_1491135) Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:45:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:45:44 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27085|0 |1 is obsolete| | --- Comment #13 from Mason James --- Created attachment 27087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27087&action=edit Bug 10823 - Follow up to add to '--' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:47:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:47:07 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 --- Comment #14 from Mason James --- bug needs sign-off on patch 1 and 3... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 13:48:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 11:48:46 +0000 Subject: [Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Alessandra Carassiti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.carassiti at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:03:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:03:25 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:03:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:03:30 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26898|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 27088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27088&action=edit Bug 12019: It should not be mandatory to define an owner if a fund is restricted Before this patch, the C4::Budgets::CanUserUseBudget assumed that budget_owner_id was set if a restriction (budget_permission) exists. see && $budget->{budget_owner_id} && $budget->{budget_owner_id} != $borrower->{borrowernumber} Actually a restriction could exists on users and/or library without being forced to defined an owner. Test plan: Create a fund A without restriction Create a fund B restricted to an owner Create a fund C restricted to a non defined owner Create a fund D restricted to owner and users (try defining/no defining an owner and/or users) Create a fund E restricted to owner, users and library (try defining/no defined an owner and/or users) With different logged in users, try to show/edit these differents funds. The restriction should be correctly applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:04:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:04:21 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 --- Comment #4 from Kyle M Hall --- Created attachment 27089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27089&action=edit Bug 11630 [QA Followup] - Move code to subroutine, add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:05:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:05:04 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:09:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:09:35 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:12:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:12:10 +0000 Subject: [Koha-bugs] [Bug 8797] can't delete quote of the day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #4 from Chris Nighswonger --- I cannot reproduce this bug on 3.14.03.000 running over our production DB which contains 86 quotes. Adding the 87th quote works as expected including deleting without a page refresh. I would be interested to know if those who are experienceing this bug are adding quote number 1 to a DB containing no quotes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:18:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:18:15 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26225|0 |1 is obsolete| | --- Comment #21 from Mason James --- Created attachment 27090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27090&action=edit Bug 10825 - detail.tt displays duplicated enumchron values for serial items TEST PLAN --------- 1) Find a data point that displays like the picture on this bug report. 2) Apply the patch 3) Refresh the screen 4) Does it look like the second picture now with the duplication removed? 5) Run koha qa test tools I did attempt with default and blank for the XSLT system preferences for the staff client. This accounts for Nicole's comment #12. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:20:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:20:35 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #22 from Mason James --- Mark you might need to update the 'author' of your patch.. you patch still has my name on it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:21:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:21:19 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10823 | Blocks| |10823 Depends on|10823 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:21:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:21:19 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10825 | Depends on| |10825 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10825 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:27:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:27:00 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20790|0 |1 is obsolete| | Attachment #27086|0 |1 is obsolete| | Attachment #27087|0 |1 is obsolete| | --- Comment #15 from Mason James --- Created attachment 27091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27091&action=edit Bug 10823 - add class info to enumchron data in detail.tt, for better styling squashing 3 patches, and rebasing after 10825 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:32:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:32:08 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #23 from Mason James --- (In reply to Mason James from comment #22) > Mark you might need to update the 'author' of your patch.. > > you patch still has my name on it i've tested Mark's patch, it looks good and works as expected thanks Mark! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:40:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:40:38 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27091|0 |1 is obsolete| | --- Comment #16 from Mason James --- Created attachment 27092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27092&action=edit Bug 10823 - add class info to enumchron data in detail.tt, for better styling squashing 3 patches, and rebasing after 10825 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:47:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:47:44 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- > I tested both db revisions by resetting Version of my database (and > adding a SetVersion after the revised older dbrev). This was possible since > the debarred field still exists in borrowers. (I have my doubts about that, > but that goes outside the scope of this report.) Yes, borrower.debarred was retained for both speed and the fact that we wouldn't need to modify all the code that checks this field. > Also note that routine _UpdateBorrowerDebarmentFlags puts back 9999-12-31 > into borrowers for indefinite debarments (which looks not very consistent). Agreed, but again this is due to the extended feature being "backwards compatible" with the original debarment system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:50:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:50:30 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:50:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:50:34 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27079|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 27093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27093&action=edit Bug 11846 - Correct database update for debarments with 9999-12-31 The borrowers with infinite debarments have borrowers.debarred with '9999-12-31'. Database update for this bug contained : INSERT INTO borrower_debarments ( borrowernumber, expiration, comment ) SELECT borrowernumber, debarred, debarredcomment FROM borrowers WHERE debarred IS NOT NULL For borrowers where borrowers.debarred is '9999-12-31', this value is copied into borrower_debarments.expiration. This is not correct because borrower_debarments.expiration must be NULL for infinite debarments. This patch corrects update 3.13.00.035 and also adds an update for databases already updated. Test plan : - Use a database with version 3.13.00.000 - Set a borrower as restricted for ever (leave until empty) - Use sources to master + patch - Perform updatedatabase - Look at borrower details, tab "Restrictions" => Without patch, you see Expiration 31/12/9999 => With patch, you see Expiration Infinite Signed-off-by: Marcel de Rooy I tested both db revisions by resetting Version of my database (and adding a SetVersion after the revised older dbrev). This was possible since the debarred field still exists in borrowers. (I have my doubts about that, but that goes outside the scope of this report.) Also note that routine _UpdateBorrowerDebarmentFlags puts back 9999-12-31 into borrowers for indefinite debarments (which looks not very consistent). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:51:18 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|sophie.meynieux at biblibre.co |kyle at bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 14:51:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 12:51:34 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 15:00:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 13:00:11 +0000 Subject: [Koha-bugs] [Bug 12071] javascript broken for a search with double quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 --- Comment #3 from Fridolin SOMERS --- (In reply to Owen Leonard from comment #2) > I can't reproduce this bug in master. I found it occurs on a server with Debian Squeeze and not on my laptop with Ubuntu 13.10, maybe a difference in library URI::Escape. Still it must be corrected because most of libraries servers run Debian Squeeze. Also, escaping URL characters into TT is a better code, regarding to MVC layers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 16:37:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 14:37:47 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 16:37:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 14:37:56 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #71 from Jonathan Druart --- Created attachment 27094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27094&action=edit Bug 11944: Fix encoding on sending emails This patch fixes 2 places where mails were badly encoded: 1/ At the opac and the intranet, on sending baskets 2/ At the opac and the intranet, on sending shelf/list Test plan: Shelf/List: - Create a list with non-latin characters in the name. - Add some items containing non-latin characters in their content. - Send the list by email Basket/Cart: - Add some items containing non-latin characters in their content to your cart.. - Send the cart by email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 16:56:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 14:56:18 +0000 Subject: [Koha-bugs] [Bug 8797] can't delete quote of the day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 --- Comment #5 from Owen Leonard --- In my test with the sample quote data when I select a quote and click the delete button nothing happens. However, when I refresh the page the quote is no longer there. Tested with Firefox 28 on Windows using version 3.15.00.028. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 17:28:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 15:28:53 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27054|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 27095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27095&action=edit Bug 11219 - CAS authentication fails with URL parameters Bug 10029 tries to fix the use of URL parameters in CAS authentication. But is does not work. The full URL must be used in all methods of C4::Auth_with_cas. Also, in checkpw_cas(), the 'ticket' parameter must be removed to find the original URL. This patch removes the 'ticket' parameter from query before calling checkpw_cas() since the ticket is passed as method arguemnt. In C4::Auth_with_cas, many methods use the same code to get the CAS handler and the service URI. This patch adds a private method _get_cas_and_service() to do the job. Test plan: - Enable CAS - Go to opac without been logged-in - Try to place hold on a record => You get to /cgi-bin/koha/opac-reserve.pl?biblionumber=XXX showing authentication page => Check that CAS link contains query param "biblionumber" - Click on CAS link and log in => Check you return well logged-in to reserve page with biblionumber param - Check CAS loggout - Check Proxy CAS auth Signed-off-by: Koha team AMU Signed-off-by: Katrin Fischer Passes all tests in t, xt, and t/db_dependent/Auth.t. Also passes QA script. As I have no working CAS server, I focused on regression testing: Activated Persona and casAuthentication. - Verified normal login against database still works. - Verified Persona login works. Note: With Persona you are always forwarded to the patron account - so you have to search for the record again before you can place a hold. - Verified that the CAS URL contains the biblionumber when logging in while placing a hold. Signed-off-by: Katrin Fischer Retested 2014-04-12 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 17:29:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 15:29:06 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 17:29:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 15:29:09 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27055|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 27096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27096&action=edit Bug 11219 - CAS authentication fails with URL parameters - followup This followup corrects the fact that when using $query->url(), both GET and POST params are get. Using $query->url_param() will only get params directly in URL. Test plan : - Enable CAS - Go to login page : cgi-bin/koha/opac-user.pl - Try to connect with local login using random login and password (they will be transmitted by POST) - You stay to login page - Look at CAS login URL => Without this patch it will contain the random login and password as parameters of opac-user.pl => With this patch it does not contain any parameter Signed-off-by: Matthias Meusburger Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 17:57:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 15:57:33 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27076|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 27097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27097&action=edit [SIGNED-OFF] Bug 12052: Display a patron message on the summary page Test plan: Fill the OPACMySummaryNote with html code or just text. The content should be displayed at the OPAC on the summary page for patrons. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 17:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 15:58:35 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:01:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:01:05 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:01:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:01:08 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27083|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 27098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27098&action=edit Bug 12048 - Doesn't display other libraries subscriptions when superlibrarian user This is a regression in master and 3.14. When a user has superlibrian permissions, a search on serials subscriptions must display other libraries subscriptions even when IndependentBranches syspref is enabled. To reproduce/test the bug/patch: 1. Enable IndependentBranches (i.e. 'Prevent' staff...) 2. Login as a user not having superlibrarian permission 3. Search for a serial subscription on: /cgi-bin/koha/serials/serials-search.pl 4. Search a title which has at least 2 subscriptions: one in the user branch, and one in another branch 5. On the result page, just 1 subscription is displayed: the one attached to the userbranch => this is normal 6. Login as a user having superlibrarian permission 7. Repeat step 3-5. 8. You get the same result as 5. You should have seen all subscriptions. That's what you get after applying this patch. Signed-off-by: Mark Tompsett NOTE: I tested a variation. My superlibrarian was a branch that was not the same as the non-superlibrarian. The serial was the same branch as the non-superlibrarian. Without the patch, the superlibrarian saw nothing, with the patch it saw the serial as expected. Also, remember the superserials permission can affect the results. I successfully changed the branch of the subscription, and then it ceased to show up with superserials not granted to the non-superlibrarian. I corrected the system preference name in the text here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:07:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:07:38 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #38 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #37) > Maybe your koha-qa repository is not up-to-date? Was not up to date, but I've updated and got same message. Anyway, with other user I have testing 5 commit(s) (applied to db3d4a0 'Bug 11563: (follow-up) add noEnterSub') OK members/mod_debarment.pl OK xt/tt_valid.t OK koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Could be some environment thing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:19:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:19:17 +0000 Subject: [Koha-bugs] [Bug 11811] tools/import_borrowers.pl doesn't support utf-8 encoded CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11811 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- (In reply to Katrin Fischer from comment #11) > Use case for this is XLS file converted into CSV which includes utf-8 > characters which display correctly in interface but are not searchable > in Koha's patrons search since browser does same decomposition as this > code does. Not so. There is no guarantee that strings entered via the web browser, or patron searches entered via the web browser, will end up in NFC. Consequently, one can end up with a mixture of NFD and NFC data in the database, meaning that patron searches will not necessarily bring up the same results. One of the root issues is the default collation that is typically used. In my development database, it happens to be utf8_general_ci -- which in general is problematic [1], and in particular doesn't treat the NFD and NFC forms of Dobrica's surname as equivalent. Spot-checking suggests that utf8_general_ci ends up as the default for databases installed from Debian packages, with the exception of a couple columns that kohastructure.sql sets to utf8_unicode_ci. Rather than piecemeal sticking in NFC(), I think a better solution would be to change the collation to utf8_unicode_ci across the board. [1] http://stackoverflow.com/questions/1036454/what-are-the-diffrences-between-utf8-general-ci-and-utf8-unicode-ci -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:22:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:22:33 +0000 Subject: [Koha-bugs] [Bug 11811] tools/import_borrowers.pl doesn't support utf-8 encoded CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11811 --- Comment #13 from Galen Charlton --- Created attachment 27099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27099&action=edit script to change collation of Koha's tables to utf8_unicode_ci This is a script to change the collation of Koha's tables to utf8_unicode_ci. Dobrica, please try it and advise if this fixes this particular bug, and whether it works in general for you. Of course, changing the collation like this could have unintended consequences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:23:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:23:15 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #15 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:23:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:23:55 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #135 from Galen Charlton --- Pushed latest to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:24:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:24:11 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:24:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:24:21 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:27:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:27:43 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:27:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:27:45 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27090|0 |1 is obsolete| | --- Comment #24 from M. Tompsett --- Created attachment 27100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27100&action=edit Bug 10825 - detail.tt displays duplicated enumchron values for serial items TEST PLAN --------- 1) Find a data point that displays like the picture on this bug report. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 2) Apply the patch 3) Refresh the screen 4) Does it look like the second picture now with the duplication removed? 5) Run koha qa test tools I did attempt with default and blank for the XSLT system preferences for the staff client. This accounts for Nicole's comment #12. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:33:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:33:00 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:33:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:33:04 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27100|0 |1 is obsolete| | --- Comment #25 from M. Tompsett --- Created attachment 27101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27101&action=edit [SIGNED OFF] Bug 10825 - detail.tt displays duplicated enumchron values for serial items TEST PLAN --------- 1) Find a data point that displays like the picture on this bug report. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 2) Apply the patch 3) Refresh the screen 4) Does it look like the second picture now with the duplication removed? 5) Run koha qa test tools I did attempt with default and blank for the XSLT system preferences for the staff client. This accounts for Nicole's comment #12. Signed-off-by: Mason James Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 18:35:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 16:35:40 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #26 from M. Tompsett --- Considering that both you and I tested it, Mason, and it was initially your patch. I'm not concerned about the author. I'm concerned about getting patches into Koha to improve it. We have two independent folk saying the patch is good. QA'ing seems the next logical step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 19:46:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 17:46:08 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 19:46:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 17:46:12 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #64 from Kyle M Hall --- Created attachment 27102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27102&action=edit Bug 11703 [QA Followup] - Bold record title, fix table width -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 19:47:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 17:47:54 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #65 from Kyle M Hall --- > 1/ The previous checkouts appears but todays checkouts are put in it. Not > logical. Ok, I see this now. I didn't notice it the first time I looked at your screen caps. I have been unable to reproduce this behavior, try as I might! > 2/ The bold: it is a regression, in my opinion. Fixed! > 3/ The width: the table is, now, really narrow on wide screen. Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 20:25:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 18:25:14 +0000 Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 --- Comment #24 from Galen Charlton --- The bug itself appears to be a regression caused by the patch for bug 9394. Specifically, the checkin sequence for circ/returns.pl does this: - ModReserveAffect(), which prior to Robin's proposed patch did not alter the priorities of other holds, just the one whose item is being set to waiting followed by - GetOtherReserves(), which among its many side-effects did fix up the rest of the priorities, via a call to ModReserveMinusPriority, which in turn called _FixPriority. However, this got broken because ModReserveMinusPriority now wants a reserve_id to identify the request being changed, but CheckReserves doesn't provide one, because _Findgroupreserve was never updated to provide reserve_id in every situation. *whew* CheckReserve and _Findgroupreserve failing to provide a reserve_id is a bug, but I think a separate one. Upshot: not to preempt QA, but I think Robin's patch is on the right track. However, it's time to take a hard look at GetOtherReserves, which is used only by circ/returns.pl, and see if it is time for that routine to go. At the very, very least, it need a name other than "GetOtherReserves". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 20:32:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 18:32:54 +0000 Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 --- Comment #25 from Galen Charlton --- Bumping up priority -- issues that mangle the priority of hold requests can make life difficult at the circ desk. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 20:33:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 18:33:04 +0000 Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 20:38:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 18:38:53 +0000 Subject: [Koha-bugs] [Bug 12079] New: CheckReserves() and _Findgroupreserve do not return reserve_id Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12079 Bug ID: 12079 Summary: CheckReserves() and _Findgroupreserve do not return reserve_id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The hold requests returned by _Findgroupreserve do not include reserve_id, which means that the request returned by CheckReserves also does not include reserve_id. If they did, bug 11947 would not have occurred (though the patch for bug 11947 should not be preempted by this bug, IMO). All routines that return hold requests should return the reserve_id to avoid the potential for breakage by other routines that rely on reserve_id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 20:42:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 18:42:20 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27092|0 |1 is obsolete| | --- Comment #17 from M. Tompsett --- Created attachment 27103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27103&action=edit Bug 10823 - add class info to enumchron data in detail.tt, for better styling Bug 10825 removes a duplicate (enumchron==serialseq). This patch was developed on top of it. It properly styles the elements. These include: - items.enumchron - the separator used - serial.serialseq - items.publisheddate As per Katrin's and Owen's suggestion, was used instead of
    . (See comment #7 and http://irc.koha-community.org/koha/2014-04-03#i_1491135) TEST PLAN --------- 1) Apply patch 10825 2) Find a biblio where the enumchron and serialseq are different. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 3) In the staff client, view the source for that item. -- It should be one class for the entire cell. 4) Apply patch 10823 5) Refresh the page 6) Look at the source for that item again. -- It should have tags around the 4 things listed above. 7) Run the koha qa test tools. Signed-off-by: Mark Tompsett NOTE: Since there was lots of squashing and rebasing, could you please test and sign this off as well, Mason? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 20:48:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 18:48:28 +0000 Subject: [Koha-bugs] [Bug 12079] CheckReserves() and _Findgroupreserve do not return reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12079 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 20:48:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 18:48:31 +0000 Subject: [Koha-bugs] [Bug 12079] CheckReserves() and _Findgroupreserve do not return reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12079 --- Comment #1 from Galen Charlton --- Created attachment 27104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27104&action=edit Bug 12079: ensure that CheckReserves() includes reserve_id in its response This patch modifies _Findgroupreserve so that its one caller, CheckReserves(), would include the reserve_id field in the hold request it returns. Failure to include reserve_id in every circumstance resulted in bug 11947. This patch is therefore a complementary fix for that bug, but is not meant to preempt the direct fix for that bug. To test: [1] Verify that t/db_dependent/Reserves.t passes. [2] Verify that the following test plan taken from the patch for bug 11947 works for this patch *without* applying the patch for 11947: * have a few borrowers, say 4. * have a biblio with a single item (you can scale this up, it should work just the same.) * issue the item to borrower A * have borrowers B, C, and D place a hold on the item * return the item, acknowledge that it'll be put aside for B. * view the holds on the item. Without the patch: * the hold priorities in the UI end up being "waiting, 2, 1" when they should be "waiting, 1, 2". * in the database "reserves" table, they're really "0, 2, 3" when they should be "0, 1, 2". With the patch: * the hold priorities in the UI end up being "waiting, 1, 2" * in the database, they're "0, 1, 2" Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 20:49:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 18:49:42 +0000 Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 --- Comment #26 from Galen Charlton --- See also bug 12079. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 21:40:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 19:40:41 +0000 Subject: [Koha-bugs] [Bug 10473] Max length should be 2 digit for adding multiple copies in add items page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P3 CC| |gmcharlt at gmail.com Severity|major |normal --- Comment #9 from Galen Charlton --- (In reply to M. Tompsett from comment #8) > You could use a quick check of the number of records in biblioitems as an > upper limit. No one is going to double the size of their library in one > step, except at the beginning of data entry. ... until we run into a user that wants to create a few thousand items for their photography collection or something. It could happen! I agree with Robin. A hard-coded soft limit to catch typos is fine; IMO we'd need to see a lot more evidence that this is a problem that folks run into often before we get any fancier. I also don't think it is a major bug, so I'm resetting the severity accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 22:54:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 20:54:23 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 22:54:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 20:54:27 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27098|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 27105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27105&action=edit [PASSED QA] Bug 12048 - Doesn't display other libraries subscriptions when superlibrarian user This is a regression in master and 3.14. When a user has superlibrian permissions, a search on serials subscriptions must display other libraries subscriptions even when IndependentBranches syspref is enabled. To reproduce/test the bug/patch: 1. Enable IndependentBranches (i.e. 'Prevent' staff...) 2. Login as a user not having superlibrarian permission 3. Search for a serial subscription on: /cgi-bin/koha/serials/serials-search.pl 4. Search a title which has at least 2 subscriptions: one in the user branch, and one in another branch 5. On the result page, just 1 subscription is displayed: the one attached to the userbranch => this is normal 6. Login as a user having superlibrarian permission 7. Repeat step 3-5. 8. You get the same result as 5. You should have seen all subscriptions. That's what you get after applying this patch. Signed-off-by: Mark Tompsett NOTE: I tested a variation. My superlibrarian was a branch that was not the same as the non-superlibrarian. The serial was the same branch as the non-superlibrarian. Without the patch, the superlibrarian saw nothing, with the patch it saw the serial as expected. Also, remember the superserials permission can affect the results. I successfully changed the branch of the subscription, and then it ceased to show up with superserials not granted to the non-superlibrarian. I corrected the system preference name in the text here. Signed-off-by: Katrin Fischer Superlibrarian permission now allows to see all subscriptions independent from the branch. Passes all tests and QA script. But the superserials permission appears broken to me before and after this patch. If I have superserials - the search doesn't show all subscriptions. If I don't have superserials I can still edit any subscription accessing the subscription detail page through the serial collection page or accessing the detail page directly by manipulating the URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 22:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 20:58:35 +0000 Subject: [Koha-bugs] [Bug 12080] New: Superserials permission appears to be broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Bug ID: 12080 Summary: Superserials permission appears to be broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com 1) IndependentBranches needs to be activated - 'Prevent' 2) Make sure you have some subscriptions, set to different branches 3) Search for all subscriptions with an empty search Problem 1: If the user has the superserials permission, the search doesn't show all subscriptions. Problem 2: If the user doesn't have the superserials permission, you can still edit a subscription accessing the subsscription detail page through the serial collection page (for records with multiple subscriptions) or accessing the detail page directly. Hope I tested this correctly - would be happy if someone could confirm the bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 23:06:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 21:06:45 +0000 Subject: [Koha-bugs] [Bug 12075] jQueryUI upgrade broke keyboard shortcuts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12075 --- Comment #3 from Katrin Fischer --- Created attachment 27106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27106&action=edit [PASSED QA] Bug 12075 - jQueryUI upgrade broke keyboard shortcuts The recent jQueryUI upgrade broke keyboard shortcuts in the staff client because of changes to the jQueryUI API. This patch fixes the problem. To test, apply the patch and clear your browser cache if necessary. - View any page in the staff which includes header search tabs for check out, check in, or catalog search (staff client home page or circulation page for instance). - Test the keyboard shortcuts: Alt-q for catalog search, Alt-u for check out, Alt-r for check in. - Each keyboard shortcut should select the correct tab. Followed test plan, patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Passes all tests and QA script. Confirmed that the shortcuts were broken before the patch and now work again after applying it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 23:07:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 21:07:09 +0000 Subject: [Koha-bugs] [Bug 12075] jQueryUI upgrade broke keyboard shortcuts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12075 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 14 23:07:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 21:07:12 +0000 Subject: [Koha-bugs] [Bug 12075] jQueryUI upgrade broke keyboard shortcuts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12075 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:09:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:09:17 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bgkriegel at gmail.com |pasi.kallinen at pttk.fi --- Comment #8 from Bernardo Gonzalez Kriegel --- Setting back to paxed :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:10:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:10:04 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27069|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Comment on attachment 27069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27069 Bug 12072 - New dateformat dd.mm.yyyy Obsoleted, paxed version is better -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:16:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:16:26 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Looking at the various buttons in the acquisition module some of them seem quite verbose. This change would fit in, but I wonder, if we shouldn't rephrase in the other direction: "Export this basket as CSV", could be "Export as CSV" "Delete this basket", could be "Delete basket" "Add order to basket" or "Add to basket" could be "New order line" or "Add order line". I'd like to get another native speaker's opinion on this - Mark seemed a bit sceptical as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:18:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:18:22 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27082|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 27107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27107&action=edit Add date format dd.mm.yyyy, known internally as dmydot. Make it much easier to add other date formats by passing the date format string to the templates, instead of hard-coding the allowed formats. http://bugs.koha-community.org/show_bug.cgi?id=12072 Signed-off-by: Bernardo Gonzalez Kriegel Better version. Works as described. Small koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:19:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:19:19 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27107|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 27108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27108&action=edit [SIGNED-OFF] Add date format dd.mm.yyyy, known internally as dmydot. Make it much easier to add other date formats by passing the date format string to the templates, instead of hard-coding the allowed formats. http://bugs.koha-community.org/show_bug.cgi?id=12072 Signed-off-by: Bernardo Gonzalez Kriegel Better version. Works as described. Small koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:20:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:20:27 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 27109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27109&action=edit Bug 12072 - Follow up to fix koha-qa errors Removed one tab, and two unnecessary 'my' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:21:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:21:16 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:48:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:48:26 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- Hi Marcel, this doesn't seem to work for me. I have older inactive budgets, could this make the difference? The pull down correctly only shows one entry unless you tick the 'show all'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:55:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:55:58 +0000 Subject: [Koha-bugs] [Bug 12081] New: tmpl_process3.pl delete temp files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Bug ID: 12081 Summary: tmpl_process3.pl delete temp files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Every time you run translate script it makes temporary files on /tmp This files are not deleted, and over time it takes a lot of space. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:58:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:58:31 +0000 Subject: [Koha-bugs] [Bug 12081] tmpl_process3.pl delete temp files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 27110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27110&action=edit Bug 12081 - tmpl_process3.pl - delete temp files This patch enable deletion of temp files used by tmpl_process3.pl. Just removed coments on existing code To test: 1. Do a count of files on /tmp ( ls /tmp | wc -l ) 2. Update preferred language 3. Count again, new files on /tmp 4. Apply the patch 5. Update again, check, no new files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 00:59:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 22:59:09 +0000 Subject: [Koha-bugs] [Bug 12081] tmpl_process3.pl delete temp files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 01:33:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 23:33:54 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26555|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 27111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27111&action=edit [SIGNED-OFF] Bug 11425: Add item search form in staff interface Item search is available at catalogue/itemsearch.pl (link is in catalogue/search.pl) It only uses SQL (not Zebra) * Use DataTables and server-side processing to be able to filter on individual columns after the first search is done. * Allow to export results in CSV * With Javascript disabled, search form still works (and CSV export too) There is the possibility to define "Custom search fields" in a new admin page admin/items_search_fields.pl (link is in admin/admin-home.pl) A custom item search field is defined by: * a name: its unique identifier * a label: the text displayed to the user * a MARC field/subfield: the field/subfield to query (it uses ExtractValue) * an authorised values list (optional): if defined the list is displayed in the search form New Perl dependency: Template::Plugin::JSON::Escape Test plan: 1/ Apply the patch and run updatedatabase.pl 2/ Go to advanced search (staff interface), then click on "Go to item search" 3/ Play with the search form! :) In the 3rd fieldset you can add as many fields as you want and combine them with boolean operators (AND, OR). You can use SQL jokers characters (%, _) You can output to screen (in a DataTables table) or to a CSV file. 4/ In the DataTables table, play with filters and try sorting columns. 5/ Disable Javascript (with Firefox: extensions NoScript or YesScript, or in about:config 'javascript.enabled' = false 6/ Reload the search page and do some searches on screen output. (there is no sorting or filtering features, but there is still pagination) 7/ Try again CSV output. 8/ You can re-enable Javascript. 9/ Go to Administration > Items search fields 10/ Add a new field. Example for title (in UNIMARC): Name: title Label: Title MARC field: 200 MARC subfield: a Authorised values category: None (add another field with an authorised values category to see the difference). 11/ As you are there try to update and delete some fields. 12/ Go back to items search form. You can see in the 3rd fieldset that your fields have appeared in the selects. 13/ Try searching on them. 14/ I think you're done :) Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Good new option. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 01:34:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 23:34:05 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26556|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 27112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27112&action=edit [SIGNED-OFF] Bug 11425: Add unit tests package Koha::Item::Search::Field function C4::SQLHelper::GetColumns function C4::Items::SearchItems Signed-off-by: Bernardo Gonzalez Kriegel Tests run without error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 01:34:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 23:34:16 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26557|0 |1 is obsolete| | --- Comment #15 from Bernardo Gonzalez Kriegel --- Created attachment 27113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27113&action=edit [SIGNED-OFF] Bug 11425: Add filter on items.notforloan column and display the 'Processing ...' box when datatables is loading new data. Signed-off-by: Bernardo Gonzalez Kriegel Nice box -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 01:37:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 23:37:16 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com --- Comment #16 from Bernardo Gonzalez Kriegel --- (In reply to Julian Maurice from comment #3) > I'm not satisfied of the way we can access the item search page (a tiny link > in advanced search page), so suggestions are very welcome! :) Perhaps with two tabs, left for Advanced search, right for item search :) Only annoying thing (may be inevitable) is loosing browser history, a back on item search results lands you on advanced search, click on a record or item view/edit, press back and lands on item search, loosing results Good work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 01:59:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Apr 2014 23:59:16 +0000 Subject: [Koha-bugs] [Bug 12075] jQueryUI upgrade broke keyboard shortcuts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12075 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 02:28:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 00:28:19 +0000 Subject: [Koha-bugs] [Bug 12082] New: hold statistics wizard can produce misleading results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12082 Bug ID: 12082 Summary: hold statistics wizard can produce misleading results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The hold statistics wizards can produce or misleading incorrect results. Here are at least two circumstances: Case 1: - hold status = active column - hold date = active row, with date range 3/1/2014-3/2/2014 - holding library: not blank - home library: not blank Because the filters get applied even if they're not selected as the row or column, in this case the report doesn't count any bib-level requests that are not yet filled or which were cancelled. This is because the home/holding library comes into play only if there is an item number set, which doesn't happen for bib-level requests until the hold is captured. This can result in a hard-to-explain situation where running a report on the number of holds in the previous month can change over time as holds placed towards the end of the month get filled. Case 2: - hold status = active column - hold date = active row, with date range 3/1/2014-3/2/2014 - holding library blank - home library blank If there happens to be a case where, for a given date, the number of requests of a given status is the same in both reserves and old_reserves, the fact that a "UNION" is used rather than a "UNION ALL" means that only one set is counted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 02:35:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 00:35:32 +0000 Subject: [Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeparator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to M. Tompsett from comment #3) > Created attachment 26941 [details] [review] > Bug 10330 - Rename system preference authoritysep to AuthoritySeperator > > Test Plan: > 1) Apply patch > 2) Run updatedatabase.pl > 3) View some records with authorities > 4) Note your previously set authority separator should still be in use Mark, this first one is signed? Or, Are you considering to sign it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 03:33:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 01:33:31 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #194 from Bernardo Gonzalez Kriegel --- Hi, testing Found a problem, at first I have an empty OPACbaseURL, file upload worked. Then I set base url, now when I upload a file, the original file name is not appended at the end of the 'new' name, I got something like "/cgi-bin/koha/opac-retrieve-file.pl?id=775f48aaf5f7a44fa534dae4e7dc876ea7191115", with a missing "_filename.ext" But file is created, and I can delete it, but url does not work Other little things, koha-qa FAIL C4/UploadedFiles.pm FAIL cataloguing/value_builder/upload.pl ... FAIL opac/opac-retrieve-file.pl with error FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) Just an old version of licence on files, update http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 05:57:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 03:57:01 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #195 from M. Tompsett --- Created attachment 27114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27114&action=edit Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN --------- 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 05:59:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 03:59:20 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #196 from M. Tompsett --- (In reply to Bernardo Gonzalez Kriegel from comment #194) So just to clarify. You tried to use this without OPACBaseURL set in the first place? And it seemed to upload fine. Then, you set the OPACBaseURL, and after logging out and back in, when you tried to check on the file it busted? I just patched the license stuff. I'll attempt to recreate your problem tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 06:00:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 04:00:55 +0000 Subject: [Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeparator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 --- Comment #6 from M. Tompsett --- I signed off the first one. The second (Follow up...) I wrote. It is NOT signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 06:17:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 04:17:40 +0000 Subject: [Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeparator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 --- Comment #7 from M. Tompsett --- Hmmm... on second thought, just consider nothing signed. I may have just rebased, since I don't have a 10330 branch in my unimarc vm. I have been trying to save things from the patch does not apply pile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 07:37:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 05:37:00 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 --- Comment #6 from Fr?d?ric Demians --- > But the superserials permission appears broken to me before > and after this patch. If I have superserials - the search > doesn't show all subscriptions. If I don't have superserials > I can still edit any subscription accessing the subscription > detail page through the serial collection page or accessing > the detail page directly by manipulating the URL. Should another bug be opened? or a follow-up patch added to this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 08:07:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 06:07:13 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 08:09:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 06:09:17 +0000 Subject: [Koha-bugs] [Bug 12083] New: koha-create misses string substitution in ./templates/koha-conf-site.xml.in file Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12083 Bug ID: 12083 Summary: koha-create misses string substitution in ./templates/koha-conf-site.xml.in file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org currently in master, some strings exist in ./templates/koha-conf-site.xml.in that are not correctly substituted by koha-create __ZEBRA_SRU_BIBLIOS_PORT__ __MERGE_SERVER_PORT__ __KOHA_CONF_DIR__ __ZEBRA_SRU_HOST__ __ZEBRA_SRU_BIBLIOS_PORT__ __ZEBRA_SRU_HOST__ __ZEBRA_SRU_AUTHORITIES_PORT__ __PAZPAR2_HOST__ __PAZPAR2_PORT__ this causes koha-create to generate glitchy koha-conf.xml files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 08:10:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 06:10:53 +0000 Subject: [Koha-bugs] [Bug 12083] koha-create misses string substitution in ./templates/koha-conf-site.xml.in file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12083 --- Comment #1 from Mason James --- oops, some double-ups above... __MERGE_SERVER_PORT__ __KOHA_CONF_DIR__ __ZEBRA_SRU_HOST__ __ZEBRA_SRU_BIBLIOS_PORT__ __ZEBRA_SRU_AUTHORITIES_PORT__ __PAZPAR2_HOST__ __PAZPAR2_PORT__ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 09:01:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 07:01:23 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Ah, I forgot to put a note here: bug 12080 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 09:50:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 07:50:11 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #66 from Jonathan Druart --- (In reply to Kyle M Hall from comment #65) > > 1/ The previous checkouts appears but todays checkouts are put in it. Not > > logical. > > Ok, I see this now. I didn't notice it the first time I looked at your > screen caps. I have been unable to reproduce this behavior, try as I might! It's odd because I don't do something special. I just check an item out to a patron (tested with marc21/unimarc and dateformat us/metric). What is your display? You get the 2 "Previous checkouts" and "Today's checkouts" lines? > > 2/ The bold: it is a regression, in my opinion. > > Fixed! Maybe a span with a class would be better than using the b tag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:15:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:15:10 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |frederic at tamil.fr Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr |ity.org | --- Comment #1 from Fr?d?ric Demians --- Created attachment 27115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27115&action=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:15:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:15:21 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12048 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:15:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:15:21 +0000 Subject: [Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12080 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:16:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:16:18 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 --- Comment #2 from Fr?d?ric Demians --- Katrin: I confirm problem 1, and propose a solution. Note that this patch requires patch for bug 12048. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:23:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:23:13 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #17 from Katrin Fischer --- I really like the idea of this new feature, but I am a bit worried about adding new code to SQLHelper now that we have DBIX and in ligth of bug 11385. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:31:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:31:08 +0000 Subject: [Koha-bugs] [Bug 12071] javascript broken for a search with double quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- Created attachment 27116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27116&action=edit Patch fixes encoding problem as well (e.g. ???) I tryed to reproduce the problem and found an other one: If you do a search for someting like ??? and then hit Z39.50 button, the encoding in the Z39.50 search form is broken. With patch, the encoding is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:35:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:35:50 +0000 Subject: [Koha-bugs] [Bug 12071] javascript broken for a search with double quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 --- Comment #5 from Marc V?ron --- Created attachment 27117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27117&action=edit [SIGNED-OFF] Bug 12071 - javascript broken for a search with double quotes In staff interface, when performing a simple search with a double quote (ie "histoire algerie"), the javascript is broken in results page because of : function GetZ3950Terms(){ var strQuery="&frameworkcode="; strQuery += "&" + "title" + "=" + ""histoire%20algerie""; This patch moves URI escaping from perl to template with uri TT filter. Test plan : - In staff interface, perform a search with double quotes that will return no result, ie "aaa xxx" => Without patch, javascript is broken => With patch, javascript is not broken - Click on Z3950 button on results page => Without patch, the Title input is empty => With patch, the Title input contains the search terms Additional test: Do a search with something like ??? and then click Z3950 button on results page. Without patch, encoding is broken in Z3950 form With patch, encoding is correct. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:36:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:36:27 +0000 Subject: [Koha-bugs] [Bug 12071] javascript broken for a search with double quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26997|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:36:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:36:30 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #31 from Katrin Fischer --- Hm, it looks like the last thing done here was fixing the patch again - should this be 'Needs Signoff'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:36:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:36:38 +0000 Subject: [Koha-bugs] [Bug 12071] javascript broken for a search with double quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:37:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:37:33 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8735 --- Comment #1 from Katrin Fischer --- Adding a see also to bug 8735 as both seem to be related. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:37:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:37:33 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:43:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:43:29 +0000 Subject: [Koha-bugs] [Bug 8338] fines not cleared with dropbox mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Version|3.8 |master Resolution|--- |DUPLICATE --- Comment #10 from Katrin Fischer --- It looks like bug 10694 will fix this: "Sometimes libraries need to backdate returns further back in time than Koha's dropbox mode will allow. The returns backdating will check in an item as if it had been returned on the specified date, and will reduce any fine accordingly." *** This bug has been marked as a duplicate of bug 10694 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:43:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:43:29 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #37 from Katrin Fischer --- *** Bug 8338 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:44:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:44:36 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27108|0 |1 is obsolete| | Attachment #27109|0 |1 is obsolete| | --- Comment #13 from paxed --- Created attachment 27118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27118&action=edit Add dateformat dd.mm.yyyy This patch fixes the qa errors fixed in bgkriegel's patch, and also fixes the offline circulation UI to show the dates in correct format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:45:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:45:11 +0000 Subject: [Koha-bugs] [Bug 8338] fines not cleared with dropbox mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #11 from Katrin Fischer --- Hm, on second thought might not be quite the same, please check if the new feature on bug 10694 is a fix for you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:54:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:54:35 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 10:58:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 08:58:37 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #2 from paxed --- (In reply to Katrin Fischer from comment #1) > Adding a see also to bug 8735 as both seem to be related. Right - that bug only moves the date forward if the end date happens to be a closed date. This one will not count holidays into the delay at all. So, different needs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:05:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:05:25 +0000 Subject: [Koha-bugs] [Bug 12084] New: Published date for serial items not formatted according to dateformat system preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12084 Bug ID: 12084 Summary: Published date for serial items not formatted according to dateformat system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: 1) Create a subscription with items added on receive 2) Receive a few issues and create items 3) Check the staff detail page 4) Verify that the published date shown there under Publication details is not showing according to the dateformat system preference. The date formatting should be done using the TT plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:07:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:07:00 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 --- Comment #27 from Katrin Fischer --- I am not totally sure why we'd want to display both there or why they might be different, but the patch just ensures that only one shows when both are the same - so this seems a harmless improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:07:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:07:53 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:07:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:07:57 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27101|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 27119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27119&action=edit [PASSED QA] Bug 10825 - detail.tt displays duplicated enumchron values for serial items TEST PLAN --------- 1) Find a data point that displays like the picture on this bug report. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 2) Apply the patch 3) Refresh the screen 4) Does it look like the second picture now with the duplication removed? 5) Run koha qa test tools I did attempt with default and blank for the XSLT system preferences for the staff client. This accounts for Nicole's comment #12. Signed-off-by: Mason James Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Template change only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:10:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:10:12 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:10:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:10:15 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27077|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 27120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27120&action=edit Bug 11797 - Odd number of elements in hash - UNIMARC I got the same warning for my UNIMARC DB. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:28:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:28:03 +0000 Subject: [Koha-bugs] [Bug 12085] New: Allow staff to place multiple reserves for the same patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085 Bug ID: 12085 Summary: Allow staff to place multiple reserves for the same patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 27121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27121&action=edit Allow multiple reserves for the same patron This requires rather large changes to C4/Reserves.pm, because it didn't use the reserve_id to distinguish the reserves. -Remove all vestiges of reserveconstraints -table from the code. -Make Reserves use ID numbers as much as possible, instead of matching with patron number, bibnum, and date. -Allow the same patron reserve the same item multiple times, but only via staff client. -Adds syspref AllowMultipleHolds ---- I wrote this patch a while ago, and seeing all the other improvements in the area (for example bug 12079 and bug 11947), I decided to put this up here, perhaps it'll be of some use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:32:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:32:05 +0000 Subject: [Koha-bugs] [Bug 12079] CheckReserves() and _Findgroupreserve do not return reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12079 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #2 from paxed --- See also bug 12085 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:32:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:32:13 +0000 Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #27 from paxed --- See also bug 12085 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:38:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:38:46 +0000 Subject: [Koha-bugs] [Bug 12086] New: Hold priorities incorrect, when waiting status was reversed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Bug ID: 12086 Summary: Hold priorities incorrect, when waiting status was reversed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Tested on top of patch for 11947! 1) Prepare for headache. 2) Check out an item from any record. 3) Place 3 holds, for patrons a, b, c on the same record. 4) Return the checked out item - it is now waiting for a, b = 1, c = 2 5) Check out the book to b(!), revert waiting status as offered by the GUI You will end up with: a = 1, c = 1 in the holds list, but in the database it's kind of more correct: a = 1, c = 3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:39:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:39:01 +0000 Subject: [Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11947 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:39:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:39:01 +0000 Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12086 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:41:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:41:05 +0000 Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:41:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:41:09 +0000 Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27035|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 27122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27122&action=edit [PASSED QA] Bug 11947 - renumber reserves when hold is confirmed Currently when a reserve is moved to "waiting" status because it's acknowledged on checkin, the reserve priorities aren't renumbered. This causes things to go a bit haywire in the UI, in particular, some reserves can unjustly end up with priority 1 when they shouldn't. It also seemed to mess with the logic of who should get it next, but I didn't look too closely at that. This patch forces a renumbering so that all the priorities remain copacetic. Test plan: * have a few borrowers, say 4. * have a biblio with a single item (you can scale this up, it should work just the same.) * issue the item to borrower A * have borrowers B, C, and D place a hold on the item * return the item, acknowledge that it'll be put aside for B. * view the holds on the item. Without the patch: * the hold priorities in the UI end up being "waiting, 2, 1" when they should be "waiting, 1, 2". * in the database "reserves" table, they're really "0, 2, 3" when they should be "0, 1, 2". With the patch: * the hold priorities in the UI end up being "waiting, 1, 2" * in the database, they're "0, 1, 2" Signed-off-by: Owen Leonard Test plan confirms that the problem exists and that the patch corrects it. Signed-off-by: Katrin Fischer Passes all tests and QA script, especially t/db_dependent/Reserves.t. Improves priority calculation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:43:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:43:30 +0000 Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 --- Comment #29 from Katrin Fischer --- I think I found another bug here: 1) Appply patch 2) Check out item 3) Place 3 holds, for patron a, b, c 4) Return the item - item is now waiting for a, b = 1, c = 2 5) Check out the book to b(!), revert waiting status as offered You will end up with: a = 1, c = 1, but in the database it's kind of more correct: a = 1, c = 3 I have put this on another bug - bug 12086. Still passing this as this patch just used an existing routine and I believe it's an improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:47:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:47:10 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #205 from Katrin Fischer --- Starting on this now... wish me luck? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:55:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:55:55 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27006|0 |1 is obsolete| | Attachment #27009|0 |1 is obsolete| | --- Comment #65 from Koha Team Lyon 3 --- Created attachment 27123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27123&action=edit Bug 9593 Prices not imported correctly from a staged file Well, prices string like '$9.99 USD' are now treated correctly. When neither currency symbol nor isocode is found like '18.95 (U.S.)', the first price is picked as done in previous routine. I included new test strings in MungeMarcPrice.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 11:56:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 09:56:07 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 12:21:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 10:21:23 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27123|0 |1 is obsolete| | --- Comment #66 from Koha Team Lyon 3 --- Created attachment 27124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27124&action=edit Bug 9593 Prices not imported correctly from a staged file slight correction in comments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 12:47:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 10:47:26 +0000 Subject: [Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #1 from paxed --- Some additional differences have creeped into the files: -use of INCLUDE 'patron-title.inc' vs. hard-coded patron title. -IF-checking picture vs. checking has_picture. -TT filtering borrowernumber with uri vs. not filtering. Other stuff that could be improved: -Hard-coded css styles should be moved into external stylesheets. -patroncategory and patronlibrary do not separate field description from the field content, so impossible to style separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 13:20:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 11:20:45 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #197 from Bernardo Gonzalez Kriegel --- Created attachment 27125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27125&action=edit Bug 6874 - Fix file URL This patch prepends 'http://' to file upload URL, because this patch series assumes (wrongly) that OAPCBaseURL is filled WITH that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 13:30:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 11:30:53 +0000 Subject: [Koha-bugs] [Bug 5052] Can't choose languages if all choices are sublanguages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 13:30:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 11:30:57 +0000 Subject: [Koha-bugs] [Bug 5052] Can't choose languages if all choices are sublanguages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27040|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 27126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27126&action=edit Bug 5052 - Can't choose languages if all choices are sublanguage This was tricky to catch. In current implementation, Bug 6755 introduced in C4/Templates.pm as condition to send the array of hashrefs of languages that (@$languages_loop<2), but with one language group that condition is false, there is only one element in that array. This patch changes that condition to have more than one language selected, grouped or not. Also send $bidi value always, that was only sent if there is more than one group language. To test: 1. Translate to en-GB and en-NZ, or simply do mkdirs on intranet-tmpl/prog and opac-tmpl/bootstrap 2. Go to Administration > System preferences > I18N enable those languages on staff/opac 3. Check that language chooser is nowhere to be found 4. Apply the patch 5. Reload staff/opac, now you can see language chooser NOTE: I made little changes on staff, but can't replicate bootstrap colors for selected/unselected language. Someone need to touch css files to make it happen. But that is current behavior. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Good catch! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 13:34:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 11:34:06 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Paxed, could you test and add your signoff to the Kyle's patch please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 13:45:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 11:45:42 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #198 from Bernardo Gonzalez Kriegel --- (In reply to M. Tompsett from comment #196) > (In reply to Bernardo Gonzalez Kriegel from comment #194) > > So just to clarify. You tried to use this without OPACBaseURL set in the > first place? And it seemed to upload fine. Then, you set the OPACBaseURL, > and after logging out and back in, when you tried to check on the file it > busted? > > I just patched the license stuff. I'll attempt to recreate your problem > tomorrow. Mark, found it! Your OPACBaseURL must be filled with "http://", that's it And it's wrong, or at last it's not suggested when you fill the preference ("The OPAC is located at http:// ... ") Look my followup, use it or not, fix as you like and squash with previous patch Regards :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 14:17:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 12:17:32 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Alessandra Carassiti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.carassiti at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 14:38:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 12:38:49 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16543|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 27127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27127&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 14:44:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 12:44:11 +0000 Subject: [Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for the same patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at pttk.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 14:46:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 12:46:53 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #206 from Katrin Fischer --- Created attachment 27128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27128&action=edit New staged order page A screenshot - testing comments later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 14:50:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 12:50:54 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #16 from Kyle M Hall --- (In reply to Galen Charlton from comment #14) > +1 to taking advantage of the existing structure for defining print queues. I'm afraid I don't believe this to be as good an idea as it may have seemed at first. It appears that admin/printers.pl has been hidden since 2008, 8 years ago. The schema for this table would need to be completely recreated as the existing one does not fit with the data needed for Net::Printer. Even worse, the code itself is extremely broken and would have to be rewritten from scratch. So, in short, we wouldn't be taking advantage of the existing structure for defining print queues, because it would all need to be completely thrown away and totally rewritten, including the printers table itself. I'm not really seeing what the advantage would be to defining the printers from the web interface either. In fact, it seems even a bit unwanted perhaps. Printer configuration is a system administration task. I don't see a great advantage to allowing librarians to alter the printer data from a web interface. Any thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:29:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:29:46 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #17 from Katrin Fischer --- I took only a quick look at the patch and I think if we go the route of adding a new column to reserves, we also need to add the column old_reserves. What happens if a print is not possible? (printer offline, no paper, etc.) is there a way to repeat the prints? Just a thought, but having the date/time of the print might be useful. Failing QA on Kyle's request, because of old_reserves - still waiting for Galen's opionion of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:32:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:32:11 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #207 from Katrin Fischer --- ** Automated tests and QA script ** Passes all tests in t, xt, and t/db_dependent/Budgets.t t/db_dependent/Acquisition.t t/db_dependent/Acquisition/ Passes QA script. New GetBudgetByCode() covered by tests in t/db_dependent/Budgets.t. ** Code review ** + Check All + Uncheck All BUG (trivial) Capitalization, please fix in a follow up. + + + BUG (trivial) Should be "Statistic 1" "Statistic 2" to match neworderempty.pl, please fix in a follow up. ** Database update Adds a new system preference MarcFieldsToOrder, inludes changes to sysprefs.sql, database update and .pref file. syspref.sql and database update are identical. acquisitions.pref + - "For example:
    price: 947$a|947$c
    quantity: 969$h
    budget_code: 922$a" BUG (minor) Fix . ** Regression testing ** * Current functionality (some notes for comparision) File list / addorderiso2709.pl - List of files that include 'staged' records is shown, details include file name, comments, status, and staged date - Bug: # Bibs is not shown (bug 9063) List of staged records / addorderiso2709.pl - Information in the list only includes title, isbn/issn, there is no way to preview a record - Clicking on 'Add order' will import the record into the catalog and set the status to 'imported'. - You can choose to import all records at once, using the Accounting details section. Options are: currency, budget (should be fund), notes, planning value1, planning value2 - Bug: Fund list shows all funds, including inactive funds (bug 10302) - Bug: Statistic values don't reload on selecting a fund, only when refreshing the page New order form / neworderempty.pl - Replacing ajax-getauthvaluedropbox.pl with fetch_sort_dropbox.pl Used on neworderempty to show the correct values for Statistic 1 + 2 on selecting a fund. * Retested with patches applied File list / addorderiso2709.pl - List of files that include 'staged' records is shown, details include file name, comments, status, and staged date -> Still ok. - Bug: # Bibs is not shown (bug 9063) -> Still broken. List of staged records / addorderiso2709.pl - Information in the list only includes title, isbn/issn, there is no way to preview a record -> MARC preview and Card preview are added BUG (normal): clicking on the 'Card' view, results in a 404 error page. - Clicking on 'Add order' will import the record into the catalog and set the status to 'imported'. -> Still works the same. - You can choose to import all records at once, using the Accounting details section. Options are: currency, budget (should be fund), notes, planning value1, planning value2 -> Options are on a new tab: - Bug: Fund list shows all funds, including inactive funds (bug 10302) -> Still broken. - Bug: Statistic values don't reload on selecting a fund, only when refreshing the page -> BUG (normal): Switching funds works now, but when one of the Statistic values is a free text (no linked authorized value) an 'undefined' text appears in the input field. Only happens on the Default accounting details tab, neworderempty and the details for single orders are ok. -> BUG (normal): Importing and leaving the statistic value free text field empty, will write an 'undefined' into aqorders.sort* New order form / neworderempty.pl - Replacing ajax-getauthvaluedropbox.pl with fetch_sort_dropbox.pl Used on neworderempty to show the correct values for Statistic 1 + 2 on selecting a fund. -> Works. ** New functionality ** * GUI - BUG (trivial): The border of the order details section shows without having the details open (see screenshot). Please take a look. - SUGGESTION: Remove some of the 'bold', maybe only keep the titles bold, but not the links? - SUGGESTION: Change links to read: ( MARC | Card | Add order ) instead of ( Show MARC | Card ; Add order ) - BUG (trivial): Change formatting of the discount field to match formatting on neworderempty.pl, bit shorter and adding % - BUG (minor): Pull discount value from the vendor. I was not sure if the vendor discount would be used now or not, this way it would be clear. - BUG/SUGGESTION Add a note on the Default accounting details tab to clarify when these settings will be taken into account - only for all/selected titles? Similar to the Item information tab. - BUG (major): In my tests I added 12.00 as the price for one record, and 10 as percentage for the discount. When looking at the record in the basket, the list price shows as: -1.21 * MarcFieldsToOrder - Still needs to be tested! QUESTION Are there other fields available not listed in the example? Could we improve the description to give a complete list? price: 947$a|947$c quantity: 969$h budget_code: 922$a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:33:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:33:12 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:37:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:37:07 +0000 Subject: [Koha-bugs] [Bug 12087] New: Improve purge of suggestions: to delete only suggestions with specified status Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12087 Bug ID: 12087 Summary: Improve purge of suggestions: to delete only suggestions with specified status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org This enhancement is for the script purge_suggestions.pl. We add the option to delete only suggestions with specified status. and older of XX days. For -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:38:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:38:34 +0000 Subject: [Koha-bugs] [Bug 12087] Improve purge of suggestions: to delete only suggestions with specified status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12087 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |z.tajoli at cineca.it |ity.org | --- Comment #1 from Zeno Tajoli --- Sorry, the last 'For' is an input error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:39:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:39:06 +0000 Subject: [Koha-bugs] [Bug 12087] Improve purge of suggestions: to delete only suggestions with specified status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12087 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:42:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:42:56 +0000 Subject: [Koha-bugs] [Bug 12079] CheckReserves() and _Findgroupreserve do not return reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12079 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27104|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 27129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27129&action=edit [SIGNED-OFF] Bug 12079: ensure that CheckReserves() includes reserve_id in its response This patch modifies _Findgroupreserve so that its one caller, CheckReserves(), would include the reserve_id field in the hold request it returns. Failure to include reserve_id in every circumstance resulted in bug 11947. This patch is therefore a complementary fix for that bug, but is not meant to preempt the direct fix for that bug. To test: [1] Verify that t/db_dependent/Reserves.t passes. [2] Verify that the following test plan taken from the patch for bug 11947 works for this patch *without* applying the patch for 11947: * have a few borrowers, say 4. * have a biblio with a single item (you can scale this up, it should work just the same.) * issue the item to borrower A * have borrowers B, C, and D place a hold on the item * return the item, acknowledge that it'll be put aside for B. * view the holds on the item. Without the patch: * the hold priorities in the UI end up being "waiting, 2, 1" when they should be "waiting, 1, 2". * in the database "reserves" table, they're really "0, 2, 3" when they should be "0, 1, 2". With the patch: * the hold priorities in the UI end up being "waiting, 1, 2" * in the database, they're "0, 1, 2" Signed-off-by: Galen Charlton Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors. Test pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:43:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:43:24 +0000 Subject: [Koha-bugs] [Bug 12079] CheckReserves() and _Findgroupreserve do not return reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12079 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:48:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:48:52 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27118|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 27130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27130&action=edit [SIGNED-OFF] Bug 12072: Add date format dd.mm.yyyy. Make it much easier to add other date formats by passing the date format string to the templates, instead of hard-coding the allowed formats. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:49:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:49:29 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Bernardo Gonzalez Kriegel --- Signed, again :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 15:57:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 13:57:37 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #14 from M. de Rooy --- (In reply to Katrin Fischer from comment #13) > Hi Marcel, this doesn't seem to work for me. I have older inactive budgets, > could this make the difference? The pull down correctly only shows one entry > unless you tick the 'show all'. Yes, this makes a difference. I can adjust the patch somewhat to account for that. But looking at it, I wonder: Suppose you have three funds (F1 is active, F2 and F3 are inactive). And an order is saved with F2. If you click Modify, what should you want neworderempty to do? Select F1, since it is the only active fund now? Or select F2, but mark it as inactive? And if it shows F2, should it also show F3 now right away and preselect Show all? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 16:32:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 14:32:32 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #18 from Galen Charlton --- (In reply to Kyle M Hall from comment #16) > (In reply to Galen Charlton from comment #14) > > +1 to taking advantage of the existing structure for defining print queues. > > I'm afraid I don't believe this to be as good an idea as it may have seemed > at first. It appears that admin/printers.pl has been hidden since 2008, 8 > years ago. The schema for this table would need to be completely recreated > as the existing one does not fit with the data needed for Net::Printer. Even > worse, the code itself is extremely broken and would have to be rewritten > from scratch. I've sent Chris a query regarding whether he's got the current print queue stuff working for any of his libraries. > So, in short, we wouldn't be taking advantage of the existing structure for > defining print queues, because it would all need to be completely thrown > away and totally rewritten, including the printers table itself. Agreed there are some changes that would be required. > I'm not really seeing what the advantage would be to defining the printers > from the web interface either. In fact, it seems even a bit unwanted > perhaps. Printer configuration is a system administration task. I don't see > a great advantage to allowing librarians to alter the printer data from a > web interface. Disagree. Particularly since Net::Printer talks to the printer directly, there isn't any server-side configuration of setting up lpr queues as seems to be required for the current printer queue approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 16:45:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 14:45:34 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 16:45:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 14:45:41 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #208 from Jonathan Druart --- Created attachment 27131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27131&action=edit Bug 7180: QA followup 2 This patch takes into account all QA failures raised in comment 207. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 16:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 14:46:35 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #209 from Jonathan Druart --- (In reply to Katrin Fischer from comment #207) > + Check All > + Uncheck All > BUG (trivial) Capitalization, please fix in a follow up. Fixed. > BUG (trivial) Should be "Statistic 1" "Statistic 2" to match > neworderempty.pl, > please fix in a follow up. Fixed. > acquisitions.pref > + - "For example:
    price: 947$a|947$c
    quantity: > 969$h
    budget_code: 922$a" > BUG (minor) Fix . Fixed. > - Bug: # Bibs is not shown (bug 9063) > -> Still broken. I am going to provide a patch for bug 9063. > List of staged records / addorderiso2709.pl > - Information in the list only includes title, isbn/issn, there is > no way to preview a record > -> MARC preview and Card preview are added > BUG (normal): clicking on the 'Card' view, results in a 404 error page. I cannot reproduce, the link is catalogue/showmarc.pl?viewas=card&id=230 and the preview works. > - Bug: Fund list shows all funds, including inactive funds (bug 10302) > -> Still broken. See bug 10875 for a patch. > -> BUG (normal): Switching funds > works now, but when one of the Statistic values is a free text > (no linked authorized value) an 'undefined' text appears in the > input field. Only happens on the Default accounting details tab, > neworderempty and the details for single orders are ok. Fixed. > -> BUG (normal): Importing and leaving the statistic value free > text field empty, will write an 'undefined' into aqorders.sort* I cannot reproduce. Maybe it is fixed with previous fix. > ** New functionality ** > > * GUI > - BUG (trivial): The border of the order details section shows without > having the details open (see screenshot). Please take a look. See comment 36: "- I think instead of having the full form on each entry it would save a lot of space if we could only display it for selected records and keep the smaller layout for when now records are selected." > - SUGGESTION: Remove some of the 'bold', maybe only keep the titles > bold, but not the links? Done. > - SUGGESTION: Change links to read: ( MARC | Card | Add order ) instead > of ( Show MARC | Card ; Add order ) Done. > - BUG (trivial): Change formatting of the discount field to match > formatting on neworderempty.pl, bit shorter and adding % Done. > - BUG (minor): Pull discount value from the vendor. I was not sure > if the vendor discount would be used now or not, this way it would > be clear. I am not sure to understand, could you detail? > - BUG/SUGGESTION Add a note on the Default accounting details tab > to clarify when these settings will be taken into account - only > for all/selected titles? Similar to the Item information tab. I tried to fix that... > - BUG (major): In my tests I added 12.00 as the price for one record, > and 10 as percentage for the discount. When looking at the record > in the basket, the list price shows as: -1.21 Fixed! The discount was divided by 100 if > 100. Which is wrong! It should be divided by 100 if > 1. > QUESTION Are there other fields available not listed in the example? > Could we improve the description to give a complete list? Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 16:51:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 14:51:49 +0000 Subject: [Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 16:51:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 14:51:52 +0000 Subject: [Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 --- Comment #3 from Jonathan Druart --- Created attachment 27132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27132&action=edit Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 16:57:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 14:57:19 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #210 from Katrin Fischer --- Hi Jonathan, the card views are all broken for me, tried several, my link is: http://localhost:8080/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&id=644 Could it be MARC flavour specific? I remember we had problems with the card view in the past where this seemed to be part of the problem. > - BUG (minor): Pull discount value from the vendor. I was not sure > if the vendor discount would be used now or not, this way it would > be clear. I am not sure to understand, could you detail? The discount fields are all empty - so I was not sure what to do - put 0 in it to disable the vendor discount? Do I have to enter my normal discount? It would be a bit more clear when the dicount fields were prefilled with the standard dicsount from the vendor. > ** New functionality ** > > * GUI > - BUG (trivial): The border of the order details section shows without > having the details open (see screenshot). Please take a look. See comment 36: "- I think instead of having the full form on each entry it would save a lot of space if we could only display it for selected records and keep the smaller layout for when now records are selected." I still think that :) It's just cosmetig, I think the doubled up border for collapsed entries looks a bit strange, it's all ok, once you open the entry. But this can totally be fixed later - trivial :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 16:57:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 14:57:50 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 16:57:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 14:57:50 +0000 Subject: [Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |7180 --- Comment #4 from Jonathan Druart --- Patch created on top of bug 7180. Feel free to provide a patch based on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 16:58:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 14:58:32 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Double-checking: was the MARC21 variant of this patch marked obsolete by mistake? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:00:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:00:08 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #72 from Paola Rossi --- 1) About sending (=Envoyer) Basket/Cart: Basket/Cart is sent OK: - either on intranet or on OPAC, - with over-255 chars either in the content of the mail (i.e. Commentaire) or in the content of the attached file (i.e. biblios titles), - by English, by French and by Italian But: the French message for cart shows bad chars: Bonjour, 113 vous a envoy? un panier de r?f?rences extraites de notre catalogue. Notez que le fichier attach? est un fichier MARC, qui peut ?tre import? dans un logiciel de gestion de bibliographie tel que EndNote, Reference Manager ou ProCite. the Italian message for cart shows bad chars: Ciao, 113 ti ha inviato un carrello dal nostro catalogo online. Il file in allegato ? fatto di record MARC che possono essere importati in un software bibliografico come EndNote, Reference Manager, ProCite, ecc. ------------------------------------------------------------------------------ 2) About sending (=Envoyer) Shelf/List: on OPAC, list is sent OK: - with over-255 chars either in the content of the mail (i.e. Commentaire) or in the content of the attached file (i.e. biblios titles), - by English, by French and by Italian. On intranet: -- French doesn't send any list [with or without over-255 chars (in biblios titles and in the list name)]; -- Italian doesn't send any list [with or without over-255 chars (in biblios titles and in the list name)]; [i.e. Italian same as French] -- English sends the list [with or without over-255 chars (in biblios titles and in the list name)]; the attached file is ok, while the content of the mail shows bad chars over-127 (biblionumber 1 in sand box 17: La Recherche ?????????. ???? by Published by: St??pahanie KHEMIS, 57 -------------------------------------------------------------- The attached files are all OK. -------------------------------------------------------------- So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:03:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:03:27 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27120|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 27133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27133&action=edit Bug 11797 - Odd number of elements in hash This was discovered when someone triggered an authority search on an authority record that was missing what is assumed the default subfield for a given field. It, however, also can be triggered in an OPAC authority search by looking at the record that lacks the default subfield for a given field. TEST PLAN --------- 1) Create an authority record with 180$x and NOT 180$v. See C4::AuthoritiesMarc::BuildSummary in the 1.. foreach loop for known tags and default values. The default subfields are the first letter of the $subfields_to_report string. 2) Trigger the bug: Method 1: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=# Where # is the authority id of your tweaked record. The error occurs in Normal view. Method 2: Home -> Cataloging -> + New record -> Click the 'Tag Editor' on 100$a Editing of $a to $b and back may be required. 3) Notice there is an error log entry. 4) Apply the patch 5) Attempt to trigger the bug again 6) That specific error log entry is not generated. Signed-off-by: Marcel de Rooy Could generate the warning with a missing 151$a with both methods. No warning anymore after applying this patch. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:03:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:03:35 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 --- Comment #8 from Jonathan Druart --- Created attachment 27134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27134&action=edit Bug 11797 - Odd number of elements in hash - UNIMARC I got the same warning for my UNIMARC DB. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:22:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:22:38 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- I confirmed problem 1 and 2. However, this patch only solves problem 1. The /cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=## URL needs to have permissions checks added still. I can direct access the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:25:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:25:00 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:25:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:25:07 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27115|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 27135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27135&action=edit [SIGNED OFF] Bug 12080 Superserials permission in search result Enabling/disabling IndependentBranch syspref & superserials permission, you can see that serials search result doesn't display all subscriptions when appropriate. Fixed with this patch. Dependency: This patch must be applied after patch for bug 12048. TEST PLAN --------- 1) Apply the patch for bug 12048 (as needed -- it may be pushed) 2) Ensure you have two users: superlibrarian, non-superlibrarian with all access to the staff client except superserials. 3) Ensure you have serials belonging to a different branch than the non-superlibrarian. 3) Log into staff client as superlibrarian 4) Click 'Serials' 5) Click the 'Submit' button in the search area. -- note the number of results. 6) Log into staff client as non-superlibrarian 7) Click 'Serials' 8) Click the 'Submit' button in the search area. -- note the number should be less, note the number. 9) Give the non-superlibrarian superserials access. 10) Home -> Serials 11) Click the 'Submit' button in the search area. -- the number will still be the same at the one in step #8. 12) Apply the patch 13) Refresh the page -- the number should now match the one in step #5. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:25:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:25:41 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Blocks|9063 | --- Comment #211 from Katrin Fischer --- Resetting failed for now, until we can figure out what's wrong with the card view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:25:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:25:41 +0000 Subject: [Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7180 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:26:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:26:30 +0000 Subject: [Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7180 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:26:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:26:30 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:28:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:28:05 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from M. de Rooy --- Can we reset the status of this report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:29:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:29:19 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27131|0 |1 is obsolete| | --- Comment #212 from Jonathan Druart --- Created attachment 27136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27136&action=edit Bug 7180: QA followup 2 This patch takes into account all QA failures raised in comment 207. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:30:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:30:22 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #213 from Jonathan Druart --- (In reply to Katrin Fischer from comment #210) > Hi Jonathan, > > the card views are all broken for me, tried several, my link is: > http://localhost:8080/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&id=644 > > Could it be MARC flavour specific? I remember we had problems with the card > view in the past where this seemed to be part of the problem. Looking at the code (catalogue/showmarc.pl), the redirect to 404 is done if new_from_usmarc or GetMarcBiblio returns something undefined. It should not append. if ($importid) { my ($marc) = GetImportRecordMarc($importid); $record = MARC::Record->new_from_usmarc($marc); } else { $record =GetMarcBiblio($biblionumber); } if(!ref $record) { print $input->redirect("/cgi-bin/koha/errors/404.pl"); exit; } Could you attach the imported record to this report? > > - BUG (minor): Pull discount value from the vendor. I was not sure > > if the vendor discount would be used now or not, this way it would > > be clear. > > I am not sure to understand, could you detail? > > The discount fields are all empty - so I was not sure what to do - put 0 in > it to disable the vendor discount? Do I have to enter my normal discount? It > would be a bit more clear when the dicount fields were prefilled with the > standard dicsount from the vendor. Hum, it could be a good idea. But if a user wants to import a batch with a specific discount, (s)he will have to remove values manually and add the default one in the accounting defails tab. > > * GUI > > - BUG (trivial): The border of the order details section shows without > > having the details open (see screenshot). Please take a look. > > See comment 36: "- I think instead of having the full form on each entry it > would save a lot of space if we could only display it for selected records > and keep the smaller layout for when now records are selected." > > I still think that :) It's just cosmetig, I think the doubled up border for > collapsed entries looks a bit strange, it's all ok, once you open the entry. > But this can totally be fixed later - trivial :) Ho yes sorry, I read that too quickly. Fixed (as I can). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:37:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:37:17 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #10 from M. Tompsett --- I agree it should be changed. I don't think Jonathan's patch has been signed off, hence the 'Needs Signoff' status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:46:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:46:53 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #73 from Jonathan Druart --- (In reply to Paola Rossi from comment #72) Arg, it works for me. Which email client do you use? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 17:50:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 15:50:18 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #74 from Zeno Tajoli --- I and Paola we use Thunderbird 24.4.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 18:15:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 16:15:56 +0000 Subject: [Koha-bugs] [Bug 12088] New: Improve date handling and sorting in holds to pull report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Bug ID: 12088 Summary: Improve date handling and sorting in holds to pull report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org pendingreserves.tt includes a call to dt_add_type_uk_date(), which should be replaced with the title-string method for sorting dates. Additionally, sorting of the title column could be improved by adding the "anti-the" sorting method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 18:23:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 16:23:25 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #29 from Galen Charlton --- Pushed to master. Thanks, Mason and Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 18:23:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 16:23:49 +0000 Subject: [Koha-bugs] [Bug 5052] Can't choose languages if all choices are sublanguages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5052 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 18:25:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 16:25:00 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Galen Charlton --- Pushed to master, along with a follow-up to normalize the two approaches taken to remove the warning and a patch that adds unit tests and regression tests. Thanks, Mark and Jonathan! Jonathan: I would be interested in seeing an example of a valid UNIMARC authority that triggers the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 18:25:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 16:25:13 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 18:25:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 16:25:21 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 18:26:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 16:26:26 +0000 Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Galen Charlton --- Pushed to master. Thanks, Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 18:49:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 16:49:24 +0000 Subject: [Koha-bugs] [Bug 12081] tmpl_process3.pl delete temp files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 18:49:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 16:49:28 +0000 Subject: [Koha-bugs] [Bug 12081] tmpl_process3.pl delete temp files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27110|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 27137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27137&action=edit [SIGNED OFF] Bug 12081 - tmpl_process3.pl - delete temp files This patch enable deletion of temp files used by tmpl_process3.pl. Just removed coments on existing code To test: 1. Do a count of files on /tmp ( ls /tmp | wc -l ) 2. Update preferred language 3. Count again, new files on /tmp 4. Apply the patch 5. Update again, check, no new files Signed-off-by: Mark Tompsett NOTE: I watched what temp files were actually in /tmp to make sure other processes didn't magically increase/decrease the number. $ perl translate update {lang code} generated 10 temporary files for me (2x5 po files). After removing those ten files, and applying the patch, no other files were generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 18:57:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 16:57:46 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 --- Comment #5 from Fr?d?ric Demians --- Thanks Mark for the detailed test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 19:40:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 17:40:37 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 19:40:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 17:40:40 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 --- Comment #1 from Owen Leonard --- Created attachment 27138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27138&action=edit Bug 12088 - Improve date handling and sorting in holds to pull report The holds to pull report could be improved by improving sorting on the title and date columns. This patch adds "anti-the" sorting to the title column and "title-string" sorting to the date column. Date formatting of another variable has been moved to the template for formatting using KohaDates. The patch includes other corrections for HTML validity. To test, apply the patch and view the holds to pull report. - Sorting by date should work correctly regardless of dateformat system preference setting. - Sorting of the title columns should correctly ignore articles. - Formatting of the "Reported on" date should be correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 20:03:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 18:03:31 +0000 Subject: [Koha-bugs] [Bug 12089] New: Remove use of dt_add_type_uk_date() Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 Bug ID: 12089 Summary: Remove use of dt_add_type_uk_date() Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Many templates call dt_add_type_uk_date() to handle sorting of date columns in tables when the dateformat system preference is set to "metric." Some of these templates already use the "title-string" method (http://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference) for sorting, and the call can be removed. Other templates should be updated to use the "title-string" method. As I make corrections I also intend to update sorting configurations to use the newer guideline described here: http://wiki.koha-community.org/wiki/DataTables_HowTo#Obsolete_configuration_methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 20:36:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 18:36:38 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 20:36:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 18:36:40 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 --- Comment #1 from Owen Leonard --- Created attachment 27139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27139&action=edit Bug 12089 - Remove use of dt_add_type_uk_date() - Circulation This patch removes instances of dt_add_type_uk_date() from there circulation templates and updates the sorting configuration according to current guidelines. To test, enable the UseTablesortForCirc system preference and open a patron for circulation who has multiple items checked out. Confirm that sorting by due date, title, and checkout date work correctly. Locate a patron who is guarantor to another or is guaranteed by another. One or both patrons should have checkouts. The "relatives checkouts" tab on the checkout page should sort correctly on due date, title, and checkout date. On the transfers to receive report, confirm that sorting by date of transfer and title work correctly for all tables. On the holds awaiting pickup report the "available since" and title columns should sort correctly for tables in both tabs (waiting and over). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 20:51:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 18:51:13 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 20:51:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 18:51:16 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26069|0 |1 is obsolete| | --- Comment #17 from Jesse Weaver --- Created attachment 27140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27140&action=edit Bug 11559 - Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Allows XSLT filename to be extracted * Extends humanmsg to allow per-message classes * Fixes XSLT namespace for in-browser rendering and * Adds proper charset to results of svc/bib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 20:51:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 18:51:32 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26070|0 |1 is obsolete| | --- Comment #18 from Jesse Weaver --- Created attachment 27141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27141&action=edit Bug 11559 - New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * jquery.hotkeys - some functionality not supported by shortcuts * jquery.lightbox_me - for modal popovers * pz2 - library for connecting to pazpar2 * require - dependency resolver and module loader -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 20:52:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 18:52:07 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26071|0 |1 is obsolete| | Attachment #26104|0 |1 is obsolete| | Attachment #26654|0 |1 is obsolete| | --- Comment #19 from Jesse Weaver --- Created attachment 27142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27142&action=edit Bug 11559 - Rancor: professional cataloging interface Test plan: 1. Apply patches for bug 10486 and this bug. 2. Reinstall patches for pazpar2. 3. Switch back and forth between basic and advanced editor, and verify that preference is saved (by workstation, not user. 4. Enter in a record (with all required fields). 5. Save to ISO2709, MARCXML and catalog, verify that all three match. 6. Import a MARCXML and ISO2709 record, and verify that the record is correct after import. 7. Run keyword and advanced searches with a variety of Z39.50 servers to check that searching is correct, and try to both import records as new records and substitute them for the contents of existing records. 8. Create, edit and delete macros, verifying that they are autosaved. 9. Try running macros (example follows). 10. Try enabling and disabling fixed-field widgets and customizing fonts, and test the editor afterwards. Example macro: goto field 003 copy field data insert new field 040 data= goto subfield end insert new subfield a data= goto subfield a paste (New version, rebased to latest master and incorporating above followups.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 21:13:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 19:13:39 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 --- Comment #2 from Owen Leonard --- Created attachment 27143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27143&action=edit Bug 12089 - Remove use of dt_add_type_uk_date() - Members This patch removes use of dt_add_type_uk_date() from the circulation history page and updates the sorting configuration according to current guidelines. The patch also makes corrections for HTML validity. To test, open the circulation history page for a patron with a history of checkouts. Confirm that the date, title, checkout date, due date, and return date columns sort correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 21:21:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 19:21:21 +0000 Subject: [Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 21:21:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 19:21:24 +0000 Subject: [Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27042|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 27144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27144&action=edit [SIGNED OFF] Bug 11508 - Untranslatable pull-down in auth_subfields_structure.pl OMG!!, this file is full of tabs and CGI::scrolling_list !!! -- I know, right? YUCK! [Mark Tompsett] This patch fix the reported strings and also another one. It removes 2 occurrences of CGI::scrolling_list with untranslatable labels. Fixed capitalization. To test 1. Go to Administration > Authority types, click 'MARC structure' of any auth type, click 'subfields' for any Tag >= 010, clic 'Edit subfields' Check pulldowns 'Manged in tab' and 'Select to display or not' 2. Apply the patch 3. Reload and verify functionality of both pulldowns 4. Check that strings are not present on staff PO file egrep "^msgid \"(Show all|Hide all|ignore)" misc/translator/po/fi-FI-i-staff-t-prog-v-3006000.po 5. Update language file (cd misc/translator/; perl translate update fi-FI) 6. Check that strings are now present, repeat 4. Signed-off-by: Mark Tompsett NOTE: drop-downs work identically. Show all, Hide all, and ignore were added to the po files too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 21:22:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 19:22:17 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement --- Comment #20 from Jesse Weaver --- NOTE: "2. Reinstall patches for pazpar2." in the directions above should read, "2. Reinstall configuration files for pazpar2, either using 'make update_zebra_conf' (if available) or manually." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 21:25:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 19:25:17 +0000 Subject: [Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 --- Comment #8 from M. Tompsett --- Comment on attachment 27144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27144 [SIGNED OFF] Bug 11508 - Untranslatable pull-down in auth_subfields_structure.pl Review of attachment 27144: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11508&attachment=27144) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt @@ +94,5 @@ > + > + [%- ELSE -%] > + > + [%- END -%] > + [%- FOREACH t IN [ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10'] -%] There's a tab '10'? Well, it was in the old dropdown too, so no problem. It is just strange. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 21:26:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 19:26:10 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #46 from Jesse Weaver --- (In reply to David Cook from comment #45) > I'm trying to install pazpar2 version 1.6.40 from source, but it looks like > it requires YAZ 4.2.68 or later. > > It looks like the YAZ package in the Debian Wheezy repo is 4.2.30, and my > non-Debian systems are a bit older than that. > > Might I be missing something? Try using an older version of pazpar2; I believe 1.6.32 should work with older versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 21:34:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 19:34:47 +0000 Subject: [Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 --- Comment #9 from Bernardo Gonzalez Kriegel --- (In reply to M. Tompsett from comment #8) > > + [%- FOREACH t IN [ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10'] -%] > > There's a tab '10'? Well, it was in the old dropdown too, so no problem. It > is just strange. Perhaps by copy of biblio's one, where tab 10 is for items... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 21:36:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 19:36:34 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 21:36:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 19:36:37 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #10 from Owen Leonard --- Created attachment 27145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27145&action=edit Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 21:54:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 19:54:48 +0000 Subject: [Koha-bugs] [Bug 5246] Special characters in patron barcodes cause SIP2 connections to hang In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5246 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 22:19:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 20:19:27 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #214 from Katrin Fischer --- Hi Jonathan, I noticed that some of my cards displayed, but the wrong record - I took a look at the code and I think id should be importid in the link? ... http://localhost:8080/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&importid=651 Works for me, while http://localhost:8080/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&id=651 shows the wrong record. And you are right about the discount, for usability it's better like it is now. What about adding a 'grey' note behind the field? 'If empty, discount rate from vendor will be used'? (or maybe we can think of something shorter) Can you check my solution from above? It's too late now for doing acquisitions... I will come back to this tomorrow :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 22:23:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 20:23:56 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #15 from Katrin Fischer --- Hi Marcel, > Yes, this makes a difference. I can adjust the patch somewhat to account for > that. > But looking at it, I wonder: Suppose you have three funds (F1 is active, F2 > and F3 are inactive). And an order is saved with F2. > If you click Modify, what should you want neworderempty to do? Select F1, > since it is the only active fund now? Or select F2, but mark it as inactive? > And if it shows F2, should it also show F3 now right away and preselect Show > all? Hm, die we uncover another bug here? It seems one of those days... I think when modifying an existing order, it should always preselect what's in the database, even if the fund has been marked inactive since or was inactive when selected. If we need to preselect 'show all' in order to make that work, I guess we need to do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 22:31:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 20:31:53 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Joel Sasse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse at plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 22:42:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 20:42:36 +0000 Subject: [Koha-bugs] [Bug 12003] Next issues for irregular pattern not correctly predicted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 22:42:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 20:42:40 +0000 Subject: [Koha-bugs] [Bug 12003] Next issues for irregular pattern not correctly predicted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27050|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 27146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27146&action=edit [PASSED QA] Bug 12003: Do not calculate next pubdate for irregular subscriptions Show 'Unknown' when planneddate and publisheddate cannot be calculated Also fixes SQL query in misc/cronjobs/serialsUpdate.pl that was still using "periodicity != 32" to exclude irregular subscriptions from results Test plan: 1) Create a subscription in the serials module. Make sure to choose: Frequency = Irregular 2) Test the prediction pattern, first publication date is set to "First issue publication date" field, others will show as 'unknown' 3) Save the subscription 4) Check the created issue - it will show a published date and a planned date (same as "First issue publication date" field) 5) Receive the issue and check the next generated issue, planned date and published date should show as 'Unknown' 6) Generate a next issue, planned date and published date should also show as 'Unknown' Signed-off-by: Bernardo Gonzalez Kriegel Work as described following test plan. No koha-qa errors Signed-off-by: Katrin Fischer Passes all tests and QA script. Also tested: - multi receiving generates mulitple issues without dates - 'unknown' - staff detail page shows the dates empty, which is fine - OPAC detail page shows the dates empty, which is fine - serial collection page shows 'unknown' and those issues appear on the 'manage' tab, as they did in the past - Editing the issue from the serial collection page leaves the date fields empty. - Receving the issue, setting the status to 'Arrived' the Expected on date is set to 'today' automatically. Date published has to be entered manually (maybe something we could improve later - subscription detail > issues tab shows Uknown. - t/db_dependent/Serials/GetNextDate.t pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 23:13:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 21:13:10 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #25 from Katrin Fischer --- Created attachment 27147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27147&action=edit [PASSED QA] Bug 12019: FIX budget_owner_id node is duplicated The input witht the budget_owner_id id is duplicated. It breaks the jQuery selector $('#budget_owner_id').val(''); Signed-off-by: marjorie barry-vila Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 23:14:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 21:14:56 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 23:15:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 21:15:00 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26897|0 |1 is obsolete| | Attachment #27088|0 |1 is obsolete| | Attachment #27147|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer --- Created attachment 27148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27148&action=edit [SIGNED OFF] Bug 12019: FIX budget_owner_id node is duplicated The input witht the budget_owner_id id is duplicated. It breaks the jQuery selector $('#budget_owner_id').val(''); Signed-off-by: marjorie barry-vila Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 23:15:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 21:15:13 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #27 from Katrin Fischer --- Created attachment 27149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27149&action=edit [SIGNED OFF] Bug 12019: It should not be mandatory to define an owner if a fund is restricted Before this patch, the C4::Budgets::CanUserUseBudget assumed that budget_owner_id was set if a restriction (budget_permission) exists. see && $budget->{budget_owner_id} && $budget->{budget_owner_id} != $borrower->{borrowernumber} Actually a restriction could exists on users and/or library without being forced to define an owner. Test plan: Create a fund A without restriction Create a fund B restricted to an owner Create a fund C restricted to a non defined owner Create a fund D restricted to owner and users (try defining/no defining an owner and/or users) Create a fund E restricted to owner, users and library (try defining/no defined an owner and/or users) With different logged in users, try to show/edit these differents funds. The restriction should be correctly applied. Signed-off-by: Katrin Fischer Tested various permission combinatons, visibility of funds is now ok. - not superlibrarian, no buget_manage_all, no owner, no users, no library, no restrictions on the fund = visible - changed: library = staff patron library, restriction = Owner, users and library = visible - changed: library = not staff patron library = invisible - changed: budget_manage_all = visible - changed: owner = staff patron no budget_manage_all = visible - changed: no owner, user = staff patron = visible - changed: no user, owner = another user, restriction = owner = invisible - changed: budget_manage_all = visible - changed: no budget_manage_all but superlibrarian = visible ... Passes tests and QA script, also t/Budgets/* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 23:17:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 21:17:47 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 23:23:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 21:23:54 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Joel Sasse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse at plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 23:38:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 21:38:22 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 23:38:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 21:38:25 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27097|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 27150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27150&action=edit [PASSED QA] Bug 12052: Display a patron message on the summary page Test plan: Fill the OPACMySummaryNote with html code or just text. The content should be displayed at the OPAC on the summary page for patrons. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Rephrased the pref text a little bit, using 'logged in' instead of 'connected'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 15 23:42:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 21:42:24 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27150|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 27151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27151&action=edit [PASSED QA] Bug 12052: Display a patron message on the summary page Test plan: Fill the OPACMySummaryNote with html code or just text. The content should be displayed at the OPAC on the summary page for patrons. Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Rephrased the pref text a little bit, using 'logged in' instead of 'connected', also added " so the description appears correctly in the pref editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 00:03:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 22:03:03 +0000 Subject: [Koha-bugs] [Bug 12090] New: Disabling Library Location Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12090 Bug ID: 12090 Summary: Disabling Library Location Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There needs to be a way to disable a library easily. There are libraries in our consortium that close for the summer, and currently we have a library that is closed due to structural damage. Right now, to disable the library, we have to make all item types for that library non-holdable, hide there library in the pickup location dropboxes in at least 3 places, and it looks like we might have to also disable their values in the transport cost matrix. By the way, when we do this, we lose all values, and have to re-enter them when the library is operating again. It would be great if there were a switch next to the library in Libraries and Groups that would allow us to enable/disable the library and all items and traffic with one switch. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 00:37:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 22:37:48 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 01:31:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 23:31:19 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #199 from Robin Sheat --- (In reply to Bernardo Gonzalez Kriegel from comment #197) > Created attachment 27125 [details] [review] > Bug 6874 - Fix file URL > > This patch prepends 'http://' to file upload URL, > because this patch series assumes (wrongly) that > OAPCBaseURL is filled WITH that :) /me points to https:// and frowns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 01:35:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 23:35:52 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #200 from M. Tompsett --- Perhaps we need a dependency on bug 5010 to solve OPAC http vs. https issues? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 01:45:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 23:45:24 +0000 Subject: [Koha-bugs] [Bug 12091] New: Ugly HTML for editing authority MARC subfields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12091 Bug ID: 12091 Summary: Ugly HTML for editing authority MARC subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com After installing the 0.9.5.8 HTML Validator plugin for Firefox, as suggested by Owen, I noticed a lot of errors for /cgi-bin/koha/admin/auth_subfields_structure.pl while testing another bug. The goal of this patch is to bring the validations errors to as close to 0 as possible. I think my untested patch gets 2 warnings. I have to confirm that the screen still functions properly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 01:46:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 23:46:26 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #201 from Bernardo Gonzalez Kriegel --- (In reply to Robin Sheat from comment #199) > > /me points to https:// and frowns. But... is strange to put OPAC under https It's possible of course, but my followup only inserts it if it's not there. It can be modified to recongnize ^http only... Mark, it's just an idea, ta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 01:47:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 23:47:30 +0000 Subject: [Koha-bugs] [Bug 12091] Ugly HTML for editing authority MARC subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12091 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 01:47:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 23:47:33 +0000 Subject: [Koha-bugs] [Bug 12091] Ugly HTML for editing authority MARC subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12091 --- Comment #1 from M. Tompsett --- Created attachment 27152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27152&action=edit Bug 12091 - Ugly HTML corrects for /cgi-bin/koha/admin/auth_subfields_structure.pl Untested. I know it cleans up the HTML, but with the renaming of things and the like, it needs to be thoroughly tested still. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 01:50:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Apr 2014 23:50:48 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #202 from Bernardo Gonzalez Kriegel --- Sorry, pressed wrong key. Mark, It's an idea, don't fully know if http(s):// is the expected beginning of base url. But that explained the wrong behavior I got. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 02:04:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 00:04:48 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #203 from Robin Sheat --- (In reply to Bernardo Gonzalez Kriegel from comment #201) > But... is strange to put OPAC under https No it's not. In fact, these days we pretty much won't deploy anything without it. People's passwords and personal information goes over it, after all. Even more so when it's LDAPified to a corporate authentication server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 03:03:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 01:03:47 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #204 from Bernardo Gonzalez Kriegel --- (In reply to Robin Sheat from comment #203) > No it's not. In fact, these days we pretty much won't deploy anything > without it. People's passwords and personal information goes over it, after > all. Even more so when it's LDAPified to a corporate authentication server. Good point, you are right. Putting 'https://' on OPACBaseURL brakes something? Is it safe to use it that way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 03:10:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 01:10:38 +0000 Subject: [Koha-bugs] [Bug 12058] OverDrive search results page doesn't show cart, lists, or login links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26922|0 |1 is obsolete| | --- Comment #3 from Jesse Weaver --- Created attachment 27153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27153&action=edit Bug 12058 - OverDrive search results page doesn't show cart, lists, or login links The template for OverDrive search results in the Bootstrap OPAC doesn't show the cart, lists, or login links because the template's checks of related system preferences relies on [% USE Koha %], which is not present. This patch adds it. To test, enable the bootstrap theme and OverDrive integration (OverDriveClientKey, etc.). Perform a search in the OPAC and click to view results from your OverDrive library. Confirm that cart, lists, and login links appear in the header. Signed-off-by: Jesse Weaver Bug confirmed, and this patch fixes it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 03:10:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 01:10:35 +0000 Subject: [Koha-bugs] [Bug 12058] OverDrive search results page doesn't show cart, lists, or login links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 03:44:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 01:44:59 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #205 from Robin Sheat --- (In reply to Bernardo Gonzalez Kriegel from comment #204) > Putting 'https://' on OPACBaseURL brakes something? > Is it safe to use it that way? We tend to not put the https:// part in, and it seems to work, though I bet there are corner cases that don't. I don't know what would happen if you included the protocol. Really, the whole syspref should be redesigned so that it requires it, so it can be set properly. I'm not sure what the best solution here is, perhaps make it work so that it'll add http:// unless the syspref =~ m|^\w+://| (after all, you might want to host your Koha on gopher://... :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 06:03:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 04:03:37 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #206 from M. Tompsett --- (In reply to Robin Sheat from comment #205) >(after all, you might > want to host your Koha on gopher://... :) YES! Oh man. I haven't heard of that protocol for like decades, since university. Actually, Bernardo Gonzalez Kriegel, putting 'http://' or 'https://' into the OPACBaseURL can break things, because some places would then generate http://http://, because we are totally inconsistent in our appending in code vs. appending in templates. That kind of mistake busts really well in FireFox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 06:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 04:20:58 +0000 Subject: [Koha-bugs] [Bug 12092] New: member quicksearch doesn't distinguish accented vs. nonaccented letters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12092 Bug ID: 12092 Summary: member quicksearch doesn't distinguish accented vs. nonaccented letters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org The patron search UI shows a list of the alphabet (from syspref alphabet), and you can click on those links to quicksearch for patrons whose surname starts with that letter, but the search doesn't distinguish between accented and nonaccented letters. For example, members/member.pl?quicksearch=1&surname=? will return patrons whose surname starts with A. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 06:26:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 04:26:33 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 06:26:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 04:26:38 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27125|0 |1 is obsolete| | --- Comment #207 from M. Tompsett --- Created attachment 27154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27154&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, particularly the OPAC system preference: OpacProtocol. This is used to generate the http or https for the OPACBaseURL. This now checks for proper configuration of the system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 06:30:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 04:30:23 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5010 --- Comment #208 from M. Tompsett --- I have attached my rework which includes a dependency on bug 5010. I have set the status to ASSIGNED, because I have not tested it yet, and did not feel like asking anyone else to sign off until I have revisited a full testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 06:30:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 04:30:23 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6874 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 06:34:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 04:34:21 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27154|0 |1 is obsolete| | --- Comment #209 from M. Tompsett --- Created attachment 27155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27155&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, particularly the OPAC system preference: OpacProtocol. This is used to generate the http or https for the OPACBaseURL. This now checks for proper configuration of the system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 08:15:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 06:15:50 +0000 Subject: [Koha-bugs] [Bug 7804] Add Koha Plugin System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 --- Comment #112 from David Cook --- Just noticed that the PLUGINS_DIR isn't saved to the koha-install-log. Don't know if this is all that important, but worth noting... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 09:16:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 07:16:08 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 --- Comment #6 from Marc V?ron --- Created attachment 27156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27156&action=edit [Signed-off] Bug 11630 [QA Followup] - Move code to subroutine, add unit tests Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 09:16:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 07:16:40 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27089|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 09:17:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 07:17:13 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 09:21:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 07:21:08 +0000 Subject: [Koha-bugs] [Bug 7985] In Checkout, list of items checked out should show Charge from table accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9481 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 09:21:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 07:21:08 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7985 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 10:16:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 08:16:32 +0000 Subject: [Koha-bugs] [Bug 12093] New: Add css classes to item statuses in detail view Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Bug ID: 12093 Summary: Add css classes to item statuses in detail view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 27157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27157&action=edit Add css classes to item statuses in detail view Some of the item statuses in detail view have no css classes, and are impossible to style effectively. This patch wraps those statuses into spans with appropriate classes, and adds spans allowing styling dates and other information separately from the stock text. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 10:21:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 08:21:35 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #23 from Jonathan Druart --- This is a major. The received email is empty and the subject is "no subject" on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 10:22:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 08:22:40 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #24 from Katrin Fischer --- I agree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 10:30:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 08:30:24 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26895|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart --- Created attachment 27158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27158&action=edit Bug 11944: use CGI( -utf8 ) everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 10:30:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 08:30:39 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27094|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart --- Created attachment 27159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27159&action=edit Bug 11944: Fix encoding on sending emails This patch fixes 2 places where mails were badly encoded: 1/ At the opac and the intranet, on sending baskets 2/ At the opac and the intranet, on sending shelf/list Test plan: Shelf/List: - Create a list with non-latin characters in the name. - Add some items containing non-latin characters in their content. - Send the list by email Basket/Cart: - Add some items containing non-latin characters in their content to your cart.. - Send the cart by email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 10:31:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 08:31:40 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Depends on| |11248 --- Comment #77 from Jonathan Druart --- This patch set now depends on bug 11248. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 10:31:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 08:31:40 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 10:37:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 08:37:23 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #78 from Jonathan Druart --- (In reply to Zeno Tajoli from comment #74) > I and Paola we use Thunderbird 24.4.0 I reproduced using icedove. The "header" was not encoded. It should work now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 10:57:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 08:57:11 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 11:03:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 09:03:22 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 11:03:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 09:03:28 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #215 from Jonathan Druart --- Created attachment 27160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27160&action=edit Bug 7180: QA followup 3 1/ showmarc.pl takes the importid for staged files. 2/ small note to indicate that the vendor's discount will be used if no discount is filled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 11:15:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 09:15:09 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #79 from Jonathan Druart --- Created attachment 27161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27161&action=edit Bug 11944: Fix encoding issue for the "Did you mean" feature Test plan: 1/ Go on admin/didyoumean.pl and enable the feature for the OPAC 2/ Generate and use the french templates 3/ Launch a search at the OPAC 4/ You should see "Voulez-vous dire : Chercher ?galement les termes sp?cifiques Chercher ?galement les termes g?n?riques Chercher ?galement les termes reli?s" Before this patch: "Voulez-vous dire : Chercher ?galement les termes sp?cifiques Chercher ?galement les termes g?n?riques Chercher ?galement les termes reli?s" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 11:40:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 09:40:40 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|jonathan.druart at biblibre.co |matthias.meusburger at biblibr |m |e.com --- Comment #26 from Jonathan Druart --- (In reply to Koha Team AMU from comment #25) > If we look at the Description > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677#c0 > Points 0, 1, 3 and 4 are OK. > > But Point 2 KO. Matthias will try to have a look asap. > Nota : There's a link with BZ10855 > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 > because some new areas of the subscription must appear in the item record > fields. I would prefer to see bug 10855 pushed before to add new behaviors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 11:58:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 09:58:26 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 --- Comment #10 from Jonathan Druart --- Comment on attachment 26457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26457 Bug 9481 - charge not showing fines On 'Check out' and 'Details' screens in patron record fines for item aren't showing. Added new soubroutine to sum up all outstanding charges by borrower for this item including all historical issues and rent charges. Pr Review of attachment 26457: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9481&attachment=26457) ----------------------------------------------------------------- ::: C4/Overdues.pm @@ +659,5 @@ > return 0; > } > > +=head2 GetItemCharges > + Why don't you put this subroutine into C4::Account? @@ +668,5 @@ > +=cut > + > +sub GetItemCharges { > + my ( $borrowernumber, $itemnumber ) = @_; > + I would prefer you pass an hashref to this new subroutine. @@ +674,5 @@ > + > + my $query = "SELECT SUM(amountoutstanding) FROM accountlines WHERE borrowernumber = ? AND itemnumber = ? "; > + my $sth = $dbh->prepare( $query ); > + $sth->execute( $borrowernumber, $itemnumber ); > + return $sth->fetchrow_arrayref()->[0]; Could be done using $dbh->selectcol_arrayref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 11:58:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 09:58:37 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 --- Comment #11 from Jonathan Druart --- Comment on attachment 26685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26685 Bug 9481 (QA follow-up) - Add unit test for GetItemCharges in C4::Overdues. Review of attachment 26685: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9481&attachment=26685) ----------------------------------------------------------------- ::: t/db_dependent/Overdues.t @@ +69,5 @@ > + $sth->execute(@$loop); > +} > + > +ok(GetItemCharges($itemnumber, $borrowernumber) == 348.25, "GetItemCharges returns all outstanding charges for item"); > + What is 348.25? Please make this more readable. @@ +71,5 @@ > + > +ok(GetItemCharges($itemnumber, $borrowernumber) == 348.25, "GetItemCharges returns all outstanding charges for item"); > + > +my $anotheritemnumber = $itemnumber + 999999; > +my $anotherborrowernumber = $borrowernumber + 999999; These numbers could exist in a big DB and the test will fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 11:59:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 09:59:26 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart --- Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 12:26:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 10:26:03 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #18 from Jonathan Druart --- Created attachment 27162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27162&action=edit Bug 11425: Get column names using DBIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 12:41:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 10:41:22 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #16 from Jonathan Druart --- Comment on attachment 27130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27130 [SIGNED-OFF] Bug 12072: Add date format dd.mm.yyyy. Review of attachment 27130: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12072&attachment=27130) ----------------------------------------------------------------- ::: C4/Dates.pm @@ +40,4 @@ > > sub _prefformat { > unless ( defined $prefformat ) { > + $prefformat = C4::Context->preference('dateformat') || 'us'; I disagree with setting a default value for this pref. It must exist in DB. ::: C4/Templates.pm @@ +112,4 @@ > $vars->{opacsmallimage} = C4::Context->preference('opacsmallimage'); > $vars->{opaclayoutstylesheet} = > C4::Context->preference('opaclayoutstylesheet'); > + $vars->{dateformatstyle} = C4::Dates->new()->formatstr(); 1/ Prefer to use Koha::DateUtils instead of C4::Dates. 2/ C4::Dates is not used in C4::Templates. 3/ Prefer to sent variable to template in C4::Auth (common way to do). 4/ Very good initiative! ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt @@ +283,4 @@ > return; > } > var date_due = new Date($('#duedatespec').datepicker('getDate')); > + date_due.setHours(23, 59); Hum... why this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 12:41:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 10:41:38 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #17 from Jonathan Druart --- Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 12:56:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 10:56:51 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 --- Comment #7 from Jonathan Druart --- Created attachment 27163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27163&action=edit Improve AgeRestrictionMarker to consider the case where the marker is immediately followed by the age, eg. "K16" in Finland. How I tested: Configure Age Restricition (see Syspref AgeRestrictionMarker) and have a biblio record with e.g. PEGI 99 in age restriction field Try to check out to a patron with age < 99 Check out should be blocked Change entry in age restriction field to PEGI99 Checkout should be possible Apply patch Checkout schould now be blocked Patch behaves as expected http://bugs.koha-community.org/show_bug.cgi?id=11630 Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 12:56:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 10:56:54 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 --- Comment #8 from Jonathan Druart --- Created attachment 27164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27164&action=edit Bug 11630 [QA Followup] - Move code to subroutine, add unit tests Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 12:56:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 10:56:57 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 --- Comment #9 from Jonathan Druart --- Created attachment 27165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27165&action=edit Bug 11630: Unit tests can be independent of DB Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 12:57:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 10:57:10 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 12:57:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 10:57:24 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 12:57:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 10:57:28 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 13:06:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 11:06:19 +0000 Subject: [Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- I'm not sure "save" is more understandable than "attachbasket". This script does a lot of things ($op can be "delete", "reopen", "mod_basket", etc.). In my opinion, "save" is not really meaningful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 13:19:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 11:19:56 +0000 Subject: [Koha-bugs] [Bug 12081] tmpl_process3.pl delete temp files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 13:19:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 11:19:59 +0000 Subject: [Koha-bugs] [Bug 12081] tmpl_process3.pl delete temp files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 --- Comment #3 from Jonathan Druart --- Created attachment 27166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27166&action=edit Bug 12081 - tmpl_process3.pl - delete temp files This patch enable deletion of temp files used by tmpl_process3.pl. Just removed coments on existing code To test: 1. Do a count of files on /tmp ( ls /tmp | wc -l ) 2. Update preferred language 3. Count again, new files on /tmp 4. Apply the patch 5. Update again, check, no new files Signed-off-by: Mark Tompsett NOTE: I watched what temp files were actually in /tmp to make sure other processes didn't magically increase/decrease the number. $ perl translate update {lang code} generated 10 temporary files for me (2x5 po files). After removing those ten files, and applying the patch, no other files were generated. Signed-off-by: Jonathan Druart These lines has been commented by commit a399dcefad193fc21ef2dc1fe31d07686ab2da46 without any apparent good reason. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 13:20:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 11:20:35 +0000 Subject: [Koha-bugs] [Bug 12081] tmpl_process3.pl does not delete temp files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Summary|tmpl_process3.pl delete |tmpl_process3.pl does not |temp files |delete temp files Severity|enhancement |normal --- Comment #4 from Jonathan Druart --- In my opinion, this is a bug, not an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 13:25:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 11:25:00 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #18 from paxed --- (In reply to Jonathan Druart from comment #16) > Comment on attachment 27130 [details] [review] > [SIGNED-OFF] Bug 12072: Add date format dd.mm.yyyy. > > Review of attachment 27130 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Dates.pm > @@ +40,4 @@ > > > > sub _prefformat { > > unless ( defined $prefformat ) { > > + $prefformat = C4::Context->preference('dateformat') || 'us'; > > I disagree with setting a default value for this pref. It must exist in DB. How can it exist before Koha is installed? The installer uses templates, and as dateformatstyle is passed on to templates... I guess part 2 below solves that problem then. > > ::: C4/Templates.pm > @@ +112,4 @@ > > $vars->{opacsmallimage} = C4::Context->preference('opacsmallimage'); > > $vars->{opaclayoutstylesheet} = > > C4::Context->preference('opaclayoutstylesheet'); > > + $vars->{dateformatstyle} = C4::Dates->new()->formatstr(); > > 1/ Prefer to use Koha::DateUtils instead of C4::Dates. > 2/ C4::Dates is not used in C4::Templates. > 3/ Prefer to sent variable to template in C4::Auth (common way to do). > 4/ Very good initiative! 1/ Because Koha::DateUtils doesn't do what is needed here - it knows nothing about the actual formatting string, just a user-friendly format name like "metric". 2/ True, that needs to be added. 3/ Didn't know about that. 4/ Just bare necessity. > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt > @@ +283,4 @@ > > return; > > } > > var date_due = new Date($('#duedatespec').datepicker('getDate')); > > + date_due.setHours(23, 59); > > Hum... why this change? Because offline UI showed the date AND the time in the datetimepicker... but the time was always hardcoded to 23:59. The other change in the offline UI was to remove the time display from the datepicker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 13:48:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 11:48:06 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #19 from Jonathan Druart --- (In reply to paxed from comment #18) > > 1/ Prefer to use Koha::DateUtils instead of C4::Dates. > > 2/ C4::Dates is not used in C4::Templates. > > 3/ Prefer to sent variable to template in C4::Auth (common way to do). > > 4/ Very good initiative! > > 1/ Because Koha::DateUtils doesn't do what is needed here - it knows nothing > about the actual formatting string, just a user-friendly format name like Is is not a good idea to continue to add code in C4::Dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:02:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:02:04 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- >From C4::Serials::can_edit_subscription: or C4::Auth::haspermission( $userid, {serials => 'superserials'}), or C4::Auth::haspermission( $userid, {serials => 'edit_subscription'}), If a user has edit_subscription he cans edit a subscription (without having superserials). But or $subscription->{branchcode} eq C4::Context->userenv->{'branch'} Means: if the user is on the same branch, he cans edit it too. So a user can edit a subscription without having the edit_subscription permission... hum... Who wrote this code?? (...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:12:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:12:25 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25798|0 |1 is obsolete| | Attachment #25799|0 |1 is obsolete| | Attachment #25800|0 |1 is obsolete| | Attachment #25801|0 |1 is obsolete| | Attachment #25802|0 |1 is obsolete| | Attachment #25803|0 |1 is obsolete| | Attachment #25804|0 |1 is obsolete| | Attachment #25805|0 |1 is obsolete| | Attachment #25806|0 |1 is obsolete| | Attachment #25807|0 |1 is obsolete| | Attachment #25808|0 |1 is obsolete| | Attachment #25809|0 |1 is obsolete| | Attachment #25810|0 |1 is obsolete| | Attachment #25811|0 |1 is obsolete| | Attachment #25812|0 |1 is obsolete| | Attachment #25813|0 |1 is obsolete| | Attachment #25814|0 |1 is obsolete| | Attachment #25815|0 |1 is obsolete| | Attachment #25816|0 |1 is obsolete| | Attachment #25930|0 |1 is obsolete| | Attachment #25933|0 |1 is obsolete| | Attachment #25934|0 |1 is obsolete| | --- Comment #270 from Kyle M Hall --- Created attachment 27167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27167&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:13:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:13:00 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #271 from Kyle M Hall --- Created attachment 27168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27168&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:13:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:13:09 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #272 from Kyle M Hall --- Created attachment 27169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27169&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:13:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:13:12 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|neworderempty should |neworderempty should |preselect the only fund |preselect the only active | |fund for new orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:13:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:13:16 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #273 from Kyle M Hall --- Created attachment 27170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27170&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:13:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:13:24 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #274 from Kyle M Hall --- Created attachment 27171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27171&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:13:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:13:30 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #275 from Kyle M Hall --- Created attachment 27172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27172&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:13:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:13:36 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #276 from Kyle M Hall --- Created attachment 27173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27173&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:13:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:13:43 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #277 from Kyle M Hall --- Created attachment 27174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27174&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:13:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:13:49 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #278 from Kyle M Hall --- Created attachment 27175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27175&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:13:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:13:56 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #279 from Kyle M Hall --- Created attachment 27176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27176&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:14:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:14:05 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #280 from Kyle M Hall --- Created attachment 27177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27177&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:14:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:14:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #281 from Kyle M Hall --- Created attachment 27178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27178&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:14:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:14:19 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #282 from Kyle M Hall --- Created attachment 27179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27179&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:14:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:14:26 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #283 from Kyle M Hall --- Created attachment 27180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27180&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:14:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:14:33 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #284 from Kyle M Hall --- Created attachment 27181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27181&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:14:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:14:39 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #285 from Kyle M Hall --- Created attachment 27182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27182&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:14:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:14:45 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #286 from Kyle M Hall --- Created attachment 27183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27183&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:14:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:14:46 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #16 from M. de Rooy --- (In reply to Katrin Fischer from comment #15) > Hm, die we uncover another bug here? It seems one of those days... > > I think when modifying an existing order, it should always preselect what's > in the database, even if the fund has been marked inactive since or was > inactive when selected. If we need to preselect 'show all' in order to make > that work, I guess we need to do that. I was thinking in the same direction. New patch forthcoming (need to adjust a few lines more..) No need to preselect Show all btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:14:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:14:54 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #287 from Kyle M Hall --- Created attachment 27184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27184&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:15:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:15:00 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #288 from Kyle M Hall --- Created attachment 27185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27185&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:15:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:15:10 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #289 from Kyle M Hall --- Created attachment 27186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27186&action=edit Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:15:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:15:17 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:15:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:15:17 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #290 from Kyle M Hall --- Created attachment 27187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27187&action=edit Bug 6427 [Part 21] - Fix ILSDI::Services -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:15:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:15:20 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27067|0 |1 is obsolete| | --- Comment #17 from M. de Rooy --- Created attachment 27188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27188&action=edit Bug 9088: Neworderempty should preselect the only active fund This patch makes the following changes to the template: [1] If you add an order line, and you have one active fund (and zero or more inactive funds), the only active fund is preselected. [2] If you modify an order line while its fund is inactive, it now shows the label (inactive) behind the fund name. (Note that other inactive funds may come up when clicking 'Show all' as they did before.) [3] Corrected some indentation in this template part. Test plan: [1] Add an order line while having one active fund. Is it selected? [2] Add an order line while having two or more active funds. No fund should be preselected. [3] Modify an order line with an active fund. Is it still selected? [4] Modify an order line with an inactive fund F2 (while having one active fund F1; note that this test explicitly wants F1 to be before F2). Check if F2 is selected and is labeled inactive. [5] (Bonus points:) Modify an order line that refers to a deleted fund. If you edit this order, the fund combo should say: Select a fund. (Note: if you delete a fund, the budget_id in aqorders remains.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:15:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:15:24 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #291 from Kyle M Hall --- Created attachment 27189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27189&action=edit Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:15:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:15:30 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #292 from Kyle M Hall --- Created attachment 27190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27190&action=edit Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:15:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:15:32 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:26:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:26:03 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27188|0 |1 is obsolete| | --- Comment #18 from M. de Rooy --- Created attachment 27191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27191&action=edit Bug 9088: Neworderempty should preselect the only active fund This patch makes the following changes to the template: [1] If you add an order line, and you have one active fund (and zero or more inactive funds), the only active fund is preselected. [2] If you modify an order line while its fund is inactive, it now shows the label (inactive) behind the fund name. (Note that other inactive funds may come up when clicking 'Show all' as they did before.) [3] Corrected some indentation in this template part. Test plan: [1] Add an order line while having one active fund. Is it selected? [2] Add an order line while having two or more active funds. No fund should be preselected. [3] Modify an order line with an active fund. Is it still selected? [4] Modify an order line with an inactive fund F2 (while having one active fund F1; note that this test explicitly wants F1 to be before F2). Check if F2 is selected and is labeled inactive. [5] (Bonus points:) Modify an order line that refers to a deleted fund. If you edit this order, the fund combo should say: Select a fund. (Note: if you delete a fund, the budget_id in aqorders remains.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:26:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:26:14 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #80 from Paola Rossi --- I apply against master 3.15.00.030 and at the 16-th patch: Applying: Bug 11944: Fix encoding issue on adding a subscription fatal: sha1 information is lacking or useless (serials/subscription-frequency.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11944: Fix encoding issue on adding a subscription ----------------------------------------------------------------------------- So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:26:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:26:45 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #19 from M. de Rooy --- Couldn't resist adjusting indentation in the commit message too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:34:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:34:35 +0000 Subject: [Koha-bugs] [Bug 12081] tmpl_process3.pl does not delete temp files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27137|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Comment on attachment 27137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27137 [SIGNED OFF] Bug 12081 - tmpl_process3.pl - delete temp files Obsolted old patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:34:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:34:57 +0000 Subject: [Koha-bugs] [Bug 10936] Standardnumber doubled up in Advanced search - more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10936 --- Comment #15 from Marc V?ron --- Created attachment 27192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27192&action=edit Bug 10936 - Follow-up for Prog theme - Standardnumber doubled up in Advanced search - more options TEST PLAN --------- 1) Set opacthemes system preference to prog 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:47:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:47:51 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:47:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:47:55 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27080|0 |1 is obsolete| | --- Comment #81 from Jonathan Druart --- Created attachment 27193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27193&action=edit Bug 11944: Fix encoding issue on adding a subscription If frequencies or numbering patterns contain non-latin characters, so output was broken. To reproduce: - Create a frequency and a numbering pattern with non-latin characters - Add a new subscription using these values - The screen should not contain bad encoded characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:48:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:48:04 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27158|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart --- Created attachment 27194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27194&action=edit Bug 11944: use CGI( -utf8 ) everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:48:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:48:10 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27159|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart --- Created attachment 27195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27195&action=edit Bug 11944: Fix encoding on sending emails This patch fixes 2 places where mails were badly encoded: 1/ At the opac and the intranet, on sending baskets 2/ At the opac and the intranet, on sending shelf/list Test plan: Shelf/List: - Create a list with non-latin characters in the name. - Add some items containing non-latin characters in their content. - Send the list by email Basket/Cart: - Add some items containing non-latin characters in their content to your cart.. - Send the cart by email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 14:48:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 12:48:36 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27161|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart --- Created attachment 27196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27196&action=edit Bug 11944: Fix encoding issue for the "Did you mean" feature Test plan: 1/ Go on admin/didyoumean.pl and enable the feature for the OPAC 2/ Generate and use the french templates 3/ Launch a search at the OPAC 4/ You should see "Voulez-vous dire : Chercher ?galement les termes sp?cifiques Chercher ?galement les termes g?n?riques Chercher ?galement les termes reli?s" Before this patch: "Voulez-vous dire : Chercher ?galement les termes sp?cifiques Chercher ?galement les termes g?n?riques Chercher ?galement les termes reli?s" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 15:17:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 13:17:29 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #293 from Kyle M Hall --- Created attachment 27197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27197&action=edit Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 15:21:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 13:21:06 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED Assignee|frederic at tamil.fr |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- I will try to provide a global fix for this permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 15:32:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 13:32:08 +0000 Subject: [Koha-bugs] [Bug 12008] hold notice can be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12008 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- I cold not reproduce this behaviour on Koha version 3.15.00.030 However, I could not create a HOLD message with Koha module set to "reserves", the drop down shows only Catalog, Circulation, Claim Acquisition, Claim serial issue, Holds, Members, Serials (routing list), Suggestion. The only way to have HOLD with module "reserves" was by making a copy from (All libraries). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 15:34:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 13:34:25 +0000 Subject: [Koha-bugs] [Bug 12094] New: jQueryUI upgrade broke default tab selection Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 Bug ID: 12094 Summary: jQueryUI upgrade broke default tab selection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Another unforeseen consequence of the jQueryUI upgrade: default tab select is broken. This is most visible on the search results page where the "search the catalog" tab should be selected by default but isn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 15:54:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 13:54:58 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from M. de Rooy --- (In reply to Jonathan Druart from comment #27) > There are 2 reasons. > 1/ I don't see the load difference following the test plan. > 2/ There are some calls to > memoize_memcached('subroutine_name', memcached => C4::Context->memcached); > in the code. > If the call is wrong, we should fix it everywhere. If I am wrong, I am not > able to pass qa on it :) I installed memcached (and ..) and ran the memoize_memcached call for GetMarcStructure and called it in a for loop so many times. My findings are: 1) As Jonathan pointed out, the call seems to be wrong. If I pass memcached =>1 as parameter, I also have: Invalid memcached argument (expected a hash). If I pass memcached => {}, it seems to be okay. I do not understand why we still find this error. Are other people using another version for memcached, Cache::Memcached or Memoize::Memcached? 2) When I increase the number of loops (calls to GetMarcStructure), I also see that the memcache variant is much slower. Since I am not yet that familiar with memcached, I am not sure if this is just a matter of configuration. I would appreciate some more feedback from the author or other users of memcached. I will send a mail to the dev list. Changing status to reflect the need for clarification. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:04:03 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #85 from Paola Rossi --- I apply against master 3.15.00.030 and at the 17-th patch: Applying: Bug 11944: use CGI( -utf8 ) everywhere fatal: sha1 information is lacking or useless (opac/opac-sendshelf.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11944: use CGI( -utf8 ) everywhere ----------------------------------------------------------------------------- So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:12:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:12:31 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26857|0 |1 is obsolete| | --- Comment #86 from Jonathan Druart --- Created attachment 27198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27198&action=edit Bug 11944: Remove all utf8 filter from templates This patch - removes all html_entity usages in tt file which hide utf8 bugs - removes all encode utf8 in tt plugins because we should get correctly marked data from DBIC and other sources directly (cf plugin EncodeUTF8 used in renew.tt) - adds some cleanup in C4::Templates::output: we now use perl utf8 file handler output so we don't need to decode tt variables manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:12:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:12:36 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26858|0 |1 is obsolete| | --- Comment #87 from Jonathan Druart --- Created attachment 27199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27199&action=edit Bug 11944: replace use of utf8 with Encode See the wiki page for the explanation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:12:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:12:54 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26859|0 |1 is obsolete| | --- Comment #88 from Jonathan Druart --- Created attachment 27200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27200&action=edit Bug 11944: Encoding UTF8 in C4::Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:02 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26860|0 |1 is obsolete| | --- Comment #89 from Jonathan Druart --- Created attachment 27201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27201&action=edit Bug 11944: Set ImplicitUnicode for YAML Before this patch, string for yaml files used in preferences.pl were broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:10 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26862|0 |1 is obsolete| | --- Comment #90 from Jonathan Druart --- Created attachment 27202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27202&action=edit Bug 11944: Library name variable should be decoded Test on preferences.pl and on some others pages when mysql is used to store session. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:16 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26863|0 |1 is obsolete| | --- Comment #91 from Jonathan Druart --- Created attachment 27203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27203&action=edit Bug 11944: replace uri_escape with uri_escape_utf8 everywhere To reproduce, edit, index notice with ?? and search "??" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:21 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26864|0 |1 is obsolete| | --- Comment #92 from Jonathan Druart --- Created attachment 27204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27204&action=edit Bug 11944: Never use decode/encode in TT Plugins The EncodeUTF8 TT plugin is useless, we should NEVER use encode in templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:26 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26865|0 |1 is obsolete| | --- Comment #93 from Jonathan Druart --- Created attachment 27205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27205&action=edit Bug 11944: Remove obsolete encoding routines We don't need to decode manually which provide nice performance boost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:30 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26866|0 |1 is obsolete| | --- Comment #94 from Jonathan Druart --- Created attachment 27206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27206&action=edit Bug 11944: TT Plugins should not encode strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:41 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26868|0 |1 is obsolete| | --- Comment #96 from Jonathan Druart --- Created attachment 27208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27208&action=edit Bug 11944: FIX Error on editing an authority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:35 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26867|0 |1 is obsolete| | --- Comment #95 from Jonathan Druart --- Created attachment 27207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27207&action=edit Bug 11944: Some refresh don't indicate the charset to use This patch replaces occurrences of META HTTP-EQUIV=Refresh with a redirection. Note: The list of modified files has been got with the following grep: git grep Content-Type | grep -v -i utf | grep Refresh | grep -v translator | grep -v \.js Test plan: 1) admin/auth_tag_structure.pl - Go on an authority MARC framework for an authority type (admin/auth_tag_structure.pl?authtypecode=CO for instance) - Click on the "Add a new tag" button - Fill fields - Save - You should be redirected on the auth_tag_structure.pl page - Try to modify an existing tag - The redirection should be done 2) admin/auth_subfields_structure.pl - From the previous page, click on a "subfields" link - Edit/Add a new subfields - Save - You should be redirected to the subfield list - Delete a subfield - You should be redirected to the subfield list 3) admin/authorised_values.pl - Add/Edit an authorised value - Save - You should be redirected to the authorised value list (with the right category selected) 4) admin/categorie.pl - Add/Edit a patron category - Save - You should be redirected to the category list - Delete a patron category - You should be redirected to the category list 5) admin/koha2marclinks.pl - Go on the Koha to MARC mapping configuration page - Edit a field - Map a field and click on "OK" - You should be redirected to the list 6) admin/marc_subfields_structure.pl - Go on the MARC frameworks page - Click on "MARC structure" for one on the list - Click on "Subfields" for one on the list - Add/Edit a subfield - Save - You should be redirected to the subfield list 7) admin/systempreferences.pl - Go on the system preferences admin page - Click on the "Local use" tab - Add/Edit a pref - Save - You shold be redirected to the Local use preference list 8) serials/subscription-detail.pl - Go on a subscription detail page - Delete the subscription (using Edit > Delete subscription) - You should be redirected on the serials home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:46 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26869|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart --- Created attachment 27209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27209&action=edit Bug 11944: Fix encoding issue on searching The search patch should fix non-latin character searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:51 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26870|0 |1 is obsolete| | --- Comment #98 from Jonathan Druart --- Created attachment 27210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27210&action=edit Bug 11944: Facets and resort This patch should fix facets and resort encoding issues. Note: This patch will certainly break the search history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:13:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:13:56 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26871|0 |1 is obsolete| | --- Comment #99 from Jonathan Druart --- Created attachment 27211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27211&action=edit Bug 11944: Authentication The password should be encoded before hashing. Test plan: - Before applying the patch, create a user with a password "????" - apply patches - try to log in - change the password - log out - try to log in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:14:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:14:10 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27193|0 |1 is obsolete| | --- Comment #101 from Jonathan Druart --- Created attachment 27213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27213&action=edit Bug 11944: Fix encoding issue on adding a subscription If frequencies or numbering patterns contain non-latin characters, so output was broken. To reproduce: - Create a frequency and a numbering pattern with non-latin characters - Add a new subscription using these values - The screen should not contain bad encoded characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:14:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:14:04 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26921|0 |1 is obsolete| | --- Comment #100 from Jonathan Druart --- Created attachment 27212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27212&action=edit Bug 11944: Fix fund names encoding on the parcel page On the parcel page, the subtotal values are stored in an hashref. The key was the fund name. The fund name being encoded in utf8, the hashref was broken. This patch replaces this logic creating a key based on an integer. The budget name is now stored in a new "budget_name" key. Note: It also fixes a small ergonomic issue (a td was missing in the tfoot). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:14:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:14:16 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27194|0 |1 is obsolete| | --- Comment #102 from Jonathan Druart --- Created attachment 27214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27214&action=edit Bug 11944: use CGI( -utf8 ) everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:14:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:14:21 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27195|0 |1 is obsolete| | --- Comment #103 from Jonathan Druart --- Created attachment 27215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27215&action=edit Bug 11944: Fix encoding on sending emails This patch fixes 2 places where mails were badly encoded: 1/ At the opac and the intranet, on sending baskets 2/ At the opac and the intranet, on sending shelf/list Test plan: Shelf/List: - Create a list with non-latin characters in the name. - Add some items containing non-latin characters in their content. - Send the list by email Basket/Cart: - Add some items containing non-latin characters in their content to your cart.. - Send the cart by email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:14:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:14:27 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27196|0 |1 is obsolete| | --- Comment #104 from Jonathan Druart --- Created attachment 27216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27216&action=edit Bug 11944: Fix encoding issue for the "Did you mean" feature Test plan: 1/ Go on admin/didyoumean.pl and enable the feature for the OPAC 2/ Generate and use the french templates 3/ Launch a search at the OPAC 4/ You should see "Voulez-vous dire : Chercher ?galement les termes sp?cifiques Chercher ?galement les termes g?n?riques Chercher ?galement les termes reli?s" Before this patch: "Voulez-vous dire : Chercher ?galement les termes sp?cifiques Chercher ?galement les termes g?n?riques Chercher ?galement les termes reli?s" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:15:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:15:05 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #105 from Jonathan Druart --- I resubmit all 19 patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:28:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:28:06 +0000 Subject: [Koha-bugs] [Bug 12095] New: Hold queue should take closed dates into account Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12095 Bug ID: 12095 Summary: Hold queue should take closed dates into account Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I recommend that the hold queue should take closed dates on the calendar into account. At least it should be an option. And that option should include that it takes the dates into account if the number of consecutive days closed is X amount. For example, if a library is closed 2 days, it might not be a factor, but if a library is closed for 4 or 5 days, it is. This is particularly important for systems with branches that are open very little during the week, or perhaps they are closed during parts of the year, like school libraries. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:45:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:45:09 +0000 Subject: [Koha-bugs] [Bug 12096] New: upload multiple cover images at once Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12096 Bug ID: 12096 Summary: upload multiple cover images at once Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice to be able to upload multiple images at once and not have to do them one at a time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:46:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:46:00 +0000 Subject: [Koha-bugs] [Bug 12097] New: replace cover replaces all covers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12097 Bug ID: 12097 Summary: replace cover replaces all covers Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When you upload an image to replace an existing cover, ALL the images get replaced, not just the current cover image one sees on the search result landing page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:57:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:57:37 +0000 Subject: [Koha-bugs] [Bug 12094] jQueryUI upgrade broke default tab selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:57:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:57:40 +0000 Subject: [Koha-bugs] [Bug 12094] jQueryUI upgrade broke default tab selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 --- Comment #1 from Owen Leonard --- Created attachment 27217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27217&action=edit Bug 12094 - jQueryUI upgrade broke default tab selection The recent upgrade to jQueryUI didn't take into account the new method for forcing selection of a tab by adding a class to the tab markup. This patch corrects this by updating the class name. This patch also updates one instance where it was necessary to switch to the new function for selecting a tab by ID, introduced by Bug 12075. To test, view the following pages: - Perform a catalog search in the staff client. On the search results page the "Search the catalog" tab should be selected. - In Acquisitions, view the basket groups page for a vendor which has open and closed basket groups (/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=X). Append "&listclosed=1" to the URL. The "Closed" tab should be selected. - In Administration -> Authorized values, modify an authorized value for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Administration -> Item types, modify an itemtype for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Cataloging, open an existing record and select any tab besides the first one. Choose "Save and continue editing" from the Save menu. When the page reloads you should be returned to the tab you selected before. - In Suggestions, markup for selected the tab has been removed because it didn't appear to be performing any function. The first tab is selected by default. The template doesn't need to explicitly add a class to make it so. - In Tools -> CSV profiles, choose an existing profile for editing. When the page loads the "Edit existing profile" tab should be selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 16:59:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 14:59:42 +0000 Subject: [Koha-bugs] [Bug 12096] upload multiple cover images at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12096 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:00:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:00:55 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:00:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:00:59 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 --- Comment #8 from Jonathan Druart --- Created attachment 27218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27218&action=edit Bug 12080: Fix C4::Serials::can_edit_subscription This patch adds some unit tests for the can_edit_subscription and add a new can_show_subscription subroutines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:01:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:01:05 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 --- Comment #9 from Jonathan Druart --- Created attachment 27219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27219&action=edit Bug 12080: Refactor can_*_subscription in C4::Serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:01:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:01:29 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22910|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 27220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27220&action=edit Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match Signed-off-by: Tom McMurdo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:01:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:01:38 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22911|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall --- Created attachment 27221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27221&action=edit Bug 10500: Followup for UNIMARC In UNIMARC, the isbn index is ISBN. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:04:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:04:33 +0000 Subject: [Koha-bugs] [Bug 11834] Filter on news tool page doesn't remember what has been selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11834 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- Fixed by Bug 7567 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:05:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:05:01 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 --- Comment #10 from Jonathan Druart --- I tried to do something for this permission, the can_edit_subscription was broken and I think we need a can_show_subscription. I added/modified these 2 routines in 2 last patches. I will be afk for 1 week and not able to continue. So you can obsolete my patch and continue with the signoff one, or continue with my patches. I will reopen a new report with these 2 patches if you decide to fix only the SearchSubscriptions routine. Feel free to do what you want and sorry not to provide a complete patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:05:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:05:08 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:05:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:05:12 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #32 from Kyle M Hall --- Created attachment 27222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27222&action=edit Bug 10500 [QA Followup] - Add checks for empty isbn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:05:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:05:18 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at biblibre.co |frederic at tamil.fr |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:14:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:14:15 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #106 from Paola Rossi --- I'm sorry, but I see the problem again with the new patches. The problem is still on the 17-th patch, about the same pl: Applying: Bug 11944: use CGI( -utf8 ) everywhere fatal: sha1 information is lacking or useless (opac/opac-sendshelf.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11944: use CGI( -utf8 ) everywhere ----------------------------------------------------------------------------- This is the opac/opac-sendshelf.pl from 20-th line on: use strict; use warnings; use CGI; use Encode; use Carp; .... ----------------------------------------------------------------------------- whilest these are the lines searched by the 17-th patch: -use CGI; -use Encode qw(decode encode); ----------------------------------------------------------------------------- So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:24:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:24:45 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #107 from Jonathan Druart --- (In reply to Paola Rossi from comment #106) It should work. Did you apply patches from bug 11248 before? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:36:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:36:54 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Pasi! Thanks also to Kyle and Jonathan for working on the test cases. Nowadays, changes to routines in the C4 and Koha namespaces really ought to come with unit and/or regression tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 17:37:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 15:37:10 +0000 Subject: [Koha-bugs] [Bug 12081] tmpl_process3.pl does not delete temp files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12081 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 18:26:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 16:26:55 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #108 from Paola Rossi --- (In reply to Jonathan Druart from comment #107) > (In reply to Paola Rossi from comment #106) > > It should work. Did you apply patches from bug 11248 before? That was the error! Now I've started applying the 3 patches of 11248, and so I can apply all the 22 patches. So I pass the patch to "Needs Signoff" status. [Until May the 5-th I'll rarely be on bugzilla.] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 19:11:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 17:11:05 +0000 Subject: [Koha-bugs] [Bug 6897] show hold expiration date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6897 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Nicole C. Engard --- This is in Koha 3.14 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 20:35:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 18:35:13 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 --- Comment #3 from Owen Leonard --- Created attachment 27223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27223&action=edit Bug 12089 - Remove use of dt_add_type_uk_date() - Budgets This patch removes use of dt_add_type_uk_date() from the budgets administration page and updates the sorting configuration according to current guidelines. Date sorting is converted to the title-string method. Invalid "align" attribute is replaced with a class. Also corrected: Active tab selection based on class. To test, go to Administration -> Budgets and confirm that sorting works correctly on both the active and inactive budget tabs. Sorting by date should work correctly regardless of dateformat system preference. To test tab selection, append "?tab=2" to the page URL and confirm that the inactive budget tab is selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 20:38:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 18:38:07 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27139|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 27224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27224&action=edit Bug 12089 [Revised] Remove use of dt_add_type_uk_date() - Circulation This patch removes instances of dt_add_type_uk_date() from there circulation templates and updates the sorting configuration according to current guidelines. To test, enable the UseTablesortForCirc system preference and open a patron for circulation who has multiple items checked out. Confirm that sorting by due date, title, and checkout date work correctly. Locate a patron who is guarantor to another or is guaranteed by another. One or both patrons should have checkouts. The "relatives checkouts" tab on the checkout page should sort correctly on due date, title, and checkout date. On the transfers to receive report, confirm that sorting by date of transfer and title work correctly for all tables. On the holds awaiting pickup report the "available since" and title columns should sort correctly for tables in both tabs (waiting and over). Revision: Missed an instance of dt_add_type_uk_date(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 20:49:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 18:49:50 +0000 Subject: [Koha-bugs] [Bug 8797] can't delete quote of the day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #6 from Chris Nighswonger --- I'm running 3.15.00.030. 1. Drop/create database. 2. Run webinstaller, selecting sample quote data. 3. Log in to fresh install 4. Navigate to quote editor 5. Select quote #7 6. Click delete button 7. Table refreshes automatically and removes quote #7 So far so good. 8. Now the remaining quotes are unselectable. 9. Refreshing page makes remaining quote selectable again. 10. Select quote #6. 11. Click delete button 12. Table refreshes automatically and removes quote #6 13. Remaining quotes are once again unselectable So it appears that the select function gets dropped when the table is redrawn. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 21:12:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 19:12:42 +0000 Subject: [Koha-bugs] [Bug 12098] New: User can edit some subcriptions he should be prevented to Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Bug ID: 12098 Summary: User can edit some subcriptions he should be prevented to Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com If the user doesn't have the superserials permission, or isn't superlibrarian, you can still edit a subscription accessing the subscription detail page through the serial collection page (for records with multiple subscriptions) or accessing the detail page directly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 21:13:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 19:13:06 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12098 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 21:13:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 19:13:06 +0000 Subject: [Koha-bugs] [Bug 12098] User can edit some subcriptions he should be prevented to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12080 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 21:14:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 19:14:40 +0000 Subject: [Koha-bugs] [Bug 12098] User can edit some subcriptions he should be prevented to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, | |katrin.fischer at bsz-bw.de, | |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 21:17:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 19:17:03 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 --- Comment #11 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #10) > I will be afk for 1 week and not able to continue. So you can > obsolete my patch and continue with the signoff one, or continue with > my patches. I will obsolete your patches. I have tested them. It works, and solves problem 2 described by Katrin. And last but not lease, you two functions add clarity to the code. But I think that another bug number, with your patch, specifically for problem 2, is more manageable for RM, especially since my patch is already dependent on bug 12048. > I will reopen a new report with these 2 patches if you decide to fix only > the SearchSubscriptions routine. See bug 12098 for attaching your patch. I'd be glad to sign-of it. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 21:17:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 19:17:48 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27218|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 21:18:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 19:18:04 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 21:19:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 19:19:07 +0000 Subject: [Koha-bugs] [Bug 12080] Superserials permission appears to be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Fr?d?ric Demians --- I've reverted to Signed-off, since it was the case before Jonathan new patch, which should land now on bug 12098. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 22:24:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 20:24:53 +0000 Subject: [Koha-bugs] [Bug 9749] Placeholders in koha-conf.xml generated by the Debian packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9749 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #1 from Magnus Enger --- *** Bug 12083 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 16 22:24:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 20:24:53 +0000 Subject: [Koha-bugs] [Bug 12083] koha-create misses string substitution in ./templates/koha-conf-site.xml.in file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12083 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |magnus at enger.priv.no Resolution|--- |DUPLICATE --- Comment #2 from Magnus Enger --- *** This bug has been marked as a duplicate of bug 9749 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 17 00:37:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Apr 2014 22:37:30 +0000 Subject: [Koha-bugs] [Bug 12098] User can edit some subcriptions he should be prevented to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 --- Comment #1 from M. Tompsett --- Perhaps we should move JD's patches from bug 12080 here? I don't like the thought that his patches are hidden by being obsoleted on another bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 17 02:47:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Apr 2014 00:47:13 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #210 from M. Tompsett --- Further testing has shown an problem with the id generation. You can't upload a file with identical contents to different directories. I'll add a patch for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 17 02:52:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Apr 2014 00:52:00 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #211 from M. Tompsett --- Created attachment 27225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27225&action=edit Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 17 03:33:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Apr 2014 01:33:41 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- I noticed this patch doesn't apply still. However, the idea of the patch is pretty obvious: put the OPACMobileUserCSS before OPACUserCSS. I noticed that the reason it doesn't apply is because of the bidi logic. I also noticed that the prog and ccsr themes handle the ordering of the bidi logic differently. Karam Qubsi in bug 10017 fixed right-to-left in the ccsr theme. Jared Camins-Esakov in bug 10405 added ids for the ccsr theme. D Ruth Bavousett in bug 8061 applies a patch similar to 10017's to the prog theme. Jared Camins-Esakov in bug 10405 added ids for the prog theme too. mtompset at ubuntu:~/kohaclone$ git blame -L25,35 koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc 3229d8b1 (Fr?d?rick Capovilla 2012-08-12 18:32:45 -0400 25) 5884fb10 (Chris Cormack 2011-04-10 20:38:30 +1200 32) at the file To test: 1) Update po files for your preffered language 2) Check occurrence of mergeAuth on staff PO file or try egrep -n "Merging with authority: |Cancel merge" strings appear in a JS func 3) Apply the patch 4) Update translations again, chech again, old strings now begin with #~ (obsoleted) and there are new entries for the messages 5) Check functionality provided by script Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 21:24:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 19:24:01 +0000 Subject: [Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 21:24:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 19:24:04 +0000 Subject: [Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26521|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 27370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27370&action=edit [SIGNED-OFF] Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders This patch MARC21 modifies value builders 006 and 008 to make confirm popup translatable To test: 1) Update po files for your preferred language, xx-YY cd misc/translator; perl translate update xx-YY 2) Check that confirm string is NOT present egrep -B3 "Show values for|material type\?" po/xx-YY*po 3) Apply the patch 4) Repeat 1) 5) Repeat 2), now the strings are present Also check that english or translated popup is right Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 21:28:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 19:28:35 +0000 Subject: [Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 21:28:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 19:28:37 +0000 Subject: [Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26520|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 27371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27371&action=edit [SIGNED-OFF] Bug 11639 - Untranslatable strings in 007 builder This patch modifies marc21_field_007.tt to make some missing strings translatable To test: 1) Using your preferred language, xx-YY, updatepo files cd misc/translator perl translate update xx-YY 2) Check that missing strings are NOT present egrep -i "exact bit depth|pad with zero|use up to 6" po/xx-YY-i-staff-t-prog-v-3006000.po 3) Apply the patch 4) repeat 1) 5) Repeat 2), check that missing strings are present Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 21:55:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 19:55:57 +0000 Subject: [Koha-bugs] [Bug 12105] Remove duplicated plugin jquery.dataTables.columnFilter.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- $ grep jquery.dataTables.columnFilter.js `find .` | cut -f1 -d':' Binary file ./.git/index matches ./koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.columnFilter.js ./koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt ./koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.columnFilter.js ./koha-tmpl/intranet-tmpl/prog/fr-FR/modules/acqui/parcel.tt ./koha-tmpl/intranet-tmpl/prog/fr-FR/modules/tools/manage-marc-import.tt ./koha-tmpl/intranet-tmpl/prog/fr-FR/modules/catalogue/detail.tt ./koha-tmpl/intranet-tmpl/prog/fr-FR/lib/jquery/plugins/jquery.dataTables.columnFilter.js The fr-FR template files will be regenerated from en template files, so they can be ignored. There are two copies of the same file, and yes the non-language version should be used. ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt uses the [% interface %] version, which is the correct one. ./koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt loads the javascript file, but does not use it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:16:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:16:26 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #53 from Katrin Fischer --- Created attachment 27372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27372&action=edit [PASSED QA] Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer All patches together pass QA script and tests. Also, new tests in t/db_dependent/ pass. Tested in all 4 OPAC themes, being logged in and anonymous. Anonymous search history will be appended to personal search history after logging in. Also verified that cleanup_database still purges search history, now also including the authority searchs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:16:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:16:29 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #54 from Katrin Fischer --- Created attachment 27373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27373&action=edit [PASSED QA] Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:16:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:16:32 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #55 from Katrin Fischer --- Created attachment 27374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27374&action=edit [PASSED QA] Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:16:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:16:35 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #56 from Katrin Fischer --- Created attachment 27375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27375&action=edit [PASSED QA] Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:16:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:16:38 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #57 from Katrin Fischer --- Created attachment 27376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27376&action=edit [PASSED QA] Bug 10807: The new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:16:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:16:41 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #58 from Katrin Fischer --- Created attachment 27377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27377&action=edit [PASSED QA] Bug 10807: Add an authority search history for the OPAC - bootstrap Patch for the bootstrap theme Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:16:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:16:44 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #59 from Katrin Fischer --- Created attachment 27378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27378&action=edit Bug 10807: Follow-up: Change wording of tabs Changed the tabs from Catalog and Authority to Catalog searches and Authority searches to be a bit more specific. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:18:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:18:10 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:18:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:18:13 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:18:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:18:15 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24225|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:18:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:18:17 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:18:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:18:18 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24221|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:18:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:18:20 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:18:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:18:22 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24223|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:19:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:19:33 +0000 Subject: [Koha-bugs] [Bug 12120] New: Add --tempdir arg to rebuild_zebra.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12120 Bug ID: 12120 Summary: Add --tempdir arg to rebuild_zebra.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org Sometimes zebra indexing will fail when the filesystem of the /tmp dir is too small for the indexing temp file ie: a 20 gig temp file is needed, and /tmp is only 1 gig :( ...in this situation, it is necessary to tell rebuild_zebra.pl to use a different filesystem with the required space. this patch aims to provide this functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:27:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:27:20 +0000 Subject: [Koha-bugs] [Bug 12105] Remove duplicated plugin jquery.dataTables.columnFilter.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 --- Comment #3 from M. Tompsett --- One question. Is Order Line supposed to sort string-based and not numerically? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 22:45:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 20:45:39 +0000 Subject: [Koha-bugs] [Bug 9749] Placeholders in koha-conf.xml generated by the Debian packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9749 --- Comment #2 from Mason James --- > So unless I am missing something we should perhaps remove some of the > placeholders from koha-conf-site.xml.in again? > > The slightly weird thing is that all these placeholders do not seem to > affect Koha in any way... i have experienced this bug too the glitchy config files have caused non-working zebras for me i think the fix is to patch koha-create to correctly substitute the missing placeholders, rather than remove them -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 21 23:37:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 21:37:00 +0000 Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 00:21:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 22:21:16 +0000 Subject: [Koha-bugs] [Bug 12105] Remove duplicated plugin jquery.dataTables.columnFilter.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 00:21:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 22:21:18 +0000 Subject: [Koha-bugs] [Bug 12105] Remove duplicated plugin jquery.dataTables.columnFilter.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27277|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 27379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27379&action=edit [SIGNED OFF] Bug 12105 - Remove duplicated plugin jquery.dataTables.columnFilter.js This patch removes a redundant copy of the DataTables plugin jquery.dataTables.columnFilter.js and corrects two templates. The path to the plugin has been modified in acqui/parcel.tt: - Go to Acquisitions and search for a vendor. - Open the detail page for that vendor. - Click the "Receive shipments" button. - Select an invoice to view. - In the table of titles, confirm that the column header search forms work to filter column data. In the template for the Staged MARC management page the plugin has been removed as it is unused. A couple of markup corrects have been made. Confirm that table sorting is unaffected by going to Administration -> Staged MARC management, clicking a staged MARC file, and viewing the table of items in that batch. There should be no more remaining instances of this path in the templates: [% themelang %]/lib/jquery/plugins/jquery.dataTables.columnFilter.js Signed-off-by: Mark Tompsett NOTE: I believe the sort order of the Order Line column is strange, but unrelated to this patch. The search area functions (filtering, paging, page size, etc.) worked fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 00:41:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 22:41:58 +0000 Subject: [Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 00:42:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 22:42:01 +0000 Subject: [Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18535|0 |1 is obsolete| | --- Comment #9 from Robin Sheat --- Created attachment 27380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27380&action=edit Bug 9165 - Prevent LDAP passwords being stored locally This adds a configuration option to LDAP that prevents it from storing user's passwords in the local database. This is useful when users of hosted Koha wish to prevent any form of offsite password storage for security reasons. Notes: * if the option is not included in the koha-conf.xml file, then the current default behaviour of saving the password locally is retained. * this has no impact on passwords that are already in the database. They will not be erased. To use: * edit the koha-conf.xml for a system that uses LDAP for authentication. * in the configuration, add: 0 * feel a greater sense of security. To test: 1) have a Koha system that authenticates using LDAP. 2) note that when a user logs in, their password is saved (hashed) in the database. 2.5) it is important to note that, for whatever reason, a user's password is not stored on a login where their account is created, only when they log in after being created. Thus perhaps log in and log out a couple of times to be sure. 3) add the 0 option to the section of koha-conf.xml. 4) login with a new user (or erase the password from the database for an existing user) and note that the password field is not populated. 5) log out and log back in just to be sure, check the password field again. Sponsored-By: National Institute of Water and Atmospheric Research (NIWA) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 00:55:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 22:55:00 +0000 Subject: [Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 01:00:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Apr 2014 23:00:27 +0000 Subject: [Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782 --- Comment #5 from Robin Sheat --- This seems perfectly fine and sensible (and documented) to me. I won't mark it as passed-QA given Chris signed off on it, but it's pretty straight forward and doesn't interfere with any other part of the system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 04:32:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 02:32:49 +0000 Subject: [Koha-bugs] [Bug 9749] Placeholders in koha-conf.xml generated by the Debian packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9749 --- Comment #3 from Robin Sheat --- (In reply to Mason James from comment #2) > i have experienced this bug too > > the glitchy config files have caused non-working zebras for me > > i think the fix is to patch koha-create to correctly substitute the missing > placeholders, rather than remove them Are you sure? You'll have to point out what placeholders weren't filled in that were needed, as I just checked one of my systems and all the placeholders were in commented out sections of koha-conf.xml. Many of them can't be generated by koha-create, as we can't know what they'll be. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 05:10:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 03:10:17 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 05:49:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 03:49:36 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 05:59:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 03:59:25 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #12 from Robin Sheat --- (In reply to Jared Camins-Esakov from comment #10) > Would using this syntax (borrowed from bug 7952) fix the problem? > > + open(my $fh, '<', $filename) > + print <$fh>; > + close $fh; If we're dealing with big binary files, this may consume a lot of memory before it sees a newline. Also, we possibly run the risk of changing newlines if we're ever different (or more lenient) from what we accept to what we output. Needless to say, this is bad for binary files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 06:09:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 04:09:27 +0000 Subject: [Koha-bugs] [Bug 9941] with Plack, Web installer should not die with stacktrace when database does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9941 --- Comment #13 from Robin Sheat --- I did some experimenting with this, and it seems pretty difficult, given that we do so much in BEGIN and I don't see a nice way we can return a meaningful exception from it. If we die() we get a stacktrace. The long-term best way is to move things more toward lazy initialisation, but in most cases that ship has long sailed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 06:27:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 04:27:32 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #27 from M. Tompsett --- ARG! This no longer applies. And because the t/db_dependent/Biblio.t file has gotten more complicated that a straight list of tests, I'm not sure how to rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 06:43:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 04:43:10 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #28 from M. Tompsett --- Rebase need caused by bug 11912. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 06:58:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 04:58:29 +0000 Subject: [Koha-bugs] [Bug 12121] New: Caching of version syspref causes web installer to be like groundhog day Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12121 Bug ID: 12121 Summary: Caching of version syspref causes web installer to be like groundhog day Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org You update, and then update again, then update again... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 06:59:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 04:59:58 +0000 Subject: [Koha-bugs] [Bug 12121] Caching of version syspref causes web installer to be like groundhog day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12121 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:13:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:13:41 +0000 Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26949|0 |1 is obsolete| | --- Comment #6 from Robin Sheat --- Created attachment 27381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27381&action=edit Bug 12041 - improve Koha::Cache This makes Koha::Cache behave better by default. It will use memcached if available to do shared caching, if that's not available it will fall back to in-memory caching. It also allows for a singleton accessor to allow a single cache to be shared within a process. * Added tests to confirm UTF8-cleanness. * Added minor fixups to stop warnings. Test plan: * The t/Cache.t file runs successfully with and without the MEMCACHED_SERVERS envvar set (and memcached running in the environment.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:17:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:17:39 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26717|0 |1 is obsolete| | --- Comment #12 from Robin Sheat --- Created attachment 27382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27382&action=edit Bug 11998 - add test case, fix issue found Adds a test case with improved coverage of the caching functionality. Fixes a bug that was uncovered by writing the test case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:18:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:18:13 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26910|0 |1 is obsolete| | --- Comment #15 from Robin Sheat --- Created attachment 27383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27383&action=edit Bug 9967 - Cache authorised value requests properly Authorised values are now cached using the proper Koha::Cache mechanism, rather than a simple internal cache. Memoize has been removed because it didn't really work like we needed it to. Test plan: * running a persistent environment: * load the edit item screen * refresh several times to ensure any process-based caches are filled * add a new LOC authorised value as fast as possible (prepare it on another tab.) * refresh the edit item page * note that the new LOC value may or may not be showing in the "shelving location" * if more than 5 seconds have passed since saving it, it must now show up. * refresh a few times to ensure that it's showing on all processes. Note: * This patch depends on the caching changes of 9967. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:35:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:35:59 +0000 Subject: [Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:36:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:36:02 +0000 Subject: [Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27370|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 27384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27384&action=edit [PASSED QA] Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders This patch MARC21 modifies value builders 006 and 008 to make confirm popup translatable To test: 1) Update po files for your preferred language, xx-YY cd misc/translator; perl translate update xx-YY 2) Check that confirm string is NOT present egrep -B3 "Show values for|material type\?" po/xx-YY*po 3) Apply the patch 4) Repeat 1) 5) Repeat 2), now the strings are present Also check that english or translated popup is right Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:37:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:37:43 +0000 Subject: [Koha-bugs] [Bug 12121] Caching of version syspref causes web installer to be like groundhog day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12121 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Robin Sheat --- Oh, never mind. I'd forgotten to apply my caching patches which fix this as a side effect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:41:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:41:02 +0000 Subject: [Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:41:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:41:04 +0000 Subject: [Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27371|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 27385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27385&action=edit [PASSED QA] Bug 11639 - Untranslatable strings in 007 builder This patch modifies marc21_field_007.tt to make some missing strings translatable To test: 1) Using your preferred language, xx-YY, updatepo files cd misc/translator perl translate update xx-YY 2) Check that missing strings are NOT present egrep -i "exact bit depth|pad with zero|use up to 6" po/xx-YY-i-staff-t-prog-v-3006000.po 3) Apply the patch 4) repeat 1) 5) Repeat 2), check that missing strings are present Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Template change, works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:46:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:46:00 +0000 Subject: [Koha-bugs] [Bug 12117] Remove unused image myshadow.png from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12117 --- Comment #3 from Katrin Fischer --- Created attachment 27386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27386&action=edit [PASSED QA] Bug 12117 - Remove unused image myshadow.png from the staff client myshadow.png was used by a jQuery plugin which has long been removed. This patch removes it. To test, search the Koha source for references to myshadow.png. There should be none. Followed test plan, patch removed file as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:46:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:46:30 +0000 Subject: [Koha-bugs] [Bug 12117] Remove unused image myshadow.png from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:46:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:46:32 +0000 Subject: [Koha-bugs] [Bug 12117] Remove unused image myshadow.png from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27359|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:52:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:52:34 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #14 from Robin Sheat --- I can somewhat reproduce this: My method: 1) Tools -> Stage MARC records for import - staged a small marc file with one entry. 2) Fill out the boxes (left everything as default, except for giving it a comment.) 3) Stage for import - everything seems to be fine 4) Follow the Manage staged records link 5) Note that my record is there. I did see: seek() on closed filehandle _GEN_44 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 32. Can't seek stdout handle: Bad file descriptor at /usr/share/perl5/Plack/App/WrapCGI.pm line 87. at /usr/share/perl/5.18/Carp.pm line 100 in the logs, but no error apparent in the browser. I assume that something (the progress updater?) is closing the output handle when plack/starman doesn't expect it. We have seen the parseerror before, long ago. It was something to do with invalid JSON appearing in the upload, which would be consistent with this. I also see: 192.168.56.1 - - [22/Apr/2014:17:47:41 +1200] "POST /cgi-bin/koha/tools/stage-marc-import.pl HTTP/1.1" 500 5728 "http://test-intra.debmaker32/cgi-bin/koha/tools/stage-marc-import.pl" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0" that is, a 500 error. So there is something going wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 07:57:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 05:57:21 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz --- Comment #15 from Robin Sheat --- Tried it with a larger marc file, and some things really went wrong. It went straight to 100%, then to 0%, now it's sitting there doing nothing. There is: DBD::mysql::st fetchrow_array failed: fetch() without execute() at /usr/share/perl5/CGI/Session/Driver/DBI.pm line 74. at /mnt/catalyst/koha/tools/upload-file.pl line 85 and DBD::mysql::st execute failed: MySQL server has gone away at /usr/share/perl5/CGI/Session/Driver/DBI.pm line 72. DBD::mysql::st execute failed: MySQL server has gone away at /usr/share/perl5/CGI/Session/Driver/DBI.pm line 72. along with some other 500 errors in there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 09:16:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 07:16:43 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #21 from Jonathan Druart --- This needs others QA points of view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 09:21:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 07:21:03 +0000 Subject: [Koha-bugs] [Bug 12099] process_message_queue.pl tells it sends print mails even if it doesn't. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12099 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |olli-antti.kivilahti at jns.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 09:21:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 07:21:25 +0000 Subject: [Koha-bugs] [Bug 12099] process_message_queue.pl tells it sends print mails even if it doesn't. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12099 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 09:21:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 07:21:38 +0000 Subject: [Koha-bugs] [Bug 12099] process_message_queue.pl tells it sends print mails even if it doesn't. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12099 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|olli-antti.kivilahti at jns.fi |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 09:50:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 07:50:50 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #2 from paxed --- Small nitpick: "Change order vendor note vendor note" - note the doubled "vendor note" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 12:26:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 10:26:25 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27220|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 27387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27387&action=edit [PASSED QA] Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match Signed-off-by: Tom McMurdo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 12:26:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 10:26:33 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27221|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 27388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27388&action=edit [PASSED QA] Bug 10500: Followup for UNIMARC In UNIMARC, the isbn index is ISBN. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 12:29:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 10:29:38 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27222|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 27389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27389&action=edit [PASSED QA] Bug 10500 [QA Followup] - Add checks for empty isbn Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 12:30:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 10:30:31 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #36 from Martin Renvoize --- I'm happy that the followup fixes the problem. We're still passing qa script tests and the code looks good to me. Re-passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 12:52:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 10:52:35 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #31 from Bernardo Gonzalez Kriegel --- Question: On opac-sendbasket.pl you send if (C4::Context->preference('OPACBaseURL')){ $template2->param( OPACBaseURL => C4::Context->preference('OPACBaseURL') ); } and in virtualshelves/sendshelf.tt [% Koha.Preference( 'OPACProtocol' ) %][% OPACBaseURL %]/cgi-bin/koha/opac... Why not [% Koha.Preference('OPACProtocol') %][% Koha.Preference('OPACBaseURL') %] ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:11:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:11:24 +0000 Subject: [Koha-bugs] [Bug 12094] jQueryUI upgrade broke default tab selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:11:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:11:26 +0000 Subject: [Koha-bugs] [Bug 12094] jQueryUI upgrade broke default tab selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27351|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 27390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27390&action=edit Bug 12094 - jQueryUI upgrade broke default tab selection The recent upgrade to jQueryUI didn't take into account the new method for forcing selection of a tab by adding a class to the tab markup. This patch corrects this by updating the class name. This patch also updates one instance where it was necessary to switch to the new function for selecting a tab by ID, introduced by Bug 12075. To test, view the following pages: - Perform a catalog search in the staff client. On the search results page the "Search the catalog" tab should be selected. - In Acquisitions, view the basket groups page for a vendor which has open and closed basket groups (/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=X). Append "&listclosed=1" to the URL. The "Closed" tab should be selected. - In Administration -> Authorized values, modify an authorized value for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Administration -> Item types, modify an itemtype for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Cataloging, open an existing record and select any tab besides the first one. Choose "Save and continue editing" from the Save menu. When the page reloads you should be returned to the tab you selected before. - In Suggestions, markup for selected the tab has been removed because it didn't appear to be performing any function. The first tab is selected by default. The template doesn't need to explicitly add a class to make it so. - In Tools -> CSV profiles, choose an existing profile for editing. When the page loads the "Edit existing profile" tab should be selected. Signed-off-by: Mark Tompsett NOTE: Unable to duplicate Cataloging step issue, but there is no visible regression with the patch. The second part of the addbiblio.tt portion of the patch is clearly correct, because it is the same type of change as made in the other sections. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:11:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:11:46 +0000 Subject: [Koha-bugs] [Bug 12094] jQueryUI upgrade broke default tab selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |11570 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:11:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:11:46 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12094 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:18:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:18:51 +0000 Subject: [Koha-bugs] [Bug 12122] New: TransferSlip should accept both itemnumber and barcode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Bug ID: 12122 Summary: TransferSlip should accept both itemnumber and barcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: benjamin.rokseth at kul.oslo.kommune.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com C4::Circulation::TransferSlip uses Getitem which takes either itemnumber or barcode. It should therefore accept both itemnumber and barcode as input. This would make it easy to generate print slip from barcode instead of doing item lookup (GetItemnumberfromBarcode) first. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:23:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:23:29 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27124|0 |1 is obsolete| | --- Comment #70 from Kyle M Hall --- Created attachment 27391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27391&action=edit Bug 9593 Prices not imported correctly from a staged file Initial bug : When there's a round price with no decimals after it, or when the symbol is after the digits, the price is not captured by regular expression in MungeMarcPrice routine and the variable is not initialized. Enhancement : The MungeMarcPrice routine had been widely modified. It 's still possible to priority pick the active currency but unlike the previous mechanism that worked only for prices preceded by the currency sign, it's now valid wherever the symbol is situated. As symbol you may enter a pure currency sign as well as a string including it like '$US'. Moreover, an 'isocode' column had been added in currency table (editable in the pro interface from Administration/Currencies and exchange rates). So the active currency can be picked either through its symbol or through its iso code. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:23:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:23:38 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #71 from Kyle M Hall --- Created attachment 27392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27392&action=edit Bug 9593 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:38:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:38:41 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #40 from Jonathan Druart --- (In reply to Katrin Fischer from comment #39) > BUT: As Jonathan noted, currently diacritics in the bsort1, bsort2 pull > downs in the member entry form will be broken. This is because of a > dependency on bug 11944, as I understand it. A patch is coming. > I think this is probably ready to go in now, if we 'fixed' the encoding, > while bug 11944 will take a bit longer. The idea of bug 11944 is to have several persons testing/contributing in order to quickly have a working patch set. Then it would be better if it doesn't take a long time to be tested/pushed > One other idea: should it be possible to add an id to the pull down for > better customization? I see that you can set a class, but sometimes you > might want to do both - a class for several elements and an id for the > individual. The id attribute is already generated, it is the "name" parameter. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:39:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:39:00 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #41 from Jonathan Druart --- Created attachment 27396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27396&action=edit Bug 766: Fix encoding issues [ REVERT ME on pushing bug 11944 ] This patch deals with the current master code. It should be removed when patches for bug 11944 will be pushed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:48:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:48:28 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 27397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27397&action=edit Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update por file, new strings 'Koha -- Circulation: Transfers' and 'Reserve not found' must be present -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:49:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:49:42 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 13:54:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 11:54:36 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 14:20:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 12:20:25 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #1 from Benjamin Rokseth --- Created attachment 27398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27398&action=edit small patch to allow barcode as input in TransferSlip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 14:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 12:20:58 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Benjamin Rokseth --- Added small patch to allow barcode as input in TransferSlip routine, mostly to allow generating transfer slips where only barcode is present (aka. javascript). Test plan: 1) find book with and 2) generate transferslips with both: transfer-slip.pl?transferitem=3967925&branchcode=MPL&op=slip transfer-slip.pl?barcode=&branchcode=MPL&op=slip and verify that the generated slips match. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 14:21:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 12:21:48 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #42 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #41) > Created attachment 27396 [details] [review] > Bug 766: Fix encoding issues [ REVERT ME on pushing bug 11944 ] > > This patch deals with the current master code. It should be removed when > patches for bug 11944 will be pushed. Well, how can be tested? I don't have problems with Bsort1/2 utf8 descriptions, with/without patch. Can/Can't have utf8 values (arabic/chinese) with/without patch. They look good, can be assigned and saved, but on edition they are not selected Or perhaps I do not understand what to test :( -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 14:24:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 12:24:05 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #43 from Katrin Fischer --- Hi Bernardo, thx for testing :) I had problems with a value ??? I think. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 14:58:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 12:58:19 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- This patch really ought to update the text to use the correct term: 'hold' instead of 'reserve.' While you're at it, the page title ought to conform to other pages: Koha › Circulation › Transfers Not a big deal, but consistency is good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:04:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:04:36 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27398|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 27399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27399&action=edit [SIGNED-OFF] Bug 12122: TransferSlip should accept both itemnumber and barcode Added small patch to allow barcode as input in TransferSlip routine, mostly to allow generating transfer slips where only barcode is present (aka. javascript). Test plan: 1) find book with and 2) generate transferslips with both: transfer-slip.pl?transferitem=3967925&branchcode=MPL&op=slip transfer-slip.pl?barcode=&branchcode=MPL&op=slip and verify that the generated slips match. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:04:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:04:34 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:13:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:13:09 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #44 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #43) > Hi Bernardo, thx for testing :) I had problems with a value ??? I think. If value has diacritics, value="??", and description "??", I see ?? with value="AA", description "??", I see "??". Can't understand, we show labels in both cases (moremember.pl?borrowernumber=NNN) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:16:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:16:20 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Owen Leonard --- This patch doesn't apply with git-bz. I'm not sure if it's a simple conflict or perhaps the patches are out of order? fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:18:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:18:21 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #45 from Katrin Fischer --- Hm, let me think. I had ??? in the description of my bsort2 value and it did show up correctly on the detail page, but the pull down on the edit form was not correct. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:20:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:20:34 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #46 from Katrin Fischer --- And the problem shoudl only appear without the last patch Jonathan attached. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:39:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:39:48 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Owen Leonard --- (In reply to Bernardo Gonzalez Kriegel from comment #38) > > But when viewing a basket you press Modify (ej. to alter quantity), > [neworderempty.pl?ordernumber=NN&booksellerid=MM&basketno=LL] > that information does not shows. I see this too: Specifically, publication place (from 260a) and "Collection title," actually series name, from 490a are not shown. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:40:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:40:33 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27396|0 |1 is obsolete| | --- Comment #47 from Bernardo Gonzalez Kriegel --- Created attachment 27400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27400&action=edit [SIGNED-OFF] Bug 766: Fix encoding issues [ REVERT ME on pushing bug 11944 ] This patch deals with the current master code. It should be removed when patches for bug 11944 will be pushed. Signed-off-by: Bernardo Gonzalez Kriegel No side effects. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:40:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:40:38 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|henridamien.laurent at biblibr | |e.com | Version|3.14 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:40:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:40:56 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:44:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:44:53 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #16 from Colin Campbell --- A minor issue with the patch as stands. It shouldnt unnecessarily import Koha::DateUtils into ILS/Transaction/CheckIn.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:54:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:54:46 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27397|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 27401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27401&action=edit Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update PO file, new strings msgid "%s %s%s%sNo hold found%s %s %s " msgid "%s%s%sNo hold found%s " msgid "Koha › Circulation › Transfers" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:55:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:55:12 +0000 Subject: [Koha-bugs] [Bug 12123] New: HTML notices can break the notice viewer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Bug ID: 12123 Summary: HTML notices can break the notice viewer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:57:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:57:50 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:57:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:57:51 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #1 from Kyle M Hall --- Created attachment 27402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27402&action=edit Bug 12123 - HTML notices can break the notice viewer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:58:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:58:33 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | --- Comment #2 from Kyle M Hall --- I do not consider this patch to be an optimal solution, but it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:59:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:59:34 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Bernardo Gonzalez Kriegel --- (In reply to Owen Leonard from comment #2) > Not a big deal, but consistency is good. Of course :) New patch to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 15:59:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 13:59:39 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27402|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 27403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27403&action=edit Bug 12123 - HTML notices can break the notice viewer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 16:02:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 14:02:26 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #38 from Colin Campbell --- This changes the api of a routine used in many places so the change should be clearer. The return_date is an optional parameter but this is not indicated in the documentation of the subroutine, a comment or even explicitly in the code, being handled as a side effect of the date routines. Instead of replacing my $today = DateTime->now( time_zone => C4::Context->tz() ); by my $today = dt_from_string( $return_date, 'iso' ); can I suggest that: my $today; if ($return_date) { $today = dt_from_string( $return_date, 'iso' ); } else { $today = DateTime->now( time_zone => C4::Context->tz() ); } makes the logic a bit clearer without forcing the reader to inspect the DateUtils code to see that having a return_date is not required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 16:18:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 14:18:05 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #18 from Jonathan Druart --- Kyle, Thanks for testing. With this patch, inactive funds are hidden by default. Which does not make sense if a budget is chosen. I will provide a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 16:19:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 14:19:02 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 16:19:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 14:19:05 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #19 from Jonathan Druart --- Created attachment 27404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27404&action=edit Bug 11578: Hide filters if a budget (budgetperiod) is chosen If a budget_period_id is given, the filters should not be displayed. Moreover, it does not make sense to display the links for displaying/hiding inactive budgets in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 16:28:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 14:28:08 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 16:31:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 14:31:03 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #30 from Tom?s Cohen Arazi --- Could you guys please test with the latest Memoize/Memcache.pm from my repo: https://gitorious.org/memoize-memcached/memoize-memcached/source/master: Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 16:53:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 14:53:50 +0000 Subject: [Koha-bugs] [Bug 12094] jQueryUI upgrade broke default tab selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 16:54:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 14:54:40 +0000 Subject: [Koha-bugs] [Bug 12117] Remove unused image myshadow.png from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12117 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 16:57:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 14:57:03 +0000 Subject: [Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 16:58:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 14:58:21 +0000 Subject: [Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:07:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:07:01 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 --- Comment #27 from Jonathan Druart --- Created attachment 27405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27405&action=edit Bug 5771: Set the directory path to /tmp The report filename should be written into /tmp -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:07:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:07:50 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 --- Comment #28 from Jonathan Druart --- Galen, Does something like the last patch could be acceptable? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:14:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:14:44 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #130 from Katrin Fischer --- Hi Marcel - do you plan to continue on the other patches? I am not sure in which state that is and if you already started. Could you give a quick update? Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:19:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:19:47 +0000 Subject: [Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27263|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 27406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27406&action=edit Bug 12086 - Hold priorities incorrect, when waiting status was reversed 1) Test record has 1 single item, checked out to patron X 2) Place 3 holds for patrons A, B and C, all title level hold this time A, B, C, item branches and staff branch are the same. 3) Return item, confirm hold 4) Confirm item is now waiting for patron A Priorities are: A = Waiting, B = 1, C = 2 5) Open patron account of user B, checkout book Koha asks: Item X has been waiting for patron A... Revert waiting status Confirm. 6) Check priorities: Hold list shows: A = 1, C = 1 Database says: A = 1, C = 3 7) Apply this patch 8) Repeat steps 1-6 9) Note the priorities are correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:22:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:22:27 +0000 Subject: [Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27406|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 27407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27407&action=edit Bug 12086 - Hold priorities incorrect, when waiting status was reversed 1) Test record has 1 single item, checked out to patron X 2) Place 3 holds for patrons A, B and C, all title level hold this time A, B, C, item branches and staff branch are the same. 3) Return item, confirm hold 4) Confirm item is now waiting for patron A Priorities are: A = Waiting, B = 1, C = 2 5) Open patron account of user B, checkout book Koha asks: Item X has been waiting for patron A... Revert waiting status Confirm. 6) Check priorities: Hold list shows: A = 1, C = 1 Database says: A = 1, C = 3 7) Apply this patch 8) Repeat steps 1-6 9) Note the priorities are correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:23:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:23:42 +0000 Subject: [Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 --- Comment #10 from Kyle M Hall --- (In reply to Katrin Fischer from comment #7) > /me whispers *regression test*? Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:41:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:41:38 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26950|0 |1 is obsolete| | --- Comment #220 from Jonathan Druart --- Created attachment 27408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27408&action=edit Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information ("Import All" and "Accounting details" areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the "Stage MARC records for import" tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the "planning values" too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the "Accounting details" area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price => listprice = 0 else => - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:41:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:41:45 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26951|0 |1 is obsolete| | --- Comment #221 from Jonathan Druart --- Created attachment 27409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27409&action=edit Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:41:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:41:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26952|0 |1 is obsolete| | --- Comment #222 from Jonathan Druart --- Created attachment 27410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27410&action=edit Bug 7180: Add UT for C4::Budgets::GetBudgetByCode Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:41:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:41:58 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26953|0 |1 is obsolete| | Attachment #26959|0 |1 is obsolete| | --- Comment #223 from Jonathan Druart --- Created attachment 27411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27411&action=edit Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:42:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:42:04 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26954|0 |1 is obsolete| | --- Comment #224 from Jonathan Druart --- Created attachment 27412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27412&action=edit Bug 7180: The default quantity is 1 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:42:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:42:10 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26955|0 |1 is obsolete| | --- Comment #225 from Jonathan Druart --- Created attachment 27413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27413&action=edit Bug 7180: Follow-up fixing minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:42:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:42:17 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26956|0 |1 is obsolete| | --- Comment #226 from Jonathan Druart --- Created attachment 27414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27414&action=edit Bug 7180: Change syspref description - the blank line is now useless - add an example for the syspref value Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:42:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:42:22 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26957|0 |1 is obsolete| | --- Comment #227 from Jonathan Druart --- Created attachment 27415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27415&action=edit Bug 7180: Adapt neworderempty code (js function moved). The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link some av to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:42:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:42:28 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26958|0 |1 is obsolete| | --- Comment #228 from Jonathan Druart --- Created attachment 27416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27416&action=edit Bug 7180: FIX License version Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:42:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:42:34 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #229 from Jonathan Druart --- Created attachment 27417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27417&action=edit Bug 7180: QA followup - fix unit tests (use a transaction). - add 3 tabs on the page in order to be more understandable. - fix a warn in logs Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:42:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:42:39 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26960|0 |1 is obsolete| | --- Comment #230 from Jonathan Druart --- Created attachment 27418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27418&action=edit Bug 7180 - QA Followup - Correct minor language issues Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:42:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:42:45 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26961|0 |1 is obsolete| | --- Comment #231 from Jonathan Druart --- Created attachment 27419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27419&action=edit Bug 7180: Restore the "Add order" link Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:42:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:42:51 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26962|0 |1 is obsolete| | --- Comment #232 from Jonathan Druart --- Created attachment 27420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27420&action=edit Bug 7180: Remove useless rrp variable Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:42:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:42:57 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26963|0 |1 is obsolete| | --- Comment #233 from Jonathan Druart --- Created attachment 27421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27421&action=edit Bug 7180: FIX: discount was divided by 100 twice. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:43:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:43:03 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26964|0 |1 is obsolete| | --- Comment #234 from Jonathan Druart --- Created attachment 27422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27422&action=edit Bug 7180: fetch_sort_dropbox.pl is not in use anymore Test plan: git grep fetch_sort_dropbox should return no result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:43:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:43:09 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27136|0 |1 is obsolete| | --- Comment #235 from Jonathan Druart --- Created attachment 27423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27423&action=edit Bug 7180: QA followup 2 This patch takes into account all QA failures raised in comment 207. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:43:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:43:14 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27160|0 |1 is obsolete| | --- Comment #236 from Jonathan Druart --- Created attachment 27424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27424&action=edit Bug 7180: QA followup 3 1/ showmarc.pl takes the importid for staged files. 2/ small note to indicate that the vendor's discount will be used if no discount is filled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:43:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:43:58 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #237 from Jonathan Druart --- (In reply to Katrin Fischer from comment #219) > Hi Jonathan, we are almost there, only 2 problems found + testing the > internal note/vendor note after rebase. If you can also rebase bug 10875 I > will include it in my next test. All patches rebased against master. > Terminology: Planning value 1 and 2 should be Statistic 1 and 2. > BUG (trivial) Fixed for picking individual records, but still appears on > the default accounting details tab. QA followup 2 amended. > * BUG (normal): On the default accounting details page the refreshing > doesn't work. > For individual records it works alright, also on the neworderempty.pl > page. It works for me. Could you retest with last patches please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:44:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:44:09 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:47:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:47:49 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21640|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 27425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27425&action=edit Bug 10875: Add order from a staged file should not display inactive funds When adding an order from a staged file, a link "show all funds" is now added on the top of the page. All inactive funds are hidden by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:48:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:48:10 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:50:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:50:58 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #32 from M. Tompsett --- (In reply to Bernardo Gonzalez Kriegel from comment #31) > Question: > > On opac-sendbasket.pl you send > > if (C4::Context->preference('OPACBaseURL')){ > $template2->param( OPACBaseURL => C4::Context->preference('OPACBaseURL') ); > } > > and in virtualshelves/sendshelf.tt > > [% Koha.Preference( 'OPACProtocol' ) %][% OPACBaseURL %]/cgi-bin/koha/opac... > > Why not > > [% Koha.Preference('OPACProtocol') %][% Koha.Preference('OPACBaseURL') %] > > ? Because the include file requires OPACBaseURL defined for the opac ones: $ grep -l -i opacbaseurl `find . | grep en/.*inc$` ./koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc ./koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc ./koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc ./koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc ./koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc $ grep -i opacbaseurl ./koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc This would explode into a wider scale fix required (lots more testing!). That's beyond the scope of this bug. I believe the second one has potential merit, but my goal was to minimize impact without having to look for other areas affected. I have found the OPACBaseURL logic was added by bug 6957, but I haven't looked much further. Since I was leaving OPACBaseURL intact to minimize potential impact, accessing the Template variable is likely faster than the Preference call and it is shorter to type, I didn't change that. The goal of this bug is to add OpacProtocol. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:59:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:59:26 +0000 Subject: [Koha-bugs] [Bug 12105] Remove duplicated plugin jquery.dataTables.columnFilter.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 17:59:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 15:59:30 +0000 Subject: [Koha-bugs] [Bug 12105] Remove duplicated plugin jquery.dataTables.columnFilter.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27379|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 27426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27426&action=edit Bug 12105 - Remove duplicated plugin jquery.dataTables.columnFilter.js This patch removes a redundant copy of the DataTables plugin jquery.dataTables.columnFilter.js and corrects two templates. The path to the plugin has been modified in acqui/parcel.tt: - Go to Acquisitions and search for a vendor. - Open the detail page for that vendor. - Click the "Receive shipments" button. - Select an invoice to view. - In the table of titles, confirm that the column header search forms work to filter column data. In the template for the Staged MARC management page the plugin has been removed as it is unused. A couple of markup corrects have been made. Confirm that table sorting is unaffected by going to Administration -> Staged MARC management, clicking a staged MARC file, and viewing the table of items in that batch. There should be no more remaining instances of this path in the templates: [% themelang %]/lib/jquery/plugins/jquery.dataTables.columnFilter.js Signed-off-by: Mark Tompsett NOTE: I believe the sort order of the Order Line column is strange, but unrelated to this patch. The search area functions (filtering, paging, page size, etc.) worked fine. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:14:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:14:52 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #86 from Heather Braum --- > - renewal using checkboxes > > Concern: It's only possible to do one renewal at a time. > After renewing once the checkbox is gone and then you will have > to reload the page to bring the checkboxes back. I've been tracking this bug, as one of the libraries backing the development, and Kyle, I'm quite concerned by Katrin's comment above, and then your response below, "This is by design. I think in those rare cases reloading the page would be a fair resolution for this." Select renewal isn't rare at circulation desks. Asking a librarian to refresh a page for each select renewal -- especially when there's three or more select renewals, is not good practice. I haven't had a chance to see this development in action yet, so I'm basing my comments and concerns on the descriptions, but I would hate for the system to lose the multiple select renewal option. > - renewal override > > OK. If the item is on hold, the renewal will fail. I wonder if that's > always been the case, but it's behaviour pre-patches. Katrin, I can also confirm that this behavior has always been the case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:15:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:15:31 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #87 from Heather Braum --- And Katrin, thanks for your thorough testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:21:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:21:37 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:26:04 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:26:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:26:07 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 --- Comment #19 from Jonathan Druart --- Created attachment 27427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27427&action=edit Bug 9180: Use selectcol instead of selectrow The selectrow_* method only returns the *first* row of data! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:26:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:26:27 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 --- Comment #20 from Jonathan Druart --- (In reply to Katrin Fischer from comment #18) Oops, sorry Katrin, noob error. Fixed in a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:31:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:31:44 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- Please provide a proper commit message with a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:33:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:33:51 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #33 from Bernardo Gonzalez Kriegel --- Patch 2/3 has fixable conflicts Patch 3/3 no, needs rebasing -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:45:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:45:04 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #34 from M. Tompsett --- Bug 11248 triggered the need for a rebase. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:54:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:54:08 +0000 Subject: [Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 18:54:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 16:54:10 +0000 Subject: [Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27407|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 27428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27428&action=edit [SIGNED-OFF] Bug 12086 - Hold priorities incorrect, when waiting status was reversed 1) Test record has 1 single item, checked out to patron X 2) Place 3 holds for patrons A, B and C, all title level hold this time A, B, C, item branches and staff branch are the same. 3) Return item, confirm hold 4) Confirm item is now waiting for patron A Priorities are: A = Waiting, B = 1, C = 2 5) Open patron account of user B, checkout book Koha asks: Item X has been waiting for patron A... Revert waiting status Confirm. 6) Check priorities: Hold list shows: A = 1, C = 1 Database says: A = 1, C = 3 7) Apply this patch 8) Repeat steps 1-6 9) Note the priorities are correct Signed-off-by: Owen Leonard Test plan correctly predicts the error and the correction made by the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 19:31:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 17:31:34 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 19:31:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 17:31:36 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19117|0 |1 is obsolete| | --- Comment #59 from Kyle M Hall --- Created attachment 27429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27429&action=edit Bug 7710 - multiple holds per title Adds the ability to allow multiple holds on the same record for the same borrower. Adds new system preference MaxHoldsPerRecord, which controls how many holds one person can have on items for the same record. Test Plan: 1) Apply patch for Bug 9394 2) Apply this patch 3) Run updatedatabase.pl 4) Attempt to place 2 holds for the same patron on the same record, you should not be able to ( default is 1 per record ) 5) Set MaxHoldsPerRecord to 3 6) Attempt to place multiple holds for one patron on one record, you should be able to place 3 holds for one patron on a given record. A 4th hold should result in a message stating the patron has placed the max number of holds allowed on this record. Signed-off-by: Maxime Pelletier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 19:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 17:32:19 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #60 from Kyle M Hall --- Rebased the patch, but it's probably in need of a rewrite. I have not tested it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 19:46:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 17:46:58 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27401|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 27430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27430&action=edit [SIGNED-OFF] Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update PO file, new strings msgid "%s %s%s%sNo hold found%s %s %s " msgid "%s%s%sNo hold found%s " msgid "Koha › Circulation › Transfers" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 19:46:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 17:46:57 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 19:48:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 17:48:10 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25878|0 |1 is obsolete| | --- Comment #35 from M. Tompsett --- Created attachment 27431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27431&action=edit Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. Tested both together using steps similar to larger test plan. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 19:48:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 17:48:30 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25879|0 |1 is obsolete| | Attachment #27072|0 |1 is obsolete| | --- Comment #36 from M. Tompsett --- Created attachment 27432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27432&action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new system preference: PublicCatalogUsesSSL. To test: - Create a list - Send yourself the list from the staff interface - Verify that the links are http:// - Put some records into your cart - Send yourself the cart from the staff interface - Verify that the links are missing http(s):// in front of them - Apply patch - Run database update - Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use' - Resent both emails - Verfiy the catalog links are now both http:// links - Change system preference setting to 'uses' - Resent both emails - Verify the catalog links are now https:// links NOTE: My cart didn't have a 'In online catalog:' line on master. My list had http:// on master. System preference affected both cart and list sending. System preference necessary, because there is no way to determine http or https in the middle of an email. Signed-off-by: Mark Tompsett NOTE: The rebase removed sendshelf.tt, because bug 11248 removed the hardcoded http:// in the template file. That may have been a mistake, since nothing was added to the corresponding sendshelf.pl file. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 19:48:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 17:48:43 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #37 from M. Tompsett --- Created attachment 27433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27433&action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new OPAC system preference, OpacProtocol, in the Policy subsection. It defaults to "doesn't use" (http://), but can be changed to "uses" (https://). Both basket/sendbasket.pl and virtualshelves/sendshelf.pl were tweaked to always set OPACBaseURL. If OPACBaseURL is undef or not set, the URL is not given in the corresponding template files. opac/opac-sendshelf.pl was returned to previous state, because it affects doc-head-close.inc if OPACBaseURL is not passed. This should be fixed to use the OpacProtocol system preference in another bug fix. However, this is OPAC, not Staff, and outside of the bugs scope. Both basket/sendbasket.tt and virtualshelves/sendshelf.tt template files contain the suggested Koha.Preference logic recommended by Kyle in comment #21. TEST PLAN --------- 1) Back up your database 2) Drop your koha database and recreate it empty 3) In the mysql client: > SOURCE .../installer/data/mysql/sysprefs.sql; -- It should run without error. > SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 4) Restore your database 5) $ ./installer/data/mysql/updatedatabase.pl -- It should run the upgrade to insert OpacProtocol. 6) In the mysql client: > SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 7) Log into the staff client 8) Click 'Koha administration' 9) Click 'Global system preferences' 10) Click the 'OPAC' tab on the left side. 11) Scroll down to the Policy section, and find the OpacProtocol preference. -- It should have a value of "doesn't use" in the drop down. 12) Fill your cart with something(s). 13) Make sure you have a list filled with something(s). 14) Click 'Cart' in the top menu bar area. 15) Click 'Send', and send it to yourself. 16) Click 'Close window' 17) Click 'Hide window' 18) Click 'More' and click 'Lists' 19) Choose a list and 'Send list' to yourself. 20) Check your email -- both emails should have OPAC URLs which start with http:// 21) Change the OPAC system preference OpacProtocol to 'uses' (https://), log out and log in (to force refresh of cached system preferences), and repeat steps 14 through 19. 22) Check your email -- the two new emails should have OPAC URLS which start with https:// NOTE: Other URLs may be broken as well, this bug only fixes carts and lists sent from staff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 19:53:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 17:53:10 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:15:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:15:09 +0000 Subject: [Koha-bugs] [Bug 11905] when editing item, cursor is positioning in search box and not to item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11905 --- Comment #2 from Marjorie Barry-Vila --- (In reply to Nick Clemens from comment #1) > I am seeing the same thing in 3.12 and 3.14. > > I think the script on the page is the issue, setting the focus in search and > overriding the anchor, with JS disabled the page loads as expected. > > This bit seems to be it: > > Thanks Nick for explanation. Do you know a script js to remove focus? Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:24:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:24:34 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:24:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:24:37 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24990|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 27434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27434&action=edit [SIGNED-OFF] Bug 11665: An ability to place orders directly from hold ratios list This enhancement introduces a possibility to place orders from hold ratios list: - new option "Add order to basket" -> "From titles w/ highest hold ratios"; (user gets redirected from acqusition to "hold ratios" list in circulation) - "N to order" in "Items needed" column now becomes a link - when clicked, user gets redirected back to acquisition, directly to order form for a choosen title (suggested quantity "N to order" is being preserved) - in the "Items needed" column, there is an additional indication if there are any pending (not yet received) orders for a given title This solution is not exactly ideal.. most important drawback: to use it librarian needs both acquisition & circulation priviledges; if not having both - new options will not show / wouldn't be active. But it requires relatively small amount of changes in the code. To test: - apply patch, - test new functions (try to place some orders using an newly added option, examine resulting order records etc.) - check modified hold ratios list for possible problems (for user with only circulation priviledges, additional information regarding pending orders should be still visible, but not the link to order form) - ensure the two following existing options for adding orders to basket ("From an existing record", "From a new (empty) record") a still working properly. Signed-off-by: Owen Leonard Minor edit in signoff: Changed "w/" to "with" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:33:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:33:46 +0000 Subject: [Koha-bugs] [Bug 12124] New: Unable to search for patrons and check materials in and out Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12124 Bug ID: 12124 Summary: Unable to search for patrons and check materials in and out Change sponsored?: --- Product: Koha Version: 3.14 Hardware: PC OS: Windows Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: library at pacificoaks.edu QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When using the search bar to "search for patrons", once typing begins, Koha automatically highlights "Search Catalog." We are unable to pull up patrons or use the "Check In" function on the search bar. We have to look up the patron accounts manually through the patron list. When we try to check out materials within the patron account in the Check out Box it automatically jumps to the Catalog Search feature. Please advise as we cannot use the system to circulate at this time. Best, Kelsey Vukic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:34:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:34:22 +0000 Subject: [Koha-bugs] [Bug 12125] New: Unable to search for patrons and check materials in and out Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12125 Bug ID: 12125 Summary: Unable to search for patrons and check materials in and out Change sponsored?: --- Product: Koha Version: 3.14 Hardware: PC OS: Windows Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: library at pacificoaks.edu QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When using the search bar to "search for patrons", once typing begins, Koha automatically highlights "Search Catalog." We are unable to pull up patrons or use the "Check In" function on the search bar. We have to look up the patron accounts manually through the patron list. When we try to check out materials within the patron account in the Check out Box it automatically jumps to the Catalog Search feature. Please advise as we cannot use the system to circulate at this time. Best, Kelsey Vukic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:36:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:36:35 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #294 from Owen Leonard --- Auto-merging Koha/DateUtils.pm CONFLICT (content): Merge conflict in Koha/DateUtils.pm Failed to merge in the changes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:50:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:50:09 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27431|0 |1 is obsolete| | --- Comment #38 from Bernardo Gonzalez Kriegel --- Created attachment 27435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27435&action=edit [SIGNED-OFF] Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. Tested both together using steps similar to larger test plan. Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel Just add a sign. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:50:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:50:25 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27432|0 |1 is obsolete| | --- Comment #39 from Bernardo Gonzalez Kriegel --- Created attachment 27436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27436&action=edit [SIGNED-OFF] Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new system preference: PublicCatalogUsesSSL. To test: - Create a list - Send yourself the list from the staff interface - Verify that the links are http:// - Put some records into your cart - Send yourself the cart from the staff interface - Verify that the links are missing http(s):// in front of them - Apply patch - Run database update - Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use' - Resent both emails - Verfiy the catalog links are now both http:// links - Change system preference setting to 'uses' - Resent both emails - Verify the catalog links are now https:// links NOTE: My cart didn't have a 'In online catalog:' line on master. My list had http:// on master. System preference affected both cart and list sending. System preference necessary, because there is no way to determine http or https in the middle of an email. Signed-off-by: Mark Tompsett NOTE: The rebase removed sendshelf.tt, because bug 11248 removed the hardcoded http:// in the template file. That may have been a mistake, since nothing was added to the corresponding sendshelf.pl file. Signed-off-by: Bernardo Gonzalez Kriegel Add a sign -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:50:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:50:41 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27433|0 |1 is obsolete| | --- Comment #40 from Bernardo Gonzalez Kriegel --- Created attachment 27437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27437&action=edit [SIGNED-OFF] Bug 5010: (2) Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new OPAC system preference, OpacProtocol, in the Policy subsection. It defaults to "doesn't use" (http://), but can be changed to "uses" (https://). Both basket/sendbasket.pl and virtualshelves/sendshelf.pl were tweaked to always set OPACBaseURL. If OPACBaseURL is undef or not set, the URL is not given in the corresponding template files. opac/opac-sendshelf.pl was returned to previous state, because it affects doc-head-close.inc if OPACBaseURL is not passed. This should be fixed to use the OpacProtocol system preference in another bug fix. However, this is OPAC, not Staff, and outside of the bugs scope. Both basket/sendbasket.tt and virtualshelves/sendshelf.tt template files contain the suggested Koha.Preference logic recommended by Kyle in comment #21. TEST PLAN --------- 1) Back up your database 2) Drop your koha database and recreate it empty 3) In the mysql client: > SOURCE .../installer/data/mysql/sysprefs.sql; -- It should run without error. > SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 4) Restore your database 5) $ ./installer/data/mysql/updatedatabase.pl -- It should run the upgrade to insert OpacProtocol. 6) In the mysql client: > SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 7) Log into the staff client 8) Click 'Koha administration' 9) Click 'Global system preferences' 10) Click the 'OPAC' tab on the left side. 11) Scroll down to the Policy section, and find the OpacProtocol preference. -- It should have a value of "doesn't use" in the drop down. 12) Fill your cart with something(s). 13) Make sure you have a list filled with something(s). 14) Click 'Cart' in the top menu bar area. 15) Click 'Send', and send it to yourself. 16) Click 'Close window' 17) Click 'Hide window' 18) Click 'More' and click 'Lists' 19) Choose a list and 'Send list' to yourself. 20) Check your email -- both emails should have OPAC URLs which start with http:// 21) Change the OPAC system preference OpacProtocol to 'uses' (https://), log out and log in (to force refresh of cached system preferences), and repeat steps 14 through 19. 22) Check your email -- the two new emails should have OPAC URLS which start with https:// NOTE: Other URLs may be broken as well, this bug only fixes carts and lists sent from staff. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, shelf and cart. No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:51:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:51:14 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 20:53:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 18:53:41 +0000 Subject: [Koha-bugs] [Bug 12124] Unable to search for patrons and check materials in and out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12124 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- If you are working with the default English templates your users need to clear their browser's cache. If you're working with a set of translated templates these templates should be updated and browser cache's cleared. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 21:06:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 19:06:20 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Owen Leonard --- Sorry, this no longer cleanly applies on top of Bug 10807. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 21:17:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 19:17:54 +0000 Subject: [Koha-bugs] [Bug 12124] Unable to search for patrons and check materials in and out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12124 Kelsey Vukic changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |FIXED --- Comment #2 from Kelsey Vukic --- Thank you. Clearing the Cache seems to have done the trick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 21:41:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 19:41:02 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Small conflict on t/db_dependent/AuthoritiesMarc.t, but problem is that tests fail prove -v t/db_dependent/AuthoritiesMarc.t t/db_dependent/AuthoritiesMarc.t .. 1..15 ok 1 - use C4::AuthoritiesMarc; "my" variable $dbh masks earlier declaration in same scope at t/db_dependent/AuthoritiesMarc.t line 196. ok 2 - Built linked authtrees hierarchy string ok 3 - Generated hierarchy data structure for linked hierarchy ok 4 - Built unlinked authtrees hierarchy string ok 5 - Generated hierarchy data structure for unlinked hierarchy ok 6 - test BuildSummary for MARC21 ok 7 - BuildSummary does not generate warning if main heading subfield not present ok 8 - test BuildSummary for UNIMARC Can't call method "subfield" on an undefined value at /home/bgkriegel/kohaclone/C4/AuthoritiesMarc.pm line 1476. # Looks like you planned 15 tests but ran 8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 22:55:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 20:55:15 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #88 from Katrin Fischer --- Hi Heather, select renewal still works - my description was not very good there :) You can only renew each item once - then you have to refresh the page, if you want to do a second renewal on the same item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 22 22:58:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 20:58:56 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #89 from Heather Braum --- Katrin, thank you for the clarification. That helps a lot and it's no longer an issue! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 00:14:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 22:14:42 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27275|0 |1 is obsolete| | --- Comment #49 from Jesse Weaver --- Created attachment 27438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27438&action=edit Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC This adds a new page to the OPAC that can search several Z39.50 targets using Pazpar2. Test plan: 1) Apply patches. 2) Update database. 3) Add one or more Z39.50 targets, using the Administration -> External targets screen. Note that not all targets support keyword search, but here are some that do: * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8 * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8 4) Perform a search on the OPAC, check to see if the "external targets" notice pops up at the top. 5) Click on the results link near that message. 6) This should bring back results from all enabled targets, all of which should be clickable to bring up a detailed view of the record. (This version incorporates previous QA followups and some fixes for translation and per-branch-limiting. Rebased again.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 00:15:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 22:15:20 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27276|0 |1 is obsolete| | --- Comment #50 from Jesse Weaver --- Created attachment 27439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27439&action=edit Bug 10486 followup - add tables to kohastructure.sql (Rebased again.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 00:15:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 22:15:48 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #51 from Jesse Weaver --- Created attachment 27440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27440&action=edit Bug 10486 - QA followup: fix several display issues and rebase errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 00:22:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Apr 2014 22:22:22 +0000 Subject: [Koha-bugs] [Bug 12126] New: SIP authentication bypassed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12126 Bug ID: 12126 Summary: SIP authentication bypassed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com SIP Authentication will allow transactions even if credentials are incorrect, as long as someone has authenticated correctly on the server, even if it is from another machine! Steps to reproduce: 1 - Authenticate from machine A with good credentials. Make a transaction. 2 - Use bad credentials on machine B. Make a transaction. For example, check something out. The transaction will appear in Koha as though it were checked out from the library credentials machine A was using. 3 - Change the credentials on machine A to a sip user for another library. Make a transaction. 4 - Using the same or other bad credentials on machine B, check something out. Koha will show item checked out from the library credentials machine A used last. When good credentials are used, SIP transactions work as expected. However, when bad credentials are used, whether it is username, password, or even port, Koha fails over to the last good credentials used. As long as you are pointing to the server, you can complete a transaction. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 03:32:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 01:32:21 +0000 Subject: [Koha-bugs] [Bug 11905] when editing item, cursor is positioning in search box and not to item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11905 --- Comment #3 from Nick Clemens --- (In reply to Marjorie Barry-Vila from comment #2) > (In reply to Nick Clemens from comment #1) > > Thanks Nick for explanation. > Do you know a script js to remove focus? > > Marjorie >From what I see the intranetusersjs loads before the script on the page, so you have to execute on window load to be able to steal focus. Below should work $(window).load(function (){ $('[id^="tag_952_subfield_0_"]').focus(); }); I think the bigger issue though is that cataloging-search.inc is set to take focus on every page where present. The link created when you click to edit an item has an anchor at the end and I am guessing the intention was, at one point, to set the focus to the edititem id once an item was being edited. I do think that is the more useful fonctionality Bug 11325 seems to be centered around the same issue with focus on the search box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 04:16:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 02:16:22 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #10 from Nick Clemens --- As a regular cataloger I have always avoided cataloging search since, in the versions we have used, ISBNs did not normalize and I couldn't use the search commands (ti:, au: etc) I have also encountered sorting issues like finding exact title matches far down or on later pages. I think most catalogers in our consortia do use the 'cataloging' search, but I suspect that is mostly because of the name and that is how they were trained. I would be very happy to see reservoir search as a tab option in the header with focus on the 'search the catalog tab' Just my two cents -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 04:48:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 02:48:17 +0000 Subject: [Koha-bugs] [Bug 11883] News Editor Changing Koha URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11883 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |liz at catalyst.net.nz Resolution|--- |DUPLICATE --- Comment #2 from Liz Rea --- *** This bug has been marked as a duplicate of bug 12032 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 04:48:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 02:48:17 +0000 Subject: [Koha-bugs] [Bug 12032] TinyMCE rewrites urls in a very annoying and unexpected way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12032 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #5 from Liz Rea --- *** Bug 11883 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 05:17:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 03:17:29 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #16 from Robin Sheat --- Tried it again, I think something else happened last time that caused the database connection to go away. This time I got an error during the stage process, with: fork failed while attempting to run /cgi-bin/koha/tools/stage-marc-import.pl as a background job at /mnt/catalyst/koha/tools/stage-marc-import.pl line 125, chunk 139245. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:09:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:09:12 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #48 from Katrin Fischer --- Created attachment 27441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27441&action=edit Without last patch to fix encoding -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:09:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:09:30 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #49 from Katrin Fischer --- Created attachment 27442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27442&action=edit With last patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:15:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:15:43 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #17 from Robin Sheat --- OK, while I haven't nailed this down exactly, I think I have some hints that there's a race condition happening. I also get plain weird things like: DBD::mysql::db selectrow_array failed: Cannot add or update a child row: a foreign key constraint fails (`koha_test`.`import_biblios`, CONSTRAINT `import_biblios_ibfk_1` FOREIGN KEY (`import_record_id`) REFERENCES `import_records` (`import_record_id`) ON DELETE CASCADE ON UPDATE CASCADE) at /mnt/catalyst/koha/C4/Context.pm line 618. and that line in C4::Context is requesting a preference. So I think that we have some sort of race condition going on. Also, forking a plack process is a) tricky, and b) memory heavy (which is why the fork was failing for me in the first instance, it started working when I changed my VM from 512MB to 1024MB.) However, I think there's something odd going on with dbh in the forked process and the original process interacting in bad ways. It seems to me that the best(?!) way to sort this is to rewrite the way the whole background processing stuff works, and to using a queueing daemon that handles forking and processing. This is cleaner overall than forking a web process anyway. However, it's a fairly substantial amount of work. A quick grep for 'fork' suggests that the following scripts may be affected by this: tools/stage-marc-import.pl tools/batchMod.pl tools/manage-marc-import.pl offline_circ/process_koc.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:22:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:22:24 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #18 from Robin Sheat --- Another option might be to do a fork-and-exec of a small process to do the work totally independently of the web serving process. That'd probably be easier to adapt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:22:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:22:44 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #50 from Katrin Fischer --- Created attachment 27443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27443&action=edit [PASSED QA] Bug 766: Move GetAuthvalueDropbox to C4::Koha GetAuthvalueDropbox is in C4::Budgets, this does not make sense. Only acqui/fetch_sort_dropbox.pl call GetAuthvalueDropbox without using C4::Koha. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:22:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:22:48 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #51 from Katrin Fischer --- Created attachment 27444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27444&action=edit [PASSED QA] Bug 766: Create a plugin routine to build dropdown list On this way, dropdown list could be generated from the templates. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:22:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:22:51 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #52 from Katrin Fischer --- Created attachment 27445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27445&action=edit [PASSED QA] Bug 766: Use the method plugin to generate sort dropdown list - memberentry Now we can use the method plugin from the memberentry form. Test plan: 1/ Create a patron and verify sort1 and sort2 dropdown list are correctly generated. 2/ Select values. 3/ Save. 4/ Edit the patron and verify the selected values are displayed. Signed-off-by: Bernardo Gonzalez Kriegel Works as described. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:22:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:22:54 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #53 from Katrin Fischer --- Created attachment 27446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27446&action=edit [PASSED QA] Bug 766: Cleaning: buildCGISort is not in use anymore buildCGISort can be deleted. Test plan: git grep buildCGISort should return no result. Signed-off-by: Bernardo Gonzalez Kriegel No more buildCGISort Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:22:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:22:57 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #54 from Katrin Fischer --- Created attachment 27447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27447&action=edit [PASSED QA] Bug 766: Use a tt include instead of a method in the AV plugin Signed-off-by: Bernardo Gonzalez Kriegel This gives a koha-qa error, but on another user/env not. Really don't know Signed-off-by: Katrin Fischer I see the same error, but can't see where this is coming from, code seems to work ok. Works as described, no regressions found. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:23:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:23:00 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #55 from Katrin Fischer --- Created attachment 27448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27448&action=edit [PASSED QA] Bug 766: Fix encoding issues [ REVERT ME on pushing bug 11944 ] This patch deals with the current master code. It should be removed when patches for bug 11944 will be pushed. Signed-off-by: Bernardo Gonzalez Kriegel No side effects. Signed-off-by: Katrin Fischer Fixes encoding problem, until this can be resolved properly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:23:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:23:26 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27044|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:23:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:23:28 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27045|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:23:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:23:30 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27046|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:23:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:23:32 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27047|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:23:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:23:35 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27048|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:23:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:23:37 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27400|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:23:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:23:53 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #56 from Katrin Fischer --- This works nicely for me. I am ready to pass QA, but I had missed before, that we will need some unit tests to cover the routine and possibly the Plugin. Also, the POD of the TT plugin should be updated to explain the new functionality. Leaving this in 'SIGNED OFF' right now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:48:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:48:05 +0000 Subject: [Koha-bugs] [Bug 12127] New: Incorrect DataTable types in Holds to Pull list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Bug ID: 12127 Summary: Incorrect DataTable types in Holds to Pull list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org At the moment, it appears that the branch filtering isn't working correctly in the Holds to Pull list. That is, it is being too restrictive rather than too fuzzy (bug 11502). It will only show rows that have a single branch when filtering. It won't show rows that have multiple available branches. I would swear that this wasn't happening earlier in the year. I repeatedly tested the patch on bug 11502 and it went through the QA process without a problem. I would also swear that the DataTables JS hasn't changed in the past few months. I would swear this because I'm using the exact same code on my machine but the filtering isn't working correctly. The only thing that seems to remotely make sense to me is perhaps a change in the browsers' internal JS processing, but I have no idea really... In any case, the immediate cause appears to be that DataTables is typing the column data as "html" rather than "string", so it is stripping out the
    tags and creating one long string of branchcodes on which to search. This is a problem after the implementation of bug 11502 which uses the angle brackets from the
    tags as a separator in regex to make the filtering more precise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:48:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:48:22 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12127 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:48:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:48:22 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11502 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 07:52:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 05:52:17 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #238 from Katrin Fischer --- Hi Jonathan, Everything looks good now, I also checked the new vendor/internal notes save correctly. There is just one more problem: the reload of the fund on the accounting details tab is still not working for me. I guess it must be something in the data that makes the difference for you, so I am trying to provide a bit more information on my current setup: - I only have 1 fund with an authorized value category linked to Statistic 2, the other funds currently have no authorized value categories linked to them. - The fund with the link appears first in my list of funds, so is selected when you get on the page. - Makes me think, maybe we need a 'select fund' option here like neworderempty.pl has? - Page shows: Statistic 1: free text field, Statistic 2: CCODE list - When I switch to another fund, it looks like no new request for a new list is done and the Statistic 2 is not cleared up. - Switching back to the first fund, I can see the request for the CCODE list in Firebug. - It works perfectly fine for individual order lines. Does that make sense? I think it's the last bit. I have confirmed it still happens with 10875 applied. ... I have a branch with 17 patches marked [PASSED QA], hope I can push that up tonight :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 08:08:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 06:08:10 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #90 from Katrin Fischer --- Running out of time here this morning - will try to continue asap. Patches apply, relative's checkouts are working, but my holds (shows 2 on the tab) have gone missing. The table loads empty. I also see a syntax error in Firebug: unterminated string literal: data += ITEM_IS_WAITING"; Switching to 'FAILED QA' - Kyle, can you check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 08:45:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 06:45:58 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 08:46:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 06:46:02 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 --- Comment #1 from David Cook --- Created attachment 27449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27449&action=edit Bug 12127 - Incorrect DataTable types in Holds to Pull list This patch explicitly sets the sType in the Holds to Pull list table for the libraries, itypes, and locations columns. It appears that the type is automatically being set to "html" when it should be set to "string". It needs to have a sType of "string", since DataTables will strip out the
    tags when using "html", and we need them for the regexp we use to create a more precise filter search. _TEST PLAN_ Before applying: 1) Place a "next available" hold on a record with an item available from one library/branch (e.g. "Branch A") 2) Place a "next available" hold on a record with an item available from two different libraries/branches 3) Place a "next available" hold on a record with an item available from three different libraries/branches - one of which is the same as the library/branch from Step 1. 4) Go to the Holds to Pull List 5) Filter the branches by "Branch A". 6) You should only see the hold from Step 1 - not Step 3. 7) Try filtering on a branch for a hold that has multiple libraries/branches. (They shouldn't appear when filtering, except when using the "None" filter). Apply the patch. After applying: 1) Repeat Steps 4-7 from above. When filtering on "Branch A", you should be able to see all holds that are available at "Branch A", even if they are available at other branches (i.e. the holds has multiple libraries listed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 09:30:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 07:30:27 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #19 from Jonathan Druart --- (In reply to Robin Sheat from comment #17) > It seems to me that the best(?!) way to sort this is to rewrite the way the > whole background processing stuff works, and to using a queueing daemon that > handles forking and processing. This is cleaner overall than forking a web > process anyway. However, it's a fairly substantial amount of work. Julian used Net::Server::Daemonize to fix an other issue in tools/batchMod.pl. It is in production and it seems to work quite well. see http://git.biblibre.com/?p=koha;a=commit;h=1347281752d62dd370f6e4fae936def6d7630d5c I don't have a lot of time at the moment to make a patch, but I will try to do it when I could. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 09:30:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 07:30:54 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 --- Comment #1 from paxed --- Also hardcoded "Deleted bibliographic notice, can't find title." in acqui/basket.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 09:39:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 07:39:23 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #20 from Jacek Ablewicz --- (In reply to Robin Sheat from comment #17) > OK, while I haven't nailed this down exactly, I think I have some hints that > there's a race condition happening. I also get plain weird things like: > > DBD::mysql::db selectrow_array failed: Cannot add or update a child row: a > foreign key constraint fails (`koha_test`.`import_biblios`, CONSTRAINT > `import_biblios_ibfk_1` FOREIGN KEY (`import_record_id`) REFERENCES > `import_records` (`import_record_id`) ON DELETE CASCADE ON UPDATE CASCADE) > at /mnt/catalyst/koha/C4/Context.pm line 618. > Looks like the plack/mod_perl related pitfall, when 2+ concurrently running processes are sharing the same single DBI connection (a big no-no, DBI would not work reliably if used that way). But - reading previous comments in this report, there may be some other unrelated/additional problems with background jobs under plack as well (?). > and that line in C4::Context is requesting a preference. So I think that we > have some sort of race condition going on. Also, forking a plack process is > a) tricky, and b) memory heavy (which is why the fork was failing for me in > the first instance, it started working when I changed my VM from 512MB to > 1024MB.) Forked/background jobs - and plack workers etc. - would not be as memory heavy (thanks to copy-on-write kernel feature) if we preload more C4/*, Koha/* and CPAN modules at plack startup script. But right now, preloading C4/Auth.pm, or any other module which is using it would cause the same exact problem with single DBI connection being shared between all plack workers and/or mod-perl processes.. That's because C4/Auth is fetching some sysprefs in BEGIN {} block. I addressed it with the following line added in the end of the startup script ${C4::Context::context}->{dbh}=undef; It seems to work fine under mod_perl (but I haven't tested it all that much yet, in particular - not with plack). This start-up script: ... use CGI (); CGI->compile(':all'); use C4::Members (); use C4::Search (); use C4::Serials (); use C4::Acquisition (); use C4::AuthoritiesMarc (); C4::Context->config('AaaBbCcc'); ${C4::Context::context}->{dbh}=undef; does preload circa 80% of C4/* perl code, resulting in significantly better latency and total RAM usage under mod_perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 09:41:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 07:41:04 +0000 Subject: [Koha-bugs] [Bug 12128] New: Acq basket shows some values with single decimal Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Bug ID: 12128 Summary: Acq basket shows some values with single decimal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 27450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27450&action=edit Format values in acq basket display with two decimals In the acquisitions basket, the values for total GSTE, total GSTI and GST are shown with a single decimal. Attached patch (re)formats the values to have two decimals. (The values are fetched from get_order_infos(), which formats the values correctly, but the formatting is lost when the values are added together) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 09:41:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 07:41:29 +0000 Subject: [Koha-bugs] [Bug 12128] Acq basket shows some values with single decimal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 09:59:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 07:59:44 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 09:59:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 07:59:49 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #239 from Jonathan Druart --- Created attachment 27451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27451&action=edit Bug 7180: Reset statistic values on reloading the page On the "Default accounting details", if a dropdown list was created for a statistic value, on reloading the page it still exist. It should not given the fund value is reset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 10:05:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 08:05:52 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 10:05:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 08:05:54 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22058|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 27452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27452&action=edit Bug 10933: The PurgeSearchHistory should be merge into the C4::Search::History module Since bug 10803 adds a C4::Search::History module, the PurgeSearchHistory routine should be moved. Test plan: - run misc/cronjobs/cleanup_database.pl with the searchhistory param and verify behavior is the same as before applying this patch. - run prove t/Search/History.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 10:41:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 08:41:13 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 10:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 08:51:18 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 10:51:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 08:51:20 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24946|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 27453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27453&action=edit [PASSED QA] Bug 11351 - Add support for SIP2 media types Koha's SIP2 server implementation does not currently support the SIP2 protocol field "media type" ( CK ). This patch implements the SIP2 media type by allowing an arbitrary mapping of itemtypes to SIP2 media types. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Edit an itemtype, select a SIP media type, and save the changes 4) Make a SIP2 Item Information Request 5) Verify that the CK field of the Item Information Response contains the correct media type code. Signed-off-by: Benjamin Rokseth Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 10:51:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 08:51:31 +0000 Subject: [Koha-bugs] [Bug 11289] sticky due date is always active In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10391 --- Comment #3 from Jonathan Druart --- Using master, it works as described by Katrin on bug 10391 comment 2. It looks not to be a bug but the expected behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 10:51:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 08:51:32 +0000 Subject: [Koha-bugs] [Bug 10391] specify due date remaining even if not selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11289 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 10:52:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 08:52:14 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- I'm happy this works as advertised, passes all qa tests and is a relatively trivial patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 11:27:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 09:27:46 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 11:27:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 09:27:56 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 11:38:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 09:38:05 +0000 Subject: [Koha-bugs] [Bug 11633] Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 12:22:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 10:22:16 +0000 Subject: [Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 --- Comment #11 from Katrin Fischer --- Maybe the best for now would be removing the unused code and keep this bug very specific. Discussion about how to improve the remaining code and which ops we should have, could then continue on a different bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 12:30:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 10:30:33 +0000 Subject: [Koha-bugs] [Bug 11633] Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 12:37:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 10:37:39 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 --- Comment #39 from Kyle M Hall --- Colin, there is no place in these patches where I make a change like that. (In reply to Colin Campbell from comment #38) > This changes the api of a routine used in many places so the change should > be clearer. The return_date is an optional parameter but this is not > indicated in the documentation of the subroutine, a comment or even > explicitly in the code, being handled as a side effect of the date routines. > > Instead of replacing > my $today = DateTime->now( time_zone => C4::Context->tz() ); > by > my $today = dt_from_string( $return_date, 'iso' ); > > can I suggest that: > my $today; > if ($return_date) { > $today = dt_from_string( $return_date, 'iso' ); > } > else { > $today = DateTime->now( time_zone => C4::Context->tz() ); > } > > makes the logic a bit clearer without forcing the reader to inspect the > DateUtils code to see that having a return_date is not required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 12:56:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 10:56:56 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26220|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize --- Created attachment 27454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27454&action=edit [PASSED QA] Bug 10942: Provide a way for package upgrades to update template translations This patch adds a new config variable AUTOMATIC_TRANSLATIONS_UPDATE at /etc/default/koha-common that is used to control whether the upgrade process should trigger a $ koha-translate --update command for each installed template translation language. To test: - Have a koha-common setup with some languages installed (e.g. koha-translate --install es-ES) - Apply the patch and build a package for it. - Install it. - A new AUTOMATIC_TRANSLATIONS_UPDATE config variable should be in place at /etc/default/koha-common - Set AUTOMATIC_TRANSLATIONS_UPDATE to 'yes' - Re-install the package to trigger the post-install script - Verify that translations get updated. Edit: added a warning message for the case AUTOMATIC_TRANSLATIONS_UPDATE=no and there are translations installed (so they need to get updated). Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Works as advertised, default behaviour doesn't change. Signed-off-by: Martin Renvoize Signed-off-by: Robin Sheat Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 12:57:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 10:57:03 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26221|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 27455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27455&action=edit [PASSED QA] Bug 10942: (follow-up) create a /etc/koha/koha-common.conf This patch creates a new master configuration file for the koha-common package, and moves the AUTOMATIC_TRANSLATIONS_UPDATE variable rather than leaving in in /etc/default/koha, which is meant to be used for init script settings. The configuration format is simple - a shell script that sets variables and which can sourced by another script or trivially parsed. To test: - Apply the patch series for bug 10942 and build a package. - Install the package. - Verify that a new config file, /etc/koha/koha-common.conf. - Follow the rest of the test plan for the main page (e.g., set AUTOMATIC_TRANSLATIONS_UPDATE and force a package upgrade). Signed-off-by: Galen Charlton Signed-off-by: Robin Sheat Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 12:57:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 10:57:13 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26222|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 27456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27456&action=edit [PASSED QA] Bug 10942: (follow-up) make AUTOMATIC_TRANSLATIONS_UPDATE default to yes This patch makes AUTOMATIC_TRANSLATIONS_UPDATE default to yes, meaning that package upgrades will update the translations by default. This seems definitely sensible for new installations, but as there are some older installations that may be in the habit directly editing generated translated templates, it's less clear whether this is a good idea for upgrades. This patch is intentionally separate, and can be ignored if the consensus swings towards having AUTOMATIC_TRANSLATIONS_UPDATE be off even for new installations or if somebody counter-patches with adding debconf support. To test: - As with the previous patches in the series, except that the translations would be automatically updated upon installing the new package. Signed-off-by: Galen Charlton Signed-off-by: Robin Sheat Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 12:57:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 10:57:23 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26223|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 27457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27457&action=edit [PASSED QA] Bug 10942 - debconfing the update option This causes a question to be asked at installation time as to whether translations should be updated or not. The answer is written to the config file, and stored in debconf. Effort is taken to ensure that if the admin changes the config file, the update will be picked up and reflected in debconf (i.e. that the admin's decision is always the correct one.) Signed-off-by: Tomas Cohen Arazi Fixed two typos that made it fail and it worked like a charm. Tested like this: - Install the package => no errors, the file is created, defaults to 'yes' - Install a language (koha-translate --install es-ES) - Re-install the package (simulating an upgrade) => es-ES gets updated - Set preference to 'no' - Re-install => es-ES doesn't get updated, the warning is printed correctly - Installed a second language (koha-translate --install pt-BR) - did all the tests again => Success Note: on master there are obvious template translation warnings. A copy of the generated package can be grabbed from: http://es.koha-community.org/koha-common_3.15+20140312172225.af7c0a23_all.deb Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 12:59:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 10:59:06 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26301|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 27458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27458&action=edit [PASSED QA] Bug 10942: (QA followup) Warnings should go to STDERR As noted by Robin, STDOUT is used by the script to communicate with debconf and, ence, the warning messages should be directed to STDERR. This patch does that. To test: - Set AUTOMATIC_TRANSLATIONS_UPDATE="no" so the warning normally shows - Redirect STDOUT to /dev/null: dpkg -i koha-common...deb > /dev/null => Warning message doesn't show (i.e. it is sent to STDOUT) - Apply the patch, rebuild package - Redirect STDOUT to /dev/null: dpkg -i koha-common...deb > /dev/null => Warning message shows (i.e. is correctly sent to STDERR) - Redirect STDERR to /dev/null: dpkg -i koha-common...deb 2> /dev/null => Warning message doesn't show - Verify that previous tests pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 12:59:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 10:59:04 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:02:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:02:15 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #37 from Martin Renvoize --- Yowsers, that was a long one. I built packages from the resulting patch set, and tested: 1. That the config file is now created - tick 2. That the config file is used for upgrades and defaults to yes - tick 3. That the config file is read as upgrade time to correctly set debconf - tick 4. That it all passes the qa scripts still - tick I'm happy that this all works as described now. Nice bit of team work going on there. I'm going to open a further bug, so that the suggestion to move translations into /var doesn't get lost once this bugs life expires. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:05:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:05:26 +0000 Subject: [Koha-bugs] [Bug 12129] New: Translations should be removed when koha-common package is removed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12129 Bug ID: 12129 Summary: Translations should be removed when koha-common package is removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz As mentioned by Robin in comment - http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942#c15 'We should probably also have a postrm hook that removes the translations when the package is removed, as they won't be tracked by the package manager as-is.' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:05:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:05:42 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12129 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:05:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:05:42 +0000 Subject: [Koha-bugs] [Bug 12129] Translations should be removed when koha-common package is removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12129 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10942 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:07:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:07:00 +0000 Subject: [Koha-bugs] [Bug 12130] New: Translations should live in /var not /usr for package installs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12130 Bug ID: 12130 Summary: Translations should live in /var not /usr for package installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz As mentioned by Robin in comment - http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942#c15 'They probably also should be going into /var, as writing to /usr is a bit of an odd thing to do really. This'll require more thought though.' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:07:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:07:10 +0000 Subject: [Koha-bugs] [Bug 12130] Translations should live in /var not /usr for package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12130 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10942 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:07:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:07:10 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12130 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:26:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:26:45 +0000 Subject: [Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:26:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:26:47 +0000 Subject: [Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25357|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 27459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27459&action=edit [PASSED QA] Bug 10782 - Add a koha-mysqlcheck script This patch adds the koha-mysqlcheck script, as a "frontend" for the mysqlcheck command. It can be used to check the integrity of database tables, as well as to repair them. See "man mysqlcheck" for more information. The script takes a Koha instance name as its only required parameter. Any other parameters provided before the instance name are passed directly to mysqlcheck, which means that all the functionality of mysqlcheck is available through this script. To test the script: - Apply the patch, build your own packages and install them, or - copy koha-mysqlcheck to a server already running off packages - Run some variations of the command, with and without arguments, and check that the output makes sense. E.g.: sudo koha-mysqlcheck myinstance sudo koha-mysqlcheck -e myinstance # Extended checks sudo koha-mysqlcheck -e -v myinstance # Extended checks and verbose - See "man mysqlcheck" for other relevant options To test the man page: - Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-mysqlcheck.xml $ man -l koha-mysqlcheck.8 - Make sure this test passes: $ prove -v xt/verify-debian-docbook.t Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:27:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:27:24 +0000 Subject: [Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Nice simple script, does what it says on the tin and causes no regressions. A worthwhile addition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:37:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:37:54 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25359|0 |1 is obsolete| | Attachment #25399|0 |1 is obsolete| | Attachment #26998|0 |1 is obsolete| | Attachment #26999|0 |1 is obsolete| | Attachment #27000|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 27460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27460&action=edit Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:39:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:39:08 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 --- Comment #40 from Kyle M Hall --- Created attachment 27461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27461&action=edit Bug 10694 [QA Followup] - Unit Tests, improve AddReturn POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:40:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:40:20 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #27 from Jonathan Druart --- Created attachment 27462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27462&action=edit Bug 8992: DB changes - add the IdRef syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:40:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:40:25 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #28 from Jonathan Druart --- Created attachment 27463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27463&action=edit Bug 8992: Add 7..$3 to the Indentifier-standard index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:40:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:40:29 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #29 from Jonathan Druart --- Created attachment 27464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27464&action=edit Bug 8992: XSLT changes This patch add the same behavior as previous patches for the xslt view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:41:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:41:03 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Jonathan Druart --- Katrin, All 7 points are taken into account in new patches. I removed the support for the prog theme too. There is just one small thing I did not manage to fix: the popup does not apply style to the table. Back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:41:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:41:24 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #41 from Kyle M Hall --- Setting to passed qa on the assumption that the unit test was the final blocker for this one. If am incorrect, please update the status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:45:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:45:05 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #17 from Kyle M Hall --- Created attachment 27465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27465&action=edit Bug 8769 [QA Followup] - Remove unnecessary module import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 13:57:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 11:57:15 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #131 from M. de Rooy --- (In reply to Katrin Fischer from comment #130) > Hi Marcel - do you plan to continue on the other patches? I am not sure in > which state that is and if you already started. Could you give a quick > update? Thx! I plan to continue with some of these reports, but I did not start yet. And I certainly have no monopoly on them. It could be advantageous if some other people also look at this line of development. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:00:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:00:27 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #132 from Katrin Fischer --- As feature freeze will be upon us quite soon I was wondering if we can figure out a way to get this QA'd in time. I am currently still working on some other big patches, but maybe someone else will be able to help you with those before I can? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:23:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:23:26 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl --- Comment #19 from M. de Rooy --- Does not apply anymore on top of 9016. Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:24:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:24:12 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from M. de Rooy --- Does not apply on top of 9016. Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:26:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:26:14 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #24 from M. de Rooy --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:32:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:32:35 +0000 Subject: [Koha-bugs] [Bug 11898] the js accordion when editing marc frameworks is broken for the t tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11898 --- Comment #1 from Gaetan Boisson --- To clarify : this only happens in the 't' tab, there is no problem with the other subfields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:33:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:33:24 +0000 Subject: [Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:34:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:34:36 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26753|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 27466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27466&action=edit [PASSED QA] Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. Signed-off-by: Benjamin Rokseth Works as notified, second date field in SIP checkin (return date) is used as return date. Return shows up in history with correct date. Comments: - patron is fined if return date is before issue date, but that is largely irrelevant anyway. - dependent bug 10694 is marked as Failed QA but seems to have passed? Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:35:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:35:18 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27465|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 27467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27467&action=edit [PASSED QA] Bug 8769 - (QA Followup) Remove unnecessary module import Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:35:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:35:16 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:36:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:36:07 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #20 from Martin Renvoize --- This patch is good now, happy to pass qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:44:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:44:31 +0000 Subject: [Koha-bugs] [Bug 12105] Remove duplicated plugin jquery.dataTables.columnFilter.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:53:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:53:14 +0000 Subject: [Koha-bugs] [Bug 11898] the js accordion when editing marc frameworks is broken for the t tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11898 --- Comment #2 from Gaetan Boisson --- This problem only happens if you have adblock plus installed and activated in firefox it seems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 14:56:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 12:56:27 +0000 Subject: [Koha-bugs] [Bug 11898] the js accordion when editing marc frameworks is broken for the t tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11898 --- Comment #3 from Gaetan Boisson --- There is a rule in adblock plus : ###advt that blocks the display of the advanced constraint tab with the advt id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:00:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:00:35 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23900|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 27468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27468&action=edit Bug 10832: Multi transport types for overdue notices Test plan: - define some complex overdue rules (tools/overduerules.pl). For example: First overdue from 2 to 5 days by sms and email with letter code L1 Second overdue from 5 to 15 days by email with letter code L2 Third overdue from 15 days by print with letter code L3 - defined a message for each transport type selected (tools/letters.pl). - select 3 patrons (P1, P2, P3) and 3 barcodes (B1, B2, B3). * checkout B1 to P1 with a due date = NOW + 3 days * checkout B2 to P2 with a due date = NOW + 10 days * checkout B3 to P3 with a due date = NOW + 20 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/overdue_notices.pl - retry the previous sql query, you should have X + 4 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code L1 1 message for P2, 1 for email and the letter code L2 1 message for P3, 1 for print and the letter code L3 - Specific case: If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required, a print notice is generated. A print notice is generated only 1 time per borrower and per level. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:00:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:00:40 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25223|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 27469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27469&action=edit Bug 10832: FIX Some print notices may not be sent If overdues should be sent to some patron (on the same branch), only the first one was notified. This patch fixes this issue. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:01:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:01:32 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #22 from Jonathan Druart --- Last patches fix conflict with bug 11598. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:08:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:08:03 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25703|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 27470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27470&action=edit [SIGNED-OFF] Bug 11856: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:08:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:08:01 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:08:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:08:14 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25704|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 27471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27471&action=edit [SIGNED-OFF] Bug 11856: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:10:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:10:09 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23901|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 27472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27472&action=edit Bug 10833: Multi transport types for advanced notices Test plan: - Choose 2 patrons P1 and P2 - Edit "Patron messaging preferences" and check SMS + email with 2 days in advance for P1 check email with 5 days in advance for P2 - defined a message for the letter code PREDUE for sms and email (tools/letters.pl). - select 2 barcodes (B1, B2). * checkout B1 to P1 with a due date = NOW - 2 days * checkout B2 to P2 with a due date = NOW - 5 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/advance_notices.pl -c - retry the previous sql query, you should have X + 3 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code PREDUE 1 message for P2, email and the letter code PREDUE Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:10:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:10:15 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23902|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 27473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27473&action=edit Bug 10833: Enhanced a warning message to include the message transport type in the message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:10:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:10:45 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 --- Comment #10 from Jonathan Druart --- Last patches fix conflict with bug 8258. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:10:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:10:57 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:14:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:14:21 +0000 Subject: [Koha-bugs] [Bug 11898] the js accordion when editing marc frameworks is broken for the t tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11898 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Gaetan Boisson --- This problem is due to another extension and should be fixed there. A separate bug has been submitted to the adblock plus team. Meanwhile, if you encounter the bug, check your adblock plus rules or deactivate the extension. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:14:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:14:30 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #8 from Owen Leonard --- Created attachment 27474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27474&action=edit [SIGNED-OFF] Bug 11856: Add publiction year and edition to French acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout3pagesfr. Additional change: Translates 'published by' to 'publi? par' http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:14:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:14:57 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25705|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:17:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:17:52 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27461|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize --- Created attachment 27475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27475&action=edit [SIGNED OFF] [Bug 10694 [QA Followup] - Unit Tests, improve AddReturn POD Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:21:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:21:47 +0000 Subject: [Koha-bugs] [Bug 12131] New: C4/TmplToken.pm has an unnecessary dependency on Exporter Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 Bug ID: 12131 Summary: C4/TmplToken.pm has an unnecessary dependency on Exporter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org TmplToken has a dependency on Exporter but does not export anything all subroutines being called via a TmplToken object looks like a bit of boilerplate got in the module. Lets remove that and the "burden" of compiling it every time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:27:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:27:42 +0000 Subject: [Koha-bugs] [Bug 11520] Invoice isn't really an invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11520 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #3 from Jacek Ablewicz --- Not sure if it's an exact duplicate, but I believe it is resolved by bug 11844 (at least partially: actual cost being shown on invoice details page instead of rrp & estimated cost). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:28:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:28:07 +0000 Subject: [Koha-bugs] [Bug 11520] Invoice isn't really an invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11520 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11844 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:28:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:28:07 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:28:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:28:51 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 --- Comment #11 from Jonathan Druart --- Created attachment 27476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27476&action=edit Bug 11351 - Add support for SIP2 media types - French file This patch adds the SIP_MEDIA_TYPE AV for the fr-FR file. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:30:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:30:00 +0000 Subject: [Koha-bugs] [Bug 12131] C4/TmplToken.pm has an unnecessary dependency on Exporter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 27477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27477&action=edit proposed patch Trivial patch does not affect functionality - removes an unused dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:30:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:30:26 +0000 Subject: [Koha-bugs] [Bug 11898] the js accordion when editing marc frameworks is broken for the t tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11898 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- I've send a report : https://reports.adblockplus.org/a506530c-65f9-426b-9246-75c181db10e4#tab=requests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:31:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:31:23 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:32:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:32:39 +0000 Subject: [Koha-bugs] [Bug 11520] Invoice isn't really an invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11520 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11844 | --- Comment #4 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #3) > Not sure if it's an exact duplicate, but I believe it is resolved by bug > 11844 (at least partially: actual cost being shown on invoice details page > instead of rrp & estimated cost). Sorry, wrong bug number - what I meant: it's resolved by bug 10613, NOT 11844. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:32:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:32:39 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11520 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:33:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:33:39 +0000 Subject: [Koha-bugs] [Bug 11520] Invoice isn't really an invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11520 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10613 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:33:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:33:39 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:34:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:34:53 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- I like this patch... but, I'de like to see it implemented such that the files in question have perma-links as opposed to the current dynamically created ones which could change. I'de also love to see a followup that allowed files to require authentication or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:39:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:39:05 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 --- Comment #43 from Colin Campbell --- (In reply to Kyle M Hall from comment #39) > Colin, there is no place in these patches where I make a change like that. > > (In reply to Colin Campbell from comment #38) > > This changes the api of a routine used in many places so the change should > > be clearer. The return_date is an optional parameter but this is not > > indicated in the documentation of the subroutine, a comment or even > > explicitly in the code, being handled as a side effect of the date routines. > > > > Instead of replacing > > my $today = DateTime->now( time_zone => C4::Context->tz() ); > > by > > my $today = dt_from_string( $return_date, 'iso' ); > > > > can I suggest that: > > my $today; > > if ($return_date) { > > $today = dt_from_string( $return_date, 'iso' ); > > } > > else { > > $today = DateTime->now( time_zone => C4::Context->tz() ); > > } > > > > makes the logic a bit clearer without forcing the reader to inspect the > > DateUtils code to see that having a return_date is not required Sorry its in 8769 ... but isnt it logically part of this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:40:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:40:35 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #5 from Katrin Fischer --- I think I like the idea of this being 'required authentication' only and having another mostly separate feature for publicly available files. We have been thinking about how the library could get to printed holds and overdue notices. Moving them to an SFTP server or similar would be an option, but having a secure way in Koha to access and download the files would be better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:44:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:44:14 +0000 Subject: [Koha-bugs] [Bug 12128] Acq basket shows some values with single decimal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 --- Comment #1 from Marc V?ron --- Created attachment 27478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27478&action=edit [Signed-off] Format some of the values in basket display with two decimals, as adding the values together loses the formatting given by get_order_infos() http://bugs.koha-community.org/show_bug.cgi?id=12128 To test open a basket and see some values without decimal formatting (e.g. in column Total tax exc.) Apply patch Values are now formatted wit two decimals. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:44:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:44:48 +0000 Subject: [Koha-bugs] [Bug 12128] Acq basket shows some values with single decimal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27450|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:45:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:45:08 +0000 Subject: [Koha-bugs] [Bug 12128] Acq basket shows some values with single decimal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:45:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:45:33 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #57 from Jonathan Druart --- (In reply to Katrin Fischer from comment #56) > This works nicely for me. I am ready to pass QA, but I had missed before, > that we will need some unit tests to cover the routine and possibly the > Plugin. I just moved the routine, no change done. So I am not sure it should be needed. It would be great to have unit tests for authorized values (see bug 10363). > Also, the POD of the TT plugin should be updated to explain the new > functionality. Will do. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:46:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:46:30 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #58 from Jonathan Druart --- Created attachment 27479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27479&action=edit Bug 766: Update POD for AuthorisedValues TT plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:52:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:52:40 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21458|0 |1 is obsolete| | Attachment #27335|0 |1 is obsolete| | --- Comment #67 from Chris Nighswonger --- Created attachment 27480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27480&action=edit Bug 10859: (follow-up) clarify logic on multiple loans on same bib This patch clarifies the logic for determining if a given item to be checked out would be the second (or third, etc.) loan on the same bib. As a conseqence, if the item is already on loan to the patron, the circ staffer won't see the multiple-loans-on-a-bib warning, just the confirmation to renew the loan or the warning that no more renewals are lest. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:53:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:53:19 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:53:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:53:20 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27449|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 27481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27481&action=edit [SIGNED-OFF] Bug 12127 - Incorrect DataTable types in Holds to Pull list This patch explicitly sets the sType in the Holds to Pull list table for the libraries, itypes, and locations columns. It appears that the type is automatically being set to "html" when it should be set to "string". It needs to have a sType of "string", since DataTables will strip out the
    tags when using "html", and we need them for the regexp we use to create a more precise filter search. _TEST PLAN_ Before applying: 1) Place a "next available" hold on a record with an item available from one library/branch (e.g. "Branch A") 2) Place a "next available" hold on a record with an item available from two different libraries/branches 3) Place a "next available" hold on a record with an item available from three different libraries/branches - one of which is the same as the library/branch from Step 1. 4) Go to the Holds to Pull List 5) Filter the branches by "Branch A". 6) You should only see the hold from Step 1 - not Step 3. 7) Try filtering on a branch for a hold that has multiple libraries/branches. (They shouldn't appear when filtering, except when using the "None" filter). Apply the patch. After applying: 1) Repeat Steps 4-7 from above. When filtering on "Branch A", you should be able to see all holds that are available at "Branch A", even if they are available at other branches (i.e. the holds has multiple libraries listed). Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:54:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:54:20 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27480|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:55:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:55:17 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #68 from Chris Nighswonger --- Created attachment 27482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27482&action=edit [SIGNED-OFF] Bug 8375 - Followup - Fix font code and alignment This patch fixes two problems: a) Bad PDF when using Helvetica font. Current label code assigns 'italic' or 'oblique' variants to title. Helvetica-Oblique was not defined, but is present b) Bad alignment using center/right justification Problem was bad font parameter passed to StrWidth routine To test: 1. Try making a batch using Helvetica, downloaded PDF do not open. 2. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. 3. Apply the patch and update your koha-conf.xml to add Oblique variant 4. Try again 1, now PDF opens 5. Try 2, now alignment is correct New problem (for another bug): DejaVuSans has a good support for arabic, but not Oblique variant. As selection of italic/oblique is hardcoded, now Arabic titles are not displayed. I'll try to add a checkbox to select or not this feature. Added a FIXME for the hardcoded forced oblique -chris_n Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:56:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:56:16 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27482|0 |1 is obsolete| | --- Comment #69 from Chris Nighswonger --- Created attachment 27483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27483&action=edit [SIGNED-OFF] Bug 8375 - use truetype fonts in PDF::Reuse Since built-in PDF fonts suport just latin-1 encoding, we have to switch to truetype fonts to correctly encode all utf-8 characters (which we should be getting from database anyway). This approach also nicely sidesteps our encoding cludges, but requires paths to truetype fonts which are included in koha-conf.xml under new section. Without this directive in kona-conf.xml code will still use latin-1 built-in pdf fonts. Signed-off-by: Kyle M Hall Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 15:56:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 13:56:29 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #70 from Chris Nighswonger --- Created attachment 27484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27484&action=edit [SIGNED-OFF] Bug 8375 - Followup - Fix font code and alignment This patch fixes two problems: a) Bad PDF when using Helvetica font. Current label code assigns 'italic' or 'oblique' variants to title. Helvetica-Oblique was not defined, but is present b) Bad alignment using center/right justification Problem was bad font parameter passed to StrWidth routine To test: 1. Try making a batch using Helvetica, downloaded PDF do not open. 2. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. 3. Apply the patch and update your koha-conf.xml to add Oblique variant 4. Try again 1, now PDF opens 5. Try 2, now alignment is correct New problem (for another bug): DejaVuSans has a good support for arabic, but not Oblique variant. As selection of italic/oblique is hardcoded, now Arabic titles are not displayed. I'll try to add a checkbox to select or not this feature. Added a FIXME for the hardcoded forced oblique -chris_n Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:00:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:00:05 +0000 Subject: [Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19189|0 |1 is obsolete| | --- Comment #5 from Chris Nighswonger --- Created attachment 27485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27485&action=edit [SIGNED-OFF] bug 9854: add ttf-dejavu as dependency for Debian packages ttf-dejavu (i.e., the core and extra DejaVu TrueType) fonts are used by the proposed fix for bug 8375. To test, build and install the Koha packages for Debian and verify that the ttf-dejavu package is installed. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:00:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:00:25 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:01:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:01:11 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:01:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:01:52 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:02:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:02:41 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:05:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:05:49 +0000 Subject: [Koha-bugs] [Bug 12119] Move jeditable jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12119 --- Comment #2 from Marc V?ron --- Created attachment 27486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27486&action=edit [Signed-off] Bug 12119 - Move jeditable jQuery plugin outside of language-specific directory This patch moves the jeditable jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. To test, apply the patch and confirm that editing quotes works correctly in the Quote of the Day manager. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:06:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:06:13 +0000 Subject: [Koha-bugs] [Bug 12119] Move jeditable jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12119 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27368|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:06:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:06:22 +0000 Subject: [Koha-bugs] [Bug 12119] Move jeditable jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12119 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:11:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:11:43 +0000 Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for serials. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:14:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:14:59 +0000 Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:15:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:15:01 +0000 Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26723|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 27487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27487&action=edit [SIGNED-OFF] Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:18:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:18:00 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:18:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:18:24 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:18:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:18:25 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26725|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 27488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27488&action=edit [SIGNED-OFF] Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch This small patch corrects the SIP2 checkin response if branch transfer is needed. It depends on bug 7981 and also removes an obsolete alert check in SIP2. Test plan: - apply bug 7981 - make sure syspref AutomaticItemReturn is false - check 'Return policy' in 'Default checkout, hold and return policy' - make a SIP2 checkout and checkin from a branch different than item's home branch. - verify that SIP2 response gives alert CV04 (=send to different branch) - also verify that response field CT gives correct branch according to 'Return policy' Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:19:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:19:33 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12088 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:19:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:19:33 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12127 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:19:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:19:47 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:21:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:21:37 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:21:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:21:38 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27138|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 27489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27489&action=edit Bug 12088 [Revised] Improve date handling and sorting in holds to pull report The holds to pull report could be improved by improving sorting on the title and date columns. This patch adds "anti-the" sorting to the title column and "title-string" sorting to the date column. Date formatting of another variable has been moved to the template for formatting using KohaDates. The patch includes other corrections for HTML validity. To test, apply the patch and view the holds to pull report. - Sorting by date should work correctly regardless of dateformat system preference setting. - Sorting of the title columns should correctly ignore articles. - Formatting of the "Reported on" date should be correct. Revision incorporates the corrections made by Bug 12127 and converts those changes to use class-based sorting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:23:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:23:02 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:24:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:24:25 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24405|0 |1 is obsolete| | Attachment #24406|0 |1 is obsolete| | --- Comment #25 from M. de Rooy --- Created attachment 27490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27490&action=edit Bug 10845: Remove the notice code HOLD_PRINT The HOLD_PRINT notice code is the HOLD notice code with a message transport type equal to 'print'. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:24:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:24:30 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #26 from M. de Rooy --- Created attachment 27491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27491&action=edit Bug 10845: Multi transport types for holds The HOLD_PRINT and HOLD_PHONE notices become useless. This patch will modify existing notices in order to group them into the main notices 'HOLD'. Like that, on one screen, all these notices can be edited. Test plan: - apply the patch and execute the update database entry. - verify that yours previous HOLD_PHONE and HOLD_PRINT are displayed when editing the HOLD notice (under phone and print). - choose a patron and check sms, email, phone for "Hold filled" (on the patron messaging preferences). - place a hold. - check the item in and confirm the hold. - if the patron has an email *and* a sms number, 2 new messages are put into the sql message_queue table: 1 sms and 1 email. if the patron does not have 1 of them, there are 2 new messages: 1 sms/email and 1 print. if the user has neither of them, there is 1 new message: 1 print. - the generated messages should correspond with the notices defined, depending the message transport type. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy Just noting that if email and sms are disabled in the msg prefs, the user will not have a print message. And if the sms driver fails, the record status in message_queue is 'failed', but staff may not be aware of that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:25:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:25:23 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:27:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:27:15 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #27 from M. de Rooy --- Yet another idea for a follow-up: If you did not fill the text for sms, you will have an error: Could not find a letter called 'HOLD' in the 'reserves' module at C4/Reserves.pm line 1932. It would be helpful to include here the message transport type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:39:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:39:27 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #23 from M. de Rooy --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:39:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:39:40 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:40:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:40:02 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:43:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:43:19 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #28 from Jonathan Druart --- (In reply to M. de Rooy from comment #26) > Just noting that if email and sms are disabled in the msg prefs, the user > will not have a print message. I confirm it works for me. I filled the pref smsdriver, removed email et smsalertnumber for a user A. Checkout an item for user B and place an hold on the item for user A. I checked the item in and a HOLD print is generated in the message_queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:43:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:43:37 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #29 from Jonathan Druart --- (In reply to M. de Rooy from comment #27) > Yet another idea for a follow-up: > If you did not fill the text for sms, you will have an error: > Could not find a letter called 'HOLD' in the 'reserves' module at > C4/Reserves.pm line 1932. > > It would be helpful to include here the message transport type. I confirm it's look like a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:52:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:52:33 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #71 from Bernardo Gonzalez Kriegel --- Can be changed to 'Signed-off'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:53:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:53:41 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #6 from Martin Renvoize --- Created attachment 27492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27492&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:54:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:54:50 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #30 from M. de Rooy --- (In reply to Jonathan Druart from comment #28) > (In reply to M. de Rooy from comment #26) > > Just noting that if email and sms are disabled in the msg prefs, the user > > will not have a print message. > > I confirm it works for me. > I filled the pref smsdriver, removed email et smsalertnumber for a user A. > Checkout an item for user B and place an hold on the item for user A. > I checked the item in and a HOLD print is generated in the message_queue. If you disable email and sms in msg prefs and you have no sms number, you will have no print. If you leave sms enabled but without sms number, you do have a print notice. (Have just mentioned it for completeness on the signoff line.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:56:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:56:02 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #7 from Martin Renvoize --- Added a follow-up to create permalinks to files based upon filename only (We may want to link to a changing file in the case of logs). I'de still like to see this changed to reflect different permissions more specifically, to enable a more general approach, as opposed to being a reports only feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:57:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:57:10 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #31 from Jonathan Druart --- Created attachment 27493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27493&action=edit Bug 10845: Add the MTT in the die message If no template is defined for the HOLD letter and the needed MTT, we should display the MTT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 16:59:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 14:59:04 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #32 from Jonathan Druart --- (In reply to M. de Rooy from comment #30) > If you disable email and sms in msg prefs and you have no sms number, you > will have no print. If you leave sms enabled but without sms number, you do > have a print notice. (Have just mentioned it for completeness on the signoff > line.) Ok sorry, I misunderstood! Thank you for qaing these (and others!) patches! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:04:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:04:58 +0000 Subject: [Koha-bugs] [Bug 7125] can't change tag in frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:05:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:05:00 +0000 Subject: [Koha-bugs] [Bug 7125] can't change tag in frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 --- Comment #3 from Owen Leonard --- Created attachment 27494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27494&action=edit Bug 7125 - can't change tag in frameworks When you edit an existing tag in a MARC framework the form makes it appear as if you can change the tag number when in fact you cannot. This patch changes the template so that the tag number does not appear as an editable form field during the edit process. To test, apply the patch and open an existing MARC framework in Adminstration -> MARC bibliographic framework. - Choose an existing tag from the list and click 'Edit.' - The line labeled "Tag" should display the tag as text. - Making a change to any of the tag's details should work correctly. - Return to the list of the MARC framework's tags. - Click 'New tag.' - The line labeled "Tag" should display a blank form field. - Create a new tag and confirm that it saves correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:11:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:11:10 +0000 Subject: [Koha-bugs] [Bug 7125] can't change tag in frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org Severity|major |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:22:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:22:26 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27479|0 |1 is obsolete| | --- Comment #59 from Bernardo Gonzalez Kriegel --- Created attachment 27495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27495&action=edit [SIGNED-OFF] Bug 766: Update POD for AuthorisedValues TT plugin Signed-off-by: Bernardo Gonzalez Kriegel POD is Ok. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:23:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:23:37 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27468|0 |1 is obsolete| | Attachment #27469|0 |1 is obsolete| | --- Comment #24 from M. de Rooy --- Created attachment 27496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27496&action=edit Bug 10832: Multi transport types for overdue notices Test plan: - define some complex overdue rules (tools/overduerules.pl). For example: First overdue from 2 to 5 days by sms and email with letter code L1 Second overdue from 5 to 15 days by email with letter code L2 Third overdue from 15 days by print with letter code L3 - defined a message for each transport type selected (tools/letters.pl). - select 3 patrons (P1, P2, P3) and 3 barcodes (B1, B2, B3). * checkout B1 to P1 with a due date = NOW + 3 days * checkout B2 to P2 with a due date = NOW + 10 days * checkout B3 to P3 with a due date = NOW + 20 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/overdue_notices.pl - retry the previous sql query, you should have X + 4 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code L1 1 message for P2, 1 for email and the letter code L2 1 message for P3, 1 for print and the letter code L3 - Specific case: If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required, a print notice is generated. A print notice is generated only 1 time per borrower and per level. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:23:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:23:45 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #25 from M. de Rooy --- Created attachment 27497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27497&action=edit Bug 10832: FIX Some print notices may not be sent If overdues should be sent to some patron (on the same branch), only the first one was notified. This patch fixes this issue. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:25:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:25:04 +0000 Subject: [Koha-bugs] [Bug 11403] renew page missing help file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Fridolin SOMERS --- Follow-up patch pushed, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:27:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:27:44 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #26 from M. de Rooy --- No circulation PREDUE letter at /usr/share/koha/testclone/C4/Letters.pm line 455 (Similar remark as on report 10845. Listing the mtt would be helpful too.) Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:31:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:31:53 +0000 Subject: [Koha-bugs] [Bug 10009] self check out not really logging out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10009 --- Comment #1 from Owen Leonard --- 3.12.x in Firefox - No problem 3.14.x in Firefox - No problem master in Firefox - No problem 3.12.x in Chrome - I can reproduce the problem 3.14.x in Chrome - No problem master in Chrome - No problem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:34:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:34:27 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.06 (creates version 3.14.05.001) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:36:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:36:57 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #27 from Jonathan Druart --- Created attachment 27498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27498&action=edit Bug 10832: Add the MTT in the warn message If no template is defined for a letter and the needed MTT, we should display the MTT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:39:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:39:38 +0000 Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:42:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:42:00 +0000 Subject: [Koha-bugs] [Bug 7125] can't change tag in frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27494|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 27499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27499&action=edit [SIGNED-OFF] Bug 7125 - can't change tag in frameworks When you edit an existing tag in a MARC framework the form makes it appear as if you can change the tag number when in fact you cannot. This patch changes the template so that the tag number does not appear as an editable form field during the edit process. To test, apply the patch and open an existing MARC framework in Adminstration -> MARC bibliographic framework. - Choose an existing tag from the list and click 'Edit.' - The line labeled "Tag" should display the tag as text. - Making a change to any of the tag's details should work correctly. - Return to the list of the MARC framework's tags. - Click 'New tag.' - The line labeled "Tag" should display a blank form field. - Create a new tag and confirm that it saves correctly. Signed-off-by: Bernardo Gonzalez Kriegel Work as describes, on edit and new. No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:42:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:42:36 +0000 Subject: [Koha-bugs] [Bug 7125] can't change tag in frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:48:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:48:44 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #72 from Chris Nighswonger --- This works as described for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 17:59:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 15:59:53 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #42 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:00:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:00:13 +0000 Subject: [Koha-bugs] [Bug 5823] Repeated check in of on-hold item fails to show hold information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5823 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Owen Leonard --- I don't see this problem anymore in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:11:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:11:53 +0000 Subject: [Koha-bugs] [Bug 6443] Merging bibs with quotes in 520 field truncates the 520 field text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6443 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Version|3.4 |master Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- I cannot reproduce this problem in master. Heather can you please re-check and reopen the bug if you still see it? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:14:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:14:55 +0000 Subject: [Koha-bugs] [Bug 11363] Label printer profile units are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24458|0 |1 is obsolete| | CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:15:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:15:09 +0000 Subject: [Koha-bugs] [Bug 11363] Label printer profile units are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:25:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:25:43 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:26:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:26:57 +0000 Subject: [Koha-bugs] [Bug 5170] budgets not giving user error messages on fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5170 --- Comment #1 from Owen Leonard --- This is still valid in master pre-3.16. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:29:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:29:16 +0000 Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:48:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:48:46 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26625|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 27500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27500&action=edit [SIGNED OFF] Bug 9612: SRU response for DOM indexing This patch makes changes to koha-conf.xml by removing the fallback section from biblioserver and authserver. The information is in a include file on the same server (no need to fall back) and moreover, some information is not up-to-date and should be moved elsewhere. The patch also simplifies the DOM retrieval-info files for auth and bib. And eliminates superfluous F and usmarc from the dom-config files. (I felt the urge to remove marcxml too, but left it for now; see also the second patch.) For reference, look at the marcxml example files of Zebra. NOTE: This patch does not deal with the Debian package installs. In the same way koha-conf-site.xml.in, and *-retrieval-info-* could be adjusted. Test plan: [1] Run at least a dev install in order to copy the new files to your Zebra folders. Choose for DOM indexing. Enable the SRU server on port 9998 (small edit in koha-conf.xml). [2] Restart Zebra and reindex -a -b -x. [3] Verify if a search from Koha still functions as expected. Check the SRU output on port 9998. NOTE: If you do not pass recordSchema, you should get back a marc response now (instead of index schema). Bonus: Add your server as a Z3950 target to another Koha install. And perform a Z3950 search from the other server to your new install. Bonus: Check response from the auth and biblio socket via yaz-client. [4] Reindex again with -a -b but without -x. [5] Repeat Koha search, SRU response (Z3950, yaz-client). Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:48:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:48:53 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26626|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 27501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27501&action=edit [SIGNED OFF] Bug 9612: Zconn parameters and elementSetName in _new_Zconn This patch makes a few adjustments in C4::Context::Zconn. It does no longer pass the (ignored) auth, syntax parameters to _new_Zconn. Note that auth was not completely ignored in theory, but we never pass auth=1 [while not having user/password in koha-conf]. Furthermore, it removes the elementSetName for dom indexing. Using marcxml here does not make a difference. It only adds a constraint on what is in the dom-config files. (It could probably be removed there now..) Two cosmetic code changes: Removes unused label retry. And moved 'servername' into the database name option. Test plan: When using Zebra with dom indexing, do a biblio and authority search. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:49:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:49:55 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Martin Renvoize --- Finally got around to testing this, and it behaves as expected and also simplifies the config somewhat which I see as a good thing. Nice work M. de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 18:54:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 16:54:41 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #16 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 19:00:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 17:00:25 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 19:02:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 17:02:03 +0000 Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 19:02:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 17:02:14 +0000 Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 19:07:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 17:07:39 +0000 Subject: [Koha-bugs] [Bug 11313] empty value in mandatory combobox in record edition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11313 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 19:08:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 17:08:30 +0000 Subject: [Koha-bugs] [Bug 6443] Merging bibs with quotes in 520 field truncates the 520 field text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6443 --- Comment #2 from Heather Braum --- I tested it and it is no longer an issue in master. I vaguely recall reporting this 3 years ago :) Thanks for checking on it Owen. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 19:09:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 17:09:08 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 19:09:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 17:09:10 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 --- Comment #2 from Owen Leonard --- Created attachment 27502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27502&action=edit Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off If the user knows the URL for OPAC lists they can access them even with the virtualshelves preference turned off. This patch copies the solution added to opac-topissues.pl by Bug 10595 and applies it to OPAC lists pages. To test, apply the patch and set the virtualshelves system preference to "don't allow." - Navigate to /cgi-bin/koha/opac-shelves.pl. You should be redirected to an Error 404 page. - Also check /cgi-bin/koha/opac-shareshelf.pl. - Turn virtualshelves back on. Access to lists and list sharing should be restored. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 19:17:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 17:17:47 +0000 Subject: [Koha-bugs] [Bug 8308] can't print transfer slip twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8308 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #1 from Owen Leonard --- I don't get it... The second time you check the item in there's a "Print slip and confirm" button which prints the transfer slip. Isn't that what you want? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 19:23:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 17:23:09 +0000 Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 19:35:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 17:35:00 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #21 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 20:55:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 18:55:11 +0000 Subject: [Koha-bugs] [Bug 8444] Lost item checked in doesn't remove from patron record, nor prompt that item is marked as lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8444 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- I can't reproduce this problem in 3.8.x or master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 21:22:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 19:22:55 +0000 Subject: [Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011 --- Comment #1 from Owen Leonard --- This bug is still valid. The code for adding a branch limitations in admin/categorie.pl was only added for the update process, not the insert process. It wouldn't be difficult to add similar code for the insert process, but since that would mean adding *more* SQL to categorie.pl I'm not sure that would be accepted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 21:40:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 19:40:54 +0000 Subject: [Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011 --- Comment #2 from Katrin Fischer --- Hm I think fixing a bug should be ok, but I haven't taken a closer look. It would be nice to have a module for categories, but I think that would be a rewrite out of the scope of this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 21:42:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 19:42:33 +0000 Subject: [Koha-bugs] [Bug 8747] clicking "repeat this tag" causes cursor to jump to top of page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8747 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Owen Leonard --- This bug is not present in 3.10.x and later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 23:19:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 21:19:50 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |mtompset at hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 23 23:28:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 21:28:42 +0000 Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27336|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 27503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27503&action=edit Bug 12068 - label-create-pdf.pl Add support for RTL language On top of Bug 8375 If you print a label using arabic/hebrew script, letters are printed in logical direction, from left to right, giving a mangled result This patch will try to fix those cases adding a new perl dependency, Text::Bidi, and using the automagic feature if it's log2vis() function to rearrange chars based on detected text 'direction' To test: 1. Install Text::Bidi package (apt-get install libtext-bidi-perl) 2. Try a batch, using Helvetica, with a mix of ltr and rtl (arabic/hebrew) titles, chars are good, but direction is bad NOTE: I suggest changing the mapping for 'HO' font on koha-conf.xml, from DejaVuSans-Oblique.ttf to DejaVuSans.ttf to view 'title' chars 3. Apply the patch 4. Try again, now the result is good Formerly a followup of Bug 8375, look sample pics on that Bug. Rebased following changes on Bug 8375 Note: Arabic titles will not be displayed, because current code selects Oblique variant (unless you change mapping as suggested on 2. ) Hebrew looks good. Rebased and move use of new dependency to Labels.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 00:19:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 22:19:08 +0000 Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 --- Comment #4 from Bernardo Gonzalez Kriegel --- When I run koha-qa, got something strange FAIL C4/Labels/Label.pm OK pod OK forbidden patterns FAIL valid Name "swig_runtime_data::type_pointer3" used only once: possible FAIL labels/label-create-pdf.pl OK pod OK forbidden patterns FAIL valid Name "swig_runtime_data::type_pointer3" used only once: possible typo Perhaps only my machine, can't understand :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 01:12:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 23:12:17 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 --- Comment #38 from Robin Sheat --- (In reply to Martin Renvoize from comment #37) > Yowsers, that was a long one. The downside of trying to do things as correct as possible is that it takes longer :) The upside is that this will probably keep working for the foreseeable future as I think it's probably the best solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 01:13:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 23:13:37 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 --- Comment #39 from Robin Sheat --- (In reply to Robin Sheat from comment #38) > longer :) The upside is that this will probably keep working for the > foreseeable future as I think it's probably the best solution. (until we get all the translations building with the packages, anyway.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 01:22:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Apr 2014 23:22:17 +0000 Subject: [Koha-bugs] [Bug 12130] Translations should live in /var not /usr for package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12130 --- Comment #1 from Robin Sheat --- I possibly think that this ought to be superseded by whatever bug it is somewhere that has the translations being built as part of the package building process. This'd involve a lot of careful migration that would probably be better having effort put into doing it with the packages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 02:05:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 00:05:40 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 02:05:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 00:05:43 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27489|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 27504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27504&action=edit Bug 12088 [Revised] Improve date handling and sorting in holds to pull report The holds to pull report could be improved by improving sorting on the title and date columns. This patch adds "anti-the" sorting to the title column and "title-string" sorting to the date column. Date formatting of another variable has been moved to the template for formatting using KohaDates. The patch includes other corrections for HTML validity. To test, apply the patch and view the holds to pull report. - Sorting by date should work correctly regardless of dateformat system preference setting. - Sorting of the title columns should correctly ignore articles. - Formatting of the "Reported on" date should be correct. Revision incorporates the corrections made by Bug 12127 and converts those changes to use class-based sorting. Signed-off-by: David Cook The patch works as described. Thanks for including and improving the changes from Bug 12127, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 02:39:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 00:39:09 +0000 Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 --- Comment #5 from Bernardo Gonzalez Kriegel --- Seems to be something related with Text::Bidi library, see http://www.cpantesters.org/cpan/report/cd6c2fe8-da0a-11e0-bbec-9aeec8b7ec30 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 02:40:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 00:40:23 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I quite like this idea (and this patch works well), but it should probably also include the following pages: opac-downloadshelf.pl opac-sendshelf.pl opac-addbybiblionumber.pl There might be others, but those are the ones that I've noticed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 02:41:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 00:41:04 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from David Cook --- Just marking this as failed, as it's not quite inclusive enough yet. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:11:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:11:09 +0000 Subject: [Koha-bugs] [Bug 12107] Move checkboxes jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12107 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:11:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:11:13 +0000 Subject: [Koha-bugs] [Bug 12107] Move checkboxes jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12107 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27294|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 27505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27505&action=edit Bug 12107 - Move checkboxes jQuery plugin outside of language-specific directory This patch moves the checkboxes jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. To test, apply the patch and confirm that select all/clear all controls continue to work on the following pages: - Acquisitions -> Late orders - Acquisitions -> Add to order from an external source (search targets) - Acquisitions -> Suggestions - Administration -> Funds -> Planning (show/hide all columns) * Some unused code has been removed - Administration -> Library transfer limits - Staff client cart - Authorities -> New from Z39.50 (search targets) - Cataloging -> New from Z39.50 (search targets) - Circulation -> Check out to a patron (renew/check in selections) - Circulation -> Offline circulation -> Pending operations - Patrons -> Patron detail (renew/check in selections) - Patrons -> Fines -> Pay fines - Serials -> Subscription -> Serial collection - Tools -> Label creator -> Batches -> Search results - Tools -> Patron card creator -> Batches -> Search results - Tools -> Tags moderation - Tools -> Batch item deletion - Tools -> Batch item modification - Tools -> Inventory -> Submit a batch of barcodes - Lists -> List contents view Signed-off-by: David Cook Works as described! I don't think I've ever checked so many boxes before... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:17:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:17:55 +0000 Subject: [Koha-bugs] [Bug 12101] Move Greybox library outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:17:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:17:59 +0000 Subject: [Koha-bugs] [Bug 12101] Move Greybox library outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27265|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 27506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27506&action=edit Bug 12101 - Move Greybox library outside of language-specific directory This patch moves the Greybox library to intranet-tmpl/lib so that it is not duplicated for each set of translated templates. The Greybox library files are called directly only by one include file, greybox.inc, which is modified by this patch. To test, apply the patch and view any page which calls the Greybox library and confirm that modal windows are still generated correctly. For instance, Cataloging -> Cataloging search, click the "Preview MARC" link. Signed-off-by: David Cook Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:24:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:24:04 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- I'm still seeing instances of "dt_add_type_uk_date" in circ/pendingreserves.tt serials/claims.tt serials/serials-search.tt serials/serials-collection.tt I think pendingreserves.tt has been taken care of by a different patch... bug 12088, I think. Should the rest be included here? When applying the Acquisitions patch, it did some auto-merging, so a rebase might be a good idea in any case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:25:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:25:29 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 --- Comment #8 from David Cook --- (In reply to David Cook from comment #7) > I'm still seeing instances of "dt_add_type_uk_date" in > > circ/pendingreserves.tt > serials/claims.tt > serials/serials-search.tt > serials/serials-collection.tt > > I think pendingreserves.tt has been taken care of by a different patch... > bug 12088, I think. Should the rest be included here? > > When applying the Acquisitions patch, it did some auto-merging, so a rebase > might be a good idea in any case. Ah, bug 11719 has those other ones covered. I'll keep going with this one then... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:25:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:25:59 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #11 from David Cook --- Leaving this one for Katrin to test as she already seems to be up on it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:27:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:27:57 +0000 Subject: [Koha-bugs] [Bug 12118] Unnecessary YUI assets included in offline circ manifest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I've never used the offline circulation methods. Can you use either the Firefox plugin or the desktop app? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:41:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:41:50 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11719, 12088 --- Comment #9 from David Cook --- Since this bug removes the dt_add_type_uk_date() function all together, I'm adding some dependencies. This patch should be pushed after those, since Koha will still rely on the dt_add_type_uk_date() function until all other instances of it have been removed. When those patches are pushed, this bug should clear out the remaining instances and remove the function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:41:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:41:50 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12089 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:41:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:41:50 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12089 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:57:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:57:55 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 --- Comment #3 from M. Tompsett --- Comment on attachment 27311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27311 [PATCH] Bug 12111: Improving templates regarding order notes Review of attachment 27311: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12111&attachment=27311) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/modordernotes.tt @@ +1,2 @@ > [% INCLUDE 'doc-head-open.inc' %] > +Koha › Acquisition › [% IF (type == "vendor") %]Change order vendor note vendor note[% ELSE %]Change order internal note[% END %] vendor note vendor note? I think that's wrong. Also, please consider using [%- and -%] as needed to make it more readable and still nicely output, rather than jamming it all onto one line. A minus beside the [% or %] prevents spacing from happening. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 03:59:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 01:59:31 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- There is no test plan. A thorough test plan speeds sign offs, Fr?d?rick. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:09:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:09:20 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:09:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:09:23 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27143|0 |1 is obsolete| | --- Comment #10 from David Cook --- Created attachment 27507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27507&action=edit Bug 12089 - [SIGNED OFF] Remove use of dt_add_type_uk_date() - Members This patch removes use of dt_add_type_uk_date() from the circulation history page and updates the sorting configuration according to current guidelines. The patch also makes corrections for HTML validity. To test, open the circulation history page for a patron with a history of checkouts. Confirm that the date, title, checkout date, due date, and return date columns sort correctly. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:09:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:09:59 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27507|0 |1 is obsolete| | --- Comment #11 from David Cook --- Created attachment 27508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27508&action=edit Bug 12089 - [SIGNED OFF] Remove use of dt_add_type_uk_date() - Members This patch removes use of dt_add_type_uk_date() from the circulation history page and updates the sorting configuration according to current guidelines. The patch also makes corrections for HTML validity. To test, open the circulation history page for a patron with a history of checkouts. Confirm that the date, title, checkout date, due date, and return date columns sort correctly. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:10:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:10:14 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27223|0 |1 is obsolete| | --- Comment #12 from David Cook --- Created attachment 27509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27509&action=edit Bug 12089 - [SIGNED OFF] Remove use of dt_add_type_uk_date() - Budgets This patch removes use of dt_add_type_uk_date() from the budgets administration page and updates the sorting configuration according to current guidelines. Date sorting is converted to the title-string method. Invalid "align" attribute is replaced with a class. Also corrected: Active tab selection based on class. To test, go to Administration -> Budgets and confirm that sorting works correctly on both the active and inactive budget tabs. Sorting by date should work correctly regardless of dateformat system preference. To test tab selection, append "?tab=2" to the page URL and confirm that the inactive budget tab is selected. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:10:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:10:23 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27224|0 |1 is obsolete| | --- Comment #13 from David Cook --- Created attachment 27510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27510&action=edit Bug 12089 [SIGNED OFF] [Revised] Remove use of dt_add_type_uk_date() - Circulation This patch removes instances of dt_add_type_uk_date() from there circulation templates and updates the sorting configuration according to current guidelines. To test, enable the UseTablesortForCirc system preference and open a patron for circulation who has multiple items checked out. Confirm that sorting by due date, title, and checkout date work correctly. Locate a patron who is guarantor to another or is guaranteed by another. One or both patrons should have checkouts. The "relatives checkouts" tab on the checkout page should sort correctly on due date, title, and checkout date. On the transfers to receive report, confirm that sorting by date of transfer and title work correctly for all tables. On the holds awaiting pickup report the "available since" and title columns should sort correctly for tables in both tabs (waiting and over). Revision: Missed an instance of dt_add_type_uk_date(). Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:10:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:10:33 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27260|0 |1 is obsolete| | --- Comment #14 from David Cook --- Created attachment 27511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27511&action=edit Bug 12089 - [SIGNED OFF] Remove use of dt_add_type_uk_date() - Acquisitions This patch removes instances of dt_add_type_uk_date() from acquisitions templates and updates sorting configurations according to current guidelines. In cases where a formatted date was passed from a Perl script, the script has been modified to pass an unformatted date. Several instances of the no longer valid align attribute have been removed from tags in favor of an existing "data" class which is suitable for display of currency values. To test, view the following pages in Acquisitions. Columns containing dates should sort correctly regardless of dateformat system preference setting. Columns containing bibliographic titles should ignore articles when sorting. - Add to an order from a staged file: The table of staged files should sort correctly. After clicking "add orders" for one of the staged files, the table of titles in that staged file should also be sorted correctly. - Add to an order from a subscription. The table of subscription search results should sort correctly. - Orders search results should sort correctly. - Late orders should sort correctly. - Search for a vendor. Click on the vendor name to view the vendor detail page. The table of contracts on this page should sort correctly. - From the Acquisitions home page click a number in the "spent" column of the table of available funds. The table of orders should sort correctly. - From the Acquisitions home page click a number in the "ordered" column of the table of available funds. The table of orders should sort correctly. - From a vendor detail page, click the "Receive shipments" button. On the receive shipments page the table of shipments should be sorted correctly. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:10:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:10:43 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27261|0 |1 is obsolete| | --- Comment #15 from David Cook --- Created attachment 27512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27512&action=edit Bug 12089 - [SIGNED OFF] Remove use of dt_add_type_uk_date() - JavaScript This patch removes the now unused dt_add_type_uk_date function from Koha's custom DataTables javascript file. To test, be sure all other patches on Bug 12089 are applied. Apply this patch and search for instances of dt_add_type_uk_date. There should be none. Signed-off-by: David Cook Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:18:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:18:02 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #21 from Robin Sheat --- (In reply to Jonathan Druart from comment #19) > Julian used Net::Server::Daemonize to fix an other issue in > tools/batchMod.pl. It is in production and it seems to work quite well. > > see > http://git.biblibre.com/?p=koha;a=commit; > h=1347281752d62dd370f6e4fae936def6d7630d5c I'm not sure that method would be totally safe, for the same reason that our current one has issues. Things like carrying the database handles around. I also don't like the idea of daemonising a starman process, it just seems dangerous. (In reply to Jacek Ablewicz from comment #20) > Looks like the plack/mod_perl related pitfall, when 2+ concurrently running > processes are sharing the same single DBI connection (a big no-no, DBI would > not work reliably if used that way). But - reading previous comments in this I thought about it a bit more, and realised why this was all of a sudden a problem: under CGI, the parent process ended immediately, so the child had the DBI handle all to itself. Now, it doesn't end immediately, and so next time it gets called on to do something, it's using the handle that is being used to do the import. > report, there may be some other unrelated/additional problems with > background jobs under plack as well (?). Maybe. I think it's OK, it's just that most of my failure to have it work is that it required more RAM than I had allocated to the VM. If we don't have a dedicated queuing daemon, there's no way around this. But I think a fork-and-exec will do for now, splitting the functions out into either another script, or changing the execution path so that it works just by execing itself. > Forked/background jobs - and plack workers etc. - would not be as memory > heavy (thanks to copy-on-write kernel feature) if we preload more C4/*, > Koha/* and CPAN modules at plack startup script. But right now, preloading That would be a good thing to do, though is a task for another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:18:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:18:36 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:18:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:18:40 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26417|0 |1 is obsolete| | --- Comment #6 from David Cook --- Created attachment 27513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27513&action=edit Bug 11769 [Follow-up] Use validation plugin when creating new MARC framework This follow up adds the correct "required" style to the required form fields as well as the "required" text after each required field. To test, apply all patches and go to Administration -> MARC bibliographic framework -> New framework. The framework code and description fields should show that they are required. Signed-off-by: David Cook Works as described and feels a million times better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:20:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:20:28 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27513|0 |1 is obsolete| | --- Comment #7 from David Cook --- Created attachment 27514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27514&action=edit Bug 11769 [Signed off][Follow-up] Use validation plugin when creating new MARC framework This follow up adds the correct "required" style to the required form fields as well as the "required" text after each required field. To test, apply all patches and go to Administration -> MARC bibliographic framework -> New framework. The framework code and description fields should show that they are required. Signed-off-by: David Cook Works as described and feels a million times better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:42:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:42:27 +0000 Subject: [Koha-bugs] [Bug 11724] Make Funds/Status on suggestions page sortable/searchable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:42:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:42:30 +0000 Subject: [Koha-bugs] [Bug 11724] Make Funds/Status on suggestions page sortable/searchable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 --- Comment #2 from David Cook --- Created attachment 27515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27515&action=edit [Signed off] Bug 11724 - Make Funds/Status on suggestions page sortable/searchable The fund and status columns on the suggestions page are not sortable or searchable. This patch makes them so. This patch also amends the DataTables configuration to use class-based targeting for sorting types as was decided on the koha-devel list. The table markup has been modified accordingly. To test you must have existing suggestions. Apply the patch and go to Acquisitions -> Suggestions. View the table of existing suggestions and confirm that the funds and status columns are sortable and searchable. Confirm that the title column correctly ignores articles when sorting. Signed-off-by: David Cook Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 04:44:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 02:44:55 +0000 Subject: [Koha-bugs] [Bug 11623] Errors with upgrade from 3.00.00.070 to 3.14.02.000 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11623 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- Probably we'll keep this around (and open) for posterity, but I suspect that we won't be fixing these issues. Thanks for adding your workarounds, they will probably help someone else someday! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 05:01:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 03:01:58 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #38 from David Cook --- (In reply to Jonathan Druart from comment #35) > Could it be possible to get some feedback on my proposed patches? The idea > was not to block the enh but to improve it! _One_ It appears that one of your patches includes the smart match operator, which is something we're avoiding due to its deprecated/experimental status in Perl 5.18, I believe. _Two_ Do you have a test plan to accompany your patches, Jonathan? It seems that the concept behind your patch and the original are at odds in that the original allows finer control of when the options appear. In yours, it appears that the options always show when viewing "more options" and only show when viewing "fewer options" if that option is included in the system preference. I think the idea was to choose between 3 scenarios: 1) Never show the option in advanced search 2) Show it when viewing "more" and "fewer" 3) Show it only when viewing "more" I think your patch only covers scenarios #2 and #3. Is that correct? I'm not a huge fan of governing this behaviour using system preferences, but I think I prefer the 3 choices rather than 2. _Three_ I think Owen has been making an effort to move the Javascript libraries out of the /en/ directory and put it higher up so that it isn't needlessly duplicated in the translations, so it would probably make sense to move the JS higher up the directory tree. _Four_ I think there might be another bug out there that seeks to add multiple options for system preferences...but I might be mistaken. _Five_ It looks like this patch will need to rebase due to the updatedatabase.pl being too old now. --- I hope that helps! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 05:01:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 03:01:59 +0000 Subject: [Koha-bugs] [Bug 12016] After upgrading, APACHE is running but browser cannot connect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12016 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- If it comes to it, you can simply mark the bug as resolved. :) This sounds pretty unlike anything I've heard of before - what version were you coming from? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 05:15:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 03:15:48 +0000 Subject: [Koha-bugs] [Bug 9108] Add uk/euro date sort filter to pages which require it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #22 from David Cook --- I'm closing this one, since it was pushed to master ages ago, and is now out of date in light of some of Owen's latest DataTable patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 05:15:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 03:15:48 +0000 Subject: [Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508 Bug 9508 depends on bug 9108, which changed state. Bug 9108 Summary: Add uk/euro date sort filter to pages which require it http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 05:15:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 03:15:48 +0000 Subject: [Koha-bugs] [Bug 9349] Saved reports: sort broken on creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9349 Bug 9349 depends on bug 9108, which changed state. Bug 9108 Summary: Add uk/euro date sort filter to pages which require it http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 05:20:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 03:20:14 +0000 Subject: [Koha-bugs] [Bug 12016] After upgrading, APACHE is running but browser cannot connect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12016 JB changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 05:28:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 03:28:45 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- I like the idea of emailing the print notices, but I'm not sure that I like the idea of using a parameter to achieve this. Wouldn't it be a better idea to send the email to the pick-up library, and failing that the KohaAdminEmailAddress? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 05:29:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 03:29:29 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 --- Comment #5 from David Cook --- (In reply to David Cook from comment #4) > I like the idea of emailing the print notices, but I'm not sure that I like > the idea of using a parameter to achieve this. > > Wouldn't it be a better idea to send the email to the pick-up library, and > failing that the KohaAdminEmailAddress? I say this in part because it seems like needless duplication/maintenance to specify a library email address in the cronjob when it's already available to Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 06:12:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 04:12:20 +0000 Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- The logic in this patch makes little sense, and is invalid XSL in some cases. In regards to the XSL, there are two elements in the element. There should be only one as it is the default "otherwise" condition. The first "otherwise" condition in these XSLTs is useless, so I'd just delete it all together. The test for "$UseControlNumber = '0'" is counter-productive in that it functions as a de facto "otherwise" which means the test for "marc:subfield[@code='0']" will never be triggered. The final "otherwise" is also useless as it is missing its href attribute. The tests for "marc:subfield[@code='t']" are problematically placed in almost every case well. Rather than salvage this patch, I would suggest starting again with the existing 773 as a model. I added the 787 to our local XSLT a while ago. Perhaps I'll add an alternative patch when I work on porting some other customizations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 06:26:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 04:26:36 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I really like the idea of this patch! It seems like it would make it a lot easier to do development on serials this way! I'm curious about your follow-up. Are there are a few more places that the constants could be used in that SQL? "AND (serial.STATUS IN ($missing_statuses_string) OR ((planneddate < now() AND serial.STATUS =1) OR serial.STATUS = 3 OR serial.STATUS = 7))" Couldn't 1, 3, and 7 be exchanged a variable containing the value from the constant? I don't use serials very often, so I might let someone else with more experience with the workflow try this one out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 06:31:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 04:31:02 +0000 Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #6 from David Cook --- I'm setting this one to In Discussion due to the discussion in bug 11169 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 06:35:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 04:35:12 +0000 Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #25 from David Cook --- (In reply to Galen Charlton from comment #23) > Is a separate tab really necessary? > > If the goal is to give patron information that new items are coming, I think > it sufficient to: > > - display an on-order status in the OPAC holdings tab if items are creating > during ordering > - display a statement saying "X items are on order" (or "X items are on > order as of $date" to take bug 11847 into account). > > Setting to in discussion Agreed. I think that this or something similar would be all that is necessary. Furthermore, I don't really like the idea of having an "acquisitions details" tab as it doesn't seem very user centred in design. As a library patron, I might not understand or want to understand anything related to "acquisitions". I just want to know if an item is on order, and when it's going to arrive/when the order was placed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 06:51:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 04:51:53 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from David Cook --- When I try applying just the patches for 11559 without first applying the patches from 10486, it still just stays stuck at the "Loading, please wait..." screen. When I try applying the patches from 10486 then 11559, I get merge conflicts. It looks like whitespace conflicts in C4/XSLT.pm. Should 10486 be added to this bug's "Depends on"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 06:56:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 04:56:31 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #52 from David Cook --- I think updatedatabase.pl needs an update. The web installer isn't being triggered after applying the patches. I might take a look at yaz again... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 07:09:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 05:09:58 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #53 from Jesse Weaver --- (In reply to David Cook from comment #52) > I think updatedatabase.pl needs an update. The web installer isn't being > triggered after applying the patches. > > I might take a look at yaz again... The web installer won't be triggered after applying patches unless kohaversion.pl is changed, which doesn't happen until the RM pushes the patch. In cases like this, you have to run updatedatabase.pl manually, unfortunately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 07:11:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 05:11:24 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #22 from Jesse Weaver --- (In reply to David Cook from comment #21) > When I try applying just the patches for 11559 without first applying the > patches from 10486, it still just stays stuck at the "Loading, please > wait..." screen. > > When I try applying the patches from 10486 then 11559, I get merge > conflicts. It looks like whitespace conflicts in C4/XSLT.pm. > > Should 10486 be added to this bug's "Depends on"? Could I ask you to open up a web console/Firebug and look for a relevant error message when you get stuck at the Loading screen? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 07:14:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 05:14:50 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #12 from Katrin Fischer --- Ah, please don't - then I can come back to do QA ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 07:46:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 05:46:14 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #240 from Katrin Fischer --- I am sorry Jonathan, but I still can't get it to work on Accounting details. :( I have tried it with and without bug 10875 applied. Some more information with 10875 applied: - with the patch for 10875 I only have 1 fund: Books, it's got: Statistic 1: no authority category Statistic 2: CCODE - when I open the staged order list and go straight to the Accounting details tab the fund pull down shows: Select fund But: Statistic 2 already shows CCODE? - when I switch to the only other option: select funds - nothing changes - when I check the checkbox to display the other funds and switch to the other funds showing up, the display of Statistic 2 still won't change Without 10875 applied: - Page also shows select fund + statistic 2: ccode from the beginning - Switching the funds won't change it Maybe it somehwo still picks the values of the first fund in the list and then fails to reset it? For a test I created another fund in the active budget, I named it Bbooks, to make sure it sorts first and before Books: - Statistic 1: no authority category - Statistic 2: CCODE - when I open the staged order list now and goto the Accounting tabs both statistic values show as empty, no fund is selected yet - switching around works Hope that helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 07:50:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 05:50:23 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #54 from Katrin Fischer --- Jesse accidentally left in a version number in the updatedatabase. If you fix that to XXX it should be ok. I will give it a try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 07:54:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 05:54:33 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #55 from Katrin Fischer --- Ah ok, misread the commit a bit even - it just needs a nudge from 13 to 15. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 07:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 05:56:52 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #56 from David Cook --- Setting up pazpar2 is definitely a bit of a pain if you're not using Debian/Ubuntu :/. I'm using an old version of yaz (4.2.13 from 2011) on my dev system, so I had to go pretty far back to get something that I could even configure. I suppose it's a bit of a moot point that Debian's Wheezy repo has yaz 4.2.30 (from 2012) in it, since the pazpar2 packages from IndexData must upgrade one's yaz packages as well. I suppose the thing to do is just update my yaz, but it would be good to know what version of yaz and pazpar2 a person needs to get this feature to work, since we're not all using Debian/Ubuntu. In fact, there probably should be some automated checking to make sure that Koha has the right versions of yaz and pazpar2 available, otherwise this feature will just bust, no? Do we keep track of version dependencies on anything besides Perl modules? Going forward, we'll probably want to do that with yaz and pazpar2... pazpar2-1.6.32.tar.gz 14-Jun-2013 09:27 1.0M Requires YAZ 4.2.58 or later pazpar2-1.6.23.tar.gz 02-Jan-2013 12:09 889K Requires YAZ 4.2.40 or later pazpar2-1.6.22.tar.gz 11-Oct-2012 08:10 890K Requires YAZ 4.2.40 or later pazpar2-1.6.21.tar.gz 24-Sep-2012 18:08 856K Requires YAZ 4.2.20 or later pazpar2-1.6.20.tar.gz 21-Sep-2012 13:27 882K Requires YAZ 4.2.20 or later pazpar2-1.6.18.tar.gz 17-Sep-2012 11:40 860K Requires YAZ 4.2.20 or later pazpar2-1.6.15.tar.gz 27-Jun-2012 10:17 842K Requires YAZ 4.2.20 or later pazpar2-1.6.10.tar.gz 23-Feb-2012 10:52 786K Requires YAZ 4.2.20 or later pazpar2-1.6.5.tar.gz 02-Nov-2011 10:25 1.5M Requires YAZ 4.2.18 or later pazpar2-1.6.4.tar.gz 28-Oct-2011 10:31 1.5M Requires YAZ 4.2.17 or later pazpar2-1.6.3.tar.gz 22-Sep-2011 11:08 1.5M Finally found one that works for 4.2.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 07:58:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 05:58:37 +0000 Subject: [Koha-bugs] [Bug 12132] New: Show guarantees in staff patron details too Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Bug ID: 12132 Summary: Show guarantees in staff patron details too Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 27516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27516&action=edit Show guarantees in staff patron details too For some reason, guarantees are not shown in patron details, if the patron is a staffer. Attached patch fixes that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:00:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:00:40 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think that's because patrons with the staff category are not supposed to have children currently - I think this probably needs more than a display fix. Would also require changing documentation etc. We favor that the staff account should not be identical with the personal account for a staff member, so keep it separate. But there is bug 6922 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:01:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:01:41 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #2 from Katrin Fischer --- I think one of the things to check is that you can actually search for a guarantor that is a staff member - if you do it the other way around and create a 'child' first and then link it to the 'adult'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:05:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:05:16 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #57 from David Cook --- Manually ran updatedatabase.pl which worked, so I was able to add an external search target. Yay! When I tried searching in the OPAC, nothing happened, which is good, since I haven't set up pazpar2 yet. I'll have to set up pazpar2 on another dev setup when I have a chance... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:09:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:09:07 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #58 from Katrin Fischer --- 2 things found in testing: - The 856 links on the result page are not working for me. It tries to create a Koha internal link (major) - Taking a look at Firebug when the page loads, I can see that it always loads something UNIMARC and NORMARC too - is that on purpose? Should it only load the files for your current marcflavour? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:12:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:12:28 +0000 Subject: [Koha-bugs] [Bug 12133] New: Guarantor requirements when registering a patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Bug ID: 12133 Summary: Guarantor requirements when registering a patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 27517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27517&action=edit Add two requirements when registering a new patron Attached patch adds two new requirements when registering a new patron: - A child patron must have a guarantor. - A guarantor cannot be a guarantee. Both of these stem from legal requirements in Finland - these might not be applicable for everywhere, so perhaps a syspref to control one, or both, might be in order? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:15:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:15:18 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #59 from Katrin Fischer --- Giving an example for the links: Result list: Online Access: Inhaltsverzeichnis [Inhaltsverzeichnis = table of contents] http://localhost/cgi-bin/koha/opac-external-search.pl?q=bodensee# Detail page: Online resources: Inhaltsverzeichnis http://d-nb.info/1037370899/04 I wonder... the results page does not look quite right - having the different label? An URL in a record is not always online access, like in this case, so I'd prefer the wording from the detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:34:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:34:02 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #3 from paxed --- (In reply to Katrin Fischer from comment #2) > I think one of the things to check is that you can actually search for a > guarantor that is a staff member - if you do it the other way around and > create a 'child' first and then link it to the 'adult'. Yes, you can. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:38:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:38:49 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #4 from paxed --- (In reply to Katrin Fischer from comment #1) > I think that's because patrons with the staff category are not supposed to > have children currently - I think this probably needs more than a display > fix. Would also require changing documentation etc. > > We favor that the staff account should not be identical with the personal > account for a staff member, so keep it separate. > > But there is bug 6922 The current behaviour is completely inconsistent: Change a patron's type from adult to staff, and their guarantees aren't showing up in the patron details. If the patron has guarantees, those should be shown, no matter what the patron's type is. If you use separate accounts for staff use and personal use, then your staff account shouldn't have the guarantees. But some other places might not do that kind of separation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:39:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:39:38 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:47:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:47:12 +0000 Subject: [Koha-bugs] [Bug 12131] C4/TmplToken.pm has an unnecessary dependency on Exporter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 08:47:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 06:47:14 +0000 Subject: [Koha-bugs] [Bug 12131] C4/TmplToken.pm has an unnecessary dependency on Exporter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27477|0 |1 is obsolete| | --- Comment #2 from M. de Rooy --- Created attachment 27518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27518&action=edit Bug 12131: Remove unused dependency on Exporter C4::TmplToken depends on Exporter but does not use any of its facilities. Removed the dead code so it does not clog up the source and waste compilation time Signed-off-by: Marcel de Rooy Module still compiles correctly; t/TmplToken.t passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 09:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 07:20:05 +0000 Subject: [Koha-bugs] [Bug 12115] Follow up fix for tools/inventory.pl's output_pref issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 09:20:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 07:20:07 +0000 Subject: [Koha-bugs] [Bug 12115] Follow up fix for tools/inventory.pl's output_pref issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27352|0 |1 is obsolete| | --- Comment #2 from M. de Rooy --- Created attachment 27519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27519&action=edit Bug 12115 - Follow up fix for tools/inventory's output_pref issues This should correct issues with the output_prefs in the compareinv2bar logic section of tools/inventory.pl It is a follow up to bug 11253. TEST PLAN --------- NOTE: There should be no distinguishable difference before and after the patch. This corrects a works by accident bug. Back up DB. Create a small barcode file from books in a given branch. Set I18N/L10N system preference of dateformat to mm/dd/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in mm/dd/yyyy format. Set I18N/L10N system preference of dateformat to yyyy-mm-dd. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in yyyy-mm-dd format. Set I18N/L10N system preference of dateformat to dd/mm/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in dd/mm/yyyy format. Apply patch Restore DB (so results should be comparable to the first result) Repeat the three testing blocks above. There should be no visible difference. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 09:20:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 07:20:37 +0000 Subject: [Koha-bugs] [Bug 12115] Follow up fix for tools/inventory.pl's output_pref issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 09:24:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 07:24:28 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #23 from David Cook --- (In reply to Jesse Weaver from comment #22) > (In reply to David Cook from comment #21) > > When I try applying just the patches for 11559 without first applying the > > patches from 10486, it still just stays stuck at the "Loading, please > > wait..." screen. > > > > When I try applying the patches from 10486 then 11559, I get merge > > conflicts. It looks like whitespace conflicts in C4/XSLT.pm. > > > > Should 10486 be added to this bug's "Depends on"? > > Could I ask you to open up a web console/Firebug and look for a relevant > error message when you get stuck at the Loading screen? Sure thing, mate. Here are the messages I get: Uncaught ReferenceError: humanMsg is not defined editor.pl:1335 Uncaught TypeError: undefined is not a function xslt.js:35 event.returnValue is deprecated. Please use the standard event.preventDefault() instead. jquery.js:3 3 Uncaught TypeError: undefined is not a function xslt.js:35 -- I'm also getting a 404 for intranet-tmpl/prog/en/lib/jquery/plugins/humanmsg.js, which is probably causing at least one of those errors... It looks like the actual path is: koha-tmpl/intranet-tmpl/lib/jquery/plugins/humanmsg.js -- Btw, I'm getting these messages when I'm applying the patches: warning: 3 lines add whitespace errors. Using index info to reconstruct a base tree... :155: trailing whitespace. // :8576: trailing whitespace. :9156: trailing whitespace. warning: 3 lines applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Removing koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.lightbox_me.js Removing koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.hotkeys.min.js Auto-merging koha-tmpl/intranet-tmpl/lib/jquery/plugins/humanmsg.js Removing koha-tmpl/intranet-tmpl/lib/codemirror/lib/runmode.js Removing koha-tmpl/intranet-tmpl/lib/codemirror/codemirror.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 09:30:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 07:30:23 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 09:30:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 07:30:28 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27451|0 |1 is obsolete| | --- Comment #241 from Jonathan Druart --- Created attachment 27520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27520&action=edit Bug 7180: Reset statistic values on reloading the page On the "Default accounting details", if a dropdown list was created for a statistic value, on reloading the page it still exist. It should not given the fund value is reset. The CGIsort variable is useless and can be remove: the dropdown list is generated using the ajax call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 09:31:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 07:31:00 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27425|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 27521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27521&action=edit Bug 10875: Add order from a staged file should not display inactive funds When adding an order from a staged file, a link "show all funds" is now added on the top of the page. All inactive funds are hidden by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 09:32:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 07:32:05 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #242 from Jonathan Druart --- (In reply to Katrin Fischer from comment #240) > I am sorry Jonathan, but I still can't get it to work on Accounting details. > :( Ok, got it! I amended the last patch and the behavior should be correct now. > Hope that helps. Yes, very helpful, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 10:15:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 08:15:51 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26478|0 |1 is obsolete| | Attachment #26492|0 |1 is obsolete| | Attachment #26834|0 |1 is obsolete| | --- Comment #10 from paxed --- Created attachment 27522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27522&action=edit Make i18n toolchain ignore useless strings This is slightly improved version of bgkriegel's patch. -Punctuation is matched with POSIX character class [:punct:] instead of listing everything separately. -HTML entities are also matched - those are not meant to be translated anyway, and are mostly non-breaking spaces or quotes anyway. Test as per bgkriegel's patch above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 11:36:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 09:36:46 +0000 Subject: [Koha-bugs] [Bug 11685] GetSupportName and GetSupportList do not split AdvancedSearchTypes by pipe In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11685 --- Comment #1 from paxed --- In addition to GetSupportName(), GetSupportList() in C4/Koha.pm, also opac/opac-topissues.pl handles the syspref wrongly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 12:28:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 10:28:58 +0000 Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at pttk.fi |ity.org | --- Comment #3 from paxed --- Created attachment 27523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27523&action=edit Allow translating the subscription frequency units in the template Allow translating the subscription frequency units. To test, 1) cd misc/translator 2) perl translate update xx-YY 3) check that there's no msgid that contains the subscription frequencies (day, week, month and year) in po/xx-YY-i-staff-t-prog-v-3006000.po (search for "BLOCK translate_frequnit") 4) apply patch 5) perl translate update xx-YY 6 check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the msgid for the frequencies. (search for "BLOCK translate_frequnit") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:05:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:05:12 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #39 from Jonathan Druart --- (In reply to David Cook from comment #38) Thanks David to revive this bug! > It appears that one of your patches includes the smart match operator, which > is something we're avoiding due to its deprecated/experimental status in > Perl 5.18, I believe. Will be fixed. > Do you have a test plan to accompany your patches, Jonathan? Will be added. > In yours, it > appears that the options always show when viewing "more options" and only > show when viewing "fewer options" if that option is included in the system > preference. > I think your patch only covers scenarios #2 and #3. Is that correct? Yes, good catch. I will add a new pref for that. > I'm not a huge fan of governing this behaviour using system preferences, but > I think I prefer the 3 choices rather than 2. I don't see another way to do that. > I think Owen has been making an effort to move the Javascript libraries out > of the /en/ directory and put it higher up so that it isn't needlessly > duplicated in the translations, so it would probably make sense to move the > JS higher up the directory tree. At the OPAC, not at the staff interface. > I think there might be another bug out there that seeks to add multiple > options for system preferences...but I might be mistaken. Not sure. If someone agree with my patches, I think the first patch should be abandoned. Otherwise, We are going to create 6 prefs and remove them just after. > It looks like this patch will need to rebase due to the updatedatabase.pl > being too old now. Will be rebased. > I hope that helps! Of course! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:07:16 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21643|0 |1 is obsolete| | Attachment #21644|0 |1 is obsolete| | Attachment #21645|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 27524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27524&action=edit [ALT 1/3] Bug 9043: Syspref improvement: add new type "multiple" This patch adds a new type "multiple" for syspref. This new type allows to select several values for one syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:07:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:07:27 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #41 from Jonathan Druart --- Created attachment 27525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27525&action=edit [ALT 2/3] Bug 9043: Add the dropdown check list jquery plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:07:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:07:35 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #42 from Jonathan Druart --- Created attachment 27526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27526&action=edit [ALT 3/3] Bug 9043: Changes to the advanced search page This patch adds 2 new sysprefs: OpacAdvSearchOptions and OpacAdvSearchMoreOptions. These sysprefs are multivalued and you can add or remove some elements on the adv search page. This patch allows to display/hide some entries in the advanced search page at the OPAC. On this way, it is possible to configure the search options to display. Test plan: 1/ Fill OpacAdvSearchOptions with Item types and Languages. Fill OpacAdvSearchMoreOptions with Item types, Languages and Location. On the advanced search page, verify the Location is only displayed for the "More options" view. 2/ Try different settings for these prefs 3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that the "More options" does not displayed additional options. 4/ Remove all entries for the OpacAdvSearchOptions and verify that the "normal view" does not displayed any options. Note that this patch only affects the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:34:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:34:16 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27522|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 27527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27527&action=edit [SIGNED_OFF] Bug 11631: Make i18n toolchain ignore useless strings Signed-off-by: Bernardo Gonzalez Kriegel Works as described, 380 strings less to 'translate' No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:36:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:36:56 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:45:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:45:57 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:45:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:45:59 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27472|0 |1 is obsolete| | Attachment #27473|0 |1 is obsolete| | --- Comment #11 from M. de Rooy --- Created attachment 27528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27528&action=edit Bug 10833: Multi transport types for advanced notices Test plan: - Choose 2 patrons P1 and P2 - Edit "Patron messaging preferences" and check SMS + email with 2 days in advance for P1 check email with 5 days in advance for P2 - defined a message for the letter code PREDUE for sms and email (tools/letters.pl). - select 2 barcodes (B1, B2). * checkout B1 to P1 with a due date = NOW - 2 days * checkout B2 to P2 with a due date = NOW - 5 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/advance_notices.pl -c - retry the previous sql query, you should have X + 3 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code PREDUE 1 message for P2, email and the letter code PREDUE Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:46:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:46:04 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 --- Comment #12 from M. de Rooy --- Created attachment 27529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27529&action=edit Bug 10833: Enhanced a warning message to include the message transport type in the message. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:46:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:46:38 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:48:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:48:05 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 --- Comment #13 from M. de Rooy --- Can generate this error with a missing notice for sms: No circulation PREDUE letter transported by sms at /usr/share/koha/testclone/C4/Letters.pm line 455. no letter of type 'PREDUE' found. Please see sample_notices.sql at misc/cronjobs/advance_notices.pl line 293. Two warnings are better than zero. But it seems to be redundant :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 13:50:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 11:50:07 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 --- Comment #14 from M. de Rooy --- Just a note: I tested this on top of 9016, 10845 and 10832. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:03:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:03:27 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:03:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:03:29 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25070|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 27530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27530&action=edit Bug 11696: The print notices should be processed in first This reorder avoids to sent a print notice with an email or sms template is no email or sms is defined. Test plan: Check print, sms and email for an overdue rule Don't define an email address and generate an overdue for a user Define 3 templates for the notice used Launch the cronjob script and verify the print notice is generated using the print template. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:04:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:04:20 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:05:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:05:34 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 --- Comment #5 from M. de Rooy --- (In reply to Olli-Antti Kivilahti from comment #3) > Pretty slick solution! This solution works. But I think that in terms of QA and maintenance it is not the most elegant one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:31:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:31:39 +0000 Subject: [Koha-bugs] [Bug 12118] Unnecessary YUI assets included in offline circ manifest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 --- Comment #3 from Owen Leonard --- This bug is relevant only to the "Built-in offline circulation interface" (circ/offline.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:32:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:32:54 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 --- Comment #16 from Owen Leonard --- Thanks for testing David, and for adding the dependencies to the bug report where they belong (instead of just in my head). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:37:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:37:21 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #1 from Owen Leonard --- (In reply to paxed from comment #0) > so perhaps a syspref to control one, or both, > might be in order? My library would definitely want a system preference to control the first option (child must have a guarantor). The second option seems like simple logic to me, but I've learned not to trust my sense of logic in these matters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:44:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:44:30 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #24 from Owen Leonard --- (In reply to David Cook from comment #23) > It looks like the actual path is: > koha-tmpl/intranet-tmpl/lib/jquery/plugins/humanmsg.js Yes, but just since Bug 12102 got pushed a few days ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:51:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:51:08 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:51:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:51:57 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #40 from Galen Charlton --- Pushed to master. Thanks, Tom?s and Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:55:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:55:32 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #16 from Chris Cormack --- Created attachment 27531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27531&action=edit Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:55:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:55:53 +0000 Subject: [Koha-bugs] [Bug 12118] Unnecessary YUI assets included in offline circ manifest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27367|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 27532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27532&action=edit Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. Signed-off-by: Chris Cormack http://bugs.koha-community.org/show_bug.cgi?id=11218 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:55:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:55:51 +0000 Subject: [Koha-bugs] [Bug 12118] Unnecessary YUI assets included in offline circ manifest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 14:56:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 12:56:21 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27531|0 |1 is obsolete| | CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:11:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:11:51 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:11:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:11:53 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27521|0 |1 is obsolete| | --- Comment #15 from Owen Leonard --- Created attachment 27533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27533&action=edit [SIGNED-OFF] Bug 10875: Add order from a staged file should not display inactive funds When adding an order from a staged file, a link "show all funds" is now added on the top of the page. All inactive funds are hidden by default. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:13:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:13:34 +0000 Subject: [Koha-bugs] [Bug 11481] new reservation syspref HoldOnlyWhenAllItemsOnLoan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED --- Comment #9 from Koha Team Lyon 3 --- I drop this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:14:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:14:39 +0000 Subject: [Koha-bugs] [Bug 11482] new reservation syspref PickupHoldOnlyFromItemBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #5 from Koha Team Lyon 3 --- I drop this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:15:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:15:25 +0000 Subject: [Koha-bugs] [Bug 11986] Tags searching doesn't work in OPAC if biblio DOM indexing is being used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:15:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:15:27 +0000 Subject: [Koha-bugs] [Bug 11986] Tags searching doesn't work in OPAC if biblio DOM indexing is being used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26528|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 27534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27534&action=edit Bug 11986 - Tags searching doesn't work in OPAC if biblio DOM indexing is being used This patch fixes the following issue: in installations that are using zebra DOM indexing for bibliographic records, tag searching in OPAC doesn't work properly (clicking on any tag in OPAC leads to "404 error"). To test: ensure that with patch applied: 1) problems with tag searching get resolved for [some] test configuration with biblio DOM indexing enabled, 2) there are no apparent tag-searching-related regressions in OPAC, in some yet another test installation configured with legacy (grs1) indexing mode for biblios. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:19:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:19:40 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:19:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:19:42 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27145|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 27535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27535&action=edit Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:22:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:22:50 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27103|0 |1 is obsolete| | --- Comment #18 from Owen Leonard --- Created attachment 27536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27536&action=edit [SIGNED-OFF] Bug 10823 - add class info to enumchron data in detail.tt, for better styling Bug 10825 removes a duplicate (enumchron==serialseq). This patch was developed on top of it. It properly styles the elements. These include: - items.enumchron - the separator used - serial.serialseq - items.publisheddate As per Katrin's and Owen's suggestion, was used instead of
    . (See comment #7 and http://irc.koha-community.org/koha/2014-04-03#i_1491135) TEST PLAN --------- 1) Apply patch 10825 2) Find a biblio where the enumchron and serialseq are different. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 3) In the staff client, view the source for that item. -- It should be one class for the entire cell. 4) Apply patch 10823 5) Refresh the page 6) Look at the source for that item again. -- It should have tags around the 4 things listed above. 7) Run the koha qa test tools. Signed-off-by: Mark Tompsett NOTE: Since there was lots of squashing and rebasing, could you please test and sign this off as well, Mason? Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:22:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:22:48 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:25:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:25:52 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 --- Comment #6 from Jonathan Druart --- (In reply to David Cook from comment #5) > I say this in part because it seems like needless duplication/maintenance to > specify a library email address in the cronjob when it's already available > to Koha. Yes, maybe it could be done later, if someone wants. The need was not to sent an email to the library email address defined into Koha but to several other emails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 15:26:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 13:26:50 +0000 Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for serials. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:01:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:01:21 +0000 Subject: [Koha-bugs] [Bug 10098] Inactive Funds are still showing in Acquisitions Order screen in Internet Explorer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10098 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Browser compatibility Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | --- Comment #1 from Owen Leonard --- It works correctly in IE11, FWIW. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:07:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:07:27 +0000 Subject: [Koha-bugs] [Bug 9955] Partly broken local cover image uploading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9955 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Version|unspecified |3.10 Resolution|--- |INVALID --- Comment #5 from Owen Leonard --- This report is over a year old now and I've not heard any confirmation for this problem, nor can I reproduce it. I'm guessing it was a local configuration issue, but if the problem persists and is reproducible please re-open the report with new details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:23:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:23:42 +0000 Subject: [Koha-bugs] [Bug 11992] detail.pl display issue after item on hold & in transit is checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11992 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|trivial |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:24:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:24:20 +0000 Subject: [Koha-bugs] [Bug 11991] "Item is already waiting" message after in-transit item on hold checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11991 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:32:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:32:04 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24773|0 |1 is obsolete| | Attachment #24774|0 |1 is obsolete| | Attachment #24775|0 |1 is obsolete| | Attachment #24776|0 |1 is obsolete| | Attachment #25008|0 |1 is obsolete| | Attachment #25584|0 |1 is obsolete| | Attachment #25586|0 |1 is obsolete| | --- Comment #63 from Kyle M Hall --- Created attachment 27537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27537&action=edit Bug 9303 [1] - relative's checkouts in the opac - Schema Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:32:19 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #64 from Kyle M Hall --- Created attachment 27538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27538&action=edit Bug 9303 [2] - relative's checkouts in the opac - Database Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:32:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:32:22 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #65 from Kyle M Hall --- Created attachment 27539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27539&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Joel Sasse Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:32:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:32:24 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #66 from Kyle M Hall --- Created attachment 27540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27540&action=edit Bug 9303 [QA Followup] - Set AUTO_INCREMENT value for issues.issue_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:32:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:32:27 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #67 from Kyle M Hall --- Created attachment 27541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27541&action=edit Bug 9303 [QA Followup 2] - Undo changes to GetReserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:32:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:32:29 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #68 from Kyle M Hall --- Created attachment 27542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27542&action=edit Bug 9303 [QA Followup 3] - Add borrowerRelationship syspref check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:32:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:32:31 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #69 from Kyle M Hall --- Created attachment 27543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27543&action=edit Bug 9303 [QA Followup 4] - Syspref the feature for staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:32:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:32:57 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 16:51:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 14:51:12 +0000 Subject: [Koha-bugs] [Bug 11685] GetSupportName and GetSupportList do not split AdvancedSearchTypes by pipe In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11685 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:15:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:15:40 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack --- Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc Auto-merging catalogue/search.pl CONFLICT (content): Merge conflict in catalogue/search.pl Auto-merging C4/Languages.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:21:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:21:59 +0000 Subject: [Koha-bugs] [Bug 12134] New: Members are restricted even if the debarment is ended Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Bug ID: 12134 Summary: Members are restricted even if the debarment is ended Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Introduced by bug 2720. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:22:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:22:26 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12134 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:22:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:22:26 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2720 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:22:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:22:50 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:24:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:24:23 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:24:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:24:25 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 --- Comment #1 from Kyle M Hall --- Created attachment 27544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27544&action=edit Bug 12134 - Members are restricted even if the debarment is ended Test Plan: 1) Modify borrowers.debarred for a borrower and set the date in the past 2) Try to check out an item to that patron 3) Note you cannot 4) Apply this patch 5) Repeat step 2 6) Note you can now check out items the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:24:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:24:34 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- The second patch does not apply Applying: Bug 11317: Follow up - Update ID to allow for permalinking fatal: sha1 information is lacking or useless (reports/report_files.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:25:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:25:20 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Templates Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:30:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:30:40 +0000 Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:30:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:30:42 +0000 Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27523|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 27545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27545&action=edit Bug 11588: Untranslatable subscription frequency units Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:36:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:36:58 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #91 from Kyle M Hall --- (In reply to Heather Braum from comment #86) > Select renewal isn't rare at circulation desks. Asking a librarian to > refresh a page for each select renewal -- especially when there's three or > more select renewals, is not good practice. > > I haven't had a chance to see this development in action yet, so I'm basing > my comments and concerns on the descriptions, but I would hate for the > system to lose the multiple select renewal option. Heather, I think you mis-understood the issue. You don't have to reload the page to renew multiple items. You would need to reload the page to renew one item multiple times! If a patron has 20 items checked out, you are still able to renew them all with a couple clicks. Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:38:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:38:40 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27544|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 27546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27546&action=edit Bug 12134 - Members are restricted even if the debarment is ended Test Plan: 1) Modify borrowers.debarred for a borrower and set the date in the past 2) Try to check out an item to that patron 3) Note you cannot 4) Apply this patch 5) Repeat step 2 6) Note you can now check out items the patron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:38:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:38:37 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:38:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:38:45 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 --- Comment #3 from Jonathan Druart --- Created attachment 27547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27547&action=edit Bug 12134: Add unit tests to reflect the change in IsDebarred Before Kyle's patch, the test failed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:39:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:39:44 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:39:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:39:47 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #92 from Kyle M Hall --- Created attachment 27548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27548&action=edit Bug 11703 [QA Followup] - Fix unterminated string literal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:42:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:42:15 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Good candidate for 3.14.6! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:49:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:49:47 +0000 Subject: [Koha-bugs] [Bug 11497] i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:49:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:49:49 +0000 Subject: [Koha-bugs] [Bug 11497] i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26801|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 27549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27549&action=edit Bug 11497 - i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation i18n toolchain fails to pick text defined inside [% ... %] This patch fixes all the cases I could find To test: 1. Update your preferred language (cd misc/translator; perl translate update fi-FI) 2. Count headers for example egrep "^msgid.*Koha online" misc/translator/po/fi-FI-* | wc -l 3. Apply the patch 4. Repeat 1 and 2, now there are more lines Or translate to some lang and visit every touched page and look the title Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 17:55:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 15:55:48 +0000 Subject: [Koha-bugs] [Bug 9724] Hourly loans don't show time due in SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9724 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 18:02:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 16:02:53 +0000 Subject: [Koha-bugs] [Bug 9724] Hourly loans don't show time due in SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9724 --- Comment #1 from Owen Leonard --- Created attachment 27550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27550&action=edit Bug 9724 - Hourly loans don't show time due in SCO Due dates in the self checkout module don't display the time items are due, and thus items which are on hourly loans don't display an accurate due date and time. This patch corrects this by adding the "with_hours => 1" parameter. To test, enable an hourly loan period for an itemtype in your collection. Log into the self-checkout system and check out an item which circulates by the hour. The due date and time should be displayed correctly. Test in both prog and Bootstrap themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 18:02:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 16:02:51 +0000 Subject: [Koha-bugs] [Bug 9724] Hourly loans don't show time due in SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9724 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 18:40:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 16:40:37 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #109 from Paola Rossi --- I test against master 3.15.00.036. [Preference UseICU set to "Using"] I've tested ACQ, Serials and the Advanced Search module. IMO the patch is OK about these 3 modules. So I pass the patch to "Signed Off" status. ----------------------------------------------------------------------------- Some doc about advanced search test. I create some [fictious] authorities (personal name' author, topical term' subject) with Japanese (such as ????), Greek (???????), Arabic (??? ????? ????? ??), and some other (??????) chars. Then I fill the 700$a and 650$a of some biblios with them. Titles of the biblios have those chars too. Some fields are like the following ones (1 alphabet's chars only): ???? ????? ????? ?? ?????, ??????? ?, ??? whilest other fields are mixture (!) of some alphabets' chars, such as: ?ajko author Ibn G?b?r?l, ??l?m?h ben Y?hud?h ???? ????? ????? ?? Alcock ? ???, Ian ? topic mu ?? G?b?r?l, ??l?m?h ben Y?hud?h, Petr Il?i? I think the mixture fields are perhaps not real cases: anyway I've checked the koha's behaviour on these hypothetical cases too. Searching is OK (keyword, keyword as phrase, Author, Author as phrase, Personal name, Personal name as phrase, Subject, Subject as phrase). Facets are created well. The link from a facet is OK (the answer is correct), with the exception of NB1. NB1. The mixed fields with 2 [or more] adjacent Japanese chars are well listed in facets, but these facets have bad links, selecting erroneuosly nothing; i.e. these kind of facets find nothing [because of the two adjacent Japanese chars inside]: No results match your search for 'kw,wrdl: ...' with limit(s): 'au:?????provo?? mu ???, ???????' NB2. If I search for '?' in : advanced search, f.i. by "Keyword" field, [in ADVANCED SEARCH] search authorities by "Contains" operator, [in AUTHORITIES] search authorities by Tag editor, f.i. by "Main Entry contains" [in CATALOG] the answer is the same as the answer against searching for "c". Perhaps this is the expected behaviour. ----------------------------------------------------------------------------- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 18:42:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 16:42:21 +0000 Subject: [Koha-bugs] [Bug 9723] Hourly loans don't show time due in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9723 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Self checkout |OPAC Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 18:51:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 16:51:07 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #17 from Bernardo Gonzalez Kriegel --- Bug 10968 added a good feature. Need to rethink this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 18:53:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 16:53:51 +0000 Subject: [Koha-bugs] [Bug 9723] Hourly loans don't show time due in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9723 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 18:53:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 16:53:53 +0000 Subject: [Koha-bugs] [Bug 9723] Hourly loans don't show time due in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9723 --- Comment #1 from Owen Leonard --- Created attachment 27551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27551&action=edit Bug 9723 - Hourly loans don't show time due in OPAC Due dates in the OPAC don't display the time items are due, and thus items which are on hourly loans don't display an accurate due date and time. This patch corrects this by adding the "with_hours => 1" parameter. To test, enable an hourly loan period for an itemtype in your collection. View the display of date due on the following pages: - Patron details (opac-user.pl) - Log into the OPAC as a user who has something checked out which circulates by the hour. - Bibliographic details (opac-detail.pl) - View the details for an item which is circulates by the hour and is checked out. - Course reserves details (opac-course-details.pl) - View the contents of a course reserve, one of which should be an item which circulates by the hour and is checked out. All due dates should show both date and time and be formatted correctly. Test in both prog and Bootstrap themes. This solution is less than ideal for libraries who do not use hourly loans, as the time information is useless and potentially confusing. It's problematic even for libraries who do use hourly loans, since probably not all loans are hourly. However, without doing a check of each item's circulation policy every time we display the due date I don't know how you can tell it's an hourly loan. Assume that items due at 23:59 are non-hourly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 18:58:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 16:58:25 +0000 Subject: [Koha-bugs] [Bug 5317] transfer messages inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5317 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- I can't reproduce this problem in master, pre-3.16. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 19:02:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 17:02:36 +0000 Subject: [Koha-bugs] [Bug 9160] untranslatable string in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9160 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- This problem is no longer present in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 19:26:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 17:26:00 +0000 Subject: [Koha-bugs] [Bug 11841] Replace Record via Z39.50 only works from detail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11841 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #3 from Kyle M Hall --- This bug was fixed by the patch for bug 11829. *** This bug has been marked as a duplicate of bug 11829 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 19:26:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 17:26:00 +0000 Subject: [Koha-bugs] [Bug 11829] JavaScript error on staff client biblio details pages if template variables are undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11829 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #7 from Kyle M Hall --- *** Bug 11841 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 19:40:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 17:40:55 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 27552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27552&action=edit Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 19:42:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 17:42:51 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen at gmail.com Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:00:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:00:15 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27552|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 27553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27553&action=edit [SIGNED-OFF] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Also checked with Arabic translation, OPAC bootstrap, prog and ccsr. Tested with arabic records. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:01:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:01:28 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:07:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:07:01 +0000 Subject: [Koha-bugs] [Bug 12135] New: Pending suggestions table width is wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Bug ID: 12135 Summary: Pending suggestions table width is wrong Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It looks like the table for pending suggestions is out of whack. All the other tabs are formatting to a width of 1006px, but the pending request are formatting the table to a width of 1256px. Apparently this can't be fixed with jQuery. I can adjust the widths of the tables on the other tabs, but for some reason it won't work on this particular table. This is the jQuery I used: $("#ASKEDt").css("width","1006px"); If I change the ID to one of the other tables, it works just fine. May be part of the bug. It looks like it applies, but when you click the tab to look at this table, the old size appears, which makes me think the style is being applied when the tab is clicked, and overridden. The funny thing is that it doesn't do this with the other tabs. The jQuery override is applied and sticks, even after changing between the tabs. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:11:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:11:01 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #18 from Bernardo Gonzalez Kriegel --- (In reply to Bernardo Gonzalez Kriegel from comment #17) > Bug 10968 added a good feature. Need to rethink this. Sorry, I mean 10986 :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:13:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:13:00 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:17:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:17:14 +0000 Subject: [Koha-bugs] [Bug 9723] Hourly loans don't show time due in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9723 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #2 from Galen Charlton --- (In reply to Owen Leonard from comment #1) > However, without doing a check of each item's circulation policy every > time we display the due date I don't know how you can tell it's an > hourly loan. Assume that items due at 23:59 are non-hourly? See bug 11148. The new 'as_due_date' option could be added to the KohaDates TT filter as well, and it does indeed assume that any loans that are due at a time other than 23:59 are hourly. That way, there would be no way to clutter up the due date display for daily loans. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:22:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:22:36 +0000 Subject: [Koha-bugs] [Bug 9723] Hourly loans don't show time due in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9723 --- Comment #3 from Galen Charlton --- The following diff shows how the TT filter might be updated to add a as_due_date option: diff --git a/Koha/Template/Plugin/KohaDates.pm b/Koha/Template/Plugin/KohaDates.pm index 134712f..37d03af 100644 --- a/Koha/Template/Plugin/KohaDates.pm +++ b/Koha/Template/Plugin/KohaDates.pm @@ -30,7 +30,9 @@ sub filter { return "" unless $text; $config->{with_hours} //= 0; my $dt = dt_from_string( $text, 'iso' ); - return output_pref({ dt => $dt, dateonly => !$config->{with_hours} }); + return $config->{as_due_date} ? + output_pref({ dt => $dt, as_due_date => 1 }) : + output_pref({ dt => $dt, dateonly => !$config->{with_hours} }); } 1; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:24:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:24:59 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 --- Comment #4 from mathieu saby --- oups, I wrote it to quickly :( I'll fix that this week end Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:26:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:26:34 +0000 Subject: [Koha-bugs] [Bug 9724] Hourly loans don't show time due in SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9724 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #2 from Galen Charlton --- My comments to bug 9723 apply here as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:38:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:38:48 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:38:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:38:54 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 27554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27554&action=edit Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:39:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:39:59 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27553|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 20:55:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 18:55:27 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #1 from Owen Leonard --- There is code in the template which is supposed to fix this which stopped working when we upgraded jQueryUI. The width of tables which are hidden in non-visible tabs cannot be correctly calculated until they are shown--hidden elements have no width. This code fixed it before the jQueryUI upgrade: $('#suggestiontabs').tabs({ // Correct table sizing for tables hidden in tabs // http://www.datatables.net/examples/api/tabs_and_scrolling.html "show": function(event, ui) { var oTable = $('div.dataTables_wrapper>table', ui.panel).dataTable(); if ( oTable.length > 0 ) { oTable.fnAdjustColumnSizing(); } } }); The jQueryUI API has changed, so this needs to be corrected on this page and others. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:03:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:03:34 +0000 Subject: [Koha-bugs] [Bug 12136] New: Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 Bug ID: 12136 Summary: Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The "Most popular" feature in Opac is broken if AdvancedSearchTypes has multiple values (separated by pipes). To reproduce: 1) Set OpacTopissue preferende to "Allow" 2) Set AdvancedSearchTypes to an empty value -> "Most popular" shows "Limit to" with "All item types" (OK) 3) Set AdvancedSearchTypes to 'itemtypes' -> "Most popular" shows "Limit to" with "All item types" (OK) 4) Set AdvancedSearchTypes to 'ccode' -> "Most popular" shows "Limit to" with "All collections" (OK) 5) Set AdvancedSearchTypes to 'ccode|itemtypes' or 'itemtypes|ccode' -> "Most popular" shows "Limit to" with "All item types" with EMPTY dropdown list (BUG) This is due to wrong comparisions in opac-topissues.pl combined with the fact that the program logic can only display one drop down list. Patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:04:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:04:30 +0000 Subject: [Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11685 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:04:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:04:30 +0000 Subject: [Koha-bugs] [Bug 11685] GetSupportName and GetSupportList do not split AdvancedSearchTypes by pipe In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11685 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12136 Severity|enhancement |minor --- Comment #2 from Marc V?ron --- - I think it is a bug, not an enhancement. - For opac/opac-topissues.pl I filed a separate bug (12136) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:17:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:17:43 +0000 Subject: [Koha-bugs] [Bug 9723] Hourly loans don't show time due in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9723 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27551|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 27555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27555&action=edit Bug 9723 - Hourly loans don't show time due in OPAC Due dates in the OPAC don't display the time items are due, and thus items which are on hourly loans don't display an accurate due date and time. This patch corrects this by adding (and using) a new "as_due_date" option to the KohaDates plugin made possible by Bug 11148. Thanks to Galen for providing the changes to KohaDates.pm. To test, enable an hourly loan period for an itemtype in your collection. View the display of date due on the following pages: - Patron details (opac-user.pl) - Log into the OPAC as a user who has something checked out which circulates by the hour. - Bibliographic details (opac-detail.pl) - View the details for an item which is circulates by the hour and is checked out. - Course reserves details (opac-course-details.pl) - View the contents of a course reserve, one of which should be an item which circulates by the hour and is checked out. Due dates for hourly items should show both date and time and be formatted correctly. Due dates for non-hourly loans should show only the date. Test in both prog and Bootstrap themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:18:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:18:48 +0000 Subject: [Koha-bugs] [Bug 9724] Hourly loans don't show time due in SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9724 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27550|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:18:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:18:54 +0000 Subject: [Koha-bugs] [Bug 9724] Hourly loans don't show time due in SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9724 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:19:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:19:02 +0000 Subject: [Koha-bugs] [Bug 9724] Hourly loans don't show time due in SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9724 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9723 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:19:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:19:02 +0000 Subject: [Koha-bugs] [Bug 9723] Hourly loans don't show time due in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9723 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9724 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:25:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:25:54 +0000 Subject: [Koha-bugs] [Bug 9724] Hourly loans don't show time due in SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9724 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:25:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:25:56 +0000 Subject: [Koha-bugs] [Bug 9724] Hourly loans don't show time due in SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9724 --- Comment #3 from Owen Leonard --- Created attachment 27556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27556&action=edit Bug 9724 - Hourly loans don't show time due in SCO Due dates in the self checkout module don't display the time items are due, and thus items which are on hourly loans don't display an accurate due date and time. This patch corrects this by adding the "as_due_date => 1" parameter added by Bug 9723. To test, apply the patch for Bug 9723 if necessary. Enable an hourly loan period for an itemtype in your collection. Log into the self-checkout system and check out an item which circulates by the hour. The due date and time should be displayed correctly. Check out an item which does not circulate hourly. The due date should be displayed as a date only. Test in both prog and Bootstrap themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:28:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:28:46 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #60 from Jesse Weaver --- (In reply to Katrin Fischer from comment #59) > Giving an example for the links: > > Result list: > Online Access: Inhaltsverzeichnis [Inhaltsverzeichnis = table of contents] > http://localhost/cgi-bin/koha/opac-external-search.pl?q=bodensee# > > Detail page: > Online resources: Inhaltsverzeichnis > http://d-nb.info/1037370899/04 > > I wonder... the results page does not look quite right - having the > different label? An URL in a record is not always online access, like in > this case, so I'd prefer the wording from the detail page. The first was an overly aggressive jQuery selector, which I'll be throwing in a QA followup along with a fix for updatedatabase.pl (sorry dcook). The latter is likely an inconsistency in the underlying XSLT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:37:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:37:55 +0000 Subject: [Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 --- Comment #1 from Marc V?ron --- Created attachment 27557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27557&action=edit Bug 12136 - Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) This patch fixes empty dropdown list if AdvancedSearchTypes contains multiple values. It defaults the dropdown to "All item types". If AdvancedSearchTypes contains ccode, it displays "All collections" To test: 1) Set OpacTopissue preferende to "Allow" 2) Set AdvancedSearchTypes to an empty value -> "Most popular" displays "Limit to" with "All item types" 3) Set AdvancedSearchTypes to 'itemtypes' -> "Most popular" displays "Limit to" with "All item types" 4) Set AdvancedSearchTypes to 'ccode' -> "Most popular" displays "Limit to" with "All collections" 5) Set AdvancedSearchTypes to 'ccode|itemtypes' or 'itemtypes|ccode' or 'ccode' -> "Most popular" should now display "Limit to" with "All collections" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:54:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:54:51 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.sassmannshausen at ptfs-e | |urope.com --- Comment #10 from Alex Sassmannshausen --- Hello, In preparation of work on bug 5670, I have implemented the functionality discussed in this bug in a generic, granular fashion. I will shortly be uploading my patch for (hopefully) sign-off and qa. Let me know if you have any questions. Best wishes, Alex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:55:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:55:12 +0000 Subject: [Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 21:57:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 19:57:29 +0000 Subject: [Koha-bugs] [Bug 9427] Withdrawn items show as available in staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9427 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 22:02:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 20:02:01 +0000 Subject: [Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 22:10:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 20:10:18 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #11 from Alex Sassmannshausen --- Created attachment 27558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27558&action=edit Patch to implement described functionality New module: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their loan history. - Global syspref ('CheckPrevIssueByDefault'), set to 'No' by default, allows users to enable this feature library wide. - Per category pref allow libraries to create overrides per category, falling back on the global setting by default. - Per borrower pref allows switching the functionality on at the level of borrowers. Fall-back to category settings by default. * Koha/Borrowers/CheckPrevIssue.pm: new module. * C4/Circulation.pm (CanBookBeIssued): introduce CheckPrevIssue check. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVISSUE' confirmation message. * installer/data/mysql/kohastructure.sql: modify structure of 'categories', 'borrowers'. * installer/data/mysql/sysprefs.sql: add 'CheckPrevIssueByDefault' (exposed in patrons.pref). * installer/data/mysql/updatedatabase.pl: provide upgrade path. * admin/categorie.pl: add 'checkprevissuebycategory' to sql queries; pass it to template. * .../admin/categorie.tt: .../members/memberentrygen.tt: .../members/moremember.tt: add content. * CheckPrevIssue.t: new file with unit tests. Test plan: - Apply patch. - Run db updateds from updatedatabase.pl manually (I have not updated the database version yet ? not sure whether I should have done?) - Optionally, run Unit Tests (t/CheckPrevIssue.t) - Verify 'CheckPrevIssueByDefault' is visible in Patrons sysprefs and can be switched 'on' and 'off'. + Issue previously issued items to a borrower, checking the message appears as expected. - Verify 'Check previous loans' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting). - Verify 'Check previous loans' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 22:12:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 20:12:50 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #21 from Alex Sassmannshausen --- Hello, Thanks for all your work reviewing this patch. I'm working on the issues raised, and as a first step I have followed Cait's advice, splitting the CheckPreviousIssue functionality into a separate patch (bug 6906). I will be adding to this series in the near future, obsoleting my old patch, but if you are interested in this, please test the attachment at bug 6906 ? it is required for this functionality. Let me know if you have any questions or further feedback. Best wishes, Alex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 22:13:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 20:13:47 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #61 from Jesse Weaver --- Created attachment 27559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27559&action=edit Bug 10486 - QA followup: fix links in results and updatedatabase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 22:27:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 20:27:56 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 22:39:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 20:39:01 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 24 22:45:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 20:45:29 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mtj at kohaaloha.com |alex.sassmannshausen at ptfs-e | |urope.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 01:08:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 23:08:58 +0000 Subject: [Koha-bugs] [Bug 12137] New: Extend CalendarFirstDayOfWeek to be any day Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137 Bug ID: 12137 Summary: Extend CalendarFirstDayOfWeek to be any day Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com On the Koha list, Mubassir Ahsan asked: > Is there any option to set Saturday as First Day of Week. Please help me. I > am [stuck]. CalendarFirstDayOfWeek is either Sunday|Monday. By converting it to 0|1|2|3|4|5|6 (Sunday, Monday, ..., Saturday), we can allow any day of the week to be the first day of the week in the date picker. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 01:09:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 23:09:10 +0000 Subject: [Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 01:09:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 23:09:17 +0000 Subject: [Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9166 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 01:09:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 23:09:17 +0000 Subject: [Koha-bugs] [Bug 9166] OPAC needs configuration file for datepicker In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12137 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 01:22:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 23:22:54 +0000 Subject: [Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 01:22:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Apr 2014 23:22:55 +0000 Subject: [Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137 --- Comment #1 from M. Tompsett --- Created attachment 27560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27560&action=edit Bug 12137 - Extend CalendarFirstDayOfWeek to be any day TEST PLAN --------- 1) Backup DB 2) In mysql: > DELETE FROM systempreferences; > SOURCE .../installer/data/mysql/sysprefs.sql > SELECT variable,value FROM systempreferences; -- It should say 'CalendarFirstDayOfWeek' and '0' 3) Restore your DB 4) .../installer/data/mysql/updatedatabase.pl -- If your previous value for 'CalendarFirstDayOfWeek' was 'Sunday', it should be '0'. For 'Monday', it should be '1'. 5) Test an installation with 'de-DE' as the language. -- The default value should be '1'. 6) Test an installation with 'nb-NO' as the language. -- The default value should be '1'. 7) In the staff client, confirm that any day of the week is available in the I18N/L10N system preferences for the CalendarFirstDayOfWeek dropdown. -- I'm aware they aren't in order, but I'm after functionality, not finesse. 8) In another tab, go to a staff place that has a datepicker. For example, Home -> Tools -> Inventory/stocktaking 9) For each possible value in the CalendarFirstDayOfWeek, go to the other tab, refresh the page after updating the system preference, and click the datepicker icon. -- The date picker should then start on the selected day of the week. 10) Find some date picker in the OPAC, and repeat the same process. 11) Run koha QA test tools. NOTE: I was unable to figure out how to trigger OPAC datepicker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 02:24:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 00:24:43 +0000 Subject: [Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137 --- Comment #2 from M. Tompsett --- YAY! Found it for OPAC 1) Log into OPAC 2) Personal Details Tab. 3) The date picker is there for the date of birth! And it works. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 02:25:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 00:25:53 +0000 Subject: [Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137 --- Comment #3 from M. Tompsett --- NOTE: With the OPAC, you need to test prog and bootstrap themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:21:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:21:56 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #243 from Katrin Fischer --- And here are my final testing notes: ** Automated tests and QA script ** Passes all tests in t, xt, and t/db_dependent/Budgets.t t/db_dependent/Acquisition.t t/db_dependent/Acquisition/ Passes QA script. New GetBudgetByCode() covered by tests in t/db_dependent/Budgets.t. ** Code review ** No Capitalization problems found. No translation problems found. Terminology: * Planning value 1 and 2 > Statistic 1 and 2 * Budget > Fund ** Database update Adds a new system preference MarcFieldsToOrder, inludes changes to sysprefs.sql, database update and .pref file. syspref.sql and database update are identical. ** Regression testing ** Comparing current functionality with functionality after applying the patches. File list - addorderiso2709.pl - List of files that include 'staged' records is shown, details include file name, comments, status, and staged date - Bug: # Bibs is not shown (bug 9063) * No regresion, still works like it should. New patch for bug 9063 also fixes the # Bibs problem. List of staged records - addorderiso2709.pl - Information in the list only includes title, isbn/issn, there is no way to preview a record * Improved: MARC preview and card preview - Clicking on 'Add order' will import the record into the catalog and set the status to 'imported'. * No regression, status is correctly set. - You can choose to import all records at once, using the Accounting details section. Options are: currency, budget (should be fund), notes, planning value1, planning value2 * Fund now correctly labelled. Options are now available for batch operation and for individual orders. Options include: - Individual order: quantity, price, discount, fund, statistic 1 + 2 - Batch: currency, fund, notes, planning value 1 + 2 No regression found. - Bug: Fund list shows all funds, including inactive funds (bug 10302) * No regression. Bug 10302 should fix the existing remaining problems. * Statistic values on work correctly now for individual order lines and on the accounting details tab. New order form / neworderempty.pl - Replacing ajax-getauthvaluedropbox.pl with fetch_sort_dropbox.pl Used on neworderempty to show the correct values for Statistic 1 + 2 on selecting a fund. * No regression, works like it should. ** MarcFieldsToOrder New system preference allows to include acq data in the uploaded MARC file. System preference settings used for testing: price: 933$a|933$c quantity: 933$q sort1: 933$1 sort2: 933$2 discount: 933$d budget_code: 933$b Lines included in my records: 933 $a 12.00 $q 12 $b BOOKS1310 $d 5 $1 sort1 $2 sort2 933 $c 12.99 $a 9.00 $q 12 $b BOOKS1310 $d 0.05 $1 sort1 $2 sort2 Looking at the individual details for the first 2 records revealed: all settings have been imported correctly. Discount should be given as $, so 0.05 is way too low, 5 is better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:22:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:22:49 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #244 from Katrin Fischer --- Created attachment 27561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27561&action=edit [PASSED QA] Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information ("Import All" and "Accounting details" areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the "Stage MARC records for import" tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the "planning values" too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the "Accounting details" area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price => listprice = 0 else => - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:22:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:22:54 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #245 from Katrin Fischer --- Created attachment 27562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27562&action=edit [PASSED QA] Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:22:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:22:58 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #246 from Katrin Fischer --- Created attachment 27563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27563&action=edit [PASSED QA] Bug 7180: Add UT for C4::Budgets::GetBudgetByCode Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:03 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #247 from Katrin Fischer --- Created attachment 27564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27564&action=edit [PASSED QA] Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:08 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #248 from Katrin Fischer --- Created attachment 27565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27565&action=edit [PASSED QA] Bug 7180: The default quantity is 1 Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:13 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #249 from Katrin Fischer --- Created attachment 27566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27566&action=edit [PASSED QA] Bug 7180: Follow-up fixing minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:18 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #250 from Katrin Fischer --- Created attachment 27567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27567&action=edit [PASSED QA] Bug 7180: Change syspref description - the blank line is now useless - add an example for the syspref value Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:23 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #251 from Katrin Fischer --- Created attachment 27568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27568&action=edit [PASSED QA] Bug 7180: Adapt neworderempty code (js function moved). The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link some av to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:28 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #252 from Katrin Fischer --- Created attachment 27569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27569&action=edit [PASSED QA] Bug 7180: FIX License version Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:34 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #253 from Katrin Fischer --- Created attachment 27570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27570&action=edit [PASSED QA] Bug 7180: QA followup - fix unit tests (use a transaction). - add 3 tabs on the page in order to be more understandable. - fix a warn in logs Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:39 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #254 from Katrin Fischer --- Created attachment 27571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27571&action=edit [PASSED QA] Bug 7180 - QA Followup - Correct minor language issues Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:44 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #255 from Katrin Fischer --- Created attachment 27572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27572&action=edit [PASSED QA] Bug 7180: Restore the "Add order" link Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:49 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #256 from Katrin Fischer --- Created attachment 27573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27573&action=edit [PASSED QA] Bug 7180: Remove useless rrp variable Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:54 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #257 from Katrin Fischer --- Created attachment 27574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27574&action=edit [PASSED QA] Bug 7180: FIX: discount was divided by 100 twice. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:23:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:23:59 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #258 from Katrin Fischer --- Created attachment 27575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27575&action=edit [PASSED QA] Bug 7180: fetch_sort_dropbox.pl is not in use anymore Test plan: git grep fetch_sort_dropbox should return no result. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:24:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:24:04 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #259 from Katrin Fischer --- Created attachment 27576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27576&action=edit [PASSED QA] Bug 7180: QA followup 2 This patch takes into account all QA failures raised in comment 207. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:24:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:24:09 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #260 from Katrin Fischer --- Created attachment 27577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27577&action=edit [PASSED QA] Bug 7180: QA followup 3 1/ showmarc.pl takes the importid for staged files. 2/ small note to indicate that the vendor's discount will be used if no discount is filled. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:24:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:24:14 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #261 from Katrin Fischer --- Created attachment 27578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27578&action=edit [PASSED QA] Bug 7180: Reset statistic values on reloading the page On the "Default accounting details", if a dropdown list was created for a statistic value, on reloading the page it still exist. It should not given the fund value is reset. The CGIsort variable is useless and can be remove: the dropdown list is generated using the ajax call. Signed-off-by: Katrin Fischer Testing notes are on the bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:12 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:16 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27424|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:20 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:24 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27408|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:28 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27409|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:31 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27410|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:35 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27411|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:39 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27412|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:43 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27413|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:47 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27414|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:51 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27415|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:25:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:25:55 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27416|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:26:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:26:00 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:26:04 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27418|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:26:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:26:08 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27419|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:26:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:26:12 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27420|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:26:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:26:16 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:26:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:26:20 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27422|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:26:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:26:24 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:35:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:35:38 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer --- Hi Jonathan, testing this now, I think I see a small problem: I have one staged file from testing MarcFieldsToOrder, where I have set the fund in my mapping. This works nicely without 10875 and the correct fund is preselected on opening the page. But with this patch it seems not ok - at first it only seemed to reset the fund when I clicked the checkbox on top/next to the funds list, but now it seems always only 'select a fund' shows. I think it would be ok for the Accounting details tab, as people notice there what happens, but for the records list it seems to happen for all orders, even those you already selected a fund for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:44:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:44:26 +0000 Subject: [Koha-bugs] [Bug 3007] four UNIMARC value_builder templates to translate to English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 07:52:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 05:52:56 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #62 from Katrin Fischer --- Jesse, this is much better! But now that I know it should also work with UNIMARC I have added a UNIMARC target, which works perfectly... except for the details page. For exmaple there is always 'publication:', but it never seems to show any information behind the label. Most records don't show any other fields at all. I have tried with BNF2, your example from below. Also I have some weird diacritics showing up in my result list, not sure if that is the target or a bug. Also paging behind page 10 only brings up empty pages? Please check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 08:29:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 06:29:09 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 08:31:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 06:31:37 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #12 from Martin Renvoize --- Comment on attachment 27558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27558 Patch to implement described functionality Review of attachment 27558: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6906&attachment=27558) ----------------------------------------------------------------- Pretty happy with this in general. Just a few minor points regarding style.. but then, I could be missing something ;) ::: installer/data/mysql/kohastructure.sql @@ +265,4 @@ > `altcontactphone` varchar(50) default NULL, -- the phone number for the alternate contact for the patron/borrower > `smsalertnumber` varchar(50) default NULL, -- the mobile phone number where the patron/borrower would like to receive notices (if SNS turned on) > `privacy` integer(11) DEFAULT '1' NOT NULL, -- patron/borrower's privacy settings related to their reading history > + `checkprevissuebyborrower` varchar(7) NOT NULL default 'inherit', -- produce a warning for this borrower if this item has previously been issued to this borrower if 'yes', not if 'no', defer to category setting if 'inherit'. I think I would lose the 'byborrower' part of 'checkprevissuebyborrower' here, I think 'checkprevissue' is descriptive enough, and we already know it's in the borrower context due to the table it's found in. @@ +466,5 @@ > `issuelimit` smallint(6) default NULL, -- unused in Koha > `reservefee` decimal(28,6) default NULL, -- cost to place holds > `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown to this category (1 for yes, 0 for no) > + `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff), > + `checkprevissuebycategory` varchar(7) NOT NULL default 'inherit', -- produce a warning for this borrower category if this item has previously been issued to this borrower if 'yes', not if 'no', defer to category setting if 'inherit'. Do you mean "defer to 'syspref' setting if inherit." here? I think I would lose the 'bycategory' part of 'checkprevissuebycategory' here, I think 'checkprevissue' is descriptive enough, and we already know it's in the category context due to the table it's found in. ::: installer/data/mysql/updatedatabase.pl @@ +8202,4 @@ > SetVersion($DBversion); > } > > +# FIXME: change $DBversion The 'normal' way of doing this now is to put '$DBversion = "3.15.00.XXX";' These happen all the time, so the RM and QA people are used to these types of conflicts ;) ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref @@ +50,4 @@ > class: multi > - (separate multiple choices with |) > - > + - pref: CheckPrevIssueByDefault As you can probably tell by now, I'm a fan of shorter, but still descriptive, names. Do we really need the 'ByDefault' here? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 08:37:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 06:37:25 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27492|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 27579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27579&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 08:39:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 06:39:47 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #10 from Martin Renvoize --- Hmm, I found a minor bug in my code anyways, so I've uploaded a new patch.. However, I couldn't replicate your issue anyway Chris, are you still having issues? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 09:47:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 07:47:27 +0000 Subject: [Koha-bugs] [Bug 12130] Translations should live in /var not /usr for package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12130 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4861 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 09:47:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 07:47:27 +0000 Subject: [Koha-bugs] [Bug 4861] Debian packaging does not include translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12130 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 09:48:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 07:48:28 +0000 Subject: [Koha-bugs] [Bug 12130] Translations should live in /var not /usr for package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12130 --- Comment #2 from Martin Renvoize --- I think the bug you're referring to is bug 4861. I agree, this is a longer term piece of work which would be nice to get done. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 09:49:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 07:49:11 +0000 Subject: [Koha-bugs] [Bug 12129] Translations should be removed when koha-common package is removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12129 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4861 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 09:49:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 07:49:11 +0000 Subject: [Koha-bugs] [Bug 4861] Debian packaging does not include translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12129 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 09:49:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 07:49:53 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4861 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 09:49:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 07:49:53 +0000 Subject: [Koha-bugs] [Bug 4861] Debian packaging does not include translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10942 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 09:50:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 07:50:38 +0000 Subject: [Koha-bugs] [Bug 4861] Debian packaging does not include translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |10942 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 09:50:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 07:50:38 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4861 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 10:07:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 08:07:02 +0000 Subject: [Koha-bugs] [Bug 12138] New: Use placeholders in translatable javascript strings Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12138 Bug ID: 12138 Summary: Use placeholders in translatable javascript strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Created attachment 27580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27580&action=edit Use formatting for translatable javascript strings Currently translating javascript strings with variables in them is hard, because the strings are created from separate parts. For example: _("Are you sure you want to delete the") + " " + count + " " + _("attached items?") This is translated in two different parts, and the translator cannot affect the place where the count-variable is. Now, if the javascript strings allowed placeholders, similar to how the template strings do, the above could be written as: _("Are you sure you want to delete the %s attached items?").format(count) This would make translation much easier. Attached patch adds a javascript string formatter, and changes all the concatenated translatable js strings used in intranet to use that. To test: 1) cd misc/translator 2) perl translate update xx-YY 3) grep ^msgid po/xx-YY-i-staff-t-prog-v-3006000.po | sort | uniq > xx-YY-pre 4) apply patch 5) perl translate update xx-YY 6) grep ^msgid po/xx-YY-i-staff-t-prog-v-3006000.po | sort | uniq > xx-YY-post 7) compare the files: diff -Nurd xx-YY-pre xx-yy-post | less should show the javascript strings that changed. 8) Test the UIs where the formatted js strings are used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 10:40:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 08:40:45 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #63 from Katrin Fischer --- Ah, and the styling for the mandatory fields on the cnfiguration page doesn't look quite right yet - compared to administration>libraries. But not a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 10:54:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 08:54:10 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27546|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 27581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27581&action=edit [PASSED QA] Bug 12134 - Members are restricted even if the debarment is ended Test Plan: 1) Modify borrowers.debarred for a borrower and set the date in the past 2) Try to check out an item to that patron 3) Note you cannot 4) Apply this patch 5) Repeat step 2 6) Note you can now check out items the patron Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 10:54:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 08:54:39 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 10:54:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 08:54:41 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27547|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 27582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27582&action=edit [PASSED QA] Bug 12134: Add unit tests to reflect the change in IsDebarred Before Kyle's patch, the test failed. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 10:55:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 08:55:30 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Passes tests, code makes sense and fixes an important bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:01:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:01:23 +0000 Subject: [Koha-bugs] [Bug 12138] Use placeholders in translatable javascript strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12138 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:01:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:01:38 +0000 Subject: [Koha-bugs] [Bug 12138] Use placeholders in translatable javascript strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12138 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at pttk.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:14:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:14:54 +0000 Subject: [Koha-bugs] [Bug 12139] New: Preference name saved all lowercase Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12139 Bug ID: 12139 Summary: Preference name saved all lowercase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a preference doesn't exist in the database, saving that preference via the UI will result the preference name set in all lowercase in the database. This means those preferences that have any uppercase characters won't find the value, eg. in templates. To test: 1) select * from systempreferences where variable like 'advancedMARCeditor'; (note the way the "variable" is in db: "advancedMARCeditor") 2) delete from systempreferences where variable like 'advancedMARCeditor'; 3) Go to system preferences, edit and save advancedMARCeditor setting. 4) select * from systempreferences where variable like 'advancedMARCeditor'; (note the way the "variable" is in db: "advancedmarceditor") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:35:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:35:07 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:35:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:35:09 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 --- Comment #17 from Jonathan Druart --- Created attachment 27583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27583&action=edit Bug 10875: Preselect the fund located in the record It is useless to copy the fund list in a new node. It seems easier to hide/show inactive/active funds. This patch also adds a "(inactive)" marker in the fund list for inactive funds. If the fund located in the record is inactive, it is displayed by default and cannot be hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:36:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:36:02 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 --- Comment #18 from Jonathan Druart --- Katrin, I think this followup will fix your issue. I switched the status back to Signed Off, feel free to ask for a signoff if you think it is needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:41:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:41:50 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27517|0 |1 is obsolete| | Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at pttk.fi |ity.org | --- Comment #2 from paxed --- Created attachment 27584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27584&action=edit Guarantor requirements when registering a patron Add two requirements when registering a new patron Attached patch adds two new requirements when registering a new patron: - A child patron must have a guarantor. This is controlled by a new syspref ChildNeedsGuarantor, which defaults to off. - A guarantor cannot be a guarantee. Both of these stem from legal requirements in Finland. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:45:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:45:15 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27198|0 |1 is obsolete| | --- Comment #110 from Jonathan Druart --- Created attachment 27585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27585&action=edit Bug 11944: Remove all utf8 filter from templates This patch - removes all html_entity usages in tt file which hide utf8 bugs - removes all encode utf8 in tt plugins because we should get correctly marked data from DBIC and other sources directly (cf plugin EncodeUTF8 used in renew.tt) - adds some cleanup in C4::Templates::output: we now use perl utf8 file handler output so we don't need to decode tt variables manually. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:45:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:45:19 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27199|0 |1 is obsolete| | --- Comment #111 from Jonathan Druart --- Created attachment 27586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27586&action=edit Bug 11944: replace use of utf8 with Encode See the wiki page for the explanation. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:45:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:45:24 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27200|0 |1 is obsolete| | --- Comment #112 from Jonathan Druart --- Created attachment 27587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27587&action=edit Bug 11944: Encoding UTF8 in C4::Templates Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:45:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:45:37 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27201|0 |1 is obsolete| | --- Comment #113 from Jonathan Druart --- Created attachment 27588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27588&action=edit Bug 11944: Set ImplicitUnicode for YAML Before this patch, string for yaml files used in preferences.pl were broken. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:45:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:45:41 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27202|0 |1 is obsolete| | --- Comment #114 from Jonathan Druart --- Created attachment 27589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27589&action=edit Bug 11944: Library name variable should be decoded Test on preferences.pl and on some others pages when mysql is used to store session. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:45:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:45:46 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27203|0 |1 is obsolete| | --- Comment #115 from Jonathan Druart --- Created attachment 27590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27590&action=edit Bug 11944: replace uri_escape with uri_escape_utf8 everywhere To reproduce, edit, index notice with ?? and search "??" Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:45:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:45:50 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27204|0 |1 is obsolete| | --- Comment #116 from Jonathan Druart --- Created attachment 27591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27591&action=edit Bug 11944: Never use decode/encode in TT Plugins The EncodeUTF8 TT plugin is useless, we should NEVER use encode in templates. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:45:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:45:54 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27205|0 |1 is obsolete| | --- Comment #117 from Jonathan Druart --- Created attachment 27592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27592&action=edit Bug 11944: Remove obsolete encoding routines We don't need to decode manually which provide nice performance boost. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:45:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:45:58 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27206|0 |1 is obsolete| | --- Comment #118 from Jonathan Druart --- Created attachment 27593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27593&action=edit Bug 11944: TT Plugins should not encode strings Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:46:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:46:07 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27208|0 |1 is obsolete| | --- Comment #120 from Jonathan Druart --- Created attachment 27595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27595&action=edit Bug 11944: FIX Error on editing an authority Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:46:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:46:11 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27209|0 |1 is obsolete| | --- Comment #121 from Jonathan Druart --- Created attachment 27596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27596&action=edit Bug 11944: Fix encoding issue on searching The search patch should fix non-latin character searches. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:46:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:46:03 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27207|0 |1 is obsolete| | --- Comment #119 from Jonathan Druart --- Created attachment 27594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27594&action=edit Bug 11944: Some refresh don't indicate the charset to use This patch replaces occurrences of META HTTP-EQUIV=Refresh with a redirection. Note: The list of modified files has been got with the following grep: git grep Content-Type | grep -v -i utf | grep Refresh | grep -v translator | grep -v \.js Test plan: 1) admin/auth_tag_structure.pl - Go on an authority MARC framework for an authority type (admin/auth_tag_structure.pl?authtypecode=CO for instance) - Click on the "Add a new tag" button - Fill fields - Save - You should be redirected on the auth_tag_structure.pl page - Try to modify an existing tag - The redirection should be done 2) admin/auth_subfields_structure.pl - From the previous page, click on a "subfields" link - Edit/Add a new subfields - Save - You should be redirected to the subfield list - Delete a subfield - You should be redirected to the subfield list 3) admin/authorised_values.pl - Add/Edit an authorised value - Save - You should be redirected to the authorised value list (with the right category selected) 4) admin/categorie.pl - Add/Edit a patron category - Save - You should be redirected to the category list - Delete a patron category - You should be redirected to the category list 5) admin/koha2marclinks.pl - Go on the Koha to MARC mapping configuration page - Edit a field - Map a field and click on "OK" - You should be redirected to the list 6) admin/marc_subfields_structure.pl - Go on the MARC frameworks page - Click on "MARC structure" for one on the list - Click on "Subfields" for one on the list - Add/Edit a subfield - Save - You should be redirected to the subfield list 7) admin/systempreferences.pl - Go on the system preferences admin page - Click on the "Local use" tab - Add/Edit a pref - Save - You shold be redirected to the Local use preference list 8) serials/subscription-detail.pl - Go on a subscription detail page - Delete the subscription (using Edit > Delete subscription) - You should be redirected on the serials home page Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:46:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:46:15 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27210|0 |1 is obsolete| | --- Comment #122 from Jonathan Druart --- Created attachment 27597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27597&action=edit Bug 11944: Facets and resort This patch should fix facets and resort encoding issues. Note: This patch will certainly break the search history Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:46:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:46:20 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27211|0 |1 is obsolete| | --- Comment #123 from Jonathan Druart --- Created attachment 27598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27598&action=edit Bug 11944: Authentication The password should be encoded before hashing. Test plan: - Before applying the patch, create a user with a password "????" - apply patches - try to log in - change the password - log out - try to log in Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:46:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:46:24 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27212|0 |1 is obsolete| | --- Comment #124 from Jonathan Druart --- Created attachment 27599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27599&action=edit Bug 11944: Fix fund names encoding on the parcel page On the parcel page, the subtotal values are stored in an hashref. The key was the fund name. The fund name being encoded in utf8, the hashref was broken. This patch replaces this logic creating a key based on an integer. The budget name is now stored in a new "budget_name" key. Note: It also fixes a small ergonomic issue (a td was missing in the tfoot). Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:46:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:46:28 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27213|0 |1 is obsolete| | --- Comment #125 from Jonathan Druart --- Created attachment 27600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27600&action=edit Bug 11944: Fix encoding issue on adding a subscription If frequencies or numbering patterns contain non-latin characters, so output was broken. To reproduce: - Create a frequency and a numbering pattern with non-latin characters - Add a new subscription using these values - The screen should not contain bad encoded characters. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:46:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:46:37 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27215|0 |1 is obsolete| | --- Comment #127 from Jonathan Druart --- Created attachment 27602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27602&action=edit Bug 11944: Fix encoding on sending emails This patch fixes 2 places where mails were badly encoded: 1/ At the opac and the intranet, on sending baskets 2/ At the opac and the intranet, on sending shelf/list Test plan: Shelf/List: - Create a list with non-latin characters in the name. - Add some items containing non-latin characters in their content. - Send the list by email Basket/Cart: - Add some items containing non-latin characters in their content to your cart.. - Send the cart by email Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:46:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:46:33 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27214|0 |1 is obsolete| | --- Comment #126 from Jonathan Druart --- Created attachment 27601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27601&action=edit Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:46:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:46:41 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27216|0 |1 is obsolete| | --- Comment #128 from Jonathan Druart --- Created attachment 27603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27603&action=edit Bug 11944: Fix encoding issue for the "Did you mean" feature Test plan: 1/ Go on admin/didyoumean.pl and enable the feature for the OPAC 2/ Generate and use the french templates 3/ Launch a search at the OPAC 4/ You should see "Voulez-vous dire : Chercher ?galement les termes sp?cifiques Chercher ?galement les termes g?n?riques Chercher ?galement les termes reli?s" Before this patch: "Voulez-vous dire : Chercher ?galement les termes sp?cifiques Chercher ?galement les termes g?n?riques Chercher ?galement les termes reli?s" Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:51:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:51:48 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #129 from Jonathan Druart --- (In reply to Paola Rossi from comment #109) > So I pass the patch to "Signed Off" status. Thanks Paola! I added your signoff to the patch set. I switch the status back to Needs Signoff for a second signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:56:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:56:16 +0000 Subject: [Koha-bugs] [Bug 12125] Unable to search for patrons and check materials in and out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12125 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Tested with 3.14.01.000 Firefox 28: OK Chrome 43: OK IE 11 :-) : OK Current master 3.15.00.036 Firefox 28: OK Chrome 43: OK IE 11: OK Can you give some more information (Browser etc.)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:56:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:56:30 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 11:56:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 09:56:34 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27579|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 27604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27604&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 12:02:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 10:02:10 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #12 from Martin Renvoize --- Thanks Joubu.. no idea why it wasn't applying.. but your new one applies fine for me still and hopefully also for everyone else too.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 12:21:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 10:21:30 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25542|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 27605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27605&action=edit Bug 11814 - (follow-up) Use constants to describe statuses This patch deals with all hard-coded status codes in the C4::Serials module. Test plan: Test a complete workflow in the serial module (create, order, receive, generate next) trying to use all statuses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 12:22:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 10:22:04 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #5 from Jonathan Druart --- (In reply to David Cook from comment #3) > Couldn't 1, 3, and 7 be exchanged a variable containing the value from the > constant? Yes, they should. Done in the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 12:41:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 10:41:19 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #13 from Alex Sassmannshausen --- Created attachment 27606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27606&action=edit Bug 6906 - show 'Borrower has previously... New module: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their loan history. - Global syspref ('CheckPrevIssue'), set to 'No' by default, allows - users to enable this feature library wide. - Per category pref allow libraries to create overrides per category, falling back on the global setting by default. - Per borrower pref allows switching the functionality on at the level of borrowers. Fall-back to category settings by default. * Koha/Borrowers/CheckPrevIssue.pm: new module. * C4/Circulation.pm (CanBookBeIssued): introduce CheckPrevIssue check. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVISSUE' confirmation message. * installer/data/mysql/kohastructure.sql: modify structure of 'categories', 'borrowers'. * installer/data/mysql/sysprefs.sql: add 'CheckPrevIssue' (exposed in patrons.pref). * installer/data/mysql/updatedatabase.pl: provide upgrade path. * admin/categorie.pl: add 'checkprevissue' to sql queries; pass it to template. * .../admin/categorie.tt: .../members/memberentrygen.tt: .../members/moremember.tt: add content. * CheckPrevIssue.t: new file with unit tests. Test plan: - Apply patch. - Run db updates from updatedatabase.pl manually. - Verify 'CheckPrevIssue' is visible in Patrons sysprefs and can be switched 'on' and 'off'. + Issue previously issued items to a borrower, checking the message appears as expected. - Verify 'Check previous loans' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting). - Verify 'Check previous loans' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 12:49:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 10:49:34 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 --- Comment #8 from Jonathan Druart --- Created attachment 27607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27607&action=edit Bug 12134: (follow-up) Add unit tests to reflect the change in IsDebarred Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 12:50:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 10:50:32 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27558|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 13:07:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 11:07:41 +0000 Subject: [Koha-bugs] [Bug 8338] fines not cleared with dropbox mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #12 from Kyle M Hall --- (In reply to Katrin Fischer from comment #10) > It looks like bug 10694 will fix this: > > "Sometimes libraries need to backdate returns further back in time than > Koha's dropbox mode will allow. The returns backdating will check in an item > as if it had been returned on the specified date, and will reduce any fine > accordingly." > > *** This bug has been marked as a duplicate of bug 10694 *** Yes, as the author of bug 10694 I believe that it will effectively resolve this bug. The only difference is that feature will require you to select the return date rather than having it decided for you automatically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 13:23:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 11:23:39 +0000 Subject: [Koha-bugs] [Bug 12131] C4/TmplToken.pm has an unnecessary dependency on Exporter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 13:23:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 11:23:41 +0000 Subject: [Koha-bugs] [Bug 12131] C4/TmplToken.pm has an unnecessary dependency on Exporter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27518|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 27608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27608&action=edit [PASSED QA] Bug 12131: Remove unused dependency on Exporter C4::TmplToken depends on Exporter but does not use any of its facilities. Removed the dead code so it does not clog up the source and waste compilation time Signed-off-by: Marcel de Rooy Module still compiles correctly; t/TmplToken.t passes. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 13:37:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 11:37:27 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 --- Comment #3 from Kyle M Hall --- Created attachment 27609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27609&action=edit [PASSED QA] Bug 12127 - Incorrect DataTable types in Holds to Pull list This patch explicitly sets the sType in the Holds to Pull list table for the libraries, itypes, and locations columns. It appears that the type is automatically being set to "html" when it should be set to "string". It needs to have a sType of "string", since DataTables will strip out the
    tags when using "html", and we need them for the regexp we use to create a more precise filter search. _TEST PLAN_ Before applying: 1) Place a "next available" hold on a record with an item available from one library/branch (e.g. "Branch A") 2) Place a "next available" hold on a record with an item available from two different libraries/branches 3) Place a "next available" hold on a record with an item available from three different libraries/branches - one of which is the same as the library/branch from Step 1. 4) Go to the Holds to Pull List 5) Filter the branches by "Branch A". 6) You should only see the hold from Step 1 - not Step 3. 7) Try filtering on a branch for a hold that has multiple libraries/branches. (They shouldn't appear when filtering, except when using the "None" filter). Apply the patch. After applying: 1) Repeat Steps 4-7 from above. When filtering on "Branch A", you should be able to see all holds that are available at "Branch A", even if they are available at other branches (i.e. the holds has multiple libraries listed). Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 13:37:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 11:37:50 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27481|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 13:38:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 11:38:29 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Kyle M Hall --- It would be nice if this patch used classes right from the start, but it's still better than having a bug! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 13:40:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 11:40:54 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27548|0 |1 is obsolete| | --- Comment #93 from Kyle M Hall --- Created attachment 27610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27610&action=edit Bug 11703 [QA Followup] - Fix unterminated string literal, add missing paren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 13:42:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 11:42:54 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #12 from Katrin Fischer --- Hm, not sure right now why this got stuck. I think we should either replace the _ANY_ by an empty branchcode and correct existing suggestions or we need to make the SQL take those _ANY_ into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 13:51:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 11:51:31 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |fridolyn.somers at biblibre.co | |m --- Comment #4 from Fridolin SOMERS --- This patch does not work. The variable CasServerUrl is always empty. It's a major problem for CAS users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:08:20 +0000 Subject: [Koha-bugs] [Bug 12128] Acq basket shows some values with single decimal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 --- Comment #2 from Kyle M Hall --- Created attachment 27611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27611&action=edit Bug 12128 [Alternate] - Acq basket shows some values with single decimal To test open a basket and see some values without decimal formatting (e.g. in column Total tax exc.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:10:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:10:28 +0000 Subject: [Koha-bugs] [Bug 12128] Acq basket shows some values with single decimal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- I think it would be best to move this formatting logic to the template, rather than formatting the string in perl. Since this is a display issue, we should solve it at the display level whenever possible. If paxed, Marc or anyone else agrees with me, please sign the alternate patch and deprecate the original patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:15:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:15:59 +0000 Subject: [Koha-bugs] [Bug 12119] Move jeditable jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12119 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27486|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- Created attachment 27612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27612&action=edit [PASSED QA] Bug 12119 - Move jeditable jQuery plugin outside of language-specific directory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:16:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:16:15 +0000 Subject: [Koha-bugs] [Bug 12119] Move jeditable jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12119 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:20:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:20:42 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #30 from Jonathan Druart --- Created attachment 27613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27613&action=edit Bug 11759: FIX issue list is empty The issue list is empty after checking an item out to a patron without existing checkout. To reproduce: - Search for a patron without checkout. - Check an item out using the "normal" checkout. - Verify the checkout list contain the checkout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:23:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:23:01 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 --- Comment #5 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #4) > This patch does not work. I've tested with a real CAS server of one of our client. It works in opac-user but not in the modal popup (link is empty) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:24:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:24:15 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:24:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:24:17 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27399|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 27614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27614&action=edit [PASSED QA] Bug 12122: TransferSlip should accept both itemnumber and barcode Added small patch to allow barcode as input in TransferSlip routine, mostly to allow generating transfer slips where only barcode is present (aka. javascript). Test plan: 1) find book with and 2) generate transferslips with both: transfer-slip.pl?transferitem=3967925&branchcode=MPL&op=slip transfer-slip.pl?barcode=&branchcode=MPL&op=slip and verify that the generated slips match. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:28:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:28:06 +0000 Subject: [Koha-bugs] [Bug 12118] Unnecessary YUI assets included in offline circ manifest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:28:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:28:08 +0000 Subject: [Koha-bugs] [Bug 12118] Unnecessary YUI assets included in offline circ manifest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27532|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 27615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27615&action=edit [PASSED QA] Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. Signed-off-by: Chris Cormack http://bugs.koha-community.org/show_bug.cgi?id=11218 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:32:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:32:30 +0000 Subject: [Koha-bugs] [Bug 12116] Move fixFloat jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12116 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:32:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:32:31 +0000 Subject: [Koha-bugs] [Bug 12116] Move fixFloat jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12116 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27357|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 27616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27616&action=edit [PASSED QA] Bug 12116 - Move fixFloat jQuery plugin outside of language-specific directory This patch moves the fixFloat jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. This patch also includes a change to staff-global.css to override some style the floating toolbar inherited when we added Bootstrap widgets. To test, apply the patch and confirm that the toolbar "sticks" to the top of the screen when scrolling down on the following pages: - System preferences - Authorities editor (Authorities -> New authority) - Cataloging editor (Cataloging -> New record) - List contents view (Lists -> View a list's contents) Followed test plan. Patch behaves as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:41:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:41:36 +0000 Subject: [Koha-bugs] [Bug 12115] Follow up fix for tools/inventory.pl's output_pref issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:41:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:41:38 +0000 Subject: [Koha-bugs] [Bug 12115] Follow up fix for tools/inventory.pl's output_pref issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27519|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 27617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27617&action=edit [PASSED QA] Bug 12115 - Follow up fix for tools/inventory's output_pref issues This should correct issues with the output_prefs in the compareinv2bar logic section of tools/inventory.pl It is a follow up to bug 11253. TEST PLAN --------- NOTE: There should be no distinguishable difference before and after the patch. This corrects a works by accident bug. Back up DB. Create a small barcode file from books in a given branch. Set I18N/L10N system preference of dateformat to mm/dd/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in mm/dd/yyyy format. Set I18N/L10N system preference of dateformat to yyyy-mm-dd. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in yyyy-mm-dd format. Set I18N/L10N system preference of dateformat to dd/mm/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in dd/mm/yyyy format. Apply patch Restore DB (so results should be comparable to the first result) Repeat the three testing blocks above. There should be no visible difference. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:42:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:42:14 +0000 Subject: [Koha-bugs] [Bug 12125] Unable to search for patrons and check materials in and out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12125 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Owen Leonard --- This bug report looks to have been an accidental duplicate of Bug 12124 where the bug-submitter's problem was resolved. *** This bug has been marked as a duplicate of bug 12124 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:42:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:42:14 +0000 Subject: [Koha-bugs] [Bug 12124] Unable to search for patrons and check materials in and out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12124 --- Comment #3 from Owen Leonard --- *** Bug 12125 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:43:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:43:21 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 --- Comment #5 from Owen Leonard --- (In reply to Kyle M Hall from comment #4) > It would be nice if this patch used classes right from the start My patch for Bug 12088 corrects this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:46:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:46:43 +0000 Subject: [Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Patch uses JSON::XS which isn't in our list of dependencies. It may not be needed though. JSON has the same subroutine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:49:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:49:43 +0000 Subject: [Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #6 from Kyle M Hall --- (In reply to Kyle M Hall from comment #5) > Patch uses JSON::XS which isn't in our list of dependencies. It may not be > needed though. JSON has the same subroutine. It appears that both JSON:PP and JSON:XS support encode_json. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:53:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:53:13 +0000 Subject: [Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #7 from Kyle M Hall --- (In reply to Kyle M Hall from comment #6) > (In reply to Kyle M Hall from comment #5) > > Patch uses JSON::XS which isn't in our list of dependencies. It may not be > > needed though. JSON has the same subroutine. > > It appears that both JSON:PP and JSON:XS support encode_json. I have verified encode_json works just fine using both PP and XS versions of JSON. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:55:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:55:41 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:55:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:55:43 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26931|0 |1 is obsolete| | --- Comment #6 from Fridolin SOMERS --- Created attachment 27618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27618&action=edit Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. This patch proposes, in case CAS is enabled, to redirect to the opac-user.pl page (like prog theme). This is because the popup content should stay small (thinking about mobile surf), and that CAS url is actually only computed in opac-user (see C4/Auth.pm) and it would not be performant to compute it in all pages. Test plan: - set syspref opacthemes to bootstrap - enable the casAuthentication syspref - fill the casServerUrl syspref with something like : https://localhost:8443/cas - go on the opac home page - click on "Log in to your account" link (top right) => You go to cgi-bin/koha/opac-user.pl page where you see the cas link - disable the casAuthentication syspref - go on the opac home page - click on "Log in to your account" link (top right) => You see a popup for loggin and password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 14:57:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 12:57:21 +0000 Subject: [Koha-bugs] [Bug 12139] Preference name saved all lowercase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12139 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- I could reproduce this following the test steps. Additional remarks: The system log logs the variable name correctly ('advancedMARCeditor') As far as I can trace it down, the involved code is in admin/systempreferences.pl around line 284 or around line 355 However, the insert statement and the log statement use the same value at both places: $input->param('variable') -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:00:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:00:01 +0000 Subject: [Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27360|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 27619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27619&action=edit Bug 12114: Fix encoding problem with reports JSON web service (opac) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:00:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:00:30 +0000 Subject: [Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27361|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 27620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27620&action=edit Bug 12114: Fix encoding problem with reports JSON web service (staff) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:00:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:00:37 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at biblibre.co |fridolyn.somers at biblibre.co |m |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:00:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:00:52 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:01:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:01:52 +0000 Subject: [Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #10 from Kyle M Hall --- Created attachment 27621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27621&action=edit Bug 12114 [QA Followup] - Use JSON instead of JSON::XS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:02:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:02:04 +0000 Subject: [Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:08:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:08:30 +0000 Subject: [Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 --- Comment #2 from Owen Leonard --- > 1) Set OpacTopissue preferende to "Allow" > 2) Set AdvancedSearchTypes to an empty value > -> "Most popular" displays "Limit to" with "All item types" I get a dropdown with "All collections" and a list of collection codes. Submitting the form with default values (10 titles, all libraries, all collections, 3 months) returns no results. Only by changing the time span to "no limit" do I get results. > 3) Set AdvancedSearchTypes to 'itemtypes' > -> "Most popular" displays "Limit to" with "All item types" Using 'itemtypes' I do get a list of item types, but the same results for a default search as above. > 4) Set AdvancedSearchTypes to 'ccode' > -> "Most popular" displays "Limit to" with "All collections" Same results as in step 1-2. > 5) Set AdvancedSearchTypes to 'ccode|itemtypes' or 'itemtypes|ccode' or > 'ccode' > -> "Most popular" should now display "Limit to" with "All collections" Same results as in step 1-2. Shouldn't these combination value offer some combination of limiters? I would expect either a dropdown which combined both collection codes and item types, or a separate dropdown for collection and item type. And what about location? This patch seems to have broken the option to limit by shelving location if AdvancedSearchTypes is set to 'loc'. If we're going to address this problem doesn't the patch need to cover the search query as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:08:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:08:36 +0000 Subject: [Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:08:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:08:54 +0000 Subject: [Koha-bugs] [Bug 12112] C4::Breeding::ImportBreeding() is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12112 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:08:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:08:56 +0000 Subject: [Koha-bugs] [Bug 12112] C4::Breeding::ImportBreeding() is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12112 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27365|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 27622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27622&action=edit [PASSED QA] Bug 12112: remove disused routine C4::Breeding::ImportBreeding() This patch removes the ImportBreeding() routine, which lost its last caller as of the patch for bug 10462. To test: [1] Verify that prove -v t/Breeding.t passes. [2] Perform a Z39.50 search in the staff interface. [3] Perform a cataloguing reservoir search in the staff interface; verifying that cached records from the search done in step 2 are retrieved. Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:09:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:09:18 +0000 Subject: [Koha-bugs] [Bug 12141] New: On Display Module Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12141 Bug ID: 12141 Summary: On Display Module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org I think that the course reserves module could be used for displays, except that there is a lot of language that would need to be changed and a few fields we wouldn't need (department, term, instructor). Basically a display module would do almost the same thing as Course Reserves though. When you have a display you create a 'Display' and add titles to it. You temporarily change their item type and/or location and/or collection code while it's on display. Displays can be browsed through a link on the main page (like course reserves) or seen just in the general search results. Then when a display is disabled or deleted the titles all go back to their original item type, collection code and/or shelving location. This would a great feature for public libraries and academic libraries alike. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:11:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:11:19 +0000 Subject: [Koha-bugs] [Bug 12142] New: option to automatically add a processing fee when an item is marked lost Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12142 Bug ID: 12142 Summary: option to automatically add a processing fee when an item is marked lost Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice if there was a sys pref or something in the circ matrix that let you define a procession fee for when an item is marked lost. So if the item is marked lost either manually or automatically (with the cron) the system can charge a fee in addition to the lost item fee. Right now libraries are doing this manually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:14:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:14:16 +0000 Subject: [Koha-bugs] [Bug 12128] Acq basket shows some values with single decimal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 --- Comment #4 from Marc V?ron --- Created attachment 27623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27623&action=edit [Signed-off] Bug 12128 [Alternate] - Acq basket shows some values with single decimal To test open a basket and see some values without decimal formatting (e.g. in column Total tax exc.) Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:14:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:14:37 +0000 Subject: [Koha-bugs] [Bug 12128] Acq basket shows some values with single decimal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27478|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:14:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:14:56 +0000 Subject: [Koha-bugs] [Bug 12128] Acq basket shows some values with single decimal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27611|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:19:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:19:32 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #19 from Katrin Fischer --- I've got a question unrelated to the implementation :) When an item is returned on the self check, it's not set to waiting, so it should show up on the holds to pull list. Would this also trigger a print? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:20:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:20:52 +0000 Subject: [Koha-bugs] [Bug 12141] On Display Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12141 --- Comment #1 from Owen Leonard --- I think shelving location is an obvious candidate for designating that something is on display. However, right now the only way to change something's shelving location is through cataloging or batch modification--two things you probably don't want to give the circ staff the required permission to do. See Bug 6615. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:25:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:25:31 +0000 Subject: [Koha-bugs] [Bug 12107] Move checkboxes jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12107 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:25:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:25:33 +0000 Subject: [Koha-bugs] [Bug 12107] Move checkboxes jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12107 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27505|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 27624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27624&action=edit [PASSED QA] Bug 12107 - Move checkboxes jQuery plugin outside of language-specific directory This patch moves the checkboxes jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. To test, apply the patch and confirm that select all/clear all controls continue to work on the following pages: - Acquisitions -> Late orders - Acquisitions -> Add to order from an external source (search targets) - Acquisitions -> Suggestions - Administration -> Funds -> Planning (show/hide all columns) * Some unused code has been removed - Administration -> Library transfer limits - Staff client cart - Authorities -> New from Z39.50 (search targets) - Cataloging -> New from Z39.50 (search targets) - Circulation -> Check out to a patron (renew/check in selections) - Circulation -> Offline circulation -> Pending operations - Patrons -> Patron detail (renew/check in selections) - Patrons -> Fines -> Pay fines - Serials -> Subscription -> Serial collection - Tools -> Label creator -> Batches -> Search results - Tools -> Patron card creator -> Batches -> Search results - Tools -> Tags moderation - Tools -> Batch item deletion - Tools -> Batch item modification - Tools -> Inventory -> Submit a batch of barcodes - Lists -> List contents view Signed-off-by: David Cook Works as described! I don't think I've ever checked so many boxes before... Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:33:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:33:41 +0000 Subject: [Koha-bugs] [Bug 12103] Move ajaxfileupload jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12103 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:33:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:33:43 +0000 Subject: [Koha-bugs] [Bug 12103] Move ajaxfileupload jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12103 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27366|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 27625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27625&action=edit [PASSED QA] Bug 12103 - Move ajaxfileupload jQuery plugin outside of language-specific directory This patch moves the ajaxfileupload jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. To test, apply the patch and test a page which requires the file upload plugin. For instance: Tools -> Upload local cover image. The upload process should finish correctly. Tested with patron and local cover images. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:39:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:39:17 +0000 Subject: [Koha-bugs] [Bug 12101] Move Greybox library outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:39:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:39:19 +0000 Subject: [Koha-bugs] [Bug 12101] Move Greybox library outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27506|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 27626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27626&action=edit [PASSED QA] Bug 12101 - Move Greybox library outside of language-specific directory This patch moves the Greybox library to intranet-tmpl/lib so that it is not duplicated for each set of translated templates. The Greybox library files are called directly only by one include file, greybox.inc, which is modified by this patch. To test, apply the patch and view any page which calls the Greybox library and confirm that modal windows are still generated correctly. For instance, Cataloging -> Cataloging search, click the "Preview MARC" link. Signed-off-by: David Cook Works as described. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:46:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:46:36 +0000 Subject: [Koha-bugs] [Bug 12100] Messaging preferences did not save Days in Advance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12100 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:46:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:46:38 +0000 Subject: [Koha-bugs] [Bug 12100] Messaging preferences did not save Days in Advance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12100 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27364|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 27627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27627&action=edit [PASSED QA] Bug 12100: Messaging preferences did not save Days in Advance If you have enhanced messaging preference, the Days in Advance combo value (in Patron Messaging Preferences) is saved in the database but not retrieved when you have not enabled the Email checkbox next to it. This patch does the following: [1] It replaces a JOIN by a LEFT JOIN that is the actual reason of the problem described. [2] Removes a FIXME by saving a hardcoded 30 into a constant. [3] Fixes a typo in the neighborhood. [4] Removes a superfluous comma in the map statement. [5] Simplifies code for the selected field of the days combo. It should just be a boolean. The text selected="selected" is in the template. Test plan: [1] Enable enhanced messaging preferences. [2] Fill in Days in advance for Advance notice but uncheck Email. [3] Save the preferences. [4] The member home screen does not display the number of days (until you decide to apply this patch :) Followed test plan. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:54:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:54:17 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- printslip.tt is used by circ/transfer-slip.pl, members/printslip.pl and opac/sco/printslip.pl as well as circ/hold-transfer-slip.pl The fixed title will not work here. You'll need to add a flag and title for each of these scripts to the template so each can have a separate translatable title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:56:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:56:23 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:56:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:56:26 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27618|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 27628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27628&action=edit Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. This patch proposes, in case CAS is enabled, to redirect to the opac-user.pl page (like prog theme). This is because the popup content should stay small (thinking about mobile surf), and that CAS url is actually only computed in opac-user (see C4/Auth.pm) and it would not be performant to compute it in all pages. Test plan: - set syspref opacthemes to bootstrap - enable the casAuthentication syspref - fill the casServerUrl syspref with something like : https://localhost:8443/cas - go on the opac home page - click on "Log in to your account" link (top right) => You go to cgi-bin/koha/opac-user.pl page where you see the cas link - disable the casAuthentication syspref - go on the opac home page - click on "Log in to your account" link (top right) => You see a popup for loggin and password Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:57:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:57:35 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 --- Comment #8 from Jonathan Druart --- Thanks Fridolin, your patch is much more consistent than mine! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 15:59:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 13:59:26 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #20 from Katrin Fischer --- Some notes after talking to Kyle about this feature: - The prints will happen when the hold is places, the printer used is the pickup branch. This means, that will work for single brnach libraries, but might be a problem to multi branch libraries. Also if the item is - The printed flag being on reserves will make it a bit harder to extend this later, I think I would like a separate table with a time queued and a time printed better. We could also extend that later for other automated prints. - If the flag stays on reserves, we might want to make it a datetime instead for the time it was printed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:10:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:10:08 +0000 Subject: [Koha-bugs] [Bug 11986] Tags searching doesn't work in OPAC if biblio DOM indexing is being used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:10:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:10:10 +0000 Subject: [Koha-bugs] [Bug 11986] Tags searching doesn't work in OPAC if biblio DOM indexing is being used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27534|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 27629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27629&action=edit [PASSED QA] Bug 11986 - Tags searching doesn't work in OPAC if biblio DOM indexing is being used This patch fixes the following issue: in installations that are using zebra DOM indexing for bibliographic records, tag searching in OPAC doesn't work properly (clicking on any tag in OPAC leads to "404 error"). To test: ensure that with patch applied: 1) problems with tag searching get resolved for [some] test configuration with biblio DOM indexing enabled, 2) there are no apparent tag-searching-related regressions in OPAC, in some yet another test installation configured with legacy (grs1) indexing mode for biblios. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:18:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:18:56 +0000 Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:18:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:18:58 +0000 Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27545|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 27630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27630&action=edit [PASSED QA] Bug 11588: Untranslatable subscription frequency units Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:33:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:33:33 +0000 Subject: [Koha-bugs] [Bug 12143] New: hiding alternate address on patron self registration doesn't hide heading Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 Bug ID: 12143 Summary: hiding alternate address on patron self registration doesn't hide heading Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org In the OPAC when on the self registration form if you have hidden all of the alternate address fields the heading for that section still shows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:41:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:41:43 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:48:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:48:05 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #19 from Kyle M Hall --- Please change "joker" to "wildcard". It may be good to also document that % matches any number of chracters and that _ matches only a single character. Another issue is that it's a bit confusing that when I ran a search, the first then I say was my search form again! I would suggest that when there are results, change the form title from "Item search" to "Item search parameters" or something like that, and make it a link that will expand and collapse the form using jquery. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:49:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:49:31 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #20 from Kyle M Hall --- On more thing, please change the "modify" links in the results to "edit" so they match up with the rest of Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:54:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:54:35 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:54:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:54:39 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26008|0 |1 is obsolete| | Attachment #26009|0 |1 is obsolete| | Attachment #26704|0 |1 is obsolete| | Attachment #26705|0 |1 is obsolete| | Attachment #26722|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart --- Created attachment 27631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27631&action=edit Bug 7673 : New patron permissions This patch adds the following permissions: - editcatalogue.limited_item_edition: Limit item modification to barcode, status and note - editcatalogue.delete_all_items: Delete all items at once - tools.items_limited_batchmod: Limit batch item modification to item status The SubfieldsToAllowForLimitedEdition syspref is used to define which subfields can be edited when the editcatalogue.limited_item_edition permission is enabled. In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define which subfields can be edited when the tools.items_limited_batchmod permission is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:54:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:54:46 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #48 from Jonathan Druart --- Created attachment 27632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27632&action=edit Bug 7673: QA Followup: trailing whitespace and perlcritic issues This patch fixes the following qa issues: FAIL cataloguing/additem.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 833) FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). FAIL tools/batchMod.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:54:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:54:52 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #49 from Jonathan Druart --- Created attachment 27633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27633&action=edit Bug 7673: The delete all items link should only be displayed if delete_all_items is set This test had been lost in a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:54:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:54:57 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #50 from Jonathan Druart --- Created attachment 27634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27634&action=edit Bug 7673: the limitation on editing an item does not affect FA framework The pref SubfieldsToAllowForLimitedEdition should not affect Fast cataloguing framework (FA). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:55:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:55:01 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #51 from Jonathan Druart --- Created attachment 27635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27635&action=edit Bug 7673: DB Changes - add system preferences This patch the 2 system preferences SubfieldsToAllowForRestrictedEdition and SubfieldsToAllowForRestrictedBatchmod. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:55:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:55:07 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #52 from Jonathan Druart --- Created attachment 27636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27636&action=edit Bug 7673: Update syspref names in script The both syspref names have been changed since the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:55:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:55:12 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #53 from Jonathan Druart --- Created attachment 27637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27637&action=edit Bug 7673: DB changes - Add permissions This patch adds 3 permissions: - edit_items_restricted - delete_all_items - items_batchmod_restricted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:55:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:55:16 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #54 from Jonathan Druart --- Created attachment 27638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27638&action=edit Bug 7673: Update permission names in script Two permission names have been changed since the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:58:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:58:33 +0000 Subject: [Koha-bugs] [Bug 12138] Use placeholders in translatable javascript strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12138 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:58:35 +0000 Subject: [Koha-bugs] [Bug 12138] Use placeholders in translatable javascript strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12138 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27580|0 |1 is obsolete| | --- Comment #1 from Owen Leonard --- Created attachment 27639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27639&action=edit Bug 12138 - Use placeholders in translatable javascript strings Currently translating javascript strings with variables in them is hard, because the strings are created from separate parts. For example: _("Are you sure you want to delete the") + " " + count + " " + _("attached items?") This is translated in two different parts, and the translator cannot affect the place where the count-variable is. Now, if the javascript strings allowed placeholders, similar to how the template strings do, the above could be written as: _("Are you sure you want to delete the %s attached items?").format(count) This would make translation much easier. Attached patch adds a javascript string formatter, and changes all the concatenated translatable js strings used in intranet to use that. To test: 1) cd misc/translator 2) perl translate update xx-YY 3) grep ^msgid po/xx-YY-i-staff-t-prog-v-3006000.po | sort | uniq > xx-YY-pre 4) apply patch 5) perl translate update xx-YY 6) grep ^msgid po/xx-YY-i-staff-t-prog-v-3006000.po | sort | uniq > xx-YY-post 7) compare the files: diff -Nurd xx-YY-pre xx-yy-post | less should show the javascript strings that changed. 8) Test the UIs where the formatted js strings are used. Signed-off-by: Owen Leonard I tested *most* of the changed files. There were some instances where it wasn't clear to me how to trigger the warnings which were modified, especially tags/review.tt, admin/manage-marc-import.tt, and holidays.tt. Everything I was able to test worked correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 16:58:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 14:58:48 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #55 from Jonathan Druart --- Created attachment 27640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27640&action=edit Bug 7673: Change the superlibrarian check To know if the user is a superlibrarian, we have to call C4::Context->IsSuperLibrarian -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:06:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:06:03 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27635|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart --- Created attachment 27641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27641&action=edit Bug 7673: DB Changes - add system preferences This patch the 2 system preferences SubfieldsToAllowForRestrictedEdition and SubfieldsToAllowForRestrictedBatchmod. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:07:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:07:46 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #57 from Jonathan Druart --- (In reply to Katrin Fischer from comment #42) > 1) I wonder about the names of the new permissions. > I think a limited edition would be something different - maybe we > can get a native speaker's opinion on this? Done. > 2) Please include all .sql permission files, so new installations won't > miss them. You can check with xt/permissions.t Done. > 3) Fix sequence of system preferences Done. > 4) If we are going to rewrite this bit of code, it would be good to > remove the use of CGI::scrolling_list (bug 766): > + $subfield_data{marc_value} =CGI::scrolling_list(@scrparam); It will be done when bug 766 will be pushed. > 5) System preference description could be more clear. It should note that > the FA framework is excluded from the permission. Also it could include > a hint that the example is for UNIMARC and also include a MARC21 example > to avoid confusion. For us developers it's clear that we use different > item fields for both flavours, but not so much for librarians I guess. Done. > 6) I have my doubts about the superlibrarian checks you used: > && $limitededition->{'superlibrarian'} eq 1); > +$limitededition = 0 if ($limitededition != 0 && > $limitededition->{'superlibrarian'} eq 1); > We now have a specific method to check those: > C4::Context::IsSuperLibrarian() Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:10:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:10:07 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|matthias.meusburger at biblibr |jonathan.druart at biblibre.co |e.com |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:17:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:17:11 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26342|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart --- Created attachment 27642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27642&action=edit Bug 9811: Patron search improvement This patch add DataTables using server-side processing for the patrons search. It adds: - 1 module C4/Utils/DataTables/Members.pm - 2 services svc/members/search and svc/members/add_to_list - 1 template members/tables/members_results.tt - 1 new practice which is to add template for DataTables in a subdirectory named 'tables'. Impacted scripts: members/members-home.pl and members/members.pl To go further: We can imagine that all patrons searches use the same service with no big changes: 1 little template creates a JSON file and to implement DataTables on the template page, that's all. Amended patch: Since bug 10565 has been pushed, these patches don't apply cleanly. I had to rewrite a part of the patron list feature. I removed the choice to add all resultant patrons from a search. I think this choice is useless with this patch: we are able to display the number of patrons we want and to select all of them. Test plan: - Check that there is no regression on searching patrons. - Try filters on the left of the screen. - Try to sort each column. - Try the "Browse by last name" links. - Check that the "Clear" button clears yours filters. - Try with IndependantBranches ON and OFF. - Verify this feature does not break the patron list feature (cf bug 10565). Signed-off-by: Cedric Vita Signed-off-by: Katrin Fischer Passes all tests and QA script, couldn't find any regressions or problems. Some notes left on the bug. Bug 9811: Add unit tests for C4::Utils::DT::Members Signed-off-by: Katrin Fischer Bug 9811: QA followup - removes 2 tabs - removes mysqlisms - add sort on borrowernotes - fix wrong capitalization - cat => Category Signed-off-by: Katrin Fischer Thx for fixing these! Bug 9811 - multilines notes brakes JSON In new patron search feature, the search results are fetched using Ajax and returned in JSON format. The JSON is created by TT using koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt. One of the fields is the borrower notes. When this notes contains several lines, the JSON is broken. This patch uses TT fileters to consert in notes linefeeds into HTML line break (html_line_break) and then remove linefeeds (collapse). Test plan : - perform a member search that does not return a borrower with a circ note - edit one of the borrowers returned by this search - enter serveral lines of text in "Circulation note" and save - reperform the member search => circ note is well displayed on several lines Bug 9811: use count(primary_key) instead of count(*) Bug 9811: A limit clause should be always added. By default, we want to retrieve 20 first results. Bug 9811: Load the page without any data. Displaying the first 20 patrons is not useful. With this patch, the table is hidden and no record is retrieved by default. On the same way, the existing side effect on redirect disappears. Signed-off-by: Olli-Antti Kivilahti ------------- -TEST REPORT- ------------- For the filter: Tested all the search fields, branches, search type. Found a bug with "date of birth", followup provided. Tested display limits and verified that AJAX-queries are efficient (using LIMIT clause) to not stress DB needlessly. Tested adding Patrons to a list. A good feature, which seems to work quite well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:17:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:17:38 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26068|0 |1 is obsolete| | --- Comment #98 from Jonathan Druart --- Created attachment 27643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27643&action=edit Bug 9811: FIX branches loop was not correctly set The branches loop was not set with the values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:17:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:17:44 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26261|0 |1 is obsolete| | --- Comment #99 from Jonathan Druart --- Created attachment 27644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27644&action=edit Bug 9811: Fixing JSON validation error for non-javascript string literal characters Issue: When a patron has backslashes in his circulation notes, the JSON transportation layer cannot send the message because it will fail JSON validation when trying to validate backslashed non-literal characters (\s \d ...). This causes the whole search to fail when even one Borrower has a non-literal backslashed character in his notes. Solution: The Borrowers' circulation notes are filtered through a regexp which doubles all backslashes to prepare them for the JSON validation routine. Result: Backslashes pass through unchanged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:17:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:17:50 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26337|0 |1 is obsolete| | --- Comment #100 from Jonathan Druart --- Created attachment 27645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27645&action=edit Bug 9811: FIX encoding issue on patron categories The patron categories should use the html_entity filter (on the current master). Signed-off-by: Olli-Antti Kivilahti This fix solves the issue of double encoding some utf8-characters by html_encoding the patron categories, which are not marked as utf8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:17:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:17:57 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26347|0 |1 is obsolete| | --- Comment #101 from Jonathan Druart --- Created attachment 27646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27646&action=edit Bug 9811 - datetime does not respect DateFormat-system prefrence To test: Try searching by the date of birth using the left filter column. Good luck. After applying this patch: You can search using your preferred DateFormat. Merci bocu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:18:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:18:50 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #102 from Jonathan Druart --- The last patch set only fixes the patches order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:37:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:37:30 +0000 Subject: [Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:37:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:37:51 +0000 Subject: [Koha-bugs] [Bug 12118] Unnecessary YUI assets included in offline circ manifest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:38:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:38:07 +0000 Subject: [Koha-bugs] [Bug 12131] C4/TmplToken.pm has an unnecessary dependency on Exporter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:38:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:38:18 +0000 Subject: [Koha-bugs] [Bug 12119] Move jeditable jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12119 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:38:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:38:27 +0000 Subject: [Koha-bugs] [Bug 12116] Move fixFloat jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12116 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:38:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:38:38 +0000 Subject: [Koha-bugs] [Bug 12101] Move Greybox library outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:38:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:38:50 +0000 Subject: [Koha-bugs] [Bug 12107] Move checkboxes jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12107 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:39:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:39:03 +0000 Subject: [Koha-bugs] [Bug 12103] Move ajaxfileupload jQuery plugin outside of language-specific directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12103 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:39:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:39:10 +0000 Subject: [Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #12 from Katrin Fischer --- Thanks Galen for providing the solution :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:39:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:39:20 +0000 Subject: [Koha-bugs] [Bug 12112] C4::Breeding::ImportBreeding() is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12112 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 17:41:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 15:41:42 +0000 Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Pasi! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 18:33:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 16:33:39 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com Component|Staff Client |Patrons Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 18:37:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 16:37:12 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #3 from Owen Leonard --- Please provide a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 19:23:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 17:23:14 +0000 Subject: [Koha-bugs] [Bug 12144] New: Book drop mode mode erasing fine when CalculateFinesOnReturn is enabled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12144 Bug ID: 12144 Summary: Book drop mode mode erasing fine when CalculateFinesOnReturn is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When returning items with Book drop mode mode enabled and CalculateFinesOnReturn set to "calculate", the amountoutstanding for a fine, no matter how large, is reduced to 0.00 To reproduce: 1) Fine a patron with and overdue item that has fines 2) Ensure CalculateFinesOnReturn is enabled 3) Browse to the returns screen, check the "Book drop mode" but *not* the "Forgive overdue charges" box 4) Return the item 5) Check the fine for that item, it should now be reduced to 0.00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:05:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:05:41 +0000 Subject: [Koha-bugs] [Bug 12145] New: Lock for Move up buttons with Marc tag Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 Bug ID: 12145 Summary: Lock for Move up buttons with Marc tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Dear Developers, Our staff in cataloguing section have complained about "move up" button with MARC tags in cataloguing sheet. They always accidently click on move up button while cataloguing process. Accidental clicking on move up button change the order of subfileds (26$a,b,c). It make errors in data entry process. Our cataloguers suggest a lock option for "Move up" buttons with MARC subfields. Lock option should be in Gloabl system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:06:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:06:44 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:34:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:34:14 +0000 Subject: [Koha-bugs] [Bug 5352] Suggestion messages to patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5352 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 5539 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:34:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:34:14 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 5352, which changed state. Bug 5352 Summary: Suggestion messages to patron http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5352 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:34:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:34:14 +0000 Subject: [Koha-bugs] [Bug 5539] Options for Suggestion Emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5539 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #1 from Owen Leonard --- *** Bug 5352 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:36:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:36:19 +0000 Subject: [Koha-bugs] [Bug 5496] Ergonomic improvement in smart rule management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5496 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:41:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:41:12 +0000 Subject: [Koha-bugs] [Bug 6910] Duplicate system logs output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6910 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:41:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:41:57 +0000 Subject: [Koha-bugs] [Bug 6456] Display of barcode in search result in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6456 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:50:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:50:34 +0000 Subject: [Koha-bugs] [Bug 7014] sorting of call numbers in Inventory tool is not correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7014 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Owen Leonard --- The inventory tool has substantially changed since 3.4 so I think we can assume this is fixed (or at least invalid because the output of the inventory tool has changed). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:51:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:51:05 +0000 Subject: [Koha-bugs] [Bug 5387] Support for NISO CORE: Cost of Resource Exchange Protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5387 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 20:56:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 18:56:12 +0000 Subject: [Koha-bugs] [Bug 6859] autoMemberNum doesn't automatically fill fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6859 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- 3.4 is no longer being maintained, and this problem doesn't appear to exist in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:04:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:04:34 +0000 Subject: [Koha-bugs] [Bug 6122] Catalogue reports exclude biblio without item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6122 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- 3.4 is no longer being maintained, and this bug hasn't gotten any confirmation. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:24:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:24:01 +0000 Subject: [Koha-bugs] [Bug 6266] Ordering from staged file gives perl error when no budget defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6266 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:25:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:25:43 +0000 Subject: [Koha-bugs] [Bug 6676] Acquisition basket access control trivially by-passable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6676 --- Comment #4 from Owen Leonard --- Is this bug valid in master? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:26:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:26:18 +0000 Subject: [Koha-bugs] [Bug 5938] Maximum number of issues across a family group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5938 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:29:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:29:39 +0000 Subject: [Koha-bugs] [Bug 4450] Type of error return causes problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:30:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:30:14 +0000 Subject: [Koha-bugs] [Bug 5181] Add js to convert units when units are changed on label or card template form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5181 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:32:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:32:07 +0000 Subject: [Koha-bugs] [Bug 4450] Type of error return causes problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4450 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:39:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:39:02 +0000 Subject: [Koha-bugs] [Bug 5927] Show series information in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:39:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:39:36 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:40:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:40:58 +0000 Subject: [Koha-bugs] [Bug 4241] Add lost/claims returned displays to patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4241 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|ASSIGNED |NEW Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:43:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:43:56 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:54:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:54:08 +0000 Subject: [Koha-bugs] [Bug 4523] aqbudgets.pl - possibility to show / hide the filters menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4523 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #6 from Owen Leonard --- Not sure why this isn't marked as having been pushed to master. It appears to have been in Koha since 2010. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:55:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:55:53 +0000 Subject: [Koha-bugs] [Bug 7386] Label batches cannot be batch deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master OS|Linux |All -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 21:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 19:56:46 +0000 Subject: [Koha-bugs] [Bug 7335] Allow custom parameters for sorting in sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7335 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 22:00:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 20:00:45 +0000 Subject: [Koha-bugs] [Bug 5145] Call number in XSLT availability information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5145 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 22:01:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 20:01:48 +0000 Subject: [Koha-bugs] [Bug 6481] Koha doesn't have a way to set a preferred language from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6481 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 22:03:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 20:03:01 +0000 Subject: [Koha-bugs] [Bug 6795] Branch-specific OPAC preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6795 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master --- Comment #1 from Owen Leonard --- The Contextual Preferences Engine? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 22:10:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 20:10:23 +0000 Subject: [Koha-bugs] [Bug 5985] Incorrect date in budgets and failed to edit funds children In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5985 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master Assignee|nunyo at masmedios.com |koha-bugs at lists.koha-commun | |ity.org Severity|enhancement |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 22:10:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 20:10:55 +0000 Subject: [Koha-bugs] [Bug 5985] Incorrect date in budgets and failed to edit funds children In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5985 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3496|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 25 22:12:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Apr 2014 20:12:06 +0000 Subject: [Koha-bugs] [Bug 3069] Koha Z39.50 client process discussion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3069 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 10:14:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 08:14:52 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 10:14:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 08:14:54 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27628|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 27647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27647&action=edit [PASSED QA] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. This patch proposes, in case CAS is enabled, to redirect to the opac-user.pl page (like prog theme). This is because the popup content should stay small (thinking about mobile surf), and that CAS url is actually only computed in opac-user (see C4/Auth.pm) and it would not be performant to compute it in all pages. Test plan: - set syspref opacthemes to bootstrap - enable the casAuthentication syspref - fill the casServerUrl syspref with something like: https://localhost:8443/cas - go on the opac home page - click on "Log in to your account" link (top right) => You go to cgi-bin/koha/opac-user.pl page where you see the cas link - disable the casAuthentication syspref - go on the opac home page - click on "Log in to your account" link (top right) => You see a popup for loggin and password Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Normal login still works with/without CAS. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 10:33:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 08:33:32 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #14 from Katrin Fischer --- I am having problems resolving the conflict here correctly - sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:11:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:11:48 +0000 Subject: [Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 --- Comment #12 from mathieu saby --- OK for me. I rewrite the patch. mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:27:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:27:27 +0000 Subject: [Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27037|0 |1 is obsolete| | --- Comment #13 from mathieu saby --- Created attachment 27648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27648&action=edit [PATCH] Bug 11433 - Remove attachbasket op value in basket.pl and rename it in basketgroup.pl This patch cleans code in basket.pl In basket.pl, some code is supposed to be executed if $op eq 'attachbasket'. But it is never the case (grep attachbasket * -r), so this condition must be removed. This patch - removes code related to 'attachbasket' in basket.pl No functional change expected. Regression test only : Make a complete acquisition process, from the creation of a basket to the closure of a basketgroup, and check everything is OK On a basket page, try to change the basketgroup it belongs to, and check everything is OK On a basketgroup page, try to edit the content of a basketgroup (put a new basket in it, change the deliverybranch...), and check everything is OK On a basketgroup page, try to reopen a closed basketgroup, and close an open basketgroup, and check everything is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:27:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:27:58 +0000 Subject: [Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:28:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:28:19 +0000 Subject: [Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove attachbasket op |Remove attachbasket op |value in basket.pl and |value in basket.pl |rename it in basketgroup.pl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:29:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:29:39 +0000 Subject: [Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 --- Comment #14 from mathieu saby --- I rewrote the patch. It now only removes useless code. As it is no more the same patch, I changed its name, and removed Marcel's sign off (maybe I could have kept it?). Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:42:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:42:11 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 --- Comment #5 from mathieu saby --- Created attachment 27649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27649&action=edit [PATCH 2/2] Bug 12111 - QA followup : fix breadcrumbs wording for vendor note As asked by QAer, this followup fixes wording in modordernotes.tt for vendor note (Change order vendor note vendor note => Change order vendor note) It also uses [%- and -%] to make code more readable Test plan : try to edit a vendor note, check the wording is correct in breadcrumbs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:42:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:42:39 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:43:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:43:46 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:44:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:44:44 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:45:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:45:31 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 --- Comment #4 from mathieu saby --- Patch still applies in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:48:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:48:06 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:48:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:48:09 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27536|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 27650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27650&action=edit [PASSED QA] Bug 10823 - add class info to enumchron data in detail.tt, for better styling Bug 10825 removes a duplicate (enumchron==serialseq). This patch was developed on top of it. It properly styles the elements. These include: - items.enumchron - the separator used - serial.serialseq - items.publisheddate As per Katrin's and Owen's suggestion, was used instead of
    . (See comment #7 and http://irc.koha-community.org/koha/2014-04-03#i_1491135) TEST PLAN --------- 1) Apply patch 10825 2) Find a biblio where the enumchron and serialseq are different. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 3) In the staff client, view the source for that item. -- It should be one class for the entire cell. 4) Apply patch 10823 5) Refresh the page 6) Look at the source for that item again. -- It should have tags around the 4 things listed above. 7) Run the koha qa test tools. Signed-off-by: Mark Tompsett NOTE: Since there was lots of squashing and rebasing, could you please test and sign this off as well, Mason? Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Template change only, no regression found. Using [%- -%] could improve readability of HTML source code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:49:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:49:40 +0000 Subject: [Koha-bugs] [Bug 11724] Make Funds/Status on suggestions page sortable/searchable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26363|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Comment on attachment 26363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26363 Bug 11724 - Make Funds/Status on suggestions page sortable/searchable Please remember to obsolete the original patch when signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:54:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:54:38 +0000 Subject: [Koha-bugs] [Bug 11724] Make Funds/Status on suggestions page sortable/searchable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 14:54:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 12:54:40 +0000 Subject: [Koha-bugs] [Bug 11724] Make Funds/Status on suggestions page sortable/searchable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27515|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 27651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27651&action=edit [PASSED QA] Bug 11724 - Make Funds/Status on suggestions page sortable/searchable The fund and status columns on the suggestions page are not sortable or searchable. This patch makes them so. This patch also amends the DataTables configuration to use class-based targeting for sorting types as was decided on the koha-devel list. The table markup has been modified accordingly. To test you must have existing suggestions. Apply the patch and go to Acquisitions -> Suggestions. View the table of existing suggestions and confirm that the funds and status columns are sortable and searchable. Confirm that the title column correctly ignores articles when sorting. Signed-off-by: David Cook Works as described. Signed-off-by: Katrin Fischer Works as described, template change only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:04:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:04:19 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 --- Comment #8 from Katrin Fischer --- Created attachment 27652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27652&action=edit [PASSED QA] Bug 11769 - Use validation plugin when creating new MARC framework The page for adding a new MARC framework includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> MARC bibliographic framework -> New framework. Try submitting the form without entering a tag number. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing framework should also work correctly. Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:04:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:04:21 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 --- Comment #9 from Katrin Fischer --- Created attachment 27653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27653&action=edit [PASSED QA] Bug 11769 [Follow-up] Use validation plugin when creating new MARC framework This follow up adds the correct "required" style to the required form fields as well as the "required" text after each required field. To test, apply all patches and go to Administration -> MARC bibliographic framework -> New framework. The framework code and description fields should show that they are required. Signed-off-by: David Cook Works as described and feels a million times better. Signed-off-by: Katrin Fischer Works as described, template changes only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:05:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:05:09 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:05:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:05:11 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27514|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:05:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:05:13 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25902|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:12:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:12:24 +0000 Subject: [Koha-bugs] [Bug 7125] can't change tag in frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:12:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:12:26 +0000 Subject: [Koha-bugs] [Bug 7125] can't change tag in frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27499|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 27654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27654&action=edit [PASSED QA] Bug 7125 - can't change tag in frameworks When you edit an existing tag in a MARC framework the form makes it appear as if you can change the tag number when in fact you cannot. This patch changes the template so that the tag number does not appear as an editable form field during the edit process. To test, apply the patch and open an existing MARC framework in Adminstration -> MARC bibliographic framework. - Choose an existing tag from the list and click 'Edit.' - The line labeled "Tag" should display the tag as text. - Making a change to any of the tag's details should work correctly. - Return to the list of the MARC framework's tags. - Click 'New tag.' - The line labeled "Tag" should display a blank form field. - Create a new tag and confirm that it saves correctly. Signed-off-by: Bernardo Gonzalez Kriegel Work as describes, on edit and new. No koha-qa errors Signed-off-by: Katrin Fischer Work as described, template change only. Checked editing and adding tags. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:19:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:19:17 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I am sorry, but this patch no longer applies: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 12088 [Revised] Improve date handling and sorting in holds to pull report fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:31:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:31:16 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 --- Comment #19 from Katrin Fischer --- I think this is more of a bug fix then an enhancement as it makes the funds list for staged orders behave like the funds list on neworderempty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:35:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:35:46 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27533|0 |1 is obsolete| | Attachment #27583|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 27655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27655&action=edit [PASSED QA] Bug 10875: Add order from a staged file should not display inactive funds When adding an order from a staged file, a link "show all funds" is now added on the top of the page. All inactive funds are hidden by default. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Passes all tests and QA script. Works as described. - Loading the page, a fund needs to be selected. Before the patch the first fund was preselected. - Checking the checkbox, inactive funds show up, but are not visible otherwise. - If the fund is selected from the MARC file, the correct fund will be selected, even if it's inactive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:35:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:35:43 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 15:35:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 13:35:57 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 --- Comment #21 from Katrin Fischer --- Created attachment 27656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27656&action=edit [PASSED QA] Bug 10875: Preselect the fund located in the record It is useless to copy the fund list in a new node. It seems easier to hide/show inactive/active funds. This patch also adds a "(inactive)" marker in the fund list for inactive funds. If the fund located in the record is inactive, it is displayed by default and cannot be hidden. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 17:09:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 15:09:21 +0000 Subject: [Koha-bugs] [Bug 12146] New: Add new ISO code column to currency sample files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 Bug ID: 12146 Summary: Add new ISO code column to currency sample files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 9593 adds a new column for ISO code to the currency table. This column should also be added to the currency sample files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 17:09:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 15:09:30 +0000 Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9593 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 17:09:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 15:09:30 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12146 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 17:36:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 15:36:44 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 17:36:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 15:36:47 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27391|0 |1 is obsolete| | Attachment #27392|0 |1 is obsolete| | --- Comment #72 from Katrin Fischer --- Created attachment 27657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27657&action=edit [PASSED QA] Bug 9593 Prices not imported correctly from a staged file Initial bug : When there's a round price with no decimals after it, or when the symbol is after the digits, the price is not captured by regular expression in MungeMarcPrice routine and the variable is not initialized. Enhancement : The MungeMarcPrice routine had been widely modified. It 's still possible to priority pick the active currency but unlike the previous mechanism that worked only for prices preceded by the currency sign, it's now valid wherever the symbol is situated. As symbol you may enter a pure currency sign as well as a string including it like '$US'. Moreover, an 'isocode' column had been added in currency table (editable in the pro interface from Administration/Currencies and exchange rates). So the active currency can be picked either through its symbol or through its iso code. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests, especially t/db_dependent/MungeMarcPrice.t Checked currencies can be added, edited and deleted. Notes: new ISO code field is mandatory. Sample sql files need to be updated (bug 12146) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 17:37:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 15:37:02 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #73 from Katrin Fischer --- Created attachment 27658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27658&action=edit [PASSED QA] Bug 9593 [QA Followup] Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 17:42:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 15:42:08 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #74 from Katrin Fischer --- I am still a bit torn about this patch and the new column. I think we need a follow up to clean up the sample files at least. Also the new field being mandatory means that you are forced to fill it in on editing now, but I see no way to get around that. Does it really need to be mandatory? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 18:14:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 16:14:00 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- Please always add the commit message to the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 18:14:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 16:14:14 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 --- Comment #13 from Katrin Fischer --- ... the test plan to the commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 18:22:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 16:22:01 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27527|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 27659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27659&action=edit [SIGNED_OFF] Bug 11631: Make i18n toolchain ignore useless strings Copy of test plan: Test: 1) Update PO files of some lang, xx-YY-*po cd misc/translator perl translate update xx-YY 2) Do it again, just in case 3) rm po/xx-YY*po~ 4) Extract all msgid's, sorted cat po/xx-YY*po | egrep "^msgid" | sort | uniq > xx-YY-pre 5) Apply the patch 6) Repeat 1-3 7) Repeat 4 again, other file cat po/xx-YY*po | egrep "^msgid" | sort | uniq > xx-YY-post 8) Do a diff, inspect results, only strings with %s and \s diff xx-YY-pre xx-YY-post | less Signed-off-by: Bernardo Gonzalez Kriegel Works as described, 380 strings less to 'translate' No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 18:22:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 16:22:39 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 --- Comment #15 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #13) > ... the test plan to the commit message. Not my patch, but my test plan :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 26 18:26:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Apr 2014 16:26:02 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #20 from M. Tompsett --- Comment on attachment 27191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27191 Bug 9088: Neworderempty should preselect the only active fund Review of attachment 27191: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9088&attachment=27191) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt @@ +425,5 @@ > + [% FOREACH budget_loo IN budget_loop %] > +
  • know easily what are the new items in the catalogue.
  • This still requires SQL, so doesn't seem to depend on the feature. +
  • display an icon in the search results for new items.
  • The only way to do this I can come up with is limited to libraries using biblio level itypes and by switching the itemtype with the script. +
  • configure issuing rules depending the 'new' status.
  • I think this would also require switching the itemtype? +
  • get a RSS/Atom feeds on these new items.
  • I think this would require using a special value in an item column that is searchable with Zebra. So you can build a search in Zebra that can then be used for the RSS feed? 4) biblioitems a) I am worried about some columns that should not be substituted: biblionumber, itemnumber, barcode, totalissues, onloan ... I think those are potentially dangerous and should not be listed. b) To me it seems like the only goal of including biblioitems is the possibility to change the bibliotitems itemtype. As it is now, it also allows changing values like title, pages, etc. which borders on a record batch edit. To me this seems a bit misplaced here. Also, ToggleNewStatus seems to only do ModItem - but you can define substitutions for biblioitems? (see also 6) 5) GUI a) It's not possible to edit a single rule. In order to add a rule or edit a rule, you always have to use 'Edit' and then all rules will display, the form for adding the new rule is at the very bottom. It is not very comfortable. b) There are no mandatory fields, duration is optional, as are conditions and substitions. So you can define an empty rule. c) In all other item related forms we use the names defined for the columns in the default framework (at least that's where I think those come from). But this feature only shows the names of the database columns. I think this is because of 2 a)? 6) Exploding? I defined a mean rule: Duration: 1 (only 1 item in my database has an accessiondate from yesterday) Conditions: no condition Substitutions: biblioitems.publishercode = XXXX biblioitems.url = something biblioitems.itemtype = XXXX items.barcode = xxxx items.materials = xxxx I didn't expect much to happen, but I had misinterpreted the duration. Results: DBD::mysql::st execute failed: Unknown column 'biblioitems.publishercode' in 'field list' at /home/katrin/kohaclone/C4/Items.pm line 2324. ERROR in _koha_modify_item UPDATE items SET biblioitems.publishercode=? WHERE itemnumber=?: Unknown column 'biblioitems.publishercode' in 'field list' at /home/katrin/kohaclone/C4/Items.pm line 2327. DBD::mysql::st execute failed: Unknown column 'biblioitems.url' in 'field list' at /home/katrin/kohaclone/C4/Items.pm line 2324. ERROR in _koha_modify_item UPDATE items SET biblioitems.url=? WHERE itemnumber=?: Unknown column 'biblioitems.url' in 'field list' at /home/katrin/kohaclone/C4/Items.pm line 2327. DBD::mysql::st execute failed: Unknown column 'biblioitems.itemtype' in 'field list' at /home/katrin/kohaclone/C4/Items.pm line 2324. ERROR in _koha_modify_item UPDATE items SET biblioitems.itemtype=? WHERE itemnumber=?: Unknown column 'biblioitems.itemtype' in 'field list' at /home/katrin/kohaclone/C4/Items.pm line 2327. DBD::mysql::st execute failed: Duplicate entry 'xxxx' for key 'itembarcodeidx' at /home/katrin/kohaclone/C4/Items.pm line 2324. ERROR in _koha_modify_item UPDATE items SET items.barcode=? WHERE itemnumber=?: Duplicate entry 'xxxx' for key 'itembarcodeidx' at /home/katrin/kohaclone/C4/Items.pm line 2327. Of course, no all my items have xxxx in materials. I thought initially only those items exactly 1 day old would be touched. But it will change all items older than 1 day. So this potentially will update a lot of items on each run. The SQL also shows that you can't actually update biblioitems columns, although the GUI offers the option. -------- I really like the idea of this, but to me it seems like there is some sort of mismatch between the feature description and how it seems to work. It feels like it needs some more thought. I think maybe this feature 'grew' since its initial specification? An example for a mismatch is also the description of the cronjob: +./toggle_new_status.pl -h + +Toggle recent acquisitions status. +Use this script to delete "new" status for items. There is no mention of the new column in the script. Another problem I see is that the feature as it is now is potentially quite dangerous and substitiutions on biblioitems don't work. Maybe biblioitems should be removed altogether from this. I'd love to hear some more opinions on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 15:09:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 13:09:07 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #37 from Katrin Fischer --- Sorry, lots of conflicts: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10212: Columns configuration for tables - Add Colvis files Applying: Bug 10212: Columns configuration for tables Using index info to reconstruct a base tree... M circ/circulation.pl M installer/data/mysql/kohastructure.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/js/datatables.js M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt :223: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/datatables.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/js/datatables.js Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 15:12:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 13:12:50 +0000 Subject: [Koha-bugs] [Bug 12091] Ugly HTML for editing authority MARC subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12091 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 15:26:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 13:26:28 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer --- Some older tests fail on applying these patches: # Biblio-level hold, renewal test not ok 21 - (Bug 10663) Cannot renew, reserved # Failed test '(Bug 10663) Cannot renew, reserved' # at t/db_dependent/Circulation.t line 266. # got: '0' # expected: '1' not ok 22 - (Bug 10663) Cannot renew, reserved # Failed test '(Bug 10663) Cannot renew, reserved' # at t/db_dependent/Circulation.t line 268. # got: '0' # expected: '1' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 15:36:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 13:36:33 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #46 from Katrin Fischer --- With these patches some unit tests fail, they are ok on master: t/Koha_MetadataRecord.t (Wstat: 512 Tests: 4 Failed: 2) Failed tests: 3-4 Non-zero exit status: 2 t/Koha_Util_MARC.t (Wstat: 512 Tests: 4 Failed: 2) Failed tests: 2-3 Non-zero exit status: 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 17:57:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 15:57:56 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #14 from Katrin Fischer --- Still not so happy about the Python dependency... but - this won't get into the way if you haven't installed it - no regressions found with existing export options I am going to pass it, as it works nicely. Leaving final decision to RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 17:58:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 15:58:25 +0000 Subject: [Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9959 --- Comment #3 from Marc V?ron --- Hi Owen, Thanks for the comments and for testing. The program logic in handles the cases "itemtypes" and "ccode" only, there is no code for "loc" (as far as I can see). I do not know why, I suppose this has historical reasons. My patch only tries to fix the problem with pipe-separated values in AdvancedSearchTypes by deciding what value (itemtypes or ccode) to take, because the existing code in opac-topissues.pl definitvely can not digest values like "itemtypes|ccode". Can you please repeat your tests without my patch? - I suppose that you will get the same or similar results. Maybe there ist a relation to Bug 9959? And I agree with your comment: "Shouldn't these combination value offer some combination of limiters? I would expect either a dropdown which combined both collection codes and item types, or a separate dropdown for collection and item type." With other words: The whole functionality would need a re-write. This would be a somewhat bigger thing, though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 17:58:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 15:58:25 +0000 Subject: [Koha-bugs] [Bug 9959] Filters for 'Most popular' page in OPAC show wrong behaviour In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9959 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12136 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 17:58:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 15:58:34 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 17:58:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 15:58:37 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26397|0 |1 is obsolete| | Attachment #26398|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 27681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27681&action=edit [PASSED QA] Bug 11679: Add ods as a format for reports This patch adds the ability to export the data generated by a report into a ods file. Test plan: 1/ Install csv2ods: Please have a look at https://code.google.com/p/scone-fu. - git clone https://code.google.com/p/scone-fu/ - cd scone-fu/code/python/odfpy-0.9.3/ - sudo python setup.py install 2/ Verify you are able to generate an ods file from a report result. Signed-off-by: Aurelie Fichot Signed-off-by: Katrin Fischer Passes tests and QA script. If python library is not installed, no additional options show up. If the library is installed a new export option Open Document Spreadsheet appears. All import options work nicely, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 18:01:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 16:01:23 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #16 from Katrin Fischer --- Created attachment 27682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27682&action=edit [PASSED QA] Bug 11679: FIX encoding in CSV file Previously, the CSV file was not in encoded in utf8 and the csv2ods command failed with the following error if diacritics existed: UnicodeDecodeError: 'utf8' codec can't decode byte 0xe9 Signed-off-by: Aurelie Fichot Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 18:09:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 16:09:32 +0000 Subject: [Koha-bugs] [Bug 9959] Filters for 'Most popular' page in OPAC show wrong behaviour In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9959 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 18:09:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 16:09:36 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 18:13:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 16:13:17 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion Severity|minor |enhancement --- Comment #18 from Katrin Fischer --- I think we haven't been able to find consensus on how this should work so far. I'd suggest to try and get some more opinions from libraries on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 18:15:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 16:15:43 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- This depends on 11625 as we are still trying to agree how this should be working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 19:36:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 17:36:36 +0000 Subject: [Koha-bugs] [Bug 12147] Column width for action links on invoices too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- It really looks ugly... My first idea was to put non breakting spaces around te slashes in lines 144 and 151 in invoices.tt, but this does not work out because of the formatting (indenting) with spaces. One would have to putt all of the if-else-logic on one line, and that is no good idea. Looking at the HTML code I see tat all column headers get a hardcoded style "width" with values between 19.2 and 126.2px - exept of the last one with the action links. But I do not see where this is done? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 21:30:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 19:30:24 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #94 from Katrin Fischer --- Hi Kyle, NEEDS REBASE! I tried to fix the conflicts, but wasn't sure I got it right so continued testing the patches on top of 2a7e71554b534f8d79cdbdc9552bc78bba9c4408 - the patches apply on this commit without conflicts. 1) In the holds table, the replacing technique is not working correctly: Die R?uber by _AUTHOR_ Schiller, Friedrich 2) On the relative's checkouts tab the price is not formatted correctly: 0.000. Maybe 0 shouldn't show at all? 3) On the checkuts tab the checkout date shows in 'database' format: 2014-04-27 21:10:00. It also still shows the seconds, although those are not recorded and the time is always :00. X) It doesn't feel faster than before :( It could just be my installation, but hard to tell for me. I'd really like to get another opinion on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 21:36:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 19:36:45 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #20 from Katrin Fischer --- I am sorry, but there are a lot of conflicts in aqbudgets.tt: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11578: Upgrade the treetable jquery plugin Applying: Bug 11578: Improve the funds list view /home/katrin/kohaclone/.git/rebase-apply/patch:465: trailing whitespace. [% ELSIF ( budget.remaining_neg ) %] warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Budgets.pm M admin/aqbudgets.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt :465: trailing whitespace. [% ELSIF ( budget.remaining_neg ) %] warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt Auto-merging admin/aqbudgets.pl Auto-merging C4/Budgets.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 21:58:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 19:58:17 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27434|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 27683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27683&action=edit [PASSED QA] Bug 11665: An ability to place orders directly from hold ratios list This enhancement introduces a possibility to place orders from hold ratios list: - new option "Add order to basket" -> "From titles w/ highest hold ratios"; (user gets redirected from acqusition to "hold ratios" list in circulation) - "N to order" in "Items needed" column now becomes a link - when clicked, user gets redirected back to acquisition, directly to order form for a choosen title (suggested quantity "N to order" is being preserved) - in the "Items needed" column, there is an additional indication if there are any pending (not yet received) orders for a given title This solution is not exactly ideal.. most important drawback: to use it librarian needs both acquisition & circulation priviledges; if not having both - new options will not show / wouldn't be active. But it requires relatively small amount of changes in the code. To test: - apply patch, - test new functions (try to place some orders using an newly added option, examine resulting order records etc.) - check modified hold ratios list for possible problems (for user with only circulation priviledges, additional information regarding pending orders should be still visible, but not the link to order form) - ensure the two following existing options for adding orders to basket ("From an existing record", "From a new (empty) record") a still working properly. Signed-off-by: Owen Leonard Minor edit in signoff: Changed "w/" to "with" Signed-off-by: Katrin Fischer This works nicely in my tests, neat new addition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 21:58:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 19:58:46 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27434|1 |0 is obsolete| | --- Comment #4 from Katrin Fischer --- Comment on attachment 27434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27434 [SIGNED-OFF] Bug 11665: An ability to place orders directly from hold ratios list Review of attachment 27434: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11665&attachment=27434) ----------------------------------------------------------------- I am a bit torn about this patch. It seems to work nicely, no problems found. ::: circ/reserveratios.pl @@ +185,5 @@ > ); > > output_html_with_http_headers $input, $cookie, $template->output; > + > +sub CountPendingOrdersByBiblionumber { But I wonder if this should not be in the .pl file, but in Acquisitions.pm with unit tests. Maybe also orders should be OrderedItems? Waiting for another opinion, leaving this a signed off for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 23:18:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 21:18:36 +0000 Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- This is definitely a problem, we have seen this. Our solution was to use a zconn per search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 23:27:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 21:27:04 +0000 Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #5 from Katrin Fischer --- Comment on attachment 27487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27487 [SIGNED-OFF] Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref Review of attachment 27487: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7981&attachment=27487) ----------------------------------------------------------------- Quick code review: - patch should also delete HomeOrHoldingBranchReturn from sysprefs.sql - I think the updatedatabase message could note that we remove HomeOrHoldingBranchReturn in favor of the circulation rules - Is there an existing test for the return policies? ... and now... sleep. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 27 23:31:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 21:31:49 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #103 from Katrin Fischer --- Patches still apply, QA script noted something small: FAIL C4/Utils/DataTables/Members.pm OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 204) OK valid OK critic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 00:01:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 22:01:55 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #17 from Galen Charlton --- (In reply to Katrin Fischer from comment #14) > Still not so happy about the Python dependency... but > - this won't get into the way if you haven't installed it > - no regressions found with existing export options > > I am going to pass it, as it works nicely. Leaving final decision to RM. And my decision is this: given that LibreOffice and friends can readily import CSV files, I am reluctant to add something that - requires a Python library that is not packaged for Debian - requires direct execution by the webserver of a non-core utility, which opens Koha up to the potential for an attack via an untrusted executable called csv2ods getting onto the system PATH. I'm especially reluctant to do so in the face of the existence of two alternatives for creating ODS files: [1] Extending the code in C4::ImportExportFramework [2] The existence of the OpenOffice::OODoc Perl module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 00:03:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 22:03:26 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #20 from Galen Charlton --- Pushed to master. Thanks, Mason! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 00:03:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 22:03:50 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #17 from Galen Charlton --- Pushed to master. Thanks, Pasi! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 00:04:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 22:04:10 +0000 Subject: [Koha-bugs] [Bug 11497] i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 00:04:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 22:04:50 +0000 Subject: [Koha-bugs] [Bug 11497] i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 --- Comment #6 from Galen Charlton --- (In reply to Katrin Fischer from comment #4) > Maybe we should add this to the coding guidelines? Although I pushed the patch, the construct that it replaces seems useful on the face of it, and it's certainly less verbose. I'd rather see the translation code be taught how to deal with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 00:05:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 22:05:12 +0000 Subject: [Koha-bugs] [Bug 12138] Use placeholders in translatable javascript strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12138 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Pasi! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 00:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 22:05:32 +0000 Subject: [Koha-bugs] [Bug 11227] Staff po files contain some Javascript In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 00:05:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 22:05:47 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 01:49:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Apr 2014 23:49:30 +0000 Subject: [Koha-bugs] [Bug 12091] Ugly HTML for editing authority MARC subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12091 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel --- Mark, no problem to test but... 1. Test plan is missing 2. I think that we must try (fervently) not to put HTML in scripts So, this kind of construct $row_data{repeatable} = "{'repeatable'} ? 'checked="checked" ' : '') . "name=\"repeatable$i\"> it's calling for a FaliedQA :( Perhaps can be replaced by (in script) $row_data{repeatable} = { id => repeatable$i, name => repeatable$i, repeatable => $data->{'repeatable'}, } (in tt) [% IF ( ...row.repeatable ) %] [% IF ( ...row.repeatable.repeatable ) %] [% ELSE %] [% END %] [% END %] or something similar 3. Bug status, it's ready to be signed? Then change that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 03:38:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 01:38:14 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26736|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 03:38:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 01:38:29 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:03:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:03:13 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 27687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27687&action=edit Bug 12017 - 1 - Move language description out of database This patch adds identical copies of languages.inc file on include dirs, and modifies include files to process it. To test: 1. No change on current behavior must be observer, any page staff/opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:03:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:03:17 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #20 from Bernardo Gonzalez Kriegel --- Created attachment 27688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27688&action=edit Bug 12017 - 2 - Enable languages on web installer This patch modifies installer/step1.tt to use new language descriptions. Only parameter used is rfc4646 code. To test: 1. Do some fake translations, for example all langs for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do mkdir koha-tmpl/intranet-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/bootstrap/$l; mkdir koha-tmpl/opac-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/ccsr/$l; done or make some lang dirs on intranet-tmpl/prog 2. Apply the patch 3. Edit your koha-conf.xml, change database name to a new name, create that database and grant access, reload staff page, log in with database user, you will be redirected to step1 of web installer. 4. Check names and codes for installed languages. Revert to your old database before proceed, but left dirs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:03:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:03:22 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #21 from Bernardo Gonzalez Kriegel --- Created attachment 27689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27689&action=edit Bug 12017 - 3 - Change lang display on sysprefs I18N This patch change the display of languages on sysprefs to set translated languages on I18N Only parameter used is rfc4646 subtag To test: 1. Apply the patch 2. Go to I18N syspref, look language descriptions Following steps are for next patch 3. Set a bunch of languages for staff/opac, save, reload Inlude vi-VN for which there is no current description in databasse 4. Set opaclanguagesdisplay to Allow Current display is preserved, native description for languages outside group, and script/region for language groups Only change is languages ordered by rfc4646 subtag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:03:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:03:25 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #22 from Bernardo Gonzalez Kriegel --- Created attachment 27690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27690&action=edit Bug 12017 - 4 - Change language changers This patch modifies language changers on staff/opac Only parameter used is rfc4646 To test: 1. Apply the patch 2. Reload staff and opac (prog/ccsr/bootstrap) 3. Check display of language changers 4. Do a real translation and check language change works Do not change language unless you did a real translation Only change in display is showing only regions for sublanguages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:03:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:03:30 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #23 from Bernardo Gonzalez Kriegel --- Created attachment 27691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27691&action=edit Bug 12017 - 5 - Change local use syspref type Language This patch changes local use syspref of type Language Currently this type of syspref is not used, and shows currently translated staff languages. It's values can't be changed. To make something useful, this kind of syspref is changed to show all langs and save iso639_2 codes. And they not use descriptions on database, only rfc4646 codes from templates. It's easy to add new kinds that save rfc4646 codes, or only show translated languages. To test: 1. Apply the patch 2. Go to system preferences, local use 3. Define a new syspref, any name/description, type 'Language', Save 4. New syspref is showed as a multiple selection of iso639_2 codes with current lang and native names. Check that 5. Select some values, save, check they are saved and restored 6. Edit, similar view, change values, save, check 7. Delete test syspref Values are stored as ',' separated values Verify in database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:03:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:03:34 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #24 from Bernardo Gonzalez Kriegel --- Created attachment 27692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27692&action=edit Bug 12017 - 6 - Change syspref AdvancedSearchLanguages Bug 10986 introduces a way of limiting advanced search languages list. It's a good feature, but to fill the preference you need to list iso639_2 codes. And there is no way to get the list of all codes again as before, and language descriptions are taken from database. This patch changes that preference so it's now a Local syspref, to present an interface to set it's value. Also adds another syspref to control if language chooser is limited at all, recovering previous behavior. As per comments on Bug 10986 language list shows translated and native names and is ordered by iso639_2 code To test: 1. Apply the patch 2. Run updatedatabase.pl 3. Go to system preferences, Searching, new syspref LimitAdvancedSearchLanguages, on by default 4. Go to Local use sysprefs, AdvancedSearchLanguages is now here with interface to set it's values 5. Check language limit on advanced search on staff and opac (any theme) 6. Disable limit and chech language list 7. Enable limit and set different languages on syspref, check language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:03:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:03:38 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #25 from Bernardo Gonzalez Kriegel --- Created attachment 27693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27693&action=edit Bug 12017 - 7 - Remove function getFrameworkLanguages [ Note: From now on dependence on language descriptions in database is about to be removed, also some code cleaning.] This must be an old relic, not used anymore. To test: 1. Check use of getFrameworkLanguages egrep -Rl getFrameworkLanguages * No result save for definition file 2. Apply the patch 3. check again, no results Reason for removing this function is that it's not used and tries to send languages descriptions from database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:03:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:03:42 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #26 from Bernardo Gonzalez Kriegel --- Created attachment 27694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27694&action=edit Bug 12017 - 8 - Remove use of getAllLanguages from installer getAllLanguages is only used on installer/install.pl, and some tests. Result parameters are passed to C4/Install.pm, but its use is futile, language check on Installer.pm uses parameters that are not present on return value of getAllLanguages, and returned value fwk_code is undefined To test: 1. Apply the patch 2. Do translated install (eg using de-DE or es-ES) a. translate first, b. then create a new database, c. grant permissions, d. change koha-conf to use new db, e. reload staff, f. proceed to web install, g. select translated language, h. use marc21, i. finish, 3. Login and check that marc frameworks are translated The translated install must proceed without problems. Removed only the very first occurence of template parameter fwk_language because of it's null value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:03:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:03:47 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #27 from Bernardo Gonzalez Kriegel --- Created attachment 27695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27695&action=edit Bug 12017 - 9 - Remove use of language_get_description function This patch removes every use of language_get_description function. This function retrieves lang names from database To test: 1. Functionality removed by this patch do not affect anything, because previous patches are only using rfc4646_subtag value, not values stored in database. 2. Removed import from Templates.pm, not used there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:03:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:03:51 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #28 from Bernardo Gonzalez Kriegel --- Created attachment 27696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27696&action=edit Bug 12017 - 10 - Remove description from getLanguage This patch rewrites getLanguage function. This function is of not much use, but is rewrited to takes its data from language_rfc4646_to_iso639 table. To test: 1. Apply the patch 2. Only place that use this function is t/db_dependent/Languages.t so run the test and check that it pass 3. To compare the output pre and post patch you can run perl -e 'use C4::Languages; use Data::Dumper; $a = getLanguages(); print Dumper $a;' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:26:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:26:55 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #29 from Bernardo Gonzalez Kriegel --- Changed from one patch to a patch series, to make clear what is changed on each one. In my opinion the only table that is useful is language_rfc4646_to_iso639, and it need to be completed. Two more things are needed: a serious cleaning of Languages.pm, and the removing of useless data from database and sql files. Just to remember, the purpose of this is to enable an easy translation of language descriptions :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:27:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:27:06 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 04:39:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 02:39:54 +0000 Subject: [Koha-bugs] [Bug 12091] Ugly HTML for editing authority MARC subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12091 --- Comment #5 from M. Tompsett --- That's why the name of the patch is untested and the status is still new. And yes, after getting it validating HTML-wise, I realized that HTML in scripts is bad. As for a test plan, trust me, it will be lengthy and thorough when it is finished being tested so as to make testing very simple. I'm just using bugzilla as my offsite backup, so I can do things like "git reset --hard origin/master" and not worry about losing the patch. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 06:22:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 04:22:32 +0000 Subject: [Koha-bugs] [Bug 12149] New: Move CountPendingOrdersByBiblionumber() from reserverations.pl to .pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12149 Bug ID: 12149 Summary: Move CountPendingOrdersByBiblionumber() from reserverations.pl to .pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Bug 11665 introduces CountPendingOrdersByBiblionumber, this should be moved to a .pm and be unit tested. As it counts items on order, maybe it should also reflect that in the name a bit better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 06:22:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 04:22:45 +0000 Subject: [Koha-bugs] [Bug 12149] Move CountPendingOrdersByBiblionumber() from reserverations.pl to .pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12149 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11665 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 06:22:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 04:22:45 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12149 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 06:24:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 04:24:08 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27434|0 |1 is obsolete| | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 07:10:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 05:10:06 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer --- On Galen's suggestion I have filed a follow-up bug to deal with the routine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 07:31:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 05:31:47 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9303 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 07:31:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 05:31:47 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 07:39:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 05:39:29 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #70 from Katrin Fischer --- > There is a difference between retaining circ history (and OpacPrivacy might > be batter called PatronCircHistoryRetentionPolicy) and making patron's > information available to other patrons. > The new system preference (AllowStaffToSetRelativesCheckoutsVisibility) will allow to disallow staff to change the relative's checkouts sharing in OPAC. I like that, but I still see a problem with the reading history and the relative's checkout being tied together. If you allow one, you HAVE to allow the other - but both are quite different features. I think both can be on the same page, but you should be able to configure both separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 07:41:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 05:41:24 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #71 from Katrin Fischer --- (In reply to Katrin Fischer from comment #58) > Hi Kyle, > > could you please syspref the feature in staff/intranet? Additionally I think > the options in the patron account shoudl only be visible when > BorrowerRelationships is not empty. I might have been a cause of confusion here... I am not sure now if I had meant to type staff/opac :( I am testing this further, but I still have concerns about the 2 features being tied together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 07:53:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 05:53:19 +0000 Subject: [Koha-bugs] [Bug 12150] New: Use more placeholders in translatable javascript strings Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Bug ID: 12150 Summary: Use more placeholders in translatable javascript strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Created attachment 27697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27697&action=edit Make more translatable javascript strings in intranet use the js string formatter. Make more translatable javascript strings in intranet use the js string formatter. This is continuation from bug 12138, which missed some translatable javascript strings. Also fixes couple untranslatable js strings (in datatables.js), and two translation marker mistakes (in datatables.js and preferences.js) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 08:28:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 06:28:39 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27543|0 |1 is obsolete| | --- Comment #72 from Katrin Fischer --- Created attachment 27698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27698&action=edit Bug 9303 [QA Followup 4] - Syspref the feature for staff Signed-off-by: Katrin Fischer Fixed sequence of sysprefs in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 08:28:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 06:28:55 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #73 from Katrin Fischer --- Created attachment 27699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27699&action=edit Bug 9393: Capitalization fixes Call No. > Call no. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 08:41:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 06:41:31 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #74 from Katrin Fischer --- Attaching 2 patches - one follow up with capitalization changes and an amended patch for the system preference, putting sysprefs.sql in correct alphabetic order. I am not sure I can finish this today, so here is what I have tested so far: 1) issue_id added to issues and old_issues - Checked numbering was correct, starting with old_issues and continueing in issues - Checked in an item, verified it got moved to old_issues correctly. - Checked out an item, verified next unused issue_id was assigned 2) AllowStaffToSetRelativesCheckoutsVisibility - off by default on new installations, option doesn't show on memberentry - If activated, option can be set and saves correctly - [BUG] The new setting doesn't show on the patron's detail page. The privacy setting for the reading history does. This is important as some libraries print this page, when patrons ask what is stored about them. 3) OPAC: bootstrap - relative's checkouts display after being allowed to 4) OPAC: prog - relative's checkouts display after being allowed to 5) Turning off OPAC privacy - [BUG?] When OPAC privacy is turned off, the patron is left without an option to deactivate the visibility of his/her account to others - the checkouts still show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 09:44:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 07:44:52 +0000 Subject: [Koha-bugs] [Bug 9108] Add uk/euro date sort filter to pages which require it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |3.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 10:47:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 08:47:42 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 10:47:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 08:47:46 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24149|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart --- Created attachment 27700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27700&action=edit Bug 10212: Columns configuration for tables - Add Colvis files Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 10:47:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 08:47:51 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24150|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart --- Created attachment 27701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27701&action=edit Bug 10212: Columns configuration for tables This development introduces ColVis into Koha and provides a configuration page for columns visibility. ColVis is a plugin for DataTables. It allows to change the visibility of the columns in the table. * This development adds: - the js and css file for ColVis - a new DB table 'columns_settings' - a new template plugin 'ColumnsSettings' - a new package C4::Utils::DataTables::ColumnsSettings - a new admin page admin/columns_settings.pl * How it works: A yaml file is created (admin/columns_settings.yml) in order to take an inventory of all tables where ColVis is implemented. This file is read to create the list of modules, pages and tables in the configuration page. There are 3 possible keys in the yml: - is_hidden: default is 0 The column will be hidden. - cannot_be_toggled: default is 0. ColVis will allow to hide/show the column. - cannot_be_modified: default is 0 Default values (in the yml) won't be modifiable. When a user changes (or saves) the configuration for one module, all columns are added to the DB table. The values in the DB get the upper hand on the yaml values. * Humm, strange? It seems weird to have 2 storages for the same values. But I think it will be easy to add an entry and maintain the yaml rather than adding a new row (and new entry in updatedatabase script) in the DB. * Test plan: 1/ Execute the updatedatabase in order to create the new table. 2/ Take a look to the yml structure. 3/ Go on the checkouts page (circ/circulation.pl). 4/ Check that you cannot hide the 3 last columns on the issues table. 5/ Check that you cannot hide the 2 last columns on the holds table. 6/ Try to hide/show columns. 7/ Go on the columns configuration page (admin/columns_settings.pl). 8/ Only the last tab are filled with data. Check/uncheck checkboxes and save. 9/ Go on the checkouts/holds page and check that the behavior is what you expected. 10/ Give me some feedback :) * To go further: We can imagine that the configuration is saved for each user (and not globally like it is made with this patch). Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 10:47:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 08:47:56 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24151|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 27702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27702&action=edit Bug 10212: Make the table names translatable Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 10:48:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 08:48:01 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24167|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart --- Created attachment 27703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27703&action=edit Bug 10212: Columns configuration for tables - QA FIX - use YAML is missing in package - get_tables and get_excluded are useless routines and can be removed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 10:48:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 08:48:07 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24168|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart --- Created attachment 27704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27704&action=edit Bug 10212: Columns configuration for tables - Unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 10:48:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 08:48:12 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24577|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart --- Created attachment 27705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27705&action=edit Bug 10212: FIX QA issues FAIL Koha/Template/Plugin/ColumnsSettings.pm FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 20) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:03:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:03:06 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:03:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:03:09 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26244|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 27706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27706&action=edit Bug 11578: Improve the funds list view The current funds list view does not allow to search in the table and the ergonomics of the page is quite bad. This patch add the datatables plugin combined to the treetable plugin in order to offer a better view of the budgets/funds. Test plan: - Verify there is no regression on this page: try to add/modify/delete a fund and a budget. - Verify the funds hierarchie is correctly displayed. - Filter the funds using the branch and the budget filters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:03:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:03:14 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26245|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 27707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27707&action=edit Bug 11578: Add some css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:03:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:03:19 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26246|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 27708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27708&action=edit Bug 11578: Hide inactive budgets by default This patch hides inactive budgets by default. They can be shown/hidden using 2 new links "Hide/Show inactive budgets". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:03:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:03:24 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26247|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 27709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27709&action=edit Bug 11578: Align budget names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:03:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:03:28 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27404|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 27710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27710&action=edit Bug 11578: Hide filters if a budget (budgetperiod) is chosen If a budget_period_id is given, the filters should not be displayed. Moreover, it does not make sense to display the links for displaying/hiding inactive budgets in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:04:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:04:01 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #26 from Jonathan Druart --- Last patches fix conflict with bug 7308. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:06:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:06:54 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #104 from Jonathan Druart --- Created attachment 27711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27711&action=edit Bug 9811: QA follow-up: Fix license version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:13:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:13:06 +0000 Subject: [Koha-bugs] [Bug 11843] Manual subscription history doesn't seem to work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |julian.maurice at biblibre.com Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:36:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:36:47 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #22 from M. de Rooy --- (In reply to M. Tompsett from comment #21) > Sorry, but guidelines should be followed. :( At least in this case. Have to repeat the option tag now a few times in the if-then-else of the new patch. Slightly less readable. (Also stumbled about the selected attribute; too bad you can't say selected="" when you do not want to select..) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:37:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:37:29 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:37:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:37:31 +0000 Subject: [Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27191|0 |1 is obsolete| | --- Comment #23 from M. de Rooy --- Created attachment 27712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27712&action=edit Bug 9088: Neworderempty should preselect the only active fund This patch makes the following changes to the template: [1] If you add an order line, and you have one active fund (and zero or more inactive funds), the only active fund is preselected. [2] If you modify an order line while its fund is inactive, it now shows the label (inactive) behind the fund name. (Note that other inactive funds may come up when clicking 'Show all' as they did before.) [3] Corrected some indentation in this template part. Test plan: [1] Add an order line while having one active fund. Is it selected? [2] Add an order line while having two or more active funds. No fund should be preselected. [3] Modify an order line with an active fund. Is it still selected? [4] Modify an order line with an inactive fund F2 (while having one active fund F1; note that this test explicitly wants F1 to be before F2). Check if F2 is selected and is labeled inactive. [5] (Bonus points:) Modify an order line that refers to a deleted fund. If you edit this order, the fund combo should say: Select a fund. (Note: if you delete a fund, the budget_id in aqorders remains.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:41:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:41:32 +0000 Subject: [Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 --- Comment #12 from Magnus Enger --- I was just bitten by the new "Access control" things described here: https://httpd.apache.org/docs/2.4/upgrading.html#access (On Ubuntu, recently upgraded to 14.04.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:53:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:53:46 +0000 Subject: [Koha-bugs] [Bug 11843] Manual subscription history doesn't seem to work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 --- Comment #3 from Julian Maurice --- Created attachment 27713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27713&action=edit Bug 11843: Reset the old code for updating manual subscription history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 11:54:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 09:54:39 +0000 Subject: [Koha-bugs] [Bug 11843] Manual subscription history doesn't seem to work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Julian Maurice --- I reset the old code so this should work exactly like before bug 7688 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 12:22:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 10:22:20 +0000 Subject: [Koha-bugs] [Bug 11843] Manual subscription history doesn't seem to work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27713|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 27714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27714&action=edit Bug 11843: Reset the old code for updating manual subscription history Test plan: 1/ Create a new subscription, with manual history enabled 2/ Edit history by clicking on "Edit history" under Planning tab (add some text) 3/ Receive some serials, see that received and missing issues are not updated in Summary tab 4/ Edit subscription and disable manual history 5/ Receive some serials, see that received and missing issues are updated, but your notes have been kept. 6/ Edit serials and change status from/to missing or not available. Check that missing issues are updated correctly. 7/ Edit serials and change status from/to arrived. Check that received issues are updated correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 12:27:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 10:27:18 +0000 Subject: [Koha-bugs] [Bug 11843] Manual subscription history doesn't seem to work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 --- Comment #6 from Julian Maurice --- added test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 14:36:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 12:36:47 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |12012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 14:36:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 12:36:47 +0000 Subject: [Koha-bugs] [Bug 12012] Updating Zebra config files for debian packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12012 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9612 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 16:51:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 14:51:38 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27681|0 |1 is obsolete| | Attachment #27682|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 27715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27715&action=edit Bug 11679: Add ods as a format for reports This patch adds the ability to export the data generated by a report into a ods file. Test plan: 1/ Install the new dependency 2/ Verify you are able to generate an ods file from a report result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 16:51:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 14:51:35 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 16:51:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 14:51:43 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #19 from Jonathan Druart --- Created attachment 27716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27716&action=edit Bug 11679: Add the new dependency OpenOffice::OODoc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 16:52:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 14:52:49 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #20 from Jonathan Druart --- (In reply to Galen Charlton from comment #17) > [2] The existence of the OpenOffice::OODoc Perl module. I rewrote this patch using the OpenOffice::OODoc module. Switch back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 16:54:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 14:54:31 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 16:54:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 14:54:58 +0000 Subject: [Koha-bugs] [Bug 10873] Lots of wasted space in Serial Search Result table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10873 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 16:55:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 14:55:09 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #7 from Jonathan Druart --- This patch is blocked by bug 11679. The ods generation should be rewritten using OpenOffice::OODoc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:01:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:01:11 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:01:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:01:14 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26986|0 |1 is obsolete| | Attachment #27241|0 |1 is obsolete| | Attachment #27339|0 |1 is obsolete| | Attachment #27342|0 |1 is obsolete| | Attachment #27349|0 |1 is obsolete| | Attachment #27350|0 |1 is obsolete| | Attachment #27353|0 |1 is obsolete| | Attachment #27354|0 |1 is obsolete| | Attachment #27356|0 |1 is obsolete| | Attachment #27610|0 |1 is obsolete| | --- Comment #95 from Kyle M Hall --- Created attachment 27717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27717&action=edit Bug 11703 - Convert checkouts table to ajax datatable When a patron has many checked out items, circulation.pl can take a very long time to load ( on the order of minutes in some cases ). This is primarily due to the processing of the previous checkouts list. If we convert to this table to a datatable that fetches its data via ajax, we can make circulation.pl far more responsive. The same should be done with relative's checkouts as well. Test Plan: 1) Apply this patch 2) Observe that the checkouts and relatives' checkouts tables are now loaded asynchronously 3) Observe and verify the renew and return actions are now ajax based and function in a manner equivilent to how they used to. This bug had quite a few followups, so I squashed all of them into one change so that code is easier to follow. Original commit messages are below: Bug 11703 - Use the ajax datatables on patron details page Bug 11703 - Convert holds tables to ajax datatables Bug 11703 [QA Followup 1] - Center bProcessing message over table Bug 11703 [QA Followup 2] - Remove icons from checkout and clear buttons Bug 11703 [QA Followup 3] - Remove references to UseTablesortForCirc Bug 11703 [QA Followup 4] - Add back in Today's checkouts/Previous checkouts rows Bug 11703 [QA Followup 5] Bug 11703 [QA Followup 6] - Move strings to an include file for translation purposes Bug 11703 [QA Followup 7] - Fix issues spotted by koha-qa.pl Bug 11703 [QA Followup 8] - Speed up api/checkouts.pl as much as possible Bug 11703 [QA Followup 9] - Move scripts from api directory to svc directory Bug 11703 [QA Followup 10] - Fix errors caused by rebase Bug 11703 [QA Followup 11] - Prevent multiple fetchs from ajax source Bug 11703 [QA Followup 12] - Fix problem detected by koha-qa.pl Bug 11703 [QA Followup 13] - Removed uneccessary data from renewal box during renewal Bug 11703 [QA Followup 14] - Fix table column span Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:01:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:01:27 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #96 from Kyle M Hall --- Created attachment 27718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27718&action=edit Bug 11703 [QA Followup] * Bold record title, fix table width * Change output_pref_due to output_pref * Retain functionality of IssuesDefaultSortOrder system preferences * Use datatables.inc in circulation.tt * Fix up holds table details * Add plugin to about * fix relatives' checkouts * add too_many string * remove dead syspref from db * Sort relatives' checkouts and holds tables client side * Provide context for translation of strings * Fix unterminated string literal, add missing paren * Add replacement of _AUTHOR_ with title's author for holds * Format prices correctly * Format checkout dates correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:01:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:01:48 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26990|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:01:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:01:53 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:09:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:09:18 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #97 from Kyle M Hall --- (In reply to Katrin Fischer from comment #94) > Hi Kyle, > > NEEDS REBASE! Done! > 1) In the holds table, the replacing technique is not working correctly: > Die R?uber by _AUTHOR_ Schiller, Friedrich Should now be fixed! > 2) On the relative's checkouts tab the price is not formatted correctly: > 0.000. Maybe 0 shouldn't show at all? Also feexed! > 3) On the checkuts tab the checkout date shows in 'database' format: > 2014-04-27 21:10:00. It also still shows the seconds, although those > are not recorded and the time is always :00. This one too > X) It doesn't feel faster than before :( It could just be my installation, > but hard to tell for me If you haven't cleared your browser cache you might still be using the js file with the ajax sorting. The js sorting should be way faster. I've also squashed all of my new qa followups into one qa followup patch for simplicity. Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:15:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:15:13 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #21 from Marc V?ron --- Crash: syntax error at /usr/share/kohaclone/C4/Installer/PerlDependencies.pm line 710, near "min_ver" Error in 2nd patch (near "required"): 'OpenOffice::OODoc' => { usage => 'Export', required => 1 min_ver => '2.125', }, Should read: 'OpenOffice::OODoc' => { usage => 'Export', required => '1', min_ver => '2.125', }, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:18:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:18:57 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27716|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 27719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27719&action=edit Bug 11679: Add the new dependency OpenOffice::OODoc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:19:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:19:35 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #23 from Jonathan Druart --- (In reply to Marc V?ron from comment #21) > Crash: syntax error at /usr/share/kohaclone/C4/Installer/PerlDependencies.pm > line 710, near "min_ver" Aarg, sorry. Thanks for the catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:21:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:21:42 +0000 Subject: [Koha-bugs] [Bug 12151] New: remove remaining uses of the Perl smartmatch operator Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Bug ID: 12151 Summary: remove remaining uses of the Perl smartmatch operator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The Perl smartmatch operator has been marked as experimental as of Perl 5.18. As the syntax and interpretation of it is therefore subject to change, current uses of it should be removed. This is especially the case when running under Perl 5.18, as by default use of experimental constructs generates warning messages. The following source files contain the ~~ operator: C4/Search.pm: unless ( $data ~~ @used_datas ) { misc/translator/translate: if ( $cmd !~ /create/ && $lang && not $lang ~~ $installer->{langs} ) { opac/opac-search.pl: if ( $sort ~~ @allowed_sortby ) { tools/batchMod.pl: unless ( $field_to_update->subfield($subfield->[0]) ~~ $subfield->[1] ) { The following source files contain the given construct, which also uses smartmatch: C4/Serials.pm: given ($num_type) { reports/acquisitions_stats.pl: given ($_) { reports/acquisitions_stats.pl: given ($podsp) { reports/acquisitions_stats.pl: given ($rodsp) { reports/acquisitions_stats.pl: given ($process) { reports/borrowers_stats.pl: given ($line) { reports/borrowers_stats.pl: given ($column) { reports/borrowers_stats.pl: given ($i) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:29:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:29:32 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #24 from Marc V?ron --- Created attachment 27720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27720&action=edit [Signed-off] Bug 11679: Add the new dependency OpenOffice::OODoc How I tested: Appla patch, verify that dependency shows up in About Koha->Perl Mudules Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:30:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:30:49 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27719|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:40:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:40:44 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master, along with a follow-up that replaces the textarea with a span when displaying the vendor note on the order receiving page. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:41:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:41:09 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #25 from Marc V?ron --- Created attachment 27721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27721&action=edit [Signed-off] Bug 11679: Add ods as a format for reports This patch adds the ability to export the data generated by a report into a ods file. Test plan: 1/ Install the new dependency 2/ Verify you are able to generate an ods file from a report result. Tested with several reports and downloaded them as Open Document Spreadsheet. Wors as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:41:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:41:53 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27715|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:42:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:42:23 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 17:54:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 15:54:53 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #26 from Galen Charlton --- (In reply to Jonathan Druart from comment #20) > (In reply to Galen Charlton from comment #17) > > [2] The existence of the OpenOffice::OODoc Perl module. > > I rewrote this patch using the OpenOffice::OODoc module. Thank you, I really appreciate your doing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:02:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:02:10 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- After consulting with Galen and as we now have officially deprecated the use of C4::Dates, this will need a follow-up moving the code to Koha::DateUtils. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:04:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:04:53 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:06:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:06:25 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #75 from Katrin Fischer --- I had hoped someone would take this on where I have left off - I think 5) is a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:15:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:15:36 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27554|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 27722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27722&action=edit [SIGNED-OFF] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Still work as described. Checked in arabic with arabic records. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:15:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:15:52 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:23:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:23:33 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #27 from Martin Renvoize --- Sorry Jonathan, this is failing the QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt OK forbidden patterns FAIL tt_valid lines 310 OK valid_template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:23:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:23:51 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Laurence Lefaucheur changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.lefaucheur at biblibr | |e.com --- Comment #36 from Laurence Lefaucheur --- Just some more information on how the dev works before answering more in details to Katrin's notes The goal of the cronjob is to remove a "new" information from items after a given period. What could be a "new" information in the item : 1) a 'new' status added just to inform about the new document : we suppose an item subfield mapped with items.new field. This value can be used in search (if zebra index is configured), for custom rss feeds ; the subfield can be linked to an authorised value (authorised value=1, label=New). The cronjob will delete the value in the 'new' subfield. 2) a 'New' itype (itemtype) so that specific issuing rules can be defined for new items. With this configuration, final itemtype can be defined based on condition in another item subfield (ccode) or in a biblio subfield (mapped with biblioitems.itemtype) or in any items or biblioitems available field. The cronjob will delete the 'New' itype value and replace it by the suitable itype) 3) why not both of 1) and 2) or any item subfield the library wants to have some 'new' information. Only items are modified, the modification of biblio (biblio or biblioitems) is not part of the dev. Biblioitems fields are used only for the condition criteria. The items having dateaccessioned <= Now-duration will be modified by the job. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:25:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:25:05 +0000 Subject: [Koha-bugs] [Bug 11986] Tags searching doesn't work in OPAC if biblio DOM indexing is being used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jacek! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:33:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:33:50 +0000 Subject: [Koha-bugs] [Bug 12115] Follow up fix for tools/inventory.pl's output_pref issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:42:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:42:24 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27470|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 27723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27723&action=edit [PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:42:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:42:30 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27471|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 27724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27724&action=edit [PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:42:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:42:50 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27474|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 27725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27725&action=edit [PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:42:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:42:59 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27723|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 27726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27726&action=edit [PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:43:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:43:57 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:45:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:45:04 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #13 from Martin Renvoize --- Apart from some issues getting this to apply (just git issues with encoding).. once I did manage then we're good. Passes qa scritps and causes no regressions. A simple enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:54:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:54:08 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27724|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:54:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:54:21 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27726|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:54:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:54:15 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27725|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:54:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:54:29 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27471|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:54:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:54:33 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27474|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:54:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:54:37 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27723|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:54:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:54:52 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #14 from Martin Renvoize --- Created attachment 27727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27727&action=edit [PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:55:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:55:00 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27471|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 27728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27728&action=edit [PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:55:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:55:03 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:55:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:55:10 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27470|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:55:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:55:54 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27471|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:56:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:56:14 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27727|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:56:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:56:20 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:57:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:57:22 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22937|0 |1 is obsolete| | --- Comment #25 from M. Tompsett --- Created attachment 27729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27729&action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep "::set_userenv" `find .` grep "\->set_userenv" `find .` The first grep demonstrated that the smaller change is from :: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use ->) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart NOTE: Rebased because of Bug 11077. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:57:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:57:33 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:57:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:57:35 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27470|0 |1 is obsolete| | Attachment #27471|0 |1 is obsolete| | Attachment #27474|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 27730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27730&action=edit [PASSED QA] Bug 11856: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:57:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:57:45 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #17 from Kyle M Hall --- Created attachment 27731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27731&action=edit [PASSED QA] Bug 11856: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:58:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:58:37 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 18:58:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 16:58:39 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #18 from Kyle M Hall --- Created attachment 27732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27732&action=edit [PASSED QA] Bug 11856: Add publiction year and edition to French acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout3pagesfr. Additional change: Translates 'published by' to 'publie par' http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:15:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:15:20 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master, along with a follow-up that repairs one of the new tests. Thanks, Jonathan and Kyle! I think serious thought should be given to removing borrowers.debarred, by the way, in favor of consulting borrower_debarments directly. borrowers.debarred was retained as a performance measure, but I'd like to see proof that querying borrower_debarments is too slow to be worth the risk of bugs like this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:21:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:21:01 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #19 from Galen Charlton --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:26:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:26:25 +0000 Subject: [Koha-bugs] [Bug 11724] Make Funds/Status on suggestions page sortable/searchable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:32:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:32:12 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:32:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:32:15 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26042|0 |1 is obsolete| | Attachment #26043|0 |1 is obsolete| | Attachment #27535|0 |1 is obsolete| | --- Comment #15 from Galen Charlton --- Created attachment 27733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27733&action=edit Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. Signed-off-by: Aleisha Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:32:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:32:28 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #16 from Galen Charlton --- Created attachment 27734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27734&action=edit Bug 11719 [Follow-up] Use new DataTables include in serials templates This patch corrects column sorting configuration to avoid an error when sorting on the call number column. Also changed: removed obsolete UK sort mention. To test, search for serial subscriptions. Test sorting on all columns in the results table with and without the RoutingSerials preference enabled. Sorting should work correctly without error. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:32:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:32:33 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #17 from Galen Charlton --- Created attachment 27735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27735&action=edit Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:37:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:37:27 +0000 Subject: [Koha-bugs] [Bug 12127] Incorrect DataTable types in Holds to Pull list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:38:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:38:50 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Patch applies now that its dependency has been pushed. Setting status back to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:43:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:43:07 +0000 Subject: [Koha-bugs] [Bug 7125] can't change tag in frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:54:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:54:44 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:54:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:54:47 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #28 from Jonathan Druart --- Created attachment 27736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27736&action=edit Bug 11578: QA follow-up This patch removes the error raised by tt_valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt FAIL tt_valid lines 310 Actually, it fails because translate script does not match strings in attribute value. In this case, we don't want to translate. This fix is not necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:59:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:59:53 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 19:59:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 17:59:56 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27733|0 |1 is obsolete| | Attachment #27734|0 |1 is obsolete| | Attachment #27735|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 27737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27737&action=edit [PASSED QA] Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. Signed-off-by: Aleisha Signed-off-by: Katrin Fischer Tested all 3 tables, no regressions found. Passes QA script and tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:00:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:00:21 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #19 from Katrin Fischer --- Created attachment 27738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27738&action=edit [PASSED QA] Bug 11719 [Follow-up] Use new DataTables include in serials templates This patch corrects column sorting configuration to avoid an error when sorting on the call number column. Also changed: removed obsolete UK sort mention. To test, search for serial subscriptions. Test sorting on all columns in the results table with and without the RoutingSerials preference enabled. Sorting should work correctly without error. Signed-off-by: Aleisha Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:00:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:00:38 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #20 from Katrin Fischer --- Created attachment 27739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27739&action=edit [PASSED QA] Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:10:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:10:04 +0000 Subject: [Koha-bugs] [Bug 12152] New: Holds to pull report should show library and itype description instead of their codes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Bug ID: 12152 Summary: Holds to pull report should show library and itype description instead of their codes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The holds to pull report shows the library code and itype codes instead of the descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:10:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:10:42 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:10:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:10:44 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27504|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 27740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27740&action=edit [PASSED QA] Bug 12088 [Revised] Improve date handling and sorting in holds to pull report The holds to pull report could be improved by improving sorting on the title and date columns. This patch adds "anti-the" sorting to the title column and "title-string" sorting to the date column. Date formatting of another variable has been moved to the template for formatting using KohaDates. The patch includes other corrections for HTML validity. To test, apply the patch and view the holds to pull report. - Sorting by date should work correctly regardless of dateformat system preference setting. - Sorting of the title columns should correctly ignore articles. - Formatting of the "Reported on" date should be correct. Revision incorporates the corrections made by Bug 12127 and converts those changes to use class-based sorting. Signed-off-by: David Cook The patch works as described. Thanks for including and improving the changes from Bug 12127, Owen! Signed-off-by: Katrin Fischer Passes QA script and tests. No regressions found, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:25:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:25:18 +0000 Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:27:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:27:02 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #27 from Katrin Fischer --- Created attachment 27741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27741&action=edit [PASSED QA] Bug 11679: Add the new dependency OpenOffice::OODoc How I tested: Apply patch, verify that dependency shows up in About Koha->Perl Mudules Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:27:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:27:14 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #28 from Katrin Fischer --- Created attachment 27742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27742&action=edit [PASSED QA] Bug 11679: Add ods as a format for reports This patch adds the ability to export the data generated by a report into a ods file. Test plan: 1/ Install the new dependency 2/ Verify you are able to generate an ods file from a report result. Tested with several reports and downloaded them as Open Document Spreadsheet. Wors as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Passes all tests and QA script. Verified tab and comma separated export still works correctly. Verifid new ODS export works nicely. Tested with data containing Arabic characters and German umlauts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:27:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:27:40 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:27:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:27:42 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27720|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:27:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:27:44 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27721|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:44:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:44:56 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #21 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:45:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:45:09 +0000 Subject: [Koha-bugs] [Bug 12088] Improve date handling and sorting in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12088 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 20:45:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 18:45:23 +0000 Subject: [Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #23 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 21:06:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 19:06:43 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 --- Comment #9 from mathieu saby --- Thank you. I had a doubt between using a span or a textarea, but I saw an other readonly textarea in the template... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 21:07:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 19:07:14 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #29 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 21:34:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 19:34:11 +0000 Subject: [Koha-bugs] [Bug 12065] Consistent use of encode_qp when sending basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12065 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27362|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 27743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27743&action=edit [SIGNED-OFF] Bug 12065: Consistent use of encode_qp when sending basket/shelf QP-encode both mail header and mail body when sending baskets or shelves. There is no need to Encode qp-encoded strings. Note that this does not solve all possible encoding problems in the mail sent. This is related to decoding CGI parameters and use of TT. That problem is addressed in report 11944. Test plan: Verify if sending a basket from opac and staff still works. Check if sending a shelf (list) from opac and staff still functions as expected. Signed-off-by: Bernardo Gonzalez Kriegel Cart/List sent form opac/staff works No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 21:35:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 19:35:11 +0000 Subject: [Koha-bugs] [Bug 12065] Consistent use of encode_qp when sending basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12065 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 21:44:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 19:44:04 +0000 Subject: [Koha-bugs] [Bug 10936] Standardnumber doubled up in Advanced search - more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10936 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27192|0 |1 is obsolete| | --- Comment #16 from Bernardo Gonzalez Kriegel --- Created attachment 27744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27744&action=edit [SIGNED-OFF] Bug 10936 - Follow-up for Prog theme - Standardnumber doubled up in Advanced search - more options TEST PLAN --------- 1) Set opacthemes system preference to prog 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time Signed-off-by: Bernardo Gonzalez Kriegel Work as described on prog theme, no more duplicate. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 21:44:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 19:44:43 +0000 Subject: [Koha-bugs] [Bug 10936] Standardnumber doubled up in Advanced search - more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10936 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:08:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:08:29 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #98 from Katrin Fischer --- GENERAL - New jQuery plugin: jquery.dataTables.grouping.js > Added to About page. CHECKOUTS - Sorting table > OK. Sorting the table was not possible before patch. Sorting will remove the Today's and Previous checkouts differentiation. Works ok. - Column price and charge > OK. - Column Due date > OK, only shows time now when it's an hourly loan. Nice! - Column Item type > Shows the code instead of description, something for another day. - Column Checked out on > OK. Checking out - still to be tested - 'normal' check out > OK. - hourly check out (with specify due date) > OK. - with rental fee > OK, charge shows up in table. - notforloan item > OK, can be overriden or not, depending on configuration. - too many items > OK, override possible. > Some more done along the way, all message/alerts showing correctly. Renewing items - Check out with an already checked out barcode again > OK, item is renewed - renewal using checkboxes > OK. Note: It's only possible to do one renewal at a time. After renewing once the checkbox is gone and then you will have to reload the page to bring the checkboxes back. - renewal override > OK. Note: If the item is on hold, the renewal will fail. Behaviour is the same before applying the patch. - too early renewal (bug 6779) > Bug: When the renewal is too soon, in master we show the first possible renwal date, with the patches only a note is shown, that the renwal is premature. System preferences - UseTableSortForCirc > Pref was removed, it's not longer needed as sorting is possible by default now. - todaysIssuesDefaultSortOrder > OK. - previousIssuesDefaultSortOrder > OK. Note: I wonder why we don't have a sorting by checkout date, so that the newest checkout always shows at the top or bottom. But that's been like that before. RELATIVE's CHECKOUTS > OK, still working nicely. HOLDS - Sorting table > OK, sorting the holds table was not possible pre-patches, it is now. - Columns: Title, Hold date, expiration date, Delete > OK - Barcode column > Ok, now offers a link to the item - Delete column - Suspending and unsuspending holds > OK - Cancelling holds > OK, possible enhancement: Redirect back to the holds tab after cancelling a hold instead of sending user to the checkouts tab. Exists pre-patch. Concern: Accessibility - I hope we don't make it harder with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:14:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:14:47 +0000 Subject: [Koha-bugs] [Bug 12153] New: Restore showing earliest renewal date for 'too early' renwals Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12153 Bug ID: 12153 Summary: Restore showing earliest renewal date for 'too early' renwals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 11703 will introduce a small regression on bug 6779 as the earliest renwal date is no longer shown in the table, but a message pointing out that the renewal is 'premature'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:15:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:15:11 +0000 Subject: [Koha-bugs] [Bug 12153] Restore showing earliest renewal date for 'too early' renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12153 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 Summary|Restore showing earliest |Restore showing earliest |renewal date for 'too |renewal date for 'too |early' renwals |early' renewals -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:15:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:15:11 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12153 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:15:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:15:43 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Large patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:15:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:15:52 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27717|0 |1 is obsolete| | Attachment #27718|0 |1 is obsolete| | --- Comment #99 from Katrin Fischer --- Created attachment 27745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27745&action=edit [PASSED QA] Bug 11703 - Convert checkouts table to ajax datatable When a patron has many checked out items, circulation.pl can take a very long time to load ( on the order of minutes in some cases ). This is primarily due to the processing of the previous checkouts list. If we convert to this table to a datatable that fetches its data via ajax, we can make circulation.pl far more responsive. The same should be done with relative's checkouts as well. Test Plan: 1) Apply this patch 2) Observe that the checkouts and relatives' checkouts tables are now loaded asynchronously 3) Observe and verify the renew and return actions are now ajax based and function in a manner equivilent to how they used to. This bug had quite a few followups, so I squashed all of them into one change so that code is easier to follow. Original commit messages are below: Bug 11703 - Use the ajax datatables on patron details page Bug 11703 - Convert holds tables to ajax datatables Bug 11703 [QA Followup 1] - Center bProcessing message over table Bug 11703 [QA Followup 2] - Remove icons from checkout and clear buttons Bug 11703 [QA Followup 3] - Remove references to UseTablesortForCirc Bug 11703 [QA Followup 4] - Add back in Today's checkouts/Previous checkouts rows Bug 11703 [QA Followup 5] Bug 11703 [QA Followup 6] - Move strings to an include file for translation purposes Bug 11703 [QA Followup 7] - Fix issues spotted by koha-qa.pl Bug 11703 [QA Followup 8] - Speed up api/checkouts.pl as much as possible Bug 11703 [QA Followup 9] - Move scripts from api directory to svc directory Bug 11703 [QA Followup 10] - Fix errors caused by rebase Bug 11703 [QA Followup 11] - Prevent multiple fetchs from ajax source Bug 11703 [QA Followup 12] - Fix problem detected by koha-qa.pl Bug 11703 [QA Followup 13] - Removed uneccessary data from renewal box during renewal Bug 11703 [QA Followup 14] - Fix table column span Signed-off-by: Dobrica Pavlinusic Signed-off-by: Katrin Fischer Passes all tests and QA script. Test plan on bug report: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703#c98 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:16:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:16:08 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #100 from Katrin Fischer --- Created attachment 27746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27746&action=edit [PASSED QA] Bug 11703 [QA Followup] * Bold record title, fix table width * Change output_pref_due to output_pref * Retain functionality of IssuesDefaultSortOrder system preferences * Use datatables.inc in circulation.tt * Fix up holds table details * Add plugin to about * fix relatives' checkouts * add too_many string * remove dead syspref from db * Sort relatives' checkouts and holds tables client side * Provide context for translation of strings * Fix unterminated string literal, add missing paren * Add replacement of _AUTHOR_ with title's author for holds * Format prices correctly * Format checkout dates correctly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:53:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:53:45 +0000 Subject: [Koha-bugs] [Bug 12154] New: Suggestion tabs show unknown Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12154 Bug ID: 12154 Summary: Suggestion tabs show unknown Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org If you organize suggestions in the staff client (suggestion.pl) by anything except 'Status', the tabs are all labeled 'Unknown', which is useless. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:54:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:54:58 +0000 Subject: [Koha-bugs] [Bug 12154] Suggestion tabs show unknown In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10519 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:54:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:54:58 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #18 from Katrin Fischer --- *** Bug 12154 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:55:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:55:19 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #19 from Katrin Fischer --- I hope to get back to this after feature freeze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 22:57:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 20:57:18 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #20 from Katrin Fischer --- ... but won't be unhappy if someone else adopts this bug :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:24:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:24:36 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 --- Comment #13 from Katrin Fischer --- Created attachment 27747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27747&action=edit [PASSED QA] Bug 11848: Move language detection function in C4::Languages and store interface (intranet, opac) in context to not have to pass it as parameter. Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors Signed-off-by: Katrin Fischer Comments on last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:24:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:24:39 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 --- Comment #14 from Katrin Fischer --- Created attachment 27748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27748&action=edit [PASSED QA] Bug 11848: Make Koha::I18N easier to use Instead of writing use CGI; use Koha::I18N; my $cgi = new CGI; my $lh = Koha::I18N->get_handle_from_context($cgi, 'intranet'); print $lh->maketext('my translatable text'); you can now write use Koha::I18N; print gettext('my translatable text'); Signed-off-by: Bernardo Gonzalez Kriegel No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:24:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:24:42 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 --- Comment #15 from Katrin Fischer --- Created attachment 27749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27749&action=edit [PASSED QA] Bug 11848: Fix C4::Context::interface, add POD and UT 1/ Edit a Perl script, for example mainpage.pl 2/ add "use Koha::I18N;" to the top of file 3/ add a translatable message somewhere in the script (this have to be after the call to get_template_and_user). For example: warn gettext("This is a translated warning"); 4/ Create or update the PO files with misc/translator/translate create LANGCODE or misc/translator/translate update LANGCODE (LANGCODE should be enable in syspref 'languages') 5/ In misc/translator/po/LANGCODE-messages.po you should have your string, translate it (using a text editor or a PO file editor, make sure you don't have the "fuzzy" flag for this string). 6/ Go to mainpage.pl with active language being English with your browser and check your logs. You should see your string "This is a translated warning". 7/ Now change language to LANGCODE. Check your logs, you should have the string translated. Note: I chose to name the sub 'gettext' because it's the default keyword for xgettext for Perl. We can change it to whatever we want. Signed-off-by: Bernardo Gonzalez Kriegel Follow test plan, work as described. No koha-qa errors. Tests pass Fixed small merge conflict on t/Context.t Signed-off-by: Katrin Fischer Passes all tests and QA script. Copied test plan from bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:25:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:25:16 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:25:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:25:14 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:25:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:25:18 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26494|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:25:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:25:20 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26495|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:30:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:30:29 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:30:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:30:44 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27745|0 |1 is obsolete| | --- Comment #101 from Kyle M Hall --- Created attachment 27750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27750&action=edit Bug 11703 - Convert checkouts table to ajax datatable When a patron has many checked out items, circulation.pl can take a very long time to load ( on the order of minutes in some cases ). This is primarily due to the processing of the previous checkouts list. If we convert to this table to a datatable that fetches its data via ajax, we can make circulation.pl far more responsive. The same should be done with relative's checkouts as well. Test Plan: 1) Apply this patch 2) Observe that the checkouts and relatives' checkouts tables are now loaded asynchronously 3) Observe and verify the renew and return actions are now ajax based and function in a manner equivilent to how they used to. This bug had quite a few followups, so I squashed all of them into one change so that code is easier to follow. Original commit messages are below: Bug 11703 - Use the ajax datatables on patron details page Bug 11703 - Convert holds tables to ajax datatables Bug 11703 [QA Followup 1] - Center bProcessing message over table Bug 11703 [QA Followup 2] - Remove icons from checkout and clear buttons Bug 11703 [QA Followup 3] - Remove references to UseTablesortForCirc Bug 11703 [QA Followup 4] - Add back in Today's checkouts/Previous checkouts rows Bug 11703 [QA Followup 5] Bug 11703 [QA Followup 6] - Move strings to an include file for translation purposes Bug 11703 [QA Followup 7] - Fix issues spotted by koha-qa.pl Bug 11703 [QA Followup 8] - Speed up api/checkouts.pl as much as possible Bug 11703 [QA Followup 9] - Move scripts from api directory to svc directory Bug 11703 [QA Followup 10] - Fix errors caused by rebase Bug 11703 [QA Followup 11] - Prevent multiple fetchs from ajax source Bug 11703 [QA Followup 12] - Fix problem detected by koha-qa.pl Bug 11703 [QA Followup 13] - Removed uneccessary data from renewal box during renewal Bug 11703 [QA Followup 14] - Fix table column span Signed-off-by: Dobrica Pavlinusic Signed-off-by: Katrin Fischer Passes all tests and QA script. Test plan on bug report: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703#c98 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:31:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:31:05 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27746|0 |1 is obsolete| | --- Comment #102 from Kyle M Hall --- Created attachment 27751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27751&action=edit Bug 11703 [QA Followup] * Bold record title, fix table width * Change output_pref_due to output_pref * Retain functionality of IssuesDefaultSortOrder system preferences * Use datatables.inc in circulation.tt * Fix up holds table details * Add plugin to about * fix relatives' checkouts * add too_many string * remove dead syspref from db * Sort relatives' checkouts and holds tables client side * Provide context for translation of strings * Fix unterminated string literal, add missing paren * Add replacement of _AUTHOR_ with title's author for holds * Format prices correctly * Format checkout dates correctly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:37:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:37:03 +0000 Subject: [Koha-bugs] [Bug 12100] Messaging preferences did not save Days in Advance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12100 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master, along with a follow-up that fixes a regression on bug 5603 introduced by the main patch. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:38:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:38:40 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 28 23:38:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 21:38:45 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27722|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 27752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27752&action=edit [PASSED QA] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Still work as described. Checked in arabic with arabic records. No koha-qa errors Signed-off-by: Katrin Fischer Passes all tests and QA script. Confirmed bug and that the patch fixes it, tested in staff, prog, ccsr and bootstrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 00:07:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 22:07:51 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #29 from Katrin Fischer --- I have started reviewing this, just a first note: 1) Add new library to about page + * jQuery treetable Plugin 3.1.0 + * http://ludo.cubicphuse.nl/jquery-treetable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 00:53:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Apr 2014 22:53:17 +0000 Subject: [Koha-bugs] [Bug 12155] New: shelving location changes when floating Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12155 Bug ID: 12155 Summary: shelving location changes when floating Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I don't know if this is possible, but it's an idea someone had today that I thought I should share. If you have a floating collection it would be nice if when the item floated to a library with different (or no) shelving locations, the shelving location changed on check in. This would require some way of having multiple shelving locations linked to branches on the item record ... Like I said not sure it's possible, but doesn't hurt to suggest it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 04:15:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 02:15:51 +0000 Subject: [Koha-bugs] [Bug 12156] New: Merging staged records with no 952c with records created in acquisitions loses data from both Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12156 Bug ID: 12156 Summary: Merging staged records with no 952c with records created in acquisitions loses data from both Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org To replicate: Create an order with "from a new record" with just a title. Stage and import a record through "Stage MARC records for import" Add both records to a list to be merged Attempt to merge them, the resultant record should be blank at the end. Caveats: If you have a MARC Modification template that adds a 942c to the record, merging will work as expected - this only happens when both records lack a 942c. This also classifies as a workaround for this problem if it happens to plague you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 04:28:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 02:28:56 +0000 Subject: [Koha-bugs] [Bug 12157] New: Batch delete for serial holdings Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12157 Bug ID: 12157 Summary: Batch delete for serial holdings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Request by a library: Currently we have to delete serial holdings one by one, it would be nice to be able to delete several (or many) at one time with a batch delete function for serial holdings. This would not necessarily have to delete the associated holding item, only the serial record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 04:31:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 02:31:08 +0000 Subject: [Koha-bugs] [Bug 12158] New: Add ability to purge old orders Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12158 Bug ID: 12158 Summary: Add ability to purge old orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Request from a library: Add the ability to purge old orders in acquisitions based on some criteria (associated with a specific budget/fund, before a certain date, etc) from the web interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 08:18:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 06:18:03 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #4 from paxed --- To test: 1) Add a new child patron. It will be successful without a guarantor. 2) Add a new child patron, with guarantor set to some other patron who already has a guarantor. Adding the child patron is successful. 3) Add a new non-child patron, with guarantor set to some other patron who already has a guarantor. Adding the patron is successful. 4) Install patch 5) Add a new child patron. It will be successful without a guarantor. 6) Add a new child patron, with guarantor set to some other patron who already has a guarantor. Adding the child patron should fail with error message. 7) Add a new non-child patron, with guarantor set to some other patron who already has a guarantor. Adding the patron should fail with error message. 8) Set syspref ChildNeedsGuarantor to ON 9) Try to add a new child patron without a guarantor. It should fail with error message. 10) Add a new non-child patron. It will be successful without a guarantor. 11) Set syspref ChildNeedsGuarantor to OFF 12) Repeat the steps 5-10, but instead of adding a patron, edit already existing patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 08:21:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 06:21:22 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #22 from Robin Sheat --- Created attachment 27753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27753&action=edit Bug 8970 - fix MARC import under plack There were database handles being shared between a parent and a child process, which is a big no-no, and was leading to crazy crashes. Fine under CGI, but not in a persistent environment. This causes the child to make a new database handle to use. Also some small cleanups. To test: * In a plack environment, * Tools -> stage MARC records for import * Use a reasonable size file (but not too big as it all goes into RAM - I made one about 40MB.) * Make sure that it works, and that the progress bars progress. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 08:25:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 06:25:08 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #23 from Robin Sheat --- There are still other issues that should be addressed, but I think they're not critical, as with this patch things work. In particular: * MARC data is all loaded into RAM, this makes the process get large and stay large until it's reaped, * Probably due to an incomplete record at the end of my test data, there is a crash, but it doesn't seem to impair the working of it at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 09:04:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 07:04:21 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #5 from paxed --- To test: 1) Look at a staffer's detail page. Even if he or she has guarantees, they won't show up there. 2) Install patch 3) Look at a staffer's detail page. If the staffer has guarantees, they will be shown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 09:21:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 07:21:55 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27736|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 27754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27754&action=edit Bug 11578: QA follow-up This patch removes the error raised by tt_valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt FAIL tt_valid lines 310 Actually, it fails because translate script does not match strings in attribute value. In this case, we don't want to translate. This fix is not necessary. This patch also adds the licence for the new jQuery treetable plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 09:34:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 07:34:00 +0000 Subject: [Koha-bugs] [Bug 11763] Consolidate fund action links into menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Summary|[DEPENDENCY STILL NEEDS |Consolidate fund action |SIGNOFF] Consolidate fund |links into menu |action links into menu | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 09:49:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 07:49:10 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Can we get a sign off on this please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 09:50:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 07:50:12 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Can we get a sign off on this please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 09:55:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 07:55:12 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #133 from Jonathan Druart --- Note for RM, and others: To complete the feature (MTT), bug 11867 and bug 11209 should reach the "Passed QA" status. They are bugfixes and quite easy to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:40:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:40:52 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27754|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 27755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27755&action=edit Bug 11578: QA follow-up This patch removes the error raised by tt_valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt FAIL tt_valid lines 310 Actually, it fails because translate script does not match strings in attribute value. In this case, we don't want to translate. This fix is not necessary. This patch also adds the licence for the new jQuery treetable plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:46:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:46:37 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #64 from Jesse Weaver --- Created attachment 27756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27756&action=edit Bug 10486 - QA followup: incorrect diacritics Correctly asks for UTF-8 now, fixing diacritics for some targets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:50:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:50:20 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #65 from Jesse Weaver --- (In reply to Katrin Fischer from comment #62) > Jesse, this is much better! > > But now that I know it should also work with UNIMARC I have added a UNIMARC > target, which works perfectly... except for the details page. For exmaple > there is always 'publication:', but it never seems to show any information > behind the label. Most records don't show any other fields at all. > > I have tried with BNF2, your example from below. Also I have some weird > diacritics showing up in my result list, not sure if that is the target or a > bug. > > Also paging behind page 10 only brings up empty pages? > > Please check? BNF unfortunately returns a lot of rather paltry records (some with only 3 tags total!), but they were one of the few UNIMARC targets I could find that supported keyword search. This problem is on their end, rather than these patches' or the XSLT's. Fixed the diacritics in the above patch. The failing after a certain page is a transient problem that happens after the user goes in a few pages, where requests to Pazpar2 seem to get stuck somewhere in Apache or the browser. It usually only happens after going fairly deep in the search results, and can be often be fixed by reloading. Not sure how to fix this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:52:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:52:24 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27140|0 |1 is obsolete| | --- Comment #25 from Jesse Weaver --- Created attachment 27757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27757&action=edit Bug 11559 - Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Allows XSLT filename to be extracted * Extends humanmsg to allow per-message classes * Fixes XSLT namespace for in-browser rendering and * Adds proper charset to results of svc/bib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:52:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:52:30 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27141|0 |1 is obsolete| | --- Comment #26 from Jesse Weaver --- Created attachment 27758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27758&action=edit Bug 11559 - New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * jquery.hotkeys - some functionality not supported by shortcuts * jquery.lightbox_me - for modal popovers * pz2 - library for connecting to pazpar2 * require - dependency resolver and module loader -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:52:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:52:39 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27142|0 |1 is obsolete| | --- Comment #27 from Jesse Weaver --- Created attachment 27759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27759&action=edit Bug 11559 - Rancor: professional cataloging interface Test plan: 1. Apply patches for bug 10486 and this bug. 2. Reinstall patches for pazpar2. 3. Switch back and forth between basic and advanced editor, and verify that preference is saved (by workstation, not user. 4. Enter in a record (with all required fields). 5. Save to ISO2709, MARCXML and catalog, verify that all three match. 6. Import a MARCXML and ISO2709 record, and verify that the record is correct after import. 7. Run keyword and advanced searches with a variety of Z39.50 servers to check that searching is correct, and try to both import records as new records and substitute them for the contents of existing records. 8. Create, edit and delete macros, verifying that they are autosaved. 9. Try running macros (example follows). 10. Try enabling and disabling fixed-field widgets and customizing fonts, and test the editor afterwards. Example macro: goto field 003 copy field data insert new field 040 data= goto subfield end insert new subfield a data= goto subfield a paste -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:52:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:52:42 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #28 from Jesse Weaver --- Created attachment 27760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27760&action=edit Bug 11559 followup - Add support for XML-based fixed field widgets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:52:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:52:44 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #29 from Jesse Weaver --- Created attachment 27761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27761&action=edit Bug 11559 - QA followup: Change path to humanmsg, fix XSLT error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:54:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:54:20 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #30 from Jesse Weaver --- (In reply to Jesse Weaver from comment #29) > Created attachment 27761 [details] [review] > Bug 11559 - QA followup: Change path to humanmsg, fix XSLT error ... The commit message for this is a bit of an overstatement, this does not in fact fix the bug David reported. Which browser did you notice this bug on, though, David? The only places I can see where it should occur are IE < 9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:54:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:54:42 +0000 Subject: [Koha-bugs] [Bug 12147] Column width for action links on invoices too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 --- Comment #2 from Marc V?ron --- Created attachment 27762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27762&action=edit Bug 12147 - Column width for action links on invoices too small To test: Got to Home > Acquisitions > Invoices and verify that the last column of invoices table displays properly and, in HTML code, has a property like "style="width: 134.2px;" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:55:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:55:53 +0000 Subject: [Koha-bugs] [Bug 12147] Column width for action links on invoices too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 10:57:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 08:57:00 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:02:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:02:03 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26243|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize --- Created attachment 27763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27763&action=edit [PASSED QA] Bug 11578: Upgrade the treetable jquery plugin This patch upgrade the treetable jquery plugin to the last version (3.1.0). It is only used on the funds list view. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:02:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:02:10 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27706|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 27764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27764&action=edit [PASSED QA] Bug 11578: Improve the funds list view The current funds list view does not allow to search in the table and the ergonomics of the page is quite bad. This patch add the datatables plugin combined to the treetable plugin in order to offer a better view of the budgets/funds. Test plan: - Verify there is no regression on this page: try to add/modify/delete a fund and a budget. - Verify the funds hierarchie is correctly displayed. - Filter the funds using the branch and the budget filters. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:02:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:02:17 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27707|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 27765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27765&action=edit [PASSED QA] Bug 11578: Add some css Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:02:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:02:24 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27708|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 27766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27766&action=edit [PASSED QA] Bug 11578: Hide inactive budgets by default This patch hides inactive budgets by default. They can be shown/hidden using 2 new links "Hide/Show inactive budgets". Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:02:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:02:32 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27709|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 27767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27767&action=edit [PASSED QA] Bug 11578: Align budget names Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:02:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:02:40 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27710|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize --- Created attachment 27768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27768&action=edit [PASSED QA] Bug 11578: Hide filters if a budget (budgetperiod) is chosen If a budget_period_id is given, the filters should not be displayed. Moreover, it does not make sense to display the links for displaying/hiding inactive budgets in this case. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:02:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:02:48 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27755|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize --- Created attachment 27769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27769&action=edit [PASSED QA] Bug 11578: QA follow-up This patch removes the error raised by tt_valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt FAIL tt_valid lines 310 Actually, it fails because translate script does not match strings in attribute value. In this case, we don't want to translate. This fix is not necessary. This patch also adds the licence for the new jQuery treetable plugin. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:06:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:06:02 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #39 from Martin Renvoize --- I'm happy with this patch series now. We're passing the qa script and all tests. It's a valuable enhancement to the ergonomics of the page. Note for RM, the QA follow-up adds the library to the about page, curretly the patch claims MIT licence for the libraries, but it's available as either MIT or GPLv2. I'm no license guru, so thought I'de leave any thoughts on which we should claim to you ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:09:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:09:23 +0000 Subject: [Koha-bugs] [Bug 11763] Consolidate fund action links into menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25281|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 27770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27770&action=edit [PASSED QA] Bug 11763 - Consolidate fund action links into menu This patch moves the fund Edit/Delete/Add child links on the fund view into a pop-up menu, allow the table to be more compact and the links to be more distinct. To test you must apply the patches on Bug 11578 if necessary. Apply the patch and view the funds list page (Administration -> Funds). For each line there should be an "Actions" menu containing the Edit/Delete/Add cihld links. Each should function correctly. Test with inactive budgets shown and hidden. Signed-off-by: Jonathan Druart It is unusual to open the action list above the button, but it works. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:09:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:09:54 +0000 Subject: [Koha-bugs] [Bug 11763] Consolidate fund action links into menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- Simple patch, easy to test. No regressions. Passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:12:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:12:12 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #66 from Katrin Fischer --- It seemed to constantly happyn for me - page 10 worked, page 11 won't. Maybe if we can't display huge result sets, we need to limit the result set? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:12:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:12:36 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #67 from Katrin Fischer --- Which wouldn't be a good solution... but I think it's a problem like it is now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:42:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:42:33 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27023|0 |1 is obsolete| | Attachment #27024|0 |1 is obsolete| | --- Comment #30 from Julian Maurice --- Created attachment 27771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27771&action=edit Bug 8868: ILS-DI: CancelHold needs to take a reserve_id CancelHold takes two parameters: patron_id and item_id. If item_id is considered as an itemnumber, holds on title can't be canceled. If item_id is considered as a biblionumber, all holds on this biblionumber (for a borrower) will be canceled. So CancelHold have to consider item_id as a reserve_id. - Added subroutine C4::Reserves::GetReserve - C4::ILSDI::Services::GetRecords now returns the reserve_id - Fix the text in the ilsdi.pl?service=Describe&verb=CancelHold page - Unit tests for CancelReserved and GetReserve - Do not delete row in reserves table if insert in old_reserves fails Signed-off-by: Leila and Sonia Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:46:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:46:13 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #31 from Julian Maurice --- Squashed all patches into one. about CancelReserve changes > - it adds a return that no callers actually check It is used in tests > more importantly, it removes the code to insert the old hold into > old_reserves, which is a pretty clear regression. Are you sure ? git show -b shows me that the patch only adds an if (and the return, of course) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 11:50:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 09:50:24 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 --- Comment #32 from Julian Maurice --- (In reply to Julian Maurice from comment #31) > > more importantly, it removes the code to insert the old hold into > > old_reserves, which is a pretty clear regression. > Are you sure ? git show -b shows me that the patch only adds an if (and the > return, of course) It appears you are right, in the previous patch there was some code missing in CancelReserve. I don't know what happened, but the last patch I just submitted is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 12:33:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 10:33:56 +0000 Subject: [Koha-bugs] [Bug 12159] New: Duplicate borrower_add_additional_fields function Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Bug ID: 12159 Summary: Duplicate borrower_add_additional_fields function Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The function borrower_add_additional_fields is defined twice, and used twice, in members/pay.pl and members/paycollect.pl Perhaps fold the functionality into GetMember()? (Also take a look at tools/viewlog.pl, it does partially the same thing as borrower_add_additional_fields) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 13:04:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 11:04:44 +0000 Subject: [Koha-bugs] [Bug 12160] New: Rename intranetuserjs to IntranetUserJS Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Bug ID: 12160 Summary: Rename intranetuserjs to IntranetUserJS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com ... to match IntranetUserCSS The same should be done with opacuserjs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 13:51:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 11:51:41 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |veron at veron.ch --- Comment #6 from Marc V?ron --- This bug has a working patch but has status "NEW". Change status to "Needs signoff". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 13:55:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 11:55:30 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 --- Comment #7 from Marc V?ron --- Created attachment 27772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27772&action=edit [Signed-off] Show guarantees for staff patron details too. Staffers are adult borrowers. To test: 1) Look at a staffer's detail page. Even if he or she has guarantees, they won't show up there. 2) Install patch 3) Look at a staffer's detail page. If the staffer has guarantees, they will be shown. http://bugs.koha-community.org/show_bug.cgi?id=12132 Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 13:56:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 11:56:06 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27516|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 13:56:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 11:56:29 +0000 Subject: [Koha-bugs] [Bug 12132] Show guarantees in staff patron details too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12132 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 14:22:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 12:22:10 +0000 Subject: [Koha-bugs] [Bug 12161] New: Serials receiving is broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12161 Bug ID: 12161 Summary: Serials receiving is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Bug 12138 (Use placeholders in translatable javascript strings) broke javascript interpretation in serials-edit.tt, making serial receiving impossible when "create an item record when receiving this serial" is used for the subscription. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 14:25:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 12:25:08 +0000 Subject: [Koha-bugs] [Bug 12161] Serials receiving is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12161 --- Comment #1 from Matthias Meusburger --- Created attachment 27773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27773&action=edit proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 14:25:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 12:25:33 +0000 Subject: [Koha-bugs] [Bug 12161] Serials receiving is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12161 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 14:28:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 12:28:17 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12161 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 14:28:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 12:28:17 +0000 Subject: [Koha-bugs] [Bug 12161] Serials receiving is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12161 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7677 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 14:54:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 12:54:20 +0000 Subject: [Koha-bugs] [Bug 12161] Serials receiving is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |12138 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 14:54:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 12:54:20 +0000 Subject: [Koha-bugs] [Bug 12138] Use placeholders in translatable javascript strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12161 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 15:16:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 13:16:50 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #27 from Matthias Meusburger --- The sentence describing the point 2 is not very clear. It means that the newly received serial automatically gets its itemtype from what is defined in the subscription in the "itemtype" dropdown list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 15:19:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 13:19:27 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #28 from Matthias Meusburger --- Created attachment 27774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27774&action=edit Make the newly received serial gets its default itemtype from the subscription. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 15:20:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 13:20:00 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 15:50:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 13:50:13 +0000 Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:16:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:16:25 +0000 Subject: [Koha-bugs] [Bug 6795] Branch-specific OPAC preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6795 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Regarding branch specific CSS in Opac we could do the following: 1) Add a class="branchcode" to the body tag using the branch code, i.e something like 2) Using this class, we could style branch specific pages e.g. in OPACUserCSS: /*Background for all branches*/ body { background-color: red; } /*Yellow background and pink border for branch with code CPL*/ body.CPL { background-color: yellow; border: 10px solid pink; } /*Green background and red border for branch with code CPL*/ body.FFL { background-color: green; border: 10px solid red; } ...or a lot of other branch specific things like background images etc. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:52 +0000 Subject: [Koha-bugs] [Bug 11048] Fix logout redirection for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:52 +0000 Subject: [Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:53 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:53 +0000 Subject: [Koha-bugs] [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:53 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:53 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:54 +0000 Subject: [Koha-bugs] [Bug 11868] Multi transport types: disable sms and phone if not in use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11868 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:54 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:54 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:54 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:54 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:55 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:55 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:55 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:55 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:56 +0000 Subject: [Koha-bugs] [Bug 11635] 995$r defined twice in record.abs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:56 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:56 +0000 Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:56 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:56 +0000 Subject: [Koha-bugs] [Bug 11263] New 'locale' setting in subscriptions is not user friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:57 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:57 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:57 +0000 Subject: [Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:57 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:58 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:58 +0000 Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:58 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:59 +0000 Subject: [Koha-bugs] [Bug 11117] Right to left text in facets + facet count = mixed text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:58 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:59 +0000 Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:28:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:28:59 +0000 Subject: [Koha-bugs] [Bug 4397] display problems (umlauts, =?UTF-8?Q?=20=C3=9F?=) with scan index in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:00 +0000 Subject: [Koha-bugs] [Bug 11167] Remove memcached config from koha-conf-site.xml.in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:00 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:00 +0000 Subject: [Koha-bugs] [Bug 11763] Consolidate fund action links into menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:00 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:01 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:01 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:02 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:02 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:02 +0000 Subject: [Koha-bugs] [Bug 11287] Import borrowers doesn't take into account the new restriction system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:02 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:03 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:03 +0000 Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:03 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:04 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:03 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:04 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:05 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:05 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:06 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:06 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:07 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:07 +0000 Subject: [Koha-bugs] [Bug 7933] Fields in marc display not the same In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7933 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:07 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:08 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:08 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:08 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:09 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:09 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:10 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:10 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:10 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:11 +0000 Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for customization routine and verbose printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:11 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:11 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:12 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:12 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:14 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:12 +0000 Subject: [Koha-bugs] [Bug 11741] < > not displaying correctly in XSLT result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:13 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:13 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:29:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:29:13 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:44:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:44:31 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:47:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:47:38 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |gmcharlt at gmail.com --- Comment #31 from Galen Charlton --- I've marked this as a candidate for 3.16.0. One question: given the integration problems around pazpar2, is it possible to spit off the pazpar2 metasearch functionality, leaving the core of the editor as something that might make it in as an experimental feature for 3.16.0? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:48:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:48:22 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate --- Comment #130 from Galen Charlton --- Marking as candidate for 3.16.0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:50:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:50:29 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Marking as candidate for 3.16.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:52:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:52:38 +0000 Subject: [Koha-bugs] [Bug 11826] Improving code for XSLT handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Marking as candidate for 3.16.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:53:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:53:36 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |gmcharlt at gmail.com --- Comment #68 from Galen Charlton --- Marking as candidate for 3.16.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:55:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:55:35 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |gmcharlt at gmail.com --- Comment #42 from Galen Charlton --- Marking as a candidate for 3.16.0. Not a guarantee, however. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 16:59:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 14:59:43 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_14_candidate, | |rel_3_16_candidate | Status|Passed QA |In Discussion --- Comment #246 from Galen Charlton --- (In reply to Galen Charlton from comment #245) > While I realize that merge conflicts can be annoying for the developers, I > can at least promise as RM that I'll deal with that myself when I apply > patches that update the schema. Setting this to in discussion for future RMs to deal with. However, I strongly feel that the patch series here presents far too much risk for little gain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 17:08:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 15:08:18 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #22 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 17:11:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 15:11:57 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 17:12:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 15:12:10 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 17:49:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 15:49:42 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 18:08:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 16:08:35 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Kyle! (In reply to Katrin Fischer from comment #12) > I am not sure if the change in the label could be confusing to patrons - it > might be an idea to still show "Libraries" when only home or holding library > are displayed. I pushed a follow-up that wraps the new facet labels in spans with IDs, making it possible for folks to tweak the labels. A follow-up template change would be easy enough to make if that proves not to be sufficient. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 18:23:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 16:23:31 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #5 from Galen Charlton --- Changes to routines in C4 and Koha really ought to be accompanied by a test case. However, of more import in this particular case, I am not seeing that the new barcode parameter to transfer-slip.pl is actually getting used. Existing templates that link to transfer-slip.pl already have the itemnumber. Please advise if there is specific code available, or soon to be available, that will actually use the new parameter. Setting to in discussion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 18:52:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 16:52:13 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 --- Comment #29 from Galen Charlton --- (In reply to Jonathan Druart from comment #28) > Galen, > Does something like the last patch could be acceptable? It still makes me nervous. I suggest another alternative: don't pass the filename around at all. Instead, stick it in the user session, from where it can be retrieved if the user requests a download. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 19:14:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 17:14:05 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 --- Comment #30 from Martin Renvoize --- I'm working on a generalised file retrieval patch based upon the work initially in bug 11317.. maybe that might help here.. My idea is to add per file permissions based upon a db table of permissions. The default permission for any files would be inaccessible until confugred on a permissions page. I'll post back here once i've got something more concrete to test. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 20:03:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 18:03:18 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Galen Charlton --- Pushed to master. Thanks, Srdjan, Mark, and Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 20:31:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 18:31:18 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27673|0 |1 is obsolete| | --- Comment #43 from Bernardo Gonzalez Kriegel --- Created attachment 27779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27779&action=edit [SIGNED-OFF] Bug 5010 - Follow up: Case typographical error The call had 'OPACProtocol', but it should be 'OpacProtocol'. I am uncertain why it functioned. TEST PLAN --------- 1) Retest the sending cart from staff client. Sign comment: It works because mysql is case insensitive :) (try "select variable from systempreferences where variable like 'opac%'") Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 20:33:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 18:33:11 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #44 from Bernardo Gonzalez Kriegel --- Solved small conflicts on updatedatabse.pl, but only upload last patch signed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 21:38:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 19:38:04 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 27780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27780&action=edit Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 21:38:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 19:38:51 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #69 from Jesse Weaver --- Created attachment 27781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27781&action=edit Bug 10486 - Followup: Give more accurate results and pages count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 21:39:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 19:39:40 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27780|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 27782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27782&action=edit Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 21:40:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 19:40:37 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 21:48:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 19:48:53 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27781|0 |1 is obsolete| | --- Comment #70 from Jesse Weaver --- Created attachment 27783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27783&action=edit Bug 10486 - Followup: Give more accurate results and pages count (Featuring correct math this time.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 21:59:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 19:59:01 +0000 Subject: [Koha-bugs] [Bug 6795] Branch-specific OPAC preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6795 --- Comment #3 from Marc V?ron --- (In reply to Owen Leonard from comment #1) > The Contextual Preferences Engine? Regarding the Contextual Preferences Engine I found the following thread: http://lists.katipo.co.nz/public/koha/2012-March/032347.html -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 22:11:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 20:11:56 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- Problems to test: Bug 9016 gives merge errors, also on updatedatbase.pl (this patch), don't we need if ( CheckVersion($DBversion) ) { instead of if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 22:14:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 20:14:40 +0000 Subject: [Koha-bugs] [Bug 12162] New: Add class="branchcode" to body tag to make OPAC CSS-styleable per branch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 Bug ID: 12162 Summary: Add class="branchcode" to body tag to make OPAC CSS-styleable per branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Libraries with multiple branches should be able to change look&feel of OPAC using branch specific CSS (e.g. in in OPACUserCSS) This can be done using a branch specific class in the body tag (class="branchcode") That would be something like Using this class, we could style branch specific pages e.g. in OPACUserCSS: /*Background for all branches*/ body { background-color: red; } /*Yellow background and pink border for branch with code CPL*/ body.CPL { background-color: yellow; border: 10px solid pink; } /*Green background and red border for branch with code CPL*/ body.FFL { background-color: green; border: 10px solid red; } I did some tests as a proof of concept. Patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 22:16:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 20:16:15 +0000 Subject: [Koha-bugs] [Bug 6795] Branch-specific OPAC preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6795 --- Comment #4 from Marc V?ron --- (Regarding comment #2) I moved the idea with branch specific CSS in a separate bug. 12162 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 22:43:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 20:43:07 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 --- Comment #1 from Marc V?ron --- Created attachment 27784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27784&action=edit [Proof of concept] Bug 12162 - Add class="branchcode" to body tag to make OPAC CSS-styleable per branch This patch implements branch specific CSS for Opac Main page and OPAC Search. If the proof of concept works out, other Opac pages can be adapted. To test: Apply patch Edit system preference OPACUserCSS and insert something like /*Background for all branches*/ body { background-color: red; } /*Yellow background and pink border for branch with code CPL*/ body.CPL { background-color: yellow; border: 10px solid pink; } /*Green background and red border for branch with code FFL*/ body.FFL { background-color: green; border: 10px solid red; } Go to Opac. Switch between branches CPL and FFL, see how background color changes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:07:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:07:02 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #71 from Katrin Fischer --- Created attachment 27785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27785&action=edit [SIGNED OFF] Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC This adds a new page to the OPAC that can search several Z39.50 targets using Pazpar2. Test plan: 1) Apply patches. 2) Update database. 3) Add one or more Z39.50 targets, using the Administration -> External targets screen. Note that not all targets support keyword search, but here are some that do: * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8 * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8 4) Perform a search on the OPAC, check to see if the "external targets" notice pops up at the top. 5) Click on the results link near that message. 6) This should bring back results from all enabled targets, all of which should be clickable to bring up a detailed view of the record. (This version incorporates previous QA followups and some fixes for translation and per-branch-limiting.) Signed-off-by: Katrin Fischer Passes tests, template problem showing up in the QA should be ok. More verbose notes on the bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:07:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:07:06 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #72 from Katrin Fischer --- Created attachment 27786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27786&action=edit [SIGNED OFF] Bug 10486 followup - add tables to kohastructure.sql Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:07:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:07:13 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #73 from Katrin Fischer --- Created attachment 27787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27787&action=edit [SIGNED OFF] Bug 10486 - QA followup: fix several display issues and rebase errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:07:16 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #74 from Katrin Fischer --- Created attachment 27788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27788&action=edit [SIGNED OFF] Bug 10486 - QA followup: fix links in results and updatedatabase Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:07:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:07:20 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #75 from Katrin Fischer --- Created attachment 27789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27789&action=edit [SIGNED OFF] Bug 10486 - QA followup: incorrect diacritics Correctly asks for UTF-8 now, fixing diacritics for some targets. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:07:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:07:24 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #76 from Katrin Fischer --- Created attachment 27790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27790&action=edit [SIGNED OFF] Bug 10486 - Followup: Give more accurate results and pages count Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:13:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:13:34 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:13:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:13:37 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:13:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:13:40 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27559|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:13:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:13:42 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27756|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:13:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:13:45 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27438|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:13:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:13:48 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:13:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:13:51 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27440|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:14:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:14:33 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #77 from Katrin Fischer --- Below my notes from testing and setting this up. I have kept the paths as they are in my installation, hopefully I didn't miss a step so others can get this working as well. I am using a newer Ubuntu version, so I cheated a bit with the Apache configuration (bug 11404). Adding a first sign off to this - but I think we need a bit more testing to ensure it works alright with packages. -- Setup steps # Add indexdata repository sudo vi /etc/apt/sources.list.d/indexdata.list deb http://ftp.indexdata.dk/debian wheezy main deb-src http://ftp.indexdata.dk/debian wheezy main wget http://ftp.indexdata.dk/debian/indexdata.asc sudo apt-key add indexdata.asc sudo apt-get update # Install pazpar2 sudo apt-get purge pazpar2 sudo apt-get install pazpar2 # Activate Pazpar2 in Koha [copy koha-httpd.conf - keep changes for new Apache version around] perl Makefile.PL Install the PazPar2 configuration files? [no] yes Keep standard settings for Pazpar2, like port 11002 make sudo make install [reactivate old koha-httpd.conf # Add proxy in OPAC koha-httpd.conf AddDefaultCharset off Order deny,allow Allow from all # Change, remove xslt restart apache] #start pazpar2 server $ pazpar2 -f /home/katrin/koha-dev/etc/pazpar2/pazpar2.xml # Add external search targets in Koha SWB: z3950n.bsz-bw.de:20210/swb MARC21 utf-8 LOC: lx2.loc.gov:210/LCDB MARC21 utf-8 BNF2: z3950.bnf.fr:2211/TOUT (Z3950/Z3950_BNF) UNIMARC Yes, you can mix UNIMARC and MARC21, but BNF records are not always very pretty in the result list. # Activate system preference OPACSearchExternalTargets Testing - Search terms entered in simple search will be used to search in the external targets as well, a message on the top of the page shows the number of records found. This works * from simple search * from advanced search, only for search options, not for limits Other search options will be turned into a keyword search for the external search targets. * when no records were found locally * with local results * if search goes directly to detail page, external targets are not searched - When looking at the search, the targets are shown to the left * Unchecking and checking a target will change the result list accordingly - The result list is ordered by relevance, targets are sorted together * Results are sorted together by relevance * Only up to 100 results will be retrieved per target - When clicking on the title a modal with the record details opens * Links except for 856 are removed, to avoid non-working links back into the catalog. - Configuration * If you add a branch restriction to a target, it's only visible for users logged in at the other libraries * If you have no restriction by branch, the target will always be searched, even when not logged in Enhancement ideas: - Add a timeout like for normal targets to avoid a long wait - Lift limit on max 100 records and make that a per target setting - Add ability to use separate XSLT files, to adapt for weirdness in MARC records returned by the targets - Add the ability to generate links to the original target - right now the user is trapped in Koha. Something similar to SearchForTitleIn would be great, giving an option to define different kinds of links with placeholders. - Offer sort options other than relevance, like publication date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:17:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:17:13 +0000 Subject: [Koha-bugs] [Bug 5242] Simplify the import of members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |veron at veron.ch Resolution|--- |INVALID --- Comment #1 from Marc V?ron --- Bug is more than 3 years old and not very specific... Maybe we should have a Status RESOLVED - OUTDATED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:25:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:25:24 +0000 Subject: [Koha-bugs] [Bug 6255] patron import csv includes borrowernumber, but fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6255 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |veron at veron.ch Resolution|--- |WORKSFORME --- Comment #1 from Marc V?ron --- Can not reproduce on current master (3.15.00.038), seems to be fixed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:26:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:26:44 +0000 Subject: [Koha-bugs] [Bug 5242] Simplify the import of members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, maybe we could rephrase the title and make it 'Import patrons directly from Excel'? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:57:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:57:31 +0000 Subject: [Koha-bugs] [Bug 5242] Import patrons directly from Excel In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- Summary|Simplify the import of |Import patrons directly |members |from Excel --- Comment #3 from Marc V?ron --- Agree... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 29 23:57:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 21:57:45 +0000 Subject: [Koha-bugs] [Bug 5242] Import patrons directly from Excel In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:06:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:06:27 +0000 Subject: [Koha-bugs] [Bug 5242] Import patrons directly from Excel In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11916 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:06:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:06:27 +0000 Subject: [Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5242 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:08:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:08:10 +0000 Subject: [Koha-bugs] [Bug 6252] Patron import tool should let you set messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6252 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11916 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:08:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:08:10 +0000 Subject: [Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6252 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:09:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:09:51 +0000 Subject: [Koha-bugs] [Bug 5153] Patron Import tool does not show progress of upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5153 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11916 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:09:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:09:52 +0000 Subject: [Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5153 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:11:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:11:11 +0000 Subject: [Koha-bugs] [Bug 5242] Import patrons directly from Excel In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5242 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Now the hard work is done changing the title .. writing the patch is easy :-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:11:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:11:38 +0000 Subject: [Koha-bugs] [Bug 8291] patron import should show error names In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8291 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11916 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:11:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:11:38 +0000 Subject: [Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8291 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:11:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:11:50 +0000 Subject: [Koha-bugs] [Bug 4397] display problems (umlauts, =?UTF-8?Q?=20=C3=9F?=) with scan index in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25817|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:12:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:12:29 +0000 Subject: [Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2705 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:12:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:12:29 +0000 Subject: [Koha-bugs] [Bug 2705] Patron import should warn about invalid characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2705 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11916 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:15:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:15:16 +0000 Subject: [Koha-bugs] [Bug 12161] Serials receiving is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12161 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|major |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:15:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:15:56 +0000 Subject: [Koha-bugs] [Bug 11014] Slip Print Problem in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11014 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:16:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:16:59 +0000 Subject: [Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 --- Comment #13 from Tom?s Cohen Arazi --- Even if we provide a workaround in the packages scripts there will be problems for users until this is fixed: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=734865 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:17:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:17:00 +0000 Subject: [Koha-bugs] [Bug 12106] Capitalization: Patron Attributes on tools/patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12106 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11916 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 00:17:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 22:17:00 +0000 Subject: [Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12106 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 01:54:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Apr 2014 23:54:51 +0000 Subject: [Koha-bugs] [Bug 10791] cart image in prog & IE10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10791 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- It is very difficult to get it right for IE without breaking it in other browsers. The best workaround I found was by adding some CSS in OpacUserCSS (Tested with IE 11): ------------ /*IE-Hack*/ @media screen and (min-width:0\0) { #cartmenulink { width: 86px; text-align: center; padding-right: 0; } } #listsmenulink{ width: 40px; } ------------ For other languages the width values must be adabted, though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 02:37:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 00:37:38 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- I like this idea. It also would allow you to use jquery per branch, which I like. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 04:20:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 02:20:15 +0000 Subject: [Koha-bugs] [Bug 9048] Quote editor does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9048 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |robin at catalyst.net.nz Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz --- Comment #1 from Robin Sheat --- Confirmed. Additionally, Koha doesn't handle this very well. It just sits there rather than letting the user know something had an upset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 05:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 03:49:44 +0000 Subject: [Koha-bugs] [Bug 9048] Quote editor does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9048 --- Comment #2 from Robin Sheat --- Created attachment 27791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27791&action=edit Bug 9048 - fix quote editor under plack The ajax responder for the quote editor was using the wrong error codes. These have been fixed. Also, a small fixup to get rid of some annoying warnings. To test: * Under plack, * Add/edit/delete a quote. * Make sure that things don't crash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 05:51:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 03:51:27 +0000 Subject: [Koha-bugs] [Bug 9048] Quote editor does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9048 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Robin Sheat --- Fixed the error codes. There seems to be a bug in the JS that prevents adding quotes showing up like they've been added until you refresh. That seems to be an unrelated bug that I'll have a quick look into. Everything else works however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 06:27:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 04:27:56 +0000 Subject: [Koha-bugs] [Bug 12163] New: Adding a new quote fails Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Bug ID: 12163 Summary: Adding a new quote fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Adding a new quote doesn't work right, as there is an error in the javascript to re-draw the table row. Everything actually works, but it appears to the user as though nothing is happening. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 06:31:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 04:31:32 +0000 Subject: [Koha-bugs] [Bug 12163] Adding a new quote fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 --- Comment #1 from Robin Sheat --- Created attachment 27792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27792&action=edit Bug 12163 - fix adding new quotes Something changed somewhere (maybe a new jQuery or datatables version) and the javascript that redrew the table row after a new quote was saved stopped working. This fixes the call to the datatables function so that it matches the API. To test: * Go and add a quote. * Note that when you press enter after finishing the quote, the line stops being an editor, and becomes just a display, like it should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 06:32:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 04:32:08 +0000 Subject: [Koha-bugs] [Bug 12163] Adding a new quote fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9048 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 06:32:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 04:32:08 +0000 Subject: [Koha-bugs] [Bug 9048] Quote editor does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9048 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12163 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 06:33:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 04:33:05 +0000 Subject: [Koha-bugs] [Bug 9048] Quote editor does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9048 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored --- Comment #4 from Robin Sheat --- Marking as blocked by bug 12163, which fixes the JS issue, as this is hard to test properly without that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 06:33:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 04:33:34 +0000 Subject: [Koha-bugs] [Bug 12163] Adding a new quote fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 06:33:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 04:33:41 +0000 Subject: [Koha-bugs] [Bug 12163] Adding a new quote fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 06:45:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 04:45:03 +0000 Subject: [Koha-bugs] [Bug 12161] Serials receiving is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12161 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27773|0 |1 is obsolete| | CC| |pasi.kallinen at pttk.fi --- Comment #2 from paxed --- Created attachment 27793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27793&action=edit Fix bug introduced in bug 12138, javascript formatting Definitely my fault. Signed off that patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 07:11:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 05:11:34 +0000 Subject: [Koha-bugs] [Bug 8866] Plack - remove unneeded dbh->disconnects OMNIBUS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8866 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |robin at catalyst.net.nz --- Comment #1 from Robin Sheat --- Is there any more detail to this? A very quick search: $ ack 'dbh->disconn' shows no hits on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 07:13:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 05:13:55 +0000 Subject: [Koha-bugs] [Bug 8908] Starman/Plack hangs when faced with zombie Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8908 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #1 from Robin Sheat --- Does CGI not have this issue? Also, any ideas on how to make zebra go zombie? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 07:21:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 05:21:59 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 07:22:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 05:22:37 +0000 Subject: [Koha-bugs] [Bug 9225] Subroutines should not be defined in acqui/parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9225 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 07:26:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 05:26:49 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 07:40:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 05:40:34 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 07:52:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 05:52:35 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 07:52:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 05:52:59 +0000 Subject: [Koha-bugs] [Bug 11726] Untranslatable loading page overlay in offline circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11726 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 07:53:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 05:53:17 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |fcapovilla at live.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 07:58:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 05:58:40 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- 'new feature' is not right for the attached patches - looks more like something between a bug fix and an enh. hm. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 08:34:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 06:34:07 +0000 Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #26 from Katrin Fischer --- *** Bug 9441 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 08:34:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 06:34:07 +0000 Subject: [Koha-bugs] [Bug 9441] In OPAC, acquisition records should be signaled even if they have no item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 11169 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 08:36:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 06:36:20 +0000 Subject: [Koha-bugs] [Bug 9478] Diacritics in branchname on subscription detail page are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 08:39:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 06:39:21 +0000 Subject: [Koha-bugs] [Bug 10434] More flexibility to handle VAT / Shipping & handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10434 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Amit, can you please give a bit more information on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 08:40:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 06:40:53 +0000 Subject: [Koha-bugs] [Bug 3123] Inventory / Stocktaking template & script errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal --- Comment #1 from Katrin Fischer --- I think this needs to be retested - lots of changes in the inventory code since the bug was filed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:15:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:15:04 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #3 from paxed --- Good idea, but perhaps it should be something like class="branch-FOO", just in case the branch short name FOO would match another css class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:12 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26656|0 |1 is obsolete| | --- Comment #134 from Jonathan Druart --- Created attachment 27794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27794&action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:17 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26657|0 |1 is obsolete| | --- Comment #135 from Jonathan Druart --- Created attachment 27795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27795&action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:20 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26658|0 |1 is obsolete| | --- Comment #136 from Jonathan Druart --- Created attachment 27796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27796&action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:24 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26659|0 |1 is obsolete| | --- Comment #137 from Jonathan Druart --- Created attachment 27797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27797&action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:28 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26660|0 |1 is obsolete| | --- Comment #138 from Jonathan Druart --- Created attachment 27798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27798&action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:32 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26661|0 |1 is obsolete| | --- Comment #139 from Jonathan Druart --- Created attachment 27799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27799&action=edit Bug 9016: QA Followup Fix tab characters and POD. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:36 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26662|0 |1 is obsolete| | --- Comment #140 from Jonathan Druart --- Created attachment 27800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27800&action=edit Bug 9016: Fix some translate issues On tools/letter.pl and tools/overduerules.pl, some strings were not translatable. This patch should fix that. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:39 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26663|0 |1 is obsolete| | --- Comment #141 from Jonathan Druart --- Created attachment 27801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27801&action=edit Bug 9016 [QA Followup] - Add insertAtCaret library to about page Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:43 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26664|0 |1 is obsolete| | --- Comment #142 from Jonathan Druart --- Created attachment 27802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27802&action=edit Bug 9016: (follow-up) qa fixes * Fixes POD of GetMessageTransportTypes. * Removes the useless map in GetMessageTransportTypes. * Textual: "You must specify a title and a content" -> "Please specify title and content". * Reintroduces << and >> around the field name. * Change message for the update DB entry. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:47 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26665|0 |1 is obsolete| | --- Comment #143 from Jonathan Druart --- Created attachment 27803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27803&action=edit Bug 9016: FIX GetLetters should return all letters GetLetters only returns letters with a mtt = email. It should return all letter codes in the DB. The message_transport_type parameter is never used. To reproduce the issue: Create a notice with a sms template and no email template. Go on the overdue rules configucation page. The notice does not appear in the notice list. Signed-off-by: Olli-Antti Kivilahti --------------- Testing report: --------------- Testing this subroutine from a test stub. Calling the method without arguments and with argument 'circulation' and 'circulat'. Works as supposed to. Related Bug 11931 discovered but not within the scope of this featureset. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:51 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26666|0 |1 is obsolete| | --- Comment #144 from Jonathan Druart --- Created attachment 27804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27804&action=edit Bug 9016: FIX additional mtt's name should be displayed in header if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. Signed-off-by: Olli-Antti Kivilahti Yes sir works great! Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:55 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26667|0 |1 is obsolete| | --- Comment #145 from Jonathan Druart --- Created attachment 27805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27805&action=edit Bug 9016: FIX letter name is not displayed on editing a letter On editing a letter, the letter name is not displayed. So if you save it, the letter name is erased with an empty string. Signed-off-by: Olli-Antti Kivilahti Tested by setting the "Name"-field in letter.pl, saving, re-editing and verifying that the email is present in the letter's "Name"-field. The letter "Name" is replicated for each template in the DB, but that doesn't incur any performance penalty. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:27:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:27:58 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26668|0 |1 is obsolete| | --- Comment #146 from Jonathan Druart --- Created attachment 27806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27806&action=edit Bug 9016: (followup) FIX letter name is not displayed on editing a letter If the name is not in email, the name is not correctly retrieved. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:28:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:28:02 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26670|0 |1 is obsolete| | --- Comment #147 from Jonathan Druart --- Created attachment 27807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27807&action=edit Bug 9016: Add some validation on the letter form 1/ Code and Name are mandatory. 2/ At least 1 template should be filled on saving. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:28:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:28:06 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26672|0 |1 is obsolete| | --- Comment #148 from Jonathan Druart --- Created attachment 27808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27808&action=edit Bug 9016: Improve number of characters display when mtt=sms Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:28:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:28:10 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26673|0 |1 is obsolete| | --- Comment #149 from Jonathan Druart --- Created attachment 27809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27809&action=edit Bug 9016: [QA Follow-up] Remove warning from content.length test If the letter.content is undef, the content.length test in the letter template will trigger warning: Argument "" isn't numeric in numeric gt (>). This patch eliminates that warning. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:28:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:28:39 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #150 from Jonathan Druart --- Last patches fix conflict with bug 11497. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:29:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:29:43 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #7 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #6) Bug 9016 rebased against master. This patch applies cleanly on top of bug 9016 and bug 10845. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:34:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:34:19 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11317 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:34:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:34:19 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5771 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 09:56:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 07:56:25 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 --- Comment #4 from Marc V?ron --- (In reply to paxed from comment #3) > Good idea, but perhaps it should be something like class="branch-FOO", just > in case the branch short name FOO would match another css class. Good point! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 10:14:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 08:14:27 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #9 from paxed --- Koha › Members › Print receipt for [%- borrowernumber -%] The [%- will eat away the space between the "for" and the borrowernumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 10:23:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 08:23:54 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #37 from Jonathan Druart --- (In reply to Katrin Fischer from comment #35) Helle Katrin, > Starting with some initial testing and notes on this: > > 1) I am not sure the 2 specialiced subroutines for getting the > columns from items and biblioitems are needed - couldn't this > be done in ToggleNewStatus with DBIC? Right now it seems like > the patch is using a mix of old and new (see comment 18 from Kyle). There are 2 calls, 1 in C4::Items::ToggleNewStatus and 1 in the pl script. I don't think it is a good idea to call DBIC directly in pl files. > 2) The 'new' column > In comment 19 you said the goal of the cronjob was to remove the > new flag. > I am unsure if I see the use of the new field in the code and the > feature. To me it seems just like a new 'notes' field, that is not > really accessible without further configuration. As I tried to explain in the commit message, this feature allows to manage new items as you want. There is no restriction or a "way todo". I listed test case examples, it is how we use this field at BibLibre. This patch is an "introduction" to the idea of manage a "new" status. > a) In order to be able to set the field, you need to add a Koha-2- > MARC-Mapping and change the bibliographic frameworks. Only then > you will be able to catalog it. The field won't be searchable > as there is no index on it. If we want to add an index later, this > will be difficult, as we can't tell which mappings people will > have used. > How will libraries learn about the existance of the new > column? Reading the changelog? > b) For a general purpose field varchar(32) seems a bit limited. In a lot of cases, we used it as a boolean, so it is enough. What do you suggest, VARCHAR(64), TEXT,...? > c) It seems the feature is independend on the existance of the new > column. The central column for the feature seems to be the > existing dateaccessioned column instead. > With the implications of a) I am not sure we should include the > 'new' from the beginning without having a clearer definition > on how to use it. This field is important for the workflow of our users, it is part of the feature. > 4) Features in documentation > I think the documentation lists features more like in an ad, than > like in a help file. Sorry, it was not the expected goal. > It's not clear to the reader, how to achieve > the described functionality. That's what I have come up with: > > +
  • know easily what are the new items in the catalogue.
  • > > This still requires SQL, so doesn't seem to depend on the feature. It depends on the "new" field, so it depends on this feature, no? > +
  • display an icon in the search results for new items.
  • > > The only way to do this I can come up with is limited to libraries > using biblio level itypes and by switching the itemtype with the > script. Yes, it is one of the purpose of it. > +
  • configure issuing rules depending the 'new' status.
  • > > I think this would also require switching the itemtype? Yes. > +
  • get a RSS/Atom feeds on these new items.
  • > > I think this would require using a special value in an item > column that is searchable with Zebra. So you can build a search in > Zebra that can then be used for the RSS feed? I don't know how they do that, maybe using a sql query. > 4) biblioitems > > a) I am worried about some columns that should not be substituted: > biblionumber, itemnumber, barcode, totalissues, onloan ... > I think those are potentially dangerous and should not be listed. It is a cronjob script, all of them should be used with full knowledge of the facts. I think it is easier/better to list all fields rather than to limit the possibilities. > b) To me it seems like the only goal of including biblioitems is > the possibility to change the bibliotitems itemtype. As it is now, > it also allows changing values like title, pages, etc. which > borders on a record batch edit. To me this seems a bit misplaced > here. > Also, ToggleNewStatus seems to only do ModItem - but you can > define substitutions for biblioitems? (see also 6) It seems only conditions on biblioitems have been tested, we don't use biblioitems for substitutions. I will provide a patch to remove the biblioitems fields in the substitution list. > 5) GUI > > a) It's not possible to edit a single rule. In order to add a rule > or edit a rule, you always have to use 'Edit' and then all rules > will display, the form for adding the new rule is at the very > bottom. It is not very comfortable. What do you suggest? I tried to do something ergonomic with a quite complicated form. With the actual way, if you have to add several rules, it is useless to save after adding each one, but only once at the end. I chose to edit all rules on the same screen, because they are stored in a syspref and I would prefer not to parse the pref to update the rules. > b) There are no mandatory fields, duration is optional, as are > conditions and substitions. So you can define an empty rule. Yes, it could be possible if you want to mark all items as new. I really want to avoid a long list of follow-ups. I don't want to add all requests in this report. If some reports are opened and linked to this one, and they are relevant, I will provide a patch. Originally, this feature was something like http://git.biblibre.com/?p=koha;a=blob;f=misc/cronjobs/toggle_new_status.pl;h=5acad013fac5bbbe22d17dab4369f99e28dd93e3;hb=8aa5f86906774da52bd317acef4131d9142c2431 We decided to submit something more flexible and more complete for the community, in order to open the possibilities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 10:31:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 08:31:44 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #38 from Jonathan Druart --- Created attachment 27810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27810&action=edit Bug 11023: Don't use the biblioitems fields for the subtitution It's dangerous to allow a change on the biblioitems fields with this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 11:43:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 09:43:55 +0000 Subject: [Koha-bugs] [Bug 2081] Unable to edit an authorised value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2081 rinku changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rinku7134 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 11:49:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 09:49:07 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 --- Comment #5 from Marc V?ron --- Created attachment 27811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27811&action=edit Bug 12162 - Add class="branchcode" to body tag to make OPAC CSS-styleable per branch This patch implements branch specific CSS for Opac Main page and OPAC Search. If the proof of concept works out, other Opac pages can be adapted. To test: Apply patch Edit system preference OPACUserCSS and insert something like /*Background for all branches*/ body { background-color: red; } /*Yellow background and pink border for branch with code CPL*/ body.branch-CPL { background-color: yellow; border: 10px solid pink; } /*Green background and red border for branch with code FFL*/ body.branch-FFL { background-color: green; border: 10px solid red; } Go to Opac. Switch between branches CPL and FFL, see how background color changes... Changes to previous patch: New version using branch-FOO as class name. Prog theme added for this proof of concept. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 11:50:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 09:50:11 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 12:07:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 10:07:31 +0000 Subject: [Koha-bugs] [Bug 563] Keyword search does not search author names In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=563 rinku changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED CC| |rinku7134 at gmail.com Resolution|FIXED |--- Assignee|chris at bigballofwax.co.nz |rinku7134 at gmail.com --- Comment #1 from rinku --- Created attachment 27812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27812&action=edit unable to search author in koha 3.14 whenever i search for any author it won't show anything.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 12:16:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 10:16:07 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #40 from Jonathan Druart --- Created attachment 27813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27813&action=edit Bug 11578: FIX show inactive link Before this patch, the inactive funds were displayed by default. The active funds should be displayed by default. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 12:16:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 10:16:11 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #41 from Jonathan Druart --- Created attachment 27814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27814&action=edit Bug 11578: FIX funds grouping The datatables sort options were wrong. The funds for a budget could be ungrouped. To reproduce: - Create 3 budgets A, B, C. - Create 1 or more funds for A, B, C - Mark B and C as inactive. - Create another fund for A - Go on the fund list view, click on "show inactive funds" => The last fund is not grouped without other funds of budget A. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 12:17:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 10:17:09 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #42 from Jonathan Druart --- I found 2 new (small but annoying) bugs. I fixed them in 2 last patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 12:20:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 10:20:30 +0000 Subject: [Koha-bugs] [Bug 563] Keyword search does not search author names In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi rinku, the authorities search will only search in authorities, which are totally separate from your bilbiographic records and the authors there. They are also separately indexed. I think this is not a problem in Koha, but might be a misunderstanding or indexing problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 12:21:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 10:21:50 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27814|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart --- Created attachment 27815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27815&action=edit Bug 11578: FIX funds grouping The datatables sort options were wrong. The funds for a budget could be ungrouped. To reproduce: - Create 3 budgets A, B, C. - Create 1 or more funds for A, B, C - Mark B and C as inactive. - Create another fund for A - Go on the fund list view, click on "show inactive funds" => The last fund is not grouped without other funds of budget A. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 12:28:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 10:28:54 +0000 Subject: [Koha-bugs] [Bug 563] Keyword search does not search author names In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 12:35:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 10:35:49 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #44 from Jonathan Druart --- Created attachment 27816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27816&action=edit Bug 11578: FIX budgets grouping If 2 budgets (budget periods) have the same description, the funds will be grouped into the same "block". This patch adds a distinction adding the id of the budget next to the description. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 12:46:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 10:46:41 +0000 Subject: [Koha-bugs] [Bug 3092] Data values storage and use 100 bug meta-bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3092 rinku changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rinku7134 at gmail.com Assignee|frederic at tamil.fr |rinku7134 at gmail.com --- Comment #3 from rinku --- Created attachment 27817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27817&action=edit unable to search previously added author in koha 3.14 whenever i am cataloging i want to search all previously added authors in my database . But it is not reflecting any search search results. I have to create always new authority that results into duplicate authors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 13:00:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 11:00:05 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27782|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 27818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27818&action=edit Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 13:00:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 11:00:45 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #11 from Bernardo Gonzalez Kriegel --- (In reply to paxed from comment #9) > Koha › Members › Print receipt for [%- borrowernumber > -%] > > The [%- will eat away the space between the "for" and the borrowernumber. Thanks, now is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 13:58:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 11:58:46 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 14:05:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 12:05:33 +0000 Subject: [Koha-bugs] [Bug 3092] Data values storage and use 100 bug meta-bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Rinku, please be careful, I think this was supposed to go on another bug. You have to make sure your authorities are indexed. It depends a bit on how you installed Koha - I think mailing the mailing list with your problem would be better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 14:54:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 12:54:49 +0000 Subject: [Koha-bugs] [Bug 12164] New: Rollover outstanding orders not yet received Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Bug ID: 12164 Summary: Rollover outstanding orders not yet received Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org There is no way within acquisitions to rollover outstanding orders not yet received at the end of a fiscal year to the next fiscal year/cycle. This new feature will allow to move orders not received and the amounts encumbered/spent from the old/previous fiscal year into the new fiscal year. Coming soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 14:55:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 12:55:01 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 15:03:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 13:03:27 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 16:25:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 14:25:40 +0000 Subject: [Koha-bugs] [Bug 9225] Subroutines should not be defined in acqui/parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9225 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 16:27:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 14:27:19 +0000 Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 16:28:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 14:28:49 +0000 Subject: [Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 16:29:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 14:29:22 +0000 Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 16:31:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 14:31:02 +0000 Subject: [Koha-bugs] [Bug 10465] Reference to fields 780 and 785 in UNIMARC XSLT should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11246 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 16:31:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 14:31:02 +0000 Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785 in UNIMARC XSLT should be removed in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Depends on| |10465 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 16:31:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 14:31:41 +0000 Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785 in UNIMARC XSLT should be removed in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 16:48:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 14:48:07 +0000 Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from "Search the catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 17:08:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 15:08:34 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #25 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 17:45:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 15:45:35 +0000 Subject: [Koha-bugs] [Bug 12163] Adding a new quote fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 17:45:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 15:45:37 +0000 Subject: [Koha-bugs] [Bug 12163] Adding a new quote fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27792|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 27819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27819&action=edit Bug 12163 - fix adding new quotes Something changed somewhere (maybe a new jQuery or datatables version) and the javascript that redrew the table row after a new quote was saved stopped working. This fixes the call to the datatables function so that it matches the API. To test: * Go and add a quote. * Note that when you press enter after finishing the quote, the line stops being an editor, and becomes just a display, like it should. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 18:00:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 16:00:17 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25761|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 27820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27820&action=edit [SIGNED-OFF] Bug 11867: MTT: Manage *_PHONE notices The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE). Test plan: 1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices 2/ Execute the update DB entry 3/ Verify the 3 notices have been merged into "phone" template of the HOLD, PREDUE and OVERDUE notices 4/ Verify there is no regression in the Talking Tech feature (how?) Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors Verified that notices are merged TalkingTech_itiva_outbound.pl runs without problem... but can't produce any output, may be not correctly configured (my setup), no warnings nor log messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 18:00:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 16:00:34 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 18:25:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 16:25:46 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |gmcharlt at gmail.com --- Comment #262 from Galen Charlton --- The first patch no longer applies, and the conflict doesn't appear non-trivial to resolve. Jonathan, please feel free to set status back to passed QA after you resolve the merge conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 18:34:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 16:34:45 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #18 from Galen Charlton --- Pushed to master. Thanks, Adrien and Christophe! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 19:15:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 17:15:23 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Galen Charlton --- Pushed to master, along with a follow-up that fixes various issues preventing the payment type from being recording correctly and avoiding a regression on bug 2546. Thanks, Ian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 19:41:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 17:41:59 +0000 Subject: [Koha-bugs] [Bug 12165] New: Add description of charges (bug 2546) to Bootstrap OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Bug ID: 12165 Summary: Add description of charges (bug 2546) to Bootstrap OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr It looks like we forgot to fix the bootstrap templates in bug 2546: Copying test plan from the other bug: The descriptions for charges are stored in English in the DB (accountlines.description). So they are not translatable. This patch removes the descriptions automatically added and generates the string in the template. Test plan: 1/ Execute the updatedatabase entry. 2/ Verify in the following pages the description is consistent: - members/pay.pl?borrowernumber=XXXX - members/boraccount.pl?borrowernumber=XXXX - opac-account.pl 3/ Launch the translate script and update the po files in order to translate the new strings. 4/ Verify the strings are translated in the interface. The database bits for this are done, we only need to update the templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 19:42:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 17:42:30 +0000 Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12165 --- Comment #16 from Katrin Fischer --- It looks like this needs a follow up for bootstrap! (bug 12165) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 19:42:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 17:42:30 +0000 Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2546 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 19:43:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 17:43:58 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #295 from Galen Charlton --- Note that the push of bug 6273 adds (at least) three potential payment types to deal with: Pay00 - SIP2 cash payment Pay01 - SIP2 VISA payment Pay02 - SIP2 credit card payment Of course, it wouldn't be surprising if there are SIP2 devices that define non-standard payment types as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 19:56:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 17:56:42 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #75 from Galen Charlton --- (In reply to Katrin Fischer from comment #74) > I am still a bit torn about this patch and the new column. I think we need a > follow up to clean up the sample files at least. > Also the new field being mandatory means that you are forced to fill it in > on editing now, but I see no way to get around that. Does it really need to > be mandatory? I don't think it needs to be mandatory, and I also think that if isocode is null, that it would be reasonable to fall back to checking for the main currency code/name (currency.currency) when parsing the prices. I'm willing to deal with that as an RM follow-up, but I would appreciate confirmation from the patch submitter that there's no issue with my proposed change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 19:58:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 17:58:46 +0000 Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 --- Comment #1 from Galen Charlton --- Note that comments on bug 9593, there's a question as to whether currency.isocode should be made mandatory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 20:00:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 18:00:25 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #76 from Galen Charlton --- (In reply to Kyle M Hall from comment #68) > I could easily see the > Currency being "Brazilian real" while the ISO code would be "BRL". Note that currency.currency is only a varchar(10). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 20:56:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 18:56:16 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 20:59:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 18:59:17 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #87 from Brendan Gallagher --- Hello Colin - I was wondering on the status of this and if you all have had a chance to post some newer code up here soon? Thanks much, Brendan (In reply to Colin Campbell from comment #85) > I'm working on generating a usable patch set for people to test from this > and some custom scripts. The edifact parsing is effectively done (for a very > limited number of vendors). It needs to be made into something that fits > cleanly with Koha. > > In practice for those Koha sites using EDI in the UK the process is largely > one of transferring incoming quotes and invoices and sending orders by > ftp/sftp. (one gets the impression that the vendors edi side is not very > automated). > > The impact on Koha's work flow is minimal we need to store vendor edi > account details (a vendor may have multiple edi 'accounts' ) and the > corresponding library side accounts. > > In the normal acq workflow the addition would be an option to send an > order_basket by edi if the vendor is edi_enabled Otherwise there need to be > batch scripts to handle transferring data from the vendor and loading that > into Koha. > > I dont know if people are envisioning other workflows, if so please post > details against this bug. > > Hope to post with tests and documentation as a working beast soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 21:17:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 19:17:42 +0000 Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 21:17:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 19:17:44 +0000 Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 --- Comment #1 from Katrin Fischer --- Created attachment 27821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27821&action=edit Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 21:25:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 19:25:33 +0000 Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 21:38:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 19:38:59 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #10 from Katrin Fischer --- The third patch on this patch set does not apply, and also has some problems. - capitalization, not including OPAC templates. I'd suggest we split this up into some smaller steps. Starting with fixing the rentals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 22:43:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 20:43:18 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25715|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Comment on attachment 25715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25715 Followup Bug-11573-display-derived-account-fines-tab-description Obsoleting here - moving it to another bug later. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 22:50:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 20:50:10 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12165 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 30 22:50:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Apr 2014 20:50:10 +0000 Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11573 -- You are receiving this mail because: You are watching all bug changes.