[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 1 12:20:44 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #30 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 26718
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26718
bug_11213: Use branch codes from the database rather than hardcoded CPL and MPL

Review of attachment 26718:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11213&attachment=26718)
-----------------------------------------------------------------

::: t/db_dependent/Items.t
@@ +29,5 @@
>  }
>  
>  my $dbh = C4::Context->dbh;
> +my $branches = GetBranches;
> +my ($branch1, $branch2) = keys %$branches;

I like the idea, but you are missing a check to make sure they are defined. And
if they aren't, you need to temporarily add them and then roll them back.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list