[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #31 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to M. Tompsett from comment #30)
> Comment on attachment 26718 [details] [review]
> bug_11213: Use branch codes from the database rather than hardcoded CPL and
> MPL
> 
> Review of attachment 26718 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: t/db_dependent/Items.t
> @@ +29,5 @@
> >  }
> >  
> >  my $dbh = C4::Context->dbh;
> > +my $branches = GetBranches;
> > +my ($branch1, $branch2) = keys %$branches;
> 
> I like the idea, but you are missing a check to make sure they are defined.
> And if they aren't, you need to temporarily add them and then roll them back.

That's true, however it is not worse then it used to be. Former test depended
on having CPL and MPL branches, this one depends on having *any* two branches,
thus is more permissive. I'm happy to drop the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.