[Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 26559
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26559
Bug 11995: Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl

Review of attachment 26559:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11995&attachment=26559)
-----------------------------------------------------------------

::: misc/cronjobs/serialsUpdate.pl
@@ +110,4 @@
>  while ( my $issue = $sth->fetchrow_hashref ) {
>  
>      my $subscription = &GetSubscription( $issue->{subscriptionid} );
> +    my $publisheddate  = $issue->{publisheddate};

What is the difference between publisheddate and planneddate? This is the only
thing holding me back from signing off.

@@ +114,3 @@
>  
> +    if ( $subscription && $publisheddate && $publisheddate ne "0000-00-00" ) {
> +        my $nextpublisheddate = GetNextDate( $subscription, $publisheddate );

Yikes! Swapping parameter order is kind of important in non-hashref parameter
lists. Good thing you are fixing this. :)

-- 
You are receiving this mail because:
You are watching all bug changes.