[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

--- Comment #60 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 13018
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13018
Bug 6030 [3.8.x] Allow html content in letters

Review of attachment 13018:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6030&attachment=13018)
-----------------------------------------------------------------

::: misc/cronjobs/overdue_notices.pl
@@ +344,4 @@
>  
>  our $csv;       # the Text::CSV_XS object
>  our $csv_fh;    # the filehandle to the CSV file.
> +if ( $csvfilename ) {

No, because the file name could be "0". Old code is better.

@@ +563,4 @@
>                              email          => $email,
>                              itemcount      => $itemcount,
>                              titles         => $titles,
> +                            outputformat   => $csvfilename ? 'csv' : defined $htmlfilename ? 'html' : '',

This nested mess should be made clearer elsewhere. And no, defined $csvfilename
should be used.

@@ +591,4 @@
>                                  email          => $email,
>                                  itemcount      => $itemcount,
>                                  titles         => $titles,
> +                                outputformat   => $csvfilename ? 'csv' : defined $htmlfilename ? 'html' : '',

This nested mess should be made clearer elsewhere. And no, defined $csvfilename
should be used.

@@ +602,4 @@
>      }
>  
>      if (@output_chunks) {
> +        if ( $csvfilename ) {

This nested mess should be made clearer elsewhere. And no, defined $csvfilename
should be used.

-- 
You are receiving this mail because:
You are watching all bug changes.